Page MenuHomePhabricator
Feed Advanced Search

Fri, Sep 23

psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@aeubanks Thank you very much for the re-landing.

Fri, Sep 23, 6:43 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 12

psamolysov abandoned D133351: [NFC][ScheduleDAG] Code cleanup for ScheduleDAGRRList.cpp.

@fhahn Thank you very much for the suggestion. I've extracted some making sense changes from the patch (using Register instead of unsigned, some C++17-fication, and using references in iterating over the collections in the foreach loops) and committed them in LLVM w/o review because those patches are very small and NFC. This review can be marked as abandoned.

Mon, Sep 12, 8:12 AM · Restricted Project, Restricted Project
psamolysov committed rGf045d0c3921e: [NFC][ScheduleDAG] Use a reference to iterate over NodeSuccs/ChainSuccs (authored by psamolysov).
[NFC][ScheduleDAG] Use a reference to iterate over NodeSuccs/ChainSuccs
Mon, Sep 12, 5:55 AM · Restricted Project, Restricted Project
psamolysov committed rG05946c144dc6: [NFC][ScheduleDAG] Use structure bindings and emplace_back (authored by psamolysov).
[NFC][ScheduleDAG] Use structure bindings and emplace_back
Mon, Sep 12, 5:55 AM · Restricted Project, Restricted Project
psamolysov committed rG354a3d9c023e: [NFC][ScheduleDAG] Use Register and MCPhysReg instead of unsigned (authored by psamolysov).
[NFC][ScheduleDAG] Use Register and MCPhysReg instead of unsigned
Mon, Sep 12, 5:18 AM · Restricted Project, Restricted Project

Tue, Sep 6

psamolysov requested review of D133351: [NFC][ScheduleDAG] Code cleanup for ScheduleDAGRRList.cpp.
Tue, Sep 6, 6:30 AM · Restricted Project, Restricted Project

Thu, Sep 1

psamolysov committed rG527b9a9d908f: [DeadArgElim] Use structure bindings in foreach loops. NFC (authored by psamolysov).
[DeadArgElim] Use structure bindings in foreach loops. NFC
Thu, Sep 1, 3:49 AM · Restricted Project, Restricted Project
psamolysov closed D133026: [DeadArgElim] Use structure bindings in foreach loops. NFC.
Thu, Sep 1, 3:49 AM · Restricted Project, Restricted Project
psamolysov added a comment to D133026: [DeadArgElim] Use structure bindings in foreach loops. NFC.

@nlopes Thank you for the information. I've opened the review to get whether this kind of c++17tion makes any sense at all.

Thu, Sep 1, 2:07 AM · Restricted Project, Restricted Project

Wed, Aug 31

psamolysov requested review of D133026: [DeadArgElim] Use structure bindings in foreach loops. NFC.
Wed, Aug 31, 8:10 AM · Restricted Project, Restricted Project

Aug 30 2022

psamolysov committed rG88581db62f55: [LazyCallGraph] Reformat the code in accordance with the code style. NFC (authored by psamolysov).
[LazyCallGraph] Reformat the code in accordance with the code style. NFC
Aug 30 2022, 1:07 AM · Restricted Project, Restricted Project
psamolysov closed D132806: [LazyCallGraph] Reformat the code in accordance with the code style. NFC.
Aug 30 2022, 1:07 AM · Restricted Project, Restricted Project
psamolysov added a comment to D132806: [LazyCallGraph] Reformat the code in accordance with the code style. NFC.

@aeubanks Oh, thank you for the comment. I tried to explicitly define EXPENSIVE_CHECK at the beginning of the LazyCallGraph.cpp file and LLVM has successfully been built. So, I've landed the patch.

Aug 30 2022, 1:07 AM · Restricted Project, Restricted Project

Aug 28 2022

psamolysov updated the diff for D132806: [LazyCallGraph] Reformat the code in accordance with the code style. NFC.

More structure bindings have been inserted in the foreach loops. Also, some inserts to maps were replaced with the try_emplace operations in order to eliminate redundant copies of pairs (but as I see those pairs are small enough but "no-copy" is better than "copy" even whenever this "no-copy" is for free).

Aug 28 2022, 10:54 PM · Restricted Project, Restricted Project
psamolysov added a comment to D132806: [LazyCallGraph] Reformat the code in accordance with the code style. NFC.

@aeubanks Thank you for the review. This patch doesn't remove any asserts just reformats them. At least it should...

Aug 28 2022, 10:50 PM · Restricted Project, Restricted Project
psamolysov requested review of D132806: [LazyCallGraph] Reformat the code in accordance with the code style. NFC.
Aug 28 2022, 3:04 AM · Restricted Project, Restricted Project
psamolysov committed rGb10a341aa5b0: [Pipelines] Introduce DAE after ArgumentPromotion (authored by psamolysov).
[Pipelines] Introduce DAE after ArgumentPromotion
Aug 28 2022, 12:51 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov closed D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Aug 28 2022, 12:51 AM · Restricted Project, Restricted Project, Restricted Project

Aug 27 2022

psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@aeubanks Thank you for the investigation! I believe this patch can be re-landed after D132764 is committed.

Aug 27 2022, 12:01 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov accepted D132764: [LazyCallGraph] Update libcall list when replacing a libcall node's function.

@aeubanks Thank you very much for the fix! I tried the cases described in D128830 and to run the new test Analysis/LazyCallGraph/replace-libcall.ll. On my environment, everything works fine, so I accept the revision.

Aug 27 2022, 12:01 AM · Restricted Project, Restricted Project

Aug 26 2022

psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

No problem, I've reverted the commit while I need some time to build clang with the reverted commit even to make it clear the commit is guilty.

Aug 26 2022, 3:45 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a reverting change for rG879f5118fc74: [Pipelines] Introduce DAE after ArgumentPromotion: rGf964417c32d0: Revert "[Pipelines] Introduce DAE after ArgumentPromotion".
Aug 26 2022, 3:43 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov committed rGf964417c32d0: Revert "[Pipelines] Introduce DAE after ArgumentPromotion" (authored by psamolysov).
Revert "[Pipelines] Introduce DAE after ArgumentPromotion"
Aug 26 2022, 3:43 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a reverting change for D128830: [Pipelines] Introduce DAE after ArgumentPromotion: rGf964417c32d0: Revert "[Pipelines] Introduce DAE after ArgumentPromotion".
Aug 26 2022, 3:43 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@mstorsjo Thank you very much for the information. Unfortunately, our tests didn't catch this problem.

Aug 26 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2022

psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Colleagues, thank you for the discussion.

Aug 25 2022, 12:57 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov committed rG879f5118fc74: [Pipelines] Introduce DAE after ArgumentPromotion (authored by psamolysov).
[Pipelines] Introduce DAE after ArgumentPromotion
Aug 25 2022, 12:56 AM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2022

psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

I tried to triage a bit. The test lldb\test\API\functionalities\unused-inlined-parameters\TestUnusedInlinedParameters.py compiles the code in main.c with -O1 and generates the following IR for the @f function:

Aug 24 2022, 3:13 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@Michael137 Thank you very much for the information!

Aug 24 2022, 2:45 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a reverting change for rG3f20dcbf708c: [Pipelines] Introduce DAE after ArgumentPromotion: rG6703ad1e0c2a: Revert "[Pipelines] Introduce DAE after ArgumentPromotion".
Aug 24 2022, 2:45 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov committed rG6703ad1e0c2a: Revert "[Pipelines] Introduce DAE after ArgumentPromotion" (authored by psamolysov).
Revert "[Pipelines] Introduce DAE after ArgumentPromotion"
Aug 24 2022, 2:44 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a reverting change for D128830: [Pipelines] Introduce DAE after ArgumentPromotion: rG6703ad1e0c2a: Revert "[Pipelines] Introduce DAE after ArgumentPromotion".
Aug 24 2022, 2:44 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@aeubanks Thank you very much for the benchmark results and patch review. I've landed the patch.

Aug 24 2022, 12:44 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov committed rG3f20dcbf708c: [Pipelines] Introduce DAE after ArgumentPromotion (authored by psamolysov).
[Pipelines] Introduce DAE after ArgumentPromotion
Aug 24 2022, 12:38 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov closed D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Aug 24 2022, 12:38 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2022

psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

... but let me run some internal benchmarks on this patch

Aug 18 2022, 11:44 PM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

psamolysov added inline comments to D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.
Jul 19 2022, 5:00 AM · Restricted Project, Restricted Project, debug-info
psamolysov added inline comments to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Jul 19 2022, 5:00 AM · Restricted Project, Restricted Project, debug-info

Jul 13 2022

psamolysov added inline comments to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Jul 13 2022, 3:46 AM · Restricted Project, Restricted Project, debug-info

Jul 12 2022

psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Return the PostOrderFunctionAttrsPass pass back on its original place in the pipeline.

Jul 12 2022, 1:40 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@aeubanks Hmm, if I correctly get your comment, I should revert this patch to the state before the proposed solution with moving the PostOrderFunctionAttrsPass at the end of the buildInlinerPipeline function regardless of the readonly instead of readnone regression. Personally along with your concern about compilation time, I have a concern about some changing in coroutines compilation, the Clang :: CodeGenCoroutines/coro-elide.cpp test demonstrates them:

Jul 12 2022, 1:37 AM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

[Pipelines] Fix the Clang :: CodeGenCoroutines/coro-elide.cpp

Jul 11 2022, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@aeubanks Thank you for the great explanation.

Jul 11 2022, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2022

psamolysov added inline comments to D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.
Jul 7 2022, 11:38 PM · Restricted Project, Restricted Project, debug-info

Jul 6 2022

psamolysov added inline comments to D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.
Jul 6 2022, 6:20 AM · Restricted Project, Restricted Project, debug-info

Jun 30 2022

psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Fix Clang :: CodeGen/thinlto-distributed-newpm.ll

Jun 30 2022, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Try to remove the DAE from the original point. Also, apply the suggestion from @nikic - make the DAE a part of the normal module optimization pipeline (post module simplification).

Jun 30 2022, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Do we need to retain the run of DeadArgumentEliminationPass in the original position or is a single run at the new position sufficient?

Jun 30 2022, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added inline comments to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 30 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added inline comments to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 30 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Actualize the new PM tests.

Jun 30 2022, 5:17 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov planned changes to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

A number of tests failed, I'm going to fix them ASAP.

Jun 30 2022, 4:54 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Add a PhaseOrdering test to show how the patch affects dead argument elimination after argument promotion.

Jun 30 2022, 3:13 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the summary of D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 30 2022, 3:12 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

There should be a PhaseOrdering test that shows that the argument is not removed in the current opimization pipeline.

Jun 30 2022, 3:11 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov committed rG3b7650da725c: [Pipelines] Add a test how DCE works after ArgumentPromotion (authored by psamolysov).
[Pipelines] Add a test how DCE works after ArgumentPromotion
Jun 30 2022, 2:57 AM · Restricted Project, Restricted Project

Jun 29 2022

psamolysov requested review of D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 29 2022, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 29 2022, 1:51 AM · Restricted Project, Restricted Project, debug-info
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 29 2022, 1:50 AM · Restricted Project, Restricted Project, debug-info
psamolysov committed rG3d9ce9e43d07: [ArgPromotion] Remove all the getters and ReplaceCallSite (NFC) (authored by psamolysov).
[ArgPromotion] Remove all the getters and ReplaceCallSite (NFC)
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project
psamolysov committed rG8958057fb100: [ArgPromotion] Move isDenselyPacked static member (NFC) (authored by psamolysov).
[ArgPromotion] Move isDenselyPacked static member (NFC)
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project
psamolysov closed D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project
psamolysov closed D128725: [ArgPromotion] Move isDenselyPacked static member (NFC).
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project

Jun 28 2022

psamolysov added a comment to D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

CGSCCPassManager and LazyCallGraph are included in the class' header. About Module I'm not sure, CLion marks this header as unused, I also see no Module in the code.

Jun 28 2022, 9:21 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

Remove #include of unused headers.

Jun 28 2022, 8:25 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

Eliminate all the getters as well as the ReplaceCallSite parameter.

Jun 28 2022, 8:17 AM · Restricted Project, Restricted Project
psamolysov added a comment to D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

Good catch, thank you. I think the ReplicaCallSite parameter can be removed too because we pass only None for it.

Jun 28 2022, 7:55 AM · Restricted Project, Restricted Project
psamolysov requested review of D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.
Jun 28 2022, 6:35 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 28 2022, 6:13 AM · Restricted Project, Restricted Project, debug-info
psamolysov requested review of D128725: [ArgPromotion] Move isDenselyPacked static member (NFC).
Jun 28 2022, 6:08 AM · Restricted Project, Restricted Project
psamolysov committed rG170c4d21bd94: [ArgPromotion] Unify byval promotion with non-byval (authored by psamolysov).
[ArgPromotion] Unify byval promotion with non-byval
Jun 28 2022, 5:23 AM · Restricted Project, Restricted Project
psamolysov closed D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 28 2022, 5:23 AM · Restricted Project, Restricted Project

Jun 27 2022

psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic Thank you for accepting. I've got the commit access and able to land patches. I'm going to land the patch in a day or two.

Jun 27 2022, 4:37 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 27 2022, 4:04 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Apply the suggestion about doing a LI->setOperand(0, GetAlloca(Ptr)) and not really creating a new instruction and RAUW.

Jun 27 2022, 4:03 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 27 2022, 3:14 AM · Restricted Project, Restricted Project, debug-info
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic thank you for landing D128536. The patch has been rebased.

Jun 27 2022, 3:07 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Rebase the patch on main, remove all the stuff related to the legacy pass manager.

Jun 27 2022, 3:06 AM · Restricted Project, Restricted Project

Jun 25 2022

psamolysov committed rG6e3d4712b90b: [DeadArgElim] Replace insert with emplace (NFC) (authored by psamolysov).
[DeadArgElim] Replace insert with emplace (NFC)
Jun 25 2022, 12:34 AM · Restricted Project, Restricted Project

Jun 24 2022

psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Fetch AssumptionCache for the new function rather than the old one.

Jun 24 2022, 8:39 AM · Restricted Project, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic I believe this is a very good idea just to drop the legacy PM support in ArgPromotion. Thank you for the patch, once your patch has been landed, I'll just leave the single DTGetter.

Jun 24 2022, 8:36 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Implement the proposed solution with DTGetter to reuse DominatorTrees from the pass manager. This works fine on the new PM but not on the legacy one. As a workaround, a new DominatorTree is created for every new generated function whenever the Argument Promotion Pass is used through the legacy pass manager.

Jun 24 2022, 7:47 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 24 2022, 7:37 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 24 2022, 5:29 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Apply suggestions from the code review.

Jun 24 2022, 5:27 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 24 2022, 5:24 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Address almost the all reviewer's comments.

Jun 24 2022, 3:20 AM · Restricted Project, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic Thank you very much for the review and comments, I've addressed almost all of them and asked a pair of questions about alignment check for loads in the HandleEndUser lambda. Could you have a look and give your answers?

Jun 24 2022, 3:15 AM · Restricted Project, Restricted Project

Jun 23 2022

psamolysov added inline comments to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.
Jun 23 2022, 4:32 AM · Restricted Project, debug-info, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic @aeubanks Colleagues, ping, could you have a look at the changes?

Jun 23 2022, 4:25 AM · Restricted Project, Restricted Project

Jun 21 2022

psamolysov committed rGf44bf3805ab2: [DeadArgElim] Reformat the pass in accordance with the code style (authored by psamolysov).
[DeadArgElim] Reformat the pass in accordance with the code style
Jun 21 2022, 11:28 PM · Restricted Project, Restricted Project
psamolysov added a comment to D128168: [DeadArgElim] Reformat the pass in accordance with the code style.

@MaskRay Thank you for the review. I've landed the patch.

Jun 21 2022, 11:28 PM · Restricted Project, Restricted Project
psamolysov closed D128168: [DeadArgElim] Reformat the pass in accordance with the code style.
Jun 21 2022, 11:28 PM · Restricted Project, Restricted Project

Jun 20 2022

psamolysov requested review of D128168: [DeadArgElim] Reformat the pass in accordance with the code style.
Jun 20 2022, 2:30 AM · Restricted Project, Restricted Project

Jun 17 2022

psamolysov added inline comments to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.
Jun 17 2022, 8:07 AM · Restricted Project, debug-info, Restricted Project
psamolysov accepted D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.

Ongoing changes LGTM but I would like you to wait for another approve too. @CarlosAlbertoEnciso please upload the final revision.

Jun 17 2022, 8:04 AM · Restricted Project, Restricted Project, debug-info
psamolysov added a comment to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.

@CarlosAlbertoEnciso You are welcome! I'll be glad if my modest efforts help you to land this amazing tool.

Jun 17 2022, 4:48 AM · Restricted Project, debug-info, Restricted Project

Jun 14 2022

psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
Jun 14 2022, 2:32 AM · Restricted Project, Restricted Project, debug-info

Jun 10 2022

psamolysov added a comment to D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

Good job! Thank you for the patch series and the usable tool!

Jun 10 2022, 12:43 AM · Restricted Project, Restricted Project, debug-info

Jun 8 2022

psamolysov added a comment to D126699: [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set.

Ping. Does this change make sense at all?

Jun 8 2022, 1:49 AM · Restricted Project, Restricted Project