Page MenuHomePhabricator
Feed Advanced Search

Today

herhut accepted D77526: [MLIR] Change return type of ParallelOp::getInductionVars to ValueRange..

Nice! Thanks.

Mon, Apr 6, 1:36 AM · Restricted Project

Fri, Apr 3

herhut accepted D77382: [MLIR] Fix shape inference in toy tutorial.

Thanks!

Fri, Apr 3, 6:59 AM · Restricted Project

Tue, Mar 31

herhut accepted D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.

Thanks!

Tue, Mar 31, 7:44 AM · Restricted Project

Fri, Mar 27

herhut committed rGac9d742bbe4f: [MLIR][LLVM] Make index type bitwidth configurable. (authored by herhut).
[MLIR][LLVM] Make index type bitwidth configurable.
Fri, Mar 27, 4:51 AM
herhut closed D76353: [MLIR][LLVM] Make index type bitwidth configurable..
Fri, Mar 27, 4:51 AM · Restricted Project
herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Minor cleanup.

Fri, Mar 27, 4:50 AM · Restricted Project
herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Rebase again.

Fri, Mar 27, 4:50 AM · Restricted Project

Thu, Mar 26

herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Comments.

Thu, Mar 26, 10:50 AM · Restricted Project
herhut accepted D76726: Allow IndexType inside tensors..

Thanks for adding this. Looking forward to removing the index -> i64 -> index casting chains!

Thu, Mar 26, 7:33 AM · Restricted Project
herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Properly rebase...

Thu, Mar 26, 6:28 AM · Restricted Project
herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Rebase

Thu, Mar 26, 5:23 AM · Restricted Project
herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Formatting

Thu, Mar 26, 4:17 AM · Restricted Project
herhut added a comment to D76353: [MLIR][LLVM] Make index type bitwidth configurable..

@ftynse Could you take another look and approve?

Thu, Mar 26, 4:17 AM · Restricted Project
herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Moving flag into LLVMTypeConverterCustomization.

Thu, Mar 26, 4:17 AM · Restricted Project
herhut accepted D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..

As this does not change the semantics of what is currently implemented, I am fine with this to land.

Thu, Mar 26, 3:44 AM · Restricted Project

Wed, Mar 25

herhut accepted D76363: [MLIR] Add parallel loop coalescing..

Thanks.

Wed, Mar 25, 7:32 AM · Restricted Project

Mon, Mar 23

herhut accepted D76563: Fix all-reduce int tests by host-registering memrefs. Reduce amount of boiler plate to register host memory..

Thanks for fixing this. The clang-tidy error seems benign.

Mon, Mar 23, 3:15 AM · Restricted Project
herhut updated subscribers of D76563: Fix all-reduce int tests by host-registering memrefs. Reduce amount of boiler plate to register host memory..

@clementval FYI, these tests were failing.

Mon, Mar 23, 3:15 AM · Restricted Project

Fri, Mar 20

herhut added a comment to D76353: [MLIR][LLVM] Make index type bitwidth configurable..

I did not go with the customization as it was not clear to me how those would compose. One should still be able to select different lowerings for signatures and the index type.

Fri, Mar 20, 7:32 AM · Restricted Project
herhut updated the diff for D76353: [MLIR][LLVM] Make index type bitwidth configurable..

Comments...

Fri, Mar 20, 7:32 AM · Restricted Project

Thu, Mar 19

herhut committed rGd4d62fcab667: [MLIR] Add test for multiple gpu.all_reduce in the same kernel when lowering to… (authored by clementval).
[MLIR] Add test for multiple gpu.all_reduce in the same kernel when lowering to…
Thu, Mar 19, 8:39 AM
herhut closed D75930: [MLIR] Add test for multiple gpu.all_reduce in the same kernel when lowering to NVVM.
Thu, Mar 19, 8:38 AM · Restricted Project
herhut accepted D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM..
Thu, Mar 19, 8:37 AM · Restricted Project
herhut requested changes to D76363: [MLIR] Add parallel loop coalescing..

Thanks. Looks great with some nits.

Thu, Mar 19, 3:11 AM · Restricted Project

Wed, Mar 18

herhut added a reviewer for D76353: [MLIR][LLVM] Make index type bitwidth configurable.: ftynse.
Wed, Mar 18, 4:51 AM · Restricted Project
herhut created D76353: [MLIR][LLVM] Make index type bitwidth configurable..
Wed, Mar 18, 4:51 AM · Restricted Project

Mon, Mar 16

herhut requested changes to D76165: [mlir][GPU] Use StructAttr to drive lowering from loop.parallel to gpu.launch.

Thanks for cleaning this up. With comments addresses, I'd be happy to see this land.

Mon, Mar 16, 4:35 AM · Restricted Project

Thu, Mar 12

herhut accepted D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM..

Can this land or has it already?

Thu, Mar 12, 7:35 AM · Restricted Project
herhut added inline comments to D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..
Thu, Mar 12, 7:35 AM · Restricted Project
herhut accepted D75968: [mlir][SideEffects][NFC] Move the .td definitions for NoSideEffect/RecursiveSideEffect to SideEffects.td.
Thu, Mar 12, 5:13 AM · Restricted Project
herhut resigned from D75876: [mlir][spirv] Let SPIRVConversionTarget consider type availability.
Thu, Mar 12, 4:30 AM · Restricted Project
herhut accepted D75888: [mlir][SideEffects] Mark the CFG only terminator operations as NoSideEffect.

For the dialects I am involved with this looks reasonable.

Thu, Mar 12, 4:30 AM · Restricted Project
herhut requested changes to D75930: [MLIR] Add test for multiple gpu.all_reduce in the same kernel when lowering to NVVM.

Thanks for the extra tests, more tests are always better. Could you fix the Summary in the commit message and I will land it.

Thu, Mar 12, 4:30 AM · Restricted Project

Wed, Mar 11

herhut added a comment to D75930: [MLIR] Add test for multiple gpu.all_reduce in the same kernel when lowering to NVVM.

csigg@ just landed some code that does in-dialect lowering and should achieve the same that is done here via using function attributions, instead. Can you verify?

Wed, Mar 11, 9:04 AM · Restricted Project
herhut committed rGc7380995f812: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm… (authored by clementval).
[MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm…
Wed, Mar 11, 6:18 AM
herhut committed rGf6790a1c6359: Revert "[MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the… (authored by herhut).
Revert "[MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the…
Wed, Mar 11, 6:18 AM
herhut added a comment to D75766: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering.

@herhut Thanks for pushing the patch. I don't see me in the attribution? Is this normal? I don't really mind but just wanted to double check.

Wed, Mar 11, 6:17 AM · Restricted Project

Tue, Mar 10

herhut committed rG2eff566b07da: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm… (authored by herhut).
[MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm…
Tue, Mar 10, 1:41 PM
herhut closed D75766: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering.
Tue, Mar 10, 1:41 PM · Restricted Project
herhut requested changes to D75930: [MLIR] Add test for multiple gpu.all_reduce in the same kernel when lowering to NVVM.
Tue, Mar 10, 10:52 AM · Restricted Project
herhut accepted D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead..

Thanks for cleaning this up.

Tue, Mar 10, 8:39 AM · Restricted Project
herhut accepted D75766: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering.

Thanks for addressing the comments. Looks good to land.

Tue, Mar 10, 8:06 AM · Restricted Project

Mon, Mar 9

herhut resigned from D75722: [mlir][Linalg] Implement padding for linalg.conv and lowering to loops..
Mon, Mar 9, 6:24 AM · Restricted Project
herhut added a comment to D75831: [mlir][Linalg] Revisit 0-D abstraction.

ok since everyone seems to be onboard and pifon@ is integrate duty this week I'll coordinate with him.

Mon, Mar 9, 6:24 AM · Restricted Project
herhut added inline comments to D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..
Mon, Mar 9, 5:20 AM · Restricted Project
herhut added a comment to D75766: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering.

I have some tests ready as well but just wanted to check what kind of test are preferred: test running with the mlir-cuda-runner with a check of the result or a miler-opt lowering with checks of the lowering?

We can't assume that someone has a GPU to be able to run the compiler unit tests: so lit+FileCheck please.

Mon, Mar 9, 3:11 AM · Restricted Project
herhut added a comment to D75766: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering.

Nice, thanks for adding this!

Mon, Mar 9, 3:11 AM · Restricted Project
herhut accepted D75831: [mlir][Linalg] Revisit 0-D abstraction.

Thanks, much cleaner solution!

Mon, Mar 9, 2:39 AM · Restricted Project
herhut accepted D75832: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce..

Sure, why not. Thanks.

Mon, Mar 9, 2:39 AM · Restricted Project

Mar 6 2020

herhut committed rG8e4a8677be30: Revert "PR45083: Mark statement expressions as being dependent if they contain" (authored by herhut).
Revert "PR45083: Mark statement expressions as being dependent if they contain"
Mar 6 2020, 2:14 AM
herhut added a reverting change for rGa95cc77be154: PR45083: Mark statement expressions as being dependent if they contain…: rG8e4a8677be30: Revert "PR45083: Mark statement expressions as being dependent if they contain".
Mar 6 2020, 2:14 AM
herhut abandoned D75684: [mlir][LLVM] Remove pessimizing std::move..
Mar 6 2020, 12:35 AM · Restricted Project

Mar 5 2020

herhut added a reviewer for D75684: [mlir][LLVM] Remove pessimizing std::move.: ftynse.

This is to make this build with less permissive warning/error flags, as well :)

Mar 5 2020, 8:13 AM · Restricted Project
herhut created D75684: [mlir][LLVM] Remove pessimizing std::move..
Mar 5 2020, 8:13 AM · Restricted Project

Mar 4 2020

herhut committed rG573c9d666c0f: [lld] Avoid creating files outside of work directory. (authored by herhut).
[lld] Avoid creating files outside of work directory.
Mar 4 2020, 6:12 AM
herhut closed D75605: [lld] Avoid creating files outside of work directory..
Mar 4 2020, 6:11 AM · Restricted Project
herhut created D75605: [lld] Avoid creating files outside of work directory..
Mar 4 2020, 6:11 AM · Restricted Project

Mar 3 2020

herhut accepted D75206: [MLIR] Add explicit initial values for loop.parallel op..

Thanks. This looks great with some minor changes addressed.

Mar 3 2020, 6:02 AM · Restricted Project
herhut committed rG10ec1860a826: [MLIR][GPU] Add error checking to loop.parallel to gpu transform. (authored by herhut).
[MLIR][GPU] Add error checking to loop.parallel to gpu transform.
Mar 3 2020, 4:36 AM
herhut closed D75468: [MLIR][GPU] Add error checking to loop.parallel to gpu transform..
Mar 3 2020, 4:36 AM · Restricted Project
herhut added a comment to D75468: [MLIR][GPU] Add error checking to loop.parallel to gpu transform..

Thanks!

Mar 3 2020, 3:04 AM · Restricted Project
herhut updated the diff for D75468: [MLIR][GPU] Add error checking to loop.parallel to gpu transform..

Review comments.

Mar 3 2020, 3:04 AM · Restricted Project
herhut added inline comments to D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..
Mar 3 2020, 2:37 AM · Restricted Project
herhut committed rG57b8b2cc50d0: Revert "[mlir][ods] Add query for derived attribute" (authored by herhut).
Revert "[mlir][ods] Add query for derived attribute"
Mar 3 2020, 1:44 AM
herhut added a reverting change for rG5aa57c281201: [mlir][ods] Add query for derived attribute: rG57b8b2cc50d0: Revert "[mlir][ods] Add query for derived attribute".
Mar 3 2020, 1:43 AM

Mar 2 2020

herhut added a reviewer for D75468: [MLIR][GPU] Add error checking to loop.parallel to gpu transform.: ftynse.
Mar 2 2020, 9:29 AM · Restricted Project
herhut created D75468: [MLIR][GPU] Add error checking to loop.parallel to gpu transform..
Mar 2 2020, 9:29 AM · Restricted Project
herhut committed rGd17428d95135: [MLIR][GPU] fix loop trip count computation in LoopsToGPU (authored by herhut).
[MLIR][GPU] fix loop trip count computation in LoopsToGPU
Mar 2 2020, 6:56 AM
herhut closed D75449: [MLIR][GPU] fix loop trip count computation in LoopsToGPU.
Mar 2 2020, 6:56 AM · Restricted Project
herhut accepted D75449: [MLIR][GPU] fix loop trip count computation in LoopsToGPU.

Thank you!

Mar 2 2020, 6:33 AM · Restricted Project
herhut committed rG56ac9d30d356: [MLIR] Add includes to PointerLikeTypeTraits where needed. (authored by herhut).
[MLIR] Add includes to PointerLikeTypeTraits where needed.
Mar 2 2020, 5:04 AM
herhut closed D75442: [MLIR] Add includes to PointerLikeTypeTraits where needed..
Mar 2 2020, 5:04 AM · Restricted Project
herhut added a comment to D75442: [MLIR] Add includes to PointerLikeTypeTraits where needed..

Should we just put it in mlir/Support/LLVM.h and rely on transitivity in most cases?

Mar 2 2020, 3:53 AM · Restricted Project
herhut added a reviewer for D75442: [MLIR] Add includes to PointerLikeTypeTraits where needed.: ftynse.

An alternative would be to forward declare the template <typename T> struct PointerLikeTypeTraits everywhere.

Mar 2 2020, 3:06 AM · Restricted Project
Herald added a reviewer for D75442: [MLIR] Add includes to PointerLikeTypeTraits where needed.: antiagainst.
Mar 2 2020, 3:00 AM · Restricted Project

Feb 28 2020

herhut added inline comments to D75287: [mlir][GPU] Expose the functionality to create a gpu.GPUFuncOp from a gpu.GPULaunchOp.
Feb 28 2020, 7:44 AM · Restricted Project

Feb 27 2020

herhut committed rG9227a74b7e8f: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC). (authored by herhut).
[MLIR][Loops] Expose transformations on loop.parallel in header (NFC).
Feb 27 2020, 11:36 AM
herhut closed D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC)..
Feb 27 2020, 11:35 AM · Restricted Project
herhut updated the diff for D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC)..

Comments...

Feb 27 2020, 11:34 AM · Restricted Project
herhut added a comment to D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC)..

Thanks!

Feb 27 2020, 11:34 AM · Restricted Project
herhut accepted D75247: [mlir] fix wrong symbol order in AffineApplyNormalizer.

Thanks for fixing this!

Feb 27 2020, 6:15 AM · Restricted Project
herhut updated the diff for D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC)..

fix linter errors.

Feb 27 2020, 4:13 AM · Restricted Project
herhut added a reviewer for D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC).: ftynse.

We probably have other transforms that should ultimately move to the header. This is a first step as the added transforms are not available otherwise.

Feb 27 2020, 1:52 AM · Restricted Project
herhut created D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC)..
Feb 27 2020, 1:50 AM · Restricted Project

Feb 25 2020

herhut committed rG5e6d7246335d: [MLIR][GPU] Properly model step in parallel loop to gpu conversion. (authored by herhut).
[MLIR][GPU] Properly model step in parallel loop to gpu conversion.
Feb 25 2020, 5:28 AM
herhut closed D75052: [MLIR][GPU] Properly model step in parallel loop to gpu conversion..
Feb 25 2020, 5:27 AM · Restricted Project
herhut committed rGca1bad5253a1: [MLIR][GPU] Properly model step in parallel loop to gpu conversion. (authored by herhut).
[MLIR][GPU] Properly model step in parallel loop to gpu conversion.
Feb 25 2020, 5:09 AM
herhut updated the diff for D75052: [MLIR][GPU] Properly model step in parallel loop to gpu conversion..

Review comments.

Feb 25 2020, 4:42 AM · Restricted Project
herhut added a comment to D75052: [MLIR][GPU] Properly model step in parallel loop to gpu conversion..

Thanks for the review!

Feb 25 2020, 4:42 AM · Restricted Project
herhut updated the diff for D75052: [MLIR][GPU] Properly model step in parallel loop to gpu conversion..

Simplify afffine constant matching.

Feb 25 2020, 3:31 AM · Restricted Project
herhut committed rGe4e122aa1d59: [MLIR][GPU] Fix forward declaration of Region class. (authored by herhut).
[MLIR][GPU] Fix forward declaration of Region class.
Feb 25 2020, 3:12 AM
herhut committed rG7a7eacc797f7: [MLIR][GPU] Implement a simple greedy loop mapper. (authored by herhut).
[MLIR][GPU] Implement a simple greedy loop mapper.
Feb 25 2020, 2:53 AM
herhut closed D74963: [MLIR][GPU] Implement a simple greedy loop mapper..
Feb 25 2020, 2:52 AM · Restricted Project
herhut updated the diff for D74963: [MLIR][GPU] Implement a simple greedy loop mapper..

Rebase and some whitespace cleanup.

Feb 25 2020, 2:43 AM · Restricted Project
herhut updated the diff for D74963: [MLIR][GPU] Implement a simple greedy loop mapper..

Add some newlines to end of files.

Feb 25 2020, 2:43 AM · Restricted Project
herhut updated the diff for D74963: [MLIR][GPU] Implement a simple greedy loop mapper..

Review comments.

Feb 25 2020, 2:43 AM · Restricted Project
herhut added inline comments to D74963: [MLIR][GPU] Implement a simple greedy loop mapper..
Feb 25 2020, 2:43 AM · Restricted Project

Feb 24 2020

herhut added a reviewer for D75052: [MLIR][GPU] Properly model step in parallel loop to gpu conversion.: ftynse.

PTAL.

Feb 24 2020, 7:44 AM · Restricted Project
herhut created D75052: [MLIR][GPU] Properly model step in parallel loop to gpu conversion..
Feb 24 2020, 7:35 AM · Restricted Project
herhut added a reviewer for D74963: [MLIR][GPU] Implement a simple greedy loop mapper.: ftynse.
Feb 24 2020, 1:36 AM · Restricted Project