Fri, Apr 3
Tue, Mar 31
Fri, Mar 27
Thu, Mar 26
Thanks for adding this. Looking forward to removing the index -> i64 -> index casting chains!
@ftynse Could you take another look and approve?
Moving flag into LLVMTypeConverterCustomization.
As this does not change the semantics of what is currently implemented, I am fine with this to land.
Wed, Mar 25
Mon, Mar 23
Thanks for fixing this. The clang-tidy error seems benign.
@clementval FYI, these tests were failing.
Fri, Mar 20
I did not go with the customization as it was not clear to me how those would compose. One should still be able to select different lowerings for signatures and the index type.
Thu, Mar 19
Thanks. Looks great with some nits.
Wed, Mar 18
Mon, Mar 16
Thanks for cleaning this up. With comments addresses, I'd be happy to see this land.
Thu, Mar 12
Can this land or has it already?
For the dialects I am involved with this looks reasonable.
Thanks for the extra tests, more tests are always better. Could you fix the Summary in the commit message and I will land it.
Wed, Mar 11
csigg@ just landed some code that does in-dialect lowering and should achieve the same that is done here via using function attributions, instead. Can you verify?
@herhut Thanks for pushing the patch. I don't see me in the attribution? Is this normal? I don't really mind but just wanted to double check.
Tue, Mar 10
Thanks for cleaning this up.
Thanks for addressing the comments. Looks good to land.
Mon, Mar 9
ok since everyone seems to be onboard and pifon@ is integrate duty this week I'll coordinate with him.
I have some tests ready as well but just wanted to check what kind of test are preferred: test running with the mlir-cuda-runner with a check of the result or a miler-opt lowering with checks of the lowering?
We can't assume that someone has a GPU to be able to run the compiler unit tests: so lit+FileCheck please.
Nice, thanks for adding this!
Thanks, much cleaner solution!
Sure, why not. Thanks.
Mar 6 2020
Mar 5 2020
This is to make this build with less permissive warning/error flags, as well :)
Mar 4 2020
Mar 3 2020
Thanks. This looks great with some minor changes addressed.
Mar 2 2020
Should we just put it in mlir/Support/LLVM.h and rely on transitivity in most cases?
An alternative would be to forward declare the template <typename T> struct PointerLikeTypeTraits everywhere.
Feb 28 2020
Feb 27 2020
Thanks for fixing this!
fix linter errors.
We probably have other transforms that should ultimately move to the header. This is a first step as the added transforms are not available otherwise.
Feb 25 2020
Thanks for the review!
Simplify afffine constant matching.
Rebase and some whitespace cleanup.
Add some newlines to end of files.
Feb 24 2020