Page MenuHomePhabricator
Feed Advanced Search

Yesterday

sfertile added inline comments to D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.
Thu, Apr 22, 1:30 PM · Restricted Project, Restricted Project
sfertile added inline comments to D100956: [AIX][TLS] Add ASM portion changes to support TLSGD relocations to XCOFF objects .
Thu, Apr 22, 12:17 PM · Restricted Project
sfertile added inline comments to D100956: [AIX][TLS] Add ASM portion changes to support TLSGD relocations to XCOFF objects .
Thu, Apr 22, 10:41 AM · Restricted Project

Tue, Apr 20

sfertile added a comment to D100214: [AIX][TLS] Add support for TLSGD relocations to XCOFF objects.

Patch looks pretty good. IIUC we were not printing the '@gd' specifier before because it is assumed by default by the system assembler. Now that we are adding object file support we can no longer rely of the system assembler to assume the specifier based on the storage mapping class ,and need to add the new variant kinds so we create the correct relocations, which has the side effect of also changing the asm we emit. I know I am being pedantic, but I think we should land that part of the change and the update to the asm test in an initial patch even though the object writing is the motivation for adding it.

Tue, Apr 20, 8:53 AM · Restricted Project

Wed, Mar 24

sfertile added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Could there be a simpler approach where we always emit a .got section on PPC64: In addReservedSymbols if we fail to resolve .TOC. then we create it?

We could do that and it would certainly solve the problem. The issue I have with that is that we will now have a .got for everything we link including things that we used to link in the past that did not require it. It seems odd to say that since the design of the linker won't allow us to do this easily we will generate this section whether we need it or not.

Wed, Mar 24, 12:30 PM · Restricted Project

Mar 8 2021

sfertile accepted D98078: [AIX][TLS] Generate 64-bit general-dynamic access code sequence.

LGTM.

Mar 8 2021, 12:42 PM · Restricted Project
sfertile accepted D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

discussed with sean offline, the we do not call the emitGlobalDtorWithCXAAtExit() in AIX. so we do not have the problem for the "__dso_handle"

I initially had concerns with the places clang introduces non-default visibility in codegen. The few cases I was worried we would hit were related to static init , but that was before @Xiangling_L static init related work. After those changes I have no other concerns. I would wait a day or two to ensure that there are no more comments related to the round-trip-args behaviour but otherwise LGTM.

Mar 8 2021, 9:47 AM · Restricted Project

Mar 6 2021

sfertile committed rGf0904a62085a: [PowePC][AIX] Handle variadic vector call operands. (authored by sfertile).
[PowePC][AIX] Handle variadic vector call operands.
Mar 6 2021, 10:51 AM
sfertile closed D97956: [PowePC][AIX] Handle variadic vector call operands..
Mar 6 2021, 10:51 AM · Restricted Project, Restricted Project

Mar 5 2021

sfertile added inline comments to D97909: [AIX] Allow safe for 32bit P8 VSX pattern matching.
Mar 5 2021, 12:24 PM · Restricted Project
sfertile accepted D97948: [AIX][TLS] Generate 32-bit general-dynamic access code sequence.

Thanks for the updates Lei. LGTM.

Mar 5 2021, 11:02 AM · Restricted Project
sfertile accepted D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.

One minor comment but otherwise LGTM.

Mar 5 2021, 9:09 AM · Restricted Project, Restricted Project
sfertile updated the diff for D97956: [PowePC][AIX] Handle variadic vector call operands..
  • clang-formated lambda
  • changed check-prefixes to check-prefix
  • added whitespace between 32-bit and 64-bit check lines
  • Changed check for further custom RegLcos to include that the ValNo of the next RegLoc is the same as the original ValNo.
Mar 5 2021, 8:55 AM · Restricted Project, Restricted Project
sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 5 2021, 7:07 AM · Restricted Project, Restricted Project
sfertile added a comment to D97948: [AIX][TLS] Generate 32-bit general-dynamic access code sequence.

Patch looks good Lei, the one thing we are missing though is a lit test that checks for the expected toc entries.

Mar 5 2021, 5:58 AM · Restricted Project

Mar 4 2021

sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 4 2021, 2:58 PM · Restricted Project, Restricted Project
sfertile retitled D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX from [AIX] Enable the default AltiVec ABI on AIX to [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 4 2021, 12:26 PM · Restricted Project, Restricted Project
sfertile accepted D97418: [PowerPC] Disable more extended mne on AIX.

LGTM.

Mar 4 2021, 12:24 PM · Restricted Project
sfertile requested review of D97956: [PowePC][AIX] Handle variadic vector call operands..
Mar 4 2021, 8:22 AM · Restricted Project, Restricted Project
sfertile committed rGaaeffbe00736: [PowerPC][AIX] Handle variadic vector formal arguments. (authored by sfertile).
[PowerPC][AIX] Handle variadic vector formal arguments.
Mar 4 2021, 7:58 AM
sfertile closed D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 4 2021, 7:58 AM · Restricted Project, Restricted Project
sfertile retitled D97485: [PowerPC][AIX] Handle variadic vector formal arguments. from PowerPC][AIX] Handle variadic vector formal arguments. to [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 4 2021, 6:34 AM · Restricted Project, Restricted Project

Mar 3 2021

sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..

Fix formating on assert.

Mar 3 2021, 3:52 PM · Restricted Project, Restricted Project
sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 3 2021, 8:20 AM · Restricted Project, Restricted Project
sfertile added inline comments to D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 3 2021, 7:42 AM · Restricted Project, Restricted Project
sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
  • Add asserts that the ValNo of custom RegLocs match the ValNo of the custom MemLoc.
  • Assert that we are targeting 32-bit codegen when we have 4 custom RegLocs.
  • Add comments to the tests to make it easier to determine what is being tested.
Mar 3 2021, 7:32 AM · Restricted Project, Restricted Project

Mar 2 2021

sfertile added inline comments to D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 2 2021, 8:33 AM · Restricted Project, Restricted Project
sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
  • Converted loop to explicit handling of custom RegLocs
  • Added const on member function.
Mar 2 2021, 8:31 AM · Restricted Project, Restricted Project
sfertile added inline comments to D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 2 2021, 7:12 AM · Restricted Project, Restricted Project

Mar 1 2021

sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 1 2021, 10:43 AM · Restricted Project, Restricted Project
sfertile committed rG3f40dbbbc71d: [PowerPC][AIX] Enable passing vectors in variadic functions. (authored by sfertile).
[PowerPC][AIX] Enable passing vectors in variadic functions.
Mar 1 2021, 10:09 AM
sfertile closed D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end)..
Mar 1 2021, 10:09 AM · Restricted Project, Restricted Project

Feb 28 2021

sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..

Fixed a number of formatting and spelling mistakes.

Feb 28 2021, 7:52 AM · Restricted Project, Restricted Project

Feb 25 2021

sfertile requested review of D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Feb 25 2021, 9:32 AM · Restricted Project, Restricted Project
sfertile requested review of D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end)..
Feb 25 2021, 7:33 AM · Restricted Project, Restricted Project

Feb 18 2021

sfertile committed rGbb260b1ca7d5: [PowerPC][AIX] Add support for vector arg passing on the stack. (authored by sfertile).
[PowerPC][AIX] Add support for vector arg passing on the stack.
Feb 18 2021, 10:35 AM
sfertile closed D96415: [PowerPC][AIX] Support passing vector arguments on the stack..
Feb 18 2021, 10:34 AM · Restricted Project, Restricted Project

Feb 17 2021

sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 17 2021, 9:48 AM · Restricted Project, Restricted Project
sfertile added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Could there be a simpler approach where we always emit a .got section on PPC64: In addReservedSymbols if we fail to resolve .TOC. then we create it?

Feb 17 2021, 7:29 AM · Restricted Project
sfertile committed rG4e127bce2d11: [PowerPC] Handle FP physical register in inline asm constraint. (authored by sfertile).
[PowerPC] Handle FP physical register in inline asm constraint.
Feb 17 2021, 6:29 AM
sfertile closed D91629: [PowerPC] Handle FP physical register in inline asm constraint..
Feb 17 2021, 6:29 AM · Restricted Project, Restricted Project
sfertile accepted D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

LGTM.

Feb 17 2021, 6:21 AM · Restricted Project
sfertile retitled D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX. from [ShrinkWrap] Enable Shrinkwrapping on 32 and 64 bit AIX, and 64 bit ELF to [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 17 2021, 6:17 AM · Restricted Project

Feb 16 2021

sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 16 2021, 7:44 AM · Restricted Project

Feb 12 2021

sfertile accepted D96184: [AIX][TLS] Generate TLS variables in assembly files.

LGTM. Please wait until David has given it the OK too though.

Feb 12 2021, 10:39 AM · Restricted Project, Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 12 2021, 10:23 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 12 2021, 9:49 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 12 2021, 8:37 AM · Restricted Project

Feb 11 2021

sfertile accepted D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.

Thanks for the update. LGTM.

Feb 11 2021, 12:58 PM · Restricted Project, Restricted Project
sfertile added a comment to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

I'll need a bit more time to finish going through ppc-shrink-wrapping.ll but the patch is looking really good. Thanks for the updates.

Feb 11 2021, 9:24 AM · Restricted Project
sfertile added inline comments to D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.
Feb 11 2021, 6:38 AM · Restricted Project, Restricted Project

Feb 10 2021

sfertile added inline comments to D96415: [PowerPC][AIX] Support passing vector arguments on the stack..
Feb 10 2021, 12:54 PM · Restricted Project, Restricted Project
sfertile updated the diff for D96415: [PowerPC][AIX] Support passing vector arguments on the stack..

Addressed review comments.

Feb 10 2021, 12:54 PM · Restricted Project, Restricted Project
sfertile added inline comments to D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.
Feb 10 2021, 11:43 AM · Restricted Project, Restricted Project
sfertile added a comment to D91629: [PowerPC] Handle FP physical register in inline asm constraint..

ping.

Feb 10 2021, 10:04 AM · Restricted Project, Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 10 2021, 9:58 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 10 2021, 8:20 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 10 2021, 7:29 AM · Restricted Project
sfertile updated the diff for D96415: [PowerPC][AIX] Support passing vector arguments on the stack..

Use early return instead.

Feb 10 2021, 6:53 AM · Restricted Project, Restricted Project
sfertile retitled D96415: [PowerPC][AIX] Support passing vector arguments on the stack. from [PowerPC][AIX} Support passing vector arguments on the stack. to [PowerPC][AIX] Support passing vector arguments on the stack..
Feb 10 2021, 6:49 AM · Restricted Project, Restricted Project
sfertile requested review of D96415: [PowerPC][AIX] Support passing vector arguments on the stack..
Feb 10 2021, 6:49 AM · Restricted Project, Restricted Project

Jan 18 2021

sfertile committed rGead71a23edde: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX. (authored by sfertile).
[PowerPC][AIX]Do not emit xxspltd mnemonic on AIX.
Jan 18 2021, 6:27 AM
sfertile closed D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..
Jan 18 2021, 6:26 AM · Restricted Project, Restricted Project

Jan 15 2021

sfertile updated the diff for D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..

Rebased on trunk.

Jan 15 2021, 8:45 AM · Restricted Project, Restricted Project

Jan 14 2021

sfertile accepted D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Thanks Jinsong, LGTM.

Jan 14 2021, 12:13 PM · Restricted Project
sfertile added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Jan 14 2021, 8:47 AM · Restricted Project
sfertile added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Jan 14 2021, 6:34 AM · Restricted Project

Jan 13 2021

sfertile added a comment to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Thanks Jinsong, left a couple really minor comments. Will rebase the xxspltd fix on this patch now.

Jan 13 2021, 8:37 AM · Restricted Project

Jan 12 2021

sfertile added a comment to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
clang -target powerpc64le-unknown-linux-gnu  -c -o a.o  modern-as.s
 error: instruction use requires an option to be enabled
            mfudscr 2

IIUC this patch is breaking compatibility with gas due to the AIX assembler not supporting the mnemonic. Similarly for my xxspltd patch, we wouldn't be able to encode the mnemonic without passing extra options on Linux. Thats why I took the approach I did in D94419. I am happy to change direction, but in my opinion we should only be disabling the mnemonics on AIX.

Jan 12 2021, 10:15 AM · Restricted Project
sfertile added a comment to D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..

I have added a Predicates in https://reviews.llvm.org/D94458 for a similar mne, maybe you can rebase this to use that.

Jan 12 2021, 7:42 AM · Restricted Project, Restricted Project
sfertile accepted D94449: [PowerPC][NFCI] PassSubtarget to ASMWriter.

Thanks Jinsong, LGTM.

Jan 12 2021, 7:40 AM · Restricted Project

Jan 11 2021

sfertile requested review of D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..
Jan 11 2021, 8:12 AM · Restricted Project, Restricted Project

Dec 7 2020

sfertile committed rG8f91f38148e8: [LLD] Search archives for symbol defs to override COMMON symbols. (authored by sfertile).
[LLD] Search archives for symbol defs to override COMMON symbols.
Dec 7 2020, 7:10 AM
sfertile closed D86142: [LLD] Search archives for non-tentative defintions..
Dec 7 2020, 7:10 AM · Restricted Project, Restricted Project

Dec 2 2020

sfertile added a comment to D86142: [LLD] Search archives for non-tentative defintions..

If there is no objections, I'll go ahead and commit later this week.

Dec 2 2020, 8:24 AM · Restricted Project, Restricted Project
sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..

Fixed one too many hyphens in man page change.

Dec 2 2020, 8:23 AM · Restricted Project, Restricted Project
sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Removed leading space in option description
  • Updated the manpage doc.
Dec 2 2020, 8:12 AM · Restricted Project, Restricted Project
sfertile added a comment to D92445: [PowerPC] Enable OpenMP for powerpcle target. [5/5].

On FreeBSD, the main use of this will be on the new powerpc64le arch, where we need to build a 32-bit LE bootloader for use with pseries. (it is easier to retarget LLVM than make a cross-endian bootloader, as it would involve rewriting filesystem code etc.)

Excuse my ignorance, but what are there technical limitations preventing writing n 64-bit LE boot loader and avoid having a 32-bit LE target all-together?

Dec 2 2020, 7:46 AM · Restricted Project, Restricted Project, Restricted Project
sfertile added inline comments to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
Dec 2 2020, 6:46 AM · Restricted Project, Restricted Project

Dec 1 2020

sfertile updated the diff for D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
  • Added -mattr=+altivec to vector pop count test to keep pwr5 testing
  • Added a test to show enabling altivec through function attribute.
Dec 1 2020, 10:26 AM · Restricted Project, Restricted Project

Nov 30 2020

sfertile added a comment to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..

The altivec feature was an optional part of the 2.03 (pwr4) and 2.04 (pwr5) ISAs, and it was not implemented by any IBM CPUs until Power6.

The Power Processing Element in various IBM CPUs (including the Cell Broadband Engine) incorporate VMX. With this change, which of the CPU options should a user targeting a PPE use?

Nov 30 2020, 12:49 PM · Restricted Project, Restricted Project
sfertile added inline comments to D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.
Nov 30 2020, 8:23 AM · Restricted Project
sfertile requested review of D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
Nov 30 2020, 7:20 AM · Restricted Project, Restricted Project

Nov 26 2020

sfertile added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Sorry Zarko, I must have deleted my comment before posting last night I've added it back now.

Nov 26 2020, 6:12 AM · Restricted Project

Nov 25 2020

sfertile accepted D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

1 comment, but otherwise LGTM.

Nov 25 2020, 4:52 PM · Restricted Project

Nov 24 2020

sfertile committed rG4f5355ee7362: [PowerPC] Don't reuse an illegal typed load for int_to_fp conversion. (authored by sfertile).
[PowerPC] Don't reuse an illegal typed load for int_to_fp conversion.
Nov 24 2020, 12:48 PM
sfertile closed D91265: [PowerPC] Don't reuse the address of an illegal typed load for int_to_fp..
Nov 24 2020, 12:48 PM · Restricted Project, Restricted Project

Nov 23 2020

sfertile accepted D91272: [AIX] Support init priority.

LGTM.

Nov 23 2020, 10:17 AM · Restricted Project
sfertile added a comment to D91272: [AIX] Support init priority.

A couple of really minor comments, but otherwise LGTM.

Nov 23 2020, 8:20 AM · Restricted Project

Nov 20 2020

sfertile accepted D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

LGTM.

Nov 20 2020, 6:55 AM · Restricted Project, Restricted Project

Nov 19 2020

sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Nov 19 2020, 10:18 AM · Restricted Project, Restricted Project
sfertile added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Nov 19 2020, 10:03 AM · Restricted Project
sfertile added inline comments to D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.
Nov 19 2020, 8:36 AM · Restricted Project
sfertile added inline comments to D91272: [AIX] Support init priority.
Nov 19 2020, 7:54 AM · Restricted Project

Nov 18 2020

sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Nov 18 2020, 12:13 PM · Restricted Project, Restricted Project
sfertile accepted D90892: [AIX][FE] Support constructor/destructor attribute.

Thanks for the updates. LGTM.

Nov 18 2020, 8:54 AM · Restricted Project

Nov 17 2020

sfertile requested review of D91629: [PowerPC] Handle FP physical register in inline asm constraint..
Nov 17 2020, 7:06 AM · Restricted Project, Restricted Project

Nov 13 2020

sfertile added inline comments to D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 13 2020, 7:56 AM · Restricted Project

Nov 12 2020

sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Add testing for warn-backrefs interaction.
  • Spelling fixes
  • Fix comments to use ## instead of # in lit test.
Nov 12 2020, 8:02 AM · Restricted Project, Restricted Project

Nov 11 2020

sfertile requested review of D91265: [PowerPC] Don't reuse the address of an illegal typed load for int_to_fp..
Nov 11 2020, 7:46 AM · Restricted Project, Restricted Project