Page MenuHomePhabricator
Feed Advanced Search

Today

sfertile added a comment to D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.

Can we please either commit this, or revert r369414 otherwise? Several of the sanitizer buildbots have been red since Tuesday due to r369414.

Fri, Aug 23, 7:47 AM · Restricted Project

Yesterday

sfertile committed rG5f85a7b1cfe9: [PowerPC] Add combined ELF ABI and 32/64 bit queries to the subtarget. [NFC] (authored by sfertile).
[PowerPC] Add combined ELF ABI and 32/64 bit queries to the subtarget. [NFC]
Thu, Aug 22, 8:14 AM
sfertile committed rG18fd1b0b494a: [PowerPC][XCOFF][MC] Explicitly set containing csect on symbols. [NFC] (authored by sfertile).
[PowerPC][XCOFF][MC] Explicitly set containing csect on symbols. [NFC]
Thu, Aug 22, 8:14 AM
sfertile committed rL369658: [PowerPC] Add combined ELF ABI and 32/64 bit queries to the subtarget. [NFC].
[PowerPC] Add combined ELF ABI and 32/64 bit queries to the subtarget. [NFC]
Thu, Aug 22, 8:14 AM
sfertile closed D65814: [PowerPC] Add combined ELF ABI and 32/64 bit queries to the Subtarget [NFC].
Thu, Aug 22, 8:14 AM · Restricted Project
sfertile committed rL369657: [PowerPC][XCOFF][MC] Explicitly set containing csect on symbols. [NFC].
[PowerPC][XCOFF][MC] Explicitly set containing csect on symbols. [NFC]
Thu, Aug 22, 8:14 AM
sfertile closed D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.
Thu, Aug 22, 8:14 AM · Restricted Project

Wed, Aug 21

sfertile added a comment to rL369549: Fix -Wimplicit-fallthrough warnings in regcomp.c.

This broke several of the bots (eg). It seems any of the __has_cpp_attribute checks that have a namespace qualified attributes will need to be guarded by a if defined(__cplusplus) if we are including the header in a C file.

Wed, Aug 21, 11:05 AM
sfertile updated the diff for D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.

We were stretching the definition of an NFC patch by creating but not using the TOC-base on AIX. I've striped this down to the NFC part and will post a separate patch for the TOC base change that includes a test change to reflect the TOC-base being created.

Wed, Aug 21, 8:44 AM · Restricted Project
sfertile commandeered D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.

Commandeering this.

Wed, Aug 21, 8:38 AM · Restricted Project

Tue, Aug 20

sfertile committed rG9467734a1c56: Fix assert in XCOFFObjectWriter related to program code csects. (authored by sfertile).
Fix assert in XCOFFObjectWriter related to program code csects.
Tue, Aug 20, 4:25 PM
sfertile committed rL369471: Fix assert in XCOFFObjectWriter related to program code csects..
Fix assert in XCOFFObjectWriter related to program code csects.
Tue, Aug 20, 4:23 PM
sfertile committed rG89463fcfc715: Remove assert with tautological compare from XCOFFObjectWriter. (authored by sfertile).
Remove assert with tautological compare from XCOFFObjectWriter.
Tue, Aug 20, 3:24 PM
sfertile committed rL369462: Remove assert with tautological compare from XCOFFObjectWriter..
Remove assert with tautological compare from XCOFFObjectWriter.
Tue, Aug 20, 3:24 PM
sfertile committed rG1e46d4cec535: Adds support for writing the .bss section for XCOFF object files. (authored by sfertile).
Adds support for writing the .bss section for XCOFF object files.
Tue, Aug 20, 3:07 PM
sfertile committed rL369454: Adds support for writing the .bss section for XCOFF object files..
Adds support for writing the .bss section for XCOFF object files.
Tue, Aug 20, 3:06 PM
sfertile closed D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Tue, Aug 20, 3:06 PM · Restricted Project
sfertile added a comment to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Related to the 32-bit vs 64-bit naming and assertions: I can appreciate being defensive about this, but I think trying to disable being able to create the various types and having an assertion (or error) in every function is overkill. Too much defensiveness is just clutter. I've added an earlier fatal_error in executePostlayoutBinding which blocks the ObjectWriter from doing anything interesting. When we are ready to proceed with 64-bit support we can remove that error and either rename the types (and guard all the appropriate functions), or modify the types for both 64-bit and 32-bit support, whichever is appropriate for the way we intend to add 64-bit support.

Tue, Aug 20, 9:30 AM · Restricted Project
sfertile updated the diff for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
  • Addressed latest round of review comments.
  • Replaced 'CSect' in code with 'Csect' and changed errors/comments to use 'CSECT'.
  • Added a second fatal error related to emiting 64-bit objects, in executePostBindingLayout.
Tue, Aug 20, 9:24 AM · Restricted Project
sfertile added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Tue, Aug 20, 7:33 AM · Restricted Project

Mon, Aug 19

sfertile updated the diff for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Addressed most review comments other then those related to 32-bit vs 64-bit.

Mon, Aug 19, 1:06 PM · Restricted Project
sfertile added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Mon, Aug 19, 12:58 PM · Restricted Project

Fri, Aug 16

sfertile added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Fri, Aug 16, 1:41 PM · Restricted Project
sfertile updated the diff for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Changed MCSymbolXCOFF StorageClass member to be an optional<StorageClass> and added asserts checking for redefineing the storage class and accessing an unset storage class.
Minor comment changes.

Fri, Aug 16, 1:41 PM · Restricted Project

Wed, Aug 14

sfertile added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Wed, Aug 14, 1:44 PM · Restricted Project
sfertile updated the diff for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Rebased and addressed numerous review comments.

Wed, Aug 14, 1:44 PM · Restricted Project

Tue, Aug 13

sfertile added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Tue, Aug 13, 8:37 AM · Restricted Project
sfertile accepted D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.

LGTM. (After either responding to or addressing Jason comment)

Tue, Aug 13, 7:07 AM · Restricted Project

Mon, Aug 12

sfertile updated the diff for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Rebased to reflect changes made in https://reviews.llvm.org/rL368584

Mon, Aug 12, 9:49 AM · Restricted Project
sfertile added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Mon, Aug 12, 8:48 AM · Restricted Project
sfertile committed rG29141da75ed9: [XCOFF] Use a single symbolic constant for the size of an embeded name. [NFC] (authored by sfertile).
[XCOFF] Use a single symbolic constant for the size of an embeded name. [NFC]
Mon, Aug 12, 8:29 AM
sfertile committed rL368584: [XCOFF] Use a single symbolic constant for the size of an embeded name. [NFC].
[XCOFF] Use a single symbolic constant for the size of an embeded name. [NFC]
Mon, Aug 12, 8:26 AM
sfertile added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Mon, Aug 12, 7:19 AM · Restricted Project

Fri, Aug 9

sfertile updated the diff for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Rebased.

Fri, Aug 9, 10:11 AM · Restricted Project
sfertile added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Fri, Aug 9, 6:36 AM · Restricted Project

Thu, Aug 8

sfertile accepted D64825: Enable assembly output of local commons for AIX.

LGTM.

Thu, Aug 8, 7:02 AM · Restricted Project

Wed, Aug 7

sfertile updated the diff for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Rebased.

Wed, Aug 7, 11:05 AM · Restricted Project
sfertile added inline comments to D64825: Enable assembly output of local commons for AIX.
Wed, Aug 7, 11:00 AM · Restricted Project

Tue, Aug 6

sfertile added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Tue, Aug 6, 1:49 PM · Restricted Project
sfertile added inline comments to D64424: [AIX] Implement LR prolog/epilog save/restore .
Tue, Aug 6, 10:28 AM · Restricted Project
sfertile accepted D65755: [ELF][PPC] Don't relax ifunc toc-indirect accesses to toc-relative.

LGTM.

Tue, Aug 6, 9:48 AM · Restricted Project
sfertile created D65814: [PowerPC] Add combined ELF ABI and 32/64 bit queries to the Subtarget [NFC].
Tue, Aug 6, 9:19 AM · Restricted Project
sfertile added inline comments to D65755: [ELF][PPC] Don't relax ifunc toc-indirect accesses to toc-relative.
Tue, Aug 6, 8:57 AM · Restricted Project

Thu, Aug 1

sfertile added a reviewer for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files.: stefanp.
Thu, Aug 1, 7:44 AM · Restricted Project
sfertile added a comment to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

ping

Thu, Aug 1, 7:44 AM · Restricted Project

Tue, Jul 30

sfertile added a comment to D64652: [AIX] Add a TargetLoweringObjectFile for XCOFF and add support for common variables..

@hubert.reinterpretcast I've committed a patch that addresses your comments: https://reviews.llvm.org/rL367324.

Tue, Jul 30, 9:08 AM · Restricted Project
sfertile committed rG39f35038140d: Address post commit review comments on revision 366727. (authored by sfertile).
Address post commit review comments on revision 366727.
Tue, Jul 30, 8:40 AM
sfertile committed rL367324: Address post commit review comments on revision 366727..
Address post commit review comments on revision 366727.
Tue, Jul 30, 8:37 AM

Mon, Jul 29

sfertile updated subscribers of D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Mon, Jul 29, 4:01 PM · Restricted Project
sfertile added inline comments to D64825: Enable assembly output of local commons for AIX.
Mon, Jul 29, 12:09 PM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Mon, Jul 29, 11:05 AM · Restricted Project
sfertile added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Mon, Jul 29, 8:20 AM · Restricted Project

Fri, Jul 26

sfertile accepted D63547: [AIX]Global Address Lowering.

A minor comment, but otherwise LGTM.

Fri, Jul 26, 10:56 AM · Restricted Project
sfertile committed rG9df6177d380e: [PowerPC][AIX]Add lowering of MCSymbol MachineOperand. (authored by sfertile).
[PowerPC][AIX]Add lowering of MCSymbol MachineOperand.
Fri, Jul 26, 10:26 AM
sfertile committed rL367133: [PowerPC][AIX]Add lowering of MCSymbol MachineOperand..
[PowerPC][AIX]Add lowering of MCSymbol MachineOperand.
Fri, Jul 26, 10:25 AM
sfertile closed D63738: [AIX]Enable lowering of MCSymbol MachineOperand.
Fri, Jul 26, 10:25 AM · Restricted Project
sfertile committed rG9bd22fec0d7b: [PowerPC] Add getCRSaveOffset to improve readability. [NFC] (authored by sfertile).
[PowerPC] Add getCRSaveOffset to improve readability. [NFC]
Fri, Jul 26, 7:03 AM
sfertile committed rL367111: [PowerPC] Add getCRSaveOffset to improve readability. [NFC].
[PowerPC] Add getCRSaveOffset to improve readability. [NFC]
Fri, Jul 26, 7:03 AM

Jul 24 2019

sfertile added a comment to D63738: [AIX]Enable lowering of MCSymbol MachineOperand.

We will need to add handling of Text SectionKind in TargetLoweringObjectFileXCOFF::getExplicitSectionGlobal in this because it blocks assembly generation for the test.

Jul 24 2019, 10:13 AM · Restricted Project
sfertile added a comment to D63547: [AIX]Global Address Lowering.

A couple minor comments, I think we are almost there.

Jul 24 2019, 9:48 AM · Restricted Project
sfertile added a comment to D64424: [AIX] Implement LR prolog/epilog save/restore .

I'll have to dig into the AIX ABI docs before I can review this more thoroughly but it looks good. I suggest we split out renaming of the hardcoded '8' to --> getCRSaveOffset() as a separate NFC patch and that we can land immediately.

Jul 24 2019, 8:13 AM · Restricted Project

Jul 23 2019

sfertile created D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Jul 23 2019, 11:08 AM · Restricted Project

Jul 22 2019

sfertile closed D64652: [AIX] Add a TargetLoweringObjectFile for XCOFF and add support for common variables..

Committed in https://reviews.llvm.org/rG942537d9fa50

Jul 22 2019, 12:23 PM · Restricted Project
sfertile committed rG942537d9fa50: Stubs out TLOF for AIX and add support for common vars in assembly output. (authored by sfertile).
Stubs out TLOF for AIX and add support for common vars in assembly output.
Jul 22 2019, 12:19 PM
sfertile committed rL366727: Stubs out TLOF for AIX and add support for common vars in assembly output..
Stubs out TLOF for AIX and add support for common vars in assembly output.
Jul 22 2019, 12:15 PM
sfertile committed rG324d33dd4ed6: [PowerPC] Fix comment on MO_PLT Target Operand Flag. [NFC] (authored by sfertile).
[PowerPC] Fix comment on MO_PLT Target Operand Flag. [NFC]
Jul 22 2019, 11:49 AM
sfertile committed rG8034daca5f47: [Object][XCOFF] Remove extra includes from XCOFF related files. [NFC] (authored by sfertile).
[Object][XCOFF] Remove extra includes from XCOFF related files. [NFC]
Jul 22 2019, 11:49 AM
sfertile committed rL366724: [PowerPC] Fix comment on MO_PLT Target Operand Flag. [NFC].
[PowerPC] Fix comment on MO_PLT Target Operand Flag. [NFC]
Jul 22 2019, 11:49 AM
sfertile committed rL366723: [Object][XCOFF] Remove extra includes from XCOFF related files. [NFC].
[Object][XCOFF] Remove extra includes from XCOFF related files. [NFC]
Jul 22 2019, 11:49 AM
sfertile closed D60885: [Object][XCOFF] Remove extra includes from XCOFF related files. [NFC].
Jul 22 2019, 11:48 AM · Restricted Project
sfertile accepted D64814: [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention.

LGTM.

Jul 22 2019, 8:05 AM · Restricted Project

Jul 16 2019

sfertile added inline comments to D64814: [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention.
Jul 16 2019, 2:12 PM · Restricted Project
sfertile updated subscribers of D64814: [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention.
Jul 16 2019, 2:03 PM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Jul 16 2019, 2:03 PM · Restricted Project

Jul 12 2019

sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Jul 12 2019, 12:07 PM · Restricted Project
sfertile created D64652: [AIX] Add a TargetLoweringObjectFile for XCOFF and add support for common variables..
Jul 12 2019, 11:23 AM · Restricted Project

Jul 9 2019

sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Jul 9 2019, 5:31 PM · Restricted Project
sfertile added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

np.

Jul 9 2019, 3:16 PM · Restricted Project
sfertile updated subscribers of D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

Maybe someone can enlighten me as to why the build bots aren't tripping up on this one, but our group is running into this when we pull this commit from the upstream:

In MCStreamer.h, the declaration of the pure virtual EmitSymbolAttribute is:

virtual bool EmitSymbolAttribute(MCSymbol *Symbol,
                                 MCSymbolAttr AttrKind,
                                 StringRef AttrVal = StringRef()) = 0;

In this revision, in MCXCOFFStreamer.h, the declaration is:

bool EmitSymbolAttribute(MCSymbol *Symbol, MCSymbolAttr Attribute) override;

This is ill-formed, because the 'override' declaration hides the pure virtual member function. Apparently the clang-fast build bots are ok with this, but I'm not sure how. A similar code segment (Compiler Explorer) fails on every clang compiler I've tried.

Jul 9 2019, 3:03 PM · Restricted Project
sfertile accepted D63738: [AIX]Enable lowering of MCSymbol MachineOperand.

LGTM.

Jul 9 2019, 12:36 PM · Restricted Project
sfertile committed rGf09d54ed2a75: Boilerplate for producing XCOFF object files from the PowerPC backend. (authored by sfertile).
Boilerplate for producing XCOFF object files from the PowerPC backend.
Jul 9 2019, 12:22 PM
sfertile committed rL365541: Boilerplate for producing XCOFF object files from the PowerPC backend..
Boilerplate for producing XCOFF object files from the PowerPC backend.
Jul 9 2019, 12:21 PM
sfertile closed D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
Jul 9 2019, 12:21 PM · Restricted Project
sfertile committed rG210314ae8c59: Try to appease the Windows build bots. (authored by sfertile).
Try to appease the Windows build bots.
Jul 9 2019, 11:46 AM
sfertile committed rL365535: Try to appease the Windows build bots..
Try to appease the Windows build bots.
Jul 9 2019, 11:44 AM
sfertile committed rG837ae69f8b9d: [Object][XCOFF] Add support for 64-bit file header and section header dumping. (authored by sfertile).
[Object][XCOFF] Add support for 64-bit file header and section header dumping.
Jul 9 2019, 11:11 AM
sfertile added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().
Jul 9 2019, 11:11 AM · Restricted Project
sfertile committed rL365524: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
[Object][XCOFF] Add support for 64-bit file header and section header dumping.
Jul 9 2019, 11:09 AM
sfertile closed D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Jul 9 2019, 11:09 AM · Restricted Project
sfertile added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().

I tried adding a dependency on TransformUtils to Analysis/LLVMBuild.txt but that generated:

CMake Error at CMakeLists.txt:711 (message):
  Unexpected failure executing llvm-build: llvm-build: fatal error: found
  cycle to u'Analysis' after following: u'AArch64CodeGen' (required library)
  -> u'Analysis' (required library) -> u'TransformUtils' (required library)
  -> Analysis

Does this mean that this change violates the dependency graph? Assuming you can repro, with -DBUILD_SHARED_LIBS=ON then perhaps we can revert this while a solution is found?

Jul 9 2019, 10:42 AM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Jul 9 2019, 9:59 AM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Jul 9 2019, 8:11 AM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Jul 9 2019, 7:59 AM · Restricted Project

Jul 8 2019

sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Jul 8 2019, 11:00 AM · Restricted Project

Jul 5 2019

sfertile updated the diff for D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
  • Various comment tweaks and spelling fixes.
  • Some indentation fixes and formatting changes.
  • Removed unreachable return statement.
  • Fixed error messages related to unsupported assembler pseudo ops.
  • Added some comments to test clarifying why we are checking for .text csect, and that the binary and text outputs don't represent the same XCOFF content.
Jul 5 2019, 12:21 PM · Restricted Project
sfertile accepted D64222: [sanitizers] Use covering ObjectFormatType switches.

LGTM.

Jul 5 2019, 8:15 AM · Restricted Project, Restricted Project
sfertile added inline comments to D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Jul 5 2019, 7:34 AM · Restricted Project
sfertile updated the diff for D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
  • Perform address arithmetic on const char* before casting to a uintptr_t.
Jul 5 2019, 7:30 AM · Restricted Project

Jul 4 2019

sfertile added inline comments to D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Jul 4 2019, 1:53 PM · Restricted Project
sfertile updated the diff for D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
  • Lots of tweaks to comments and whitespace.
    • Added assertion to 'getPointerToSymbolTable`
    • Changed name of local variable in getSymbolSectionName to be more descriptive.
    • Use checkOffset and getObject'in parseStringTable.
    • Changed unreachables to report_fatal_error in 'printSectionHeaders`.
    • Added TODO where overflow checking eventually needs to be done.
    • Added comment about DWARF subsection types, & limited section flag printing to the section type flags.
Jul 4 2019, 1:48 PM · Restricted Project