In D42047#1164773, @lebedev.ri wrote:In D42047#1164770, @Quolyk wrote:In D42047#1164762, @lebedev.ri wrote:Is it possible to add some unit test for this?

I have not seen that this header is explicitly tested, but it can be tested througn some libFunc pattern matches, as I hope to introduce some using this

unittests/IR/PatternMatch.cpp

- Queries
- All Stories
- Search
- Advanced Search

Feed Advanced Search

# Advanced Search

Advanced Search

# Yesterday

Yesterday

Sun, Jun 23, 2:42 AM · Restricted Project

# Feb 4 2019

Feb 4 2019

Feb 4 2019, 6:30 AM · Restricted Project

Quolyk retitled D42047: [PatternMatch] Implement matching code for LibFunc from Pattern matching code for LibFunc to [PatternMatch] Implement matching code for LibFunc.

Feb 4 2019, 6:27 AM · Restricted Project

Use TargetLibraryInfo::getLibFunc.

Feb 4 2019, 6:26 AM · Restricted Project

Quolyk retitled D41608: [InstCombine] Missed optimization in math expression: pow multiplications from [InstCombine] Missed optimization in math expression: aggressive optimization with pow to [InstCombine] Missed optimization in math expression: pow multiplications.

Feb 4 2019, 3:35 AM · Restricted Project

Quolyk updated the diff for D41608: [InstCombine] Missed optimization in math expression: pow multiplications.

Update tests. Apply patch only for pow multiplications. Pow divisions will be considered in different patch.

Feb 4 2019, 3:33 AM · Restricted Project

Commit tests for changes in revision D41608

Commit tests for changes in revision D41608

# Feb 2 2019

Feb 2 2019

Quolyk committed rL352981: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x….

[InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x…

Quolyk closed D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Feb 2 2019, 7:48 PM · Restricted Project

# Jan 31 2019

Jan 31 2019

Quolyk added a comment to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

In D41940#1378402, @lebedev.ri wrote:LG unless others have more comments (@spatel ?)

You probably know this already, but there are some other low-hanging fruit here, e.g.

https://godbolt.org/z/Trdf_e

https://www.wolframalpha.com/input/?i=log2(x)+%2F+log2(10)+%3D+log10(x)

Jan 31 2019, 1:25 AM · Restricted Project

# Jan 30 2019

Jan 30 2019

Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Update tests.

Jan 30 2019, 11:51 PM · Restricted Project

Commit tests for changes in revision D41940

Quolyk added a comment to D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

@spatel @lebedev.ri thank you for review and helping me get through.

Quolyk committed rL352730: [InstCombine] Missed optimization in math expression: simplify calls exp….

[InstCombine] Missed optimization in math expression: simplify calls exp…

Quolyk added inline comments to D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Quolyk added inline comments to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Jan 30 2019, 5:52 AM · Restricted Project

Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Update tests.

Commit tests for changes in revision D41342

# Jan 29 2019

Jan 29 2019

Quolyk added inline comments to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Jan 29 2019, 5:43 AM · Restricted Project

Quolyk added inline comments to D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Update tests.

# Jan 23 2019

Jan 23 2019

LGTM.

Quolyk added inline comments to D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

Quolyk added a comment to D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

I think we need to update docs as well.

[llvm-symbolizer] Allow single letter command flags grouping.

# Jan 22 2019

Jan 22 2019

Update test.

Move test to separate file.

llvm/test/tools/llvm-symbolizer/ and llvm/test/DebugInfo/llvm-symbolizer* pass successfully.

# Jan 21 2019

Jan 21 2019

Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Ping.

Jan 21 2019, 10:47 PM · Restricted Project

Quolyk updated the summary of D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Update tests.

@jhenderson thanks a lot for review and remarks. That is very valuable.

[llvm-symbolizer] Add -no-demangle as alias for -demangle=false

# Jan 20 2019

Jan 20 2019

Quolyk added inline comments to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Used clang-format -style='{ReflowComments: true}'.

# Jan 18 2019

Jan 18 2019

Quolyk added inline comments to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests.

# Jan 17 2019

Jan 17 2019

Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests.

Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests. Add logic. Honestly, I'm not good at writing llvm-symbolizer test, so I picked test that would fail if --demangle=true to test --demangle, --no-demangle order.

# Jan 16 2019

Jan 16 2019

I'm not sure how do I handle situation when -demange and -no-demangle appear in one command. I mean what precedence to use.

# Jan 15 2019

Jan 15 2019

[llvm-symbolizer] Add -C as a short alias to -demangle

Update tests

Quolyk updated the diff for D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

Patch is not yet fixed.

# Jan 14 2019

Jan 14 2019

Quolyk added a comment to D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

For now I just updated tests. The problem is in `BaseRange` definition, as it holds `EndLoc` and `BeginLoc` pointing to the beginning of ArrayExpression base https://github.com/llvm-mirror/clang-tools-extra/blob/e0441f6939da38f26bea9c1d75bb33024daa4e40/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp#L78. I'm investigating this.

Quolyk added a comment to D56635: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.

In D56635#1355791, @jhenderson wrote:In D56635#1355781, @jhenderson wrote:I'll file a bug for it, as it's probably worth fixing this all in one go.

[llvm-symbolizer] Add -addresses, -a as aliases for -print-address

In D56591#1354067, @jhenderson wrote:Could you add an ELF test for this too, please, to show the route through the Itanium demangler (and when it doesn't go through it for -C=false)?

Unfortunately, it looks like I don't have a pre-requisite either, so the pdb test is unsupported for me too. The test change looks safe, but adding the ELF test as well would give the extra reassurance.

Add test

# Jan 13 2019

Jan 13 2019

Quolyk added inline comments to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

Quolyk updated the diff for D56644: [clang-tidy] readability-container-size-empty handle std::string length().

Update tests. Handle length.

# Jan 12 2019

Jan 12 2019

Quolyk added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

In D56644#1355434, @lebedev.ri wrote:Either this is a NFC change with just tests, or the actual fix is missing.

Quolyk added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

For now, I just added tests. I have several questions, as I'm beginner (`ContainerSizeEmptyCheck.cpp`).

- Do I have to extend
`ValidContainer`, so it recognises`::std::string`with`length()`method as valid container too or we can assume`::std::string`as valid container by default? - If
`::std::string`is valid container, I just add one more expression to match. Is it correct way?

# Jan 11 2019

Jan 11 2019

I cannot have DIA SDK on my computer. As I see @jhenderson you have a Windows computer. Could you please write if tests are correct and in the right place. If there is a way to test it without DIA SDK any advice would be helpful.

[llvm-symbolizer] Add -exe, -e as aliases to -obj

Update tests

# Jan 10 2019

Jan 10 2019

[llvm-symbolizer] Add -p as alias to -pretty-print

FileCheck --check-prefix --> FileCheck -check-prefix

Add cl::NotHidden option

# Jul 17 2018

Jul 17 2018

Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Jul 17 2018, 4:32 AM · Restricted Project

In D42047#1164762, @lebedev.ri wrote:Is it possible to add some unit test for this?

Jul 17 2018, 3:04 AM · Restricted Project

Check if call isNoBuiltin

Jul 17 2018, 2:55 AM · Restricted Project

# Mar 17 2018

Mar 17 2018

Ping

Mar 17 2018, 12:44 AM · Restricted Project

Quolyk added a comment to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Ping

Mar 17 2018, 12:44 AM · Restricted Project

# Feb 23 2018

Feb 23 2018

Up. I guess it still needs to be merged as it introduces pattern matching for LibFuncs that would be quite usefull.

Feb 23 2018, 6:42 AM · Restricted Project

Feb 23 2018, 6:10 AM · Restricted Project

# Jan 30 2018

Jan 30 2018

Abandoning, as it was fixed in D42032

# Jan 17 2018

Jan 17 2018

Quolyk added inline comments to D41608: [InstCombine] Missed optimization in math expression: pow multiplications.

Jan 17 2018, 11:02 AM · Restricted Project

# Jan 14 2018

Jan 14 2018

Quolyk retitled D41608: [InstCombine] Missed optimization in math expression: pow multiplications from [WIP][InstCombine] Missed optimization in math expression: aggressive optimization with pow to [InstCombine] Missed optimization in math expression: aggressive optimization with pow.

Jan 14 2018, 11:58 PM · Restricted Project

Jan 14 2018, 11:16 PM · Restricted Project

# Jan 12 2018

Jan 12 2018

Quolyk added a comment to D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).

I'll try introduce llvm.tan intrinsic then in different patch

Quolyk added a comment to D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).

In D41283#974798, @spatel wrote:Why doesn't tan have an LLVM intrinsic like sin/cos?

# Jan 11 2018

Jan 11 2018

Quolyk created D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Jan 11 2018, 2:07 AM · Restricted Project

Quolyk updated the diff for D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).

This needs to be merged first, because it introduces m_LibFunc match, that would be useful for other optimizations.

# Jan 10 2018

Jan 10 2018

Quolyk updated subscribers of D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).

Quolyk committed rL322255: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).

[InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x)

# Jan 9 2018

Jan 9 2018