Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Quolyk added inline comments to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Fri, Jan 18, 4:42 AM
Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests.

Fri, Jan 18, 4:40 AM

Thu, Jan 17

Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests.

Thu, Jan 17, 7:08 AM
Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests. Add logic. Honestly, I'm not good at writing llvm-symbolizer test, so I picked test that would fail if --demangle=true to test --demangle, --no-demangle order.

Thu, Jan 17, 6:06 AM

Wed, Jan 16

Quolyk added a comment to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

I'm not sure how do I handle situation when -demange and -no-demangle appear in one command. I mean what precedence to use.

Wed, Jan 16, 12:18 AM
Quolyk created D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Wed, Jan 16, 12:16 AM

Tue, Jan 15

Quolyk committed rL351300: [llvm-symbolizer] Add -C as a short alias to -demangle.
[llvm-symbolizer] Add -C as a short alias to -demangle
Tue, Jan 15, 11:09 PM
Quolyk closed D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.
Tue, Jan 15, 11:09 PM
Quolyk updated the diff for D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

Update tests

Tue, Jan 15, 3:49 AM
Quolyk updated the diff for D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

Patch is not yet fixed.

Tue, Jan 15, 3:22 AM

Mon, Jan 14

Quolyk added a comment to D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

For now I just updated tests. The problem is in BaseRange definition, as it holds EndLoc and BeginLoc pointing to the beginning of ArrayExpression base https://github.com/llvm-mirror/clang-tools-extra/blob/e0441f6939da38f26bea9c1d75bb33024daa4e40/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp#L78. I'm investigating this.

Mon, Jan 14, 5:19 AM
Quolyk created D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.
Mon, Jan 14, 5:13 AM
Quolyk added a comment to D56635: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.

I'll file a bug for it, as it's probably worth fixing this all in one go.

https://bugs.llvm.org/show_bug.cgi?id=40304

Mon, Jan 14, 2:16 AM
Quolyk committed rL351043: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.
[llvm-symbolizer] Add -addresses, -a as aliases for -print-address
Mon, Jan 14, 2:14 AM
Quolyk closed D56635: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.
Mon, Jan 14, 2:14 AM
Quolyk added a comment to D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

Could you add an ELF test for this too, please, to show the route through the Itanium demangler (and when it doesn't go through it for -C=false)?

Unfortunately, it looks like I don't have a pre-requisite either, so the pdb test is unsupported for me too. The test change looks safe, but adding the ELF test as well would give the extra reassurance.

Mon, Jan 14, 2:00 AM
Quolyk updated the diff for D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

Add test

Mon, Jan 14, 1:59 AM

Sun, Jan 13

Quolyk added inline comments to D56644: [clang-tidy] readability-container-size-empty handle std::string length().
Sun, Jan 13, 3:12 AM · Restricted Project
Quolyk updated the diff for D56644: [clang-tidy] readability-container-size-empty handle std::string length().

Update tests. Handle length.

Sun, Jan 13, 3:01 AM · Restricted Project

Sat, Jan 12

Quolyk added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

Either this is a NFC change with just tests, or the actual fix is missing.

Sat, Jan 12, 11:35 PM · Restricted Project
Quolyk added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

For now, I just added tests. I have several questions, as I'm beginner (ContainerSizeEmptyCheck.cpp).

  1. Do I have to extend ValidContainer, so it recognises ::std::string with length() method as valid container too or we can assume ::std::string as valid container by default?
  2. If ::std::string is valid container, I just add one more expression to match. Is it correct way?
Sat, Jan 12, 11:34 PM · Restricted Project
Quolyk created D56644: [clang-tidy] readability-container-size-empty handle std::string length().
Sat, Jan 12, 11:26 PM · Restricted Project
Quolyk created D56635: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.
Sat, Jan 12, 3:34 AM

Fri, Jan 11

Quolyk added a comment to D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

I cannot have DIA SDK on my computer. As I see @jhenderson you have a Windows computer. Could you please write if tests are correct and in the right place. If there is a way to test it without DIA SDK any advice would be helpful.

Fri, Jan 11, 4:45 AM
Quolyk created D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.
Fri, Jan 11, 4:41 AM
Quolyk committed rL350925: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
[llvm-symbolizer] Add -exe, -e as aliases to -obj
Fri, Jan 11, 3:55 AM
Quolyk closed D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
Fri, Jan 11, 3:55 AM
Quolyk updated the diff for D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.

Update tests

Fri, Jan 11, 3:35 AM
Quolyk updated the summary of D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
Fri, Jan 11, 12:02 AM
Quolyk created D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
Fri, Jan 11, 12:00 AM

Thu, Jan 10

Quolyk committed rL350832: [llvm-symbolizer] Add -p as alias to -pretty-print.
[llvm-symbolizer] Add -p as alias to -pretty-print
Thu, Jan 10, 7:37 AM
Quolyk closed D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Thu, Jan 10, 7:37 AM
Quolyk added inline comments to D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Thu, Jan 10, 7:21 AM
Quolyk updated the diff for D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.

FileCheck --check-prefix --> FileCheck -check-prefix

Thu, Jan 10, 7:13 AM
Quolyk added inline comments to D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Thu, Jan 10, 7:03 AM
Quolyk updated the diff for D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.

Add cl::NotHidden option

Thu, Jan 10, 7:02 AM
Quolyk updated the summary of D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Thu, Jan 10, 6:12 AM
Quolyk added reviewers for D56542: [llvm-symbolizer] Add -p as alias to -pretty-print: samsonov, khemant, ruiu, rnk, fjricci.
Thu, Jan 10, 6:09 AM
Quolyk created D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Thu, Jan 10, 6:04 AM

Jul 17 2018

Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Jul 17 2018, 4:32 AM
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jul 17 2018, 4:13 AM
Quolyk added a comment to D42047: Pattern matching code for LibFunc.

Is it possible to add some unit test for this?

Jul 17 2018, 3:04 AM
Quolyk updated the diff for D42047: Pattern matching code for LibFunc.

Check if call isNoBuiltin

Jul 17 2018, 2:55 AM

Mar 17 2018

Quolyk added a comment to D42047: Pattern matching code for LibFunc.

Ping

Mar 17 2018, 12:44 AM
Quolyk added a comment to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Ping

Mar 17 2018, 12:44 AM

Feb 23 2018

Quolyk added a comment to D42047: Pattern matching code for LibFunc.

Up. I guess it still needs to be merged as it introduces pattern matching for LibFuncs that would be quite usefull.

Feb 23 2018, 6:42 AM
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Feb 23 2018, 6:22 AM
Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Feb 23 2018, 6:10 AM

Jan 30 2018

Quolyk abandoned D41554: [InstSimplify] Missed optimization in math expression: (x+x)/x == 2.

Abandoning, as it was fixed in D42032

Jan 30 2018, 5:02 AM

Jan 17 2018

Quolyk added inline comments to D41608: [InstCombine] Missed optimization in math expression: aggressive optimization with pow.
Jan 17 2018, 11:02 AM

Jan 14 2018

Quolyk retitled D41608: [InstCombine] Missed optimization in math expression: aggressive optimization with pow from [WIP][InstCombine] Missed optimization in math expression: aggressive optimization with pow to [InstCombine] Missed optimization in math expression: aggressive optimization with pow.
Jan 14 2018, 11:58 PM
Quolyk created D42047: Pattern matching code for LibFunc.
Jan 14 2018, 11:16 PM

Jan 12 2018

Quolyk added a comment to D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).

I'll try introduce llvm.tan intrinsic then in different patch

Jan 12 2018, 10:54 AM
Quolyk added a comment to D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).

Why doesn't tan have an LLVM intrinsic like sin/cos?

Jan 12 2018, 9:55 AM

Jan 11 2018

Quolyk created D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Jan 11 2018, 2:07 AM
Quolyk updated the diff for D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).

This needs to be merged first, because it introduces m_LibFunc match, that would be useful for other optimizations.

Jan 11 2018, 12:36 AM
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jan 11 2018, 12:00 AM

Jan 10 2018

Quolyk updated subscribers of D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).

@spatel @davide thanks for review and comments

Jan 10 2018, 10:39 PM
Quolyk committed rL322255: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).
[InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x)
Jan 10 2018, 10:34 PM
Quolyk closed D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).
Jan 10 2018, 10:34 PM

Jan 9 2018

Quolyk updated the diff for D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).
Jan 9 2018, 1:04 AM

Jan 7 2018

Quolyk updated the diff for D41608: [InstCombine] Missed optimization in math expression: aggressive optimization with pow.

pow(a, x) * a * a * a * a emits to

define double @pow_ab_x_aaaa_fast(double %a, double %x) {
  %1 = call fast double @llvm.pow.f64(double %a, double %x)
  %2 = fmul fast double %a, %a
  %3 = fmul fast double %2, %2
  %mul4 = fmul fast double %3, %1
  ret double %mul4
}

I don't see obvious ways to fold these instructions. I Would appreciate if somebody could help me with this.

Jan 7 2018, 9:53 AM
Quolyk updated the diff for D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).
Jan 7 2018, 12:49 AM

Jan 4 2018

Quolyk retitled D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a) from [WIP][InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a) to [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).
Jan 4 2018, 1:14 AM
Quolyk updated the diff for D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).

As in D41389 I have tan calls that are never used and never erased.

Jan 4 2018, 1:13 AM
Quolyk updated the diff for D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).
Jan 4 2018, 12:52 AM

Jan 3 2018

Quolyk committed rL321710: [InstSimplify] Missed optimization in math expression: squashing exp(log), log….
[InstSimplify] Missed optimization in math expression: squashing exp(log), log…
Jan 3 2018, 6:39 AM
Quolyk closed D41381: [InstSimplify] Missed optimization in math expression: squashing exp(log), log(exp).
Jan 3 2018, 6:38 AM
Quolyk updated the diff for D41381: [InstSimplify] Missed optimization in math expression: squashing exp(log), log(exp).

@spatel I updated diff, please take a look.

Jan 3 2018, 12:09 AM

Jan 2 2018

Quolyk updated the diff for D41381: [InstSimplify] Missed optimization in math expression: squashing exp(log), log(exp).

Updated tests

Jan 2 2018, 11:47 AM
Quolyk committed rL321648: NFC. Add description comments to Function header.
NFC. Add description comments to Function header
Jan 2 2018, 6:14 AM
Quolyk closed D41609: NFC. Add description comments to Function header.
Jan 2 2018, 6:14 AM
Quolyk added a comment to D41609: NFC. Add description comments to Function header.

It looks ok to me. I’d prefer the comments reflect the overloaded method parameters but it’s not necessary.

Jan 2 2018, 6:10 AM
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jan 2 2018, 4:22 AM
Quolyk updated the diff for D41381: [InstSimplify] Missed optimization in math expression: squashing exp(log), log(exp).

Moved to InstructionSimplify. This patch changed a bit, ping me if ok, I'll commit.

Jan 2 2018, 4:05 AM

Jan 1 2018

Quolyk committed rL321637: [InstCombine] Missed optimization in math expression: squashing sqrt functions.
[InstCombine] Missed optimization in math expression: squashing sqrt functions
Jan 1 2018, 9:59 PM
Quolyk closed D41322: [InstCombine] Missed optimization in math expression: squashing sqrt functions.
Jan 1 2018, 9:59 PM
Quolyk updated the summary of D41322: [InstCombine] Missed optimization in math expression: squashing sqrt functions.
Jan 1 2018, 9:57 PM
Quolyk committed rL321636: Test commit.
Test commit
Jan 1 2018, 9:48 PM
Quolyk closed D41561: Test commit.
Jan 1 2018, 9:48 PM

Dec 28 2017

Quolyk added a comment to D41322: [InstCombine] Missed optimization in math expression: squashing sqrt functions.

This isn't committed yet. Do you have access?

Dec 28 2017, 9:07 AM

Dec 27 2017

Quolyk added reviewers for D41609: NFC. Add description comments to Function header: davidxl, silvas, brzycki.
Dec 27 2017, 11:59 PM
Quolyk created D41609: NFC. Add description comments to Function header.
Dec 27 2017, 11:42 PM
Quolyk created D41608: [InstCombine] Missed optimization in math expression: aggressive optimization with pow.
Dec 27 2017, 11:30 PM

Dec 25 2017

Quolyk reopened D41561: Test commit.
Dec 25 2017, 11:45 PM
Quolyk closed D41561: Test commit.
Dec 25 2017, 11:31 PM

Dec 24 2017

Quolyk added inline comments to D41554: [InstSimplify] Missed optimization in math expression: (x+x)/x == 2.
Dec 24 2017, 4:17 AM
Quolyk accepted D41561: Test commit.
Dec 24 2017, 2:03 AM
Quolyk created D41561: Test commit.
Dec 24 2017, 2:02 AM

Dec 23 2017

Quolyk created D41554: [InstSimplify] Missed optimization in math expression: (x+x)/x == 2.
Dec 23 2017, 9:14 AM

Dec 22 2017

Quolyk added a comment to D41322: [InstCombine] Missed optimization in math expression: squashing sqrt functions.

@davide please accept the revision, if ok. I'll commit.

Dec 22 2017, 9:50 AM

Dec 21 2017

Quolyk updated the diff for D41322: [InstCombine] Missed optimization in math expression: squashing sqrt functions.
Dec 21 2017, 12:38 AM
Quolyk updated the diff for D41381: [InstSimplify] Missed optimization in math expression: squashing exp(log), log(exp).
Dec 21 2017, 12:26 AM

Dec 20 2017

Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Dec 20 2017, 11:45 PM
Quolyk requested review of D41381: [InstSimplify] Missed optimization in math expression: squashing exp(log), log(exp).
Dec 20 2017, 11:18 PM
Quolyk added a comment to D41381: [InstSimplify] Missed optimization in math expression: squashing exp(log), log(exp).

I don't have access to my checkout here, but I'm fairly sure we do something similar in SimplifyLibCalls.
I understand many of the pattern proposed will be duplicated, which is, not ideal.
Also, I'm pretty sure @scanon once taught me (when I implemented a similar transformation in simplifylibcalls) that these can underflow/overflow pretty dramatically, so, shouldn't these only be enabled under -ffast-math ?

Dec 20 2017, 11:10 PM
Quolyk updated the diff for D41283: [InstCombine] Missed optimization in math expression: tan(a) * cos(a) == sin(a).
Dec 20 2017, 11:02 PM
Quolyk added a comment to D40335: X86-specific path: Implemented the fusing of MUL+SUBADD to FMSUBADD.

@craig.topper please commit

Dec 20 2017, 9:47 AM
Quolyk added a comment to D40638: [AMDGPU, AsmParser] Enable the mnemonic spell corrector..

@arsenm please commit

Dec 20 2017, 9:44 AM
Quolyk added a comment to D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x).

@hfinkel I'd like to thank you for your help and patience reviewing my patches, as I'm new to the community. I hope it's ok when I include you as a reviewer.

Dec 20 2017, 4:31 AM