Page MenuHomePhabricator
Feed Advanced Search

Jul 15 2019

Quolyk committed rGcb238de456ba: [PatternMatch] Implement matching code for LibFunc (authored by Quolyk).
[PatternMatch] Implement matching code for LibFunc
Jul 15 2019, 7:49 AM
Quolyk committed rL366069: [PatternMatch] Implement matching code for LibFunc.
[PatternMatch] Implement matching code for LibFunc
Jul 15 2019, 7:48 AM
Quolyk closed D42047: [PatternMatch] Implement matching code for LibFunc.
Jul 15 2019, 7:48 AM · Restricted Project

Jul 12 2019

Quolyk updated the diff for D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

Update. Solution is not elegant, because DeclRef->BaseRange somehow has zero length.

Jul 12 2019, 7:53 AM · Restricted Project
Quolyk updated the diff for D42047: [PatternMatch] Implement matching code for LibFunc.

Minor update

Jul 12 2019, 4:35 AM · Restricted Project
Quolyk updated the diff for D42047: [PatternMatch] Implement matching code for LibFunc.

Add NoBuiltin tests.

Jul 12 2019, 4:34 AM · Restricted Project

Jul 11 2019

Quolyk updated the diff for D42047: [PatternMatch] Implement matching code for LibFunc.

Use NoBuiltin

Jul 11 2019, 12:19 AM · Restricted Project

Jul 10 2019

Quolyk updated the diff for D42047: [PatternMatch] Implement matching code for LibFunc.

Add negative tests

Jul 10 2019, 11:48 PM · Restricted Project

Jun 29 2019

Quolyk committed rG9e9eb62f9fd7: [APInt] Fix getBitsNeeded for INT_MIN values (authored by Quolyk).
[APInt] Fix getBitsNeeded for INT_MIN values
Jun 29 2019, 4:39 AM
Quolyk committed rL364710: [APInt] Fix getBitsNeeded for INT_MIN values.
[APInt] Fix getBitsNeeded for INT_MIN values
Jun 29 2019, 4:39 AM
Quolyk closed D63691: [APInt] Fix getBitsNeeded for INT_MIN values.
Jun 29 2019, 4:38 AM · Restricted Project

Jun 28 2019

Quolyk updated the diff for D63691: [APInt] Fix getBitsNeeded for INT_MIN values.

Update

Jun 28 2019, 5:27 AM · Restricted Project
Quolyk updated the diff for D42047: [PatternMatch] Implement matching code for LibFunc.

Add unit tests

Jun 28 2019, 5:11 AM · Restricted Project

Jun 23 2019

Quolyk created D63691: [APInt] Fix getBitsNeeded for INT_MIN values.
Jun 23 2019, 2:42 AM · Restricted Project

Feb 4 2019

Quolyk added a comment to D42047: [PatternMatch] Implement matching code for LibFunc.

Is it possible to add some unit test for this?

I have not seen that this header is explicitly tested, but it can be tested througn some libFunc pattern matches, as I hope to introduce some using this

unittests/IR/PatternMatch.cpp

Feb 4 2019, 6:30 AM · Restricted Project
Quolyk retitled D42047: [PatternMatch] Implement matching code for LibFunc from Pattern matching code for LibFunc to [PatternMatch] Implement matching code for LibFunc.
Feb 4 2019, 6:27 AM · Restricted Project
Quolyk updated the diff for D42047: [PatternMatch] Implement matching code for LibFunc.

Use TargetLibraryInfo::getLibFunc.

Feb 4 2019, 6:26 AM · Restricted Project
Quolyk retitled D41608: [InstCombine] Missed optimization in math expression: pow multiplications from [InstCombine] Missed optimization in math expression: aggressive optimization with pow to [InstCombine] Missed optimization in math expression: pow multiplications.
Feb 4 2019, 3:35 AM · Restricted Project
Quolyk updated the diff for D41608: [InstCombine] Missed optimization in math expression: pow multiplications.

Update tests. Apply patch only for pow multiplications. Pow divisions will be considered in different patch.

Feb 4 2019, 3:33 AM · Restricted Project
Quolyk committed rG3643cbbf9ca1: Commit tests for changes in revision D41608 (authored by Quolyk).
Commit tests for changes in revision D41608
Feb 4 2019, 2:32 AM
Quolyk committed rL353037: Commit tests for changes in revision D41608.
Commit tests for changes in revision D41608
Feb 4 2019, 2:32 AM

Feb 2 2019

Quolyk committed rL352981: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x….
[InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x…
Feb 2 2019, 7:48 PM
Quolyk closed D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Feb 2 2019, 7:48 PM · Restricted Project

Jan 31 2019

Quolyk added a comment to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

LG unless others have more comments (@spatel ?)
You probably know this already, but there are some other low-hanging fruit here, e.g.
https://godbolt.org/z/Trdf_e
https://www.wolframalpha.com/input/?i=log2(x)+%2F+log2(10)+%3D+log10(x)

Jan 31 2019, 1:25 AM · Restricted Project

Jan 30 2019

Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Update tests.

Jan 30 2019, 11:51 PM · Restricted Project
Quolyk committed rL352734: Commit tests for changes in revision D41940.
Commit tests for changes in revision D41940
Jan 30 2019, 11:39 PM
Quolyk added a comment to D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

@spatel @lebedev.ri thank you for review and helping me get through.

Jan 30 2019, 10:29 PM
Quolyk committed rL352730: [InstCombine] Missed optimization in math expression: simplify calls exp….
[InstCombine] Missed optimization in math expression: simplify calls exp…
Jan 30 2019, 10:28 PM
Quolyk closed D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jan 30 2019, 10:28 PM
Quolyk added inline comments to D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jan 30 2019, 6:00 AM
Quolyk added inline comments to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Jan 30 2019, 5:52 AM · Restricted Project
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Update tests.

Jan 30 2019, 5:42 AM
Quolyk committed rL352613: Commit tests for changes in revision D41342.
Commit tests for changes in revision D41342
Jan 30 2019, 1:50 AM

Jan 29 2019

Quolyk added inline comments to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Jan 29 2019, 5:43 AM · Restricted Project
Quolyk added inline comments to D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jan 29 2019, 5:37 AM
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Update tests.

Jan 29 2019, 5:34 AM

Jan 23 2019

Quolyk accepted D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

LGTM.

Jan 23 2019, 4:40 AM
Quolyk added inline comments to D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.
Jan 23 2019, 4:07 AM
Quolyk added a comment to D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

I think we need to update docs as well.

Jan 23 2019, 3:48 AM
Quolyk committed rL351936: [llvm-symbolizer] Allow single letter command flags grouping..
[llvm-symbolizer] Allow single letter command flags grouping.
Jan 23 2019, 1:49 AM
Quolyk closed D57046: [llvm-symbolizer] Allow single letter command flags grouping..
Jan 23 2019, 1:49 AM

Jan 22 2019

Quolyk updated the diff for D57046: [llvm-symbolizer] Allow single letter command flags grouping..

Update test.

Jan 22 2019, 11:22 PM
Quolyk updated the diff for D57046: [llvm-symbolizer] Allow single letter command flags grouping..

Move test to separate file.
llvm/test/tools/llvm-symbolizer/ and llvm/test/DebugInfo/llvm-symbolizer* pass successfully.

Jan 22 2019, 6:26 AM
Quolyk created D57046: [llvm-symbolizer] Allow single letter command flags grouping..
Jan 22 2019, 4:35 AM

Jan 21 2019

Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Ping.

Jan 21 2019, 10:47 PM · Restricted Project
Quolyk updated the summary of D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jan 21 2019, 6:55 AM
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.

Update tests.

Jan 21 2019, 6:42 AM
Quolyk added a comment to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

@jhenderson thanks a lot for review and remarks. That is very valuable.

Jan 21 2019, 2:03 AM
Quolyk committed rL351735: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
[llvm-symbolizer] Add -no-demangle as alias for -demangle=false
Jan 21 2019, 2:01 AM
Quolyk closed D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Jan 21 2019, 2:01 AM

Jan 20 2019

Quolyk added inline comments to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Jan 20 2019, 11:32 PM
Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Used clang-format -style='{ReflowComments: true}'.

Jan 20 2019, 11:27 PM

Jan 18 2019

Quolyk added inline comments to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Jan 18 2019, 4:42 AM
Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests.

Jan 18 2019, 4:40 AM

Jan 17 2019

Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests.

Jan 17 2019, 7:08 AM
Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Update tests. Add logic. Honestly, I'm not good at writing llvm-symbolizer test, so I picked test that would fail if --demangle=true to test --demangle, --no-demangle order.

Jan 17 2019, 6:06 AM

Jan 16 2019

Quolyk added a comment to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

I'm not sure how do I handle situation when -demange and -no-demangle appear in one command. I mean what precedence to use.

Jan 16 2019, 12:18 AM
Quolyk created D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Jan 16 2019, 12:16 AM

Jan 15 2019

Quolyk committed rL351300: [llvm-symbolizer] Add -C as a short alias to -demangle.
[llvm-symbolizer] Add -C as a short alias to -demangle
Jan 15 2019, 11:09 PM
Quolyk closed D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.
Jan 15 2019, 11:09 PM
Quolyk updated the diff for D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

Update tests

Jan 15 2019, 3:49 AM
Quolyk updated the diff for D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

Patch is not yet fixed.

Jan 15 2019, 3:22 AM · Restricted Project

Jan 14 2019

Quolyk added a comment to D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

For now I just updated tests. The problem is in BaseRange definition, as it holds EndLoc and BeginLoc pointing to the beginning of ArrayExpression base https://github.com/llvm-mirror/clang-tools-extra/blob/e0441f6939da38f26bea9c1d75bb33024daa4e40/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp#L78. I'm investigating this.

Jan 14 2019, 5:19 AM · Restricted Project
Quolyk created D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.
Jan 14 2019, 5:13 AM · Restricted Project
Quolyk added a comment to D56635: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.

I'll file a bug for it, as it's probably worth fixing this all in one go.

https://bugs.llvm.org/show_bug.cgi?id=40304

Jan 14 2019, 2:16 AM
Quolyk committed rL351043: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.
[llvm-symbolizer] Add -addresses, -a as aliases for -print-address
Jan 14 2019, 2:14 AM
Quolyk closed D56635: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.
Jan 14 2019, 2:14 AM
Quolyk added a comment to D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

Could you add an ELF test for this too, please, to show the route through the Itanium demangler (and when it doesn't go through it for -C=false)?

Unfortunately, it looks like I don't have a pre-requisite either, so the pdb test is unsupported for me too. The test change looks safe, but adding the ELF test as well would give the extra reassurance.

Jan 14 2019, 2:00 AM
Quolyk updated the diff for D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

Add test

Jan 14 2019, 1:59 AM

Jan 13 2019

Quolyk added inline comments to D56644: [clang-tidy] readability-container-size-empty handle std::string length().
Jan 13 2019, 3:12 AM · Restricted Project, Restricted Project
Quolyk updated the diff for D56644: [clang-tidy] readability-container-size-empty handle std::string length().

Update tests. Handle length.

Jan 13 2019, 3:01 AM · Restricted Project, Restricted Project

Jan 12 2019

Quolyk added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

Either this is a NFC change with just tests, or the actual fix is missing.

Jan 12 2019, 11:35 PM · Restricted Project, Restricted Project
Quolyk added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

For now, I just added tests. I have several questions, as I'm beginner (ContainerSizeEmptyCheck.cpp).

  1. Do I have to extend ValidContainer, so it recognises ::std::string with length() method as valid container too or we can assume ::std::string as valid container by default?
  2. If ::std::string is valid container, I just add one more expression to match. Is it correct way?
Jan 12 2019, 11:34 PM · Restricted Project, Restricted Project
Quolyk created D56644: [clang-tidy] readability-container-size-empty handle std::string length().
Jan 12 2019, 11:26 PM · Restricted Project, Restricted Project
Quolyk created D56635: [llvm-symbolizer] Add -addresses, -a as aliases for -print-address.
Jan 12 2019, 3:34 AM

Jan 11 2019

Quolyk added a comment to D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.

I cannot have DIA SDK on my computer. As I see @jhenderson you have a Windows computer. Could you please write if tests are correct and in the right place. If there is a way to test it without DIA SDK any advice would be helpful.

Jan 11 2019, 4:45 AM
Quolyk created D56591: [llvm-symbolizer] Add -C as a short alias to -demangle.
Jan 11 2019, 4:41 AM
Quolyk committed rL350925: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
[llvm-symbolizer] Add -exe, -e as aliases to -obj
Jan 11 2019, 3:55 AM
Quolyk closed D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
Jan 11 2019, 3:55 AM
Quolyk updated the diff for D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.

Update tests

Jan 11 2019, 3:35 AM
Quolyk updated the summary of D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
Jan 11 2019, 12:02 AM
Quolyk created D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj.
Jan 11 2019, 12:00 AM

Jan 10 2019

Quolyk committed rL350832: [llvm-symbolizer] Add -p as alias to -pretty-print.
[llvm-symbolizer] Add -p as alias to -pretty-print
Jan 10 2019, 7:37 AM
Quolyk closed D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Jan 10 2019, 7:37 AM
Quolyk added inline comments to D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Jan 10 2019, 7:21 AM
Quolyk updated the diff for D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.

FileCheck --check-prefix --> FileCheck -check-prefix

Jan 10 2019, 7:13 AM
Quolyk added inline comments to D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Jan 10 2019, 7:03 AM
Quolyk updated the diff for D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.

Add cl::NotHidden option

Jan 10 2019, 7:02 AM
Quolyk updated the summary of D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Jan 10 2019, 6:12 AM
Quolyk added reviewers for D56542: [llvm-symbolizer] Add -p as alias to -pretty-print: samsonov, khemant, ruiu, rnk, fjricci.
Jan 10 2019, 6:09 AM
Quolyk created D56542: [llvm-symbolizer] Add -p as alias to -pretty-print.
Jan 10 2019, 6:04 AM

Jul 17 2018

Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Jul 17 2018, 4:32 AM · Restricted Project
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Jul 17 2018, 4:13 AM
Quolyk added a comment to D42047: [PatternMatch] Implement matching code for LibFunc.

Is it possible to add some unit test for this?

Jul 17 2018, 3:04 AM · Restricted Project
Quolyk updated the diff for D42047: [PatternMatch] Implement matching code for LibFunc.

Check if call isNoBuiltin

Jul 17 2018, 2:55 AM · Restricted Project

Mar 17 2018

Quolyk added a comment to D42047: [PatternMatch] Implement matching code for LibFunc.

Ping

Mar 17 2018, 12:44 AM · Restricted Project
Quolyk added a comment to D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.

Ping

Mar 17 2018, 12:44 AM · Restricted Project

Feb 23 2018

Quolyk added a comment to D42047: [PatternMatch] Implement matching code for LibFunc.

Up. I guess it still needs to be merged as it introduces pattern matching for LibFuncs that would be quite usefull.

Feb 23 2018, 6:42 AM · Restricted Project
Quolyk updated the diff for D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions.
Feb 23 2018, 6:22 AM
Quolyk updated the diff for D41940: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x.
Feb 23 2018, 6:10 AM · Restricted Project