Page MenuHomePhabricator
Feed Advanced Search

Wed, Sep 18

paquette committed rGce65ebc39e5b: [AArch64][GlobalISel] Support lowering musttail calls (authored by paquette).
[AArch64][GlobalISel] Support lowering musttail calls
Wed, Sep 18, 3:45 PM
paquette committed rL372273: [AArch64][GlobalISel] Support lowering musttail calls.
[AArch64][GlobalISel] Support lowering musttail calls
Wed, Sep 18, 3:45 PM
paquette closed D67681: [AArch64][GlobalISel] Support lowering musttail calls.
Wed, Sep 18, 3:45 PM · Restricted Project
paquette updated the diff for D67681: [AArch64][GlobalISel] Support lowering musttail calls.

Add test verifying that we fall back to SelectionDAG and die when a musttail call is not lowered as a tail call.

Wed, Sep 18, 3:12 PM · Restricted Project
paquette accepted D67724: [AArch64] Don't implicitly enable global isel on Darwin if code-model==large..

LGTM

Wed, Sep 18, 12:56 PM · Restricted Project

Tue, Sep 17

paquette created D67681: [AArch64][GlobalISel] Support lowering musttail calls.
Tue, Sep 17, 3:03 PM · Restricted Project
paquette committed rG8a4d9f04b51a: [AArch64][GlobalISel] Support -tailcallopt (authored by paquette).
[AArch64][GlobalISel] Support -tailcallopt
Tue, Sep 17, 1:25 PM
paquette committed rL372177: [AArch64][GlobalISel] Support -tailcallopt.
[AArch64][GlobalISel] Support -tailcallopt
Tue, Sep 17, 1:22 PM
paquette closed D67580: [AArch64][GlobalISel] Support -tailcallopt.
Tue, Sep 17, 1:22 PM · Restricted Project
paquette committed rGd16cf40f8c35: [AArch64][GlobalISel][NFC] Refactor tail call lowering code (authored by paquette).
[AArch64][GlobalISel][NFC] Refactor tail call lowering code
Tue, Sep 17, 12:12 PM
paquette committed rL372164: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
[AArch64][GlobalISel][NFC] Refactor tail call lowering code
Tue, Sep 17, 12:07 PM
paquette closed D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
Tue, Sep 17, 12:06 PM · Restricted Project

Fri, Sep 13

paquette added a parent revision for D67580: [AArch64][GlobalISel] Support -tailcallopt: D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
Fri, Sep 13, 3:54 PM · Restricted Project
paquette added a child revision for D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code: D67580: [AArch64][GlobalISel] Support -tailcallopt.
Fri, Sep 13, 3:54 PM · Restricted Project
paquette created D67580: [AArch64][GlobalISel] Support -tailcallopt.
Fri, Sep 13, 3:54 PM · Restricted Project
paquette created D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
Fri, Sep 13, 3:20 PM · Restricted Project
paquette committed rG727328ab63b2: [AArch64][GlobalISel] Tail call memory intrinsics (authored by paquette).
[AArch64][GlobalISel] Tail call memory intrinsics
Fri, Sep 13, 1:32 PM
paquette committed rL371893: [AArch64][GlobalISel] Tail call memory intrinsics.
[AArch64][GlobalISel] Tail call memory intrinsics
Fri, Sep 13, 1:24 PM
paquette closed D67566: [AArch64][GlobalISel] Tail call memory intrinsics.
Fri, Sep 13, 1:24 PM · Restricted Project
paquette updated the diff for D67566: [AArch64][GlobalISel] Tail call memory intrinsics.

Update comments, add -global-isel-abort=1 to test

Fri, Sep 13, 11:52 AM · Restricted Project
paquette updated the diff for D67566: [AArch64][GlobalISel] Tail call memory intrinsics.

Add missing check for when the return is a tail call.

Fri, Sep 13, 11:17 AM · Restricted Project
paquette created D67566: [AArch64][GlobalISel] Tail call memory intrinsics.
Fri, Sep 13, 10:40 AM · Restricted Project
paquette committed rG14bfb56b1aea: [AArch64][GlobalISel] Add support for sibcalling callees with varargs (authored by paquette).
[AArch64][GlobalISel] Add support for sibcalling callees with varargs
Fri, Sep 13, 9:10 AM
paquette committed rL371868: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
[AArch64][GlobalISel] Add support for sibcalling callees with varargs
Fri, Sep 13, 9:08 AM
paquette closed D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
Fri, Sep 13, 9:08 AM · Restricted Project

Thu, Sep 12

paquette committed rG0c283cb50418: [AArch64][GlobalISel] Support tail calling with swiftself parameters (authored by paquette).
[AArch64][GlobalISel] Support tail calling with swiftself parameters
Thu, Sep 12, 4:05 PM
paquette committed rL371788: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
[AArch64][GlobalISel] Support tail calling with swiftself parameters
Thu, Sep 12, 4:00 PM
paquette closed D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
Thu, Sep 12, 4:00 PM · Restricted Project
paquette committed rGa42070a6aa8f: [AArch64][GlobalISel] Support sibling calls with outgoing arguments (authored by paquette).
[AArch64][GlobalISel] Support sibling calls with outgoing arguments
Thu, Sep 12, 3:13 PM
paquette committed rL371780: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
[AArch64][GlobalISel] Support sibling calls with outgoing arguments
Thu, Sep 12, 3:09 PM
paquette closed D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Thu, Sep 12, 3:08 PM · Restricted Project
paquette added a parent revision for D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs: D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Thu, Sep 12, 1:41 PM · Restricted Project
paquette created D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
Thu, Sep 12, 1:41 PM · Restricted Project
paquette added a child revision for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments: D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
Thu, Sep 12, 1:41 PM · Restricted Project
paquette added a parent revision for D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters: D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Thu, Sep 12, 12:04 PM · Restricted Project
paquette created D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
Thu, Sep 12, 12:04 PM · Restricted Project
paquette added a child revision for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments: D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
Thu, Sep 12, 12:04 PM · Restricted Project
paquette accepted D67333: DAG/GlobalISel: Correct type profile of bitcount ops.

I think this seems reasonable.

Thu, Sep 12, 9:20 AM
paquette updated the diff for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.

Improve comment

Thu, Sep 12, 9:14 AM · Restricted Project
paquette added inline comments to D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Thu, Sep 12, 9:14 AM · Restricted Project

Wed, Sep 11

paquette committed rGe297ad1bd964: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility (authored by paquette).
[GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility
Wed, Sep 11, 4:44 PM
paquette committed rL371692: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
[GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility
Wed, Sep 11, 4:44 PM
paquette closed D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
Wed, Sep 11, 4:44 PM · Restricted Project
paquette added a parent revision for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments: D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
Wed, Sep 11, 3:10 PM · Restricted Project
paquette created D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Wed, Sep 11, 3:10 PM · Restricted Project
paquette added a child revision for D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility: D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Wed, Sep 11, 3:10 PM · Restricted Project
paquette created D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
Wed, Sep 11, 1:50 PM · Restricted Project
paquette added inline comments to D66210: [RFC/WIP][RISCV] Enable the machine outliner for RISC-V.
Wed, Sep 11, 11:08 AM · Restricted Project

Tue, Sep 10

paquette committed rG469d42fcf6b6: [GlobalISel] When a tail call is emitted in a block, stop translating it (authored by paquette).
[GlobalISel] When a tail call is emitted in a block, stop translating it
Tue, Sep 10, 4:35 PM
paquette committed rL371572: [GlobalISel] When a tail call is emitted in a block, stop translating it.
[GlobalISel] When a tail call is emitted in a block, stop translating it
Tue, Sep 10, 4:33 PM
paquette closed D67415: [GlobalISel] When a tail call is emitted in a block, stop translating it.
Tue, Sep 10, 4:33 PM · Restricted Project
paquette committed rG2af5b193d5e5: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions (authored by paquette).
[AArch64][GlobalISel] Support sibling calls with mismatched calling conventions
Tue, Sep 10, 4:25 PM
paquette committed rL371570: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions.
[AArch64][GlobalISel] Support sibling calls with mismatched calling conventions
Tue, Sep 10, 4:23 PM
paquette closed D67361: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions.
Tue, Sep 10, 4:23 PM · Restricted Project
paquette created D67415: [GlobalISel] When a tail call is emitted in a block, stop translating it.
Tue, Sep 10, 2:10 PM · Restricted Project

Mon, Sep 9

paquette created D67361: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions.
Mon, Sep 9, 10:34 AM · Restricted Project
paquette committed rGbfb00e3d536e: [GlobalISel][AArch64] Handle tail calls with non-void return types (authored by paquette).
[GlobalISel][AArch64] Handle tail calls with non-void return types
Mon, Sep 9, 10:16 AM
paquette committed rL371425: [GlobalISel][AArch64] Handle tail calls with non-void return types.
[GlobalISel][AArch64] Handle tail calls with non-void return types
Mon, Sep 9, 10:15 AM
paquette closed D67282: [GlobalISel][AArch64] Handle tail calls with non-void return types.
Mon, Sep 9, 10:15 AM · Restricted Project

Fri, Sep 6

paquette accepted D67303: [AArch64][GlobalISel] Enable the localizer for optimized builds.

LGTM

Fri, Sep 6, 2:50 PM · Restricted Project
paquette committed rG121d9114f567: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt (authored by paquette).
[AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt
Fri, Sep 6, 9:49 AM
paquette committed rL371227: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt.
[AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt
Fri, Sep 6, 9:49 AM
paquette closed D67245: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt.
Fri, Sep 6, 9:49 AM · Restricted Project
paquette created D67282: [GlobalISel][AArch64] Handle tail calls with non-void return types.
Fri, Sep 6, 9:00 AM · Restricted Project

Thu, Sep 5

paquette accepted D67104: GlobalISel/TableGen: Fix handling of EXTRACT_SUBREG constraints.

LGTM in any case; I think it would be good to find out why the register class can come out wrong though.

Thu, Sep 5, 4:37 PM
paquette created D67245: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt.
Thu, Sep 5, 4:25 PM · Restricted Project
paquette committed rG20e866709882: Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic… (authored by paquette).
Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic…
Thu, Sep 5, 1:21 PM
paquette committed rL371114: Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic….
Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic…
Thu, Sep 5, 1:20 PM
paquette added a comment to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.

Fixed the issue. Issue was that I never tested returning something other than void. I disabled tail calling calls with non-void return types, and updated the test to reflect that.

Thu, Sep 5, 1:20 PM · Restricted Project
paquette accepted D67209: [MIR] MIR Namer pass.

LGTM

Thu, Sep 5, 12:50 PM · Restricted Project
paquette added inline comments to D67209: [MIR] MIR Namer pass.
Thu, Sep 5, 10:55 AM · Restricted Project
paquette added a comment to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.

@RKSimon Sorry about that. I'll enable EXPENSIVE_CHECKS.

Thu, Sep 5, 9:10 AM · Restricted Project

Wed, Sep 4

paquette committed rGb78324fc4087: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls (authored by paquette).
[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls
Wed, Sep 4, 3:57 PM
paquette committed rL370996: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls
Wed, Sep 4, 3:57 PM
paquette closed D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Wed, Sep 4, 3:57 PM · Restricted Project
paquette added a comment to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.

I'm going to commit this as-is and put up a separate review for remarks.

Wed, Sep 4, 3:43 PM · Restricted Project
paquette added inline comments to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Wed, Sep 4, 3:36 PM · Restricted Project
paquette added inline comments to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Wed, Sep 4, 11:47 AM · Restricted Project
paquette added inline comments to D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE.
Wed, Sep 4, 11:38 AM · Restricted Project
paquette accepted D67187: GlobalISel: Add basic legalization for G_BITREVERSE.

LGTM

Wed, Sep 4, 11:25 AM
paquette accepted D67136: GlobalISel/TableGen: Handle REG_SEQUENCE patterns.

LGTM with style nit

Wed, Sep 4, 11:21 AM
paquette created D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Wed, Sep 4, 11:13 AM · Restricted Project
paquette accepted D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

LGTM with some nits on comments.

Wed, Sep 4, 10:34 AM · Restricted Project

Tue, Sep 3

paquette accepted D66180: [GlobalISel][CallLowering] Add support for splitting types according to calling conventions.

LGTM

Tue, Sep 3, 2:27 PM · Restricted Project
paquette added a comment to D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

This is just code movement, but still a couple of nits/questions.

Tue, Sep 3, 11:26 AM · Restricted Project
paquette committed rG15036acb0587: [AArch64][GlobalISel] Don't import i64imm_32bit pattern at -O0 (authored by paquette).
[AArch64][GlobalISel] Don't import i64imm_32bit pattern at -O0
Tue, Sep 3, 10:21 AM
paquette committed rL370789: [AArch64][GlobalISel] Don't import i64imm_32bit pattern at -O0.
[AArch64][GlobalISel] Don't import i64imm_32bit pattern at -O0
Tue, Sep 3, 10:20 AM
paquette closed D67027: [AArch64][GlobalISel] Don't import i64imm_32bit pattern at -O0.
Tue, Sep 3, 10:20 AM · Restricted Project
paquette added inline comments to D66210: [RFC/WIP][RISCV] Enable the machine outliner for RISC-V.
Tue, Sep 3, 10:18 AM · Restricted Project
paquette accepted D66402: AMDGPU/GlobalISel: Select atomic loads.

LGTM

Tue, Sep 3, 10:00 AM
paquette accepted D67100: GlobalISel/TableGen: Don't skip REG_SEQUENCE based on patterns.

I'm pretty sure this should fall back considering that in the past, INSERT_SUBREG (which wasn't checked for) did. So, LGTM.

Tue, Sep 3, 9:51 AM
paquette added inline comments to D67104: GlobalISel/TableGen: Fix handling of EXTRACT_SUBREG constraints.
Tue, Sep 3, 9:51 AM
paquette added inline comments to D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Tue, Sep 3, 9:41 AM · Restricted Project
paquette added inline comments to D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Tue, Sep 3, 9:35 AM · Restricted Project
paquette added a comment to D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..

+1 for a separate pass. If we're going for an equivalent of -instnamer, I think it makes sense to keep the mode of use consistent.

Tue, Sep 3, 9:27 AM · Restricted Project
paquette added a comment to D67100: GlobalISel/TableGen: Don't skip REG_SEQUENCE based on patterns.

Testcase to verify that we still reject it?

Tue, Sep 3, 9:18 AM
paquette added inline comments to D67104: GlobalISel/TableGen: Fix handling of EXTRACT_SUBREG constraints.
Tue, Sep 3, 9:18 AM

Fri, Aug 30

paquette created D67027: [AArch64][GlobalISel] Don't import i64imm_32bit pattern at -O0.
Fri, Aug 30, 4:16 PM · Restricted Project

Thu, Aug 29

paquette committed rG04e657be2875: [AArch64][GlobalISel] Select arithmetic extended register patterns (authored by paquette).
[AArch64][GlobalISel] Select arithmetic extended register patterns
Thu, Aug 29, 2:54 PM
paquette committed rL370410: [AArch64][GlobalISel] Select arithmetic extended register patterns.
[AArch64][GlobalISel] Select arithmetic extended register patterns
Thu, Aug 29, 2:54 PM