Page MenuHomePhabricator
Feed Advanced Search

Yesterday

rriddle accepted D95021: [mlir] Support FuncOpSignatureConversion for more FunctionLike ops..

LGTM. Thanks!

Thu, Jan 21, 3:36 PM · Restricted Project
rriddle accepted D94868: [mlir] Enable passing crash reproducer stream factory method.

LGTM with Mehdi's comments addressed.

Thu, Jan 21, 3:22 PM · Restricted Project, Restricted Project
rriddle added inline comments to D95153: [mlir][Linalg] Make Fill operation work on tensors..
Thu, Jan 21, 1:34 PM · Restricted Project
rriddle added a comment to D95105: Implement constant folding for PowFOp.

Thanks for adding the folding!

Thu, Jan 21, 10:58 AM · Restricted Project
rriddle added inline comments to D95149: [mlir][Linalg] Add a padding option to Linalg tiling.
Thu, Jan 21, 10:02 AM · Restricted Project
rriddle accepted D95123: Remove deprecated methods from OpState..
Thu, Jan 21, 9:43 AM · Restricted Project

Wed, Jan 20

rriddle requested review of D95109: [mlir][OpFormatGen] Add support for anchoring optional groups with types.
Wed, Jan 20, 6:20 PM · Restricted Project
rriddle added inline comments to D95021: [mlir] Support FuncOpSignatureConversion for more FunctionLike ops..
Wed, Jan 20, 6:13 PM · Restricted Project
rriddle added a comment to D95105: Implement constant folding for PowFOp.

Since MLIR is also handling tensors and vectors, I'm not entirely sure how this check would be implemented (i.e. the operands can't always be cast to FloatAttr). The function constFoldBinaryOp currently handles these cases, so we'd have to re-implement some of that logic. Does someone with more experience with the existing folders have any good ideas about this?

Wed, Jan 20, 5:20 PM · Restricted Project
rriddle committed rG825c2b4a41c7: [mlir][OpFormatGen] Fix incorrect kind used for RegionsDirective (authored by rriddle).
[mlir][OpFormatGen] Fix incorrect kind used for RegionsDirective
Wed, Jan 20, 4:55 PM
rriddle closed D94988: [mlir][OpFormatGen] Fix incorrect kind used for RegionsDirective.
Wed, Jan 20, 4:55 PM · Restricted Project
rriddle added inline comments to D95105: Implement constant folding for PowFOp.
Wed, Jan 20, 4:41 PM · Restricted Project
rriddle committed rGc78219f644c7: [mlir] Add a new builtin `unrealized_conversion_cast` operation (authored by rriddle).
[mlir] Add a new builtin `unrealized_conversion_cast` operation
Wed, Jan 20, 4:28 PM
rriddle committed rG6ccf2d62b487: [mlir] Add an interface for Cast-Like operations (authored by rriddle).
[mlir] Add an interface for Cast-Like operations
Wed, Jan 20, 4:28 PM
rriddle closed D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Wed, Jan 20, 4:28 PM · Restricted Project
rriddle closed D94831: [mlir] Add an interface for Cast-Like operations.
Wed, Jan 20, 4:28 PM · Restricted Project
rriddle added inline comments to D95021: [mlir] Support FuncOpSignatureConversion for more FunctionLike ops..
Wed, Jan 20, 4:21 PM · Restricted Project

Tue, Jan 19

rriddle added inline comments to D95021: [mlir] Support FuncOpSignatureConversion for more FunctionLike ops..
Tue, Jan 19, 10:00 PM · Restricted Project
rriddle added inline comments to D95022: Add Python bindings for the builtin dialect.
Tue, Jan 19, 9:56 PM · Restricted Project
rriddle added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Tue, Jan 19, 2:46 PM · Restricted Project, Restricted Project
rriddle added inline comments to D94994: [mlir][splitting std] move 2 more ops to `tensor`.
Tue, Jan 19, 2:17 PM · Restricted Project
rriddle added inline comments to D94994: [mlir][splitting std] move 2 more ops to `tensor`.
Tue, Jan 19, 1:51 PM · Restricted Project
rriddle added inline comments to D95000: [mlir:async] Use ODS to define async types.
Tue, Jan 19, 1:44 PM · Restricted Project
rriddle added a comment to D95000: [mlir:async] Use ODS to define async types.

Nice cleanup!

Tue, Jan 19, 1:42 PM · Restricted Project
rriddle accepted D95000: [mlir:async] Use ODS to define async types.
Tue, Jan 19, 1:42 PM · Restricted Project
rriddle accepted D94994: [mlir][splitting std] move 2 more ops to `tensor`.
Tue, Jan 19, 12:46 PM · Restricted Project
rriddle updated the diff for D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.

Address feedback

Tue, Jan 19, 12:42 PM · Restricted Project
rriddle updated the diff for D94831: [mlir] Add an interface for Cast-Like operations.

Address feedback

Tue, Jan 19, 12:41 PM · Restricted Project
rriddle requested review of D94988: [mlir][OpFormatGen] Fix incorrect kind used for RegionsDirective.
Tue, Jan 19, 11:25 AM · Restricted Project

Fri, Jan 15

rriddle added inline comments to D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 10:32 PM · Restricted Project
rriddle added a comment to D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.

Out of curiosity: may I please have some context for what this base class is being created for? Ie, what consumers other than the existing PatternRewriter will soon exist? :)

Fri, Jan 15, 8:25 PM · Restricted Project
rriddle updated the summary of D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 6:44 PM · Restricted Project
rriddle added inline comments to D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 6:44 PM · Restricted Project
rriddle added inline comments to D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 6:44 PM · Restricted Project
rriddle updated the diff for D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.

Address most comments

Fri, Jan 15, 6:43 PM · Restricted Project
rriddle updated the diff for D94831: [mlir] Add an interface for Cast-Like operations.

Address comments

Fri, Jan 15, 6:43 PM · Restricted Project
rriddle retitled D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation from [mlir] Add a new builtin `partial_conversion_cast` operation to [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 6:43 PM · Restricted Project
rriddle committed rG2a27a9819a1e: [mlir][AsmPrinter] Properly escape strings when printing locations (authored by rriddle).
[mlir][AsmPrinter] Properly escape strings when printing locations
Fri, Jan 15, 5:15 PM
rriddle closed D94847: [mlir][AsmPrinter] Properly escape strings when printing locations.
Fri, Jan 15, 5:15 PM · Restricted Project
rriddle requested review of D94847: [mlir][AsmPrinter] Properly escape strings when printing locations.
Fri, Jan 15, 4:55 PM · Restricted Project
rriddle updated the diff for D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.

Rebase

Fri, Jan 15, 3:36 PM · Restricted Project
rriddle updated the diff for D94831: [mlir] Add an interface for Cast-Like operations.

Fix accidental incorrect behavior for casts

Fri, Jan 15, 3:36 PM · Restricted Project
rriddle updated the summary of D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 3:36 PM · Restricted Project
rriddle added inline comments to D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 3:02 PM · Restricted Project
rriddle added inline comments to D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 2:55 PM · Restricted Project
rriddle requested review of D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 2:48 PM · Restricted Project
rriddle requested review of D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 2:48 PM · Restricted Project

Thu, Jan 14

rriddle added inline comments to D94737: [mlir] Add better support for f80 and f128.
Thu, Jan 14, 6:46 PM · Restricted Project
rriddle accepted D94737: [mlir] Add better support for f80 and f128.

Did a pass through, and looks good to me.

Thu, Jan 14, 6:18 PM · Restricted Project
rriddle added a comment to D94662: [mlir] Remove over specified memory effects.

Should I get more reviews, or should I arc land this now?

Thu, Jan 14, 2:29 PM · Restricted Project
rriddle accepted D94662: [mlir] Remove over specified memory effects.

Thanks!

Thu, Jan 14, 12:29 PM · Restricted Project
rriddle accepted D94706: [mlir] Remove TosaToLinalg dependency on all Passes.
Thu, Jan 14, 12:07 PM · Restricted Project
rriddle committed rGc8fb6ee34151: [mlir][PatternRewriter] Add a new hook to selectively replace uses of an… (authored by rriddle).
[mlir][PatternRewriter] Add a new hook to selectively replace uses of an…
Thu, Jan 14, 12:05 PM
rriddle closed D94632: [mlir][PatternRewriter] Add a new hook to selectively replace uses of an operation.
Thu, Jan 14, 12:05 PM · Restricted Project
rriddle committed rG93592b726c75: [mlir][OpFormatGen] Format enum attribute cases as keywords when possible (authored by rriddle).
[mlir][OpFormatGen] Format enum attribute cases as keywords when possible
Thu, Jan 14, 11:43 AM
rriddle committed rG00a61b327dd8: [mlir][ODS] Add new RangedTypesMatchWith operation predicate (authored by rriddle).
[mlir][ODS] Add new RangedTypesMatchWith operation predicate
Thu, Jan 14, 11:43 AM
rriddle closed D94575: [mlir][OpFormatGen] Format enum attribute cases as keywords when possible.
Thu, Jan 14, 11:43 AM · Restricted Project
rriddle closed D94574: [mlir][ODS] Add new RangedTypesMatchWith operation predicate.
Thu, Jan 14, 11:43 AM · Restricted Project
rriddle accepted D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Awesome!

Thu, Jan 14, 11:16 AM · Restricted Project

Wed, Jan 13

rriddle accepted D94651: [mlir] Update doc to omit the usage of LLVMIntegerType.
Wed, Jan 13, 10:03 PM · Restricted Project
rriddle added a comment to D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.

I went with IRRewriterImpl as this seems close to a SmallVectorImpl situation, but happy to rename to something else if there are suggestions.

Wed, Jan 13, 2:53 PM · Restricted Project
rriddle requested review of D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.
Wed, Jan 13, 2:52 PM · Restricted Project
rriddle requested review of D94632: [mlir][PatternRewriter] Add a new hook to selectively replace uses of an operation.
Wed, Jan 13, 1:30 PM · Restricted Project
rriddle accepted D94623: [mlir] Correct 2 places that result in corrupted conversion rollbacks.
Wed, Jan 13, 11:28 AM · Restricted Project

Tue, Jan 12

rriddle requested review of D94575: [mlir][OpFormatGen] Format enum attribute cases as keywords when possible.
Tue, Jan 12, 6:30 PM · Restricted Project
rriddle requested review of D94574: [mlir][ODS] Add new RangedTypesMatchWith operation predicate.
Tue, Jan 12, 6:29 PM · Restricted Project

Mon, Jan 11

rriddle added inline comments to D94451: Proposal for adding Bazel build configuration in-tree with peripheral support.
Mon, Jan 11, 5:44 PM
rriddle added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Mon, Jan 11, 5:32 PM · Restricted Project
rriddle committed rGd79642b3db1d: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleTy… (authored by rriddle).
[mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleTy…
Mon, Jan 11, 12:09 PM
rriddle committed rG948be58258dd: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef (authored by rriddle).
[mlir][TypeDefGen] Add support for adding builders when generating a TypeDef
Mon, Jan 11, 12:09 PM
rriddle committed rG207417730134: [mlir][ODS] Add a C++ abstraction for OpBuilders (authored by rriddle).
[mlir][ODS] Add a C++ abstraction for OpBuilders
Mon, Jan 11, 12:09 PM
rriddle closed D94275: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleType to ODS.
Mon, Jan 11, 12:08 PM · Restricted Project
rriddle closed D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.
Mon, Jan 11, 12:08 PM · Restricted Project
rriddle closed D94273: [mlir][ODS] Add a C++ abstraction for OpBuilders.
Mon, Jan 11, 12:08 PM · Restricted Project
rriddle added inline comments to D94434: [mlir][vector] Add side-effect information to different load/store ops.
Mon, Jan 11, 12:00 PM · Restricted Project

Sun, Jan 10

rriddle accepted D94384: [IR Parser] Fix a crash handling zero width integer attributes..
Sun, Jan 10, 7:07 PM · Restricted Project

Fri, Jan 8

rriddle added inline comments to D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.
Fri, Jan 8, 4:55 PM · Restricted Project
rriddle committed rG77501bd1754f: [mlir][PassManager] Properly set the initialization generation when cloning a… (authored by rriddle).
[mlir][PassManager] Properly set the initialization generation when cloning a…
Fri, Jan 8, 2:47 PM
rriddle added inline comments to D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.
Fri, Jan 8, 2:05 PM · Restricted Project
rriddle committed rG1ba5ea67a301: [mlir] Add a hook for initializing passes before execution and use it in the… (authored by rriddle).
[mlir] Add a hook for initializing passes before execution and use it in the…
Fri, Jan 8, 1:38 PM
rriddle closed D93147: [mlir] Add a hook for initializing passes before execution and use it in the Canonicalizer.
Fri, Jan 8, 1:38 PM · Restricted Project
rriddle added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Fri, Jan 8, 1:35 PM · Restricted Project
rriddle requested changes to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Fri, Jan 8, 1:29 PM · Restricted Project
rriddle updated the diff for D93147: [mlir] Add a hook for initializing passes before execution and use it in the Canonicalizer.

Resolve comments and rebase

Fri, Jan 8, 1:24 PM · Restricted Project
rriddle committed rGe45840f4af46: [mlir][PDL] Use ODS for defining PDL types (authored by rriddle).
[mlir][PDL] Use ODS for defining PDL types
Fri, Jan 8, 12:45 PM
rriddle closed D94135: [mlir][PDL] Use ODS for defining PDL types.
Fri, Jan 8, 12:45 PM · Restricted Project
rriddle accepted D94116: Update the maximum integer bitwidth in MLIR. .
Fri, Jan 8, 12:31 PM · Restricted Project
rriddle added a comment to D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.

+Chris as I think you also ran into a need for this.

Fri, Jan 8, 12:23 PM · Restricted Project
rriddle added a reviewer for D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef: lattner.
Fri, Jan 8, 12:23 PM · Restricted Project

Thu, Jan 7

rriddle accepted D94281: Fix MLIR DRR matching when attributes are interleaved with operands.
Thu, Jan 7, 6:46 PM · Restricted Project
rriddle requested review of D94275: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleType to ODS.
Thu, Jan 7, 4:32 PM · Restricted Project
rriddle requested review of D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.
Thu, Jan 7, 4:31 PM · Restricted Project
rriddle requested review of D94273: [mlir][ODS] Add a C++ abstraction for OpBuilders.
Thu, Jan 7, 4:31 PM · Restricted Project
rriddle accepted D94219: Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute..

LGTM from me, but can you send a post to llvm-dev to make sure there is general consensus?

Thu, Jan 7, 1:08 AM · Restricted Project
rriddle accepted D94218: Fix two pessimizing moves..
Thu, Jan 7, 1:06 AM · Restricted Project, Restricted Project

Wed, Jan 6

rriddle added a comment to D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..

Separate definition because gcc 10 doesn't allow attributes on function definition.

It's done now, but it seems to me that the C++14 attribute would have been cleaner.

LLVM uses C++14, so I'm wondering if the LLVM_ATTRIBUTE_DEPRECATED macro itself should be deprecated ;-)

Wed, Jan 6, 10:59 PM · Restricted Project
rriddle committed rG238dbeb1e7ba: [mlir][ODS] Fix missed rename of TypeParameter 'description' to 'summary' (authored by rriddle).
[mlir][ODS] Fix missed rename of TypeParameter 'description' to 'summary'
Wed, Jan 6, 10:25 PM
rriddle accepted D94208: Update for review feedback: Inline var declaration and expand names..

Nice!

Wed, Jan 6, 5:39 PM · Restricted Project
rriddle accepted D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

LGTM after adding error messages. Thanks!

Wed, Jan 6, 3:56 PM · Restricted Project
rriddle added inline comments to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Wed, Jan 6, 3:50 PM · Restricted Project