Page MenuHomePhabricator
Feed Advanced Search

Yesterday

rriddle committed rG24aa4efffd83: [mlir] Print 0 element DenseElementsAttr as dense<> to fix parser bugs with… (authored by rriddle).
[mlir] Print 0 element DenseElementsAttr as dense<> to fix parser bugs with…
Wed, Jul 8, 6:48 PM
rriddle closed D83445: [mlir] Print 0 element DenseElementsAttr as dense<> to fix parser bugs with expected shape..
Wed, Jul 8, 6:48 PM · Restricted Project
Herald added a project to D83445: [mlir] Print 0 element DenseElementsAttr as dense<> to fix parser bugs with expected shape.: Restricted Project.
Wed, Jul 8, 5:44 PM · Restricted Project

Tue, Jul 7

rriddle accepted D83356: [MLIR] Combine the 2 overloads of FuncOp::build() into one..
Tue, Jul 7, 4:20 PM · Restricted Project
rriddle added inline comments to D83012: [mlir] [VectorOps] Add choice between dot and axpy lowering of vector.contract.
Tue, Jul 7, 1:43 AM · Restricted Project
rriddle committed rG9db53a182705: [mlir][NFC] Remove usernames and google bug numbers from TODO comments. (authored by rriddle).
[mlir][NFC] Remove usernames and google bug numbers from TODO comments.
Tue, Jul 7, 1:42 AM
rriddle added a comment to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

@rriddle Thanks for your comments. I handled them but in this review: https://reviews.llvm.org/D83241. This one had to be reverted due to some internal error in MSVC.

Tue, Jul 7, 12:41 AM · Restricted Project

Mon, Jul 6

rriddle added inline comments to D83012: [mlir] [VectorOps] Add choice between dot and axpy lowering of vector.contract.
Mon, Jul 6, 10:02 PM · Restricted Project
rriddle accepted D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.
Mon, Jul 6, 7:23 PM · Restricted Project
rriddle added inline comments to D83239: [MLIR] adding affine parallel in lower affine pass.
Mon, Jul 6, 7:16 PM · Restricted Project
rriddle added inline comments to D82803: Create the MLIR Reduce framework.
Mon, Jul 6, 7:14 PM · Restricted Project
rriddle added a comment to D83016: [MLIR] Add a NoRegionArguments trait.

Did you consider using a per-region constraint in ODS instead?

Mon, Jul 6, 7:07 PM · Restricted Project
rriddle accepted D83087: DomTree: remove explicit use of DomTreeNodeBase::iterator.

Approval for anything MLIR related.

Mon, Jul 6, 7:06 PM · Restricted Project, Restricted Project, Restricted Project
rriddle added inline comments to D83064: [mlir][Vector] Add a VectorUnrollInterface and expose UnrollVectorPattern..
Mon, Jul 6, 7:04 PM · Restricted Project
rriddle added inline comments to D83117: [MLIR][Standard] Add `assert` operation to the standard dialect.
Mon, Jul 6, 7:00 PM · Restricted Project
rriddle added inline comments to D83194: [mlir] Add additional Canonicalization of shape.cstr_broadcastable..
Mon, Jul 6, 6:59 PM · Restricted Project
rriddle added inline comments to D83150: [mlir][Vector] Add ExtractOp folding.
Mon, Jul 6, 6:55 PM · Restricted Project
rriddle added inline comments to D83012: [mlir] [VectorOps] Add choice between dot and axpy lowering of vector.contract.
Mon, Jul 6, 6:51 PM · Restricted Project
rriddle added inline comments to D83030: [MLIR][SPIRVToLLVM] SPIR-V function call conversion pattern.
Mon, Jul 6, 6:45 PM · Restricted Project
rriddle added inline comments to D82639: [MLIR][SPIRVToLLVM] Implementation of spv.BitFieldInsert pattern.
Mon, Jul 6, 6:45 PM · Restricted Project
rriddle added inline comments to D82757: [mlir] Add redundant copy removal transform.
Mon, Jul 6, 6:43 PM · Restricted Project
rriddle added inline comments to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
Mon, Jul 6, 6:39 PM · Restricted Project

Wed, Jul 1

rriddle committed rGc59aec0ca1ed: [mlir][OpFormatGen] Add support for resolving variadic types from non-variadic (authored by rriddle).
[mlir][OpFormatGen] Add support for resolving variadic types from non-variadic
Wed, Jul 1, 10:43 PM
rriddle closed D83011: [mlir][OpFormatGen] Add support for resolving variadic types from non-variadic.
Wed, Jul 1, 10:43 PM · Restricted Project
rriddle updated the diff for D83011: [mlir][OpFormatGen] Add support for resolving variadic types from non-variadic.

Resolve comments

Wed, Jul 1, 10:43 PM · Restricted Project
rriddle created D83011: [mlir][OpFormatGen] Add support for resolving variadic types from non-variadic.
Wed, Jul 1, 5:19 PM · Restricted Project
rriddle added a comment to D82829: [MLIR] Add type checking capability to RegionBranchOpInterface.

Thanks, took a pass over.

Wed, Jul 1, 4:13 PM · Restricted Project
rriddle added inline comments to D82914: [mlir][NFC] Move conversion of scf to spir-v ops in their own file.
Wed, Jul 1, 4:13 PM · Restricted Project
rriddle added inline comments to D82914: [mlir][NFC] Move conversion of scf to spir-v ops in their own file.
Wed, Jul 1, 3:40 PM · Restricted Project
rriddle added inline comments to D82945: [MLIR][SPIRVToLLVM] Conversion of SPIR-V array, runtime array, pointer and struct types to LLVM dialect..
Wed, Jul 1, 2:04 PM · Restricted Project
rriddle added inline comments to D82914: [mlir][NFC] Move conversion of scf to spir-v ops in their own file.
Wed, Jul 1, 2:04 PM · Restricted Project
rriddle added inline comments to D82246: [mlir][spirv] Add support for lowering scf.for scf/if with return values.
Wed, Jul 1, 2:04 PM · Restricted Project
rriddle added inline comments to D82936: [MLIR][SPIRVToLLVM] Added spv.constant conversion pattern for scalar and vector types.
Wed, Jul 1, 1:32 PM · Restricted Project
rriddle added inline comments to D82803: Create the MLIR Reduce framework.
Wed, Jul 1, 1:32 PM · Restricted Project

Tue, Jun 30

rriddle committed rGf625f5231ab8: [mlir] Remove the default template parameters from AttrBase and TypeBase. (authored by rriddle).
[mlir] Remove the default template parameters from AttrBase and TypeBase.
Tue, Jun 30, 10:11 PM
rriddle committed rG5d699d18b32c: [mlir] Remove locking for dialect/operation registration. (authored by rriddle).
[mlir] Remove locking for dialect/operation registration.
Tue, Jun 30, 4:19 PM
rriddle committed rG2e2cdd0a5230: [mlir] Refactor InterfaceGen to support generating interfaces for Attributes… (authored by rriddle).
[mlir] Refactor InterfaceGen to support generating interfaces for Attributes…
Tue, Jun 30, 4:19 PM
rriddle committed rG9fbb2de8e475: [mlir] Add support for defining Traits and Interfaces on Attributes/Types. (authored by rriddle).
[mlir] Add support for defining Traits and Interfaces on Attributes/Types.
Tue, Jun 30, 4:19 PM
rriddle closed D82595: [mlir] Remove locking for dialect/operation registration..
Tue, Jun 30, 4:19 PM · Restricted Project
rriddle closed D81884: [mlir] Refactor InterfaceGen to support generating interfaces for Attributes and Types..
Tue, Jun 30, 4:19 PM · Restricted Project
rriddle closed D81883: [mlir] Add support for defining Traits and Interfaces on Attributes/Types..
Tue, Jun 30, 4:19 PM · Restricted Project

Mon, Jun 29

rriddle committed rG6b9a706200cb: Add front/back accessors to indexed_accessor_range. (authored by rriddle).
Add front/back accessors to indexed_accessor_range.
Mon, Jun 29, 11:04 PM
rriddle updated the diff for D81884: [mlir] Refactor InterfaceGen to support generating interfaces for Attributes and Types..

Rebase

Mon, Jun 29, 6:34 PM · Restricted Project
rriddle added a comment to D81883: [mlir] Add support for defining Traits and Interfaces on Attributes/Types..

These still require a trait being added explicitly to the type? E.g., a user can't opt a type into a trait (say I want to add a ComparableToDialectFooFixed trait, I'd need to change the definition of Int type to have that trait vs being able to opt in the type later?)

Mon, Jun 29, 6:34 PM · Restricted Project
rriddle updated the diff for D81883: [mlir] Add support for defining Traits and Interfaces on Attributes/Types..

Address comments

Mon, Jun 29, 6:34 PM · Restricted Project
rriddle added a comment to D82831: [mlir][DialectConversion] Enable deeper integration of type conversions.

@ftynse I still need to add tests and rewrite the documentation, but it should be good to start looking over. Thanks.

Mon, Jun 29, 5:58 PM · Restricted Project
rriddle created D82831: [mlir][DialectConversion] Enable deeper integration of type conversions.
Mon, Jun 29, 5:57 PM · Restricted Project
rriddle added a child revision for D82830: [mlir][DialectConversion] Emit an error if an operation marked as erased has live users after conversion: D82831: [mlir][DialectConversion] Enable deeper integration of type conversions.
Mon, Jun 29, 5:57 PM · Restricted Project
rriddle created D82830: [mlir][DialectConversion] Emit an error if an operation marked as erased has live users after conversion.
Mon, Jun 29, 5:57 PM · Restricted Project
rriddle added inline comments to D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 4:54 PM · Restricted Project, Restricted Project
rriddle accepted D82819: [ods] Update Operator to record Arg->[Attr|Operand]Index mapping.
Mon, Jun 29, 4:06 PM · Restricted Project
rriddle requested changes to D82803: Create the MLIR Reduce framework.

Thanks Mauricio, added some initial comments.

Mon, Jun 29, 2:46 PM · Restricted Project
rriddle added inline comments to D82757: [mlir] Add redundant copy removal transform.
Mon, Jun 29, 11:21 AM · Restricted Project
rriddle added inline comments to D82667: [mlir] LLVM dialect: use addressof instead of constant to create function pointers.
Mon, Jun 29, 11:21 AM · Restricted Project
rriddle accepted D82769: [MLIR] Add variadic isa<> for Type, Value, and Attribute.
Mon, Jun 29, 11:21 AM · Restricted Project

Fri, Jun 26

rriddle added a comment to D81883: [mlir] Add support for defining Traits and Interfaces on Attributes/Types..

What about trait in the test dialect that could test this?

Fri, Jun 26, 3:39 PM · Restricted Project
rriddle added inline comments to D82454: [ADT] Add Bitfield utilities - design #3.
Fri, Jun 26, 12:35 PM · Restricted Project
rriddle added inline comments to D82672: [MLIR] Parallelize affine.for op to 1-D affine.parallel op.
Fri, Jun 26, 12:35 PM · Restricted Project
rriddle accepted D82666: [mlir] do not hardcode the name of the undefined function in the error message.
Fri, Jun 26, 12:35 PM · Restricted Project
rriddle accepted D82656: [mlir] Modernize LLVM dialect rountrip test.
Fri, Jun 26, 12:35 PM · Restricted Project
rriddle added inline comments to D82667: [mlir] LLVM dialect: use addressof instead of constant to create function pointers.
Fri, Jun 26, 12:35 PM · Restricted Project
rriddle added inline comments to D82475: [mlir] make the bitwidth of device side index computations configurable.
Fri, Jun 26, 12:35 PM · Restricted Project
rriddle added inline comments to D82647: [mlir] support returning unranked memrefs.
Fri, Jun 26, 12:02 PM · Restricted Project
rriddle added a comment to D82640: [MLIR][SPIRVToLLVM] Implementation of spv.BitFieldSExtract and spv.BitFieldUExtract patterns.

It doesn't seem like you are actually testing that these patterns replace the op.

Fri, Jun 26, 12:02 PM · Restricted Project

Thu, Jun 25

rriddle added a comment to D82600: IR changes to add yield semantics for affine.if and affine.parallel, additional affine.parallel canonicalization.

Thanks for reuploading!

Thu, Jun 25, 2:44 PM · Restricted Project
rriddle added inline comments to D82600: IR changes to add yield semantics for affine.if and affine.parallel, additional affine.parallel canonicalization.
Thu, Jun 25, 2:44 PM · Restricted Project
rriddle added a comment to D82600: IR changes to add yield semantics for affine.if and affine.parallel, additional affine.parallel canonicalization.

Please re-upload with full context.
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Thu, Jun 25, 2:44 PM · Restricted Project
rriddle created D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.
Thu, Jun 25, 1:39 PM · Restricted Project
rriddle added a child revision for D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types: D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..
Thu, Jun 25, 1:39 PM · Restricted Project
rriddle created D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..
Thu, Jun 25, 1:39 PM · Restricted Project
rriddle added a child revision for D81883: [mlir] Add support for defining Traits and Interfaces on Attributes/Types.: D82595: [mlir] Remove locking for dialect/operation registration..
Thu, Jun 25, 1:39 PM · Restricted Project
rriddle updated the diff for D81883: [mlir] Add support for defining Traits and Interfaces on Attributes/Types..

Rebase

Thu, Jun 25, 1:39 PM · Restricted Project
rriddle added a child revision for D82595: [mlir] Remove locking for dialect/operation registration.: D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.
Thu, Jun 25, 1:39 PM · Restricted Project
rriddle created D82595: [mlir] Remove locking for dialect/operation registration..
Thu, Jun 25, 1:39 PM · Restricted Project
rriddle added inline comments to D82529: MLIR][Shape] Add function signature conversion to `scf` to `std` lowering..
Thu, Jun 25, 1:39 PM · Restricted Project
rriddle accepted D82471: [mlir-tblgen] Use fully qualified names in generated code files.

LGTM after making sure that LLVM types use the proper llvm namespace.

Thu, Jun 25, 1:39 PM · Restricted Project
rriddle accepted D82583: [SVE] Remove calls to VectorType::getNumElements from mlir.
Thu, Jun 25, 1:05 PM · Restricted Project
rriddle added inline comments to D82531: [MLIR][Shape] Fold `shape.size_eq`.
Thu, Jun 25, 1:04 PM · Restricted Project
rriddle added inline comments to D82530: [MLIR][Shape] Lower `shape.shape_eq` to `scf`.
Thu, Jun 25, 12:29 PM · Restricted Project
rriddle added inline comments to D82454: [ADT] Add Bitfield utilities - design #3.
Thu, Jun 25, 12:28 PM · Restricted Project

Wed, Jun 24

rriddle committed rGe6a343e491d4: [mlir][DialectConversion][NFC] Add comment blocks and organize a bit of the code (authored by rriddle).
[mlir][DialectConversion][NFC] Add comment blocks and organize a bit of the code
Wed, Jun 24, 5:57 PM
rriddle committed rG7d1452d8373e: [mlir] Refactor OpInterface internals to be faster and factor out common bits. (authored by rriddle).
[mlir] Refactor OpInterface internals to be faster and factor out common bits.
Wed, Jun 24, 5:57 PM
rriddle closed D81882: [mlir] Refactor OpInterface internals to be faster and factor out common bits..
Wed, Jun 24, 5:57 PM · Restricted Project
rriddle requested changes to D82471: [mlir-tblgen] Use fully qualified names in generated code files.
Wed, Jun 24, 5:56 PM · Restricted Project
rriddle added inline comments to D82489: [MLIR][NFC] Adopt variadic isa<>.
Wed, Jun 24, 1:34 PM · Restricted Project
rriddle accepted D82489: [MLIR][NFC] Adopt variadic isa<>.
Wed, Jun 24, 11:55 AM · Restricted Project
rriddle added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Wed, Jun 24, 11:55 AM · Restricted Project

Tue, Jun 23

rriddle added inline comments to D82417: [MLIR] [NFC] Add new line and empty line before printing modified loop to make the debug output readable..
Tue, Jun 23, 6:21 PM · Restricted Project
rriddle accepted D82417: [MLIR] [NFC] Add new line and empty line before printing modified loop to make the debug output readable..

Feel free to submit simple things like this directly in the future.

Tue, Jun 23, 3:39 PM · Restricted Project
rriddle added inline comments to D82406: [mlir] Support iterator arguments in the loop unrolling.
Tue, Jun 23, 1:58 PM · Restricted Project
rriddle added inline comments to D82191: [mlir] parallel loop canonicalization.
Tue, Jun 23, 1:26 PM · Restricted Project
rriddle added inline comments to D82191: [mlir] parallel loop canonicalization.
Tue, Jun 23, 12:21 PM · Restricted Project
rriddle added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Tue, Jun 23, 12:21 PM · Restricted Project
rriddle accepted D82371: [mlir] Avoid pontentially ambiguous class name.
Tue, Jun 23, 11:48 AM · Restricted Project

Mon, Jun 22

rriddle accepted D82334: [MLIR][NFC] Adopt hasNItems() for SizedRegion predicate.
Mon, Jun 22, 3:35 PM · Restricted Project
rriddle added inline comments to D82077: [MLIR][Shape] Add canonicalization pattern for `shape.rank`.
Mon, Jun 22, 3:03 PM · Restricted Project
rriddle updated the diff for D81882: [mlir] Refactor OpInterface internals to be faster and factor out common bits..

Resolve comments

Mon, Jun 22, 1:26 PM · Restricted Project
rriddle added inline comments to D81882: [mlir] Refactor OpInterface internals to be faster and factor out common bits..
Mon, Jun 22, 1:26 PM · Restricted Project
rriddle added inline comments to D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Mon, Jun 22, 2:06 AM · Restricted Project

Fri, Jun 19

rriddle updated the diff for D81884: [mlir] Refactor InterfaceGen to support generating interfaces for Attributes and Types..

Rebase

Fri, Jun 19, 3:14 PM · Restricted Project