Tue, Jul 7
Mon, Jul 6
Did you consider using a per-region constraint in ODS instead?
Approval for anything MLIR related.
Wed, Jul 1
Thanks, took a pass over.
Tue, Jun 30
Mon, Jun 29
These still require a trait being added explicitly to the type? E.g., a user can't opt a type into a trait (say I want to add a ComparableToDialectFooFixed trait, I'd need to change the definition of Int type to have that trait vs being able to opt in the type later?)
@ftynse I still need to add tests and rewrite the documentation, but it should be good to start looking over. Thanks.
Thanks Mauricio, added some initial comments.
Fri, Jun 26
It doesn't seem like you are actually testing that these patterns replace the op.
Thu, Jun 25
Thanks for reuploading!
Please re-upload with full context.
LGTM after making sure that LLVM types use the proper llvm namespace.
Wed, Jun 24
Tue, Jun 23
Feel free to submit simple things like this directly in the future.
Mon, Jun 22
Fri, Jun 19