In D82710#2135063, @ergawy wrote:

@rriddle Thanks for your comments. I handled them but in this review: https://reviews.llvm.org/D83241. This one had to be reverted due to some internal error in MSVC.

Did you consider using a per-region constraint in ODS instead?

Approval for anything MLIR related.

Resolve comments

Thanks, took a pass over.

Rebase

In D81883#2118718, @jpienaar wrote:

These still require a trait being added explicitly to the type? E.g., a user can't opt a type into a trait (say I want to add a ComparableToDialectFooFixed trait, I'd need to change the definition of Int type to have that trait vs being able to opt in the type later?)

Address comments

@ftynse I still need to add tests and rewrite the documentation, but it should be good to start looking over. Thanks.

Thanks Mauricio, added some initial comments.

In D81883#2116020, @mehdi_amini wrote:

What about trait in the test dialect that could test this?

It doesn't seem like you are actually testing that these patterns replace the op.

Thanks for reuploading!

Please re-upload with full context.
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Rebase

LGTM after making sure that LLVM types use the proper llvm namespace.

Feel free to submit simple things like this directly in the future.

Resolve comments

Rebase