Page MenuHomePhabricator
Feed Advanced Search

Jan 16 2021

Herald added a reviewer for D94695: [libomptarget][amdgpu] Fix kernel launch tracing to match previous behavior: jdoerfert.
Jan 16 2021, 10:40 PM · Unknown Object (Project)

Jan 7 2021

fghanim added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Ping. Please add the Lit test for this.

Jan 7 2021, 12:11 PM · Restricted Project
fghanim added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 7 2021, 12:10 PM · Unknown Object (Project), Restricted Project

Dec 6 2020

fghanim added a comment to D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.

Thanks for the patch. Just a couple of nits

Dec 6 2020, 11:16 AM · Unknown Object (Project), Restricted Project

Dec 1 2020

fghanim added a comment to D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function.

Thanks; just two more mediocre things if possible. if not. you are good to go. :)

Dec 1 2020, 2:57 PM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2020

fghanim added a reviewer for D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function: fghanim.

Thank you for the patch :)

Nov 30 2020, 3:45 PM · Restricted Project, Restricted Project, Restricted Project

Nov 26 2020

fghanim added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 26 2020, 2:09 PM · Unknown Object (Project), Restricted Project

Nov 20 2020

fghanim added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Nov 20 2020, 9:29 PM · Restricted Project

Nov 18 2020

fghanim added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 18 2020, 10:06 PM · Unknown Object (Project), Restricted Project

Nov 10 2020

fghanim added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

I second @Meinersbur comment. Reducing duplication is always better :)

Nov 10 2020, 2:47 PM · Unknown Object (Project), Restricted Project
fghanim added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Thanks for doing this.

Nov 10 2020, 1:58 PM · Restricted Project

Nov 9 2020

fghanim accepted D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC..

LGTM

Nov 9 2020, 4:45 PM · Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Nov 7 2020

fghanim added a comment to D90830: [OpenMPIRBuilder] Implement CreateCanonicalLoop..

Thanks for the response, I think I am beginning to understand where this fits.
Just one Nit, O/W LGTM

Nov 7 2020, 10:25 AM · Restricted Project

Nov 5 2020

fghanim added a comment to D90830: [OpenMPIRBuilder] Implement CreateCanonicalLoop..

Thanks for the Patch. Generally looks Good.
Just a couple of very minor comments/questions

Nov 5 2020, 5:41 PM · Restricted Project

Oct 21 2020

fghanim added a comment to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Oct 21 2020, 7:37 PM · Restricted Project
fghanim added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Great work. Thanks.

Oct 21 2020, 4:52 PM · Unknown Object (Project), Restricted Project

Oct 20 2020

fghanim added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

I have updated the title.

Oct 20 2020, 1:20 PM · Unknown Object (Project), Restricted Project

Oct 19 2020

fghanim added a reviewer for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder: fghanim.

Thank you for working on this!

Oct 19 2020, 12:32 PM · Unknown Object (Project), Restricted Project

Oct 2 2020

fghanim added a comment to D88706: [OpenMP][MLIR] WIP : Fix for AllocaIP.

While debugging the nested parallel region issues, we saw some difference between where the allocas are placed by the OpenMP IRBuilder in the clang usage and the MLIR usage. Moving to the version where the OpenMP IRBuilder maintains allocaIP fixed the difference. In MLIR module translation there is no alloca insertion point. So what we can provide as allocaIP is the current insertionPoint.

Oct 2 2020, 1:47 PM · Restricted Project, Restricted Project

Oct 1 2020

fghanim added a reviewer for D88706: [OpenMP][MLIR] WIP : Fix for AllocaIP: fghanim.

After reading the patch for master you referred to, I don't understand why do we need the OMPBuilder to maintain the insertion point. As far as master is concerned, we will emit any alloca's contained inside its region into the entry block of the enclosing outlined region (e.g. innermost parallel).
FWIW, the master directive in clang already uses the OMPBuilder and just relies on clang to handle the insertion of any non-omp code (including alloca's). Is there a reason why a similar approach wouldn't work here?

Oct 1 2020, 6:14 PM · Restricted Project, Restricted Project

Sep 18 2020

fghanim added a comment to D87841: [openmp][libomptarget] Include header from LLVM source tree.

I have no idea if this has been considered before or not, or if there is some technical/organizational difficulties against this option, but I think an option would be to create somewhere in the LLVM umbrella project for common Headers/Def.s between different LLVM subprojects (directory called "common" maybe?), which should help maintain independence between the projects without duplication, package maintainers will know to always include that in any package without having to worry about looking for shared files on a file by file bases, and users should always download that with whichever llvm package they are going to use.

Sep 18 2020, 10:32 AM · Restricted Project, Unknown Object (Project)

Sep 8 2020

fghanim added a comment to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

@kiranchandramohan This error happens when there are things within the OMP region still alive/are used outside the region, I cannot comment on what causes this here. Usually, this suggests that "something" that should be contained within the parallel region is not being detected as such, and so when the region is outlined, this User remains as part of the original function.

Sep 8 2020, 7:22 PM · Restricted Project
fghanim added a comment to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

I don't know enough about the OMPIR for me to be helpful, however, I noticed a couple of things that I wanted to ask about for better understanding. :)

Sep 8 2020, 6:51 PM · Restricted Project

Sep 1 2020

fghanim added a comment to D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.

Tests missing

Sep 1 2020, 6:56 AM · Restricted Project
fghanim added a comment to D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`.

What is the plan for this patch?

Sep 1 2020, 6:45 AM · Restricted Project

Aug 31 2020

fghanim added a comment to D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.

What is the plan for this patch?

Aug 31 2020, 3:15 PM · Restricted Project

Aug 15 2020

fghanim committed rGaaa93a681bd8: [OpenMP][OMPBuilder] Adding support for `omp single` (authored by fghanim).
[OpenMP][OMPBuilder] Adding support for `omp single`
Aug 15 2020, 10:57 PM
fghanim closed D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.
Aug 15 2020, 10:56 PM · Restricted Project

Aug 14 2020

fghanim added inline comments to D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.
Aug 14 2020, 4:35 PM · Restricted Project
fghanim added a comment to D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.

ping

Aug 14 2020, 2:36 PM · Restricted Project

Aug 13 2020

fghanim added a comment to D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`.

ping

Aug 13 2020, 7:47 PM · Restricted Project

Aug 12 2020

fghanim updated the diff for D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.

Fixing nits

Aug 12 2020, 12:27 PM · Restricted Project

Aug 10 2020

fghanim added a comment to D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.

Thanks. will fix nits.

Aug 10 2020, 5:47 PM · Restricted Project
fghanim added a comment to D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`.

Before I start, Why is this change all new code and no modification or deletion of existing Clang functionality for omp single/copyprivate?

Aug 10 2020, 5:27 PM · Restricted Project

Aug 9 2020

fghanim updated fghanim.
Aug 9 2020, 1:31 PM
fghanim updated fghanim.
Aug 9 2020, 1:30 PM
fghanim added a comment to D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`.

Feel free to add other reviewers. Thanks.

Aug 9 2020, 12:38 PM · Restricted Project
fghanim added reviewers for D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`: hfinkel, kiranchandramohan.
Aug 9 2020, 12:37 PM · Restricted Project
fghanim added a comment to D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.

Feel free to add other reviewers. Thanks.

Aug 9 2020, 12:37 PM · Restricted Project
fghanim added reviewers for D85617: [OpenMP][OMPBuilder] Adding support for `omp single`: hfinkel, kiranchandramohan.
Aug 9 2020, 12:36 PM · Restricted Project
fghanim requested review of D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`.
Aug 9 2020, 12:33 PM · Restricted Project
fghanim requested review of D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.
Aug 9 2020, 12:32 PM · Restricted Project

Jul 17 2020

fghanim accepted D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.

Great. Thank you!
LGTM

Jul 17 2020, 10:16 PM · Restricted Project, Restricted Project

Jul 16 2020

fghanim added inline comments to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.
Jul 16 2020, 10:54 AM · Restricted Project, Restricted Project

Jul 14 2020

fghanim added a comment to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.

I'll address the nits.

Thanks :)

Jul 14 2020, 9:35 AM · Restricted Project, Restricted Project

Jul 13 2020

fghanim added a comment to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.

Thanks for the update. Just a couple of Nits, and a quick note

Jul 13 2020, 10:28 PM · Restricted Project, Restricted Project

Jul 3 2020

fghanim added inline comments to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.
Jul 3 2020, 1:35 AM · Restricted Project, Restricted Project

Jul 2 2020

fghanim added a comment to D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested.

LGTM

Jul 2 2020, 3:08 PM · Restricted Project

Jun 30 2020

fghanim added a comment to D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.

Is the ordering of code generation for clauses important?
copyin -> firstprivate -> barrier -> private

Jun 30 2020, 11:57 PM · Restricted Project

Jun 29 2020

fghanim added a comment to D82722: [OpenMP][IRBuilder] Support nested parallel regions.

OK. Thanks :)

Jun 29 2020, 10:15 AM · Restricted Project, Restricted Project
fghanim requested changes to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.
Jun 29 2020, 1:34 AM · Restricted Project, Restricted Project

Jun 28 2020

fghanim committed rG80e15b4574f4: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to… (authored by fghanim).
[Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to…
Jun 28 2020, 5:11 PM
fghanim closed D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers.
Jun 28 2020, 5:10 PM · Restricted Project
fghanim added a comment to D82722: [OpenMP][IRBuilder] Support nested parallel regions.

Thanks for working on this. LGTM.
Did you make any changes other than splitting from D82470 ?

Jun 28 2020, 1:27 PM · Restricted Project, Restricted Project

Jun 26 2020

fghanim added a comment to rG82b8236cf248: [OpenMP][OMPBuilder] Adding privatization related `createXXXX` to OMPBuilder.

Build error due to unused variable fixed in rG89812eeee97c8f7ab2e6ee2c48edb7a409dfff39

Jun 26 2020, 11:56 PM
fghanim committed rG89812eeee97c: [OpenMP][OMPBuilder] Remove unused variable in Unittest (authored by fghanim).
[OpenMP][OMPBuilder] Remove unused variable in Unittest
Jun 26 2020, 11:50 PM
fghanim closed D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

commited: rG82b8236cf248

Jun 26 2020, 11:34 PM · Restricted Project, Restricted Project
fghanim committed rG82b8236cf248: [OpenMP][OMPBuilder] Adding privatization related `createXXXX` to OMPBuilder (authored by fghanim).
[OpenMP][OMPBuilder] Adding privatization related `createXXXX` to OMPBuilder
Jun 26 2020, 11:25 PM

Jun 24 2020

fghanim added inline comments to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.
Jun 24 2020, 4:52 PM · Restricted Project, Restricted Project
fghanim added a comment to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.

Thanks for the Patch. I have few questions to help me understand what's going on.

Jun 24 2020, 1:34 PM · Restricted Project, Restricted Project

Jun 15 2020

fghanim added a comment to D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.

ping - please suggest reviewers I can add to review the clang side of things?

Jun 15 2020, 11:31 AM · Restricted Project
fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

Ping.
Does this patch need further changes?

Jun 15 2020, 11:31 AM · Restricted Project, Restricted Project

Jun 10 2020

fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

you are responding to a comment from 2 weeks ago, so let's just move on.

Jun 10 2020, 3:35 PM · Restricted Project, Restricted Project

Jun 9 2020

fghanim retitled D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder` from [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive to [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.
Jun 9 2020, 10:58 AM · Restricted Project
fghanim added inline comments to D81484: [Clang][OpenMP][OMPBuilder] (4/4) Privatize `parallel` for `OMPBuilder`.
Jun 9 2020, 10:57 AM · Restricted Project
fghanim added inline comments to D81483: [Clang][OpenMP][OMPBuilder] (3/4) Privatize `parallel` for `OMPBuilder`.
Jun 9 2020, 10:25 AM · Restricted Project
fghanim updated the diff for D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.
  • rebase
  • splitting patch into 4 ( this, D81482 , D81483 , D81484 )
  • addressing reviewer's comments
Jun 9 2020, 10:25 AM · Restricted Project
fghanim added a comment to D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.

@jdoerfert Please suggest reviewer's for this, and I will add them to other clang related patches

Jun 9 2020, 10:25 AM · Restricted Project
fghanim created D81484: [Clang][OpenMP][OMPBuilder] (4/4) Privatize `parallel` for `OMPBuilder`.
Jun 9 2020, 10:25 AM · Restricted Project
fghanim created D81483: [Clang][OpenMP][OMPBuilder] (3/4) Privatize `parallel` for `OMPBuilder`.
Jun 9 2020, 10:25 AM · Restricted Project
fghanim updated the diff for D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers.
  • rebase
  • addressing reviewer's comments
Jun 9 2020, 10:25 AM · Restricted Project
fghanim created D81482: [Clang][OpenMP][OMPBuilder] (2/4) Privatize `parallel` for `OMPBuilder`.
Jun 9 2020, 10:25 AM · Restricted Project
fghanim updated the diff for D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.
  • Rebase + refactor based on D80222
  • addressed reviewer comments
Jun 9 2020, 10:25 AM · Restricted Project, Restricted Project

May 27 2020

fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

I am moving on because we are not getting anywhere. However, There are few things I need to point out very quickly.

I fail to see the point in committing for example your target type solution if we found a more generic version in the meantime.
We can for sure commit them and then replace them subsequently, but is that really helping anyone? It would not be a question if
they were in, since they are not it seems to me there is no benefit in blocking the other patch on them. I mean, the time you worked
on that part is not "less wasted" if we commit it. TBH, I don't thin it is wasted at all but that is a different conversation.

At one point, you said I was delaying D80222 moments after it was uploaded. Now, D79675 and D79676 , cannot be committed because of the artificial dependency on that patch.

May 27 2020, 4:22 PM · Restricted Project, Restricted Project

May 22 2020

fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

I am going to omit parts of the quote, because who wants to look at a wall of test - readability is important ;)

May 22 2020, 3:34 PM · Restricted Project, Restricted Project
fghanim added inline comments to D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def.
May 22 2020, 9:05 AM · Restricted Project, Restricted Project, Unknown Object (Project)

May 21 2020

fghanim added inline comments to D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def.
May 21 2020, 10:45 PM · Restricted Project, Restricted Project, Unknown Object (Project)

May 20 2020

fghanim updated the diff for D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

Addressing more reviewers comments.

May 20 2020, 10:22 AM · Restricted Project, Restricted Project
fghanim added inline comments to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.
May 20 2020, 10:22 AM · Restricted Project, Restricted Project
fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

So this whole thing was about moving Def.s out of CGOMPRuntime? Given how low priority making the-soon-to-be-deprecated CGOMPRuntime use the new Def.s is, and that I actually use these stuff as part of the-soon-to-be-the-way-to-CG-OMP OMPBuilder, wouldn't it have been better to postpone both patches until we are done with this one then add anything I didn't have already as part of D79739 ? It would have certainly saved everyone a lot of time, and made more sense given that the earlier patch came out 2 days after mine, and the other patch today? :)

  1. Soon is relative.

"Soon" is indeed relative, and so is "later", and so is 99% of the words. However, words have specific meanings, otherwise opposites would refer to the same thing, and words become useless and meaningless. "Soon" means soon.

May 20 2020, 10:22 AM · Restricted Project, Restricted Project

May 19 2020

fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

Could you please list the other patches that are being held back by this one? I'd be interested to have a look at them. :)

We need the target type support for D80222, D79739 can go in but we need to modify it afterwards.

May 19 2020, 6:11 PM · Restricted Project, Restricted Project
fghanim updated the diff for D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

Addressing reviewer Comments

May 19 2020, 4:00 PM · Restricted Project, Restricted Project
fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

What's the status? Can we split the target specific types stuff if this may take a while, other patches depend on that :)

May 19 2020, 4:00 PM · Restricted Project, Restricted Project

May 14 2020

fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

I left some comments on the type stuff. The rest looks good.
I think if you rebase the type stuff on D79739 (which I can merge) we should only need to expand initializeTypes to make this work as expected. WDYT?

May 14 2020, 3:47 PM · Restricted Project, Restricted Project
fghanim added a comment to D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.

Generally you copied the existing Clang logic, correct?

May 14 2020, 9:43 AM · Restricted Project
fghanim updated the diff for D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers.

updating in response to review comments

May 14 2020, 9:43 AM · Restricted Project
fghanim added inline comments to D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers.
May 14 2020, 9:43 AM · Restricted Project
fghanim updated the diff for D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.
  • removed many Definitions from OMPKinds.def due to being added in D79739
  • made changes based on reviewer comments
  • added unit test for CreateCopyinClauseBlocks()
May 14 2020, 9:10 AM · Restricted Project, Restricted Project
fghanim added inline comments to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.
May 14 2020, 9:10 AM · Restricted Project, Restricted Project

May 13 2020

fghanim added a comment to D79739: Adding Extra Runtime Functions to OMPKinds.def.

@jdoerfert At this point should I just drop the changes I made in OMPKinds.def ? :D

The target dependent size stuff is not solved in here so your solution is needed. The runtime functions and types now declared do not need to be declared again by you.
I'll merge this today.

May 13 2020, 9:44 AM · Restricted Project, Restricted Project

May 12 2020

fghanim added a comment to D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.

This is a small patch as it is. splitting it any further would make it very very small :D

May 12 2020, 4:42 PM · Restricted Project, Restricted Project
fghanim added a comment to D79739: Adding Extra Runtime Functions to OMPKinds.def.

@jdoerfert At this point should I just drop the changes I made in OMPKinds.def ? :D

May 12 2020, 4:42 PM · Restricted Project, Restricted Project

May 9 2020

fghanim created D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`.
May 9 2020, 1:17 PM · Restricted Project
fghanim created D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers.
May 9 2020, 12:45 PM · Restricted Project
fghanim created D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder.
May 9 2020, 12:45 PM · Restricted Project, Restricted Project

Apr 2 2020

fghanim accepted D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`.

OK, As I said a few days ago, I went over the patch, and I didn't see any functional changes. I am accepting this patch.

Apr 2 2020, 3:11 PM · Restricted Project

Mar 31 2020

fghanim added a comment to D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`.

Figured as much, just wanted to be sure. Anyways, this one also LGTM
I'll wait a couple of days in case any one has comments, if not I'll approve it

Mar 31 2020, 3:59 PM · Restricted Project
fghanim added a comment to D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping.

Thanks for working on this as well.
As an aside, I like the new allowed clause implementation much better. it is much simpler and cleaner than the previous one.
I'll wait to see if anyone else has comments, but if not, then it LGTM.

Mar 31 2020, 2:55 PM · Restricted Project
fghanim added a comment to D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`.

Thanks for doing this. I looked at all of it, and the changes seem to be you just moved things to llvm/Frontend, and fixed namespaces/includes to work correctly with the new location. Is there here anything else I am missing?

Mar 31 2020, 2:52 PM · Restricted Project

Mar 20 2020

fghanim added a comment to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

My comments were nits so.

Mar 20 2020, 10:50 AM · Restricted Project, Restricted Project