LGTM.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 28 2017
Aug 28 2017
simbuerg accepted D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..
Aug 28 2017, 2:39 AM · Restricted Project
Aug 23 2017
Aug 23 2017
[Polly][WIP] Scalar fully indexed expansion
Aug 18 2017
Aug 18 2017
simbuerg committed rL311165: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.
[Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion
simbuerg accepted D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.
OK
Aug 16 2017
Aug 16 2017
simbuerg added a comment to D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.
Apart from the Load/Store union_map issue and the tests, just a few minor remarks.
Aug 13 2017
Aug 13 2017
We talked about it on Friday but I think I can help out more with a small writeup.
Aug 7 2017
Aug 7 2017
[Polly] Fully-Indexed static expansion
Jul 25 2017
Jul 25 2017
Jun 27 2017
Jun 27 2017
Allright, I just committed the size-check with test. From my side this patch is ready as soon as:
- Rebase is done
- Commit message gives a usefull description of what this patch does.
We're getting close IMHO. I will commit the small range-check patch tonight.
[NFC][CodeGen] Use the ExitBlock explicitly.
[FIX] Add %loadPolly to test
Jun 26 2017
Jun 26 2017
simbuerg committed rL306283: [NFC] Return both polly.start and polly.exiting from executeScopConditionally..
[NFC] Return both polly.start and polly.exiting from executeScopConditionally.
Jun 9 2017
Jun 9 2017
Jun 7 2017
Jun 7 2017
Jun 6 2017
Jun 6 2017
So far it looks good. I would add tests that take care of error cases: negative sizes, overflow in the size calculation.
General Note: Can you reduce the size of the test-cases? (Remove the debug metadata with opt -strip-debug, unnecessary attributes).
May 23 2017
May 23 2017
May 3 2017
May 3 2017
simbuerg added inline comments to D32739: [Polly] JSONImporter misses checks whether the data it imports makes sense..
Feb 24 2015
Feb 24 2015
Otherwise LGTM.
Dec 19 2014
Dec 19 2014
(diagnostics) fix typo in test...
Nov 14 2014
Nov 14 2014
Nov 13 2014
Nov 13 2014
Nov 12 2014
Nov 12 2014
Oct 14 2014
Oct 14 2014
Alright, I got a closer second look and now I think it actually looks nicer than before ;-). Thanks for explaining.
Oct 13 2014
Oct 13 2014
This is exactly what I feared.
I'm not sure if I'm the only one, but I really like the definition of the command-line options where they matter: In the file where they influence something. Why would we want to extract the definitions too? Isn't it sufficient to provide the Options.h header and be done with it (+unify the naming)?
LGTM
Oct 9 2014
Oct 9 2014
simbuerg added a comment to D4988: [Polly] Extract number of elements/iterations for a isl_set/isl_ast_node.
Just a minor comment, I'm not fully awake yet. Btw, get some sleep! ;-)
Oct 6 2014
Oct 6 2014
simbuerg added inline comments to D5623: [Polly][Fix] Dead memory accesses should not confuse RTC generation.
Aug 13 2014
Aug 13 2014
I have some stylistic comments inline, the rest looks good to me.
Aug 13 2014, 2:49 PM · Restricted Project
LGTM.
Jun 26 2014
Jun 26 2014
Jun 17 2014
Jun 17 2014
simbuerg retitled D4171: [polly] Support the new DiagnosticRemarks from to [polly] Support the new DiagnosticRemarks.