Page MenuHomePhabricator
Feed Advanced Search

Wed, Jun 9

I_Perry updated the diff for D102400: [flang] [openmp] Add Fortran specific semantic check 4 for OpenMP Allocate directive..

Addressed nit comments and added additional test for common block names.

Wed, Jun 9, 6:08 AM · Restricted Project

Thu, Jun 3

I_Perry updated the diff for D102400: [flang] [openmp] Add Fortran specific semantic check 4 for OpenMP Allocate directive..

Removed generated enum as a simpler test for a custom allocator was found.

Thu, Jun 3, 3:06 PM · Restricted Project

Tue, Jun 1

I_Perry updated the diff for D102400: [flang] [openmp] Add Fortran specific semantic check 4 for OpenMP Allocate directive..

Added function to check for predefined allocator and allocator value generated enum.

Tue, Jun 1, 10:37 AM · Restricted Project

Mon, May 24

I_Perry updated the diff for D102400: [flang] [openmp] Add Fortran specific semantic check 4 for OpenMP Allocate directive..

Made change to fix failing test on Phabricator.

Mon, May 24, 6:00 AM · Restricted Project

Tue, May 18

I_Perry added inline comments to D102061: [flang] [openmp] Add Fortran specific semantic checks for OpenMP Allocate directive..
Tue, May 18, 5:36 AM · Restricted Project
I_Perry updated the diff for D102400: [flang] [openmp] Add Fortran specific semantic check 4 for OpenMP Allocate directive..

Added custom allocator test in omp-allocate08.f90

Tue, May 18, 5:10 AM · Restricted Project
I_Perry updated the diff for D102061: [flang] [openmp] Add Fortran specific semantic checks for OpenMP Allocate directive..

Addressed comments.

Tue, May 18, 5:07 AM · Restricted Project

May 13 2021

I_Perry added reviewers for D102400: [flang] [openmp] Add Fortran specific semantic check 4 for OpenMP Allocate directive.: kiranchandramohan, clementval, kiranktp, klausler, sameeranjoshi.
May 13 2021, 6:43 AM · Restricted Project
I_Perry requested review of D102400: [flang] [openmp] Add Fortran specific semantic check 4 for OpenMP Allocate directive..
May 13 2021, 6:41 AM · Restricted Project

May 7 2021

I_Perry added reviewers for D102061: [flang] [openmp] Add Fortran specific semantic checks for OpenMP Allocate directive.: kiranchandramohan, clementval, kiranktp, klausler, sameeranjoshi, Rin.
May 7 2021, 7:19 AM · Restricted Project
I_Perry requested review of D102061: [flang] [openmp] Add Fortran specific semantic checks for OpenMP Allocate directive..
May 7 2021, 3:59 AM · Restricted Project

Apr 22 2021

I_Perry added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Addressed nit comments.

Do you have access to land the patch?

Apr 22 2021, 8:40 AM · Restricted Project, Restricted Project
I_Perry updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Addressed nit comments.

Apr 22 2021, 8:35 AM · Restricted Project, Restricted Project

Apr 21 2021

I_Perry updated subscribers of D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

@kiranchandramohan @awarzynski This patch has been rebased against main, all tests pass and it is ready for merge.

Apr 21 2021, 9:45 AM · Restricted Project, Restricted Project
I_Perry updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Patch ready for merge.

Apr 21 2021, 9:15 AM · Restricted Project, Restricted Project

Apr 13 2021

I_Perry updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Fixed incorrect formatting.

Apr 13 2021, 6:20 AM · Restricted Project, Restricted Project

Apr 12 2021

I_Perry updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Adressed comments

Apr 12 2021, 12:22 PM · Restricted Project, Restricted Project

Apr 8 2021

I_Perry updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

This update changes the function IsInsideTargetDirective to the more generic IsNestedInDirective and adds a comment explaining when to use ResolveOmpObjectScope over ResolveOmpName.

Apr 8 2021, 6:56 AM · Restricted Project, Restricted Project

Mar 26 2021

I_Perry added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Mar 26 2021, 8:06 AM · Restricted Project, Restricted Project
I_Perry commandeered D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

I'll take this patch over from Rin and take it to completion.

Mar 26 2021, 7:33 AM · Restricted Project, Restricted Project