Page MenuHomePhabricator
Feed Advanced Search

Yesterday

sunho committed rG134363208b92: [clang] Fix gcc-6 compilation error. (NFC) (authored by sunho).
[clang] Fix gcc-6 compilation error. (NFC)
Sun, Jul 3, 1:34 PM · Restricted Project, Restricted Project
sunho closed D129049: [clang] Fix gcc-6 compilation error. (NFC).
Sun, Jul 3, 1:34 PM · Restricted Project, Restricted Project
sunho updated the diff for D129049: [clang] Fix gcc-6 compilation error. (NFC).
Sun, Jul 3, 12:39 PM · Restricted Project, Restricted Project
sunho requested review of D129049: [clang] Fix gcc-6 compilation error. (NFC).
Sun, Jul 3, 12:30 PM · Restricted Project, Restricted Project
sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..
Sun, Jul 3, 12:37 AM · Restricted Project, Restricted Project

Sat, Jul 2

sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..

Address comments and fix builds.

Sat, Jul 2, 1:12 PM · Restricted Project, Restricted Project
sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..
Sat, Jul 2, 10:32 AM · Restricted Project, Restricted Project
sunho retitled D128968: [JITLink][COFF] Initial COFF support. from [DRAFT][JITLink][COFF] Initial COFF support. to [JITLink][COFF] Initial COFF support..
Sat, Jul 2, 9:53 AM · Restricted Project, Restricted Project
sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..

Support weak external symbols.

Sat, Jul 2, 9:43 AM · Restricted Project, Restricted Project
sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..

Refactor symobol handling, calculate implicit size, support jitlink-check.

Sat, Jul 2, 9:04 AM · Restricted Project, Restricted Project
sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..

Finish up object file detection. Add more test cases.

Sat, Jul 2, 6:41 AM · Restricted Project, Restricted Project

Fri, Jul 1

sunho updated the summary of D128968: [JITLink][COFF] Initial COFF support..
Fri, Jul 1, 1:27 PM · Restricted Project, Restricted Project
sunho updated the summary of D128968: [JITLink][COFF] Initial COFF support..
Fri, Jul 1, 1:22 PM · Restricted Project, Restricted Project
sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..

Add tests and rel32 relocation.

Fri, Jul 1, 1:12 PM · Restricted Project, Restricted Project

Thu, Jun 30

sunho updated the diff for D128968: [JITLink][COFF] Initial COFF support..
Thu, Jun 30, 11:46 PM · Restricted Project, Restricted Project
sunho requested review of D128968: [JITLink][COFF] Initial COFF support..
Thu, Jun 30, 11:24 PM · Restricted Project, Restricted Project
sunho abandoned D128967: [JITLink] Initial COFF support..
Thu, Jun 30, 11:14 PM · Restricted Project, Restricted Project
sunho requested review of D128967: [JITLink] Initial COFF support..
Thu, Jun 30, 11:14 PM · Restricted Project, Restricted Project
sunho added inline comments to D128589: [clang-repl] Support destructors of global objects..
Thu, Jun 30, 11:52 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 26

sunho added a comment to D128589: [clang-repl] Support destructors of global objects..

This seems to be breaking builds in ppc bots. Invastigating right now.

Sun, Jun 26, 6:11 AM · Restricted Project, Restricted Project, Restricted Project
sunho added a reverting change for rG9de8b05bfe0d: [clang-repl] Support destructors of global objects.: rG45b6c38145e7: Revert "[clang-repl] Support destructors of global objects.".
Sun, Jun 26, 6:11 AM · Restricted Project, Restricted Project
sunho committed rG45b6c38145e7: Revert "[clang-repl] Support destructors of global objects." (authored by sunho).
Revert "[clang-repl] Support destructors of global objects."
Sun, Jun 26, 6:11 AM · Restricted Project, Restricted Project
sunho added a reverting change for D128589: [clang-repl] Support destructors of global objects.: rG45b6c38145e7: Revert "[clang-repl] Support destructors of global objects.".
Sun, Jun 26, 6:11 AM · Restricted Project, Restricted Project, Restricted Project
sunho updated the summary of D128601: [ORC][ORC_RT][AArch64] Implement TLS descriptor in ELFNixPlatform..
Sun, Jun 26, 4:36 AM · Restricted Project, Restricted Project, Restricted Project
sunho committed rG9de8b05bfe0d: [clang-repl] Support destructors of global objects. (authored by sunho).
[clang-repl] Support destructors of global objects.
Sun, Jun 26, 3:04 AM · Restricted Project, Restricted Project
sunho closed D128589: [clang-repl] Support destructors of global objects..
Sun, Jun 26, 3:03 AM · Restricted Project, Restricted Project, Restricted Project
sunho updated the diff for D128589: [clang-repl] Support destructors of global objects..
Sun, Jun 26, 1:21 AM · Restricted Project, Restricted Project, Restricted Project
sunho updated the diff for D128601: [ORC][ORC_RT][AArch64] Implement TLS descriptor in ELFNixPlatform..
Sun, Jun 26, 12:57 AM · Restricted Project, Restricted Project, Restricted Project
sunho updated the summary of D128601: [ORC][ORC_RT][AArch64] Implement TLS descriptor in ELFNixPlatform..
Sun, Jun 26, 12:37 AM · Restricted Project, Restricted Project, Restricted Project
sunho requested review of D128601: [ORC][ORC_RT][AArch64] Implement TLS descriptor in ELFNixPlatform..
Sun, Jun 26, 12:33 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Jun 25

sunho set the repository for D128589: [clang-repl] Support destructors of global objects. to rG LLVM Github Monorepo.
Sat, Jun 25, 12:18 PM · Restricted Project, Restricted Project, Restricted Project
sunho added a reviewer for D128589: [clang-repl] Support destructors of global objects.: v.g.vassilev.
Sat, Jun 25, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
sunho requested review of D128589: [clang-repl] Support destructors of global objects..
Sat, Jun 25, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
sunho committed rG7d101e43cd8a: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport. (authored by sunho).
[ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport.
Sat, Jun 25, 11:51 AM · Restricted Project, Restricted Project
sunho closed D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Sat, Jun 25, 11:50 AM · Restricted Project, Restricted Project

Fri, Jun 24

sunho updated the summary of D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 24, 5:29 AM · Restricted Project, Restricted Project
sunho added a comment to D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..

@sgraenitz I added a testcase and editted the description of the revision to explain the situation more thoroughly which I will use as a commit message. Does it look good to you?

Fri, Jun 24, 5:29 AM · Restricted Project, Restricted Project
sunho updated the summary of D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 24, 5:27 AM · Restricted Project, Restricted Project
sunho updated the diff for D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..

Add testcases

Fri, Jun 24, 5:17 AM · Restricted Project, Restricted Project

Fri, Jun 17

sunho added a comment to D127207: [flang][driver] Fix support for `-x`.

Hi! I'm not exactly sure what's going on. But, seems like build is failing here? https://lab.llvm.org/buildbot/#/builders/177/builds/5571

Fri, Jun 17, 5:20 PM · Restricted Project, Restricted Project, Restricted Project
sunho committed rG7bc00ce5cd41: [clang-repl] Remove memory leak of ASTContext/TargetMachine. (authored by sunho).
[clang-repl] Remove memory leak of ASTContext/TargetMachine.
Fri, Jun 17, 2:37 PM · Restricted Project, Restricted Project
sunho closed D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Fri, Jun 17, 2:36 PM · Restricted Project, Restricted Project
sunho updated the summary of D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 17, 3:55 AM · Restricted Project, Restricted Project
sunho updated the summary of D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 17, 3:43 AM · Restricted Project, Restricted Project
sunho updated the summary of D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 17, 3:41 AM · Restricted Project, Restricted Project
sunho updated the summary of D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 17, 2:54 AM · Restricted Project, Restricted Project
sunho retitled D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport. from [ORC][LLJIT] Add atexit support. to [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 17, 2:50 AM · Restricted Project, Restricted Project
sunho updated the diff for D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 17, 2:47 AM · Restricted Project, Restricted Project
sunho added a comment to D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..

Asan tests passing! Solves the memory leak issue for original as well as modified version of execute.cpp (Commit issue solved )

Fri, Jun 17, 2:28 AM · Restricted Project, Restricted Project
sunho requested review of D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..
Fri, Jun 17, 2:22 AM · Restricted Project, Restricted Project

Thu, Jun 16

sunho retitled D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine. from [Interpreter][ClangRepl] Remove memory leak of ASTContext/TargetMachine. to [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 10:19 PM · Restricted Project, Restricted Project
sunho updated the summary of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 6:22 PM · Restricted Project, Restricted Project
sunho abandoned D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Fix in windows build requires improving on ORC side. (extending GenericLLVMIRPlatformSupport or write new platform support) I'll reopen this once I have done this groundwork. For asan failiures, I believe https://reviews.llvm.org/D127991 should be enough.

Thu, Jun 16, 6:08 PM · Restricted Project
sunho updated the diff for D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..

format

Thu, Jun 16, 6:00 PM · Restricted Project, Restricted Project
sunho updated the summary of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 12:08 PM · Restricted Project, Restricted Project
sunho updated the summary of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 12:06 PM · Restricted Project, Restricted Project
sunho updated the summary of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 12:06 PM · Restricted Project, Restricted Project
sunho updated subscribers of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..

@Purva-Chaudhari Could you check this out?

Thu, Jun 16, 11:59 AM · Restricted Project, Restricted Project
sunho updated the summary of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 11:36 AM · Restricted Project, Restricted Project
sunho retitled D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine. from [Interpreter][ClangRepl] Fix memory leak of ASTContext. to [Interpreter][ClangRepl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 11:35 AM · Restricted Project, Restricted Project
sunho updated the diff for D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..

Remove leaks of targetmachine too.

Thu, Jun 16, 11:33 AM · Restricted Project, Restricted Project
sunho updated the summary of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 11:05 AM · Restricted Project, Restricted Project
sunho added a comment to D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 11:04 AM · Restricted Project, Restricted Project
sunho requested review of D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..
Thu, Jun 16, 10:53 AM · Restricted Project, Restricted Project
sunho added a comment to D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Gotcha. Let me look into it.

Thu, Jun 16, 6:21 AM · Restricted Project
sunho added a comment to D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

@Purva-Chaudhari Could you give me the full log of asan failure for reference?

Thu, Jun 16, 6:15 AM · Restricted Project
sunho added a comment to D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Hi @Purva-Chaudhari I haven't set up asan build setting yet. It's sad to hear it's still mem leaking. We need to look into somewhere else then...

Thu, Jun 16, 6:05 AM · Restricted Project
sunho updated the diff for D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..
Thu, Jun 16, 3:37 AM · Restricted Project
sunho updated the diff for D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..
Thu, Jun 16, 2:47 AM · Restricted Project
sunho updated the diff for D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..
Thu, Jun 16, 2:45 AM · Restricted Project
sunho updated the diff for D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Add testcase.

Thu, Jun 16, 2:42 AM · Restricted Project
sunho updated the diff for D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Clean up inside ~Interpreter

Thu, Jun 16, 1:53 AM · Restricted Project
sunho added a comment to D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Some notes: this is probably not related to asan errors of clang-repl popping up recently. There is no dtors emitted in related test cases. There's a chance this can fix things, though. Nevertheless, I think this is the right thing to do.

Thu, Jun 16, 12:43 AM · Restricted Project
sunho requested review of D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..
Thu, Jun 16, 12:37 AM · Restricted Project

Wed, Jun 15

sunho committed rGf3e7e4d786fa: [JITLink][AArch64][NFC] Suppress unused variable error. (authored by sunho).
[JITLink][AArch64][NFC] Suppress unused variable error.
Wed, Jun 15, 11:31 PM · Restricted Project, Restricted Project
sunho closed D127940: [JITLink][AArch64][NFC] Suppress unused variable error..
Wed, Jun 15, 11:30 PM · Restricted Project, Restricted Project
sunho requested review of D127940: [JITLink][AArch64][NFC] Suppress unused variable error..
Wed, Jun 15, 11:14 PM · Restricted Project, Restricted Project
sunho added inline comments to D127558: [JITLink][AArch64] Unify table managers of ELF and MachO..
Wed, Jun 15, 10:17 PM · Restricted Project, Restricted Project
sunho committed rG9fc0aa45e331: [JITLink][ELF] Log enum name of unsupported relocation type. (authored by sunho).
[JITLink][ELF] Log enum name of unsupported relocation type.
Wed, Jun 15, 7:27 AM · Restricted Project, Restricted Project
sunho closed D127715: [JITLink][ELF] Log enum name of unsupported relocation type..
Wed, Jun 15, 7:26 AM · Restricted Project, Restricted Project

Tue, Jun 14

sunho added a comment to D127720: [ORC-RT] Add integration tests for AArch64 Linux.

Wow, a lot of cool testcases.

Tue, Jun 14, 12:23 AM · Restricted Project, Restricted Project

Mon, Jun 13

sunho requested review of D127715: [JITLink][ELF] Log enum name of unsupported relocation type..
Mon, Jun 13, 10:50 PM · Restricted Project, Restricted Project
sunho committed rG3d8061a3beff: [JITLink][ELF][AArch64] Implement R_AARCH64_MOVW_UABS_G*_NC. (authored by sunho).
[JITLink][ELF][AArch64] Implement R_AARCH64_MOVW_UABS_G*_NC.
Mon, Jun 13, 10:07 PM · Restricted Project, Restricted Project
sunho closed D127585: [JITLink][ELF][AArch64] Implement R_AARCH64_MOVW_UABS_G*_NC..
Mon, Jun 13, 10:07 PM · Restricted Project, Restricted Project
sunho committed rG398df667d6d1: [JITLink][AArch64] Implement MoveWide16 generic edge. (authored by sunho).
[JITLink][AArch64] Implement MoveWide16 generic edge.
Mon, Jun 13, 9:52 PM · Restricted Project, Restricted Project
sunho closed D127584: [JITLink][AArch64] Implement MoveWide16 generic edge..
Mon, Jun 13, 9:52 PM · Restricted Project, Restricted Project
sunho committed rG6cc3450a5246: [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC) (authored by sunho).
[JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC)
Mon, Jun 13, 9:35 PM · Restricted Project, Restricted Project
sunho closed D127559: [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC).
Mon, Jun 13, 9:35 PM · Restricted Project, Restricted Project
sunho committed rGdb3722580335: [JITLink][AArch64] Unify table managers of ELF and MachO. (authored by sunho).
[JITLink][AArch64] Unify table managers of ELF and MachO.
Mon, Jun 13, 9:17 PM · Restricted Project, Restricted Project
sunho closed D127558: [JITLink][AArch64] Unify table managers of ELF and MachO..
Mon, Jun 13, 9:17 PM · Restricted Project, Restricted Project
sunho updated the diff for D127584: [JITLink][AArch64] Implement MoveWide16 generic edge..

Oops. I completely missed it. I've updated the code.

Mon, Jun 13, 6:45 PM · Restricted Project, Restricted Project

Sat, Jun 11

sunho requested review of D127585: [JITLink][ELF][AArch64] Implement R_AARCH64_MOVW_UABS_G*_NC..
Sat, Jun 11, 8:37 PM · Restricted Project, Restricted Project
sunho requested review of D127584: [JITLink][AArch64] Implement MoveWide16 generic edge..
Sat, Jun 11, 8:34 PM · Restricted Project, Restricted Project

Fri, Jun 10

sunho retitled D127559: [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC) from [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. to [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC).
Fri, Jun 10, 10:02 PM · Restricted Project, Restricted Project
sunho added reviewers for D127559: [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC): lhames, sgraenitz.
Fri, Jun 10, 10:01 PM · Restricted Project, Restricted Project
sunho requested review of D127559: [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC).
Fri, Jun 10, 10:01 PM · Restricted Project, Restricted Project
sunho requested review of D127558: [JITLink][AArch64] Unify table managers of ELF and MachO..
Fri, Jun 10, 9:50 PM · Restricted Project, Restricted Project
sunho committed rGf8a9536c5581: [JITLink][ELF][AArch64] Implement eh frame handling. (authored by sunho).
[JITLink][ELF][AArch64] Implement eh frame handling.
Fri, Jun 10, 12:07 PM · Restricted Project, Restricted Project
sunho closed D127063: [JITLink][ELF/AARCH64] Implement eh frame handling .
Fri, Jun 10, 12:06 PM · Restricted Project, Restricted Project

Thu, Jun 9

sunho committed rG6d67f7a3294d: [JITLink][EHFrameSupport] Remove CodeAlignmentFactor and DataAlignmentFactor… (authored by sunho).
[JITLink][EHFrameSupport] Remove CodeAlignmentFactor and DataAlignmentFactor…
Thu, Jun 9, 11:30 PM · Restricted Project, Restricted Project