Page MenuHomePhabricator
Feed Advanced Search

Jul 17 2019

ro added a comment to D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.
In D64482#1588154, @rnk wrote:

To avoid a similar inconsistence with host compilers that don't predefine _FILE_OFFSET_BITS=64
(e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted shortly.

I'm curious, what's the plan for that? I suppose the user can always take things into their own hands with -D and -U.

Jul 17 2019, 3:34 AM · Restricted Project, Restricted Project
ro committed rG966272157290: [Driver] Enable __cxa_atexit on Solaris (authored by ro).
[Driver] Enable __cxa_atexit on Solaris
Jul 17 2019, 1:38 AM
ro committed rL366305: [Driver] Enable __cxa_atexit on Solaris.
[Driver] Enable __cxa_atexit on Solaris
Jul 17 2019, 1:36 AM
ro closed D64491: [Driver] Enable __cxa_atexit on Solaris.
Jul 17 2019, 1:36 AM · Restricted Project, Restricted Project

Jul 16 2019

ro created D64796: [builtins][test] XFAIL two SPARC tests.
Jul 16 2019, 6:27 AM · Restricted Project, Restricted Project
ro created D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.
Jul 16 2019, 5:49 AM · Restricted Project, Restricted Project
ro added inline comments to rL366204: Document the LLVM_ENABLE_BINDINGS option.
Jul 16 2019, 5:07 AM
ro committed rGa5dc9c98352c: [Driver] Don't pass --dynamic-linker to ld on Solaris (authored by ro).
[Driver] Don't pass --dynamic-linker to ld on Solaris
Jul 16 2019, 4:07 AM
ro committed rL366202: [Driver] Don't pass --dynamic-linker to ld on Solaris.
[Driver] Don't pass --dynamic-linker to ld on Solaris
Jul 16 2019, 4:06 AM
ro closed D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris.
Jul 16 2019, 4:06 AM · Restricted Project, Restricted Project
ro added reviewers for D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris: hubert.reinterpretcast, jasonliu.

Ping? It's been a week and together with it's clang companion this patch is needed to unbreak make check-all with gcc 9. So it would
be good to get this into LLVM 9.

Jul 16 2019, 1:38 AM · Restricted Project
ro added reviewers for D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris: mehdi_amini, rnk.

Ping? It's been a week and it would be good to get this patch and its companion into LLVM 9: it unbreaks make check-all with gcc 9
and restores g++ compatibility.

Jul 16 2019, 1:38 AM · Restricted Project, Restricted Project
ro added reviewers for D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris: mehdi_amini, rnk.

Ping? It's been a ween and unless someone comes up with a good explanation why the default interpreter must be specified instead
of letting ld figure it out, this seems pretty obvious.

Jul 16 2019, 1:33 AM · Restricted Project, Restricted Project
ro added reviewers for D64491: [Driver] Enable __cxa_atexit on Solaris: mehdi_amini, rnk.

Ping? It's been a week and the patch seems completely in line with other ELF targets.

Jul 16 2019, 1:30 AM · Restricted Project, Restricted Project
ro added reviewers for D64484: [CMake] Add -z defs on Solaris: hubert.reinterpretcast, jasonliu.

Ping? It's been a week and this seems pretty obvious, bringing Solaris in line with other ELF targets.

Jul 16 2019, 1:25 AM · Restricted Project
ro added a reviewer for D64488: [Driver] Support -fsanitize=function on Solaris/x86: krytarowski.

Ping? It's been a week.

Jul 16 2019, 1:23 AM · Restricted Project, Restricted Project, Restricted Project
ro added a reviewer for D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC: jyknight.

Ping? It's been a week.

Jul 16 2019, 1:13 AM · Restricted Project
ro added a reviewer for D64496: [compiler-rt][builtins] Provide __clear_cache for SPARC: jyknight.

Ping? It's been a week.

Jul 16 2019, 1:10 AM · Restricted Project, Restricted Project

Jul 12 2019

ro committed rG4a9a772f44bf: Enable compiler-rt on SPARC (authored by ro).
Enable compiler-rt on SPARC
Jul 12 2019, 1:32 AM
ro committed rL365880: Enable compiler-rt on SPARC.
Enable compiler-rt on SPARC
Jul 12 2019, 1:32 AM
ro closed D40943: Enable compiler-rt on SPARC.
Jul 12 2019, 1:32 AM · Restricted Project, Restricted Project
ro committed rG56f2f1cdb36a: [Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout. (authored by ro).
[Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout.
Jul 12 2019, 1:32 AM
ro committed rL365879: [Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout..
[Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout.
Jul 12 2019, 1:28 AM
ro closed D64559: [Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout.DumpListOfModules on Solaris.
Jul 12 2019, 1:28 AM · Restricted Project, Restricted Project

Jul 11 2019

ro closed D64498: [profile][test] Fix Profile-* :: instrprof-merge.c etc. on SPARC.

Forgot to add Differential Revision: tag before URL, so closing manually.

Jul 11 2019, 11:32 AM · Restricted Project, Restricted Project
ro committed rG9512c0a1d196: [profile][test] Fix Profile-* :: instrprof-merge.c etc. on SPARC (authored by ro).
[profile][test] Fix Profile-* :: instrprof-merge.c etc. on SPARC
Jul 11 2019, 11:30 AM
ro committed rL365805: [profile][test] Fix Profile-* :: instrprof-merge.c etc. on SPARC.
[profile][test] Fix Profile-* :: instrprof-merge.c etc. on SPARC
Jul 11 2019, 11:29 AM
ro created D64559: [Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout.DumpListOfModules on Solaris.
Jul 11 2019, 5:15 AM · Restricted Project, Restricted Project
ro added a comment to D40943: Enable compiler-rt on SPARC.

Updated title and summary to reflect current status: ready to be reviewed.

Jul 11 2019, 4:54 AM · Restricted Project, Restricted Project
ro retitled D40943: Enable compiler-rt on SPARC from [Sanitizers] Enable sanitizers on SPARC (PR 33274) to Enable compiler-rt on SPARC.
Jul 11 2019, 4:51 AM · Restricted Project, Restricted Project
ro added a comment to D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.
Jul 11 2019, 4:28 AM · Restricted Project, Restricted Project
ro updated the diff for D64498: [profile][test] Fix Profile-* :: instrprof-merge.c etc. on SPARC.
  • Introduce new profile_test.h header to share the ALIGNED definition, now handling MSVC, too.
  • Use it in affected tests.
Jul 11 2019, 12:51 AM · Restricted Project, Restricted Project

Jul 10 2019

ro created D64498: [profile][test] Fix Profile-* :: instrprof-merge.c etc. on SPARC.
Jul 10 2019, 7:46 AM · Restricted Project, Restricted Project
ro created D64496: [compiler-rt][builtins] Provide __clear_cache for SPARC.
Jul 10 2019, 7:38 AM · Restricted Project, Restricted Project
ro added a comment to D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.

There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE for C++ only, while clang has long been doing it for all languages

Can you explain more about the hack https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0f97ccfdccc033f543ccbcb220697e62e84bf01f

Jul 10 2019, 7:30 AM · Restricted Project, Restricted Project
ro created D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris.
Jul 10 2019, 7:13 AM · Restricted Project, Restricted Project
ro created D64491: [Driver] Enable __cxa_atexit on Solaris.
Jul 10 2019, 7:09 AM · Restricted Project, Restricted Project
ro created D64488: [Driver] Support -fsanitize=function on Solaris/x86.
Jul 10 2019, 6:59 AM · Restricted Project, Restricted Project, Restricted Project
ro created D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC.
Jul 10 2019, 6:53 AM · Restricted Project
ro created D64484: [CMake] Add -z defs on Solaris.
Jul 10 2019, 6:42 AM · Restricted Project
ro created D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.
Jul 10 2019, 6:37 AM · Restricted Project
ro created D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.
Jul 10 2019, 6:33 AM · Restricted Project, Restricted Project

Jul 8 2019

ro committed rG40f159cc40e2: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris (authored by ro).
[Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris
Jul 8 2019, 3:10 PM
ro committed rL365399: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris.
[Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris
Jul 8 2019, 3:10 PM
ro closed D63601: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris.
Jul 8 2019, 3:09 PM · Restricted Project, Restricted Project
ro committed rG025e44f289b6: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris (authored by ro).
[Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris
Jul 8 2019, 3:09 PM
ro committed rL365396: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.
[Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris
Jul 8 2019, 3:04 PM
ro closed D63602: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.
Jul 8 2019, 3:04 PM · Restricted Project, Restricted Project
ro added a comment to D63602: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.
In D63602#1570884, @ro wrote:

Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has remained unreviewed for two weeks.

I would recommend to check for a recent activity of the reviewer and here I would not expect anything from @alekseyshl

Jul 8 2019, 3:01 PM · Restricted Project, Restricted Project
ro committed rG04ea772d5af9: [ubsan][test] Fix several UBSan-* :: TestCases/ImplicitConversion tests on… (authored by ro).
[ubsan][test] Fix several UBSan-* :: TestCases/ImplicitConversion tests on…
Jul 8 2019, 2:23 AM
ro committed rL365303: [ubsan][test] Fix several UBSan-* :: TestCases/ImplicitConversion tests on….
[ubsan][test] Fix several UBSan-* :: TestCases/ImplicitConversion tests on…
Jul 8 2019, 2:23 AM
ro closed D63984: [ubsan][test] Fix several UBSan-* :: TestCases/ImplicitConversion tests on Solaris.
Jul 8 2019, 2:23 AM · Restricted Project, Restricted Project
ro committed rGd11df93898a1: [ubsan][test] Don't disable ubsan testing on 64-bit Solaris/x86 (authored by ro).
[ubsan][test] Don't disable ubsan testing on 64-bit Solaris/x86
Jul 8 2019, 2:19 AM
ro committed rL365302: [ubsan][test] Don't disable ubsan testing on 64-bit Solaris/x86.
[ubsan][test] Don't disable ubsan testing on 64-bit Solaris/x86
Jul 8 2019, 2:18 AM
ro closed D63982: [ubsan][test] Don't disable ubsan testing on 64-bit Solaris/x86.
Jul 8 2019, 2:18 AM · Restricted Project, Restricted Project
ro added a comment to D63984: [ubsan][test] Fix several UBSan-* :: TestCases/ImplicitConversion tests on Solaris.

Ping? It's been a week now and the patch is completely mechanical. Or is there a better way to handle this? Duplicating each and every
affected CHECK* line feels unmaintanable to me.

Jul 8 2019, 1:22 AM · Restricted Project, Restricted Project
ro added a comment to D63982: [ubsan][test] Don't disable ubsan testing on 64-bit Solaris/x86.

Ping? It's been a week now and it should be pretty clear that 64-bit Solaris/x86 asan support is immaterial for ubsan.

Jul 8 2019, 1:20 AM · Restricted Project, Restricted Project

Jul 4 2019

ro added a comment to D63602: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.

Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has remained unreviewed for two weeks.

Jul 4 2019, 5:02 PM · Restricted Project, Restricted Project
ro added a comment to D63601: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris.

Ping^2. It's been two weeks now and the patch (with its companion https://reviews.llvm.org/D63602) should be pretty simple.

Jul 4 2019, 5:02 PM · Restricted Project, Restricted Project

Jul 2 2019

ro committed rG8d568d044cdc: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc (authored by ro).
[Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc
Jul 2 2019, 1:41 AM
ro committed rL364892: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc.
[Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc
Jul 2 2019, 1:41 AM
ro closed D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc.
Jul 2 2019, 1:41 AM · Restricted Project, Restricted Project
ro added a comment to D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc.

Then looks like the right thing to do.
Do you have commit access? Or you want me to submit this?

Jul 2 2019, 1:10 AM · Restricted Project, Restricted Project
ro added a comment to D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc.

Are you sure it's unused? I see several uses of this function:

Jul 2 2019, 12:56 AM · Restricted Project, Restricted Project
ro added a comment to D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc.

Ping? It's been a week and the patch is as obvious as it gets.

Jul 2 2019, 12:42 AM · Restricted Project, Restricted Project

Jul 1 2019

ro created D63984: [ubsan][test] Fix several UBSan-* :: TestCases/ImplicitConversion tests on Solaris.
Jul 1 2019, 2:25 AM · Restricted Project, Restricted Project
ro updated the diff for D40943: Enable compiler-rt on SPARC.

This slightly revised patch completely disabled asan testing since that would break the
build as described. It does build it to make sure that it keeps compiling for use in GCC
where it works just fine.

Jul 1 2019, 2:04 AM · Restricted Project, Restricted Project
ro created D63982: [ubsan][test] Don't disable ubsan testing on 64-bit Solaris/x86.
Jul 1 2019, 1:54 AM · Restricted Project, Restricted Project

Jun 28 2019

ro committed rG36c3d1312a07: [unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest. (authored by ro).
[unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest.
Jun 28 2019, 11:30 AM
ro committed rL364671: [unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest..
[unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest.
Jun 28 2019, 11:30 AM
ro closed D63598: [unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions on Solaris.
Jun 28 2019, 11:30 AM · Restricted Project

Jun 27 2019

ro added a comment to D63602: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.

Ping? It's been a week and I've since been informed that without it Solaris/SPARC compilation is broken since the sancov_* archives don't
exit (compiler-rt isn't built on sparc).

Jun 27 2019, 11:07 PM · Restricted Project, Restricted Project
ro added a comment to D63601: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris.

Ping? It's been a week and it's pretty trivial.

Jun 27 2019, 11:06 PM · Restricted Project, Restricted Project
ro added a comment to D63598: [unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions on Solaris.

Ping? It's been a week and he patch is pretty obvious.

Jun 27 2019, 11:06 PM · Restricted Project

Jun 26 2019

ro committed rL364475: [zorg] Fixes for solaris11-amd64, solaris11-sparcv9 builders.
[zorg] Fixes for solaris11-amd64, solaris11-sparcv9 builders
Jun 26 2019, 2:16 PM
ro closed D63757: [zorg] Fixes for solaris11-amd64, solaris11-sparcv9 builders.
Jun 26 2019, 2:16 PM · Restricted Project, Restricted Project
ro committed rGe6474e682aa4: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris (authored by ro).
[compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris
Jun 26 2019, 1:23 AM
ro committed rL364394: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris.
[compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris
Jun 26 2019, 1:20 AM
ro closed D63761: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris.
Jun 26 2019, 1:20 AM · Restricted Project, Restricted Project

Jun 25 2019

ro added a reviewer for D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc: samsonov.
Jun 25 2019, 5:52 AM · Restricted Project, Restricted Project
ro created D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc.
Jun 25 2019, 5:45 AM · Restricted Project, Restricted Project
ro updated the diff for D63761: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris.

Sorry, wrong patch.

Jun 25 2019, 4:49 AM · Restricted Project, Restricted Project
ro created D63761: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris.
Jun 25 2019, 4:36 AM · Restricted Project, Restricted Project
ro created D63757: [zorg] Fixes for solaris11-amd64, solaris11-sparcv9 builders.
Jun 25 2019, 1:26 AM · Restricted Project, Restricted Project

Jun 21 2019

ro added a comment to D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris.
In D63678#1554508, @rnk wrote:

I would almost prefer to XFAIL this on Solaris, I feel like the intent is clearer with echo.

Jun 21 2019, 4:32 PM · Restricted Project, Restricted Project

Jun 20 2019

ro committed rGd5f16d6cfccc: [test][Driver] Fix Clang :: Driver/cl-response-file.c (authored by ro).
[test][Driver] Fix Clang :: Driver/cl-response-file.c
Jun 20 2019, 2:32 PM
ro committed rL363985: [test][Driver] Fix Clang :: Driver/cl-response-file.c.
[test][Driver] Fix Clang :: Driver/cl-response-file.c
Jun 20 2019, 2:29 PM
ro closed D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c.
Jun 20 2019, 2:29 PM · Restricted Project, Restricted Project
ro committed rG6fde832b82da: [profile] Solaris ld supports __start___llvm_prof_data etc. labels (authored by ro).
[profile] Solaris ld supports __start___llvm_prof_data etc. labels
Jun 20 2019, 2:26 PM
ro committed rL363984: [profile] Solaris ld supports __start___llvm_prof_data etc. labels.
[profile] Solaris ld supports __start___llvm_prof_data etc. labels
Jun 20 2019, 2:25 PM
ro closed D41111: [profile] Solaris ld supports __start___llvm_prof_data etc. labels.
Jun 20 2019, 2:25 PM · Restricted Project
ro created D63602: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.
Jun 20 2019, 7:23 AM · Restricted Project, Restricted Project
ro created D63601: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris.
Jun 20 2019, 7:19 AM · Restricted Project, Restricted Project
ro updated the diff for D41111: [profile] Solaris ld supports __start___llvm_prof_data etc. labels.

Rebased an slightly fixed version. Without it, man profiling tests on Solaris FAIL like

Command Output (stderr):
--
Undefined                       first referenced
 symbol                             in file
__llvm_profile_register_names_function /tmp/lit_tmp_Nqu4eh/infinite_loop-9dc638.o
__llvm_profile_register_function    /tmp/lit_tmp_Nqu4eh/infinite_loop-9dc638.o

I don't think we need to worry about older versions of Solaris ld that don't support
__start_SECNAME and stop_SECNAME labels any longer: that feature is in
Solaris 11.4 and we already use Solaris 11.4-only features like ld -z gnu-version-script-compat
and fully working .preinit_array suport in compiler-rt.

Jun 20 2019, 7:03 AM · Restricted Project
ro created D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c.
Jun 20 2019, 6:35 AM · Restricted Project, Restricted Project
ro created D63598: [unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions on Solaris.
Jun 20 2019, 6:25 AM · Restricted Project

Jun 19 2019

ro committed rL363785: [zorg] Add solaris11-amd64, solaris11-sparcv9 builders.
[zorg] Add solaris11-amd64, solaris11-sparcv9 builders
Jun 19 2019, 3:26 AM
ro closed D63495: [zorg] Add solaris11-amd64, solaris11-sparcv9 builders.
Jun 19 2019, 3:26 AM · Restricted Project, Restricted Project
ro updated the diff for D63495: [zorg] Add solaris11-amd64, solaris11-sparcv9 builders.

Further testing in the exact buildbot user environment revealed that I'd forgotten one
crucial option: clang calls the linker with Solaris ld-only options. If GNU ld happens to
be earlier in PATH at link time, this breaks the build.

Jun 19 2019, 2:01 AM · Restricted Project, Restricted Project
ro committed rGcd31e7868b3e: [Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5 (authored by ro).
[Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5
Jun 19 2019, 1:57 AM