Page MenuHomePhabricator
Feed Advanced Search

Thu, May 21

kariddi committed rGdbaed589ab85: [SelectionDAG] Add the option of disabling generic combines. (authored by kariddi).
[SelectionDAG] Add the option of disabling generic combines.
Thu, May 21, 1:33 PM
kariddi closed D79112: [SelectionDAG] Add the option of disabling generic combines..
Thu, May 21, 1:33 PM · Restricted Project
kariddi added a comment to D79112: [SelectionDAG] Add the option of disabling generic combines..

Thanks for having a look Hendrik. I'm gonna push this considering there has been no push back for a month. If somebody wants to further comment on this or pitch for a revert please let me know.

Thu, May 21, 1:32 PM · Restricted Project

Wed, May 20

kariddi updated the diff for D79112: [SelectionDAG] Add the option of disabling generic combines..

Changed comment

Wed, May 20, 10:22 AM · Restricted Project
kariddi added inline comments to D79112: [SelectionDAG] Add the option of disabling generic combines..
Wed, May 20, 10:22 AM · Restricted Project
kariddi added a reviewer for D79112: [SelectionDAG] Add the option of disabling generic combines.: hgreving.
Wed, May 20, 9:16 AM · Restricted Project

Tue, May 19

kariddi added a comment to D79112: [SelectionDAG] Add the option of disabling generic combines..

ping :)

Tue, May 19, 1:44 PM · Restricted Project

Wed, May 13

kariddi added reviewers for D79112: [SelectionDAG] Add the option of disabling generic combines.: arsenm, craig.topper.
Wed, May 13, 11:25 AM · Restricted Project

Mon, May 11

kariddi added a comment to D79112: [SelectionDAG] Add the option of disabling generic combines..

ping

Mon, May 11, 8:34 AM · Restricted Project

May 4 2020

kariddi added a comment to D79112: [SelectionDAG] Add the option of disabling generic combines..

ping

May 4 2020, 1:01 AM · Restricted Project

Apr 29 2020

kariddi updated the diff for D79112: [SelectionDAG] Add the option of disabling generic combines..

Inverted condition for error.

Apr 29 2020, 2:00 PM · Restricted Project
kariddi added a comment to D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure.

ping

Apr 29 2020, 2:00 PM · Restricted Project
kariddi added inline comments to D79112: [SelectionDAG] Add the option of disabling generic combines..
Apr 29 2020, 2:00 PM · Restricted Project
kariddi updated the diff for D79112: [SelectionDAG] Add the option of disabling generic combines..

Adding an attribute in DAGCombiner that caches disableGenericCombines() calls.

Apr 29 2020, 2:00 PM · Restricted Project
kariddi updated the diff for D79112: [SelectionDAG] Add the option of disabling generic combines..

Changing to a disable flag.

Apr 29 2020, 12:54 PM · Restricted Project
kariddi updated the summary of D79112: [SelectionDAG] Add the option of disabling generic combines..
Apr 29 2020, 12:22 PM · Restricted Project
kariddi created D79112: [SelectionDAG] Add the option of disabling generic combines..
Apr 29 2020, 12:22 PM · Restricted Project

Apr 24 2020

kariddi accepted D78417: [SlotIndexes] Add insertion point for insertMBBIntoMaps.

LGTM

Apr 24 2020, 12:29 AM · Restricted Project

Apr 20 2020

kariddi added a comment to D78417: [SlotIndexes] Add insertion point for insertMBBIntoMaps.

I don't get completely what is the difference between this and just calling insertMBBInMaps() with the new block created by split as the argument. Shouldn't the insertion point being automatically devised correctly if the block is inserted in the right position?

Apr 20 2020, 1:33 PM · Restricted Project

Apr 16 2020

kariddi retitled D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure from [MachineDCE] Make sure MachineDCE considers subregs when adding liveins. to [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure.
Apr 16 2020, 7:30 PM · Restricted Project
kariddi abandoned D78175: [MachineDCE] Predicated instructions shouldn't clear LivePhysRegs..

I'm abandoning this for now based on the fact that I have another patch that ports DeadMachineInstrs to LivePhysRegs. LivePhysRegs though doesn't seem to care about predicates as well ... Probably the fix might need to go there

Apr 16 2020, 3:37 PM · Restricted Project

Apr 15 2020

kariddi updated the diff for D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure.

use addLiveOuts()

Apr 15 2020, 12:30 AM · Restricted Project

Apr 14 2020

kariddi updated the diff for D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure.

Moving to LivePhysReg

Apr 14 2020, 9:12 PM · Restricted Project
kariddi added inline comments to D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure.
Apr 14 2020, 6:31 PM · Restricted Project
kariddi added reviewers for D78175: [MachineDCE] Predicated instructions shouldn't clear LivePhysRegs.: rampitec, kparzysz.
Apr 14 2020, 6:31 PM · Restricted Project
kariddi created D78175: [MachineDCE] Predicated instructions shouldn't clear LivePhysRegs..
Apr 14 2020, 6:31 PM · Restricted Project
kariddi abandoned D78161: [MachineDCE] Predicated instructions shouldn't clear LivePhysRegs..
Apr 14 2020, 3:45 PM · Restricted Project
kariddi added a reviewer for D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure: hgreving.
Apr 14 2020, 3:45 PM · Restricted Project
kariddi added a reviewer for D78161: [MachineDCE] Predicated instructions shouldn't clear LivePhysRegs.: hgreving.
Apr 14 2020, 3:45 PM · Restricted Project
kariddi added reviewers for D78161: [MachineDCE] Predicated instructions shouldn't clear LivePhysRegs.: rampitec, ThomasRaoux, arsenm, kparzysz.
Apr 14 2020, 3:45 PM · Restricted Project
kariddi added a reviewer for D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure: ThomasRaoux.
Apr 14 2020, 3:45 PM · Restricted Project
kariddi added reviewers for D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure: rampitec, arsenm, alexfh, kparzysz.
Apr 14 2020, 3:45 PM · Restricted Project
kariddi created D78161: [MachineDCE] Predicated instructions shouldn't clear LivePhysRegs..
Apr 14 2020, 3:14 PM · Restricted Project
kariddi created D78159: [MachineDCE] Move machine DCE into using LivePhysRegs infrastructure.
Apr 14 2020, 3:12 PM · Restricted Project
kariddi accepted D78047: [AntiDepBreaker][NFC] Move AntiDepBreaker.h to include folder.

LGTM

Apr 14 2020, 10:10 AM · Restricted Project
kariddi added a comment to D77969: [LiveIntervals] Replace handleMoveIntoBundle.

I wonder if it would make sense to test that the SlotIndex is the same as the one of the bundle header after calling the method.

Apr 14 2020, 10:10 AM · Restricted Project

Apr 10 2020

kariddi committed rGea11f4726f2f: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC (authored by kariddi).
Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC
Apr 10 2020, 11:26 AM
kariddi closed D76584: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC.
Apr 10 2020, 11:26 AM · Restricted Project

Mar 24 2020

kariddi added inline comments to D76664: [ConstantFold][NFC] Compile time optimization for large vectors.
Mar 24 2020, 4:57 PM · Restricted Project
kariddi added a comment to D76664: [ConstantFold][NFC] Compile time optimization for large vectors.

Thanks for the patch! Some speedup in this area was dearly needed!

Mar 24 2020, 2:00 PM · Restricted Project
kariddi added inline comments to D76664: [ConstantFold][NFC] Compile time optimization for large vectors.
Mar 24 2020, 2:00 PM · Restricted Project
kariddi updated the diff for D76584: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC.

Addressing Matt's suggestions

Mar 24 2020, 1:03 AM · Restricted Project

Mar 22 2020

kariddi added reviewers for D76584: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC: qcolombet, MatzeB, arsenm, rtereshin.
Mar 22 2020, 8:56 PM · Restricted Project
kariddi created D76584: Split LiveRangeCalc in LiveRangeCalc/LiveIntervalCalc. NFC.
Mar 22 2020, 8:56 PM · Restricted Project

Mar 12 2020

kariddi committed rGba5500f27a26: [RAGreedy] Fix minor typo in comment. NFC (authored by kariddi).
[RAGreedy] Fix minor typo in comment. NFC
Mar 12 2020, 8:41 AM

Mar 9 2020

kariddi committed rGa8f76e99ba59: Fix indentation using clang-format for Spiller.h. NFC Spiller.h had indentation… (authored by kariddi).
Fix indentation using clang-format for Spiller.h. NFC Spiller.h had indentation…
Mar 9 2020, 11:20 AM
kariddi committed rGe5205074df0e: Move Spiller.h from lib/ directory path to include/CodeGen. NFC (authored by kariddi).
Move Spiller.h from lib/ directory path to include/CodeGen. NFC
Mar 9 2020, 11:20 AM
kariddi closed D75830: Move Spiller.h from lib/ directory path to include/CodeGen. NFC.
Mar 9 2020, 11:19 AM · Restricted Project

Mar 8 2020

kariddi abandoned D75829: Fix indentation using clang-format for Spiller.h. NFC.
Mar 8 2020, 12:16 PM · Restricted Project
kariddi created D75830: Move Spiller.h from lib/ directory path to include/CodeGen. NFC.
Mar 8 2020, 11:44 AM · Restricted Project
kariddi updated the diff for D75829: Fix indentation using clang-format for Spiller.h. NFC.

Moving the Spiller.h file from lib/CodeGen to include/llvm/CodeGen allowing it to be visible from external users.

Mar 8 2020, 11:12 AM · Restricted Project
kariddi abandoned D75829: Fix indentation using clang-format for Spiller.h. NFC.
Mar 8 2020, 11:12 AM · Restricted Project
kariddi created D75829: Fix indentation using clang-format for Spiller.h. NFC.
Mar 8 2020, 11:12 AM · Restricted Project

Mar 2 2020

kariddi added a comment to D73068: Reapply Avoid creating an immutable map in the Automaton class..

ping2 :)

Mar 2 2020, 11:36 AM · Restricted Project

Feb 24 2020

kariddi added a comment to D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.

LGTM

Feb 24 2020, 9:35 AM · Restricted Project
kariddi accepted D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.
Feb 24 2020, 9:35 AM · Restricted Project

Feb 21 2020

kariddi added inline comments to D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.
Feb 21 2020, 4:30 PM · Restricted Project
kariddi added a comment to D74893: [mlir] Intrinsics generator: use TableGen-defined builder function.

Thanks, nice cleanup!

Feb 21 2020, 4:20 PM · Restricted Project

Feb 5 2020

kariddi added a comment to D73068: Reapply Avoid creating an immutable map in the Automaton class..

ping

Feb 5 2020, 1:22 PM · Restricted Project

Jan 23 2020

kariddi committed rGbe9f09c768f9: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen. (authored by kariddi).
[mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen.
Jan 23 2020, 11:24 AM
kariddi closed D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 23 2020, 11:24 AM · Restricted Project
kariddi updated the diff for D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..

Ok, in this patch I'm stripping away the "TargetPrefix" off the intrinsics.
I don't know if there are some users that might want to keep that (at which point we might add it as a command line option)
but this avoids the nvvm.intr.nvvm.barrier0 problem, making the output just nvvm.intr.barrier0

Jan 23 2020, 10:36 AM · Restricted Project
kariddi added inline comments to D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 23 2020, 9:52 AM · Restricted Project
kariddi added inline comments to D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 23 2020, 9:30 AM · Restricted Project
kariddi added inline comments to D73068: Reapply Avoid creating an immutable map in the Automaton class..
Jan 23 2020, 8:34 AM · Restricted Project

Jan 22 2020

kariddi updated the diff for D73068: Reapply Avoid creating an immutable map in the Automaton class..

Fixing typo that made everything useless :P

Jan 22 2020, 5:59 PM · Restricted Project
kariddi created D73233: [mlir] Add option to use custom base class for dialect in LLVMIRIntrinsicGen..
Jan 22 2020, 2:31 PM · Restricted Project
kariddi committed rG04a151710e8b: [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen (authored by kariddi).
[mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen
Jan 22 2020, 8:02 AM
kariddi closed D73137: [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen.
Jan 22 2020, 8:02 AM · Restricted Project

Jan 21 2020

kariddi created D73137: [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen.
Jan 21 2020, 1:28 PM · Restricted Project
kariddi committed rGcbf08d0f5751: [mlir] Fix LLVM intrinsic convesion generator for overloadable types. (authored by kariddi).
[mlir] Fix LLVM intrinsic convesion generator for overloadable types.
Jan 21 2020, 11:55 AM
kariddi closed D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Jan 21 2020, 11:55 AM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Addressing comments

Jan 21 2020, 11:37 AM · Restricted Project
kariddi added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Comments addressed

Jan 21 2020, 11:37 AM · Restricted Project

Jan 20 2020

kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Fixing additional comments.

Jan 20 2020, 7:09 PM · Restricted Project
kariddi added inline comments to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Jan 20 2020, 7:09 PM · Restricted Project
kariddi created D73068: Reapply Avoid creating an immutable map in the Automaton class..
Jan 20 2020, 4:45 PM · Restricted Project

Jan 17 2020

kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Removing space

Jan 17 2020, 8:12 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Thanks River for the review. Addressed your comments.

Jan 17 2020, 8:12 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Testing the change by adapting existing test

Jan 17 2020, 7:46 PM · Restricted Project
kariddi created D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Jan 17 2020, 7:35 PM · Restricted Project

Jan 16 2020

kariddi committed rG051d330314cb: Avoid creating an immutable map in the Automaton class. (authored by kariddi).
Avoid creating an immutable map in the Automaton class.
Jan 16 2020, 6:54 PM
kariddi closed D72682: Avoid creating an immutable map in the Automaton class..
Jan 16 2020, 6:53 PM · Restricted Project

Jan 13 2020

kariddi updated the diff for D72682: Avoid creating an immutable map in the Automaton class..

Updating a stale comment where the old map used to live

Jan 13 2020, 10:21 PM · Restricted Project
kariddi created D72682: Avoid creating an immutable map in the Automaton class..
Jan 13 2020, 10:21 PM · Restricted Project

Oct 29 2019

kariddi added a comment to D69498: IR: Invert convergent attribute handling.

It absolutely makes sense for Clang as a GPU-programming frontend to set attributes appropriately when targeting the GPU. I'm objecting to making "convergence" and related "code layout is semantics" properties a universal part of the IR semantics that literally every frontend has to know about in order to get reasonable behavior from LLVM. I know that doing so makes sense to GPU backend developers because you mostly work exclusively on GPU toolchains, but AFAIK there are half a dozen GPU frontends and they're all forks of Clang, whereas there are dozens of LLVM frontends out there that don't care about targeting the GPU and quite possibly never will. (And even if they do target GPUs, they often will not care about exposing thread groups; many programming environments are just interested in taking advantage of the GPU's parallel-computation power and have no interest in inter-thread interference.)

John.

Oct 29 2019, 10:45 AM · Restricted Project
kariddi added a comment to D68994: [RFC] Redefine `convergent` in terms of dynamic instances.

Thanks for the answers! It was about time somebody tackled this problem in LLVM :)

Oct 29 2019, 9:38 AM · Restricted Project

Oct 28 2019

kariddi added a comment to D68994: [RFC] Redefine `convergent` in terms of dynamic instances.

What is the expectiation of lowering of a loop like the one you mentioned above?

Oct 28 2019, 7:19 PM · Restricted Project
kariddi added a comment to D69498: IR: Invert convergent attribute handling.

One thing to probably note is that its not only a "target specific" issue, but a language specific issue as well (IMHO). OpenCL, CUDA, SYCL are all languages (to name a few) that have a concept of "convergence" and its not related only to the fact that they mostly run on a GPU, but to their programming model as well with respect to accessing textures and SIMD-wide communication and decision making (ballot)

Oct 28 2019, 7:06 PM · Restricted Project
kariddi created D69515: [LiveIntervalUnion] Expose extraction of last index in map for external users.
Oct 28 2019, 8:51 AM · Restricted Project

Oct 16 2019

kariddi committed rG5926eb5fe64a: Clang-formatting of some files in LiveRangeCalc header (LiveRangeCalc.h) (authored by kariddi).
Clang-formatting of some files in LiveRangeCalc header (LiveRangeCalc.h)
Oct 16 2019, 8:18 PM
kariddi committed rG6fc9563dba63: Move LiveRangeCalc header to publicily available position. NFC (authored by kariddi).
Move LiveRangeCalc header to publicily available position. NFC
Oct 16 2019, 8:18 PM
kariddi closed D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available.
Oct 16 2019, 8:18 PM · Restricted Project
kariddi added a comment to D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available.

I was just about to do the same

Oct 16 2019, 8:18 PM · Restricted Project
kariddi added a reviewer for D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available: aditya_nandakumar.
Oct 16 2019, 6:37 PM · Restricted Project
kariddi created D69078: Move LiveRangeCalc header to the llvm/include directory to make it publicly available.
Oct 16 2019, 6:36 PM · Restricted Project

Oct 10 2019

kariddi committed rGa064edf55e1c: [GISel] Simplifying return from else in function. NFC (authored by kariddi).
[GISel] Simplifying return from else in function. NFC
Oct 10 2019, 2:53 PM
kariddi committed rG0112123eea5f: [GISel] Allow getConstantVRegVal() to return G_FCONSTANT values. (authored by kariddi).
[GISel] Allow getConstantVRegVal() to return G_FCONSTANT values.
Oct 10 2019, 2:53 PM
kariddi closed D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines.
Oct 10 2019, 2:53 PM · Restricted Project
kariddi added a reviewer for D68739: [GISel] Allow ConstantFoldBinOp to consider G_FCONSTANT binary representation for combines: arsenm.
Oct 10 2019, 2:15 PM · Restricted Project