You are the best! Thanks, Louis!
- All Stories
- Advanced Search
- Transaction Logs
Aug 4 2022
Jul 25 2022
Can you please add a round trip test as well?
Jul 24 2022
Jul 8 2022
Feb 21 2022
This looks great, thanks Egor!
Jan 27 2022
This patch looks awesome, Chris.
Dec 2 2021
Nov 11 2021
Aug 13 2021
Use inline cache.
Aug 12 2021
I have a few inline comments that I want to resolve tomorrow and I also need to fix the bots. Then I'll land this.
Address review comments.
Fix modules build and windows build.
Rebase and apply review comments.
Also, is there something that needs updating in the paper status?
Aug 11 2021
Fix based on review.
Generate private header tests.
- Add views::iota.
- Fix all the bots except for UBSan.
Aug 10 2021
Apply review comments
Make start private to fix friends in gcc.
Fix the 32 bit bots for real.
Aug 9 2021
Make ranges::iota_view<bool> invalid everywhere.
Fix the 32 bit bots.
Apply Chris' comments.
Apply review comments.
Aug 6 2021
Aug 4 2021
Remove __current_iter_base so this actually compiles.
Aug 3 2021
This is a separate patch, but it would be good to track what algorithms need to be implemented and who's doing that.
- Generate private header tests
- Add hide from ABI
- Remove log file
Jul 30 2021
Fix build again.
Nothing major. This looks good to me!
This implementation looks good to me. It's actually pretty simple, and I don't think we can shave anything else off. I have a few suggestions:
- Use _LIBCPP_EXPRESSION_EQUIVALENT in range_adaptors.h
- I want to see some more tests, specifically something like what I posted for the inline namespace example.
- And as we talked about, splitting this into separate patches would be great.
Apply review comments. Fix build.
Jul 29 2021
Anyway, beyond those mostly unrelated comments, I like this implementation a lot. Thanks for working out all the details and exploring this!
Jul 28 2021
Apply Chris' last comment. Fix GCC.
Apply review feedback
So it appears that the assign test crashes on GCC trunk! Anyway, I filed a bug (id = 101663), and I'll mark this test as unsupported on GCC.
Apply Louis' feedback.
Address Louis' comments.
Address Chris' comments.
Address Louis' comments.
Jul 27 2021
Go through list of things in the docs.
Add UNSUPPORTED: libcpp-has-no-incomplete-ranges. Rebase. Add range conformance tests.
Add a comment with a TODO for the ranges::min.
Apply feedback. Fix modules build. Move conformance tests into their own file as requested by Chriss.
@cjdb iterator_traits.compile.pass.cpp L71.
Address review comments and fix 32bit CI.
Apply Chris' feedback.
Jul 26 2021
Move Copyable and ContiguousView into the local header. They were conflicting with types that transform_view uses. I'll move them into test_ranges.h in a later commit.