Page MenuHomePhabricator
Feed Advanced Search

Yesterday

zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Remove test for iterator_traits<void*> pre-C++17. void can't be referenced so this was failing with a hard error.
Mon, Apr 19, 5:11 PM · Restricted Project
zoecarver committed rG2218f5998b5b: [libc++][gardening] Replace instances of `\x{AD}`. (authored by zoecarver).
[libc++][gardening] Replace instances of `\x{AD}`.
Mon, Apr 19, 3:00 PM
zoecarver closed D100799: [libc++][gardening] Replace instances of `\x{AD}`..
Mon, Apr 19, 3:00 PM · Restricted Project
zoecarver requested review of D100799: [libc++][gardening] Replace instances of `\x{AD}`..
Mon, Apr 19, 2:58 PM · Restricted Project
zoecarver added a comment to D100686: [libc++][nfc] Move iterator_traits and related into __iterator/iterator_traits.h..

Assuming the tests pass here as well, I'm going to land this with D99855.

Mon, Apr 19, 2:44 PM · Restricted Project
zoecarver updated the diff for D100686: [libc++][nfc] Move iterator_traits and related into __iterator/iterator_traits.h..
  • Fix includes.
  • Rebase off D99855.
Mon, Apr 19, 2:43 PM · Restricted Project
zoecarver added a comment to D99855: [libcxx] makes `iterator_traits` C++20-aware.

I will be committing when the CI passes.

Mon, Apr 19, 2:21 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Add a test for regex_token_iterator.
Mon, Apr 19, 2:21 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Add all c++ stdlib iterators.
  • * Apply remaining review comments.
Mon, Apr 19, 1:51 PM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Mon, Apr 19, 1:48 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Remove internal macros from tests.
Mon, Apr 19, 12:50 PM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Mon, Apr 19, 12:49 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Apply review comments
  • Format
  • Move around iterator_traits impl so that all __iterator_traits specializations are in a row.
Mon, Apr 19, 12:43 PM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Mon, Apr 19, 10:14 AM · Restricted Project
zoecarver accepted D100707: [libcxx][doc] Use Phabricator links..

Thanks for doing this @Mordante. Sorry I didn't review more quickly.

Mon, Apr 19, 9:45 AM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Mon, Apr 19, 9:08 AM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Mon, Apr 19, 9:01 AM · Restricted Project

Sat, Apr 17

zoecarver added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Sat, Apr 17, 5:36 PM · Restricted Project

Fri, Apr 16

zoecarver added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Fri, Apr 16, 3:28 PM · Restricted Project
zoecarver added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Fri, Apr 16, 3:03 PM · Restricted Project
zoecarver added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Fri, Apr 16, 3:02 PM · Restricted Project
zoecarver updated the diff for D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
  • Apply most of Arthur's comments.
Fri, Apr 16, 3:00 PM · Restricted Project
zoecarver updated the diff for D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers..

I accidently updated this patch instead of D100686. So, I'm just putting back the correct patch here.

Fri, Apr 16, 2:40 PM · Restricted Project
zoecarver updated the diff for D100686: [libc++][nfc] Move iterator_traits and related into __iterator/iterator_traits.h..
  • Rebase
Fri, Apr 16, 2:38 PM · Restricted Project
zoecarver updated the diff for D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers..
  • Rebase
Fri, Apr 16, 2:37 PM · Restricted Project
zoecarver updated the diff for D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers..
  • Apply cjdb's comments.
Fri, Apr 16, 2:33 PM · Restricted Project
zoecarver requested review of D100686: [libc++][nfc] Move iterator_traits and related into __iterator/iterator_traits.h..
Fri, Apr 16, 2:21 PM · Restricted Project
zoecarver added inline comments to D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers..
Fri, Apr 16, 1:34 PM · Restricted Project
zoecarver updated the diff for D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers..
  • Add licence comment.
Fri, Apr 16, 1:33 PM · Restricted Project
zoecarver added inline comments to D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers..
Fri, Apr 16, 1:32 PM · Restricted Project
zoecarver requested review of D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers..
Fri, Apr 16, 1:28 PM · Restricted Project
zoecarver added a comment to D99855: [libcxx] makes `iterator_traits` C++20-aware.

Okay, this is now ready for re-review!

Fri, Apr 16, 12:35 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Apply Louis' comment about has_arrow
Fri, Apr 16, 12:34 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • (Again) base on correct commit.
Fri, Apr 16, 12:25 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Add a few more tests.
  • Fix inline comments.
  • Re structure impl.
  • Remove "-_" characters.
Fri, Apr 16, 12:24 PM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Fri, Apr 16, 11:59 AM · Restricted Project
zoecarver planned changes to D99855: [libcxx] makes `iterator_traits` C++20-aware.

...while I update the rest of the comments. (Should have done this last night, sorry.)

Fri, Apr 16, 8:40 AM · Restricted Project

Thu, Apr 15

zoecarver added a comment to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.

With all that in mind, I think the added complexity is justified.

Thu, Apr 15, 9:30 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.
  • Base diff on correct commit.
Thu, Apr 15, 4:25 PM · Restricted Project
zoecarver updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.

Adds Arthur's (modified) tests. I have not started to apply the other review comments yet.

Thu, Apr 15, 4:23 PM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Thu, Apr 15, 3:57 PM · Restricted Project
zoecarver commandeered D99855: [libcxx] makes `iterator_traits` C++20-aware.

rebases so @zoecarver can commandeer without issue

Thu, Apr 15, 2:55 PM · Restricted Project
zoecarver commandeered D99855: [libcxx] makes `iterator_traits` C++20-aware.
Thu, Apr 15, 2:48 PM · Restricted Project
zoecarver added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Thu, Apr 15, 1:11 PM · Restricted Project
zoecarver added a comment to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..

I should have mentioned: this implements LWG3530.

Should it be marked on status page?

Thu, Apr 15, 1:02 PM · Restricted Project
zoecarver added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Thu, Apr 15, 12:59 PM · Restricted Project
zoecarver added a comment to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..

@Quuxplusone look good now?

Thu, Apr 15, 12:53 PM · Restricted Project
zoecarver updated the diff for D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..

Inline and remove check_sized_sentinel_for.

Thu, Apr 15, 12:40 PM · Restricted Project
zoecarver updated the diff for D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..
  • Apply Arthur's feedback.
Thu, Apr 15, 12:34 PM · Restricted Project
zoecarver added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Thu, Apr 15, 12:33 PM · Restricted Project
zoecarver added inline comments to D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..
Thu, Apr 15, 12:31 PM · Restricted Project
zoecarver accepted D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..

Thanks! I'll land it once the tests pass and parent patches are committed.

Thu, Apr 15, 11:50 AM · Restricted Project
zoecarver updated the diff for D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..
  • Small formatting changes.
Thu, Apr 15, 11:37 AM · Restricted Project
zoecarver requested review of D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..
Thu, Apr 15, 11:35 AM · Restricted Project
zoecarver added a comment to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

I removed the dependency on D99141 because it already landed. This was making the phab CLI confused.

Thu, Apr 15, 9:04 AM · Restricted Project
zoecarver added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Thu, Apr 15, 8:54 AM · Restricted Project
zoecarver updated the diff for D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
  • Update based on review.
Thu, Apr 15, 8:44 AM · Restricted Project

Wed, Apr 14

zoecarver accepted D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

Thanks for the updates!

Wed, Apr 14, 9:38 PM · Restricted Project
zoecarver added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Wed, Apr 14, 9:34 PM · Restricted Project
zoecarver updated the diff for D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
  • Use generate_n and make_shared.
Wed, Apr 14, 5:17 PM · Restricted Project
zoecarver accepted D90999: [libc++] Implements ranges::enable_borrowed_range.

Please fix the remaining few nits and land this! Thanks @Mordante! (You can accept on behalf of libc++ yourself.)

Wed, Apr 14, 5:06 PM · Restricted Project
zoecarver committed rGb12f3ce47f89: [libcxx][nfc] Assign [ranges.primitives] in "RangesStatus." (authored by zoecarver).
[libcxx][nfc] Assign [ranges.primitives] in "RangesStatus."
Wed, Apr 14, 4:11 PM
zoecarver accepted D100160: [libcxx] adds `std::input_or_output_iterator` and `std::sentinel_for` to <iterator>.

LGMT.

Wed, Apr 14, 3:41 PM · Restricted Project
zoecarver accepted D100080: [libcxx] adds `std::weakly_incrementable` and `std::incrementable` to <iterator>.

This LGTM sans the small nits.

Wed, Apr 14, 3:25 PM · Restricted Project
zoecarver accepted D100078: [libcxx] adds `std::indirectly_writable` to <iterator>.

LGTM. Thanks.

Wed, Apr 14, 3:11 PM · Restricted Project
zoecarver added inline comments to D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.
Wed, Apr 14, 2:57 PM · Restricted Project
zoecarver added a comment to D100073: [libcxx] adds `std::indirectly_readable` to <iterator>.

Overall, I think this patch is great. There are a lot of tests, but they're all super simple and easily verifiable. Other than the few very small comments I made inline, this LGTM.

Wed, Apr 14, 2:24 PM · Restricted Project
zoecarver requested changes to D100073: [libcxx] adds `std::indirectly_readable` to <iterator>.

I have at least these few small comments, so please hold off on committing.

Wed, Apr 14, 2:17 PM · Restricted Project
zoecarver added a comment to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.

Just some super small things. But LGTM!

Wed, Apr 14, 1:51 PM · Restricted Project
zoecarver added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Wed, Apr 14, 12:54 PM · Restricted Project
zoecarver added inline comments to D81417: [libcxx] Fix LWG 2874: Constructor shared_ptr::shared_ptr(Y*) should be constrained..
Wed, Apr 14, 12:42 PM · Restricted Project
zoecarver accepted D81417: [libcxx] Fix LWG 2874: Constructor shared_ptr::shared_ptr(Y*) should be constrained..

Two nits, feel free to take or leave them. LGTM.

Wed, Apr 14, 12:32 PM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Wed, Apr 14, 12:23 PM · Restricted Project
zoecarver added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Wed, Apr 14, 11:58 AM · Restricted Project
zoecarver updated the diff for D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
  • Update based on review.
  • Use correct unsupported comment for tests.
Wed, Apr 14, 11:57 AM · Restricted Project

Tue, Apr 13

zoecarver committed rG0f0149b8d3be: [libc++][docs] Add status docs for ranges. (authored by zoecarver).
[libc++][docs] Add status docs for ranges.
Tue, Apr 13, 6:00 PM
zoecarver closed D100393: [libc++][docs] Add status docs for ranges..
Tue, Apr 13, 6:00 PM · Restricted Project
zoecarver updated the diff for D100393: [libc++][docs] Add status docs for ranges..
  • Apply feedback.
Tue, Apr 13, 5:56 PM · Restricted Project
zoecarver added a comment to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..

I should have mentioned: this implements LWG3530.

Tue, Apr 13, 5:30 PM · Restricted Project
zoecarver requested review of D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Tue, Apr 13, 5:28 PM · Restricted Project
zoecarver updated subscribers of D99855: [libcxx] makes `iterator_traits` C++20-aware.
Tue, Apr 13, 3:24 PM · Restricted Project
zoecarver added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Tue, Apr 13, 2:01 PM · Restricted Project
zoecarver added a comment to D99855: [libcxx] makes `iterator_traits` C++20-aware.

The logic LGTM.

Tue, Apr 13, 1:59 PM · Restricted Project
zoecarver added inline comments to D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.
Tue, Apr 13, 12:05 PM · Restricted Project
zoecarver added a comment to D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

Please mark LWG3420 as complete in the status. Haven't looked at the tests yet.

Tue, Apr 13, 11:52 AM · Restricted Project
zoecarver added a comment to D100393: [libc++][docs] Add status docs for ranges..

Thanks for doing that @cjdb! I'll apply those and fix the names.

Tue, Apr 13, 11:23 AM · Restricted Project
zoecarver accepted D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

This LGTM, though. Other than the small comments.

Tue, Apr 13, 11:22 AM · Restricted Project
zoecarver added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Tue, Apr 13, 11:21 AM · Restricted Project
zoecarver added inline comments to D90999: [libc++] Implements ranges::enable_borrowed_range.
Tue, Apr 13, 10:55 AM · Restricted Project
zoecarver requested review of D100393: [libc++][docs] Add status docs for ranges..
Tue, Apr 13, 9:49 AM · Restricted Project

Thu, Apr 8

zoecarver committed rG097d77d611d1: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array… (authored by zoecarver).
[libcxx] Allow shared_ptr's unique_ptr converting constructor to support array…
Thu, Apr 8, 10:06 PM
zoecarver closed D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
Thu, Apr 8, 10:05 PM · Restricted Project
zoecarver updated the diff for D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
  • Enable array->array tests after C++14 only
Thu, Apr 8, 12:53 PM · Restricted Project
zoecarver added inline comments to D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
Thu, Apr 8, 12:52 PM · Restricted Project
zoecarver added a comment to D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..

For sure, will do, thanks for reviewing!

Thu, Apr 8, 12:00 PM · Restricted Project
zoecarver updated the diff for D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
  • Test the right thing!
  • Remove "explicit" in ctor comment.
Thu, Apr 8, 11:56 AM · Restricted Project
zoecarver accepted D99691: [libcxx] adjusts formatting rules.

I started working on SpacesInAngles: Leave option for clang-format. If that's accepted, we could use this option together with Standard: Latest (or c++20, btw, Cpp11 is deprecated). I need to check that there's nothing else apart angle brackets that may break pre-C++20 code.

Thu, Apr 8, 11:35 AM · Restricted Project
zoecarver added inline comments to D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
Thu, Apr 8, 11:16 AM · Restricted Project
zoecarver updated the diff for D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
  • Remove constraint not is_array from overloads.
Thu, Apr 8, 11:15 AM · Restricted Project
zoecarver added a comment to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.

This still LGTM. I think we should land this to get stuff unblocked! (After another reviewer approves.)

Thu, Apr 8, 10:50 AM · Restricted Project