You are the best! Thanks, Louis!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 4 2022
Aug 4 2022
Jul 25 2022
Jul 25 2022
Can you please add a round trip test as well?
Jul 24 2022
Jul 24 2022
Jul 8 2022
Jul 8 2022
zoecarver committed rG22c7a6ddddec: [objcxx] Fix `std::addressof` for `id`. (authored by zoecarver).
[objcxx] Fix `std::addressof` for `id`.
Feb 21 2022
Feb 21 2022
zoecarver accepted D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features.
This looks great, thanks Egor!
Jan 27 2022
Jan 27 2022
zoecarver added a comment to D116203: [clang] adds unary type transformations as compiler built-ins.
This patch looks awesome, Chris.
Dec 2 2021
Dec 2 2021
Dec 2 2021, 1:51 PM · Restricted Project
Nov 11 2021
Nov 11 2021
zoecarver accepted D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty.
Nov 11 2021, 2:12 PM · Restricted Project
Aug 13 2021
Aug 13 2021
Aug 13 2021, 4:17 PM · Restricted Project
zoecarver committed rG9ed077817910: [libcxx][ranges] Move `namespace views` into `namespace ranges` and add an… (authored by zoecarver).
[libcxx][ranges] Move `namespace views` into `namespace ranges` and add an…
zoecarver closed D108047: [libcxx][ranges] Move `namespace views` into `namespace ranges` and add an alias..
Aug 13 2021, 4:12 PM · Restricted Project
zoecarver added inline comments to D108047: [libcxx][ranges] Move `namespace views` into `namespace ranges` and add an alias..
Aug 13 2021, 4:11 PM · Restricted Project
zoecarver added inline comments to D108047: [libcxx][ranges] Move `namespace views` into `namespace ranges` and add an alias..
Aug 13 2021, 11:39 AM · Restricted Project
zoecarver requested review of D108047: [libcxx][ranges] Move `namespace views` into `namespace ranges` and add an alias..
Aug 13 2021, 11:37 AM · Restricted Project
zoecarver committed rGdf324bba5c4c: [libcxx][ranges] Add `ranges::join_view`. (authored by zoecarver).
[libcxx][ranges] Add `ranges::join_view`.
zoecarver committed rG7b20e05c714e: [libcxx][ranges] Add `ranges::iota_view`. (authored by zoecarver).
[libcxx][ranges] Add `ranges::iota_view`.
Aug 13 2021, 11:31 AM · Restricted Project
Aug 13 2021, 11:31 AM · Restricted Project
Use inline cache.
Aug 13 2021, 9:24 AM · Restricted Project
Aug 13 2021, 9:24 AM · Restricted Project
Aug 12 2021
Aug 12 2021
I have a few inline comments that I want to resolve tomorrow and I also need to fix the bots. Then I'll land this.
Aug 12 2021, 5:31 PM · Restricted Project
Address review comments.
Aug 12 2021, 5:26 PM · Restricted Project
Fix modules build and windows build.
Aug 12 2021, 3:09 PM · Restricted Project
Apply comments.
Aug 12 2021, 11:16 AM · Restricted Project
Rebase and apply review comments.
Aug 12 2021, 10:36 AM · Restricted Project
zoecarver committed rG4ac87e33785e: [libcxx][ranges] Add `unreachable_sentinel`. (authored by zoecarver).
[libcxx][ranges] Add `unreachable_sentinel`.
Aug 12 2021, 10:11 AM · Restricted Project
Also, is there something that needs updating in the paper status?
Aug 12 2021, 10:10 AM · Restricted Project
Aug 11 2021
Aug 11 2021
Fix based on review.
Aug 11 2021, 6:26 PM · Restricted Project
Aug 11 2021, 6:24 PM · Restricted Project
Aug 11 2021, 3:31 PM · Restricted Project
Generate private header tests.
Aug 11 2021, 11:18 AM · Restricted Project
Aug 11 2021, 11:17 AM · Restricted Project
- Add views::iota.
- Fix all the bots except for UBSan.
Aug 11 2021, 10:42 AM · Restricted Project
Aug 11 2021, 9:44 AM · Restricted Project
Aug 11 2021, 9:42 AM · Restricted Project
Aug 10 2021
Aug 10 2021
Apply review comments
Aug 10 2021, 5:44 PM · Restricted Project
Aug 10 2021, 5:42 PM · Restricted Project
zoecarver committed rGf9e58f35e905: [libcxx][ranges] Add `views::counted` CPO. (authored by zoecarver).
[libcxx][ranges] Add `views::counted` CPO.
Aug 10 2021, 4:42 PM · Restricted Project
LGTM. Thanks!
Aug 10 2021, 4:38 PM · Restricted Project
Aug 10 2021, 12:21 PM · Restricted Project
Make start private to fix friends in gcc.
Aug 10 2021, 10:26 AM · Restricted Project
Fix the 32 bit bots for real.
Aug 10 2021, 10:24 AM · Restricted Project
Aug 9 2021
Aug 9 2021
Make ranges::iota_view<bool> invalid everywhere.
Aug 9 2021, 3:32 PM · Restricted Project
Fix the 32 bit bots.
Aug 9 2021, 3:16 PM · Restricted Project
zoecarver committed rG9d982c67ba01: [libcxx][ranges] Add `ranges::reverse_view`. (authored by zoecarver).
[libcxx][ranges] Add `ranges::reverse_view`.
Aug 9 2021, 3:10 PM · Restricted Project
Apply Chris' comments.
Aug 9 2021, 1:54 PM · Restricted Project
Aug 9 2021, 1:40 PM · Restricted Project
Apply review comments.
Aug 9 2021, 12:51 PM · Restricted Project
Aug 6 2021
Aug 6 2021
Aug 6 2021, 3:34 PM · Restricted Project
Aug 4 2021
Aug 4 2021
Remove __current_iter_base so this actually compiles.
Aug 3 2021
Aug 3 2021
This is a separate patch, but it would be good to track what algorithms need to be implemented and who's doing that.
Aug 3 2021, 1:44 PM · Restricted Project
- Generate private header tests
- Add hide from ABI
- Remove log file
Aug 3 2021, 1:18 PM · Restricted Project
Aug 3 2021, 1:14 PM · Restricted Project
Jul 30 2021
Jul 30 2021
Fix build again.
Jul 30 2021, 4:25 PM · Restricted Project
Nothing major. This looks good to me!
Jul 30 2021, 4:18 PM · Restricted Project
This implementation looks good to me. It's actually pretty simple, and I don't think we can shave anything else off. I have a few suggestions:
- Use _LIBCPP_EXPRESSION_EQUIVALENT in range_adaptors.h
- I want to see some more tests, specifically something like what I posted for the inline namespace example.
- And as we talked about, splitting this into separate patches would be great.
Jul 30 2021, 4:08 PM · Restricted Project
zoecarver committed rG3df649e61915: [libcxx][docs] Take locks on the last three views. (authored by zoecarver).
[libcxx][docs] Take locks on the last three views.
Jul 30 2021, 2:59 PM · Restricted Project
Apply review comments. Fix build.
Jul 30 2021, 2:59 PM · Restricted Project
zoecarver committed rG481ad59b9fa4: [libcxx][ranges] Add `std::ranges::single_view`. (authored by zoecarver).
[libcxx][ranges] Add `std::ranges::single_view`.
Jul 30 2021, 10:53 AM · Restricted Project
Jul 29 2021
Jul 29 2021
zoecarver added a comment to D107098: [libc++] Implement the underlying mechanism for range adaptors.
Anyway, beyond those mostly unrelated comments, I like this implementation a lot. Thanks for working out all the details and exploring this!
Jul 29 2021, 4:50 PM · Restricted Project
zoecarver added inline comments to D107098: [libc++] Implement the underlying mechanism for range adaptors.
Jul 29 2021, 4:49 PM · Restricted Project
Jul 29 2021, 12:08 PM · Restricted Project
Jul 28 2021
Jul 28 2021
Apply Chris' last comment. Fix GCC.
Jul 28 2021, 4:18 PM · Restricted Project
Apply review feedback
Jul 28 2021, 3:39 PM · Restricted Project
So it appears that the assign test crashes on GCC trunk! Anyway, I filed a bug (id = 101663), and I'll mark this test as unsupported on GCC.
Jul 28 2021, 3:38 PM · Restricted Project
Apply Louis' feedback.
Jul 28 2021, 2:53 PM · Restricted Project
zoecarver committed rG0f4b41e03853: [libcxx][ranges] Add ranges::take_view. (authored by zoecarver).
[libcxx][ranges] Add ranges::take_view.
Jul 28 2021, 12:14 PM · Restricted Project
Address Louis' comments.
Jul 28 2021, 11:33 AM · Restricted Project
Address Chris' comments.
Jul 28 2021, 11:24 AM · Restricted Project
Jul 28 2021, 11:24 AM · Restricted Project
Address Louis' comments.
Jul 28 2021, 11:22 AM · Restricted Project
Jul 28 2021, 11:21 AM · Restricted Project
Jul 27 2021
Jul 27 2021
Go through list of things in the docs.
Jul 27 2021, 4:54 PM · Restricted Project
Jul 27 2021, 4:51 PM · Restricted Project
Add UNSUPPORTED: libcpp-has-no-incomplete-ranges. Rebase. Add range conformance tests.
Jul 27 2021, 4:07 PM · Restricted Project
Add a comment with a TODO for the ranges::min.
Jul 27 2021, 3:54 PM · Restricted Project
zoecarver committed rG8a48e6dda9f7: [libcxx][ranges] Add `counted_iterator`. (authored by zoecarver).
[libcxx][ranges] Add `counted_iterator`.
zoecarver committed rGb187e0389d13: [libcxx][nfc] Delete `cpp20_input_iterator`'s default constructor. (authored by zoecarver).
[libcxx][nfc] Delete `cpp20_input_iterator`'s default constructor.
Jul 27 2021, 3:50 PM · Restricted Project
Apply feedback. Fix modules build. Move conformance tests into their own file as requested by Chriss.
Jul 27 2021, 3:09 PM · Restricted Project
@cjdb iterator_traits.compile.pass.cpp L71.
Jul 27 2021, 2:23 PM · Restricted Project
Jul 27 2021, 11:03 AM · Restricted Project
Address review comments and fix 32bit CI.
Jul 27 2021, 10:49 AM · Restricted Project
Jul 27 2021, 10:47 AM · Restricted Project
Apply Chris' feedback.
Jul 27 2021, 9:27 AM · Restricted Project
Jul 27 2021, 9:27 AM · Restricted Project
Jul 26 2021
Jul 26 2021
Jul 26 2021, 5:28 PM · Restricted Project
Move Copyable and ContiguousView into the local header. They were conflicting with types that transform_view uses. I'll move them into test_ranges.h in a later commit.
Jul 26 2021, 3:47 PM · Restricted Project
Fix GCC.
Jul 26 2021, 3:39 PM · Restricted Project