Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

May 26 2022

sdasgup3 closed D126504: Summary: [mlir] Fix the misspellings of CHECK-* directives..

Already covered by https://reviews.llvm.org/D125604

May 26 2022, 5:49 PM · Restricted Project, Restricted Project
sdasgup3 added a comment to D126504: Summary: [mlir] Fix the misspellings of CHECK-* directives..

Sure. I will rebase on top of the current main branch before push it.

May 26 2022, 4:06 PM · Restricted Project, Restricted Project
sdasgup3 requested review of D126504: Summary: [mlir] Fix the misspellings of CHECK-* directives..
May 26 2022, 2:53 PM · Restricted Project, Restricted Project

Nov 23 2021

sdasgup3 added inline comments to D113719: [mlir] Refactoring a few Parser APIs.
Nov 23 2021, 3:33 AM · Restricted Project

Nov 22 2021

sdasgup3 added inline comments to D113719: [mlir] Refactoring a few Parser APIs.
Nov 22 2021, 1:18 PM · Restricted Project
sdasgup3 updated the diff for D113719: [mlir] Refactoring a few Parser APIs.
  1. Updating D113719: [mlir] Refactoring a few Parser APIs #

Addressed the review comments.

Nov 22 2021, 1:17 PM · Restricted Project
sdasgup3 added inline comments to D113719: [mlir] Refactoring a few Parser APIs.
Nov 22 2021, 8:07 AM · Restricted Project

Nov 19 2021

sdasgup3 added inline comments to D113719: [mlir] Refactoring a few Parser APIs.
Nov 19 2021, 3:27 PM · Restricted Project
sdasgup3 updated the diff for D113719: [mlir] Refactoring a few Parser APIs.
  1. Updating D113719: [mlir] Refactoring a few Parser APIs #

Changed the return type of pasreCustomOperationName to OperationName.

Nov 19 2021, 3:27 PM · Restricted Project
sdasgup3 added inline comments to D113719: [mlir] Refactoring a few Parser APIs.
Nov 19 2021, 12:50 AM · Restricted Project
sdasgup3 updated the diff for D113719: [mlir] Refactoring a few Parser APIs.
  1. Updating D113719: [mlir] Refactoring a few Parser APIs #

Addressed all the comments except the one related to leveraging a recent change
https://reviews.llvm.org/D114049. Waiting of the change to sync in the
repository I am working on.

Nov 19 2021, 12:49 AM · Restricted Project

Nov 17 2021

sdasgup3 updated the diff for D113719: [mlir] Refactoring a few Parser APIs.
  1. Updating D113719: [mlir] Refactoring a few Parser APIs #

Refactored the APIs as per the following review comments.

Nov 17 2021, 3:51 AM · Restricted Project

Nov 12 2021

sdasgup3 updated the diff for D113719: [mlir] Refactoring a few Parser APIs.
  1. Updating D113719: [mlir] Refactoring a few Parser APIs #

Fixing build failures.

Nov 12 2021, 4:35 PM · Restricted Project

Nov 11 2021

sdasgup3 added inline comments to D113719: [mlir] Refactoring a few Parser APIs.
Nov 11 2021, 4:49 PM · Restricted Project
sdasgup3 updated the diff for D113719: [mlir] Refactoring a few Parser APIs.
  1. Updating D113719: [mlir] Refactoring a few Parser APIs #

Fixed an issue with the API CustomOpAsmParser::parseCustomOperationName exposing
the AbstractOperation.

Nov 11 2021, 4:35 PM · Restricted Project
sdasgup3 requested review of D113719: [mlir] Refactoring a few Parser APIs.
Nov 11 2021, 2:38 PM · Restricted Project