Page MenuHomePhabricator
Feed Advanced Search

Today

craig.topper committed rGf8f1b20e6b30: [RISCV] Don't create LMUL=8 pseudo instructions for ternary widening arithmetic… (authored by craig.topper).
[RISCV] Don't create LMUL=8 pseudo instructions for ternary widening arithmetic…
Thu, Jan 21, 7:30 PM
craig.topper closed D95189: [RISCV] Don't create LMUL=8 pseudo instructions for ternary widening arithmetic instructions.
Thu, Jan 21, 7:30 PM · Restricted Project
craig.topper accepted D94749: [RISCV] Correct DWARF number for vector registers..

LGTM

Thu, Jan 21, 7:29 PM · Restricted Project
craig.topper requested review of D95189: [RISCV] Don't create LMUL=8 pseudo instructions for ternary widening arithmetic instructions.
Thu, Jan 21, 5:58 PM · Restricted Project
craig.topper committed rG3b5430eb0dad: [RISCV] Add a VL output to vleff intrinsics. (authored by craig.topper).
[RISCV] Add a VL output to vleff intrinsics.
Thu, Jan 21, 5:21 PM
craig.topper closed D94286: [RISCV] Add a VL output to vleff intrinsics..
Thu, Jan 21, 5:21 PM · Restricted Project
craig.topper updated the diff for D94286: [RISCV] Add a VL output to vleff intrinsics..

Rebase after the argument register change

Thu, Jan 21, 4:57 PM · Restricted Project
craig.topper updated the diff for D94653: [RISCV] Rename Zbs instructions to start with just 'b' instead of 'sb' to match 0.93 bitmanip spec..

Rebase

Thu, Jan 21, 4:11 PM · Restricted Project
craig.topper updated the diff for D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec..

Rebase

Thu, Jan 21, 4:11 PM · Restricted Project
craig.topper added inline comments to D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).
Thu, Jan 21, 3:36 PM · Restricted Project
craig.topper added a comment to D95148: [RISCV] Spilling for RISC-V V extension. (2nd version).

Is this dependent on the frame lowering patch to emit the csrr vlenb?

Thu, Jan 21, 3:06 PM · Restricted Project
craig.topper added a comment to D95148: [RISCV] Spilling for RISC-V V extension. (2nd version).

Is this patch dependent on https://reviews.llvm.org/D93614?

Thu, Jan 21, 2:52 PM · Restricted Project
craig.topper added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Thu, Jan 21, 2:15 PM · Restricted Project, Restricted Project
craig.topper added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Thu, Jan 21, 2:14 PM · Restricted Project, Restricted Project
craig.topper accepted D95134: [RISCV] Use v8-v23 as argument registers to conform to the proposal..

LGTM

Thu, Jan 21, 1:54 PM · Restricted Project
craig.topper requested review of D95169: [RISCV] Add more cmov isel patterns to handle seteq/ne with a small non-zero immediate..
Thu, Jan 21, 1:44 PM · Restricted Project
craig.topper committed rG4ab0f51a7518: Recommit "[RISCV] Legalize select when Zbt extension available" (authored by mundaym).
Recommit "[RISCV] Legalize select when Zbt extension available"
Thu, Jan 21, 12:11 PM
craig.topper closed D93767: [RISCV] Legalize select when Zbt extension available.
Thu, Jan 21, 12:11 PM · Restricted Project
craig.topper added inline comments to D94501: [SelectionDAG] Support scalable-vector splats in more cases.
Thu, Jan 21, 11:31 AM · Restricted Project
craig.topper added inline comments to D94615: [RISCV][WIP] Add RVV insertelt/extractelt scalable-vector patterns.
Thu, Jan 21, 11:17 AM · Restricted Project
craig.topper accepted D94583: [RISCV] Update V extension to v1.0-draft 08a0b464..

LGTM

Thu, Jan 21, 10:35 AM · Restricted Project
craig.topper accepted D95028: [RISCV] Add intrinsics for vector unordered indexed loads in RVV 1.0.

LGTM

Thu, Jan 21, 10:33 AM · Restricted Project
craig.topper accepted D94940: [RISCV] Implement vsoxseg/vsuxseg intrinsics..

LGTM

Thu, Jan 21, 10:29 AM · Restricted Project
craig.topper added inline comments to D94903: [RISCV] Implement vloxseg/vluxseg intrinsics..
Thu, Jan 21, 10:26 AM · Restricted Project
craig.topper added inline comments to D94999: [RISCV] Add xperm.* instructions to Zbp extension..
Thu, Jan 21, 10:24 AM · Restricted Project
craig.topper added inline comments to D95150: [RISCV] Add B extension tests to make sure RV64 only instructions aren't accepted in RV32..
Thu, Jan 21, 10:21 AM · Restricted Project
craig.topper added a comment to D93767: [RISCV] Legalize select when Zbt extension available.

@mundaym do you have commit access yet? I think Sam had been committing your previous patches?

Thu, Jan 21, 10:17 AM · Restricted Project
craig.topper requested review of D95150: [RISCV] Add B extension tests to make sure RV64 only instructions aren't accepted in RV32..
Thu, Jan 21, 10:16 AM · Restricted Project
craig.topper updated the diff for D94999: [RISCV] Add xperm.* instructions to Zbp extension..

Rebase

Thu, Jan 21, 9:28 AM · Restricted Project
craig.topper added a comment to D95146: [RISCV] Make v extension imply zvamo, zvlsseg.

Doesn't this mean that if you only enable zvlsseg, you'll be able to use the instruction in that extension but not the vsetvli instruction that you need to program the VL register?

Thu, Jan 21, 9:25 AM · Restricted Project
craig.topper updated the diff for D94742: [RISCV] Move pack instructions to Zbp extension only..

Move pack tests from rv32zbbp-invalid.s to rv32zbp-invalid.s

Thu, Jan 21, 9:17 AM · Restricted Project
craig.topper updated the diff for D95002: [RISCV] Update B extension version to 0.93..

Remove conflict marker that got left behind

Thu, Jan 21, 8:22 AM · Restricted Project, Restricted Project
craig.topper updated the diff for D95002: [RISCV] Update B extension version to 0.93..

Rebase after clang-format in Zba patch

Thu, Jan 21, 8:16 AM · Restricted Project, Restricted Project
craig.topper updated the diff for D94617: [RISCV] Add Zba feature and move add.uw and slli.uw to it..

clang-format

Thu, Jan 21, 8:13 AM · Restricted Project, Restricted Project
craig.topper updated the diff for D95002: [RISCV] Update B extension version to 0.93..

Update header on RISCVInstrInfoB.td

Thu, Jan 21, 8:04 AM · Restricted Project, Restricted Project

Yesterday

craig.topper added a comment to D94903: [RISCV] Implement vloxseg/vluxseg intrinsics..

Does this need earlyclobber? The spec says "For vector indexed segment loads, the destination vector register groups cannot overlap the source vector register group (specified by vs2), else an illegal instruction exception is raised."

Wed, Jan 20, 9:49 PM · Restricted Project
craig.topper added inline comments to D94940: [RISCV] Implement vsoxseg/vsuxseg intrinsics..
Wed, Jan 20, 9:47 PM · Restricted Project
craig.topper accepted D95113: [RISCV] Add intrinsics for RVV v1.0 VFRSQRTE7 & VFRECE7.

LGTM

Wed, Jan 20, 8:09 PM · Restricted Project
craig.topper added inline comments to D94903: [RISCV] Implement vloxseg/vluxseg intrinsics..
Wed, Jan 20, 8:00 PM · Restricted Project
craig.topper updated the diff for D94286: [RISCV] Add a VL output to vleff intrinsics..

-Add tests for unused results on the masked intrinsic
-Make the masked intrinsic have "side effects"
-Use the default read/write memory property instead of IntrReadMem+IntrHasSideEffects which doesn't work correctly without tablegen changes.

Wed, Jan 20, 7:14 PM · Restricted Project
craig.topper committed rG6cab3f88ee4d: [RISCV] Use update_llc_test_checks.py to regenerate check lines in vleff-rv32. (authored by craig.topper).
[RISCV] Use update_llc_test_checks.py to regenerate check lines in vleff-rv32.
Wed, Jan 20, 6:54 PM
craig.topper added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Wed, Jan 20, 6:43 PM · Restricted Project, Restricted Project
craig.topper requested review of D95106: [RISCV] Add isel patterns for SH*ADD(.UW).
Wed, Jan 20, 4:59 PM · Restricted Project
craig.topper updated the diff for D94999: [RISCV] Add xperm.* instructions to Zbp extension..

Rebase

Wed, Jan 20, 3:55 PM · Restricted Project
craig.topper updated the diff for D94944: [RISCV] Add support for rev8 and orc.b to Zbb..

Rebase

Wed, Jan 20, 3:53 PM · Restricted Project
craig.topper updated the diff for D94818: [RISCV] Add zext.h instruction to Zbb..

Rebase

Wed, Jan 20, 3:52 PM · Restricted Project
craig.topper updated the diff for D94742: [RISCV] Move pack instructions to Zbp extension only..

Rebase

Wed, Jan 20, 3:50 PM · Restricted Project
craig.topper updated the diff for D94736: [RISCV] Change zext.w to be an alias of add.uw rd, rs1, x0 instead of pack..

Rebase

Wed, Jan 20, 3:49 PM · Restricted Project
craig.topper updated the diff for D95090: [RISCV] Modify add.uw patterns to put the masked operand in rs1 to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:48 PM · Restricted Project
craig.topper updated the diff for D94653: [RISCV] Rename Zbs instructions to start with just 'b' instead of 'sb' to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:46 PM · Restricted Project
craig.topper updated the diff for D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:44 PM · Restricted Project
craig.topper requested changes to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

Revoking my approval

Wed, Jan 20, 3:42 PM · Restricted Project
craig.topper updated the diff for D94637: [RISCV] Add SH*ADD(.UW) instructions to Zba extension based on 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:41 PM · Restricted Project
craig.topper updated the diff for D94617: [RISCV] Add Zba feature and move add.uw and slli.uw to it..

Rebase

Wed, Jan 20, 3:35 PM · Restricted Project, Restricted Project
craig.topper added inline comments to D94286: [RISCV] Add a VL output to vleff intrinsics..
Wed, Jan 20, 3:35 PM · Restricted Project
craig.topper updated the diff for D94582: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93 bitmanip spec..

Remove Zba changes that accidentally got merged in the previous rebase

Wed, Jan 20, 3:32 PM · Restricted Project, Restricted Project
craig.topper updated the diff for D94637: [RISCV] Add SH*ADD(.UW) instructions to Zba extension based on 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:18 PM · Restricted Project
craig.topper updated the diff for D94582: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:16 PM · Restricted Project, Restricted Project
craig.topper updated the diff for D94582: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:13 PM · Restricted Project, Restricted Project
craig.topper updated the diff for D94580: [RISCV] Swap encodings of max and minu to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:09 PM · Restricted Project
craig.topper updated the diff for D94577: [RISCV] Remove addiwu, addwu, subwu, subuw, clmulw, clmulrw, clmulhw to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:07 PM · Restricted Project
craig.topper updated the diff for D94568: [RISCV] Rename pcnt->cpop to match 0.93 bitmanip spec..

Rebase

Wed, Jan 20, 3:05 PM · Restricted Project
craig.topper committed rGe996f1d4194b: [RISCV] Add another isel pattern for slliu.w. (authored by craig.topper).
[RISCV] Add another isel pattern for slliu.w.
Wed, Jan 20, 2:56 PM
craig.topper committed rG0f8386c4f6aa: [RISCV] Add addu.w and slliu.w test that uses getelementptr with zero extended… (authored by craig.topper).
[RISCV] Add addu.w and slliu.w test that uses getelementptr with zero extended…
Wed, Jan 20, 2:56 PM
craig.topper requested review of D95090: [RISCV] Modify add.uw patterns to put the masked operand in rs1 to match 0.93 bitmanip spec..
Wed, Jan 20, 2:05 PM · Restricted Project
craig.topper updated the diff for D94736: [RISCV] Change zext.w to be an alias of add.uw rd, rs1, x0 instead of pack..

Rebase

Wed, Jan 20, 1:18 PM · Restricted Project
craig.topper updated the summary of D94286: [RISCV] Add a VL output to vleff intrinsics..
Wed, Jan 20, 12:51 PM · Restricted Project
craig.topper updated the diff for D94286: [RISCV] Add a VL output to vleff intrinsics..

Remove side effects from READ_VL portion. Allowing it to be deleted.

Wed, Jan 20, 12:49 PM · Restricted Project
craig.topper added inline comments to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.
Wed, Jan 20, 12:03 PM · Restricted Project
craig.topper added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

TBH, I feel "X is readonly and has side effects" sends the wrong message to begin with. It is a contradiction (in the IR world) as basically shown by the need for this patch. Given that there are no examples in-tree I don't understand why one would mark a side-effect intrinsic as readonly (or similar). Long story short, I would argue this should be a loud error, not silently ignored.

Wed, Jan 20, 11:55 AM · Restricted Project
craig.topper accepted D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

Having just tripped over this bug again. I think we should fix this

Wed, Jan 20, 11:27 AM · Restricted Project
craig.topper accepted D95014: [RISCV] Add intrinsics for vrgatherei16 instruction.

LGTM

Wed, Jan 20, 10:45 AM · Restricted Project
craig.topper committed rG9d792fef5778: [RISCV] Remove unnecessary APInt copy. NFC (authored by craig.topper).
[RISCV] Remove unnecessary APInt copy. NFC
Wed, Jan 20, 10:34 AM
craig.topper accepted D94863: [RISCV] Implement vssseg intrinsics..

LGTM

Wed, Jan 20, 10:30 AM · Restricted Project
craig.topper accepted D94763: [RISCV] Implement vlsseg intrinsics..

LGTM

Wed, Jan 20, 10:27 AM · Restricted Project
craig.topper accepted D94688: [RISCV] Implement vsseg intrinsics..

LGTM

Wed, Jan 20, 10:22 AM · Restricted Project
craig.topper committed rGb11b6ab3e094: [RISCV] Add way to mark CompressPats that should only be used for compressing. (authored by craig.topper).
[RISCV] Add way to mark CompressPats that should only be used for compressing.
Wed, Jan 20, 9:43 AM
craig.topper closed D94894: [RISCV] Add way to mark CompressPats that should only be used for compressing..
Wed, Jan 20, 9:43 AM · Restricted Project
craig.topper added a comment to D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec..

Changes look good but, like you, I can't see that these instructions are in that section (or any section for that matter). We can keep an eye on the issue you filed and approve once it's confirmed?

Wed, Jan 20, 9:11 AM · Restricted Project
craig.topper added a comment to D94653: [RISCV] Rename Zbs instructions to start with just 'b' instead of 'sb' to match 0.93 bitmanip spec..

What are the implications of having the renamed Zbe instructions in what we'll advertise as 0.93?

Wed, Jan 20, 9:08 AM · Restricted Project
craig.topper added a comment to D94637: [RISCV] Add SH*ADD(.UW) instructions to Zba extension based on 0.93 bitmanip spec..

LGTM. I take it the patterns can come later?

Wed, Jan 20, 9:07 AM · Restricted Project

Tue, Jan 19

craig.topper accepted D94229: [RISCV] Implement vlseg intrinsics..

LGTM to me with that one comment.

Tue, Jan 19, 8:37 PM · Restricted Project
craig.topper added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Tue, Jan 19, 8:33 PM · Restricted Project, Restricted Project
craig.topper added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Tue, Jan 19, 8:19 PM · Restricted Project, Restricted Project
craig.topper added a comment to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..

This is a very incomplete review, but I need to go eat dinner

Tue, Jan 19, 7:26 PM · Restricted Project, Restricted Project
craig.topper accepted D94951: [RISCV] refactor VPatBinary (NFC).

LGTM

Tue, Jan 19, 6:57 PM · Restricted Project
craig.topper added a comment to D94951: [RISCV] refactor VPatBinary (NFC).

I'm not sure I understand what's special about vrgathere16 that needs this refactor. Can you provide an explanation?

VPatBinary helps encode LMUL in the instruction name,
but for vrgatherei16 it needs to encode both LMUL & EMUL in the instruction name,
like PseudoVRGATHEREI16_VV_M1_M1, and PseudoVRGATHEREI16_VV_M1_M2.
Here is my patch for vrgatherei16 based on the NFC patch https://reviews.llvm.org/D95014

Tue, Jan 19, 6:57 PM · Restricted Project
craig.topper committed rGe75a4b6ea9e9: [RISCV] Remove NotHasStdExtZbb predicate from zext.h/sext.b/sext.h InstAliases. (authored by craig.topper).
[RISCV] Remove NotHasStdExtZbb predicate from zext.h/sext.b/sext.h InstAliases.
Tue, Jan 19, 2:37 PM
craig.topper requested review of D95002: [RISCV] Update B extension version to 0.93..
Tue, Jan 19, 2:16 PM · Restricted Project, Restricted Project
craig.topper requested review of D94999: [RISCV] Add xperm.* instructions to Zbp extension..
Tue, Jan 19, 1:27 PM · Restricted Project
craig.topper updated the diff for D94944: [RISCV] Add support for rev8 and orc.b to Zbb..

Rebase

Tue, Jan 19, 12:33 PM · Restricted Project
craig.topper updated the diff for D94818: [RISCV] Add zext.h instruction to Zbb..

Fix comment

Tue, Jan 19, 12:32 PM · Restricted Project
craig.topper added a reviewer for D94944: [RISCV] Add support for rev8 and orc.b to Zbb.: kito-cheng.
Tue, Jan 19, 12:17 PM · Restricted Project
craig.topper updated the summary of D94818: [RISCV] Add zext.h instruction to Zbb..
Tue, Jan 19, 12:17 PM · Restricted Project
craig.topper updated the diff for D94818: [RISCV] Add zext.h instruction to Zbb..

Modify to use the same approach as rev8 and orc.b patch

Tue, Jan 19, 12:13 PM · Restricted Project
craig.topper committed rGce8b3937ddad: [RISCV] Add DAG combine to turn (setcc X, 1, setne) -> (setcc X, 0, seteq) if… (authored by craig.topper).
[RISCV] Add DAG combine to turn (setcc X, 1, setne) -> (setcc X, 0, seteq) if…
Tue, Jan 19, 11:23 AM
craig.topper closed D94730: [RISCV] Add DAG combine to turn (setcc X, 1, setne) -> (setcc X, 0, seteq) if we can prove X is 0/1..
Tue, Jan 19, 11:22 AM · Restricted Project
craig.topper updated the diff for D94894: [RISCV] Add way to mark CompressPats that should only be used for compressing..

Consistently use isCompressOnly = true

Tue, Jan 19, 10:58 AM · Restricted Project
craig.topper added inline comments to D94763: [RISCV] Implement vlsseg intrinsics..
Tue, Jan 19, 10:12 AM · Restricted Project
craig.topper added a comment to D94951: [RISCV] refactor VPatBinary (NFC).

I'm not sure I understand what's special about vrgathere16 that needs this refactor. Can you provide an explanation?

Tue, Jan 19, 10:08 AM · Restricted Project