@MaskRay and @nickdesaulniers Can you please work together to reach a consensus on what is the best path forward? I am ok either way, just need to know what the next steps are. :) Thank you.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 6 2022
Oct 3 2022
Sep 30 2022
In D134454#3826179, @MaskRay wrote:In D134454#3826143, @10ne1 wrote:In D134454#3824571, @MaskRay wrote:I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting.
This adds new functionality for non-MIPS and we need some fake file hierarchies (like those used in linux-cross.cpp).
I'll add the test, though, and submit this for you.Request changes for now.
Ok. Thanks, please ping if you need any action on my side.
My latest thought is that this patch is going toward a wrong direction: https://reviews.llvm.org/D134454#3824630
Sep 29 2022
In D134454#3824571, @MaskRay wrote:I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting.
This adds new functionality for non-MIPS and we need some fake file hierarchies (like those used in linux-cross.cpp).
I'll add the test, though, and submit this for you.Request changes for now.
In D134454#3824391, @nickdesaulniers wrote:Looks great! Nice job @10ne1 . Need me to commit this for you?
Updated based on feedback from Nick.
Sep 28 2022
FYI: @MaskRay I think you will be very happy that after the simplifications Nick suggested the Distro::* additions are not necessary anymore.
Sep 27 2022
Fixed some clang-format problems.
@nickdesaulniers @MaskRay I've updated the diff & summary based on the review comments which I've marked as done. Please tell me what you think. Thank you!
In D134454#3816460, @MaskRay wrote:I am nervous as well as Arch Linux has many derivatives. They likely don't use ID=arch in /etc/os-release. The patch won't work for them.
In general, I don't think our current approach adding new Distro::* flavors scale or really meet the needs of numerous less-popular distributions.The last few comments of https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606 discuss a generic mechanism solving the distribution difference problem with configuration files.
Also, the new driver option --gcc-install-dir (https://discourse.llvm.org/t/add-gcc-install-dir-deprecate-gcc-toolchain-and-remove-gcc-install-prefix/65091 ; milestone: 16.0.0) can be useful for some tasks.
Sep 26 2022
In D134454#3812153, @nickdesaulniers wrote:Is it worth contacting the package maintainer for LLVM+clang for Arch-Linux in regards to this patch?
Sep 23 2022
Regenerated diff with git diff HEAD~1 -U999999