Page MenuHomePhabricator
Feed Advanced Search

Today

JDevlieghere committed rG056c31976948: [LLDB] Only set FRAMEWORK when we're actually building a framework. (authored by JDevlieghere).
[LLDB] Only set FRAMEWORK when we're actually building a framework.
Tue, Nov 12, 3:48 PM
JDevlieghere accepted D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..

This is very nice, thanks!

Any chance we could test this with a pexpect test?

Absolutely. It was waaay more complicated than I expected due to funny escaping somewhere between pexpect and lldb, but testing an actual command seems to work. Hopefully I've captured that in the test doc comment.

Tue, Nov 12, 3:47 PM · Restricted Project
JDevlieghere committed rG34ca6e1fbef5: [LLDB] Remove debug message in AddLLDB.cmake (authored by JDevlieghere).
[LLDB] Remove debug message in AddLLDB.cmake
Tue, Nov 12, 3:38 PM
JDevlieghere committed rGa247bd1f274e: [LLDB] Fix/silence CMake developer warning for LLDB framework. (authored by JDevlieghere).
[LLDB] Fix/silence CMake developer warning for LLDB framework.
Tue, Nov 12, 2:22 PM
JDevlieghere committed rGfbb228c7d222: [LLDB] Always remove debugserver from LLVM_DISTRIBUTION_COMPONENTS (authored by JDevlieghere).
[LLDB] Always remove debugserver from LLVM_DISTRIBUTION_COMPONENTS
Tue, Nov 12, 1:06 PM
JDevlieghere added a comment to D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..

This is very nice, thanks!

Tue, Nov 12, 12:29 PM · Restricted Project
JDevlieghere accepted D70106: Performance: Add a set of visited SymbolFiles to other the FindFiles variant..
Tue, Nov 12, 9:23 AM · Restricted Project
JDevlieghere accepted D70115: DWARFDebugLoclists: stricter base address handling.

LGTM!

Tue, Nov 12, 9:23 AM · Restricted Project

Yesterday

JDevlieghere committed rG0b8dfb5762fd: [lldb] Re-enable VSCode tests (authored by JDevlieghere).
[lldb] Re-enable VSCode tests
Mon, Nov 11, 4:00 PM
JDevlieghere committed rG0cf86da1741f: [Reproducer] Quit the debugger after generating a reproducer (authored by JDevlieghere).
[Reproducer] Quit the debugger after generating a reproducer
Mon, Nov 11, 2:38 PM
JDevlieghere accepted D70084: DWARFDebugLoclists: Add an api to get the location lists of a DWARF unit.

LGTM

Mon, Nov 11, 11:17 AM · Restricted Project
JDevlieghere committed rG8a44d4850d26: [debuginfo] Update test to account for missing __debug_macinfo (authored by JDevlieghere).
[debuginfo] Update test to account for missing __debug_macinfo
Mon, Nov 11, 10:41 AM

Fri, Nov 8

JDevlieghere committed rG441a78533e61: Revert "Add a testcase for .dSYM path remapping dictionaries." (authored by JDevlieghere).
Revert "Add a testcase for .dSYM path remapping dictionaries."
Fri, Nov 8, 6:22 PM
JDevlieghere added a reverting change for rG2bbc4fdd8fa0: Add a testcase for .dSYM path remapping dictionaries.: rG441a78533e61: Revert "Add a testcase for .dSYM path remapping dictionaries.".
Fri, Nov 8, 6:21 PM
JDevlieghere accepted D70037: Fix a regression in macOS-style path remapping..

Sorry for breaking this functionality & thank you for fixing it!

Fri, Nov 8, 6:03 PM · Restricted Project
JDevlieghere committed rG4d0e07f7862b: [lldb] Make Asan/SIP workaround work for Python 3 (authored by JDevlieghere).
[lldb] Make Asan/SIP workaround work for Python 3
Fri, Nov 8, 9:21 AM
JDevlieghere committed rG6b44a41fefc7: [lldb] Prevent Asan/SIP workaround from affecting Python in /usr/local/bin (authored by JDevlieghere).
[lldb] Prevent Asan/SIP workaround from affecting Python in /usr/local/bin
Fri, Nov 8, 9:12 AM

Thu, Nov 7

JDevlieghere added a comment to D69684: [debuginfo-tests] Don't look for Python 3 if we already have it.
In D69684#1737796, @rnk wrote:

Would it be OK if we removed all the logic to redo the python search here, and replace it with a simple version check? So far as I know, most of the rest of LLVM is Python 3 ready, so even if you use python 2 on PATH, there's no reason not to tell cmake to use Python 3.

Thu, Nov 7, 2:54 PM · Restricted Project
JDevlieghere committed rGc62a9f180c26: [lldb] Improve assert in GDBRemoteCommunicationReplayServer (authored by JDevlieghere).
[lldb] Improve assert in GDBRemoteCommunicationReplayServer
Thu, Nov 7, 12:50 PM

Wed, Nov 6

JDevlieghere committed rG703c97be2492: [lldb] Mark ASan & TSan as test dependencies (authored by JDevlieghere).
[lldb] Mark ASan & TSan as test dependencies
Wed, Nov 6, 3:26 PM
JDevlieghere committed rGcfca0056f054: [lldb] Remove dead code from STLUtils.h (authored by JDevlieghere).
[lldb] Remove dead code from STLUtils.h
Wed, Nov 6, 3:15 PM

Tue, Nov 5

JDevlieghere committed rG2abcf44f4c91: [Reproducer] Add test case for expression evaluation (authored by JDevlieghere).
[Reproducer] Add test case for expression evaluation
Tue, Nov 5, 12:38 PM
JDevlieghere committed rGa9970036d43b: [lldb] Fix Python 3 incompatibility in API/lit.cfg.py (authored by JDevlieghere).
[lldb] Fix Python 3 incompatibility in API/lit.cfg.py
Tue, Nov 5, 10:20 AM
JDevlieghere accepted D69847: DWARFDebugLoc(v4): Add an incremental parsing function.
Tue, Nov 5, 9:42 AM · Restricted Project
JDevlieghere accepted D69672: DWARFDebugLoclists: Move to a incremental parsing model.

Personally I'm not a big fan of callbacks, but it seems like this was well thought through. My original suggestion of doing a two-step parse also wouldn't allow you to abort parsing, which is possible here by returning false form the callback.

Tue, Nov 5, 9:42 AM · Restricted Project

Mon, Nov 4

JDevlieghere added inline comments to D69742: [LLDB][Python] remove ArgInfo::count.
Mon, Nov 4, 10:58 AM · Restricted Project
JDevlieghere accepted D69742: [LLDB][Python] remove ArgInfo::count.

LGTM modulo inline comment.

Mon, Nov 4, 9:31 AM · Restricted Project
JDevlieghere added a comment to D69793: Bundle libedit-compatible readline replacement.

+1 on everything Pavel said :-)

Mon, Nov 4, 9:22 AM · Restricted Project

Fri, Nov 1

JDevlieghere accepted D69142: [dsymutil] Add support for linking remarks.
Fri, Nov 1, 11:18 AM · Restricted Project
JDevlieghere committed rG96bbf478b671: [dsymutil] Add DW_TAG_common_block to dieNeedsChildrenToBeMeaningful (authored by JDevlieghere).
[dsymutil] Add DW_TAG_common_block to dieNeedsChildrenToBeMeaningful
Fri, Nov 1, 10:58 AM
JDevlieghere added a reverting change for rZORG42519d0c1e21: Revert "Add six to the list of python dependencies.": rZORG8d729f6fd0a6: Revert "Revert "Add six to the list of python dependencies."".
Fri, Nov 1, 9:49 AM
JDevlieghere committed rZORG8d729f6fd0a6: Revert "Revert "Add six to the list of python dependencies."" (authored by JDevlieghere).
Revert "Revert "Add six to the list of python dependencies.""
Fri, Nov 1, 9:49 AM
JDevlieghere accepted D69713: [lldb] Also disable de-registration of EHFrames in IRExecutionUnit.
Fri, Nov 1, 9:49 AM · Restricted Project, Restricted Project
JDevlieghere accepted D69717: [lldb] Add trailing dots to comments in Value.cpp.
Fri, Nov 1, 9:49 AM · Restricted Project, Restricted Project
JDevlieghere committed rZORG172fefe95bc2: [Python] Add more decode('utf-8') to check_output. (authored by JDevlieghere).
[Python] Add more decode('utf-8') to check_output.
Fri, Nov 1, 9:40 AM
JDevlieghere committed rZORGc5faf0188998: [Python] Pass the executable not all the remaining args (authored by JDevlieghere).
[Python] Pass the executable not all the remaining args
Fri, Nov 1, 9:39 AM
JDevlieghere committed rZORG00c16c2736e2: [Python] Decode check_output result which is not a string in Python 3. (authored by JDevlieghere).
[Python] Decode check_output result which is not a string in Python 3.
Fri, Nov 1, 9:32 AM
JDevlieghere committed rZORG2f1f701bf981: [Python] Make dep.py compatible with Python 2 & 3. (authored by JDevlieghere).
[Python] Make dep.py compatible with Python 2 & 3.
Fri, Nov 1, 9:22 AM
JDevlieghere accepted D69705: [lldb][NFC] Make test/python_api/module_section test smaller.
Fri, Nov 1, 9:13 AM · Restricted Project

Thu, Oct 31

JDevlieghere committed rZORG904e29fd5516: [Jenkins] Support both Python 2 & 3 in monorepo_build.py (authored by JDevlieghere).
[Jenkins] Support both Python 2 & 3 in monorepo_build.py
Thu, Oct 31, 10:01 AM
JDevlieghere committed rZORG622ade6fbac6: [pipeline] Remove python 2 workaround (authored by JDevlieghere).
[pipeline] Remove python 2 workaround
Thu, Oct 31, 9:42 AM
JDevlieghere added inline comments to D69142: [dsymutil] Add support for linking remarks.
Thu, Oct 31, 9:25 AM · Restricted Project
JDevlieghere resigned from D68886: Remove unnecessary codes in llvm-dwarfdump.
Thu, Oct 31, 9:14 AM · debug-info, Restricted Project
JDevlieghere accepted D69141: [Remarks] Add support for linking remarks.

Few small comments inline but otherwise this LGTM

Thu, Oct 31, 9:14 AM · Restricted Project
JDevlieghere added inline comments to D68270: DWARFDebugLoc: Add a function to get the address range of an entry.
Thu, Oct 31, 9:05 AM · Restricted Project
JDevlieghere accepted D68271: DWARFDebugLoclists: Make it possible to read relocated addresses.

LGTM

Thu, Oct 31, 8:37 AM · Restricted Project

Wed, Oct 30

JDevlieghere accepted D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type.
Wed, Oct 30, 4:05 PM · Restricted Project
JDevlieghere added a comment to D68868: Fix build under musl.

Let me know if you want me to commit this for you.

Wed, Oct 30, 12:38 PM · Restricted Project
JDevlieghere accepted D69619: [lldb/lit] Introduce %clang_host substitutions.

All my thoughts have already been brought up and discussed. :-)

Wed, Oct 30, 12:29 PM · Restricted Project

Tue, Oct 29

JDevlieghere committed rG44bac3ed5291: [lldbsuite] Remove unused test_event files (authored by JDevlieghere).
[lldbsuite] Remove unused test_event files
Tue, Oct 29, 5:46 PM
JDevlieghere committed rG9f989559bad7: [lldbsuite] Remove the DumpFormatter (authored by JDevlieghere).
[lldbsuite] Remove the DumpFormatter
Tue, Oct 29, 5:46 PM
JDevlieghere committed rG8a82000e486a: [lldbsuite] Remove pre_kill_hook package (authored by JDevlieghere).
[lldbsuite] Remove pre_kill_hook package
Tue, Oct 29, 5:46 PM
JDevlieghere committed rG5cc2e0651fed: [lldbsuite] Remove unused support files (authored by JDevlieghere).
[lldbsuite] Remove unused support files
Tue, Oct 29, 5:46 PM
JDevlieghere committed rG39e2a7e2c365: Revert "Revert "[DebugInfo] Normalize common kinds of DWARF sub-expressions."" (authored by JDevlieghere).
Revert "Revert "[DebugInfo] Normalize common kinds of DWARF sub-expressions.""
Tue, Oct 29, 5:12 PM
JDevlieghere committed rG178f4caddbb2: Revert "[DebugInfo] Normalize common kinds of DWARF sub-expressions." (authored by JDevlieghere).
Revert "[DebugInfo] Normalize common kinds of DWARF sub-expressions."
Tue, Oct 29, 5:05 PM
JDevlieghere committed rG2c8cb8fead42: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by JDevlieghere).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Tue, Oct 29, 3:59 PM
JDevlieghere committed rGb62a8eca9d65: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by JDevlieghere).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Tue, Oct 29, 3:58 PM

Mon, Oct 28

JDevlieghere added a comment to D69535: build: improve python check for Windows.

I proposed this in https://reviews.llvm.org/D64881 and the consensus was that we didn't want to do this.

Mon, Oct 28, 3:43 PM · Restricted Project
JDevlieghere committed rG5ae881f96f99: [Docs] Repurpose 'sources' page as 'contributing'. (authored by JDevlieghere).
[Docs] Repurpose 'sources' page as 'contributing'.
Mon, Oct 28, 3:29 PM
JDevlieghere committed rGf8a92af893ee: [LLDB] Remove incorrect dotest.py invocation (authored by JDevlieghere).
[LLDB] Remove incorrect dotest.py invocation
Mon, Oct 28, 1:24 PM
JDevlieghere committed rGda2a4c234dcd: [Docs] Update source code link to Github (authored by JDevlieghere).
[Docs] Update source code link to Github
Mon, Oct 28, 11:15 AM
JDevlieghere committed rG6336317e0a37: [Docs] Disable Python docs when LLDB_DISABLE_PYTHON is set (authored by JDevlieghere).
[Docs] Disable Python docs when LLDB_DISABLE_PYTHON is set
Mon, Oct 28, 9:55 AM

Fri, Oct 25

JDevlieghere committed rG10b5cd8ed527: [LLDB] Fix inline variable only used in assertion. (NFC) (authored by JDevlieghere).
[LLDB] Fix inline variable only used in assertion. (NFC)
Fri, Oct 25, 3:52 PM
JDevlieghere closed D69451: Inline variable only used in assertion.
Fri, Oct 25, 3:52 PM · Restricted Project
JDevlieghere added a comment to D69451: Inline variable only used in assertion.

Thanks! Please let me know if you need me to commit this for you.

Fri, Oct 25, 3:43 PM · Restricted Project
JDevlieghere accepted D69451: Inline variable only used in assertion.

PS: In the future please uploaded full-context diffs.

Fri, Oct 25, 3:35 PM · Restricted Project
JDevlieghere accepted D69003: [dsymutil] Explicitly link against libatomic when necessary.
Fri, Oct 25, 2:38 PM · Restricted Project
JDevlieghere committed rG5934cd11ea3e: [TableGen] Add asserts to make sure default values match property type (authored by JDevlieghere).
[TableGen] Add asserts to make sure default values match property type
Fri, Oct 25, 10:25 AM
JDevlieghere removed a reviewer for D69286: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/warnings. I Also ran the test suite it using `lit` and passed all the unit tests.: JDevlieghere.
Fri, Oct 25, 9:29 AM · Restricted Project

Thu, Oct 24

JDevlieghere committed rGfd025c094bef: [CMake] Move test dependency tracking into test/CMakeLists.txt (authored by JDevlieghere).
[CMake] Move test dependency tracking into test/CMakeLists.txt
Thu, Oct 24, 2:50 PM
JDevlieghere committed rG33fca97880d3: [CMake] Move LLDB_TEST_BUILD_DIRECTORY into test/CMakeLists.txt (authored by JDevlieghere).
[CMake] Move LLDB_TEST_BUILD_DIRECTORY into test/CMakeLists.txt
Thu, Oct 24, 2:50 PM
JDevlieghere committed rG220cce1e7274: [CMake] Don't set LLDB_TEST_* in the top-level CMakeLists (authored by JDevlieghere).
[CMake] Don't set LLDB_TEST_* in the top-level CMakeLists
Thu, Oct 24, 2:50 PM
JDevlieghere committed rGd52b36e354e9: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER (authored by JDevlieghere).
[CMake] Remove unused variable LLDB_TEST_CXX_COMPILER
Thu, Oct 24, 2:50 PM
JDevlieghere closed D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER.
Thu, Oct 24, 2:50 PM · Restricted Project
JDevlieghere added a comment to D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER.

I thought this option was so that you could specify which compilers to use to build from a cache or command line? I don't think you just want to set LLDB_TEST_COMPILER to clang since clang++ is what is used to compile C++ code. Maybe I'm mis-remembering or mistaken here.

Thu, Oct 24, 2:38 PM · Restricted Project
JDevlieghere added a comment to D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER.

I did a bit of digging and there's more context in https://reviews.llvm.org/D39215. It sounds to me like the motivation for the two variables isn't relevant anymore, so I still think removing the CXX variant is desirable.

Thu, Oct 24, 1:25 PM · Restricted Project
JDevlieghere created D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER.
Thu, Oct 24, 1:01 PM · Restricted Project
JDevlieghere committed rG0c798aa4483e: [CMake] Split logic across test suite subdirectories (NFC) (authored by JDevlieghere).
[CMake] Split logic across test suite subdirectories (NFC)
Thu, Oct 24, 11:00 AM
JDevlieghere closed D69394: [CMake] Move specific logic into API, shell and unittest sub-directories..
Thu, Oct 24, 11:00 AM · Restricted Project
JDevlieghere created D69394: [CMake] Move specific logic into API, shell and unittest sub-directories..
Thu, Oct 24, 10:45 AM · Restricted Project

Wed, Oct 23

JDevlieghere added a comment to D69335: [Support] Replace StringRef hashing algorithm with DJB.

This change looks sensible but I'd like to verify the performance impact. Could you provide some numbers that compare performance before and after the change?

Wed, Oct 23, 7:12 PM · Restricted Project

Tue, Oct 22

JDevlieghere committed rG0bff9bd26e3d: [lldb] Adjust for the new class_rw_t layout. (authored by JDevlieghere).
[lldb] Adjust for the new class_rw_t layout.
Tue, Oct 22, 11:15 AM

Mon, Oct 21

JDevlieghere committed rG3434472ed741: XFAIL TestLocalVariables.py on Windows (authored by JDevlieghere).
XFAIL TestLocalVariables.py on Windows
Mon, Oct 21, 3:19 PM
JDevlieghere committed rL375459: XFAIL TestLocalVariables.py on Windows.
XFAIL TestLocalVariables.py on Windows
Mon, Oct 21, 3:19 PM
JDevlieghere added inline comments to D69141: [Remarks] Add support for linking remarks.
Mon, Oct 21, 1:36 PM · Restricted Project
JDevlieghere accepted D69213: Avoid appending the source directory to an absolute path.

LGTM modulo the comment.

Mon, Oct 21, 9:20 AM · Restricted Project, debug-info
JDevlieghere added inline comments to D69213: Avoid appending the source directory to an absolute path.
Mon, Oct 21, 9:20 AM · Restricted Project, debug-info

Fri, Oct 18

JDevlieghere committed rG06a2beae92f5: [Reproducer] XFAIL TestWorkingDir on Windows (authored by JDevlieghere).
[Reproducer] XFAIL TestWorkingDir on Windows
Fri, Oct 18, 3:18 PM
JDevlieghere committed rL375294: [Reproducer] XFAIL TestWorkingDir on Windows.
[Reproducer] XFAIL TestWorkingDir on Windows
Fri, Oct 18, 3:18 PM
JDevlieghere committed rG64b7d9556860: [Reproducer] Improve reproducer help (NFC) (authored by JDevlieghere).
[Reproducer] Improve reproducer help (NFC)
Fri, Oct 18, 2:50 PM
JDevlieghere committed rL375292: [Reproducer] Improve reproducer help (NFC).
[Reproducer] Improve reproducer help (NFC)
Fri, Oct 18, 2:50 PM
JDevlieghere committed rGded44e220f6c: [Reproducer] Use ::rtrim() to remove trailing control characters. (authored by JDevlieghere).
[Reproducer] Use ::rtrim() to remove trailing control characters.
Fri, Oct 18, 10:12 AM
JDevlieghere committed rL375259: [Reproducer] Use ::rtrim() to remove trailing control characters..
[Reproducer] Use ::rtrim() to remove trailing control characters.
Fri, Oct 18, 10:11 AM
JDevlieghere accepted D69148: Disable exit-on-SIGPIPE in lldb.

Thanks for fixing this, Vedant!

Fri, Oct 18, 8:38 AM · Restricted Project, Restricted Project

Thu, Oct 17

JDevlieghere committed rGa0f6c6434cc4: [test] Add a .clang-format file for the shell test. (authored by JDevlieghere).
[test] Add a .clang-format file for the shell test.
Thu, Oct 17, 2:28 PM
JDevlieghere closed D69058: [test] Add a .clang-format file for the shell test. .
Thu, Oct 17, 2:27 PM · Restricted Project
JDevlieghere committed rL375172: [test] Add a .clang-format file for the shell test..
[test] Add a .clang-format file for the shell test.
Thu, Oct 17, 2:27 PM
JDevlieghere committed rG2b7899b730b7: [Reproducer] Surface error if setting the cwd fails (authored by JDevlieghere).
[Reproducer] Surface error if setting the cwd fails
Thu, Oct 17, 11:02 AM
JDevlieghere committed rL375146: [Reproducer] Surface error if setting the cwd fails.
[Reproducer] Surface error if setting the cwd fails
Thu, Oct 17, 11:02 AM
JDevlieghere accepted D69119: Modernize the rest of the Find.* API (NFC).
Thu, Oct 17, 11:02 AM · Restricted Project