Page MenuHomePhabricator
Feed Advanced Search

Thu, Jun 1

sotoshigoto abandoned D151682: [mlir][doc] Add missing documentation for Pass and Transform docs.

I noticed that these missing docs were already fixed, so I abandon this PR.

Thu, Jun 1, 7:00 AM · Unknown Object (Project), Restricted Project
sotoshigoto added inline comments to D151675: [mlir] Fix a crash of attribute tests when given a non-integer type.
Thu, Jun 1, 6:49 AM · Unknown Object (Project), Restricted Project
sotoshigoto added a comment to D151682: [mlir][doc] Add missing documentation for Pass and Transform docs.

@ftynse Thank you for your review! I don't have a commit access, could you rand it?

Thu, Jun 1, 6:38 AM · Unknown Object (Project), Restricted Project
sotoshigoto abandoned D151063: [mlir][tensor] Fix assertion failure when operand is negative in GenerateOp canonicalization.

duplicated with https://reviews.llvm.org/D151611

Thu, Jun 1, 6:37 AM · Unknown Object (Project), Restricted Project

Mon, May 29

sotoshigoto added reviewers for D151682: [mlir][doc] Add missing documentation for Pass and Transform docs: ftynse, bondhugula.
Mon, May 29, 10:22 PM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D151682: [mlir][doc] Add missing documentation for Pass and Transform docs.
Mon, May 29, 10:21 PM · Unknown Object (Project), Restricted Project
sotoshigoto added a reviewer for D151675: [mlir] Fix a crash of attribute tests when given a non-integer type: rkayaith.
Mon, May 29, 9:03 PM · Unknown Object (Project), Restricted Project
sotoshigoto updated the summary of D151675: [mlir] Fix a crash of attribute tests when given a non-integer type.
Mon, May 29, 9:00 PM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D151675: [mlir] Fix a crash of attribute tests when given a non-integer type.
Mon, May 29, 9:00 PM · Unknown Object (Project), Restricted Project

Sun, May 28

sotoshigoto added a comment to D150182: [mlir] [NFC] Add a newline to debug message at inserting of InterfaceMap.

@rriddle I don't have a commit access, could you land it?

Sun, May 28, 8:57 PM · Unknown Object (Project), Restricted Project

Mon, May 22

sotoshigoto updated the diff for D151063: [mlir][tensor] Fix assertion failure when operand is negative in GenerateOp canonicalization.

apply clang-format

Mon, May 22, 6:37 PM · Unknown Object (Project), Restricted Project
sotoshigoto added reviewers for D151063: [mlir][tensor] Fix assertion failure when operand is negative in GenerateOp canonicalization: silvas, pifon2a, rriddle.
Mon, May 22, 12:45 AM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D151063: [mlir][tensor] Fix assertion failure when operand is negative in GenerateOp canonicalization.
Mon, May 22, 12:40 AM · Unknown Object (Project), Restricted Project

Thu, May 11

sotoshigoto added a comment to D150341: [mlir][NFC] Fix broken sidebar and improve documentation.

@ftynse Could you land this patch? I don't have a commit access.

Thu, May 11, 7:00 PM · Unknown Object (Project), Restricted Project

Wed, May 10

sotoshigoto added reviewers for D150341: [mlir][NFC] Fix broken sidebar and improve documentation: bondhugula, ftynse.
Wed, May 10, 8:09 PM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D150341: [mlir][NFC] Fix broken sidebar and improve documentation.
Wed, May 10, 8:06 PM · Unknown Object (Project), Restricted Project

May 9 2023

sotoshigoto retitled D150182: [mlir] [NFC] Add a newline to debug message at inserting of InterfaceMap from [NFC] Add a newline to debug message at inserting of InterfaceMap to [mlir] [NFC] Add a newline to debug message at inserting of InterfaceMap.
May 9 2023, 1:28 AM · Unknown Object (Project), Restricted Project
sotoshigoto added a reviewer for D150182: [mlir] [NFC] Add a newline to debug message at inserting of InterfaceMap: rriddle.
May 9 2023, 1:24 AM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D150182: [mlir] [NFC] Add a newline to debug message at inserting of InterfaceMap.
May 9 2023, 1:21 AM · Unknown Object (Project), Restricted Project

Feb 26 2023

sotoshigoto abandoned D144446: [mlir][bufferization] Modify setting illegal from dialect to a CloneOp.

Thank you for your comment! I understand that there may be cases where One-Shot Bufferize is not yet able to handle, and I appreciate the information on alternatives for the buffer deallocation pass.
Based on this, I will go ahead and close this PR.

Feb 26 2023, 11:48 PM · Restricted Project, Unknown Object (Project)

Feb 21 2023

sotoshigoto added a comment to D144446: [mlir][bufferization] Modify setting illegal from dialect to a CloneOp.

Thanks to this comment and I read a your comment on this issue. So I think that the name of this pass, convert-bufferization-to-memref, may be misleading. This pass requires that it runs after other bufferization passes, so perhaps it would be more appropriate to rename it or move it to -finalizing-bufferize.
Alternatively, I'm wondering if this conversion pass will eventually be removed, since it is recommended to use One-shot Bufferize instead of Conversion-based Bufferization. I am still trying to understand the details and context of Bufferization. If this PR is not needed, I will close it.

Feb 21 2023, 7:39 PM · Restricted Project, Unknown Object (Project)

Feb 20 2023

sotoshigoto added reviewers for D144446: [mlir][bufferization] Modify setting illegal from dialect to a CloneOp: dfki-jugr, mscuttari, springerm.
Feb 20 2023, 8:58 PM · Restricted Project, Unknown Object (Project)
sotoshigoto requested review of D144446: [mlir][bufferization] Modify setting illegal from dialect to a CloneOp.
Feb 20 2023, 8:56 PM · Restricted Project, Unknown Object (Project)

Feb 16 2023

sotoshigoto added a comment to D143874: [mlir][sparse] Add checking parent op of SortOp.

@aartbik @wrengr Could you land this patch? I don't have commit access.

Feb 16 2023, 4:56 PM · Unknown Object (Project), Restricted Project

Feb 15 2023

sotoshigoto added a comment to D142868: [mlir][NFC] Cleanup Passes documentation.

Could someone review this patch document and provide feedback?

Feb 15 2023, 4:47 PM · Unknown Object (Project), Restricted Project
sotoshigoto added reviewers for D142868: [mlir][NFC] Cleanup Passes documentation: ftynse, rriddle, jpienaar, kuhar.
Feb 15 2023, 4:44 PM · Unknown Object (Project), Restricted Project

Feb 14 2023

sotoshigoto updated the diff for D143874: [mlir][sparse] Add checking parent op of SortOp.

remove unnecessary an include

Feb 14 2023, 5:40 PM · Unknown Object (Project), Restricted Project
sotoshigoto updated the diff for D143874: [mlir][sparse] Add checking parent op of SortOp.

Move a fix point from verification of op to rewriting level

Feb 14 2023, 5:38 PM · Unknown Object (Project), Restricted Project

Feb 12 2023

sotoshigoto added reviewers for D143874: [mlir][sparse] Add checking parent op of SortOp: wrengr, bixia.
Feb 12 2023, 8:59 PM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D143874: [mlir][sparse] Add checking parent op of SortOp.
Feb 12 2023, 8:57 PM · Unknown Object (Project), Restricted Project

Feb 8 2023

sotoshigoto added a comment to D143474: [mlir][transform] Fix apply WithPDLPatternsOp with non-pattern op.

@ftynse I don't have commit access. Could you please commit to this patch?

Feb 8 2023, 5:12 PM · Unknown Object (Project), Restricted Project

Feb 7 2023

sotoshigoto updated the diff for D143474: [mlir][transform] Fix apply WithPDLPatternsOp with non-pattern op.

update

Feb 7 2023, 1:29 AM · Unknown Object (Project), Restricted Project
sotoshigoto added inline comments to D143474: [mlir][transform] Fix apply WithPDLPatternsOp with non-pattern op.
Feb 7 2023, 1:27 AM · Unknown Object (Project), Restricted Project
sotoshigoto added a reviewer for D143474: [mlir][transform] Fix apply WithPDLPatternsOp with non-pattern op: ftynse.
Feb 7 2023, 12:44 AM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D143474: [mlir][transform] Fix apply WithPDLPatternsOp with non-pattern op.
Feb 7 2023, 12:44 AM · Unknown Object (Project), Restricted Project

Feb 6 2023

sotoshigoto added reviewers for D143237: [mlir][NFC] Add omitted operations to Transform dialect's doc: bondhugula, ftynse.
Feb 6 2023, 4:52 PM · Unknown Object (Project), Restricted Project
sotoshigoto added a comment to D142868: [mlir][NFC] Cleanup Passes documentation.

@bondhugula Ping

Feb 6 2023, 4:49 PM · Unknown Object (Project), Restricted Project

Feb 2 2023

sotoshigoto requested review of D143237: [mlir][NFC] Add omitted operations to Transform dialect's doc.
Feb 2 2023, 5:32 PM · Unknown Object (Project), Restricted Project

Feb 1 2023

sotoshigoto updated the diff for D142868: [mlir][NFC] Cleanup Passes documentation.

Upload patch to fix a ci error

Feb 1 2023, 5:40 PM · Unknown Object (Project), Restricted Project

Jan 31 2023

sotoshigoto updated the diff for D142858: [mlir][NFC] Clean and Fix broken Affine documentation.

Fix two whitespace errors

Jan 31 2023, 11:41 PM · Unknown Object (Project), Restricted Project

Jan 30 2023

sotoshigoto added a comment to D142858: [mlir][NFC] Clean and Fix broken Affine documentation.

The patch has two whitespace errors. Can you please fix these? I can land it otherwise.

git diff --check HEAD~
mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:510: trailing whitespace.
+    
mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:877: trailing whitespace.
+
Jan 30 2023, 11:29 PM · Unknown Object (Project), Restricted Project
sotoshigoto updated the diff for D142868: [mlir][NFC] Cleanup Passes documentation.

Update doc based on the review comments

Jan 30 2023, 12:30 AM · Unknown Object (Project), Restricted Project

Jan 29 2023

sotoshigoto requested review of D142868: [mlir][NFC] Cleanup Passes documentation.
Jan 29 2023, 10:42 PM · Unknown Object (Project), Restricted Project
sotoshigoto requested review of D142858: [mlir][NFC] Clean and Fix broken Affine documentation.
Jan 29 2023, 5:51 PM · Unknown Object (Project), Restricted Project