Page MenuHomePhabricator
Feed Advanced Search

Wed, Sep 11

uabelho added a comment to D67417: [LICM/AST] Check if the AliasAny set is removed from the tracker..

I've no idea if the fix itself makes sense but at least it does seem to fix my reproducer for PR38513 and I didn't see any problems with the patch during the (limited) testing I've done.

Wed, Sep 11, 12:39 AM · Restricted Project

Tue, Sep 10

uabelho added a comment to D67171: LLVM_COMPILE_FLAGS also applies to C files.

Hi @uabelho – Try r371521

Tue, Sep 10, 11:25 PM · Restricted Project
uabelho added a comment to D67171: LLVM_COMPILE_FLAGS also applies to C files.

When compiling with gcc, we get warnings with this commit:

[100/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regfree.c.o
cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C
[101/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regstrlcpy.c.o
cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C
[102/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regerror.c.o
cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C
[107/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regexec.c.o
cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C
[114/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o
cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C
Tue, Sep 10, 6:15 AM · Restricted Project

Fri, Sep 6

uabelho added a comment to D67209: [MIR] MIR Namer pass.

I did a minor change to the test case in r371171 since the

;CHECK: bb

checks matched on the line

;ModuleID = '/repo/bb/

in the output instead of the wanted "bb.0:".

Fri, Sep 6, 12:02 AM · Restricted Project
uabelho committed rGdee0702b2a9d: [MIR] Change test case to read from stdin instead of file (authored by uabelho).
[MIR] Change test case to read from stdin instead of file
Fri, Sep 6, 12:00 AM
uabelho committed rL371171: [MIR] Change test case to read from stdin instead of file.
[MIR] Change test case to read from stdin instead of file
Fri, Sep 6, 12:00 AM

Wed, Sep 4

uabelho added a comment to D66803: [LV] Tail-folding with runtime memory checks.

Normally we do use basicaa, the crash was found in "fuzz" tests where we compile the code with random flags.

Wed, Sep 4, 7:00 AM · Restricted Project
uabelho added a comment to D66803: [LV] Tail-folding with runtime memory checks.

Why would it be ok to give the assert when we run

Wed, Sep 4, 5:29 AM · Restricted Project
uabelho added a comment to D66803: [LV] Tail-folding with runtime memory checks.

Hi,

I've hit the new assertion when compiling for my out of tree target when using -Osize in combination with

#pragma clang loop vectorize(enable)

on a loop.

What is supposed to prevent us from triggering the assertion in a case like that?

Wed, Sep 4, 3:49 AM · Restricted Project
uabelho added a comment to D66803: [LV] Tail-folding with runtime memory checks.

I've hit the new assertion when compiling for my out of tree target when using -Osize in combination with

Wed, Sep 4, 1:00 AM · Restricted Project

Aug 16 2019

uabelho added inline comments to D65683: MVT: Add v3i16/v3f16 vectors.
Aug 16 2019, 12:38 AM

Jul 11 2019

uabelho committed rG7618b2a5c2af: [test] Silence gcc 7.4 warning [NFC] (authored by uabelho).
[test] Silence gcc 7.4 warning [NFC]
Jul 11 2019, 12:08 AM
uabelho committed rL365738: [test] Silence gcc 7.4 warning [NFC].
[test] Silence gcc 7.4 warning [NFC]
Jul 11 2019, 12:07 AM

Jul 10 2019

uabelho committed rGc593f5e6711a: [clang-doc] Silence compiler warning with gcc 7.4 [NFC] (authored by uabelho).
[clang-doc] Silence compiler warning with gcc 7.4 [NFC]
Jul 10 2019, 11:51 PM
uabelho committed rL365736: [clang-doc] Silence compiler warning with gcc 7.4 [NFC].
[clang-doc] Silence compiler warning with gcc 7.4 [NFC]
Jul 10 2019, 11:51 PM

Jul 9 2019

uabelho committed rG77392c3f5e79: Silence gcc warning by adding parentheses to condition [NFC] (authored by uabelho).
Silence gcc warning by adding parentheses to condition [NFC]
Jul 9 2019, 11:20 PM
uabelho committed rL365597: Silence gcc warning by adding parentheses to condition [NFC].
Silence gcc warning by adding parentheses to condition [NFC]
Jul 9 2019, 11:20 PM

Jul 4 2019

uabelho committed rGc72cb1f2a215: Silence gcc warning "control reaches end of non-void function" [NFCI] (authored by uabelho).
Silence gcc warning "control reaches end of non-void function" [NFCI]
Jul 4 2019, 11:13 PM
uabelho committed rL365174: Silence gcc warning "control reaches end of non-void function" [NFCI].
Silence gcc warning "control reaches end of non-void function" [NFCI]
Jul 4 2019, 11:13 PM
uabelho committed rG67dd39f86e26: [Remarks] Silence gcc warning by catching unhandled values in switches (authored by uabelho).
[Remarks] Silence gcc warning by catching unhandled values in switches
Jul 4 2019, 2:32 AM
uabelho committed rL365118: [Remarks] Silence gcc warning by catching unhandled values in switches.
[Remarks] Silence gcc warning by catching unhandled values in switches
Jul 4 2019, 2:29 AM

Jun 27 2019

uabelho committed rG2adab5a1426e: Silence gcc warning in testcase [NFC] (authored by uabelho).
Silence gcc warning in testcase [NFC]
Jun 27 2019, 11:46 PM
uabelho committed rL364624: Silence gcc warning in testcase [NFC].
Silence gcc warning in testcase [NFC]
Jun 27 2019, 11:46 PM
uabelho committed rG79dc930c131c: [clang-tidy] Fix NDEBUG build [NFC] (authored by uabelho).
[clang-tidy] Fix NDEBUG build [NFC]
Jun 27 2019, 5:52 AM
uabelho committed rL364535: [clang-tidy] Fix NDEBUG build [NFC].
[clang-tidy] Fix NDEBUG build [NFC]
Jun 27 2019, 5:51 AM
uabelho committed rG7b81b6136869: Silence gcc warning after r364458 (authored by uabelho).
Silence gcc warning after r364458
Jun 27 2019, 1:17 AM
uabelho committed rL364507: Silence gcc warning after r364458.
Silence gcc warning after r364458
Jun 27 2019, 1:16 AM

Jun 17 2019

uabelho committed rG5136ea499484: Fix compiler warning by removing unused variable (authored by uabelho).
Fix compiler warning by removing unused variable
Jun 17 2019, 11:42 PM
uabelho committed rL363651: Fix compiler warning by removing unused variable.
Fix compiler warning by removing unused variable
Jun 17 2019, 11:38 PM

Jun 14 2019

uabelho added a comment to D62644: [EarlyCSE] Ensure equal keys have the same hash value.

It looks like this patch may have caused https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15236. It would be great if you could have a look.

Jun 14 2019, 4:15 AM · Restricted Project

Jun 12 2019

uabelho abandoned D57149: [StackProtector] Skip analysing dead users in HasAddressTaken, PR40436.

With r363169 the problem seems to be fixed, so this patch is probably not needed anymore.

Jun 12 2019, 11:04 PM
uabelho committed rG030df51e27e7: [ARM] Fix compiler warning (authored by uabelho).
[ARM] Fix compiler warning
Jun 12 2019, 7:17 AM
uabelho committed rL363166: [ARM] Fix compiler warning.
[ARM] Fix compiler warning
Jun 12 2019, 7:16 AM

Jun 10 2019

uabelho committed rGe2acbeb94cf2: [clangd] Fix gcc warning by removing extra ";" (authored by uabelho).
[clangd] Fix gcc warning by removing extra ";"
Jun 10 2019, 11:00 PM
uabelho committed rL363034: [clangd] Fix gcc warning by removing extra ";".
[clangd] Fix gcc warning by removing extra ";"
Jun 10 2019, 10:59 PM

Jun 6 2019

uabelho added inline comments to D62476: [clangd] Support offsets for parameters in signatureHelp.
Jun 6 2019, 10:16 PM · Restricted Project, Restricted Project

Jun 5 2019

uabelho added inline comments to D62476: [clangd] Support offsets for parameters in signatureHelp.
Jun 5 2019, 12:33 AM · Restricted Project, Restricted Project

Jun 3 2019

uabelho committed rGd8d3e17b8b07: Fix compilation warning about unused variable [NFC] (authored by uabelho).
Fix compilation warning about unused variable [NFC]
Jun 3 2019, 3:49 AM
uabelho committed rL362379: Fix compilation warning about unused variable [NFC].
Fix compilation warning about unused variable [NFC]
Jun 3 2019, 3:48 AM

Jun 2 2019

uabelho committed rG404a679e1d0c: [TableGen] Fix std::array initializer to avoid warnings with older tool chains. (authored by uabelho).
[TableGen] Fix std::array initializer to avoid warnings with older tool chains.
Jun 2 2019, 11:37 PM
uabelho committed rL362360: [TableGen] Fix std::array initializer to avoid warnings with older tool chains..
[TableGen] Fix std::array initializer to avoid warnings with older tool chains.
Jun 2 2019, 11:37 PM

May 20 2019

uabelho committed rG3b6b2e331fea: Fix compilation warning about unused variable [NFC] (authored by uabelho).
Fix compilation warning about unused variable [NFC]
May 20 2019, 4:37 AM
uabelho committed rC361145: Fix compilation warning about unused variable [NFC].
Fix compilation warning about unused variable [NFC]
May 20 2019, 4:36 AM
uabelho committed rL361145: Fix compilation warning about unused variable [NFC].
Fix compilation warning about unused variable [NFC]
May 20 2019, 4:36 AM

May 14 2019

uabelho added a comment to D61904: [LICM] Allow AliasSetMap to contain top-level loops..

@fhahn : I noticed that https://bugs.llvm.org/show_bug.cgi?id=31141 stopped crashing with this patch, do you think it's by accident or can that possibly be closed now?

May 14 2019, 11:43 PM · Restricted Project

May 12 2019

uabelho added a comment to D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

https://bugs.llvm.org/show_bug.cgi?id=41853

May 12 2019, 11:04 PM · Restricted Project

May 10 2019

uabelho added a comment to D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

When the assertion fails we have:

(gdb) call F.dump()
May 10 2019, 12:30 AM · Restricted Project

May 9 2019

uabelho added a comment to D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

With this patch the following starts hitting an assertion:

May 9 2019, 11:39 PM · Restricted Project
uabelho committed rGa186edbc000a: Fix gcc compilation warning in test case [NFC] (authored by uabelho).
Fix gcc compilation warning in test case [NFC]
May 9 2019, 5:12 AM
uabelho committed rG1fa5248d44ce: Fix gcc compilation warning in an assert [NFC] (authored by uabelho).
Fix gcc compilation warning in an assert [NFC]
May 9 2019, 5:12 AM
uabelho committed rL360334: Fix gcc compilation warning in test case [NFC].
Fix gcc compilation warning in test case [NFC]
May 9 2019, 5:11 AM
uabelho committed rCTE360334: Fix gcc compilation warning in test case [NFC].
Fix gcc compilation warning in test case [NFC]
May 9 2019, 5:11 AM
uabelho committed rC360333: Fix gcc compilation warning in an assert [NFC].
Fix gcc compilation warning in an assert [NFC]
May 9 2019, 5:11 AM
uabelho committed rL360333: Fix gcc compilation warning in an assert [NFC].
Fix gcc compilation warning in an assert [NFC]
May 9 2019, 5:11 AM

May 8 2019

uabelho added a comment to D60846: [ValueTracking] Improve isKnowNonZero for Ints.

@uabelho great job coming up with a reproducer and thanks @nikic for reverting! I'll start working on a better solution.

I ran ninja check, but I did not hit any failures. Are there more architectures and/or tools I should enable and check before a commit?

May 8 2019, 10:09 PM · Restricted Project
uabelho added a comment to D60846: [ValueTracking] Improve isKnowNonZero for Ints.

This is as far as I've come:

May 8 2019, 6:49 AM · Restricted Project
uabelho added a comment to D60846: [ValueTracking] Improve isKnowNonZero for Ints.

I'm experiencing problems with this patch as well. I'm not 100% sure what the
problem is yet but I have a suspicion:

May 8 2019, 5:57 AM · Restricted Project

May 3 2019

Herald added a project to D45842: [Reassociate] swap binop operands to increase factoring potential: Restricted Project.
May 3 2019, 5:16 AM · Restricted Project
uabelho added reviewers for D51028: [BranchFolder] Drop kill flags if they aren't present in all merged instructions: craig.topper, rnk.

Anyone has an opinion about this?

May 3 2019, 1:12 AM
uabelho updated the diff for D51028: [BranchFolder] Drop kill flags if they aren't present in all merged instructions.

Rebased, fixed a spelling mistake.

May 3 2019, 1:07 AM
uabelho resigned from D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP.
May 3 2019, 12:20 AM · Restricted Project

Apr 29 2019

uabelho added a comment to D58113: [SCEV] Teach computeSCEVAtScope benefit from one-input Phi. PR39673.

Should we/someone push this?

Apr 29 2019, 12:50 AM · Restricted Project

Apr 24 2019

uabelho added a comment to D61024: [SLP] Fix crash after r358519.

Thanks for fixing!
The original case where I saw the crash compiles successfully with this patch.

Apr 24 2019, 1:00 AM · Restricted Project

Apr 16 2019

uabelho added a comment to D60791: [CVP] Simplify umulo and smulo that cannot overflow.

I see crashed with this patch. E.g.

Apr 16 2019, 11:15 PM · Restricted Project

Apr 10 2019

uabelho committed rG58c080a3b12d: Add { } to silence compiler warning [NFC] (authored by uabelho).
Add { } to silence compiler warning [NFC]
Apr 10 2019, 11:56 PM
uabelho committed rC358152: Add { } to silence compiler warning [NFC].
Add { } to silence compiler warning [NFC]
Apr 10 2019, 11:56 PM
uabelho committed rL358152: Add { } to silence compiler warning [NFC].
Add { } to silence compiler warning [NFC]
Apr 10 2019, 11:56 PM

Apr 3 2019

uabelho added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

When looking at some code changes for my out-of-tree target with this commit I noticed a change that I thought I'd ask if you think
is good or not.

With this change we now seem to sink e.g. calls to @llvm.lifetime.end? It returns void, and thus has 0 uses, and as far as I understand
such calls were not sinked before? Is this on purpose and is that good? In general I guess it's good to do lifetime.end at soon as possible?

(And I suppose there are also a whole bunch of other intrinsics that also return void that can be sinked now, I've no idea if that
can cause problems somewhere?)

It's not on purpose in the sense that I was targeting the lifetime intrinsics, but it's showing my change working as intended.

For the lifetime intrinsics, I don't think this really matters. As you say, it's good to do lifetime.end as soon as possible, so sinking them in general doesn't make sense, but I also don't think this matters much here because they can't be sunk very far, i.e. I don't see how this sinking could actually extend the lifetime.

Apr 3 2019, 1:35 AM · Restricted Project
uabelho added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

When looking at some code changes for my out-of-tree target with this commit I noticed a change that I thought I'd ask if you think
is good or not.

Apr 3 2019, 12:56 AM · Restricted Project

Apr 2 2019

uabelho committed rG4ec931714dec: Fix compiler warning, remove extra ";" [NFC] (authored by uabelho).
Fix compiler warning, remove extra ";" [NFC]
Apr 2 2019, 3:03 AM
uabelho committed rL357461: Fix compiler warning, remove extra ";" [NFC].
Fix compiler warning, remove extra ";" [NFC]
Apr 2 2019, 3:03 AM
uabelho committed rC357461: Fix compiler warning, remove extra ";" [NFC].
Fix compiler warning, remove extra ";" [NFC]
Apr 2 2019, 3:03 AM
uabelho added a comment to D59528: [clang-tidy] Expand modular headers for PPCallbacks.

I noticed that with this commit I get a whole bunch (~40) of warnings like the below when compiling with gcc 7.4:

[10/16] Building CXX object tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/clangTidyUtils.dir/HeaderGuard.cpp.o
In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:12:0,
                 from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9:
../tools/clang/tools/extra/clang-tidy/utils/../ClangTidy.h:161:16: warning: 'virtual void clang::tidy::ClangTidyCheck::registerPPCallbacks(const clang::SourceManager&, clang::Preprocessor*, clang::Preprocessor*)' was hidden [-Woverloaded-virtual]
   virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
                ^~~~~~~~~~~~~~~~~~~
In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9:0:
../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:35:8: warning:   by 'virtual void clang::tidy::utils::HeaderGuardCheck::registerPPCallbacks(clang::CompilerInstance&)' [-Woverloaded-virtual]
   void registerPPCallbacks(CompilerInstance &Compiler) override;
        ^~~~~~~~~~~~~~~~~~~
Apr 2 2019, 1:53 AM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2019

uabelho committed rG150a7ec2dc04: [InstCombine] Handle vector gep with scalar argument in… (authored by uabelho).
[InstCombine] Handle vector gep with scalar argument in…
Apr 1 2019, 7:10 AM
uabelho committed rL357389: [InstCombine] Handle vector gep with scalar argument in….
[InstCombine] Handle vector gep with scalar argument in…
Apr 1 2019, 7:10 AM
uabelho closed D60058: [InstCombine] Handle vector gep with scalar argument in evaluateInDifferentElementOrder.
Apr 1 2019, 7:10 AM · Restricted Project
uabelho committed rG3e527cd823a4: Revert "[InstCombine] Handle vector gep with scalar argument in… (authored by uabelho).
Revert "[InstCombine] Handle vector gep with scalar argument in…
Apr 1 2019, 7:07 AM
uabelho committed rL357387: Revert "[InstCombine] Handle vector gep with scalar argument in….
Revert "[InstCombine] Handle vector gep with scalar argument in…
Apr 1 2019, 7:05 AM
uabelho committed rGd66a47f90a78: [InstCombine] Handle vector gep with scalar argument in… (authored by uabelho).
[InstCombine] Handle vector gep with scalar argument in…
Apr 1 2019, 6:48 AM
uabelho committed rL357385: [InstCombine] Handle vector gep with scalar argument in….
[InstCombine] Handle vector gep with scalar argument in…
Apr 1 2019, 6:47 AM
uabelho updated the diff for D60058: [InstCombine] Handle vector gep with scalar argument in evaluateInDifferentElementOrder.
Apr 1 2019, 6:45 AM · Restricted Project
uabelho updated the diff for D60058: [InstCombine] Handle vector gep with scalar argument in evaluateInDifferentElementOrder.
Apr 1 2019, 6:37 AM · Restricted Project
uabelho added a comment to D60058: [InstCombine] Handle vector gep with scalar argument in evaluateInDifferentElementOrder.

Great! I'll update the test and submit in a little bit.

Apr 1 2019, 6:20 AM · Restricted Project
uabelho created D60058: [InstCombine] Handle vector gep with scalar argument in evaluateInDifferentElementOrder.
Apr 1 2019, 2:27 AM · Restricted Project

Mar 21 2019

uabelho committed rG5b1754f93d84: Silence warning about unused variable in builds without asserts [NFC] (authored by uabelho).
Silence warning about unused variable in builds without asserts [NFC]
Mar 21 2019, 12:56 AM
uabelho committed rL356648: Silence warning about unused variable in builds without asserts [NFC].
Silence warning about unused variable in builds without asserts [NFC]
Mar 21 2019, 12:56 AM

Mar 15 2019

uabelho committed rG339daae806b2: [CodeGenPrepare] avoid crashing from replacing a phi twice (authored by uabelho).
[CodeGenPrepare] avoid crashing from replacing a phi twice
Mar 15 2019, 6:51 AM
uabelho committed rL356260: [CodeGenPrepare] avoid crashing from replacing a phi twice.
[CodeGenPrepare] avoid crashing from replacing a phi twice
Mar 15 2019, 6:50 AM
uabelho closed D59358: [CodeGenPrepare] avoid crashing from replacing a phi twice.
Mar 15 2019, 6:50 AM · Restricted Project
uabelho added a comment to D59358: [CodeGenPrepare] avoid crashing from replacing a phi twice.

I'll push this for JesperAntonsson in a bit since he's having some environment issues.

Mar 15 2019, 6:44 AM · Restricted Project

Mar 14 2019

uabelho committed rGf5fe2974cfd2: Remove unused variable to silence compiler warning [NFC] (authored by uabelho).
Remove unused variable to silence compiler warning [NFC]
Mar 14 2019, 7:21 AM
uabelho committed rL356152: Remove unused variable to silence compiler warning [NFC].
Remove unused variable to silence compiler warning [NFC]
Mar 14 2019, 7:21 AM
uabelho committed rC356152: Remove unused variable to silence compiler warning [NFC].
Remove unused variable to silence compiler warning [NFC]
Mar 14 2019, 7:21 AM

Feb 26 2019

uabelho added a comment to D58626: [DAG] Fix constant store folding to handle non-byte sizes..

Added a few nits about too long lines.

Feb 26 2019, 2:09 AM · Restricted Project
uabelho added a comment to D58626: [DAG] Fix constant store folding to handle non-byte sizes..

Nice! I ran a new bunch of llvm-stress tests with this patch and now I don't see the crashes anymore.
Please push.

Feb 26 2019, 1:19 AM · Restricted Project

Feb 19 2019

uabelho committed rG2d6bb13443d8: [RegAllocGreedy] Take last chance recoloring into account in split and assign (authored by uabelho).
[RegAllocGreedy] Take last chance recoloring into account in split and assign
Feb 19 2019, 11:14 PM
uabelho committed rL354439: [RegAllocGreedy] Take last chance recoloring into account in split and assign.
[RegAllocGreedy] Take last chance recoloring into account in split and assign
Feb 19 2019, 11:14 PM
uabelho closed D58376: [RegAllocGreedy] Take last chance recoloring into account in split and assign.
Feb 19 2019, 11:14 PM · Restricted Project
uabelho added a comment to D58376: [RegAllocGreedy] Take last chance recoloring into account in split and assign.

Thanks!

Feb 19 2019, 11:13 PM · Restricted Project
uabelho added a comment to D57149: [StackProtector] Skip analysing dead users in HasAddressTaken, PR40436.

I do see the point of ensuring the sanity of StackProtector, and I'm not opposed to patching that up (as you have done here in this patch); however, I do see benefit in preventing the dead code from reaching the StackProtector in the first place. I'm not sure how others feel.

Feb 19 2019, 6:01 AM