Page MenuHomePhabricator
Feed Advanced Search

Today

uabelho committed rG410c150abb20: [test] Update PR reference in testcase [NFC] (authored by uabelho).
[test] Update PR reference in testcase [NFC]
Mon, Nov 23, 6:13 AM
uabelho committed rGfaf848ac3218: [Inline] Fix in handling of ptrtoint in InlineCost (authored by uabelho).
[Inline] Fix in handling of ptrtoint in InlineCost
Mon, Nov 23, 5:34 AM
uabelho closed D90610: [Inline] Fix in handling of ptrtoint in InlineCost.
Mon, Nov 23, 5:34 AM · Restricted Project
uabelho added a comment to D90610: [Inline] Fix in handling of ptrtoint in InlineCost.

LGTM

Mon, Nov 23, 4:18 AM · Restricted Project

Thu, Nov 19

uabelho added a comment to D90610: [Inline] Fix in handling of ptrtoint in InlineCost.

Thanks for looking into this!

Should places where we use ConstantOffsetPtrs to determine if instructions may be simplified, like CallAnalyzer::visitCmpInst, be also adjusted? Or does the ContantExpr::getICmp call take care of different-sized constant ints?

I don't know. When I debugged PR49890 I just realized that the size mismatch was introduced with the ptrtoint, so I tried doing something about that instead of trying to handle it at every use of ConstantOffsetPtrs. And then I realized that fix seems to have fixed PR38500 as well.

I think it would be good to understand that, as part of this patch, as changing that may have performance implications.

Thu, Nov 19, 6:42 AM · Restricted Project
uabelho added inline comments to D90610: [Inline] Fix in handling of ptrtoint in InlineCost.
Thu, Nov 19, 6:29 AM · Restricted Project
uabelho updated the diff for D90610: [Inline] Fix in handling of ptrtoint in InlineCost.

Do the easiest fix.

Thu, Nov 19, 6:22 AM · Restricted Project

Wed, Nov 18

uabelho added a comment to D91383: [BasicAA] Make alias GEP positive offset handling symmetric.

@uabelho Thanks for the report! I have reverted the assert in https://github.com/llvm/llvm-project/commit/85ccdcaa502ee2c478f2d0ba2b1e217117b69032. We'll have to fix this asymmetric in phi-phi aliasing before re-enabling it.

Wed, Nov 18, 9:58 PM · Restricted Project

Tue, Nov 17

uabelho added a comment to D91383: [BasicAA] Make alias GEP positive offset handling symmetric.

The following hits an assertion with this patch. If I run

opt -S -o - aa.ll -aa-eval
Tue, Nov 17, 11:46 PM · Restricted Project
uabelho added a comment to D88735: [SLP] Also try to vectorize incoming values of PHIs ..

Thanks!

Tue, Nov 17, 10:38 PM · Restricted Project

Mon, Nov 16

uabelho added inline comments to D91059: [LoopVectorizer] NFCI: Calculate register usage based on TLI.getTypeLegalizationCost..
Mon, Nov 16, 11:50 PM · Restricted Project
uabelho added a comment to D88735: [SLP] Also try to vectorize incoming values of PHIs ..

Hi!
This seems to fail if one of the predecessors to the PHI block is dead and contain weird stuff e.g. like this:

define void @foo() {
bb.0:
  br label %bb.1
Mon, Nov 16, 4:48 AM · Restricted Project

Thu, Nov 12

uabelho added inline comments to D91046: [CGSCC][Inliner] Handle new non-trivial edges in updateCGAndAnalysisManagerForPass.
Thu, Nov 12, 10:16 PM · Restricted Project
uabelho added a comment to D91083: [AsmPrinter] fix -disable-debug-info option.

Thanks! The problem I saw is fixed with this patch.

Thu, Nov 12, 12:45 AM · Restricted Project

Wed, Nov 11

uabelho added a comment to D91059: [LoopVectorizer] NFCI: Calculate register usage based on TLI.getTypeLegalizationCost..

I hit an assertion with this patch:
opt: ../lib/IR/Type.cpp:620: static llvm::FixedVectorType *llvm::FixedVectorType::get(llvm::Type *, unsigned int): Assertion `isValidElementType(ElementType) && "Element type of a VectorType must " "be an integer, floating point, or " "pointer type."' failed.

Wed, Nov 11, 6:22 AM · Restricted Project

Wed, Nov 4

uabelho added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Hi!

I found a new problem after this was turned on again in 51ff04567b2f.

Wed, Nov 4, 6:13 AM · Restricted Project, Restricted Project
uabelho added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I found a new problem after this was turned on again in 51ff04567b2f.
With

opt -S -o - bbi-49235.ll -memoryssa -gvn -dse -verify-memoryssa

I hit

opt: ../lib/Analysis/MemorySSA.cpp:2063: void llvm::MemorySSA::verifyOrderingDominationAndDefUses(llvm::Function &) const: Assertion `&*ALI == *AAI && "Not the same accesses in the same order"' failed.

with bbi-49235.ll being

define void @k() {
entry:
  %tobool = icmp ne i16 1, 0
  %0 = xor i1 %tobool, true
  call void @llvm.assume(i1 %0)
  call void @f()
  ret void
}
Wed, Nov 4, 5:58 AM · Restricted Project, Restricted Project
uabelho added a comment to D74158: make the AsmPrinterHandler array public.

Bah, I meant to post my comment in https://reviews.llvm.org/D89613. I did now.

Wed, Nov 4, 4:44 AM · Restricted Project
uabelho added a comment to D89613: make the AsmPrinterHandler array public.

Is this commit supposed to change the output from llc?

Wed, Nov 4, 4:44 AM · Restricted Project
uabelho added a comment to D74158: make the AsmPrinterHandler array public.

Is this commit supposed to change the output from llc?

Wed, Nov 4, 4:42 AM · Restricted Project

Tue, Nov 3

uabelho added inline comments to D90610: [Inline] Fix in handling of ptrtoint in InlineCost.
Tue, Nov 3, 5:44 AM · Restricted Project
uabelho added a comment to D90610: [Inline] Fix in handling of ptrtoint in InlineCost.

Thanks for looking into this!

Should places where we use ConstantOffsetPtrs to determine if instructions may be simplified, like CallAnalyzer::visitCmpInst, be also adjusted? Or does the ContantExpr::getICmp call take care of different-sized constant ints?

Tue, Nov 3, 12:10 AM · Restricted Project
uabelho added inline comments to D90610: [Inline] Fix in handling of ptrtoint in InlineCost.
Tue, Nov 3, 12:07 AM · Restricted Project
uabelho updated the diff for D90610: [Inline] Fix in handling of ptrtoint in InlineCost.

Changed names of the testcase functions and changed to zext in visitPtrToInt.

Tue, Nov 3, 12:04 AM · Restricted Project

Mon, Nov 2

uabelho added inline comments to D90610: [Inline] Fix in handling of ptrtoint in InlineCost.
Mon, Nov 2, 7:19 AM · Restricted Project
uabelho requested review of D90610: [Inline] Fix in handling of ptrtoint in InlineCost.
Mon, Nov 2, 7:17 AM · Restricted Project

Wed, Oct 28

uabelho added a comment to D87528: Enable '#pragma STDC FENV_ACCESS' in frontend.

We got similar problems for our downstream target. We worked around that by bailing out early in PragmaSTDC_FENV_ACCESSHandler::HandlePragma for our target but perhaps one could check hasStrictFP() instead and ignore the pragma if that is false?

Wed, Oct 28, 12:13 AM · Restricted Project

Mon, Oct 26

uabelho added a comment to D54749: Saturating float to int casts..

Are there any outstanding issues left or is this perhaps good enough to be submitted?

Mon, Oct 26, 11:40 PM · Restricted Project

Oct 23 2020

uabelho added a comment to D89978: Fix SROA with a PHI mergig values from a same block.

I don't know what the best fix is, but I've verified that this patch solves the problem I saw and I haven't seen anything weird pop up with the patch in some limited testing I've done with it.
Thanks!

Oct 23 2020, 1:52 AM · Restricted Project

Oct 22 2020

uabelho added a comment to D79218: Process gep (phi ptr1, ptr2) in SROA.

https://bugs.llvm.org/show_bug.cgi?id=47945 started happening with this patch.

Oct 22 2020, 8:09 AM · Restricted Project

Oct 16 2020

uabelho committed rGe5e4653255ff: Remove dead variable to silence compiler warning [NFC] (authored by uabelho).
Remove dead variable to silence compiler warning [NFC]
Oct 16 2020, 12:36 AM

Oct 14 2020

uabelho added inline comments to D86078: [AArch64] Improved lowering for saturating float to int..
Oct 14 2020, 12:39 AM · Restricted Project

Oct 13 2020

uabelho added a comment to D88806: [SCEV] Model ptrtoint(SCEVUnknown) cast not as unknown, but as zext/trunc/self of SCEVUnknown.

Perfect, thank you. That's the test case i was missing. Will fix in a moment.

Fixed in rG7324616660fc0995fa8c166e3c392361222d5dbc, thank you for the reproducer!

Oct 13 2020, 4:35 AM · Restricted Project
uabelho added a comment to D88806: [SCEV] Model ptrtoint(SCEVUnknown) cast not as unknown, but as zext/trunc/self of SCEVUnknown.

I got my share of doom too, even after the fix.
So

opt -S -o - bbi-48445.ll -indvars

crashes with

opt: ../lib/IR/Constants.cpp:1896: static llvm::Constant *llvm::ConstantExpr::getZExt(llvm::Constant *, llvm::Type *, bool): Assertion `C->getType()->isIntOrIntVectorTy() && "ZEXt operand must be integral"' failed.

for the following input:

Oct 13 2020, 1:04 AM · Restricted Project

Oct 7 2020

uabelho added a comment to D88167: [LoopDeletion] Forget loop before setting values to undef.

I just wrote
https://bugs.llvm.org/show_bug.cgi?id=47753
about a failure that starts occuring with this patch.

Oct 7 2020, 5:14 AM · Restricted Project

Oct 6 2020

uabelho accepted D88876: [AMDGPU] Fix gcc warnings.

Thanks!

Oct 6 2020, 1:54 AM · Restricted Project
uabelho added inline comments to D86270: [AMDGPU] Use tablegen for argument indices.
Oct 6 2020, 12:00 AM · Restricted Project

Oct 5 2020

uabelho added a comment to D88487: [TableGen][GlobalISel] add handling of nested *_SUBREG.

I submitted for ehjogab.

Oct 5 2020, 1:53 AM · Restricted Project
uabelho committed rG64b879ae2a8a: [TableGen][GlobalISel] add handling of nested *_SUBREG (authored by ehjogab).
[TableGen][GlobalISel] add handling of nested *_SUBREG
Oct 5 2020, 1:53 AM
uabelho closed D88487: [TableGen][GlobalISel] add handling of nested *_SUBREG.
Oct 5 2020, 1:52 AM · Restricted Project

Oct 1 2020

uabelho added a comment to D88454: [CMake] Use -isystem flag to access libc++ headers.

Hi!
I don't understand why, but with this commit I start seeing several warnings like this when compiling builtins:

Oct 1 2020, 9:29 PM · Restricted Project, Restricted Project

Sep 30 2020

uabelho added a comment to D86511: [GlobalISel] Fix incorrect setting of ValNo when splitting.

I submited this for ehjogab

Sep 30 2020, 7:11 AM · Restricted Project
uabelho committed rG43d239d0fadb: [GlobalISel] Fix incorrect setting of ValNo when splitting (authored by ehjogab).
[GlobalISel] Fix incorrect setting of ValNo when splitting
Sep 30 2020, 7:09 AM
uabelho closed D86511: [GlobalISel] Fix incorrect setting of ValNo when splitting.
Sep 30 2020, 7:09 AM · Restricted Project

Sep 24 2020

uabelho committed rGa1217620a87f: [unittests] Use std::make_tuple to make some toolchains happy again (authored by uabelho).
[unittests] Use std::make_tuple to make some toolchains happy again
Sep 24 2020, 2:26 AM

Sep 18 2020

uabelho added a comment to D87149: [InstCombine] erase instructions leading up to unreachable.

We've run into a case where instcombine crashes with this patch:

opt -o /dev/null bbi-47401.ll -instcombine

on

@c = external global i16*, align 1
Sep 18 2020, 12:32 AM · Restricted Project

Sep 17 2020

uabelho committed rGbb037c2a7625: [ConstraintSystem] Remove local variable that is set but not read [NFC] (authored by uabelho).
[ConstraintSystem] Remove local variable that is set but not read [NFC]
Sep 17 2020, 5:29 AM

Sep 14 2020

uabelho added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Hi,

I'm seeing what I think is a miscompile with this:

Thanks for the reproducer. We have to be more careful around pointers that may reference multiple locations in memory. I pushed f715d81c9df3 which limits elimination to stores that only reference a single location (or are in the same BB). The check is conservative and can be improved in the future, but the impact on the number of stores eliminated seems very low in practice. It would be great if you could check if that fixes the original reproducer.

Great! I'll check and get back during the day.

Sep 14 2020, 5:52 AM · Restricted Project, Restricted Project
uabelho added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Hi,

I'm seeing what I think is a miscompile with this:

Thanks for the reproducer. We have to be more careful around pointers that may reference multiple locations in memory. I pushed f715d81c9df3 which limits elimination to stores that only reference a single location (or are in the same BB). The check is conservative and can be improved in the future, but the impact on the number of stores eliminated seems very low in practice. It would be great if you could check if that fixes the original reproducer.

Sep 14 2020, 4:50 AM · Restricted Project, Restricted Project
uabelho added a comment to D86689: [DAGCombine] Don't delete the node if it has uses immediately.

I wrote https://bugs.llvm.org/show_bug.cgi?id=47517 about a crash that starts happening with this patch.

Sep 14 2020, 4:20 AM · Restricted Project
uabelho added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I'm seeing what I think is a miscompile with this:

opt -S -dse -o - dse.ll

on

Sep 14 2020, 12:18 AM · Restricted Project, Restricted Project

Sep 7 2020

uabelho committed rGea795304ec07: [PowerPC] Add parentheses to silence gcc warning (authored by uabelho).
[PowerPC] Add parentheses to silence gcc warning
Sep 7 2020, 11:41 PM

Sep 4 2020

uabelho added a comment to D86534: [GVN] Preserve MemorySSA if it is available..

The following crashes for me with this patch
opt -memoryssa -gvn -early-cse-memssa -S -o - foo.ll

Sep 4 2020, 3:44 AM · Restricted Project

Sep 3 2020

uabelho added inline comments to D86589: (Expensive) Check for Loop, SCC and Region pass return status.
Sep 3 2020, 9:37 AM · Restricted Project
uabelho added inline comments to D86589: (Expensive) Check for Loop, SCC and Region pass return status.
Sep 3 2020, 3:03 AM · Restricted Project

Sep 2 2020

uabelho added a comment to D86839: [CMake] Remove -Wl,-allow-shlib-undefined which was added in rL221530.

We ran into problems with this commit.

Sep 2 2020, 5:36 AM · Restricted Project
uabelho added inline comments to D86738: AMDGPU/GlobalISel: Implement computeKnownBits for groupstaticsize.
Sep 2 2020, 2:42 AM · Restricted Project

Sep 1 2020

uabelho added a comment to D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics.

I wrote
https://bugs.llvm.org/show_bug.cgi?id=47381
about a similar problem also caused by the missing setting of Changed in SimplifyIndvar::eliminateOverflowIntrinsic.

Sep 1 2020, 4:21 AM · Restricted Project

Aug 28 2020

uabelho added a comment to D71538: [SCEVExpander] Preserve LCSSA directly..

We ran into a problem with this patch. I wrote https://bugs.llvm.org/show_bug.cgi?id=47343 about it.

Aug 28 2020, 4:12 AM · Restricted Project

Aug 26 2020

uabelho added a comment to D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z.

We've run with changes like this for a long time to make the routines work for our out of tree target where int is also 16 bits so thumbs up from me even if I'm not sure I can formally LGTM it.

Aug 26 2020, 2:09 AM · Restricted Project

Aug 25 2020

uabelho committed rG1c39ffecd84a: [libunwind] Fix warning when building without frameheader cache (authored by uabelho).
[libunwind] Fix warning when building without frameheader cache
Aug 25 2020, 4:02 AM
uabelho committed rG59e1fbe55784: [PowerPC] Fix gcc warning [NFC] (authored by uabelho).
[PowerPC] Fix gcc warning [NFC]
Aug 25 2020, 4:02 AM

Jul 16 2020

uabelho added inline comments to D83760: [AMDGPU][MC] Corrected MTBUF parsing and decoding.
Jul 16 2020, 10:56 PM · Restricted Project
uabelho committed rG274332282cb4: [clangd] Fix a few gcc warnings [NFC] (authored by uabelho).
[clangd] Fix a few gcc warnings [NFC]
Jul 16 2020, 1:16 AM
uabelho committed rGae74387fc0fd: [MasmParser] Remove unused method emitStructValue to silence warning (authored by uabelho).
[MasmParser] Remove unused method emitStructValue to silence warning
Jul 16 2020, 1:16 AM

Jul 10 2020

uabelho added a comment to D82998: [BasicAA] Enable -basic-aa-recphi by default.

Thanks. I will take a look.

From this, that bug appears to be fixed: https://godbolt.org/z/6W8hc8. Probably from D82987 I would expect. I will check. Opt 10.0.0 does show the problem, where as trunk seems to be fixed.

Let me know about the runtime failure.

Jul 10 2020, 3:00 AM · Restricted Project
uabelho added a comment to D82998: [BasicAA] Enable -basic-aa-recphi by default.

I noticed that we got a runtime failure with this patch for our out-of-tree target. I haven't gone to the bottom with it yet, but I saw that a colleague of mine wrote a PR about a miscompile with -basic-aa-recphi that at least hasn't been handled according to bugzilla:
https://bugs.llvm.org/show_bug.cgi?id=37952

Jul 10 2020, 1:32 AM · Restricted Project

Jul 9 2020

uabelho added a comment to D81345: [LV] Vectorize without versioning-for-unit-stride under -Os/-Oz.

I start seeing a crash with this patch:
https://bugs.llvm.org/show_bug.cgi?id=46652

Jul 9 2020, 1:11 AM · Restricted Project

Jul 8 2020

uabelho added inline comments to D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.
Jul 8 2020, 1:58 AM · Restricted Project
uabelho committed rGcfcf8e17ef53: [analyzer] Silence gcc -Wparentheses warning [NFC] (authored by uabelho).
[analyzer] Silence gcc -Wparentheses warning [NFC]
Jul 8 2020, 1:26 AM

Jul 5 2020

uabelho added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

A whole bunch of buildbots seems to have failed as well (in different ways).
E.g.
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/227/steps/test-libc%2B%2B/logs/FAIL%3A%20libc%2B%2B%3A%3Aunique_ptr_arg.pass.cpp
hit the same assertion as I see.
How about reverting again?

Jul 5 2020, 11:57 PM · Restricted Project
uabelho added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

I hit this assertion in a couple of testcases when running check-all on trunk now:

Jul 5 2020, 11:27 PM · Restricted Project

Jun 30 2020

uabelho added a comment to D82453: [CostModel] Fix for cast crash.

I don't know this code but at least the crash I saw goes away with the fix. Thanks!

Jun 30 2020, 2:08 AM · Restricted Project

Jun 24 2020

uabelho added a comment to D81643: [NFCI][CostModel] Unify ExtractElement cost..

I wrote
https://bugs.llvm.org/show_bug.cgi?id=46430
about a crash that started happening with this patch.

Jun 24 2020, 1:34 AM · Restricted Project

Jun 23 2020

uabelho added a comment to D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory.

Can you check if you see the warning with different versions of gcc?

Jun 23 2020, 11:57 PM · Restricted Project
uabelho added a comment to D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw.

Test failures are being fixed in https://reviews.llvm.org/D82338/new/

Jun 23 2020, 10:08 PM · Restricted Project
uabelho committed rG82a882db0832: Silence gcc warning about extra ";" [NFC] (authored by uabelho).
Silence gcc warning about extra ";" [NFC]
Jun 23 2020, 2:36 AM
uabelho added inline comments to D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory.
Jun 23 2020, 2:36 AM · Restricted Project
uabelho added a comment to D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw.

I see a bunch of failures when I run libcxx testcases with this patch. Should there be "noexcept" on a number of more places?

Jun 23 2020, 2:04 AM · Restricted Project
uabelho added inline comments to D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory.
Jun 23 2020, 1:00 AM · Restricted Project

Jun 17 2020

uabelho added inline comments to D81860: [ARM] Fix crash trying to generate i1 immediates.
Jun 17 2020, 2:07 AM · Restricted Project

Jun 16 2020

uabelho added a comment to D80206: [IR] Clean up dead instructions after simplifying a conditional branch.

I wrote
https://bugs.llvm.org/show_bug.cgi?id=46343
about a crash that starts happening with this patch.

Jun 16 2020, 2:09 AM · Restricted Project

Jun 11 2020

uabelho added a comment to D81634: Remove assert from ShuffleVectorInst.

Was the failure only a fuzzer problem?

Jun 11 2020, 10:29 PM · Restricted Project
uabelho added a comment to D79218: Process gep (phi ptr1, ptr2) in SROA.

Hi!

I wrote
https://bugs.llvm.org/show_bug.cgi?id=46280
for a crash that started happening with this commit.

Thanks! Here is the fix: D81674

Jun 11 2020, 10:29 PM · Restricted Project
uabelho added a comment to D79218: Process gep (phi ptr1, ptr2) in SROA.

I wrote
https://bugs.llvm.org/show_bug.cgi?id=46280
for a crash that started happening with this commit.

Jun 11 2020, 6:35 AM · Restricted Project
uabelho resigned from D81634: Remove assert from ShuffleVectorInst.

Thanks for the patch so quickly!
I really have no idea if the assert actually makes sense or not though, so it's best if @spatel can have an opinion.

Jun 11 2020, 1:50 AM · Restricted Project
uabelho added a comment to D80992: [CostModel] Unify getArithmeticInstrCost .

I wrote a PR about a crash that starts occuring with this patch:
https://bugs.llvm.org/show_bug.cgi?id=46276

Jun 11 2020, 12:37 AM · Restricted Project

Jun 10 2020

uabelho added a comment to D74825: SpeculativeExecution: fixed ingoring free execution.

I just wrote a PR about a debug-info fault that starts occuring with this patch:
https://bugs.llvm.org/show_bug.cgi?id=46267

Jun 10 2020, 2:08 AM · Restricted Project

Jun 9 2020

uabelho added a comment to D81408: [builtins] Improve compatibility with 16 bit targets.

Our out-of-tree target also have 16 bit ints and we've had to change a whole bunch of builtin_clz to clzsi and builtin_ctz to ctzsi to make things work so this patch is a step in the right direction for us too.

Jun 9 2020, 7:05 AM · Restricted Project

Jun 4 2020

uabelho added a comment to D71943: AMDGPU/GlobalISel: Add stub reg-bank aware combiner pass.

With gcc 7.4, the following warning pops up with this patch:

Jun 4 2020, 7:04 AM · Restricted Project
uabelho added inline comments to D77644: [clangd] Handle additional includes while parsing ASTs.
Jun 4 2020, 2:40 AM · Restricted Project
uabelho committed rG2f671c42254d: [WebAssembly] Fix gcc warning [NFC] (authored by uabelho).
[WebAssembly] Fix gcc warning [NFC]
Jun 4 2020, 1:35 AM

Jun 3 2020

uabelho added inline comments to D54368: RegAllocFast: Record internal state based on register units.
Jun 3 2020, 11:57 PM · Restricted Project
uabelho added a comment to D80863: [WebAssembly] Eliminate range checks on br_tables.
In D80863#2070105, @kcc wrote:

Hi, 
This made our ubsan bots red. Please fix or revert ASAP
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/42256

Jun 3 2020, 1:03 AM · Restricted Project

May 27 2020

uabelho added a comment to D78987: [BPI][NFC] Reuse post dominantor tree from analysis manager when available.

Hi!
PR 46098 started occuring wiith this patch:
https://bugs.llvm.org/show_bug.cgi?id=46098

May 27 2020, 6:27 AM · Restricted Project

May 19 2020

uabelho committed rGe408b54290bd: [clangd] Fix gcc compiler warning by removing extra ";" [NFC] (authored by uabelho).
[clangd] Fix gcc compiler warning by removing extra ";" [NFC]
May 19 2020, 3:13 AM

May 14 2020

uabelho added a comment to D79467: [PDB] Optimize public symbol processing.
In D79467#2035176, @rnk wrote:

Hopefully rG409274274 addresses the GCC warnings. I didn't get a chance to locally repro and confirm that the fix works.

May 14 2020, 1:01 AM · Restricted Project

May 13 2020

uabelho added inline comments to D79467: [PDB] Optimize public symbol processing.
May 13 2020, 3:11 AM · Restricted Project
uabelho added inline comments to D79467: [PDB] Optimize public symbol processing.
May 13 2020, 2:39 AM · Restricted Project

May 12 2020

uabelho added a comment to D76483: [DivRemPairs] Freeze operands if they can be undef values.

I wrote https://bugs.llvm.org/show_bug.cgi?id=45885 about a crash which starts happening with this patch.

May 12 2020, 4:47 AM · Restricted Project