causes confusing stack traces in applications
Thu, Sep 9
Tue, Aug 31
Fixed clang-tidy warnings, dropped an unnecessary auto.
I think you might want to update the syntax files for the various text editors. See:
Fixed clang-tidy warnings, cleaned up tests.
Aug 20 2021
Here's a PoC of the built-in function that returns the address of the function body with CFI. Based on D108478.
Here's a PoC of the "no cfi" constant type suggested by Peter. PTAL.
Aug 18 2021
Aug 12 2021
Thanks, Nick. I tested a kernel build with both ThinLTO and regular LTO + CFI, and can confirm that with this patch vmlinux has the previously missing .cfi_jt symbols again.
Aug 3 2021
Jul 30 2021
Also skip functions with names incompatible with XCOFF.
Jul 21 2021
As we only care about fixing inline assembly references, mangled names are
not that important in the first place. This version skips any functions
that have unusual characters in their names that would otherwise require
quotes, which includes any functions with MSVC compatible name mangling.
Jul 20 2021
Folded in D106392.
Nick suggested reverting until we figure out if this is the ideal fix here. I'll fold this to the original patch.
This patch broke the sanitizer-windows bot: https://lab.llvm.org/buildbot/#/builders/127/builds/14257Failed Tests (4): cfi-devirt-lld-thinlto-x86_64 :: anon-namespace.cpp cfi-devirt-lld-thinlto-x86_64 :: simple-pass.cpp cfi-standalone-lld-thinlto-x86_64 :: anon-namespace.cpp cfi-standalone-lld-thinlto-x86_64 :: simple-pass.cpp
Please revert or fix.
Jul 16 2021
Added REQUIRES: x86-registered-target to tests.
The tests that now specify a target triple also need ; REQUIRES: x86-registered-target or they will obviously fail. I'll upload another revision.
I'm curious if this will lead to breakages with LTO in general? I suppose not, since it's llvm-lto2 that needs the explicit list of symbols that can be linked against.
Jul 14 2021
Change LGTM, but I don't understand why the following tests are modified:
Jul 13 2021
Moved the alias creation to module level inline assembly to avoid issues with LowerTypeTestsModule, based on pcc's suggestion.
Jun 23 2021
Thanks for the revert, I'll take a look.
Jun 22 2021
Fix a use-of-uninitialized-value error.
Jun 17 2021
Moved the test to llvm/test/Transforms/ThinLTOBitcodeWriter.
Jun 10 2021
Changed the message to refer to CallBase instead of CallInst.
Thanks, Nick. I don't have commit access, so would you mind committing the patch? I confirmed that check-all passes for me with the patch applied.
Jun 8 2021
Thanks, Peter. I don't have commit access, so Nick, would you mind committing this for me? The Windows build failure looks unrelated.