Page MenuHomePhabricator
Feed Advanced Search

Wed, Sep 11

stella.stamenova added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

This broke the windows bot:

Wed, Sep 11, 5:48 AM · Restricted Project, Restricted Project
stella.stamenova accepted D66574: [lit] Make internal diff work in pipelines.

LGTM as long as all the tests still pass

Wed, Sep 11, 5:36 AM · Restricted Project

Fri, Aug 30

stella.stamenova added a comment to D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.

Is there a way to reduce some of the code duplication? The more duplication there is, the harder it is to maintain.

Fri, Aug 30, 11:27 AM · Restricted Project, Restricted Project

Thu, Aug 22

stella.stamenova added a comment to D66546: Extend FindTypes w/ CompilerContext to allow filtering by language.

It looks like this broke the windows build bot:

Thu, Aug 22, 1:26 PM · Restricted Project

Tue, Aug 20

stella.stamenova accepted D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC).

LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though.

Tue, Aug 20, 2:51 PM · Restricted Project, Restricted Project
stella.stamenova accepted D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.

I think this is actually fine. The change that was needed for multi-configuration generators is how the two default paths for the compilers are set. The USE variables were to make it explicit when we will or we won't override the user-set compiler. As long as we are OK overriding it if they set it to an empty string (which is probably an error, anyway), this change is good.

Tue, Aug 20, 10:40 AM · Restricted Project, Restricted Project
stella.stamenova accepted D66482: [lit] Diagnose insufficient args to internal env.

LGTM

Tue, Aug 20, 10:27 AM · Restricted Project

Aug 15 2019

stella.stamenova added a comment to D66224: MemoryBuffer: Add a missing error-check to getOpenFileImpl.

It looks like this changed caused 30 or so of the tests to fail on the Windows bot. It was already broken, so you wouldn't have gotten an email:

Aug 15 2019, 8:23 AM · Restricted Project

Aug 12 2019

stella.stamenova committed rG532e72499239: Revert "[lldb] Refactor guard variable checks in IRForTarget" (authored by stella.stamenova).
Revert "[lldb] Refactor guard variable checks in IRForTarget"
Aug 12 2019, 1:11 PM
stella.stamenova added a reverting change for rG94fbbf712e90: [lldb] Refactor guard variable checks in IRForTarget: rG532e72499239: Revert "[lldb] Refactor guard variable checks in IRForTarget".
Aug 12 2019, 1:11 PM
stella.stamenova committed rGe7daf78e05d2: Revert "[lldb] Fix dynamic_cast by no longer failing on variable without… (authored by stella.stamenova).
Revert "[lldb] Fix dynamic_cast by no longer failing on variable without…
Aug 12 2019, 1:11 PM
stella.stamenova added a reverting change for rGb448d1bf2122: [lldb] Fix dynamic_cast by no longer failing on variable without metadata: rGe7daf78e05d2: Revert "[lldb] Fix dynamic_cast by no longer failing on variable without….
Aug 12 2019, 1:11 PM
stella.stamenova committed rL368616: Revert "[lldb] Refactor guard variable checks in IRForTarget".
Revert "[lldb] Refactor guard variable checks in IRForTarget"
Aug 12 2019, 1:10 PM
stella.stamenova committed rL368615: Revert "[lldb] Fix dynamic_cast by no longer failing on variable without….
Revert "[lldb] Fix dynamic_cast by no longer failing on variable without…
Aug 12 2019, 1:10 PM
stella.stamenova added a comment to D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.

This change caused failures on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7681 compounding on the existing failures from [lldb] Refactor guard variable checks in IRForTarget

Aug 12 2019, 11:20 AM · Restricted Project, Restricted Project

Aug 8 2019

stella.stamenova added inline comments to D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option.
Aug 8 2019, 10:13 AM · Restricted Project

Aug 5 2019

stella.stamenova added a comment to D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC.

The windows bot for LLDB is still broken after the partial fix for the breakage:

Aug 5 2019, 2:25 PM · Restricted Project

Aug 2 2019

stella.stamenova committed rGdf1b00a7cb16: [lit] Fix 42812: lit test suite can no longer be run stand-alone (authored by stella.stamenova).
[lit] Fix 42812: lit test suite can no longer be run stand-alone
Aug 2 2019, 3:04 PM
stella.stamenova committed rL367730: [lit] Fix 42812: lit test suite can no longer be run stand-alone.
[lit] Fix 42812: lit test suite can no longer be run stand-alone
Aug 2 2019, 3:02 PM
stella.stamenova closed D65674: [lit] Fix 42812: lit test suite can no longer be run stand-alone.
Aug 2 2019, 3:02 PM · Restricted Project
stella.stamenova added a comment to D65674: [lit] Fix 42812: lit test suite can no longer be run stand-alone.

@mgorny Could you download the patch and see if it fixes your scenario? I tested it on both Ubuntu and Linux, but neither installation of LLVM I have actually contains FileCheck or not, so my setup is not entirely the same as yours.

Aug 2 2019, 1:30 PM · Restricted Project
stella.stamenova created D65674: [lit] Fix 42812: lit test suite can no longer be run stand-alone.
Aug 2 2019, 1:29 PM · Restricted Project
stella.stamenova accepted D65624: [lit] Print internal env commands.
Aug 2 2019, 9:49 AM · Restricted Project
stella.stamenova accepted D65623: [lit] Actually run tests for internal env command.
Aug 2 2019, 9:49 AM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

Yes, it was! Thanks for catching that :)

Aug 2 2019, 9:46 AM · Restricted Project

Aug 1 2019

Herald added a project to D55571: [ast] CreateParameterDeclaration should use an appropriate DeclContext.: Restricted Project.

Test passes now. Thanks!

Aug 1 2019, 3:25 PM · Restricted Project

Jul 31 2019

stella.stamenova accepted D65546: Fix TestThreadSpecificBreakpoint on Windows.

LGTM. Please keep an eye on the bot after you commit though

Jul 31 2019, 3:56 PM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

I am able to do some testing as well.

Jul 31 2019, 10:07 AM · Restricted Project
stella.stamenova added a comment to D65156: [lit] Protect full test suite from FILECHECK_OPTS.

HERE: useExternalSh: False

Jul 31 2019, 10:03 AM · Restricted Project

Jul 30 2019

stella.stamenova added a comment to D65156: [lit] Protect full test suite from FILECHECK_OPTS.

This actually breaks the lit tests on Windows when the path to Python has spaces. For example:

Jul 30 2019, 11:22 AM · Restricted Project
stella.stamenova added a comment to D65335: [llvm] [lit/tests] Replace 'env -u' with more portable construct.

It is indeed https://reviews.llvm.org/D65156 which introduced the failure

Jul 30 2019, 11:22 AM · Restricted Project
stella.stamenova added a comment to D65335: [llvm] [lit/tests] Replace 'env -u' with more portable construct.

It could be either actually. I'll run the tests with just the first one and see if it reproduces. I *think* it's this one.

Jul 30 2019, 9:29 AM · Restricted Project

Jul 29 2019

stella.stamenova added a comment to D65335: [llvm] [lit/tests] Replace 'env -u' with more portable construct.

This actually breaks the lit tests on Windows when the path to Python has spaces. For example:

Jul 29 2019, 6:13 PM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

One failure:

Jul 29 2019, 6:12 PM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

I'll run some tests and let you know the result.

Jul 29 2019, 4:01 PM · Restricted Project
stella.stamenova accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

I think you need one small change for lld still - to make it clear that it is required on Windows in the Windows section, but it looks good otherwise. Please fix that before committing.

Jul 29 2019, 10:23 AM · Restricted Project, Restricted Project

Jul 26 2019

stella.stamenova added inline comments to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 10:29 AM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 10:03 AM · Restricted Project, Restricted Project

Jul 17 2019

stella.stamenova added a comment to D64881: [Cmake] Use the modern way to find Python when possible.

Re: Windows CMake: I am not sure, I'd have to do look into it further.

Jul 17 2019, 2:31 PM · Restricted Project

Jul 16 2019

stella.stamenova accepted D64660: add a workaround in GetLine to account for ReadFile not reporintg error.

LGTM!

Jul 16 2019, 9:05 AM · Restricted Project

Jul 15 2019

stella.stamenova committed rG032e3c468fab: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build (authored by stella.stamenova).
[llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build
Jul 15 2019, 11:16 AM
stella.stamenova committed rL366097: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build.
[llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build
Jul 15 2019, 11:15 AM
stella.stamenova closed D64357: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build.
Jul 15 2019, 11:15 AM · Restricted Project
stella.stamenova accepted D64719: [zorg] [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout.
Jul 15 2019, 9:04 AM · Restricted Project, Restricted Project

Jul 9 2019

stella.stamenova added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

This broke the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/6493/steps/build/logs/stdio

Jul 9 2019, 1:11 PM · Restricted Project
stella.stamenova committed rG20ecec6116b3: [lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher (authored by stella.stamenova).
[lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher
Jul 9 2019, 11:43 AM
stella.stamenova committed rL365533: [lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher.
[lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher
Jul 9 2019, 11:41 AM
stella.stamenova committed rG2ea514c5662f: [lldb-suite] Skip TestMachCore on Windows (authored by stella.stamenova).
[lldb-suite] Skip TestMachCore on Windows
Jul 9 2019, 11:19 AM
stella.stamenova committed rL365527: [lldb-suite] Skip TestMachCore on Windows.
[lldb-suite] Skip TestMachCore on Windows
Jul 9 2019, 11:18 AM
stella.stamenova committed rG631b5f7dc0e9: [lldb, windows] Update two more locations that use LaunchThread to the new… (authored by stella.stamenova).
[lldb, windows] Update two more locations that use LaunchThread to the new…
Jul 9 2019, 11:12 AM
stella.stamenova committed rL365526: [lldb, windows] Update two more locations that use LaunchThread to the new….
[lldb, windows] Update two more locations that use LaunchThread to the new…
Jul 9 2019, 11:11 AM
stella.stamenova added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().

I am not sure if you've seen this yet, but this broke the Windows LLDB bot:

Jul 9 2019, 9:07 AM · Restricted Project

Jul 8 2019

stella.stamenova committed rG7f843e22bae2: [lldb, windows] When StartMonitoring fails, return a proper error (authored by stella.stamenova).
[lldb, windows] When StartMonitoring fails, return a proper error
Jul 8 2019, 3:10 PM
stella.stamenova committed rL365400: [lldb, windows] When StartMonitoring fails, return a proper error.
[lldb, windows] When StartMonitoring fails, return a proper error
Jul 8 2019, 3:10 PM
stella.stamenova committed rG05590baa071b: [lldb] Fix two more issues in Windows following rL365226: Change LaunchThread… (authored by stella.stamenova).
[lldb] Fix two more issues in Windows following rL365226: Change LaunchThread…
Jul 8 2019, 2:19 PM
stella.stamenova committed rL365388: [lldb] Fix two more issues in Windows following rL365226: Change LaunchThread….
[lldb] Fix two more issues in Windows following rL365226: Change LaunchThread…
Jul 8 2019, 2:18 PM
stella.stamenova committed rGed499a36b67c: Revert "Move common functionality from processwindows into processdebugger" (authored by stella.stamenova).
Revert "Move common functionality from processwindows into processdebugger"
Jul 8 2019, 11:56 AM
stella.stamenova added a reverting change for rG9c01eaff6aa3: Move common functionality from processwindows into processdebugger: rGed499a36b67c: Revert "Move common functionality from processwindows into processdebugger".
Jul 8 2019, 11:56 AM
stella.stamenova committed rL365371: Revert "Move common functionality from processwindows into processdebugger".
Revert "Move common functionality from processwindows into processdebugger"
Jul 8 2019, 11:53 AM
stella.stamenova created D64357: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build.
Jul 8 2019, 11:34 AM · Restricted Project

Jul 3 2019

stella.stamenova accepted D64154: [Docs] Unify build instructions .
Jul 3 2019, 1:34 PM · Restricted Project
stella.stamenova added inline comments to D64154: [Docs] Unify build instructions .
Jul 3 2019, 1:23 PM · Restricted Project

Jul 2 2019

stella.stamenova accepted D64046: [windows] re-call signal in sigint_handler for Windows.

LGTM. Have you run the tests to make sure they behave correctly after this change?

Jul 2 2019, 9:30 AM · Restricted Project

Jul 1 2019

stella.stamenova committed rG86e4d7ea35ee: [lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate (authored by stella.stamenova).
[lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate
Jul 1 2019, 3:15 PM
stella.stamenova committed rL364860: [lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate.
[lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate
Jul 1 2019, 3:13 PM
stella.stamenova committed rG55d2e6f1c26c: [lldb] [lldbsuite] Use a unique class name for TestBacktraceAll (authored by stella.stamenova).
[lldb] [lldbsuite] Use a unique class name for TestBacktraceAll
Jul 1 2019, 11:14 AM
stella.stamenova committed rL364826: [lldb] [lldbsuite] Use a unique class name for TestBacktraceAll.
[lldb] [lldbsuite] Use a unique class name for TestBacktraceAll
Jul 1 2019, 11:14 AM

Jun 21 2019

stella.stamenova accepted D63679: [lit] Make lit-lldb-init configurable by CMake.

LGTM.

Jun 21 2019, 4:04 PM · Restricted Project, Restricted Project

Jun 20 2019

stella.stamenova added a comment to D63110: Fix a crash in option parsing..

@stella.stamenova could you try running the lldb invocation manually like I did? I'm wondering if you're getting the same issue.

Jun 20 2019, 11:27 AM · Restricted Project, Restricted Project

Jun 18 2019

stella.stamenova added a comment to D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups.

Thanks!

Jun 18 2019, 8:45 AM · Restricted Project
stella.stamenova added a comment to D63110: Fix a crash in option parsing..

This test is extremely flaky on Windows - it looks like it passes on the bot less than 10% of the time: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot.

Jun 18 2019, 8:45 AM · Restricted Project, Restricted Project

Jun 17 2019

stella.stamenova added a comment to D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups.

It looks like this broke the Windows bot. I am no longer receiving emails when the bot fails (as bot owner I used to always get the failure emails), so I am assuming for some reason notifications aren't working correctly.

Jun 17 2019, 1:45 PM · Restricted Project

Jun 11 2019

stella.stamenova accepted D63102: Fix some lit test ResourceWarnings on Windows.

LGTM

Jun 11 2019, 9:18 AM · Restricted Project

Jun 4 2019

stella.stamenova accepted D62759: Fix lit tests on Windows related to CR.
Jun 4 2019, 3:46 PM · Restricted Project
stella.stamenova added inline comments to D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.
Jun 4 2019, 2:23 PM · Restricted Project, Restricted Project
stella.stamenova accepted D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Jun 4 2019, 2:14 PM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Jun 4 2019, 1:59 PM · Restricted Project, Restricted Project
stella.stamenova accepted D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.

LGTM

Jun 4 2019, 1:52 PM · Restricted Project, Restricted Project
stella.stamenova requested changes to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

I don't think that this would apply very well to Visual Studio with the current change because it is likely that if you are using VS to build LLDB, you also used VS to build the dependencies. Even for xcode, I am sure that there are people who build the dependencies standalone with xcode and then are building LLDB standalone with xcode, so any change that absolutely treats the scenario as one or the other is going to break someone.

Jun 4 2019, 9:54 AM · Restricted Project, Restricted Project

May 29 2019

stella.stamenova committed rG83c28abdb252: lit: modernize the lit configuration for the lit tests (authored by stella.stamenova).
lit: modernize the lit configuration for the lit tests
May 29 2019, 11:06 AM
stella.stamenova committed rL361998: lit: modernize the lit configuration for the lit tests.
lit: modernize the lit configuration for the lit tests
May 29 2019, 11:05 AM
stella.stamenova closed D61798: lit: modernize the lit configuration for the lit tests.
May 29 2019, 11:05 AM · Restricted Project

May 28 2019

stella.stamenova added a comment to D60095: [LLD][COFF] Early load PDB type server files.

I am not very familiar with the lldb-mi tests specifically, but it looks like they require python to run (and are marked as unsupported otherwise):

May 28 2019, 2:04 PM · Restricted Project
stella.stamenova added a comment to D60095: [LLD][COFF] Early load PDB type server files.

This change broke one of the tests on the Windows LLDB bot:

May 28 2019, 12:33 PM · Restricted Project
stella.stamenova added a comment to D55056: [CMake] Default options for faster executables on MSVC.

This caused failures on the windows bot again:

May 28 2019, 8:05 AM · Restricted Project

May 23 2019

stella.stamenova added a comment to D62337: [lldb] followup fix for https://reviews.llvm.org/D62305.

This looks good - it is still not all though. Even after Jonas' change the build failed with the same error elsewhere.

May 23 2019, 11:53 AM · Restricted Project
stella.stamenova added a comment to D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.

It looks like this was not enough and the build is still broken. Please revert your change or fix it and then keep an eye on the Buildbot to make sure it turns to green again. Once it's broken, it won't continue sending failure emails, so you have to monitor it to make sure your change fixed it.

May 23 2019, 9:48 AM · Restricted Project
stella.stamenova added inline comments to D55056: [CMake] Default options for faster executables on MSVC.
May 23 2019, 8:57 AM · Restricted Project

May 17 2019

stella.stamenova committed rG5bac70634326: [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt (authored by stella.stamenova).
[CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt
May 17 2019, 11:51 AM
stella.stamenova committed rL361064: [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt.
[CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt
May 17 2019, 11:50 AM
stella.stamenova committed rLLDB361064: [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt.
[CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt
May 17 2019, 11:50 AM

May 10 2019

stella.stamenova added a comment to rC360463: Improve interface of APValuePathEntry..

Either this change or your other APValue change broke the windows bot:

May 10 2019, 3:17 PM
stella.stamenova created D61798: lit: modernize the lit configuration for the lit tests.
May 10 2019, 12:27 PM · Restricted Project

May 9 2019

stella.stamenova committed rG46b9d19cc09a: Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does… (authored by stella.stamenova).
Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does…
May 9 2019, 1:21 PM
stella.stamenova committed rL360373: Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does….
Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does…
May 9 2019, 1:20 PM
stella.stamenova committed rGdde1d9a6b775: Fix TestVSCode_attach on Linux (authored by stella.stamenova).
Fix TestVSCode_attach on Linux
May 9 2019, 12:49 PM
stella.stamenova added a comment to D60153: Re-enable most lldb-vscode tests on Linux..

Thanks, Pavel! I tested out the proposed change and all of our Ubuntu bots now work. I've committed it as well.

May 9 2019, 12:49 PM · Restricted Project, Restricted Project
stella.stamenova committed rL360371: Fix TestVSCode_attach on Linux.
Fix TestVSCode_attach on Linux
May 9 2019, 12:47 PM
stella.stamenova committed rLLDB360371: Fix TestVSCode_attach on Linux.
Fix TestVSCode_attach on Linux
May 9 2019, 12:47 PM
stella.stamenova committed rGbc9e0866933c: Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED… (authored by stella.stamenova).
Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED…
May 9 2019, 12:44 PM