Page MenuHomePhabricator
Feed Advanced Search

Dec 7 2015

ted committed rL254931: Fix watchpoint check to use watchpoint ranges.
Fix watchpoint check to use watchpoint ranges
Dec 7 2015, 11:42 AM
ted closed D14932: Fix watchpoint check to use watchpoint ranges.
Dec 7 2015, 11:41 AM

Nov 23 2015

ted retitled D14932: Fix watchpoint check to use watchpoint ranges from to Fix watchpoint check to use watchpoint ranges.
Nov 23 2015, 12:48 PM
ted abandoned D10247: Fix crash when cu_comp_dir parameter to DWARFDebugLine::ParseSupportFiles() is an empty string.

Handled by another patch

Nov 23 2015, 12:34 PM

Sep 11 2015

ted removed a reviewer for D12652: [Static Analyzer] Lambda support.: ted.
Sep 11 2015, 10:26 AM

Aug 26 2015

ted added a comment to D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053..

I tried deleting the target and setting the platform to the host platform at the end of the test in TestDisassemble_VST1_64.py, but that didn't solve the problem.

Aug 26 2015, 10:01 AM
ted added a comment to D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053.

The problem with this test is it gets python in a bad state, so after it's run, all tests after error out. It runs fine on its own, but something like:
dotest.py python_api/

Aug 26 2015, 9:56 AM
ted added a comment to D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053.

The error also happens on Linux; this test should be turned off everywhere.

Aug 26 2015, 9:50 AM

Aug 25 2015

ted added a comment to D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053..

My guess is the target create is failing. This line in the test:

Aug 25 2015, 12:26 PM

Aug 24 2015

ted added a comment to D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053..

This is essentially reverting http://reviews.llvm.org/rL237053 , so we'd go back to the problem with it - LLDB won't be able to set the platform based on the architecture in the target binary, but will use the currently selected platform, even if it's not compatible.

Aug 24 2015, 6:12 PM

Jul 13 2015

ted added a comment to D11129: Fix for remote-linux test fails: use currently selected platform on target launch.

I agree that the current implementation is annoying with using the platform selected at target creation time, but changing the platform for a target after it is created might be dangerous because it can cache information from the platform.

Jul 13 2015, 6:43 PM

Jun 4 2015

ted retitled D10247: Fix crash when cu_comp_dir parameter to DWARFDebugLine::ParseSupportFiles() is an empty string from to Fix crash when cu_comp_dir parameter to DWARFDebugLine::ParseSupportFiles() is an empty string.
Jun 4 2015, 9:13 AM

May 14 2015

ted added a comment to D9782: Only check for _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF.

This codepath also fixes mangling issues with Hexagon binaries. Please add

|| (arch.GetTriple().GetMachine() == llvm::Triple::hexagon)

to the if, to pick up the fix for Hexagon.

May 14 2015, 3:26 PM

May 13 2015

ted accepted D9764: Sync PlatformFreeBSD::GetSupportedArchitectureAtIndex with PlatformLinux.

LGTM

May 13 2015, 4:44 PM
ted committed rL237278: Change Linux Platform to support non-host Linux architectures.
Change Linux Platform to support non-host Linux architectures
May 13 2015, 11:56 AM
ted closed D9683: Change Linux Platform to support non-host Linux architectures.
May 13 2015, 11:56 AM
ted added a comment to D9754: Enable workaround for finding functions in global namespace on linux binaries on all hosts..

This affects Windows and Hexagon as well, FYI. I believe this will fix bug 22177.

May 13 2015, 11:34 AM
ted added a comment to D8749: Fix selecting the Platform in TargetList::CreateTargetInternal().

I wonder if it's reporting not compatible because the platform isn't connected yet, and currently the non-host linux platform needs to be connected.

May 13 2015, 10:04 AM
ted updated the diff for D9683: Change Linux Platform to support non-host Linux architectures.

Adding table after check for remote platform, as requested.

May 13 2015, 10:02 AM
ted added a comment to D8749: Fix selecting the Platform in TargetList::CreateTargetInternal().

This change will look for a compatible platform if the current platform is not compatible with the current architecture.

May 13 2015, 9:54 AM

May 12 2015

ted committed rL237162: Windows: fix bug in getcwd() and add chdir()..
Windows: fix bug in getcwd() and add chdir().
May 12 2015, 11:51 AM
ted added a comment to D9672: Call remote platform GetSupportedArchAtIndex if connected to remote..

The problem with querying PlatformGDBRemote is it's only valid if you're connected to the remote platform. I'm trying to set the Platform when creating a target, so there is no connection yet.

May 12 2015, 11:28 AM
ted added a comment to D9683: Change Linux Platform to support non-host Linux architectures.

What I'm trying to do is allow a user to load an arbitrary Linux binary and have LLDB select the Remote Linux Platform, if the architecture is one of our supported Linuxes. My goal is to be able to remotely debug Hexagon Linux binaries on Windows.

May 12 2015, 11:11 AM

May 11 2015

ted added a comment to D9437: Add Hexagon packet support to ThreadPlanStepRange.

That's a good point - breakpoints set on functions or source lines will get the start of a packet, but if the user sets a breakpoint on an address we should fix that to set it at the start of the packet containing that address.

May 11 2015, 2:54 PM
ted retitled D9683: Change Linux Platform to support non-host Linux architectures from to Change Linux Platform to support non-host Linux architectures.
May 11 2015, 2:50 PM
ted committed rL237053: Fix selecting the Platform in TargetList::CreateTargetInternal().
Fix selecting the Platform in TargetList::CreateTargetInternal()
May 11 2015, 2:27 PM
ted committed rL237052: Remove Triple Vendor check when creating Linux Platform.
Remove Triple Vendor check when creating Linux Platform
May 11 2015, 2:25 PM
ted committed rL237047: Add Hexagon packet support to ThreadPlanStepRange.
Add Hexagon packet support to ThreadPlanStepRange
May 11 2015, 2:16 PM

May 8 2015

ted closed D9437: Add Hexagon packet support to ThreadPlanStepRange.
May 8 2015, 12:14 PM

May 7 2015

ted added a comment to D9437: Add Hexagon packet support to ThreadPlanStepRange.

InstructionList::GetIndexOfNextBranchInstruction() is only called from one spot, ThreadPlanStepRange::SetNextBranchBreakpoint(), and it needs a Target to get the the ArchSpec to check for Hexagon. I could change it to only do the check if the Target wasn't nullptr, but that seems unnecessary to me.

May 7 2015, 3:27 PM
ted updated the diff for D9437: Add Hexagon packet support to ThreadPlanStepRange.

Changed parameter from ProcessSP to Target, as requested.

May 7 2015, 2:45 PM

May 6 2015

ted updated the diff for D9437: Add Hexagon packet support to ThreadPlanStepRange.

Code moved to GetIndexOfNextBranchInstruction(), as requested.

May 6 2015, 4:05 PM

May 4 2015

ted updated subscribers of D9404: Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation.
May 4 2015, 11:13 AM
ted added a comment to D9404: Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation.

The problem with a Hexagon-specific testcase is it would need to use the Hexagon simulator, which is not currently publicly available. We expect it to be available later this year.

May 4 2015, 9:38 AM

May 1 2015

ted retitled D9437: Add Hexagon packet support to ThreadPlanStepRange from to Add Hexagon packet support to ThreadPlanStepRange.
May 1 2015, 9:35 AM

Apr 30 2015

ted closed D9300: Windows: fix bug in getcwd() and add chdir()..
Apr 30 2015, 9:42 AM

Apr 29 2015

ted added a comment to D9300: Windows: fix bug in getcwd() and add chdir()..

Whoops - missed the do loop upping the size of the buffer to the return value. But I can't find any documentation saying that GetCurrentDirectory() supports paths > MAX_PATH. Are we sure it does?

Apr 29 2015, 10:25 AM
ted added a comment to D9300: Windows: fix bug in getcwd() and add chdir()..

llvm::sys::fs::current_path() doesn't handle paths > MAX_PATH-1:

Apr 29 2015, 10:16 AM

Apr 27 2015

ted updated the diff for D9300: Windows: fix bug in getcwd() and add chdir()..

Replace erroneously removed comment

Apr 27 2015, 4:06 PM
ted updated the diff for D9300: Windows: fix bug in getcwd() and add chdir()..

Changed getcwd() and chdir() to use _getcwd() and _chdir().

Apr 27 2015, 4:01 PM
ted retitled D9300: Windows: fix bug in getcwd() and add chdir(). from to Windows: fix bug in getcwd() and add chdir()..
Apr 27 2015, 10:28 AM

Apr 17 2015

ted closed D8749: Fix selecting the Platform in TargetList::CreateTargetInternal().
Apr 17 2015, 3:09 PM

Apr 14 2015

ted added a comment to D8749: Fix selecting the Platform in TargetList::CreateTargetInternal().

Friendly ping. This behaves as expected - selecting a compatible platform will use it; selecting an incompatible platform and lldb will find a compatible one.

Apr 14 2015, 3:01 PM

Apr 13 2015

ted added a comment to D8964: Add comments to LLDB-MI disassembly..

The spaces bother me too. Ewan, please remove them.

Apr 13 2015, 8:28 AM

Apr 10 2015

ted added a comment to D8964: Add comments to LLDB-MI disassembly..
In D8964#154945, @ted wrote:

The comment isn't there to get line and file; it's there to get symbolic branch targets.

If so then create a separate field named "comment" and use it for comments. Also, update the MIExtensions.txt please.

Apr 10 2015, 2:54 PM
ted closed D8709: Change Linux Platform to support non-host Linux architectures.
Apr 10 2015, 2:25 PM
ted closed D8742: Remove Triple Vendor check when creating Linux Platform.
Apr 10 2015, 2:22 PM
ted added a comment to D8964: Add comments to LLDB-MI disassembly..

The comment isn't there to get line and file; it's there to get symbolic branch targets.

Apr 10 2015, 1:35 PM
ted added a comment to D8979: Making linking against Python simpler on Windows.

So if I specify -DPYTHON_HOME:STRING=c:\pythonfoo, it will pick up the python includes and library from c:\pythonfoo, and if LLDB_RELOCATABLE_PYTHON is set to 0, lldb will use c:\pythonfoo as PYTHONHOME?

Apr 10 2015, 1:00 PM

Apr 6 2015

ted added a comment to D8749: Fix selecting the Platform in TargetList::CreateTargetInternal().

This will do that - platform_sp is the currently selected platform, and both calls to SetSelectedPlatform() are gated by !platform_sp->IsCompatibleArchitecture(), so it will only search for a new platform if the architecture is not compatible with the currently selected platform.

Apr 6 2015, 4:02 PM
ted committed rL234244: Fix check for options in "command alias".
Fix check for options in "command alias"
Apr 6 2015, 2:58 PM
ted closed D8844: Fix check for options in "command alias".
Apr 6 2015, 2:58 PM
ted closed D8844: Fix check for options in "command alias" by committing rL234244: Fix check for options in "command alias".
Apr 6 2015, 2:58 PM
ted retitled D8844: Fix check for options in "command alias" from to Fix check for options in "command alias".
Apr 6 2015, 10:15 AM

Apr 3 2015

ted added a comment to D8749: Fix selecting the Platform in TargetList::CreateTargetInternal().

Jim, if I select a platform, then load a target that the platform is not compatible with, should it use the incompatible platform, or find one that is compatible?

Apr 3 2015, 3:00 PM
ted added a comment to D8742: Remove Triple Vendor check when creating Linux Platform.

Friendly Ping

Apr 3 2015, 2:59 PM
ted added a comment to D8709: Change Linux Platform to support non-host Linux architectures.

Friendly Ping

Apr 3 2015, 2:58 PM

Mar 31 2015

ted added a comment to D8749: Fix selecting the Platform in TargetList::CreateTargetInternal().

It should use the current Platform, but only if it is compatible with the target's architecture, right? I believe it does this already, because any change of platform_sp is gated by if(!platform_sp->IsCompatibleArchitecture()).

Mar 31 2015, 3:36 PM
ted retitled D8749: Fix selecting the Platform in TargetList::CreateTargetInternal() from to Fix selecting the Platform in TargetList::CreateTargetInternal().
Mar 31 2015, 2:50 PM
ted retitled D8742: Remove Triple Vendor check when creating Linux Platform from to Remove Triple Vendor check when creating Linux Platform.
Mar 31 2015, 11:59 AM

Mar 30 2015

ted updated the diff for D8709: Change Linux Platform to support non-host Linux architectures.

Added mips.

Mar 30 2015, 3:51 PM
ted updated subscribers of D8709: Change Linux Platform to support non-host Linux architectures.
Mar 30 2015, 2:51 PM
ted retitled D8709: Change Linux Platform to support non-host Linux architectures from to Change Linux Platform to support non-host Linux architectures.
Mar 30 2015, 2:50 PM

Mar 26 2015

ted added a comment to D8454: Fix TestGdbRemote* on remote Linux.

I'm seeing less failures, but I'm still seeing some with this patch:

Mar 26 2015, 12:24 PM

Mar 20 2015

ted added a comment to D8381: Make lldb-mi handle only MI commands.

I would like ctrl-c to not exit lldb-mi. "quit" exits, and it's too easy to hit ctrl-c when the target isn't running and accidentally exit lldb-mi.

Mar 20 2015, 9:49 AM
ted added a comment to D8381: Make lldb-mi handle only MI commands.

gdb handles command line gdb and MI in one executable. I think lldb should do the same. We ship one executable, called hexagon-lldb, that is actually lldb-mi. Pass --interpreter and it runs MI, otherwise it runs the standard LLDB CLI.

Mar 20 2015, 7:47 AM

Dec 17 2014

ted updated subscribers of D6702: Work around for Visual Studio 2013 compiler crash.
Dec 17 2014, 9:45 AM