Page MenuHomePhabricator
Feed Advanced Search

Thu, Feb 13

ted committed rGefef165f82cb: Clean up hexagon builder after object-emission removal (authored by ted).
Clean up hexagon builder after object-emission removal
Thu, Feb 13, 11:20 AM
ted committed rGcecc185166c0: Add REQUIRES: x86 so this won't be run if x86 is not available. (authored by ted).
Add REQUIRES: x86 so this won't be run if x86 is not available.
Thu, Feb 13, 9:20 AM

Mon, Feb 10

ted committed rG7683a084de6b: Remove lit feature object-emission (authored by ted).
Remove lit feature object-emission
Mon, Feb 10, 1:58 PM
ted closed D73568: Remove lit feature object-emission.
Mon, Feb 10, 1:58 PM · Restricted Project
ted updated the diff for D73568: Remove lit feature object-emission.

File llvm/test/DebugInfo/X86/vla.ll was modified so the diff did not apply anymore. object-emission was removed from it, so I'm removing it from this diff.

Mon, Feb 10, 12:45 PM · Restricted Project
ted committed rG6fd818c5a9c5: Don't fail step out if remote server doesn't implement qMemoryRegionInfo (authored by ted).
Don't fail step out if remote server doesn't implement qMemoryRegionInfo
Mon, Feb 10, 11:42 AM
ted closed D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.
Mon, Feb 10, 11:41 AM · Unknown Object (Project)

Wed, Feb 5

ted added a comment to D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.

@jingham friendly ping

Wed, Feb 5, 1:12 PM · Unknown Object (Project)
ted added a comment to D73568: Remove lit feature object-emission.

Friendly ping

Wed, Feb 5, 1:12 PM · Restricted Project

Tue, Jan 28

ted reopened D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.
Tue, Jan 28, 1:55 PM · Unknown Object (Project)
ted updated the diff for D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.

Removed the code that sets m_constructor_errors when GetLoadAddressPermissions returns False, as requested by @jingham .

Tue, Jan 28, 1:55 PM · Unknown Object (Project)
ted added a comment to D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.

Wow @jingham you posted your comment and I landed the patch at the same time!

Tue, Jan 28, 1:11 PM · Unknown Object (Project)
ted committed rG04488c485a88: Don't fail step out if remote server doesn't implement qMemoryRegionInfo (authored by ted).
Don't fail step out if remote server doesn't implement qMemoryRegionInfo
Tue, Jan 28, 11:47 AM
ted closed D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.
Tue, Jan 28, 11:46 AM · Unknown Object (Project)
Herald added a reviewer for D73568: Remove lit feature object-emission: whitequark.
Tue, Jan 28, 11:22 AM · Restricted Project

Jan 10 2020

ted added a reviewer for D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo: mossberg.
Jan 10 2020, 9:23 AM · Unknown Object (Project)
ted added a comment to D71372: [lldb] Add additional validation on return address in 'thread step-out'.
In D71372#1813142, @ted wrote:
In D71372#1810687, @ted wrote:

I've got another failure case for this. If the remote gdbserver doesn't implement qMemoryRegionInfo or qXfer:memory-map:read, thread step-out will fail.
....

That's a good point Ted. I think we should give targets which don't support fetching permissions the benefit of the doubt, and treat all memory as potentially executable. Would removing the return statement from the if(!GetLoadAddressPermissions) branch solve your problem? If so, can you whip up a patch for that?

Removing the return statement fixes the issue. I'll put up a patch. Keeping the m_constructor_errors.Printf line doesn't cause a failure; it might be useful to keep that in case the breakpoint can't be created for other reasons. What do you think?

I don't care much either way.. Since you have this kind of a target around, you can judge whether printing this error/warning after each "finish" would be useful or just annoying. Another possibility would be to don't print the error to the command output, but still emit something into the log...

Jan 10 2020, 8:25 AM · Unknown Object (Project)
ted added reviewers for D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo: labath, jingham, clayborg.
Jan 10 2020, 8:25 AM · Unknown Object (Project)
ted created D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.
Jan 10 2020, 8:24 AM · Unknown Object (Project)

Jan 9 2020

ted added a comment to D71372: [lldb] Add additional validation on return address in 'thread step-out'.
In D71372#1810687, @ted wrote:

I've got another failure case for this. If the remote gdbserver doesn't implement qMemoryRegionInfo or qXfer:memory-map:read, thread step-out will fail.
....

That's a good point Ted. I think we should give targets which don't support fetching permissions the benefit of the doubt, and treat all memory as potentially executable. Would removing the return statement from the if(!GetLoadAddressPermissions) branch solve your problem? If so, can you whip up a patch for that?

Jan 9 2020, 2:37 PM · Unknown Object (Project)

Jan 8 2020

ted added a comment to D71372: [lldb] Add additional validation on return address in 'thread step-out'.

I've got another failure case for this. If the remote gdbserver doesn't implement qMemoryRegionInfo or qXfer:memory-map:read, thread step-out will fail.

Jan 8 2020, 12:32 PM · Unknown Object (Project)
ted added a comment to D69119: Modernize the rest of the Find.* API (NFC).
Jan 8 2020, 12:32 PM · Unknown Object (Project)

Apr 4 2019

ted added a comment to D60152: Fix and simplify PrepareCommandsForSourcing.

llvm/tools/lldb/tools/driver/Driver.cpp:495:12: error: comparison of integers of different signs: 'ssize_t' (aka 'long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]

if (nrwr != commands_size) {
    ~~~~ ^  ~~~~~~~~~~~~~

1 error generated.

Apr 4 2019, 11:38 AM · Restricted Project

Mar 25 2019

ted added a comment to D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..

This doesn't look correct to me - it looks like there are 1 too many #endifs. I think the one at line 179 should be removed - it should have been replaced by the #else that is at line 180.

Mar 25 2019, 1:17 PM · Unknown Object (Project), Restricted Project

Feb 1 2019

ted added a comment to D57552: Handle "." in target.source-map in PathMapListing::FindFiles.

That sounds like it will have to be fixed somewhere else, and not part of this patch then. Can you file a bug to get that fixed?

Feb 1 2019, 11:36 AM · Restricted Project, Unknown Object (Project)
ted added a comment to D57552: Handle "." in target.source-map in PathMapListing::FindFiles.
In D57552#1380782, @ted wrote:

FYI, @jingham , this is also an issue with DYLD plugins, if the file in the link map starts with ".". "image search-paths add . /path/to/my/libraries" fails in this case, because "./library.so" gets changed to "library.so".

This should fix that issue as well, since image search-paths are also PathMappingLists. I don't see any tests for this, however. Do you have something handy you could turn into a test?

Feb 1 2019, 10:39 AM · Restricted Project, Unknown Object (Project)
Herald added a project to D55332: [CMake] Python bindings generation polishing: Unknown Object (Project).

@sgraenitz I've found an issue with this patch, using the Visual Studio 2015 generator.

Feb 1 2019, 8:16 AM · Unknown Object (Project)
ted added a comment to D57552: Handle "." in target.source-map in PathMapListing::FindFiles.

FYI, @jingham , this is also an issue with DYLD plugins, if the file in the link map starts with ".".

Feb 1 2019, 7:40 AM · Restricted Project, Unknown Object (Project)

Sep 10 2018

ted added a comment to D51162: [PDB] Restore AST from PDB symbols.

Another issue:

Sep 10 2018, 2:55 PM · Unknown Object (Project)
ted committed rLLDB341849: Fix raw address breakpoints not resolving.
Fix raw address breakpoints not resolving
Sep 10 2018, 11:20 AM
ted committed rL341849: Fix raw address breakpoints not resolving.
Fix raw address breakpoints not resolving
Sep 10 2018, 11:20 AM
ted closed D51816: Fix raw address breakpoints not resolving.
Sep 10 2018, 11:20 AM

Sep 7 2018

ted updated the diff for D51816: Fix raw address breakpoints not resolving.

Added a test to TestAddressBreakpoints.py that sets an address breakpoint before launch, launches, and checks to see if the breakpoint was hit.

Sep 7 2018, 4:04 PM
ted added a comment to D51816: Fix raw address breakpoints not resolving.

Yes, I'll add a new test to TestAddressBreakpoints.py.

Sep 7 2018, 3:05 PM
ted created D51816: Fix raw address breakpoints not resolving.
Sep 7 2018, 2:17 PM

Apr 20 2018

ted added a comment to D45333: WIP: [LIT] Have lit run the lldb test suite.

@JDevlieghere I'm seeing the same issue as @alberto_magni . The Visual Studio cmake generator gives errors. We're reverting it internally, but it needs to be fixed or reverted ASAP.

Apr 20 2018, 8:25 AM

Feb 23 2018

ted added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

I believe lldb-server does not work around breakpoint opcodes during writing (it does for reading), but that can be fixed, of course.

Feb 23 2018, 1:41 PM
ted added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

Traditionally, remote gdbservers handle memory operations that overlap a software breakpoint. Writes get the new value saved off, and reads get the breakpoint opcode replaced by the saved value.

Feb 23 2018, 1:16 PM

Jan 10 2018

ted added a comment to D41533: Advanced guessing of rendezvous breakpoint.

Thanks for adding me, Pavel.

Jan 10 2018, 9:43 AM · Unknown Object (Project)

Oct 24 2017

ted added a comment to D39215: Default to using in-tree clang for building test executables.

We build lldb, clang and tools for Hexagon only, and call them hexagon-lldb, hexagon-clang, etc. The test infrastructure is smart enough to pick up hexagon-lldb-mi if we tell it to run with hexagon-lldb using --executable; will it be smart enough to run an in-tree hexagon-clang?

Oct 24 2017, 8:58 AM

Oct 11 2017

ted committed rL315524: Add cases for new type DependentAddressSpace, added in r314649.
Add cases for new type DependentAddressSpace, added in r314649
Oct 11 2017, 3:42 PM
ted committed rL315496: Remove default case from switch..
Remove default case from switch.
Oct 11 2017, 12:38 PM

Sep 20 2017

ted committed rL313799: Fix warning caused by new clang::BuiltinType::Float16 added in r312794.
Fix warning caused by new clang::BuiltinType::Float16 added in r312794
Sep 20 2017, 12:18 PM

Sep 7 2017

ted committed rL312726: Fix lldb-mi test data_read_memory_bytes_global.
Fix lldb-mi test data_read_memory_bytes_global
Sep 7 2017, 9:26 AM
ted closed D37533: Fix lldb-mi test data_read_memory_bytes_global.
Sep 7 2017, 9:25 AM

Sep 6 2017

ted added a comment to D37533: Fix lldb-mi test data_read_memory_bytes_global.

Tested with clang 3.8 on top-of-tree lldb-mi on Ubuntu 14.

Sep 6 2017, 1:48 PM
ted created D37533: Fix lldb-mi test data_read_memory_bytes_global.
Sep 6 2017, 1:46 PM

Aug 31 2017

ted committed rL312270: lldb-mi: -var-update can hang when traversing complex types with pointers.
lldb-mi: -var-update can hang when traversing complex types with pointers
Aug 31 2017, 12:23 PM
ted closed D37154: lldb-mi: -var-update can hang when traversing complex types with pointers.
Aug 31 2017, 12:23 PM
ted added a comment to D37154: lldb-mi: -var-update can hang when traversing complex types with pointers.

We want to go down into a pointer if it's the original parent, but not into a child that's a pointer. To avoid skipping children of a top-level pointer/reference, I think we need to do the type check in the loop.

Aug 31 2017, 9:42 AM

Aug 30 2017

ted updated the diff for D37154: lldb-mi: -var-update can hang when traversing complex types with pointers.

Updated with Greg's suggestion.

Aug 30 2017, 2:44 PM
ted updated the diff for D37154: lldb-mi: -var-update can hang when traversing complex types with pointers.

Added check for reference types, as Greg suggested.

Aug 30 2017, 2:03 PM

Aug 25 2017

ted created D37154: lldb-mi: -var-update can hang when traversing complex types with pointers.
Aug 25 2017, 10:58 AM

May 17 2017

ted committed rL303278: Fix error string set in AddName to take a StringRef..
Fix error string set in AddName to take a StringRef.
May 17 2017, 11:02 AM

Feb 3 2017

ted added a reviewer for D29513: Add -gdb-set and -gdb-show support for non-stop to lldb-mi: ki.stfu.
Feb 3 2017, 3:14 PM
ted edited reviewers for D29513: Add -gdb-set and -gdb-show support for non-stop to lldb-mi, added: jingham; removed: ki.stfu.
Feb 3 2017, 2:05 PM
ted updated subscribers of D29513: Add -gdb-set and -gdb-show support for non-stop to lldb-mi.
Feb 3 2017, 2:05 PM
ted added a reviewer for D29513: Add -gdb-set and -gdb-show support for non-stop to lldb-mi: ki.stfu.
Feb 3 2017, 2:04 PM
ted created D29513: Add -gdb-set and -gdb-show support for non-stop to lldb-mi.
Feb 3 2017, 1:32 PM

Oct 12 2016

ted added a comment to D23802: gdb-remote: Make the sequence mutex non-recursive.

I'm seeing the same issue as Nitesh, except in a different spot. The Hexagon Simulator doesn't support QSaveRegisterState, so lldb calls GDBRemoteRegisterContext::ReadAllRegisterValues. It gets a lock on the communication client, then calls ReadAllRegisters, which tries to get a lock on the communication client, and fails (hangs on Linux, crashes on Windows).

Oct 12 2016, 10:33 AM

Sep 30 2016

ted accepted D25137: [lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output.

The problem this scenario has is asynchronous output from 2 different sources. The original fix made Windows (or any lldb without libedit) much better, but I think most non-Windows builds will use libedit, because it's extremely useful. lldb-mi has a different set of constraints; the position of the prompt isn't as important, since users won't use it as a cue to tell when the debugger can accept more input.

Sep 30 2016, 3:39 PM

Jun 23 2016

ted added a comment to D21649: Don't create unnecessary remote platforms.

The Hexagon platform (currently in-house only) acts like the ios simulator platform, in that it doesn't connect - it fixes up the command line, then launches the Hexagon simulator (based on the debugserver launch code in the gdb-remote process plugin).

Jun 23 2016, 3:40 PM

May 11 2016

ted committed rL269250: Keep original source path and mapped path in LineEntry.
Keep original source path and mapped path in LineEntry
May 11 2016, 3:53 PM
ted closed D20135: Keep original source path and mapped path in LineEntry.
May 11 2016, 3:52 PM
ted updated the diff for D20135: Keep original source path and mapped path in LineEntry.

Addressed Jim's comments.

May 11 2016, 2:44 PM

May 10 2016

ted retitled D20135: Keep original source path and mapped path in LineEntry from to Keep original source path and mapped path in LineEntry.
May 10 2016, 2:20 PM
ted abandoned D20035: Add source file mapping to inline frames' SymbolContext line_entry.file.

Problem will be fixed in another way.

May 10 2016, 2:03 PM

May 6 2016

ted retitled D20035: Add source file mapping to inline frames' SymbolContext line_entry.file from to Add source file mapping to inline frames' SymbolContext line_entry.file.
May 6 2016, 3:04 PM

Mar 30 2016

ted accepted D18531: Allow gdbremote process to read modules from memory.
Mar 30 2016, 11:21 AM
ted added a comment to D18531: Allow gdbremote process to read modules from memory.

Thanks for adding me, Tamas.

Mar 30 2016, 11:20 AM

Mar 25 2016

ted retitled D18484: Change windows cmake to require debug libraries for a debug build, otherwise release libraries from to Change windows cmake to require debug libraries for a debug build, otherwise release libraries.
Mar 25 2016, 3:31 PM

Mar 24 2016

ted committed rL264332: Fix for missing prompt on Windows.
Fix for missing prompt on Windows
Mar 24 2016, 1:40 PM
ted closed D18335: Fix for missing prompt on Windows.
Mar 24 2016, 1:40 PM

Mar 23 2016

ted added a comment to D18335: Fix for missing prompt on Windows.

Adrian and I worked out what is going on:

Mar 23 2016, 4:04 PM
ted updated the diff for D18335: Fix for missing prompt on Windows.

Updated to change cursor position before async output so old prompt is overwritten.

Mar 23 2016, 12:24 PM

Mar 21 2016

ted added a comment to D18335: Fix for missing prompt on Windows.

Without the patch I'm seeing the original prompt printed after the command, in a line like this:

Mar 21 2016, 3:55 PM
ted retitled D18335: Fix for missing prompt on Windows from to Fix for missing prompt on Windows.
Mar 21 2016, 2:27 PM

Mar 9 2016

ted committed rL263066: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp.
Fix "ninja check-lldb" crash in IRExecutionUnit.cpp
Mar 9 2016, 2:10 PM
ted closed D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp.
Mar 9 2016, 2:10 PM
ted updated the diff for D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp.

Updated to address Jim's comments.

Mar 9 2016, 1:01 PM
ted added a comment to D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp.

So you'd like to see this function get the address of a function that it
finds in either symbols or debug info?

Mar 9 2016, 11:37 AM

Mar 8 2016

ted added a comment to D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp.

The change is to guard against the case where candidate_sc.symbol is nullptr.

Mar 8 2016, 2:46 PM
ted updated the diff for D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp.

Updated to use early-out as requested

Mar 8 2016, 2:46 PM

Mar 3 2016

ted retitled D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp from to Fix "ninja check-lldb" crash in IRExecutionUnit.cpp.
Mar 3 2016, 10:58 AM

Mar 1 2016

ted committed rL262407: Fix bug with function resolution when using IR Interpreter.
Fix bug with function resolution when using IR Interpreter
Mar 1 2016, 1:58 PM
ted closed D17745: Fix bug with function resolution when using IR Interpreter.
Mar 1 2016, 1:58 PM
ted updated the diff for D17745: Fix bug with function resolution when using IR Interpreter.

Updated to address Sean's comments

Mar 1 2016, 1:46 PM

Feb 29 2016

ted retitled D17745: Fix bug with function resolution when using IR Interpreter from to Fix bug with function resolution when using IR Interpreter.
Feb 29 2016, 5:17 PM

Dec 11 2015

ted committed rL255374: Remove hardcoded registers from Hexagon ABI.
Remove hardcoded registers from Hexagon ABI
Dec 11 2015, 1:56 PM
ted closed D15457: Remove hardcoded registers from Hexagon ABI.
Dec 11 2015, 1:55 PM
ted updated the diff for D15457: Remove hardcoded registers from Hexagon ABI.

Updated to check for invalid register numbers.

Dec 11 2015, 12:05 PM
ted retitled D15457: Remove hardcoded registers from Hexagon ABI from to Remove hardcoded registers from Hexagon ABI.
Dec 11 2015, 10:23 AM
ted committed rL255340: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it.
Change finishSwigPythonLLDB.py to copy six.py instead of simlink it
Dec 11 2015, 7:46 AM
ted closed D15422: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it.
Dec 11 2015, 7:46 AM

Dec 10 2015

ted added a comment to D15422: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it.
Dec 10 2015, 10:24 AM
ted updated subscribers of D15422: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it.
Dec 10 2015, 10:22 AM
ted retitled D15422: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it from to Change finishSwigPythonLLDB.py to copy six.py instead of simlink it.
Dec 10 2015, 9:59 AM
ted committed rL255268: Add Hexagon ABI to System Initialization.
Add Hexagon ABI to System Initialization
Dec 10 2015, 9:56 AM
ted closed D15347: Add Hexagon ABI to System Initialization.
Dec 10 2015, 9:56 AM

Dec 8 2015

ted retitled D15347: Add Hexagon ABI to System Initialization from to Add Hexagon ABI to System Initialization.
Dec 8 2015, 1:44 PM