Page MenuHomePhabricator
Feed Advanced Search

Yesterday

tpr added a comment to D74594: [AMDGPU] Fix some tests that did not specify -mcpu.

This got landed in a slightly different form because of conflicts with other sdiv64 etc tests.

Mon, Feb 17, 6:16 AM · Restricted Project
tpr committed rG1e926a9f9c51: [AMDGPU] Fix some tests that did not specify -mcpu (authored by tpr).
[AMDGPU] Fix some tests that did not specify -mcpu
Mon, Feb 17, 6:08 AM
tpr closed D74594: [AMDGPU] Fix some tests that did not specify -mcpu.
Mon, Feb 17, 6:07 AM · Restricted Project

Fri, Feb 14

tpr updated the diff for D74594: [AMDGPU] Fix some tests that did not specify -mcpu.

V2: Also added gfx1010 to memtime test.

Fri, Feb 14, 2:30 AM · Restricted Project
tpr added reviewers for D74594: [AMDGPU] Fix some tests that did not specify -mcpu: kzhuravl, rampitec.
Fri, Feb 14, 1:47 AM · Restricted Project
tpr created D74594: [AMDGPU] Fix some tests that did not specify -mcpu.
Fri, Feb 14, 1:45 AM · Restricted Project

Dec 13 2019

tpr committed rGfce1a6f5848d: Revert "AMDGPU: Try to commute sub of boolean ext" (authored by tpr).
Revert "AMDGPU: Try to commute sub of boolean ext"
Dec 13 2019, 4:54 AM
tpr added a reverting change for rG69fcfb7d3597: AMDGPU: Try to commute sub of boolean ext: rGfce1a6f5848d: Revert "AMDGPU: Try to commute sub of boolean ext".
Dec 13 2019, 4:54 AM
tpr closed D70978: Revert "AMDGPU: Try to commute sub of boolean ext".
Dec 13 2019, 4:54 AM · Restricted Project
tpr updated the diff for D70978: Revert "AMDGPU: Try to commute sub of boolean ext".
V3: Reinstated and fixed the removed test.
Dec 13 2019, 2:35 AM · Restricted Project

Dec 12 2019

tpr added a comment to D70978: Revert "AMDGPU: Try to commute sub of boolean ext".

Yes, sorry, I will do the test changes that Matt suggested so this can be approved and landed.

Dec 12 2019, 2:16 AM · Restricted Project

Dec 4 2019

tpr updated the diff for D70978: Revert "AMDGPU: Try to commute sub of boolean ext".

V2: Removed an existing test for the bogus fold.

Dec 4 2019, 12:44 AM · Restricted Project

Dec 3 2019

tpr added reviewers for D70978: Revert "AMDGPU: Try to commute sub of boolean ext": arsenm, rampitec.
Dec 3 2019, 1:11 PM · Restricted Project
tpr added a reverting change for rG69fcfb7d3597: AMDGPU: Try to commute sub of boolean ext: D70978: Revert "AMDGPU: Try to commute sub of boolean ext".
Dec 3 2019, 1:02 PM
tpr created D70978: Revert "AMDGPU: Try to commute sub of boolean ext".
Dec 3 2019, 1:02 PM · Restricted Project

Dec 2 2019

tpr committed rG3d5ba7c60f39: AMDGPU: Fixed indeterminate map iteration in SIPeepholeSDWA (authored by tpr).
AMDGPU: Fixed indeterminate map iteration in SIPeepholeSDWA
Dec 2 2019, 4:12 AM
tpr closed D70783: AMDGPU: Fixed indeterminate map iteration in SIPeepholeSDWA.
Dec 2 2019, 4:12 AM · Restricted Project

Nov 27 2019

tpr updated the diff for D70783: AMDGPU: Fixed indeterminate map iteration in SIPeepholeSDWA.

V2: Sorted includes alphabetically.

Nov 27 2019, 11:51 AM · Restricted Project
tpr added a comment to D70783: AMDGPU: Fixed indeterminate map iteration in SIPeepholeSDWA.

Did the problem manifest in any way?

Nov 27 2019, 11:23 AM · Restricted Project
tpr added reviewers for D70783: AMDGPU: Fixed indeterminate map iteration in SIPeepholeSDWA: SamWot, rampitec, nhaehnle.

No test because by definition it was indeterminate.

Nov 27 2019, 7:31 AM · Restricted Project
tpr created D70783: AMDGPU: Fixed indeterminate map iteration in SIPeepholeSDWA.
Nov 27 2019, 7:22 AM · Restricted Project

Nov 12 2019

tpr committed rG07ebd741546e: MCP: Fixed bug with dest overlapping copy source (authored by tpr).
MCP: Fixed bug with dest overlapping copy source
Nov 12 2019, 12:22 AM
tpr closed D69953: MCP: Fixed bug with dest overlapping copy source.
Nov 12 2019, 12:22 AM · Restricted Project

Nov 11 2019

tpr updated the diff for D69953: MCP: Fixed bug with dest overlapping copy source.

V3: Only bail if it is a copy and a partial def, to avoid spurious test changes.

Nov 11 2019, 6:41 AM · Restricted Project

Nov 8 2019

tpr added inline comments to D69953: MCP: Fixed bug with dest overlapping copy source.
Nov 8 2019, 8:17 AM · Restricted Project
tpr updated the diff for D69953: MCP: Fixed bug with dest overlapping copy source.

V2: Used modifiesRegister as suggested by Matt.

Nov 8 2019, 8:17 AM · Restricted Project
tpr committed rG0703db398929: [CostModel] Fixed isExtractSubvectorMask for undef index off end (authored by tpr).
[CostModel] Fixed isExtractSubvectorMask for undef index off end
Nov 8 2019, 7:49 AM
tpr closed D70005: [CostModel] Fixed isExtractSubvectorMask for undef index off end.
Nov 8 2019, 7:49 AM · Restricted Project
tpr updated subscribers of D70005: [CostModel] Fixed isExtractSubvectorMask for undef index off end.
Nov 8 2019, 5:56 AM · Restricted Project
tpr added a reviewer for D70005: [CostModel] Fixed isExtractSubvectorMask for undef index off end: RKSimon.
Nov 8 2019, 5:56 AM · Restricted Project
tpr added a comment to rL346510: [CostModel] Add SK_ExtractSubvector handling to getInstructionThroughput….

This is slightly broken for us. See D70005 for a fix.

Nov 8 2019, 5:49 AM
tpr created D70005: [CostModel] Fixed isExtractSubvectorMask for undef index off end.
Nov 8 2019, 5:49 AM · Restricted Project

Nov 7 2019

tpr added reviewers for D69953: MCP: Fixed bug with dest overlapping copy source: bogner, efriedma.
Nov 7 2019, 9:42 AM · Restricted Project
tpr created D69953: MCP: Fixed bug with dest overlapping copy source.
Nov 7 2019, 9:42 AM · Restricted Project

Oct 29 2019

tpr added a comment to D69557: AsmParser: Allow FMF on varargs call.

Does D69161 cover this change? If so, we could add the test there and fix the problem in 1 step.

I think this bug fix is orthogonal to D69161, which adds new functionality.

Oct 29 2019, 10:07 AM · Restricted Project
tpr added reviewers for D69557: AsmParser: Allow FMF on varargs call: spatel, hfinkel.
Oct 29 2019, 5:10 AM · Restricted Project
tpr created D69557: AsmParser: Allow FMF on varargs call.
Oct 29 2019, 5:01 AM · Restricted Project

Sep 30 2019

tpr updated the diff for D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.

V2: Better fix that does not accidentally allow pow() transforms.

Sep 30 2019, 11:43 AM · Restricted Project
tpr updated subscribers of D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.

@foad pointed out that this fix is wrong. TLI saying pow() is not supported means if we find a call to a function called pow() then we don't know its semantics. So I will push a revised fix.

Sep 30 2019, 11:06 AM · Restricted Project
tpr added reviewers for D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func: evandro, xbolva00.
Sep 30 2019, 9:35 AM · Restricted Project
tpr created D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.
Sep 30 2019, 9:33 AM · Restricted Project

Sep 23 2019

tpr committed rL372563: Request commit access for tpr.
Request commit access for tpr
Sep 23 2019, 2:21 AM

Sep 18 2019

tpr committed rG178611711122: [AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16 (authored by tpr).
[AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16
Sep 18 2019, 2:31 AM
tpr committed rL372208: [AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16.
[AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16
Sep 18 2019, 2:30 AM
tpr closed D67680: [AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16.
Sep 18 2019, 2:30 AM · Restricted Project

Sep 17 2019

tpr added a comment to D67680: [AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16.

LGTM. Can you also add a test for the mad case

Sep 17 2019, 3:06 PM · Restricted Project
tpr added reviewers for D67680: [AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16: arsenm, kzhuravl, rampitec, vpykhtin.
Sep 17 2019, 2:34 PM · Restricted Project
tpr created D67680: [AMDGPU] Allow FP inline constant in v_madak_f16 and v_fmaak_f16.
Sep 17 2019, 2:27 PM · Restricted Project

Sep 11 2019

tpr committed rGc26b3940c320: [TLI][AMDGPU] AMDPAL does not have library functions (authored by tpr).
[TLI][AMDGPU] AMDPAL does not have library functions
Sep 11 2019, 12:30 AM
tpr committed rL371592: [TLI][AMDGPU] AMDPAL does not have library functions.
[TLI][AMDGPU] AMDPAL does not have library functions
Sep 11 2019, 12:26 AM
tpr closed D67406: [TLI][AMDGPU] AMDPAL does not have tan function.
Sep 11 2019, 12:26 AM · Restricted Project

Sep 10 2019

tpr updated the diff for D67406: [TLI][AMDGPU] AMDPAL does not have tan function.

V2: Disable all library functions, not just tan.

Sep 10 2019, 12:09 PM · Restricted Project
tpr added inline comments to D67406: [TLI][AMDGPU] AMDPAL does not have tan function.
Sep 10 2019, 9:34 AM · Restricted Project
tpr added reviewers for D67406: [TLI][AMDGPU] AMDPAL does not have tan function: dlj, nhaehnle.
Sep 10 2019, 9:19 AM · Restricted Project
tpr created D67406: [TLI][AMDGPU] AMDPAL does not have tan function.
Sep 10 2019, 9:13 AM · Restricted Project

Sep 2 2019

tpr added a comment to D67003: AMDGPU: Don't put constants in .text for Mesa.

I just noticed that this already came up in D65813 and it does the right thing, it's just waiting review.

Sep 2 2019, 4:19 AM · Restricted Project

Aug 13 2019

tpr committed rG10db641aabf0: [AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm' (authored by tpr).
[AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm'
Aug 13 2019, 12:02 PM
tpr committed rL368736: [AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm'.
[AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm'
Aug 13 2019, 11:57 AM
tpr closed D66133: [AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm'.
Aug 13 2019, 11:57 AM · Restricted Project
tpr created D66133: [AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm'.
Aug 13 2019, 3:52 AM · Restricted Project
tpr added a reviewer for D66133: [AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm': arsenm.
Aug 13 2019, 3:52 AM · Restricted Project

Aug 6 2019

tpr committed rG5a0794327a67: [StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default (authored by tpr).
[StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default
Aug 6 2019, 7:31 AM
tpr committed rL368042: [StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default.
[StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default
Aug 6 2019, 7:29 AM
tpr closed D63198: [StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default.
Aug 6 2019, 7:29 AM · Restricted Project

Jul 4 2019

tpr committed rG5816889c748b: [AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8 (authored by tpr).
[AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8
Jul 4 2019, 10:39 AM
tpr committed rL365148: [AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8.
[AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8
Jul 4 2019, 10:38 AM
tpr closed D63160: [AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8.
Jul 4 2019, 10:38 AM · Restricted Project

Jun 24 2019

tpr added a comment to D63712: [AMDGPU] Fix +DumpCode to print an entry label for the first function.

Possibly, but our majority use case is to not need the disassembly, and our thinking is that we don't want to change the tool flow between the majority case and the minority case. So can we get this fix in please?

Jun 24 2019, 2:31 PM · Restricted Project
tpr committed rGd2fdb956e044: [AMDGPU] Allow any value in unused src0 field in v_nop (authored by tpr).
[AMDGPU] Allow any value in unused src0 field in v_nop
Jun 24 2019, 10:39 AM
tpr committed rL364208: [AMDGPU] Allow any value in unused src0 field in v_nop.
[AMDGPU] Allow any value in unused src0 field in v_nop
Jun 24 2019, 10:36 AM
tpr closed D63724: [AMDGPU] Allow any value in unused src0 field in v_nop.
Jun 24 2019, 10:36 AM · Restricted Project
tpr added reviewers for D63724: [AMDGPU] Allow any value in unused src0 field in v_nop: rampitec, kzhuravl.
Jun 24 2019, 9:27 AM · Restricted Project
tpr created D63724: [AMDGPU] Allow any value in unused src0 field in v_nop.
Jun 24 2019, 9:27 AM · Restricted Project
tpr added a comment to D63712: [AMDGPU] Fix +DumpCode to print an entry label for the first function.

I don't think anyone is a fan of dumpcode. But we're still in the position that the proper disassembler does not support gfx6 or gfx7, and we need to get this particular problem fixed in the short term.

Jun 24 2019, 6:13 AM · Restricted Project

Jun 19 2019

tpr added a comment to D63510: [LiveInterval] Removed bogus empty subrange assert.

For this bug, whatever we do with a mir test, it is not going to be reliable in failing if the bug is present. Maybe there is a unit testing framework for LiveRangeCalc tests that I could add a test to.

Jun 19 2019, 12:04 PM · Restricted Project
tpr added inline comments to D63510: [LiveInterval] Removed bogus empty subrange assert.
Jun 19 2019, 12:01 PM · Restricted Project
tpr added inline comments to D63510: [LiveInterval] Removed bogus empty subrange assert.
Jun 19 2019, 2:30 AM · Restricted Project

Jun 18 2019

tpr added reviewers for D63510: [LiveInterval] Removed bogus empty subrange assert: MatzeB, qcolombet.
Jun 18 2019, 12:29 PM · Restricted Project
tpr created D63510: [LiveInterval] Removed bogus empty subrange assert.
Jun 18 2019, 12:29 PM · Restricted Project

Jun 13 2019

tpr added reviewers for D63198: [StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default: nhaehnle, arsenm, kzhuravl.
Jun 13 2019, 3:33 AM · Restricted Project

Jun 12 2019

tpr updated the diff for D63198: [StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default.

V2: Lit test fix.

Jun 12 2019, 12:26 PM · Restricted Project
tpr created D63198: [StructurizeCFG] Enable -structurizecfg-relaxed-uniform-regions by default.
Jun 12 2019, 6:17 AM · Restricted Project
tpr added inline comments to D63160: [AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8.
Jun 12 2019, 3:32 AM · Restricted Project
tpr updated the diff for D63160: [AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8.

V2: Addressed review comments re test.

Jun 12 2019, 3:30 AM · Restricted Project

Jun 11 2019

tpr created D63160: [AMDGPU] Custom lower INSERT_SUBVECTOR v3, v4, v5, v8.
Jun 11 2019, 1:10 PM · Restricted Project

May 30 2019

tpr committed rG7fecdf36cc5b: [AMDGPU] Added target-specific attribute amdgpu-max-memory-clause (authored by tpr).
[AMDGPU] Added target-specific attribute amdgpu-max-memory-clause
May 30 2019, 11:49 AM
tpr committed rL362127: [AMDGPU] Added target-specific attribute amdgpu-max-memory-clause.
[AMDGPU] Added target-specific attribute amdgpu-max-memory-clause
May 30 2019, 11:43 AM
tpr closed D62572: [AMDGPU] Added target feature +disable-form-clauses.
May 30 2019, 11:43 AM · Restricted Project
tpr updated the diff for D62572: [AMDGPU] Added target feature +disable-form-clauses.

V2: Target-specific attribute instead of target feature, as suggested by Stas.

May 30 2019, 8:25 AM · Restricted Project

May 29 2019

tpr added a reviewer for D62572: [AMDGPU] Added target feature +disable-form-clauses: rampitec.
May 29 2019, 1:14 AM · Restricted Project
tpr created D62572: [AMDGPU] Added target feature +disable-form-clauses.
May 29 2019, 1:12 AM · Restricted Project

May 21 2019

tpr added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

LGTM, but I don't think I know the legalization code well enough to approve this.

May 21 2019, 6:35 AM · Restricted Project

May 16 2019

tpr committed rGe3cbdaf1b5e7: [CodeGen] Fixed de-optimization of legalize subvector extract (authored by tpr).
[CodeGen] Fixed de-optimization of legalize subvector extract
May 16 2019, 2:47 PM
tpr committed rL360942: [CodeGen] Fixed de-optimization of legalize subvector extract.
[CodeGen] Fixed de-optimization of legalize subvector extract
May 16 2019, 2:46 PM
tpr closed D60457: [CodeGen] Fixed de-optimization of legalize subvector extract.
May 16 2019, 2:46 PM · Restricted Project
tpr added a comment to D60457: [CodeGen] Fixed de-optimization of legalize subvector extract.

Is someone now able to approve this? Eli?

May 16 2019, 10:22 AM · Restricted Project

May 14 2019

tpr committed rG33cb8f5b547c: [AMDGPU] Fixed +DumpCode (authored by tpr).
[AMDGPU] Fixed +DumpCode
May 14 2019, 9:17 AM
tpr committed rL360688: [AMDGPU] Fixed +DumpCode.
[AMDGPU] Fixed +DumpCode
May 14 2019, 9:15 AM
tpr closed D60682: [AMDGPU] Fixed +DumpCode.
May 14 2019, 9:14 AM · Restricted Project
tpr added inline comments to D60457: [CodeGen] Fixed de-optimization of legalize subvector extract.
May 14 2019, 8:09 AM · Restricted Project