Page MenuHomePhabricator
Feed Advanced Search

Tue, Sep 29

hamax97 added a comment to D87259: [OpenMPOpt][SplitMemTransfer] Implementation of the real issue and wait api functions..

I think these API functions should also include the source location pointer from https://reviews.llvm.org/D87946. We need to consider renaming the *_issue and *_wait functions to extend the *_loc API the aforementioned patch is introducing. E.g. after D87946 the "current" data begin API function will be __tgt_target_data_begin_mapper_loc, so this patch should extend that name as __tgt_target_data_begin_mapper_loc_issue and __tgt_target_data_begin_mapper_loc_wait. Because both patches make changes to the API, I think it's better to wait until the former patch has been committed.

Tue, Sep 29, 9:42 AM · Restricted Project
hamax97 added a comment to D87259: [OpenMPOpt][SplitMemTransfer] Implementation of the real issue and wait api functions..

Ping!. Could you please take a look at it?

Tue, Sep 29, 8:19 AM · Restricted Project

Sep 22 2020

hamax97 updated the diff for D87259: [OpenMPOpt][SplitMemTransfer] Implementation of the real issue and wait api functions..

Passing handle as input/output argument to __tgt_target_data_begin_mapper_<issue|wait>.

Sep 22 2020, 9:56 AM · Restricted Project
hamax97 committed rGbd31abc1d0f1: [OpenMPOpt] Refactored "issue" and "wait" declarations for data map runtime… (authored by hamax97).
[OpenMPOpt] Refactored "issue" and "wait" declarations for data map runtime…
Sep 22 2020, 8:51 AM
hamax97 closed D88029: [OpenMPOpt][SplitMemTransfer] Refactored API declarations.
Sep 22 2020, 8:51 AM · Restricted Project

Sep 21 2020

hamax97 added a comment to D87260: [OpenMPOpt][SplitMemTransfer] Can move setup instructions upwards?.

tests?

Sep 21 2020, 9:09 AM · Restricted Project
hamax97 requested review of D88029: [OpenMPOpt][SplitMemTransfer] Refactored API declarations.
Sep 21 2020, 9:07 AM · Restricted Project

Sep 15 2020

hamax97 updated the diff for D87260: [OpenMPOpt][SplitMemTransfer] Can move setup instructions upwards?.
  • Fixed bug when creating the wait runtime call.
Sep 15 2020, 1:46 PM · Restricted Project
hamax97 updated the diff for D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
  • Added constants to ease the access to OffloadArrays in the function detectIssue.
Sep 15 2020, 10:46 AM · Restricted Project

Sep 8 2020

hamax97 added a comment to D87260: [OpenMPOpt][SplitMemTransfer] Can move setup instructions upwards?.

Tests?

The regression test for this is hide_mem_transfer_latency.ll. But there's still the issue with the AAManager, so the test has the fixmes of where the set up instructions should be moved.

But it seems not to include any changes to the test. why not? because this doesn't have an impact without resolving the issue you mentioned?

Sep 8 2020, 10:48 AM · Restricted Project
hamax97 added a comment to D87260: [OpenMPOpt][SplitMemTransfer] Can move setup instructions upwards?.

Tests?

Sep 8 2020, 8:06 AM · Restricted Project

Sep 7 2020

hamax97 requested review of D87260: [OpenMPOpt][SplitMemTransfer] Can move setup instructions upwards?.
Sep 7 2020, 6:10 PM · Restricted Project
hamax97 requested review of D87259: [OpenMPOpt][SplitMemTransfer] Implementation of the real issue and wait api functions..
Sep 7 2020, 6:08 PM · Restricted Project

Sep 1 2020

hamax97 added inline comments to D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
Sep 1 2020, 6:52 AM · Restricted Project

Aug 31 2020

hamax97 updated the diff for D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
  • Adding regression test
Aug 31 2020, 5:15 PM · Restricted Project
hamax97 committed rG1d3d9b9cd808: [OpenMPOpt][NFC] Moving constants as struct static attributes (authored by hamax97).
[OpenMPOpt][NFC] Moving constants as struct static attributes
Aug 31 2020, 5:05 PM
hamax97 closed D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.

rG8931add61705 [OpenMPOpt][HideMemTransfersLatency] Get values stored in offload arrays.

Aug 31 2020, 2:18 PM · Restricted Project, Restricted Project
hamax97 committed rG8931add61705: [OpenMPOpt][HideMemTransfersLatency] Get values stored in offload arrays (authored by hamax97).
[OpenMPOpt][HideMemTransfersLatency] Get values stored in offload arrays
Aug 31 2020, 1:34 PM
hamax97 added inline comments to D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
Aug 31 2020, 9:57 AM · Restricted Project, Restricted Project
hamax97 updated the diff for D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
  • Removing factory function for OffloadArray, now using it as member function.
  • Calculating the accessed index of the OffloadArray using the offset returned by GetPointerBaseWithConstantOffset.
Aug 31 2020, 9:22 AM · Restricted Project, Restricted Project

Aug 28 2020

hamax97 added inline comments to D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
Aug 28 2020, 1:22 PM · Restricted Project, Restricted Project
hamax97 added inline comments to D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
Aug 28 2020, 9:25 AM · Restricted Project, Restricted Project

Aug 27 2020

hamax97 added inline comments to D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
Aug 27 2020, 8:52 AM · Restricted Project

Aug 25 2020

hamax97 updated the diff for D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
  • NIT changes to comments
Aug 25 2020, 11:55 AM · Restricted Project
hamax97 updated the diff for D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
  • NIT changes.
  • Tried to split the patch, but then we couldn't test for the values we got.
Aug 25 2020, 10:17 AM · Restricted Project, Restricted Project

Aug 24 2020

hamax97 requested review of D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
Aug 24 2020, 10:26 AM · Restricted Project
hamax97 abandoned D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.
Aug 24 2020, 10:18 AM · Restricted Project
hamax97 abandoned D84593: [OpenMPOpt][SplitMemTransfer][WIP] Detect issue.
Aug 24 2020, 10:18 AM · Restricted Project, Restricted Project
hamax97 abandoned D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Aug 24 2020, 10:18 AM · Restricted Project, Restricted Project

Aug 21 2020

hamax97 updated the diff for D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
  • Require comments
  • Added REQUIRES: assertions to regression test.
Aug 21 2020, 9:59 AM · Restricted Project, Restricted Project
hamax97 updated the diff for D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.

NIT: Refactor some variable declarations.

Aug 21 2020, 8:48 AM · Restricted Project, Restricted Project

Aug 20 2020

hamax97 updated the diff for D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
  • Adding regression test.
Aug 20 2020, 4:56 PM · Restricted Project, Restricted Project
hamax97 updated hamax97.
Aug 20 2020, 10:15 AM
hamax97 added inline comments to D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
Aug 20 2020, 10:04 AM · Restricted Project, Restricted Project
hamax97 requested review of D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
Aug 20 2020, 9:02 AM · Restricted Project, Restricted Project

Aug 18 2020

hamax97 updated the diff for D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.
  • Removing comparison with explicit runtime functions from canBeMovedDownwards.
  • Minor refactors to comments and arguments.
Aug 18 2020, 4:37 PM · Restricted Project
hamax97 added inline comments to D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.
Aug 18 2020, 4:16 PM · Restricted Project
hamax97 updated the diff for D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.

Adding constraint mayReadFromMemory to canBeMovedDownwards.

Aug 18 2020, 1:17 PM · Restricted Project
hamax97 added a comment to D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.

We have to check "mayReadMemory" as well I think.

Aug 18 2020, 11:18 AM · Restricted Project
hamax97 closed D86111: [OpenMPOpt][SplitMemTransfer][NFC] Updating regression test.

Commit: https://github.com/llvm/llvm-project/commit/ad03d0647fed02f74f811ff09341a3e7a72fdfc6

Aug 18 2020, 10:48 AM · Restricted Project
hamax97 closed D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.

Commit: https://github.com/llvm/llvm-project/commit/496f8e5b369f091def93482578232da8c6e77a7a

Aug 18 2020, 10:43 AM · Restricted Project
hamax97 requested review of D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.
Aug 18 2020, 10:33 AM · Restricted Project

Aug 17 2020

hamax97 updated the diff for D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
  • Refactor to some names and other minor changes.
  • Update regression test to expect the split runtime calls.
Aug 17 2020, 4:42 PM · Restricted Project
hamax97 requested review of D86111: [OpenMPOpt][SplitMemTransfer][NFC] Updating regression test.
Aug 17 2020, 2:49 PM · Restricted Project

Aug 16 2020

hamax97 added inline comments to D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
Aug 16 2020, 10:45 AM · Restricted Project

Aug 13 2020

hamax97 updated the diff for D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
  • Isolating split function.
Aug 13 2020, 5:29 PM · Restricted Project
hamax97 added a comment to D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.

Hm, is it possible to apply this one first. I think this is the easiest to approve right away, that way we have less outstanding code.

WDYT?

But we need to add the structure MemoryTranfer too. Also remember this assumes we moved the declarations in OpenMPOpt.cpp to OpenMPOpt.h, so we would have to put this new code into OpenMPOpt.cpp, which I think is not a problem at all, but just to consider it.

Why do we need anything to split the runtime calls? The arguments should be sufficient for the split, no?

Aug 13 2020, 12:19 PM · Restricted Project
hamax97 added a comment to D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.

Hm, is it possible to apply this one first. I think this is the easiest to approve right away, that way we have less outstanding code.

WDYT?

Aug 13 2020, 7:12 AM · Restricted Project

Aug 12 2020

hamax97 updated the diff for D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
  • Changing std::vector for SmallVector in split function.
Aug 12 2020, 3:35 PM · Restricted Project
hamax97 updated the diff for D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.

Sorry. Error updating last patch.

  • Fix to canBeMovedDownwards
Aug 12 2020, 3:34 PM · Restricted Project
hamax97 updated the diff for D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.
Aug 12 2020, 3:32 PM · Restricted Project
hamax97 updated the diff for D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.
  • Fix to canBeMovedDownwards.
Aug 12 2020, 3:24 PM · Restricted Project
hamax97 added a comment to D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.

Can you add parent revisions for this and maybe other related patches? It will be easier to know the order.

Aug 12 2020, 1:33 PM · Restricted Project
hamax97 retitled D84593: [OpenMPOpt][SplitMemTransfer][WIP] Detect issue from [OpenMPOpt][SplitMemTransfer][WIP] Where to move the issue to [OpenMPOpt][SplitMemTransfer][WIP] Detect issue.
Aug 12 2020, 1:27 PM · Restricted Project, Restricted Project
hamax97 added a comment to D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

This can be closed, right?

Aug 12 2020, 1:23 PM · Restricted Project, Restricted Project
hamax97 updated the diff for D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
  • Removing move code.
Aug 12 2020, 9:18 AM · Restricted Project
hamax97 added a comment to D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.

Is this a diff against master?

Aug 12 2020, 9:09 AM · Restricted Project
hamax97 updated the diff for D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
  • Splitting patch into canBeMoved logic and splitting the runtime call.
  • Fix to minor bug in detectIssue.
  • Update regression test. Now checks that the runtime call __tgt_target_data_begin is successfully split. Not sure if this should go in another patch.
Aug 12 2020, 9:00 AM · Restricted Project
hamax97 requested review of D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.
Aug 12 2020, 8:43 AM · Restricted Project

Aug 11 2020

hamax97 updated the diff for D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
  • Using OMPIRBuilder instead of manually generating the runtime calls.
  • Updating regression test for this optimization.
Aug 11 2020, 3:25 PM · Restricted Project

Aug 10 2020

hamax97 added a comment to D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.

I think if I only add the declarations of __tgt_target_data_begin_issue and __tgt_target_data_being_wait the linking process will fail. How should I define the wait function?, the issue is just a wrapper of the current function, but as we don't have Shilei's patch merged yet I would have to create something that does nothing and change it later when the asynchronous stuff is merged.

Aug 10 2020, 10:40 AM · Restricted Project

Aug 7 2020

hamax97 requested review of D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
Aug 7 2020, 9:26 AM · Restricted Project

Jul 31 2020

hamax97 updated the diff for D84593: [OpenMPOpt][SplitMemTransfer][WIP] Detect issue.
  • Fix code style issue.
  • Problem with getModRefInfo, it always returns that a value V may be modified, even when running opt with -aa-pipeline=basic-aa.
Jul 31 2020, 2:36 PM · Restricted Project, Restricted Project

Jul 30 2020

hamax97 added a comment to D83316: [OpenMPOpt][WIP] Structure for unittests.

I'm not totally sure about this. There's a lot of test setup relative to the test case itself, and I can't work out by reading the test itself what it's checking. What are all the mock classes for?

I'm wondering if we would be better off refactoring the code it intends to test so that it needs less setup.

Jul 30 2020, 11:15 AM · Restricted Project, Restricted Project
hamax97 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jul 30 2020, 10:56 AM · Restricted Project, Restricted Project

Jul 25 2020

hamax97 created D84593: [OpenMPOpt][SplitMemTransfer][WIP] Detect issue.
Jul 25 2020, 5:38 PM · Restricted Project, Restricted Project

Jul 20 2020

hamax97 updated the summary of D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project
hamax97 updated the diff for D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
  • Refactors discussed made.
  • OpenMPOpt unit tests infrastructure merged.
Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project

Jul 18 2020

hamax97 added a comment to D83316: [OpenMPOpt][WIP] Structure for unittests.

Wow, this required more machinery than I expected.. thanks!

Should we merge this with the MemoryTransfer logic so we can test it?

Jul 18 2020, 8:10 PM · Restricted Project, Restricted Project
hamax97 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jul 18 2020, 8:09 PM · Restricted Project, Restricted Project
hamax97 updated the diff for D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

Finished getting values in offload arrays

Jul 18 2020, 11:59 AM · Restricted Project, Restricted Project
hamax97 updated the diff for D83316: [OpenMPOpt][WIP] Structure for unittests.

Unit test for getValuesInOfflArrays working.

Jul 18 2020, 11:52 AM · Restricted Project, Restricted Project

Jul 9 2020

hamax97 added a comment to D83316: [OpenMPOpt][WIP] Structure for unittests.

Should we merge the test header into the test cpp?

We need an actual unit test that runs :)

Jul 9 2020, 8:18 AM · Restricted Project, Restricted Project

Jul 7 2020

hamax97 updated the diff for D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
  • Exposing getValuesInOfflArrays() to make it unit testable.
Jul 7 2020, 4:21 PM · Restricted Project, Restricted Project
hamax97 updated the diff for D83312: [OpenMPOpt][NFC] Exposing OMPInformationCache and OpenMPOpt in the public header for unittesting.
Jul 7 2020, 10:57 AM · Restricted Project, Restricted Project
hamax97 updated the summary of D83312: [OpenMPOpt][NFC] Exposing OMPInformationCache and OpenMPOpt in the public header for unittesting.
Jul 7 2020, 10:55 AM · Restricted Project, Restricted Project
hamax97 created D83316: [OpenMPOpt][WIP] Structure for unittests.
Jul 7 2020, 8:52 AM · Restricted Project, Restricted Project
hamax97 updated the diff for D83312: [OpenMPOpt][NFC] Exposing OMPInformationCache and OpenMPOpt in the public header for unittesting.
  • Adding static function needed in unittest.
  • Fixing description in header of new file.
Jul 7 2020, 8:45 AM · Restricted Project, Restricted Project
Herald added a reviewer for D83312: [OpenMPOpt][NFC] Exposing OMPInformationCache and OpenMPOpt in the public header for unittesting: baziotis.
Jul 7 2020, 8:15 AM · Restricted Project, Restricted Project

Jul 5 2020

hamax97 updated the diff for D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.
  • Fix heavyComputation1 test case.
  • Passing all test cases through optimizer in order to remove some unnecessary code.
Jul 5 2020, 12:47 PM · Restricted Project, Restricted Project

Jul 4 2020

hamax97 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jul 4 2020, 9:02 PM · Restricted Project, Restricted Project
hamax97 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jul 4 2020, 12:21 PM · Restricted Project, Restricted Project
hamax97 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jul 4 2020, 12:21 PM · Restricted Project, Restricted Project
hamax97 updated the diff for D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

[WIP]

  • Creating the first unit test for OpenMPOpt. This creation led me to move the declaration of OpenMPOpt and OMPInformationCache to OpenMPOpt.h.
  • I propose refactoring the optimizations to separate structures so that they are easily maintainable and testable.
Jul 4 2020, 11:49 AM · Restricted Project, Restricted Project

Jun 29 2020

hamax97 updated the diff for D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

Including all diff

Jun 29 2020, 8:24 PM · Restricted Project, Restricted Project

Jun 28 2020

hamax97 updated the diff for D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

Changing from returning status code to bool + Getting MemorySSAAnalysis through OMPInfoCache

Jun 28 2020, 4:06 PM · Restricted Project, Restricted Project
hamax97 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jun 28 2020, 3:02 PM · Restricted Project, Restricted Project
hamax97 created D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jun 28 2020, 8:39 AM · Restricted Project, Restricted Project

Jun 1 2020

hamax97 updated the diff for D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

Added FileCheck constructs

Jun 1 2020, 5:21 PM · Restricted Project, Restricted Project

May 24 2020

hamax97 updated the diff for D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

Added __tgt_target_data_begin to the commented original code, just to make the test cases easier to read.

May 24 2020, 8:00 AM · Restricted Project, Restricted Project

May 22 2020

hamax97 updated the diff for D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.
  • Fixed illegal movement: now there's one negative test case (issue cannot be moved) and one positive (with noalias) where the issue can be moved.
  • Added data transfer only test case.
May 22 2020, 3:02 PM · Restricted Project, Restricted Project

May 16 2020

hamax97 added a comment to D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

This is great! Thanks for starting. I left two comments but this looks pretty good to me.
We will later need positive and negative test cases. We can make those smaller though,
you just have the memory transfer request, no target region. We want to verify we move it
properly, e.g., when it appears in loops, in conditionals, there are memory accesses
before/after, ...

Btw. if it helps, we can also create a "thinner" version of the API that takes less arguments
and is applicable only in some often occurring cases, e.g., we can remove the baseptr array
and use it only if ptr and baseptr have the same entries anyway.

May 16 2020, 10:33 AM · Restricted Project, Restricted Project

May 15 2020

hamax97 created D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.
May 15 2020, 4:52 PM · Restricted Project, Restricted Project

Mar 21 2020

hamax97 added a comment to D76058: [OpenMPOpt] Validate declaration types against the expected types .

LGTM. Thx!

Mar 21 2020, 2:38 AM · Restricted Project, Restricted Project

Mar 20 2020

hamax97 added inline comments to D76058: [OpenMPOpt] Validate declaration types against the expected types .
Mar 20 2020, 10:17 AM · Restricted Project, Restricted Project
hamax97 updated the diff for D76058: [OpenMPOpt] Validate declaration types against the expected types .

Removing unnecessary check for variadic function.

Mar 20 2020, 10:17 AM · Restricted Project, Restricted Project

Mar 19 2020

hamax97 added inline comments to D76058: [OpenMPOpt] Validate declaration types against the expected types .
Mar 19 2020, 2:39 AM · Restricted Project, Restricted Project

Mar 15 2020

hamax97 added inline comments to D76058: [OpenMPOpt] Validate declaration types against the expected types .
Mar 15 2020, 7:20 PM · Restricted Project, Restricted Project
hamax97 updated the diff for D76058: [OpenMPOpt] Validate declaration types against the expected types .

Minor change to test file + adding std::move to object copy.

Mar 15 2020, 12:19 PM · Restricted Project, Restricted Project
hamax97 added inline comments to D76058: [OpenMPOpt] Validate declaration types against the expected types .
Mar 15 2020, 9:05 AM · Restricted Project, Restricted Project