Page MenuHomePhabricator
Feed Advanced Search

Aug 4 2022

AndrewLitteken accepted D130230: [llvm][IROutliner] Account for return void in sort comparator.

LGTM with small nit.

Aug 4 2022, 8:37 AM · Restricted Project, Restricted Project

Aug 3 2022

AndrewLitteken added a comment to D130230: [llvm][IROutliner] Account for return void in sort comparator.

There shouldn't be a case where there is a ret void and a ret <Constant Int> in a function. I am pretty sure that there will only more than one return value when the function has more than one exit block. In that case, there are multiple return values have an integer value. So the cases you laid out should be correct.

Aug 3 2022, 8:47 AM · Restricted Project, Restricted Project

May 10 2022

AndrewLitteken added a comment to D124775: [IRSim] Removing check that caused early matching of commutative instructions.

Yes, this was written to fix that crash. Should have noted it in the commit message.

May 10 2022, 5:08 AM · Restricted Project, Restricted Project

May 9 2022

AndrewLitteken committed rG96345f773cfe: [IRSim] Remove early check from similarity matching such that commutative… (authored by AndrewLitteken).
[IRSim] Remove early check from similarity matching such that commutative…
May 9 2022, 8:59 PM · Restricted Project, Restricted Project
AndrewLitteken closed D124775: [IRSim] Removing check that caused early matching of commutative instructions.
May 9 2022, 8:59 PM · Restricted Project, Restricted Project

May 7 2022

AndrewLitteken committed rGe38f014c40e9: [IROutliner] Accomodate blocks containing PHINodes with one entry outside the… (authored by AndrewLitteken).
[IROutliner] Accomodate blocks containing PHINodes with one entry outside the…
May 7 2022, 3:13 PM · Restricted Project, Restricted Project
AndrewLitteken closed D124777: [IROutliner] Accommodate PHINodes with entry outside region for numbering.
May 7 2022, 3:12 PM · Restricted Project, Restricted Project

May 4 2022

AndrewLitteken updated the diff for D124777: [IROutliner] Accommodate PHINodes with entry outside region for numbering.

Updating case when there are no predecessors to the outlined region form outside the region.

May 4 2022, 11:49 AM · Restricted Project, Restricted Project

May 2 2022

AndrewLitteken requested review of D124777: [IROutliner] Accommodate PHINodes with entry outside region for numbering.
May 2 2022, 9:03 AM · Restricted Project, Restricted Project
AndrewLitteken requested review of D124775: [IRSim] Removing check that caused early matching of commutative instructions.
May 2 2022, 8:56 AM · Restricted Project, Restricted Project

Apr 19 2022

AndrewLitteken committed rG3de29ad20955: [IRSim] Ignore debug instructions when creating canonical numbering (authored by AndrewLitteken).
[IRSim] Ignore debug instructions when creating canonical numbering
Apr 19 2022, 11:18 AM · Restricted Project, Restricted Project
AndrewLitteken closed D123903: [IRSim] Ignore Debug instructions with constructing canonical numbering for basic blocks.
Apr 19 2022, 11:18 AM · Restricted Project, Restricted Project

Apr 18 2022

AndrewLitteken added a comment to D123903: [IRSim] Ignore Debug instructions with constructing canonical numbering for basic blocks.

I don't know that much about this analysis pass to say if it is correct to skip dbg intrinsics like this. (And should for example lifetime instrinsics be skipped in the same way?)

Apr 18 2022, 8:45 AM · Restricted Project, Restricted Project

Apr 16 2022

AndrewLitteken added a comment to D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..

Seen assertion failures downstream with this patch. Here is a reproducer:

Apr 16 2022, 2:17 PM · Restricted Project, Restricted Project
AndrewLitteken requested review of D123903: [IRSim] Ignore Debug instructions with constructing canonical numbering for basic blocks.
Apr 16 2022, 2:17 PM · Restricted Project, Restricted Project
AndrewLitteken committed rGd7c56a076e7a: [IROutliner] Ensure that phi values that are passed in as arguments are… (authored by AndrewLitteken).
[IROutliner] Ensure that phi values that are passed in as arguments are…
Apr 16 2022, 1:49 PM · Restricted Project, Restricted Project

Apr 14 2022

AndrewLitteken added a reverting change for rGd6eb480afbc0: [IROutliner] Ensure that phi values that are passed in as arguments are…: rG6f8eba06c289: Revert "[IROutliner] Ensure that phi values that are passed in as arguments are….
Apr 14 2022, 10:24 AM · Restricted Project, Restricted Project
AndrewLitteken committed rG6f8eba06c289: Revert "[IROutliner] Ensure that phi values that are passed in as arguments are… (authored by AndrewLitteken).
Revert "[IROutliner] Ensure that phi values that are passed in as arguments are…
Apr 14 2022, 10:24 AM · Restricted Project, Restricted Project
AndrewLitteken added a reverting change for D122206: [IROutliner] Ensure that phi values that are passed in as arguments are remapped as arguments: rG6f8eba06c289: Revert "[IROutliner] Ensure that phi values that are passed in as arguments are….
Apr 14 2022, 10:24 AM · Restricted Project, Restricted Project
AndrewLitteken committed rGd6eb480afbc0: [IROutliner] Ensure that phi values that are passed in as arguments are… (authored by AndrewLitteken).
[IROutliner] Ensure that phi values that are passed in as arguments are…
Apr 14 2022, 10:16 AM · Restricted Project, Restricted Project
AndrewLitteken closed D122206: [IROutliner] Ensure that phi values that are passed in as arguments are remapped as arguments.
Apr 14 2022, 10:16 AM · Restricted Project, Restricted Project
AndrewLitteken committed rGa919d3d8881e: [IROutliner] Ensure that incoming blocks of PHINodes are included in the unique… (authored by AndrewLitteken).
[IROutliner] Ensure that incoming blocks of PHINodes are included in the unique…
Apr 14 2022, 10:14 AM · Restricted Project, Restricted Project
AndrewLitteken closed D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..
Apr 14 2022, 10:14 AM · Restricted Project, Restricted Project

Apr 13 2022

AndrewLitteken added a comment to D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..

Reduced reproducer here: https://godbolt.org/z/4jW3KsEns

Apr 13 2022, 10:33 PM · Restricted Project, Restricted Project
AndrewLitteken updated the diff for D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..
Apr 13 2022, 2:32 PM · Restricted Project, Restricted Project

Mar 21 2022

AndrewLitteken requested review of D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..
Mar 21 2022, 8:39 PM · Restricted Project, Restricted Project
AndrewLitteken requested review of D122206: [IROutliner] Ensure that phi values that are passed in as arguments are remapped as arguments.
Mar 21 2022, 8:35 PM · Restricted Project, Restricted Project
AndrewLitteken committed rG86f970e595f4: [IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock (authored by hkmatsumoto).
[IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock
Mar 21 2022, 10:35 AM · Restricted Project
AndrewLitteken closed D121627: [IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock.
Mar 21 2022, 10:34 AM · Restricted Project, Restricted Project
AndrewLitteken added a comment to D121627: [IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock.

Since I don't have commit access, can you land this patch for me?

Mar 21 2022, 9:20 AM · Restricted Project, Restricted Project
AndrewLitteken committed rG4e500df89ec6: [IROutliner] Fix phi nodes when self referential within block but doesn't… (authored by AndrewLitteken).
[IROutliner] Fix phi nodes when self referential within block but doesn't…
Mar 21 2022, 9:07 AM · Restricted Project
AndrewLitteken closed D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.
Mar 21 2022, 9:06 AM · Restricted Project, Restricted Project

Mar 20 2022

AndrewLitteken committed rG38e8880e9312: [IROutliner] Do not outlined from functions with optnone (authored by AndrewLitteken).
[IROutliner] Do not outlined from functions with optnone
Mar 20 2022, 9:40 PM · Restricted Project
AndrewLitteken closed D121567: [IROutliner] Do not outline from regions that are marked with OptNone.
Mar 20 2022, 9:39 PM · Restricted Project, Restricted Project
AndrewLitteken accepted D121627: [IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock.

LGTM

Mar 20 2022, 6:25 PM · Restricted Project, Restricted Project

Mar 17 2022

AndrewLitteken committed rGf7d90ad57bef: [IROutliner] Make sure that loop debug info is stripped. (authored by AndrewLitteken).
[IROutliner] Make sure that loop debug info is stripped.
Mar 17 2022, 1:44 PM · Restricted Project
AndrewLitteken closed D120869: [IROutliner] Strip loop info when moving code into outlined function..
Mar 17 2022, 1:43 PM · Restricted Project, Restricted Project

Mar 14 2022

AndrewLitteken added a comment to D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.

https://github.com/llvm/llvm-project/issues/54212

Mar 14 2022, 3:51 PM · Restricted Project, Restricted Project
AndrewLitteken committed rG228cc2c38bfb: [IROutliner] Ensure merged PHINodes respect order and incoming blocks, not just… (authored by AndrewLitteken).
[IROutliner] Ensure merged PHINodes respect order and incoming blocks, not just…
Mar 14 2022, 2:48 PM · Restricted Project
AndrewLitteken closed D121310: [IROutliner] IR Outliner can mix up order of incoming values when compressing phi nodes if contain the same values.
Mar 14 2022, 2:48 PM · Restricted Project, Restricted Project
AndrewLitteken committed rGc79ab1065e89: [IROutliner] Separate split PHI nodes from multiple exits by different… (authored by AndrewLitteken).
[IROutliner] Separate split PHI nodes from multiple exits by different…
Mar 14 2022, 12:57 PM · Restricted Project
AndrewLitteken closed D121313: [IROutliner] Fix miscounting of exit paths when a single phi node used as an output for several outlined regions..
Mar 14 2022, 12:57 PM · Restricted Project, Restricted Project
AndrewLitteken committed rG3c90812f3b43: [IROutliner] Avoid reusing PHINodes that have already been matched when merging… (authored by AndrewLitteken).
[IROutliner] Avoid reusing PHINodes that have already been matched when merging…
Mar 14 2022, 10:00 AM · Restricted Project
AndrewLitteken closed D121312: [IROutliner] Avoid reusing PHINodes that have already been matched when merging outlined functions' phi node blocks.
Mar 14 2022, 10:00 AM · Restricted Project, Restricted Project

Mar 13 2022

AndrewLitteken requested review of D121567: [IROutliner] Do not outline from regions that are marked with OptNone.
Mar 13 2022, 9:59 PM · Restricted Project, Restricted Project
AndrewLitteken updated the diff for D120869: [IROutliner] Strip loop info when moving code into outlined function..

Reducing test case

Mar 13 2022, 9:57 PM · Restricted Project, Restricted Project
AndrewLitteken updated the diff for D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.
Mar 13 2022, 9:55 PM · Restricted Project, Restricted Project
AndrewLitteken updated the diff for D121310: [IROutliner] IR Outliner can mix up order of incoming values when compressing phi nodes if contain the same values.

Updating with context

Mar 13 2022, 9:54 PM · Restricted Project, Restricted Project
AndrewLitteken updated the diff for D121310: [IROutliner] IR Outliner can mix up order of incoming values when compressing phi nodes if contain the same values.

Updating with nits

Mar 13 2022, 9:53 PM · Restricted Project, Restricted Project
AndrewLitteken committed rG0c4bbd293e66: [IRSim] Make sure the first instruction of a block doesn't get missed if it is… (authored by AndrewLitteken).
[IRSim] Make sure the first instruction of a block doesn't get missed if it is…
Mar 13 2022, 9:19 PM · Restricted Project
AndrewLitteken closed D120786: [IRSim] Removing length check so first instruction in module is included.
Mar 13 2022, 9:19 PM · Restricted Project, Restricted Project
AndrewLitteken committed rG1643f01232b4: [IRSim][IROutliner] Ignoring Musttail Function (authored by AndrewLitteken).
[IRSim][IROutliner] Ignoring Musttail Function
Mar 13 2022, 5:29 PM · Restricted Project
AndrewLitteken added a reverting change for rGc7037c72572c: [IRSim][IROutliner] Ignoring Musttail Function: rG66f90fdff181: Revert "[IRSim][IROutliner] Ignoring Musttail Function".
Mar 13 2022, 5:28 PM · Restricted Project
AndrewLitteken committed rG66f90fdff181: Revert "[IRSim][IROutliner] Ignoring Musttail Function" (authored by AndrewLitteken).
Revert "[IRSim][IROutliner] Ignoring Musttail Function"
Mar 13 2022, 5:28 PM · Restricted Project
AndrewLitteken closed D120733: [IRSim][IROutliner] Ignore outlined sections that include musttail calls .
Mar 13 2022, 5:28 PM · Restricted Project, Restricted Project
AndrewLitteken committed rGc7037c72572c: [IRSim][IROutliner] Ignoring Musttail Function (authored by AndrewLitteken).
[IRSim][IROutliner] Ignoring Musttail Function
Mar 13 2022, 5:26 PM · Restricted Project

Mar 9 2022

AndrewLitteken added inline comments to D121313: [IROutliner] Fix miscounting of exit paths when a single phi node used as an output for several outlined regions..
Mar 9 2022, 11:21 AM · Restricted Project, Restricted Project
AndrewLitteken requested review of D121313: [IROutliner] Fix miscounting of exit paths when a single phi node used as an output for several outlined regions..
Mar 9 2022, 11:00 AM · Restricted Project, Restricted Project
AndrewLitteken requested review of D121312: [IROutliner] Avoid reusing PHINodes that have already been matched when merging outlined functions' phi node blocks.
Mar 9 2022, 10:58 AM · Restricted Project, Restricted Project
AndrewLitteken added a reviewer for D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not: paquette.
Mar 9 2022, 10:56 AM · Restricted Project, Restricted Project
AndrewLitteken requested review of D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.
Mar 9 2022, 10:56 AM · Restricted Project, Restricted Project
AndrewLitteken requested review of D121310: [IROutliner] IR Outliner can mix up order of incoming values when compressing phi nodes if contain the same values.
Mar 9 2022, 10:53 AM · Restricted Project, Restricted Project
AndrewLitteken committed rG0b3a6c8d20d1: [IROutliner] Handling outlined code with no exit paths (authored by AndrewLitteken).
[IROutliner] Handling outlined code with no exit paths
Mar 9 2022, 10:44 AM · Restricted Project
AndrewLitteken closed D120868: [IROutliner] handle functions that do not contain an exit path.
Mar 9 2022, 10:44 AM · Restricted Project, Restricted Project

Mar 2 2022

AndrewLitteken requested review of D120869: [IROutliner] Strip loop info when moving code into outlined function..
Mar 2 2022, 10:10 PM · Restricted Project, Restricted Project
AndrewLitteken requested review of D120868: [IROutliner] handle functions that do not contain an exit path.
Mar 2 2022, 10:08 PM · Restricted Project, Restricted Project
AndrewLitteken requested review of D120867: [IROutliner] Adding support to properly handle musttail, swifttailcc and tailcc.
Mar 2 2022, 10:04 PM · Restricted Project, Restricted Project
AndrewLitteken updated the diff for D120733: [IRSim][IROutliner] Ignore outlined sections that include musttail calls .

Adding comments explaining reasoning for skipping for now.

Mar 2 2022, 10:02 PM · Restricted Project, Restricted Project
AndrewLitteken updated the diff for D120786: [IRSim] Removing length check so first instruction in module is included.

Adding test

Mar 2 2022, 10:01 PM · Restricted Project, Restricted Project
AndrewLitteken added a comment to D120786: [IRSim] Removing length check so first instruction in module is included.

Oh, well I'll add it to the list. It looks like it's due to loop metadata not being stripped, only debug info location info gets stripped at the moment.

Mar 2 2022, 12:13 PM · Restricted Project, Restricted Project

Mar 1 2022

AndrewLitteken requested review of D120786: [IRSim] Removing length check so first instruction in module is included.
Mar 1 2022, 4:58 PM · Restricted Project, Restricted Project
AndrewLitteken added inline comments to D120733: [IRSim][IROutliner] Ignore outlined sections that include musttail calls .
Mar 1 2022, 8:05 AM · Restricted Project, Restricted Project
AndrewLitteken requested review of D120733: [IRSim][IROutliner] Ignore outlined sections that include musttail calls .
Mar 1 2022, 7:57 AM · Restricted Project, Restricted Project

Feb 2 2022

AndrewLitteken committed rG30420bc34415: [IRSim] Make sure that commutative intrinsics are treated as function calls… (authored by AndrewLitteken).
[IRSim] Make sure that commutative intrinsics are treated as function calls…
Feb 2 2022, 11:25 AM
AndrewLitteken closed D118807: [IRSim] Make sure that commutative intrinsics are treated as function calls without commutativity.
Feb 2 2022, 11:25 AM · Restricted Project
AndrewLitteken added a comment to D118807: [IRSim] Make sure that commutative intrinsics are treated as function calls without commutativity.

I think we should be able to do that, right now it's an either or for the commutative path vs the non commutative path, but I think we should be give the similarity identifier a sublist of values that are commutative and a sublist that are noncommutative and run both functions.

Feb 2 2022, 10:44 AM · Restricted Project
AndrewLitteken requested review of D118807: [IRSim] Make sure that commutative intrinsics are treated as function calls without commutativity.
Feb 2 2022, 9:17 AM · Restricted Project

Jan 28 2022

AndrewLitteken abandoned D93475: Updating macOS Version logic for macOS 11+ and Darwin 20+.

Closing since has been solved differently

Jan 28 2022, 1:11 PM · Restricted Project
AndrewLitteken committed rG3785c1d05501: [IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching… (authored by AndrewLitteken).
[IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching…
Jan 28 2022, 11:52 AM

Jan 25 2022

AndrewLitteken committed rGba79295c48bb: [NFC][IROutliner] fix namespace and unused variable (authored by AndrewLitteken).
[NFC][IROutliner] fix namespace and unused variable
Jan 25 2022, 4:42 PM
AndrewLitteken committed rGe8f4e41b6bf4: [IRSim][IROutliner] Add support for outlining PHINodes with the rest of the… (authored by AndrewLitteken).
[IRSim][IROutliner] Add support for outlining PHINodes with the rest of the…
Jan 25 2022, 4:27 PM
AndrewLitteken closed D106997: [IRSim][IROutliner] Detecting Similar Phi Nodes and Outlining.
Jan 25 2022, 4:27 PM · Restricted Project
AndrewLitteken added a reverting change for rG515eec3553b0: [IRSim][IROutliner] Add support for outlining PHINodes with the rest of the…: rGe50b217b4e6f: Revert "[IRSim][IROutliner] Add support for outlining PHINodes with the rest of….
Jan 25 2022, 4:25 PM
AndrewLitteken committed rGe50b217b4e6f: Revert "[IRSim][IROutliner] Add support for outlining PHINodes with the rest of… (authored by AndrewLitteken).
Revert "[IRSim][IROutliner] Add support for outlining PHINodes with the rest of…
Jan 25 2022, 4:24 PM
AndrewLitteken committed rG515eec3553b0: [IRSim][IROutliner] Add support for outlining PHINodes with the rest of the… (authored by AndrewLitteken).
[IRSim][IROutliner] Add support for outlining PHINodes with the rest of the…
Jan 25 2022, 4:21 PM
AndrewLitteken added a reverting change for rG8de76bd56973: [IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching…: rG9c2daf648c9b: Revert "[IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity….
Jan 25 2022, 4:21 PM
AndrewLitteken committed rG9c2daf648c9b: Revert "[IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity… (authored by AndrewLitteken).
Revert "[IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity…
Jan 25 2022, 4:21 PM
AndrewLitteken added a reverting change for D109450: [IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching and Outlined Regions: rG9c2daf648c9b: Revert "[IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity….
Jan 25 2022, 4:21 PM · Restricted Project
AndrewLitteken committed rG8de76bd56973: [IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching… (authored by AndrewLitteken).
[IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching…
Jan 25 2022, 3:29 PM
AndrewLitteken closed D109450: [IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching and Outlined Regions.
Jan 25 2022, 3:29 PM · Restricted Project
AndrewLitteken added inline comments to rGf5f377d1fca8: [IRSim][IROutliner] Adding support for recognizing and outlining indirect….
Jan 25 2022, 3:05 PM
AndrewLitteken committed rGf5f377d1fca8: [IRSim][IROutliner] Adding support for recognizing and outlining indirect… (authored by AndrewLitteken).
[IRSim][IROutliner] Adding support for recognizing and outlining indirect…
Jan 25 2022, 1:21 PM
AndrewLitteken closed D109448: [IRSim][IROutliner] Treating Called Functions as Values and Outlining Indirect Calls.
Jan 25 2022, 1:21 PM · Restricted Project
AndrewLitteken committed rG4be86d18c0fc: [IROutliner] Disallow outlining calls that return twice. (authored by AndrewLitteken).
[IROutliner] Disallow outlining calls that return twice.
Jan 25 2022, 11:09 AM
AndrewLitteken closed D110007: [IROutliner] Disallow functions that return twice.
Jan 25 2022, 11:09 AM · Restricted Project
AndrewLitteken committed rGdcc3e728ca01: [IROutliner] Allowing Phi Nodes in exit blocks (authored by AndrewLitteken).
[IROutliner] Allowing Phi Nodes in exit blocks
Jan 25 2022, 9:34 AM
AndrewLitteken closed D106995: [IROutliner] Allowing PHINodes in Exit Blocks.
Jan 25 2022, 9:34 AM · Restricted Project

Jan 12 2022

AndrewLitteken updated the diff for D106995: [IROutliner] Allowing PHINodes in Exit Blocks.

Updating with one-liners and extra comments.

Jan 12 2022, 4:21 PM · Restricted Project
AndrewLitteken committed rG4ff4e7ea3033: [CostModel] Use cost of target trunc type when only it is the only use of a non… (authored by AndrewLitteken).
[CostModel] Use cost of target trunc type when only it is the only use of a non…
Jan 12 2022, 4:04 PM
AndrewLitteken closed D109388: [AArch64][CostModel] Use cost of target trunc type when only use of a non-register sized load.
Jan 12 2022, 4:04 PM · Restricted Project