Page MenuHomePhabricator
Feed Advanced Search

Today

sammccall accepted D74606: [clangd] Add add commit characters to the server capabilities.
Tue, Feb 18, 7:02 AM · Restricted Project

Yesterday

sammccall added a comment to D74731: [Clangd] Fixed assertion when processing extended ASCII characters..

Specifically, we can't change the return value for any valid utf-8 string (see tests).

Mon, Feb 17, 12:02 PM · Restricted Project
sammccall added a comment to D74731: [Clangd] Fixed assertion when processing extended ASCII characters..

Yeah I think there must be some confusion about what this code is doing. It's specifically iterating over the unicode codepoints of what are supposed to be UTF-8-encoded input bytes.

Mon, Feb 17, 11:53 AM · Restricted Project

Fri, Feb 14

sammccall added a comment to D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses.

The idea is this is an easy option for the user to work-around editors that do client-side filtering badly (everyone lets you add flags).
But as mentioned offline, I don't think we actually have an example of an editor this fixes (I think it fixes neither vscode nor coc.nvim). So in that case we shouldn't land it.

Fri, Feb 14, 8:23 AM

Thu, Feb 13

sammccall added inline comments to D74547: [clangd] Expose Code Completion score to the client.
Thu, Feb 13, 5:31 AM · Restricted Project
sammccall accepted D74547: [clangd] Expose Code Completion score to the client.
Thu, Feb 13, 5:31 AM · Restricted Project

Tue, Feb 11

sammccall commandeered D71920: [AST] Refactor propagation of dependency bits. NFC.

@ilya-biryukov isn't working on clang fulltime anymore :-(

Tue, Feb 11, 11:01 AM · Restricted Project
sammccall updated the diff for D71920: [AST] Refactor propagation of dependency bits. NFC.

Rebase (ConceptSpecializationExpr moved).
Added FIXME to use enum for concept requirement dependence, it's still murky to me.
addDependencies -> addDependence, for clarity.
Move variably-modified into TypeDependence bitfield.

Tue, Feb 11, 10:42 AM · Restricted Project
sammccall committed rGd4df372559ad: [clangd] Expose completion range in code completion results (C++ API) (authored by sammccall).
[clangd] Expose completion range in code completion results (C++ API)
Tue, Feb 11, 6:28 AM
sammccall closed D74305: [clangd] Expose completion range in code completion results (C++ API).
Tue, Feb 11, 6:28 AM · Restricted Project
sammccall added a comment to D74396: [clangd] Mention the CLANGD_TRACE env var in the overview as well..

That comment is talking about how CLANGD_FLAGS corresponds to command-line flags in general.

Tue, Feb 11, 4:12 AM · Restricted Project

Mon, Feb 10

sammccall accepted D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'.

LG, thanks! Just a nit about further simplifying the test, up to you.

Mon, Feb 10, 9:37 AM · Restricted Project
sammccall created D74305: [clangd] Expose completion range in code completion results (C++ API).
Mon, Feb 10, 2:56 AM · Restricted Project
sammccall accepted D72867: [clangd] Support renaming designated initializers.
Mon, Feb 10, 2:38 AM · Restricted Project
sammccall added a comment to D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'.

Looks pretty good now, thanks! Test needs to be more precise (doesn't actually test the behavior at present, I think).

Mon, Feb 10, 1:35 AM · Restricted Project

Fri, Feb 7

sammccall added a comment to D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'.

Thanks for this. It makes me a bit sad but I don't really see a clean way to make this "just work".

Fri, Feb 7, 9:49 AM · Restricted Project

Wed, Feb 5

sammccall accepted D74025: [clangd] Add the missing elaborated types in FindTarget..
Wed, Feb 5, 4:00 AM · Restricted Project
sammccall added a comment to D73696: [clang][Index] Introduce a TemplateParm SymbolKind.

Libclang changes need tests I think.

Wed, Feb 5, 3:24 AM · Restricted Project

Tue, Feb 4

sammccall committed rG2629035a0090: [clangd] Don't assert when completing a lambda variable inside the lambda. (authored by sammccall).
[clangd] Don't assert when completing a lambda variable inside the lambda.
Tue, Feb 4, 8:31 AM
sammccall closed D73960: [clangd] Don't assert when completing a lambda variable inside the lambda..
Tue, Feb 4, 8:31 AM · Restricted Project
sammccall committed rG2f4c4d0a78e3: Reland "[clangd] Mechanism to make update debounce responsive to rebuild speed." (authored by sammccall).
Reland "[clangd] Mechanism to make update debounce responsive to rebuild speed."
Tue, Feb 4, 8:22 AM
sammccall added a reverting change for rGed98994f64b8: Revert "[clangd] Mechanism to make update debounce responsive to rebuild speed.": rG2f4c4d0a78e3: Reland "[clangd] Mechanism to make update debounce responsive to rebuild speed.".
Tue, Feb 4, 8:22 AM
sammccall added a comment to D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed..

I agree it's a bit strange. The linux bot didn't recover after the revert either, so something's amiss.

My Win bot has been hanging since this landed and I just CRD'd in and it's hanging in check-clangd and there are tens of ClangdTests processes hanging around and doing nothing.

On the more official win bot, instead the link of ClangdTests has been failing since this landed, which on Windows is likely caused by the processes still hanging around (http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14120/steps/stage%201%20check/logs/stdio). This is the first bad build: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14113/

Tue, Feb 4, 8:13 AM · Restricted Project
sammccall added a comment to D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed..

This seems to break tests: http://45.33.8.238/linux/9296/step_9.txt

Tue, Feb 4, 6:51 AM · Restricted Project
sammccall committed rGed98994f64b8: Revert "[clangd] Mechanism to make update debounce responsive to rebuild speed." (authored by sammccall).
Revert "[clangd] Mechanism to make update debounce responsive to rebuild speed."
Tue, Feb 4, 6:42 AM
sammccall added a reverting change for rG92570718a86c: [clangd] Mechanism to make update debounce responsive to rebuild speed.: rGed98994f64b8: Revert "[clangd] Mechanism to make update debounce responsive to rebuild speed.".
Tue, Feb 4, 6:42 AM
sammccall committed rG69a39dc1f0d0: [clangd] Increase stack size of the new threads on macOS (authored by sammccall).
[clangd] Increase stack size of the new threads on macOS
Tue, Feb 4, 6:24 AM
sammccall closed D50993: [clangd] Increase stack size of the new threads on macOS.
Tue, Feb 4, 6:23 AM · Restricted Project
sammccall added a comment to D50993: [clangd] Increase stack size of the new threads on macOS.

Sorry we let this last piece get stuck in limbo, of course I was reminded of it when someone else hit this problem.

Tue, Feb 4, 6:23 AM · Restricted Project
sammccall created D73960: [clangd] Don't assert when completing a lambda variable inside the lambda..
Tue, Feb 4, 5:46 AM · Restricted Project
sammccall created D73949: [clangd] Debounce rebuilds responsively to rebuild times..
Tue, Feb 4, 3:49 AM · Restricted Project
sammccall committed rG92570718a86c: [clangd] Mechanism to make update debounce responsive to rebuild speed. (authored by sammccall).
[clangd] Mechanism to make update debounce responsive to rebuild speed.
Tue, Feb 4, 3:40 AM
sammccall closed D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed..
Tue, Feb 4, 3:40 AM · Restricted Project

Mon, Feb 3

sammccall created D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed..
Mon, Feb 3, 4:10 AM · Restricted Project
sammccall committed rG6b15a3d722a9: [clangd] TUScheduler::run() (i.e. workspace/symbol) counts towards concurrent… (authored by sammccall).
[clangd] TUScheduler::run() (i.e. workspace/symbol) counts towards concurrent…
Mon, Feb 3, 2:36 AM
sammccall committed rGb79cb547121d: [clangd] Refactor TUScheduler options into a struct. NFC (authored by sammccall).
[clangd] Refactor TUScheduler options into a struct. NFC
Mon, Feb 3, 2:27 AM

Thu, Jan 30

sammccall accepted D73690: [clangd] Make go-to-def jumps to overriden methods on `final` specifier..
Thu, Jan 30, 3:36 AM · Restricted Project
sammccall accepted D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension..
Thu, Jan 30, 2:35 AM · Restricted Project

Wed, Jan 29

sammccall committed rGb500c49cd4f8: [clangd] Don't mmap source files on all platforms --> don't crash on git… (authored by sammccall).
[clangd] Don't mmap source files on all platforms --> don't crash on git…
Wed, Jan 29, 10:45 AM
sammccall closed D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout.
Wed, Jan 29, 10:44 AM · Restricted Project
sammccall created D73649: [CodeComplete] Member completion for concept-constrained types..
Wed, Jan 29, 10:44 AM · Restricted Project
sammccall accepted D73628: [clangd] Log directory when a CDB is loaded.
Wed, Jan 29, 7:49 AM · Restricted Project
sammccall accepted D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer..

Thanks for the cleanup!

Wed, Jan 29, 5:31 AM · Restricted Project
sammccall added a comment to D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout.

Also I'd like to put this onto the 10 release branch because this is a big crasher, fix seems safe, we've run this code on windows for a while.

Wed, Jan 29, 4:28 AM · Restricted Project
sammccall accepted D73354: clang-format: insert trailing commas into containers..

(Maybe we should have a basic test for C++, but I'm not sure how this usually goes)

Wed, Jan 29, 4:18 AM · Restricted Project, Restricted Project
sammccall committed rGbcb3e42fdfb3: [clangd] Go-to-definition on 'override' jumps to overridden method(s) (authored by sammccall).
[clangd] Go-to-definition on 'override' jumps to overridden method(s)
Wed, Jan 29, 3:50 AM
sammccall closed D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s).
Wed, Jan 29, 3:50 AM · Restricted Project
sammccall committed rG6f6952780ba9: [clangd] add CODE_OWNERS (authored by sammccall).
[clangd] add CODE_OWNERS
Wed, Jan 29, 3:43 AM
sammccall closed D73537: [clangd] add CODE_OWNERS.
Wed, Jan 29, 3:43 AM · Restricted Project
sammccall accepted D73610: [clangd] Replace raw lexer code with token buffer in prepare rename..
Wed, Jan 29, 3:40 AM · Restricted Project
sammccall updated the summary of D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout.
Wed, Jan 29, 3:25 AM · Restricted Project
sammccall created D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout.
Wed, Jan 29, 3:25 AM · Restricted Project
sammccall added reviewers for D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout: ilya-biryukov, kadircet.
Wed, Jan 29, 3:25 AM · Restricted Project
sammccall added inline comments to D73613: [clangd][Hover] Make tests hermetic by setting target triplet.
Wed, Jan 29, 3:16 AM · Restricted Project
sammccall accepted D73615: [clangd] Get rid of delayed template parsing.
Wed, Jan 29, 3:12 AM · Restricted Project
sammccall accepted D73612: [clangd] Update lsp dependencies to pickup the progress support in LSP 3.15.

LG. (The internal google mirror of VSCode is stuck at 1.38, but this should just fail to update the extension I think)

Wed, Jan 29, 3:12 AM · Restricted Project
sammccall accepted D73613: [clangd][Hover] Make tests hermetic by setting target triplet.
Wed, Jan 29, 2:31 AM · Restricted Project
sammccall added a comment to D73610: [clangd] Replace raw lexer code with token buffer in prepare rename..

Nice, thanks!

Wed, Jan 29, 2:15 AM · Restricted Project

Tue, Jan 28

sammccall created D73596: [CodeComplete] WIP member completion for concept-constrained type parameters.
Tue, Jan 28, 5:20 PM · Restricted Project
sammccall committed rG9a5c448a31ba: [clangd] Fix null check in FindTarget. (authored by sammccall).
[clangd] Fix null check in FindTarget.
Tue, Jan 28, 5:11 PM
sammccall accepted D73271: [clang][CodeComplete] Support for designated initializers.
Tue, Jan 28, 7:08 AM · Restricted Project
sammccall accepted D73538: [clangd] Make bin/llvm-lit run standalone clangd tests.
Tue, Jan 28, 7:01 AM · Restricted Project
sammccall added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto

// Copy pointers, but make it clear that they're pointers.
for (const auto *Ptr : Container) { observe(*Ptr); }
for (auto *Ptr : Container) { Ptr->change(); }

This is the reasoning behind putting the const qualifier in the check. If people feel that this isn't quite enough to justify the const qualifier I'll submit a follow up. The general consensus though is that you should mark auto pointers as const if they don't need to change to express intent

Tue, Jan 28, 4:05 AM · Restricted Project, Restricted Project
sammccall created D73537: [clangd] add CODE_OWNERS.
Tue, Jan 28, 3:18 AM · Restricted Project
sammccall added a comment to D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s).

(the clang-tidy check doesn't reflect a style guideline and I'm not sure it's a good idea, raised on D72217 which added it)

Tue, Jan 28, 3:09 AM · Restricted Project
sammccall updated the diff for D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s).

address comment and clang-format

Tue, Jan 28, 3:09 AM · Restricted Project
sammccall added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

This check as configured for LLVM itself is pretty noisy, generating warnings like:

Tue, Jan 28, 3:00 AM · Restricted Project, Restricted Project
sammccall committed rGf4871ead55f5: [clangd] Support pseudo-obj expr, opaque values, and property references in… (authored by sammccall).
[clangd] Support pseudo-obj expr, opaque values, and property references in…
Tue, Jan 28, 2:15 AM
sammccall closed D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences().
Tue, Jan 28, 2:15 AM · Restricted Project
sammccall committed rGaf071f03f379: [clangd] Improve ObjC property handling in SelectionTree. (authored by sammccall).
[clangd] Improve ObjC property handling in SelectionTree.
Tue, Jan 28, 2:15 AM
sammccall closed D72634: [clangd] Improve ObjC property handling in SelectionTree..
Tue, Jan 28, 2:14 AM · Restricted Project
sammccall updated the diff for D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences().

Address comments

Tue, Jan 28, 2:14 AM · Restricted Project

Sat, Jan 25

sammccall accepted D72647: [clangd] Only re-open files if their flags changed.
Sat, Jan 25, 7:16 AM · Restricted Project
sammccall added inline comments to D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences().
Sat, Jan 25, 7:06 AM · Restricted Project
sammccall updated the diff for D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences().

more tests

Sat, Jan 25, 7:06 AM · Restricted Project
sammccall updated the diff for D72634: [clangd] Improve ObjC property handling in SelectionTree..

more tests

Sat, Jan 25, 6:53 AM · Restricted Project
sammccall committed rGd08563486e06: [clangd] Make Notification a little safer. (authored by sammccall).
[clangd] Make Notification a little safer.
Sat, Jan 25, 6:33 AM
sammccall committed rG18e6a65bae93: [Support] Fix race in threading test, found by TSan (authored by sammccall).
[Support] Fix race in threading test, found by TSan
Sat, Jan 25, 6:24 AM

Fri, Jan 24

sammccall created D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code..
Fri, Jan 24, 9:35 AM · Restricted Project
sammccall created D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s).
Fri, Jan 24, 9:26 AM · Restricted Project
sammccall added a comment to D73354: clang-format: insert trailing commas into containers..

I have an issue with this change. Currently (at least for C++), the presence of a trailing comma is used as a formatting hint to put all the element in one line or one per line as below:

Good point about the interaction with bin-packing.
Do the style guides that want this actually endorse bin-packing containers? Insertion + bin-packing + comma-as-hint basically can't coexist - we could turn off the hint or make this option mutually exclusive with bin-packing.

Fri, Jan 24, 8:40 AM · Restricted Project, Restricted Project
sammccall added a comment to D73354: clang-format: insert trailing commas into containers..

For rolling this out, I think the best path is:

  • check in the option, but don't turn it on with any styles yet
  • test it by taking a large codebase, formatting it (normal options), format it (with comma insertion), look at the diffs (internally google3diff can do this)
  • turn it on for -style=google
Fri, Jan 24, 8:14 AM · Restricted Project, Restricted Project
sammccall committed rG76fa5d50f3d1: [clangd] Remove pesky ;. NFC (authored by sammccall).
[clangd] Remove pesky ;. NFC
Fri, Jan 24, 7:17 AM
sammccall committed rG6ef1ccecf7ae: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it… (authored by sammccall).
[clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it…
Fri, Jan 24, 7:00 AM
sammccall closed D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional.
Fri, Jan 24, 7:00 AM · Restricted Project
sammccall added inline comments to D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional.
Fri, Jan 24, 6:59 AM · Restricted Project
sammccall accepted D73344: [clangd][Hover] Handle uninstantiated templates.

Can you file a new bug or modify the upstream one to audit existing uses of getTemplateInstantiationPattern() (and maybe related functions)?

Fri, Jan 24, 5:28 AM · Restricted Project
sammccall updated the diff for D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional.

Document new interface and threading model of existing functions.

Fri, Jan 24, 5:19 AM · Restricted Project
sammccall created D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional.
Fri, Jan 24, 5:11 AM · Restricted Project
sammccall committed rG7d20e80225b3: [clangd] Show background index status using LSP 3.15 work-done progress… (authored by sammccall).
[clangd] Show background index status using LSP 3.15 work-done progress…
Fri, Jan 24, 3:22 AM
sammccall closed D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications.
Fri, Jan 24, 3:22 AM · Restricted Project, Restricted Project
sammccall accepted D73336: [clangd][Hover] Change arrow in return type back to →.
Fri, Jan 24, 3:13 AM · Restricted Project
sammccall committed rGd3260bf5b2f7: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok. (authored by sammccall).
[clangd] Errors in TestTU cause test failures unless suppressed with error-ok.
Fri, Jan 24, 2:17 AM
sammccall closed D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok..
Fri, Jan 24, 2:17 AM · Restricted Project
sammccall added inline comments to D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok..
Fri, Jan 24, 2:08 AM · Restricted Project
sammccall committed rGb3b68c0f802e: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left. (authored by sammccall).
[Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left.
Fri, Jan 24, 2:05 AM
sammccall closed D73334: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left..
Fri, Jan 24, 2:05 AM · Restricted Project
sammccall updated the diff for D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications.

address comments

Fri, Jan 24, 1:32 AM · Restricted Project, Restricted Project
sammccall added inline comments to D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications.
Fri, Jan 24, 1:32 AM · Restricted Project, Restricted Project
sammccall created D73334: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left..
Fri, Jan 24, 1:15 AM · Restricted Project