Page MenuHomePhabricator
Feed Advanced Search

Yesterday

ilya-biryukov added inline comments to D64863: [clangd] Ignore diags from builtin files.
Mon, Jul 22, 4:11 AM · Restricted Project
ilya-biryukov committed rGaf5d3b02fbc6: [clangd] Log input code of failed highlighting tests. NFC (authored by ilya-biryukov).
[clangd] Log input code of failed highlighting tests. NFC
Mon, Jul 22, 3:07 AM
ilya-biryukov committed rG0a42fe70a566: [AST] Treat semantic form of InitListExpr as implicit code in traversals (authored by ilya-biryukov).
[AST] Treat semantic form of InitListExpr as implicit code in traversals
Mon, Jul 22, 3:02 AM
ilya-biryukov added inline comments to D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
Mon, Jul 22, 2:45 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
  • Rewrite code as suggested in the review
Mon, Jul 22, 2:45 AM · Restricted Project, Restricted Project

Fri, Jul 19

ilya-biryukov added inline comments to D64863: [clangd] Ignore diags from builtin files.
Fri, Jul 19, 7:37 AM · Restricted Project
ilya-biryukov added inline comments to D64863: [clangd] Ignore diags from builtin files.
Fri, Jul 19, 7:09 AM · Restricted Project
ilya-biryukov committed rG8bb8915d43fe: [clangd] Provide a way to publish highlightings in non-racy manner (authored by ilya-biryukov).
[clangd] Provide a way to publish highlightings in non-racy manner
Fri, Jul 19, 6:52 AM
ilya-biryukov added a comment to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

The fix for a race condition on remove has landed in rL366577, this revision would need a small update after it.

Fri, Jul 19, 6:51 AM · Restricted Project
ilya-biryukov updated the diff for D64985: [clangd] Provide a way to publish highlightings in non-racy manner.
  • Group PublishFn with onMainAST
Fri, Jul 19, 6:43 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..
Fri, Jul 19, 6:39 AM · Restricted Project
ilya-biryukov added a comment to D64638: [CrossTU] Fix plist macro expansion if macro in other file..

StaticAnalyzer/Core does not depend on clangFrontend now, you can see this by looking at lib/StaticAnalyzer/Core/CMakeLists.txt:

add_clang_library(clangStaticAnalyzerCore
...
  LINK_LIBS
  clangAST
  clangASTMatchers
  clangAnalysis
  clangBasic
  clangCrossTU
  clangLex
  clangRewrite
  )

Not a StaticAnalyzer expert, so I don't know whether it's acceptable to add this dependency to clangStaticAnalyzerCore, you'll have to find someone who owns the code to know whether this dependency is justified.
(My wild guess from looking at the names of the libraries would be that this dependency is not ok and the code should go into clangStaticAnalyzerFrontend instead. But again, not an expert here, just a guess).

Fri, Jul 19, 5:58 AM · Restricted Project
ilya-biryukov updated the diff for D64985: [clangd] Provide a way to publish highlightings in non-racy manner.
  • Remove a leftover comment from the previous version
Fri, Jul 19, 5:47 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D64985: [clangd] Provide a way to publish highlightings in non-racy manner.

Thanks for all the suggestions. This is ready for the next round now.

Fri, Jul 19, 5:46 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D64985: [clangd] Provide a way to publish highlightings in non-racy manner.
  • Update usage of DiagsMu in a comment
Fri, Jul 19, 5:42 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D64985: [clangd] Provide a way to publish highlightings in non-racy manner.
  • Use the same mechanism for diagnostics
  • Change typedef to function<void(function<void()>)>
  • Update a comment
  • s/PublishResults/PublishFn
  • Reformat
Fri, Jul 19, 5:34 AM · Restricted Project, Restricted Project
ilya-biryukov created D64985: [clangd] Provide a way to publish highlightings in non-racy manner.
Fri, Jul 19, 2:57 AM · Restricted Project, Restricted Project

Thu, Jul 18

ilya-biryukov committed rGcf41271448bd: [ASTUnit] Attempt to unbreak Windows buildbots after r366448 (authored by ilya-biryukov).
[ASTUnit] Attempt to unbreak Windows buildbots after r366448
Thu, Jul 18, 9:25 AM
ilya-biryukov accepted D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

LGTM

Thu, Jul 18, 9:20 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D64924: [LibTooling] Add function to translate and validate source range for editing.

LGTM

Thu, Jul 18, 9:20 AM · Restricted Project, Restricted Project
ilya-biryukov committed rGabc744d2631f: Revert r366449: [CrossTU] Add a function to retrieve original source location. (authored by ilya-biryukov).
Revert r366449: [CrossTU] Add a function to retrieve original source location.
Thu, Jul 18, 8:44 AM
ilya-biryukov added a comment to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

@rsmith, I'll look into emitting the typos when we pop expression evaluation context, but do we expect this to cover all cases where TypoExprs are produced?
(conservatively assuming that the answer is "no") should we land this patch and also emit at the end of TU in addition to expression evaluation context?

Thu, Jul 18, 8:35 AM · Restricted Project
ilya-biryukov accepted D64915: [clangd] cleanup: unify the implemenation of checking a location is inside main file..

LGTM

Thu, Jul 18, 8:25 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG5de0c85e88be: [ASTUnit] Fix a regression in cached completions (authored by ilya-biryukov).
[ASTUnit] Fix a regression in cached completions
Thu, Jul 18, 8:25 AM
ilya-biryukov added inline comments to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..
Thu, Jul 18, 8:18 AM · Restricted Project
ilya-biryukov added inline comments to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..
Thu, Jul 18, 8:04 AM · Restricted Project
ilya-biryukov added inline comments to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..
Thu, Jul 18, 7:54 AM · Restricted Project
ilya-biryukov added a comment to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

A few suggestions from me, I haven't looked into the diffing algorithm and the tests yet.

Thu, Jul 18, 7:26 AM · Restricted Project
ilya-biryukov added inline comments to D64918: [ASTUnit] Fix a regression in cached completions.
Thu, Jul 18, 7:01 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D64918: [ASTUnit] Fix a regression in cached completions.
  • s/preamble/cached completions (in tests)
Thu, Jul 18, 7:01 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D64627: [clangd] Suppress unwritten scopes when expanding auto..

LGTM

Thu, Jul 18, 7:01 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D64915: [clangd] cleanup: unify the implemenation of checking a location is inside main file..

Neat! Many thanks, that's a very useful cleanup.
A few suggestions from my side.

Thu, Jul 18, 6:41 AM · Restricted Project, Restricted Project
ilya-biryukov created D64918: [ASTUnit] Fix a regression in cached completions.
Thu, Jul 18, 6:33 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG4f8dc16fcdb6: Revert r366422: [OpenCL] Improve destructor support in C++ for OpenCL (authored by ilya-biryukov).
Revert r366422: [OpenCL] Improve destructor support in C++ for OpenCL
Thu, Jul 18, 4:57 AM
ilya-biryukov added a comment to D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro.

Wanted to write unit tests, but couldn't find any that check traversal order. I'm aware of Tooling/RecursiveASTVisitorTests, but they mostly check that implicit nodes are visited.
Do we have other tests for traversals?

Thu, Jul 18, 2:45 AM · Restricted Project
ilya-biryukov updated the diff for D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro.
  • Visit attributes before visiting the Decl
Thu, Jul 18, 2:42 AM · Restricted Project
ilya-biryukov created D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro.
Thu, Jul 18, 2:37 AM · Restricted Project
ilya-biryukov added inline comments to D64863: [clangd] Ignore diags from builtin files.
Thu, Jul 18, 1:32 AM · Restricted Project

Wed, Jul 17

ilya-biryukov added a comment to D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

This seems like a good candidate for configuration -- the user could then choose which mode to run in. But, I'm also open to just reporting these conditions as errors. It's already in a context that returns Expected, so its no trouble; it's just a matter of choosing what we think is "correct".

WRT to returning Expected vs Optional. Either seems fine and in the spirit of the library, depending on whether we want to produce more detailed errors. However, if we choose Optional let's stick to it, as practice shows switching from Optional to Expected correctly is almost impossible, as that requires a lot of attention to make sure all clients consume the errors (and given that it's an error case, tests often don't catch unconsumed errors).
I would personally go with Optional here (meaning the client code would have to say something generic like could not map from macro expansion to source code). But up to you, not a strong preference.

I think we might be talking about different things here. I meant that the *calling* function, translateEdits, returns Expected, so it would be easy to return an error when makeValidRange returns None. I agree that makeValidRange (or whatever we choose to call it) should stick with Optional for simplicity (with the generic interpretation of None being "could not map from macro expansion to source code").

Ah, great, we're on the same page then. LGTM!

Wed, Jul 17, 11:10 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

This seems like a good candidate for configuration -- the user could then choose which mode to run in. But, I'm also open to just reporting these conditions as errors. It's already in a context that returns Expected, so its no trouble; it's just a matter of choosing what we think is "correct".

WRT to returning Expected vs Optional. Either seems fine and in the spirit of the library, depending on whether we want to produce more detailed errors. However, if we choose Optional let's stick to it, as practice shows switching from Optional to Expected correctly is almost impossible, as that requires a lot of attention to make sure all clients consume the errors (and given that it's an error case, tests often don't catch unconsumed errors).
I would personally go with Optional here (meaning the client code would have to say something generic like could not map from macro expansion to source code). But up to you, not a strong preference.

Wed, Jul 17, 10:15 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D64864: [CodeComplete] Fix ASTUnit cached completion of macros from preamble, broken in r342528.

LGTM

Wed, Jul 17, 10:04 AM · Restricted Project
ilya-biryukov added a comment to D64863: [clangd] Ignore diags from builtin files.

Thanks for switching to SM everywhere, makes the code much more readable!

Wed, Jul 17, 8:44 AM · Restricted Project
ilya-biryukov updated the diff for D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.
  • Remove -disable-free from the test, it is no longer required to workaround the crash
Wed, Jul 17, 8:27 AM · Restricted Project
ilya-biryukov committed rGf81ee439a409: [clang-tidy] Adjust location of namespace comment diagnostic (authored by ilya-biryukov).
[clang-tidy] Adjust location of namespace comment diagnostic
Wed, Jul 17, 8:23 AM
ilya-biryukov added a comment to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

I tried to find a good place to emit unresolved typos earlier (to make sure CodeGen does not ever get TypoExpr), but couldn't find one.
Please let me know if there's some obvious place I'm missing.

Wed, Jul 17, 8:13 AM · Restricted Project
ilya-biryukov created D64861: [clang-tidy] Adjust location of namespace comment diagnostic.
Wed, Jul 17, 6:05 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D64741: [clangd] Added highlighting for tokens that are macro arguments..

Thanks for pointing out I missed stuff. The strategy for conflicting highlightings LG, just a few NITs left from my side.

Wed, Jul 17, 4:01 AM · Restricted Project
ilya-biryukov added a comment to D64741: [clangd] Added highlighting for tokens that are macro arguments..

I had completely missed that there could be conflicting tokens when only highlighting macro arguments as well. Added code to just remove conflicting tokens.

Picking one of the highlightings looks fine, but we probably want to make sure it's deterministic. Given that we use sort now, I bet it won't be. Maybe include kinds into comparison as well? That's not a perfect solution, but would at least make sure the user-visible behavior is not random.
Could you add tests for that case too?

Wed, Jul 17, 1:31 AM · Restricted Project

Tue, Jul 16

ilya-biryukov updated the diff for D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

Fix a typo (xD)

Tue, Jul 16, 8:23 AM · Restricted Project
ilya-biryukov created D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.
Tue, Jul 16, 8:03 AM · Restricted Project
ilya-biryukov added inline comments to D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
Tue, Jul 16, 3:22 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D64741: [clangd] Added highlighting for tokens that are macro arguments..

How should this behave when if the same token is used multiple times inside a macro and the uses are different? Could we add this to tests?
E.g.

#define W(a) class a { void test() { int a = 10; } }
W(foo); // <-- `foo` is a variable of a class?
Tue, Jul 16, 2:48 AM · Restricted Project
ilya-biryukov updated the diff for D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
  • Add a test.
Tue, Jul 16, 2:42 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
Tue, Jul 16, 12:05 AM · Restricted Project, Restricted Project

Mon, Jul 15

ilya-biryukov updated the summary of D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
Mon, Jul 15, 11:03 AM · Restricted Project, Restricted Project
ilya-biryukov created D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
Mon, Jul 15, 10:57 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

This clearly increases the utility of the library, but also seems to add corner cases that the library won't handle (see the comment about unittests for an example).
WDYT about those? Are they important, should we support producing warnings in those cases to let the users know things might get broken?

Mon, Jul 15, 10:04 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG7284d443c3ba: Revert "r366069: [PatternMatch] Implement matching code for LibFunc" (authored by ilya-biryukov).
Revert "r366069: [PatternMatch] Implement matching code for LibFunc"
Mon, Jul 15, 9:45 AM
ilya-biryukov abandoned D64747: [clangd] Skip implicit nodes when traversing for highlightings.

Ah, sorry, that's actually the default...

Mon, Jul 15, 8:00 AM · Restricted Project
ilya-biryukov created D64747: [clangd] Skip implicit nodes when traversing for highlightings.
Mon, Jul 15, 8:00 AM · Restricted Project
ilya-biryukov accepted D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.

LGTM (I think @hokein 's comments were addressed too)

Mon, Jul 15, 7:52 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.

Have we tried figuring out why RecursiveASTVisitor visits the argument lists twice? Is that an expected behavior?

Mon, Jul 15, 6:49 AM · Restricted Project, Restricted Project

Thu, Jul 11

ilya-biryukov created D64576: [Syntax] Do not add a node for 'eof' into the tree.
Thu, Jul 11, 11:12 AM · Restricted Project
ilya-biryukov added a child revision for D63835: [Syntax] Add nodes for most common statements: D64573: [Syntax] Allow to mutate syntax trees.
Thu, Jul 11, 9:44 AM · Restricted Project
ilya-biryukov created D64573: [Syntax] Allow to mutate syntax trees.
Thu, Jul 11, 9:44 AM · Restricted Project
ilya-biryukov added a parent revision for D64573: [Syntax] Allow to mutate syntax trees: D63835: [Syntax] Add nodes for most common statements.
Thu, Jul 11, 9:44 AM · Restricted Project
ilya-biryukov added inline comments to D64565: [clangd] Don't run the prepare for tweaks that are disabled..
Thu, Jul 11, 7:53 AM · Restricted Project, Restricted Project

Wed, Jul 10

ilya-biryukov added a comment to D63835: [Syntax] Add nodes for most common statements.

This is ready for another round

Wed, Jul 10, 9:50 AM · Restricted Project
ilya-biryukov updated the diff for D63835: [Syntax] Add nodes for most common statements.
  • Mark groups of kinds for statements and expressions
Wed, Jul 10, 9:48 AM · Restricted Project
ilya-biryukov added inline comments to D63835: [Syntax] Add nodes for most common statements.
Wed, Jul 10, 6:29 AM · Restricted Project
ilya-biryukov updated the diff for D63835: [Syntax] Add nodes for most common statements.
  • Rebase
  • Address comments
  • Restructure the roles
  • Remove the role from tree dumps for now With too many roles it is annoying to update the test outputs on incremental changes. I tried using the symbolic role names there, but they end up being too verbose.
Wed, Jul 10, 6:29 AM · Restricted Project
ilya-biryukov accepted D64481: [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements..

LGTM with a small NIT.

Wed, Jul 10, 6:22 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG57852878c0ff: [clangd] Stop recording tokens before running clang-tidy (authored by ilya-biryukov).
[clangd] Stop recording tokens before running clang-tidy
Wed, Jul 10, 2:30 AM
ilya-biryukov committed rG18cb8e401c45: [clangd] Consume error to avoid assertion failures (authored by ilya-biryukov).
[clangd] Consume error to avoid assertion failures
Wed, Jul 10, 2:21 AM
ilya-biryukov committed rG625a0f70a988: [Syntax] Add assertion to catch invalid tokens early. NFC (authored by ilya-biryukov).
[Syntax] Add assertion to catch invalid tokens early. NFC
Wed, Jul 10, 1:29 AM
ilya-biryukov added a comment to D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be applied by -fixit, available to libclang and clangd, etc)..

One major drawback that I see is the lack of indentation (and other format options) in the added code.
Should we have this fix at a higher level that can have formatting (either now or in the future)? E.g. in clangd directly?

Wed, Jul 10, 12:58 AM · Restricted Project

Tue, Jul 9

ilya-biryukov added a comment to D63835: [Syntax] Add nodes for most common statements.

Submitting a few comments to start up the discussions.

Tue, Jul 9, 8:02 AM · Restricted Project
ilya-biryukov committed rG51dad4196e58: [Syntax] Move roles into a separate enum (authored by ilya-biryukov).
[Syntax] Move roles into a separate enum
Tue, Jul 9, 6:32 AM
ilya-biryukov abandoned D61637: [Syntax] Introduce syntax trees.
Tue, Jul 9, 4:35 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG9b3f38f99085: Reland r365355: [Syntax] Introduce syntax trees (authored by ilya-biryukov).
Reland r365355: [Syntax] Introduce syntax trees
Tue, Jul 9, 4:34 AM
ilya-biryukov added a comment to D61637: [Syntax] Introduce syntax trees.

Relanded in rL365466 with a fix to the crash.

Tue, Jul 9, 4:33 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D61637: [Syntax] Introduce syntax trees.

@ilya-biryukov We're seeing buildbot failures in SyntaxTests.exe :
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/50927
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26822

Failing Tests (1):

Clang-Unit :: Tooling/Syntax/./SyntaxTests.exe/SyntaxTreeTest.Basic
Tue, Jul 9, 4:27 AM · Restricted Project, Restricted Project

Mon, Jul 8

ilya-biryukov committed rGb736969eddce: [Syntax] Introduce syntax trees (authored by ilya-biryukov).
[Syntax] Introduce syntax trees
Mon, Jul 8, 10:28 AM
ilya-biryukov closed D61637: [Syntax] Introduce syntax trees.
Mon, Jul 8, 10:27 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D61637: [Syntax] Introduce syntax trees.
Mon, Jul 8, 10:27 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D61637: [Syntax] Introduce syntax trees.
  • s/TranslationUnitDeclaration/TranslationUnit
  • Remove accessor from 'eof', add a FIXME to remove it from the tree altogether
Mon, Jul 8, 10:23 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG4aa2873fdce5: [clangd] A code tweak to expand a macro (authored by ilya-biryukov).
[clangd] A code tweak to expand a macro
Mon, Jul 8, 8:27 AM
ilya-biryukov added inline comments to D61681: [clangd] A code tweak to expand a macro.
Mon, Jul 8, 8:20 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D61681: [clangd] A code tweak to expand a macro.
  • Replace bsearch with partition_point.
  • Include macro name in the title.
  • Added a FIXME for empty selection case.
  • Return null when no token is found.
Mon, Jul 8, 8:20 AM · Restricted Project, Restricted Project

Wed, Jun 26

ilya-biryukov added a comment to D63835: [Syntax] Add nodes for most common statements.

This change mostly aims to illustrate that TreeBuilder seems to be powerful enough to go beyond basic nodes.
But it also introduces enough nodes to make the syntax trees minimally useful for traversing statement nodes. Hopefully that could become a good basis to define other APIs (mutations, etc).

Wed, Jun 26, 11:54 AM · Restricted Project
ilya-biryukov added a child revision for D61637: [Syntax] Introduce syntax trees: D63835: [Syntax] Add nodes for most common statements.
Wed, Jun 26, 11:48 AM · Restricted Project, Restricted Project
ilya-biryukov added a parent revision for D63835: [Syntax] Add nodes for most common statements: D61637: [Syntax] Introduce syntax trees.
Wed, Jun 26, 11:48 AM · Restricted Project
ilya-biryukov created D63835: [Syntax] Add nodes for most common statements.
Wed, Jun 26, 11:48 AM · Restricted Project
ilya-biryukov added a comment to D61637: [Syntax] Introduce syntax trees.

This is now in a pretty good shape, I've incorporated changes after our offline discussions about child roles.
The builder interface is also much richer now, removing a requirement that the tree has to be traversed left-to-right (bottom-up is still required!).

Wed, Jun 26, 11:26 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D61637: [Syntax] Introduce syntax trees.
  • Remove (outdated) changes to gn files
Wed, Jun 26, 11:22 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D61637: [Syntax] Introduce syntax trees.
  • Introduce roles to allow distinguishing the child nodes.
  • Remove recovery node, use an unknown role instead.
  • TreeBuidler now can consume children at any point, not just suffix nodes.
Wed, Jun 26, 11:20 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D63821: [clangd] Added C++ API code for semantic highlighting.
Wed, Jun 26, 8:00 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D63817: [clangd] No longer getting template instantiations from header files in Main AST..
Wed, Jun 26, 7:49 AM · Restricted Project, Restricted Project

Tue, Jun 25

ilya-biryukov added a reviewer for D61681: [clangd] A code tweak to expand a macro: sammccall.
Tue, Jun 25, 1:34 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D61681: [clangd] A code tweak to expand a macro.
  • Rebase
  • Update some comments
Tue, Jun 25, 1:34 AM · Restricted Project, Restricted Project