Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 3

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

@jdoerfert , @clementval : over in D83032 is a polished-up version of the script I used to check where the missing deps needed to go. Might be useful for the next problem of this kind. But I'm not sure who to get to review it; perhaps one of you might look at it?

Fri, Jul 3, 1:35 AM · Restricted Project, Restricted Project

Thu, Jul 2

simon_tatham created D83032: [utils] New script `check_ninja_deps.py`.
Thu, Jul 2, 4:15 AM · Restricted Project
simon_tatham committed rG9e6f19fd8390: Fix missing build dependency on omp_gen. (authored by simon_tatham).
Fix missing build dependency on omp_gen.
Thu, Jul 2, 1:34 AM
simon_tatham closed D82659: Fix missing build dependency on omp_gen..
Thu, Jul 2, 1:34 AM · Restricted Project, Restricted Project

Wed, Jul 1

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be removed right?

Wed, Jul 1, 8:42 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

[facepalm] Thank you. I carefully wrote a revised description, but forgot to upload it to this issue.

Wed, Jul 1, 8:42 AM · Restricted Project, Restricted Project
simon_tatham updated the summary of D82659: Fix missing build dependency on omp_gen..
Wed, Jul 1, 8:42 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D82659: Fix missing build dependency on omp_gen..

Here's a completely different patch, which adds all the missing dependencies on OMP.h.inc in the clang subdirectory in one go.

Wed, Jul 1, 3:44 AM · Restricted Project, Restricted Project

Tue, Jun 30

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

Cannot you just add a depends for your failing case?

Tue, Jun 30, 9:12 AM · Restricted Project, Restricted Project
simon_tatham reopened D82659: Fix missing build dependency on omp_gen..

Unfortunately, I had to revert this because it caused a buildbot failure: rG39ea5d74b283d5a42f34b856d22bfaf806a1c907

Tue, Jun 30, 5:23 AM · Restricted Project, Restricted Project
simon_tatham added a reverting change for rGed4328c60730: Fix missing build dependency on omp_gen.: rG39ea5d74b283: Revert "Fix missing build dependency on omp_gen.".
Tue, Jun 30, 2:08 AM
simon_tatham committed rG39ea5d74b283: Revert "Fix missing build dependency on omp_gen." (authored by simon_tatham).
Revert "Fix missing build dependency on omp_gen."
Tue, Jun 30, 2:08 AM
simon_tatham committed rGed4328c60730: Fix missing build dependency on omp_gen. (authored by simon_tatham).
Fix missing build dependency on omp_gen.
Tue, Jun 30, 1:03 AM
simon_tatham closed D82659: Fix missing build dependency on omp_gen..
Tue, Jun 30, 1:02 AM · Restricted Project, Restricted Project

Mon, Jun 29

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

@clementval , are you happy for me to commit this patch?

Mon, Jun 29, 6:58 AM · Restricted Project, Restricted Project

Fri, Jun 26

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

I wondered about that. I think it may well mean some of those DEPENDS can be removed, but I'm not sure how to be certain of it :-)

Fri, Jun 26, 8:44 AM · Restricted Project, Restricted Project
simon_tatham created D82659: Fix missing build dependency on omp_gen..
Fri, Jun 26, 8:10 AM · Restricted Project, Restricted Project
simon_tatham committed rG41eb63929183: Fix implicit include dependencies on SmallVector.h. (authored by simon_tatham).
Fix implicit include dependencies on SmallVector.h.
Fri, Jun 26, 5:58 AM

Wed, Jun 24

simon_tatham accepted D81339: [ARM] MVE VCVT lowering for f16->f32 extends.
Wed, Jun 24, 9:09 AM · Restricted Project
simon_tatham committed rGb769eb02b526: [ARM][BFloat] Legalize bf16 type even without fullfp16. (authored by simon_tatham).
[ARM][BFloat] Legalize bf16 type even without fullfp16.
Wed, Jun 24, 2:08 AM
simon_tatham closed D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Wed, Jun 24, 2:08 AM · Restricted Project
simon_tatham accepted D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

LGTM. Thanks for the fixes.

Wed, Jun 24, 1:34 AM · Restricted Project

Tue, Jun 23

simon_tatham added inline comments to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Tue, Jun 23, 9:37 AM · Restricted Project
simon_tatham updated the diff for D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

Updated for @dmgreen's review suggestions, which both seem to work as far as I can see.

Tue, Jun 23, 9:04 AM · Restricted Project
simon_tatham added inline comments to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Tue, Jun 23, 9:04 AM · Restricted Project
simon_tatham added a comment to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

It isn't unused – there are still some isel patterns using it, which I haven't touched in this commit.

Tue, Jun 23, 8:31 AM · Restricted Project
simon_tatham added inline comments to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Tue, Jun 23, 7:25 AM · Restricted Project
simon_tatham updated subscribers of D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

(Sorry @labrinea – removing you as a reviewer was an unintentional side effect of a bad arc command.)

Tue, Jun 23, 7:25 AM · Restricted Project
simon_tatham added a reviewer for D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16.: labrinea.
Tue, Jun 23, 7:25 AM · Restricted Project
simon_tatham updated the diff for D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

New version addressing review comments.

Tue, Jun 23, 7:25 AM · Restricted Project
simon_tatham created D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Tue, Jun 23, 5:49 AM · Restricted Project
simon_tatham added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

OK, fair enough. In that case, please correct my nitpicks and I'll approve the revised patch.

Tue, Jun 23, 2:36 AM · Restricted Project

Mon, Jun 22

simon_tatham added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

for ARMv7 we only disallowed this pair, and this change removes that restriction. So now, all of them are allowed...

Mon, Jun 22, 6:24 AM · Restricted Project
simon_tatham added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

I've made a couple of nitpicks to the patch, but my more general question is: if we think that this pair of coprocessors should be changed from "reject completely" to "accept with a warning", why not all of them? What argument applies to CP10 and CP11 that doesn't apply to all the others, apart from the immediate short-term argument of "this is the one that's currently causing somebody a problem"?

Mon, Jun 22, 2:38 AM · Restricted Project

Wed, Jun 17

simon_tatham added inline comments to D80865: [TableGen] defm in a loop is not final (bug fix).
Wed, Jun 17, 1:34 AM · Restricted Project

Mon, Jun 15

simon_tatham added inline comments to D80865: [TableGen] defm in a loop is not final (bug fix).
Mon, Jun 15, 6:28 AM · Restricted Project

May 28 2020

simon_tatham added inline comments to D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
May 28 2020, 7:02 AM · Restricted Project, Restricted Project

May 5 2020

simon_tatham accepted D79402: [ARM] Correct the type on a predicate cast.
May 5 2020, 3:11 AM · Restricted Project

Apr 21 2020

simon_tatham accepted D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 21 2020, 8:04 AM · Restricted Project
simon_tatham added inline comments to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 21 2020, 6:26 AM · Restricted Project

Apr 20 2020

simon_tatham added a comment to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.

I see. In that case I suppose the simplest thing to do is just to explain that in the commit message, along the lines of "D77872 has already added the MC representations of the instructions so that they can be used in code gen; this patch fills in the details needed to make assembly parsing work, and adds tests for asm and disasm'.

Apr 20 2020, 4:16 AM · Restricted Project
simon_tatham added a comment to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.

The important part of this patch seems to be missing! It says it's adding AArch32 assembly parsing for some new instructions, but I don't see any new Tablegen work that adds the instructions. New mnemonics are added to a couple of exclusion lists in ARMAsmParser, but there's no code in here that makes the mnemonics actually exist in the first place, or that says what their operands should be or what their encodings are – just that small C++ tweak and a load of tests. Where's the rest of it?

Apr 20 2020, 1:02 AM · Restricted Project

Apr 7 2020

simon_tatham committed rGaab9e9de4d99: [Support,Windows] Tolerate failure of CryptGenRandom (authored by simon_tatham).
[Support,Windows] Tolerate failure of CryptGenRandom
Apr 7 2020, 1:36 AM
simon_tatham closed D77553: [Support,Windows] Tolerate failure of CryptGenRandom.
Apr 7 2020, 1:36 AM · Restricted Project
simon_tatham added inline comments to D77553: [Support,Windows] Tolerate failure of CryptGenRandom.
Apr 7 2020, 1:35 AM · Restricted Project

Apr 6 2020

simon_tatham created D77553: [Support,Windows] Tolerate failure of CryptGenRandom.
Apr 6 2020, 8:06 AM · Restricted Project

Apr 1 2020

simon_tatham added a comment to D77202: [Target][ARM] Fold or(A, B) more aggressively for I1 Vectors.

I have no thoughts on the patch itself, but the commit message looks quite alarming out of context. Perhaps it should mention that you're doing this specifically for i1 and vectors of i1, and not for bitwise OR of ordinary integers?

Apr 1 2020, 2:50 AM · Restricted Project

Mar 27 2020

simon_tatham accepted D76927: [ARM,CDE] Improve CDE intrinsics testing.
Mar 27 2020, 8:45 AM · Restricted Project
simon_tatham accepted D76910: [ARM] Make remaining MVE instruction predictable.
Mar 27 2020, 5:24 AM · Restricted Project
simon_tatham added a comment to D76910: [ARM] Make remaining MVE instruction predictable.

Are we talking about CONSTRAINED_UNPREDICTABLE here?

Mar 27 2020, 4:17 AM · Restricted Project
simon_tatham added a comment to D76910: [ARM] Make remaining MVE instruction predictable.

Do you understand why all those test outputs have changed as a side effect of this?

Mar 27 2020, 3:10 AM · Restricted Project

Mar 26 2020

simon_tatham committed rG6a946993d519: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on. (authored by simon_tatham).
Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on.
Mar 26 2020, 2:08 AM
simon_tatham closed D76760: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on..
Mar 26 2020, 2:08 AM · Restricted Project

Mar 25 2020

simon_tatham accepted D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics.
Mar 25 2020, 8:04 AM · Restricted Project
simon_tatham committed rG8f1651ccead1: [ARM,MVE] Add missing tests for vqdmlash intrinsics. (authored by simon_tatham).
[ARM,MVE] Add missing tests for vqdmlash intrinsics.
Mar 25 2020, 3:13 AM
simon_tatham closed D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics..
Mar 25 2020, 3:13 AM · Restricted Project
simon_tatham created D76760: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on..
Mar 25 2020, 3:13 AM · Restricted Project

Mar 24 2020

simon_tatham created D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics..
Mar 24 2020, 10:12 AM · Restricted Project
simon_tatham committed rGf282b6ab23a0: [ReleaseNotes,ARM] MVE intrinsics are all implemented! (authored by simon_tatham).
[ReleaseNotes,ARM] MVE intrinsics are all implemented!
Mar 24 2020, 4:48 AM
simon_tatham closed D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.
Mar 24 2020, 4:48 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.

Added an entry to the Clang release notes as well.

Mar 24 2020, 3:12 AM · Restricted Project, Restricted Project

Mar 23 2020

simon_tatham accepted D76511: [ARM] Don't split trunc stores that can be better handled as VMOVN.
Mar 23 2020, 2:43 AM · Restricted Project
simon_tatham accepted D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.

LGTM, with only one tiny remaining nitpick.

Mar 23 2020, 2:43 AM · Restricted Project

Mar 20 2020

simon_tatham created D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.
Mar 20 2020, 10:17 AM · Restricted Project, Restricted Project
simon_tatham committed rG45a9945b9ea9: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.
Mar 20 2020, 9:11 AM
simon_tatham committed rG1adfa4c99169: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.
Mar 20 2020, 9:11 AM
simon_tatham closed D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family..
Mar 20 2020, 9:11 AM · Restricted Project
simon_tatham closed D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family..
Mar 20 2020, 9:11 AM · Restricted Project
simon_tatham updated the diff for D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family..

Update tests to fix CI failure (oops). Also added opt -sroa to make the incidental half/float argument marshalling a bit less verbose.

Mar 20 2020, 7:32 AM · Restricted Project
simon_tatham created D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family..
Mar 20 2020, 5:23 AM · Restricted Project
simon_tatham created D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family..
Mar 20 2020, 5:23 AM · Restricted Project

Mar 18 2020

simon_tatham committed rGe13d153c1b59: [ARM,MVE] Add intrinsics for the VQDMLAD family. (authored by simon_tatham).
[ARM,MVE] Add intrinsics for the VQDMLAD family.
Mar 18 2020, 10:21 AM
simon_tatham closed D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family..
Mar 18 2020, 10:20 AM · Restricted Project
simon_tatham added inline comments to D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.
Mar 18 2020, 9:47 AM · Restricted Project
simon_tatham created D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family..
Mar 18 2020, 6:31 AM · Restricted Project
simon_tatham committed rG28c5d97beec7: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA. (authored by simon_tatham).
[ARM,MVE] Add intrinsics and isel for MVE integer VMLA.
Mar 18 2020, 4:19 AM
simon_tatham committed rG928776de9233: [ARM,MVE] Add intrinsics for the VQDMLAH family. (authored by simon_tatham).
[ARM,MVE] Add intrinsics for the VQDMLAH family.
Mar 18 2020, 4:19 AM
simon_tatham closed D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family..
Mar 18 2020, 4:19 AM · Restricted Project
simon_tatham closed D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..
Mar 18 2020, 4:19 AM · Restricted Project
simon_tatham added inline comments to D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.
Mar 18 2020, 3:46 AM · Restricted Project

Mar 17 2020

simon_tatham added inline comments to D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.
Mar 17 2020, 8:31 AM · Restricted Project

Mar 16 2020

simon_tatham added inline comments to D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..
Mar 16 2020, 10:20 AM · Restricted Project

Mar 13 2020

simon_tatham updated the diff for D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..

Fix clang-format warnings.

Mar 13 2020, 4:24 AM · Restricted Project
simon_tatham created D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..
Mar 13 2020, 2:58 AM · Restricted Project
simon_tatham created D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family..
Mar 13 2020, 2:58 AM · Restricted Project

Mar 12 2020

simon_tatham committed rG3f8e714e2f9f: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add. (authored by simon_tatham).
[ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.
Mar 12 2020, 4:30 AM
simon_tatham committed rGd608fee8399a: [ARM,MVE] Fix user-namespace violation in arm_mve.h. (authored by simon_tatham).
[ARM,MVE] Fix user-namespace violation in arm_mve.h.
Mar 12 2020, 4:30 AM
simon_tatham closed D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h..
Mar 12 2020, 4:30 AM · Restricted Project
simon_tatham closed D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add..
Mar 12 2020, 4:30 AM · Restricted Project, Restricted Project

Mar 11 2020

simon_tatham updated the diff for D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add..

Update test results following a last-minute correctness fix. (I updated one of the two test files but not the other.)

Mar 11 2020, 9:04 AM · Restricted Project, Restricted Project
simon_tatham created D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h..
Mar 11 2020, 9:04 AM · Restricted Project
simon_tatham added a comment to D75990: [ARM] MVE VFMA (reg) and VFMAS patterns.

... but I hadn't quite uploaded it yet. Now I have: D75998.

Mar 11 2020, 9:04 AM · Restricted Project
simon_tatham created D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add..
Mar 11 2020, 9:04 AM · Restricted Project, Restricted Project

Mar 10 2020

simon_tatham accepted D75850: [ARM,CDE] Generalize MVE intrinsics infrastructure to support CDE.

LGTM with a couple of tiny spelling nitpicks.

Mar 10 2020, 5:48 AM · Restricted Project, Restricted Project

Mar 9 2020

simon_tatham updated subscribers of D75850: [ARM,CDE] Generalize MVE intrinsics infrastructure to support CDE.

Renames the 'clang_arm_mve_alias' attribute into 'clang_arm_builtin_alias' (it will be used with CDE intrinsics as well as MVE intrinsics)

Mar 9 2020, 9:41 AM · Restricted Project, Restricted Project
simon_tatham accepted D75843: [ARM,CDE] Implement CDE feature test macros.
Mar 9 2020, 9:08 AM · Restricted Project
simon_tatham added inline comments to D75843: [ARM,CDE] Implement CDE feature test macros.
Mar 9 2020, 8:35 AM · Restricted Project
simon_tatham requested changes to D75843: [ARM,CDE] Implement CDE feature test macros.
Mar 9 2020, 6:57 AM · Restricted Project

Mar 5 2020

simon_tatham added inline comments to D75470: [SVE] Auto-generate builtins and header for svld1..
Mar 5 2020, 8:13 AM · Restricted Project

Mar 4 2020

simon_tatham committed rG810127f6ab5d: [ARM,MVE] Add the `vsbciq` intrinsics. (authored by simon_tatham).
[ARM,MVE] Add the `vsbciq` intrinsics.
Mar 4 2020, 1:13 AM