Page MenuHomePhabricator
Feed Advanced Search

Jun 27 2019

astrelni added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Looks reasonable. I did not review the check itself though.
Are test/clang-tidy/google-upgrade-googletest-case-nosuite.cpp and test/clang-tidy/google-upgrade-googletest-case.cpp identical other than the included header and expected output?
I'd recommend to condense it into a single file, and just have two RUN lines each one checking different message prefixes

Jun 27 2019, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.
Jun 27 2019, 11:05 AM · Restricted Project, Restricted Project, Restricted Project
astrelni added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

It sounds correct, but i don't see accompanying test changes, so i can't be sure.

The tests as they are cover the positive case in that they would not show warning or fixes if we didn't find the replacements.

Yep

The only way to test the negative is to make a second test with a second set of mock googletest headers that declare things in the v1.8 way. Is this what you would prefer?

If that is what it takes to get the test coverage, i suppose so.

Jun 27 2019, 6:56 AM · Restricted Project, Restricted Project, Restricted Project
astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.
Jun 27 2019, 6:55 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2019

astrelni added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

It sounds correct, but i don't see accompanying test changes, so i can't be sure.

Jun 26 2019, 12:00 PM · Restricted Project, Restricted Project, Restricted Project
astrelni added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Without seeing the tests - what version checks does this have?
It shouldn't fire if the googletest version is the one before that rename.

I don't believe this question was answered.

Sorry, the original comment got lost between me updating two patches as I noticed I did it wrong without seeing your comment.

Unfortunately there are no versioning macros in googletest, so I'm not sure how to keep this check from providing warnings if it is run while depending on a version that is too early. The new names are in master and will be part of an upcoming version 1.9 release. I have tried to update the documentation to clarify which version of googletest this intended for. Please let me know how you think we should proceed.

I'm not fully current on what can and can't be done in clang-tidy, but i suppose if the
check has matched something, then it must mean that the googletest headers were parsed.
Can you perhaps look in the AST that the new names are present?
E.g. the new macros, specified in getNewMacroName().

Jun 26 2019, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.
Jun 26 2019, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
astrelni added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Without seeing the tests - what version checks does this have?
It shouldn't fire if the googletest version is the one before that rename.

I don't believe this question was answered.

Jun 26 2019, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.
Jun 26 2019, 8:24 AM · Restricted Project, Restricted Project, Restricted Project

Jun 12 2019

astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Fix diff issues again

Jun 12 2019, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Fix mistake not uploading full diff

Jun 12 2019, 10:01 AM · Restricted Project, Restricted Project, Restricted Project
astrelni added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

I think will be good idea to replace upgrade with modernize to be consistent with similar checks in other module.

Jun 12 2019, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Fix space.

Jun 12 2019, 9:41 AM · Restricted Project, Restricted Project, Restricted Project
astrelni updated the diff for D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Style updates.

Jun 12 2019, 9:38 AM · Restricted Project, Restricted Project, Restricted Project

Jun 6 2019

astrelni created D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.
Jun 6 2019, 1:10 PM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2018

astrelni added a comment to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Sorry for the long delay.

Nov 21 2018, 7:59 AM · Restricted Project
astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Nov 21 2018, 7:45 AM · Restricted Project

Nov 15 2018

astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Fix incorrect uploaded diff.

Nov 15 2018, 9:30 AM · Restricted Project
astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Fix to use hasAnyName everywhere

Nov 15 2018, 9:02 AM · Restricted Project

Nov 2 2018

astrelni added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Nov 2 2018, 11:25 AM · Restricted Project
astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Updated filtering of template instantiations to not use potentially costly hasDescendent matcher.

Nov 2 2018, 11:20 AM · Restricted Project

Oct 31 2018

astrelni added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 31 2018, 3:44 PM · Restricted Project
astrelni added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 31 2018, 1:36 PM · Restricted Project
astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Reply to comments:

  • Change diagnostic message
  • Update documentation
Oct 31 2018, 1:35 PM · Restricted Project
astrelni added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 31 2018, 1:18 PM · Restricted Project
astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Reply to review comments:

  • minor code reorder
  • improve test coverage
Oct 31 2018, 1:17 PM · Restricted Project
astrelni added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 31 2018, 11:18 AM · Restricted Project
astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Combine template instantiation matching into the other matcher registration.

Oct 31 2018, 11:15 AM · Restricted Project
astrelni added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 31 2018, 8:23 AM · Restricted Project
astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Thanks for the feedback so far.

Oct 31 2018, 8:23 AM · Restricted Project

Oct 29 2018

astrelni updated the diff for D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

Reply to comments: add check for language being c++, explicitly name type in declaration, alphabetize release notes.

Oct 29 2018, 1:53 PM · Restricted Project
astrelni retitled D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions' from [clang-tidy]: Abseil: new check 'upgrade-duration-conversions' to [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 29 2018, 1:25 PM · Restricted Project
astrelni created D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 29 2018, 1:18 PM · Restricted Project