Page MenuHomePhabricator
Feed Advanced Search

Tue, Dec 1

Whitney added inline comments to D91481: [LoopUnroll] Discount uniform instructions in cost models.
Tue, Dec 1, 9:24 AM · Restricted Project
Whitney added inline comments to D91481: [LoopUnroll] Discount uniform instructions in cost models.
Tue, Dec 1, 5:12 AM · Restricted Project
Whitney added inline comments to D91682: [LoopInterchange] Fix the checking of tightly nested loop.
Tue, Dec 1, 4:55 AM · Restricted Project

Wed, Nov 18

Whitney accepted D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Wed, Nov 18, 11:59 AM · Restricted Project
Whitney added inline comments to D91682: [LoopInterchange] Fix the checking of tightly nested loop.
Wed, Nov 18, 11:55 AM · Restricted Project

Tue, Nov 10

Whitney added a comment to rG2f1038c7b699: [BranchProbabilityInfo] Use SmallVector (NFC).

There are new assertions with this commit.
opt: llvm/lib/Analysis/BranchProbabilityInfo.cpp:1123: llvm::BranchProbability llvm::BranchProbabilityInfo::getEdgeProbability(const llvm::BasicBlock *, const llvm::BasicBlock *) const: Assertion `SrcProbs.size() == Src->getTerminator()->getNumSuccessors() && "The number of edge probabilities must match the number of " "successors."' failed.

Tue, Nov 10, 5:27 PM

Oct 30 2020

Whitney added a comment to D89911: [PartialInliner]: Handle code regions in a switch stmt cases.

LGTM. I will approve tomorrow if no one object..

Oct 30 2020, 9:07 AM · Restricted Project

Oct 21 2020

Whitney added inline comments to D89911: [PartialInliner]: Handle code regions in a switch stmt cases.
Oct 21 2020, 4:16 PM · Restricted Project

Oct 13 2020

Whitney added a comment to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Hi @Whitney, @ychen, if the patches are ready to land, could you do me a favor of committing this as well as the follow-up D87531 (with --author="Ta-Wei Tu <tu.da.wei@gmail.com>)?
Thanks in advance!

Oct 13 2020, 12:17 PM · Restricted Project

Sep 30 2020

Whitney accepted D88608: [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake.
Sep 30 2020, 1:52 PM · Restricted Project

Sep 29 2020

Whitney accepted D88408: [docs] Revise loop terminology reference..

Thanks for writing this up.

Sep 29 2020, 9:35 AM · Restricted Project
Whitney accepted D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Thanks for working on it! Are you planning to change one of the LoopPass to a LoopNestPass next?

Sep 29 2020, 9:20 AM · Restricted Project

Sep 17 2020

Whitney added inline comments to D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..
Sep 17 2020, 12:42 PM · Restricted Project
Whitney committed rG1cee33e9dbb6: [LoopUnrollAndJam] Allow unroll and jam loops forced by user. (authored by Whitney).
[LoopUnrollAndJam] Allow unroll and jam loops forced by user.
Sep 17 2020, 12:41 PM
Whitney closed D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..
Sep 17 2020, 12:40 PM · Restricted Project
Whitney updated the diff for D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..
Sep 17 2020, 7:31 AM · Restricted Project

Sep 16 2020

Whitney added a comment to D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..

Why is this specific to the PowerPC-backend. Doesn't the LoopUnrollAndJamPass pick-up the transformation metadata already?

Sep 16 2020, 6:36 PM · Restricted Project
Whitney requested review of D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..
Sep 16 2020, 12:13 PM · Restricted Project

Sep 15 2020

Whitney added a comment to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
  • How about using PreservedAnalyses run(Loop &, LoopAnalysisManager &, LoopStandardAnalysisResults &, LPMUpdater &, LoopNest &); for the interface. I think it should work better because it is still a loop pass interface.

Sounds like a good idea to me. Let' see what @Whitney and @etiotto think about the new interface first, and I'll update the patch later if they agree on that. Thanks!

Sep 15 2020, 6:45 AM · Restricted Project
Whitney added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Sep 15 2020, 5:39 AM · Restricted Project
Whitney accepted D87531: [LoopNest] Extend `LPMUpdater` and adaptor to handle loop-nest passes.

LGTM.

Sep 15 2020, 5:29 AM · Restricted Project

Sep 12 2020

Whitney added a comment to rGfb109c42d91c: [DSE] Switch to MemorySSA-backed DSE by default..

Thanks for the prompt fix! I have verified it fixes our original issue.

Sep 12 2020, 5:34 PM

Sep 11 2020

Whitney added a comment to rGfb109c42d91c: [DSE] Switch to MemorySSA-backed DSE by default..

@fhahn Looks like there is an issue with handling loop-carried dependency.

Sep 11 2020, 6:08 PM

Sep 10 2020

Whitney added inline comments to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Sep 10 2020, 7:02 AM · Restricted Project

Sep 9 2020

Whitney added inline comments to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Sep 9 2020, 10:50 AM · Restricted Project

Sep 1 2020

Whitney added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Sep 1 2020, 11:54 AM · Restricted Project

Aug 25 2020

Whitney committed rGabbd652dd6db: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops (authored by TaWeiTu).
[LoopNest] False negative of `arePerfectlyNested` with LCSSA loops
Aug 25 2020, 9:21 AM
Whitney closed D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 25 2020, 9:21 AM · Restricted Project
Whitney added a comment to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Hi @etiotto, @Whitney thanks for your reviews!
Can you commit this for me? --author="Ta-Wei Tu <tu.da.wei@gmail.com>" as mentioned above looks good to me, thanks!

Aug 25 2020, 8:57 AM · Restricted Project

Aug 19 2020

Whitney added a comment to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Hi @Whitney, @fhahn, thanks for your review and comment!
Please let me know if there's any other problem with the patch.
Also, if the patch is ready to land, is it possible for you to commit it instead (I believe I don't have the commit access)?

Aug 19 2020, 4:58 PM · Restricted Project
Whitney accepted D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 19 2020, 7:05 AM · Restricted Project
Whitney added a comment to D84886: Create LoopNestPass.

I was trying to convert the LoopInterchange pass into a loop-nest pass. However, there seems to be no corresponding loop pass for the NPM.
Any particular reason for this?

Aug 19 2020, 6:59 AM · Restricted Project, Restricted Project

Aug 18 2020

Whitney added inline comments to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 18 2020, 12:07 PM · Restricted Project
Whitney added inline comments to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 18 2020, 8:22 AM · Restricted Project
Whitney added a reviewer for D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops: etiotto.
Aug 18 2020, 5:12 AM · Restricted Project
Whitney added a comment to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

arePerfectlyNested is written very conservative to start with, this patch allows loop nests with PHINodes in between to be considered perfect.

Aug 18 2020, 5:12 AM · Restricted Project

Aug 12 2020

Whitney added a comment to D84886: Create LoopNestPass.

Examples of existing transformations that can be benefited from LoopNestPass: LoopInterchange, LoopUnrollAndJam, LoopIdiom, LoopDistribution, ...
And their corresponding cost model analyses can be benefited from LoopNestAnalysis, e.g. LoopCacheCost.

Aug 12 2020, 7:06 AM · Restricted Project, Restricted Project

Aug 11 2020

Whitney added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Aug 11 2020, 9:02 AM · Restricted Project
Whitney committed rGaa994d9867e3: [NFC][LoopUnrollAndJam] Use BasicBlock::replacePhiUsesWith instead of (authored by Whitney).
[NFC][LoopUnrollAndJam] Use BasicBlock::replacePhiUsesWith instead of
Aug 11 2020, 8:36 AM
Whitney closed D85673: [NFC][LoopUnrollAndJam] Use BasicBlock::replacePhiUsesWith instead of static function updatePHIBlocks..
Aug 11 2020, 8:36 AM · Restricted Project

Aug 10 2020

Whitney requested review of D85673: [NFC][LoopUnrollAndJam] Use BasicBlock::replacePhiUsesWith instead of static function updatePHIBlocks..
Aug 10 2020, 11:20 AM · Restricted Project

Aug 7 2020

Whitney requested changes to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Aug 7 2020, 9:39 AM · Restricted Project
Whitney added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Aug 7 2020, 9:37 AM · Restricted Project

Jul 29 2020

Whitney closed D83543: [CodeMoverUtils] Add more data dependency related test case.

https://reviews.llvm.org/rG167cac3100f5145186db678e497028a426ace655

Jul 29 2020, 7:43 AM · Restricted Project
Whitney added inline comments to D84776: [CodeMoverUtils] Add more tests to check code motion safety using data dependence information..
Jul 29 2020, 7:40 AM · Restricted Project

Jul 28 2020

Whitney added a comment to D84776: [CodeMoverUtils] Add more tests to check code motion safety using data dependence information..

Some quick first round review comments.

Jul 28 2020, 12:31 PM · Restricted Project

Jul 26 2020

Whitney accepted D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Jul 26 2020, 3:20 AM · Restricted Project
Whitney added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Jul 26 2020, 2:45 AM · Restricted Project

Jul 25 2020

Whitney added a comment to D80643: [CodeMoverUtils] Move OrderedInstructions to CodeMoverUtils.

https://reviews.llvm.org/rGe71c7b593a2d1b7d60dc8aaa4b8ede03de7bbd00

Jul 25 2020, 12:55 PM · Restricted Project
Whitney added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Jul 25 2020, 12:44 PM · Restricted Project

Jul 20 2020

Whitney accepted D83543: [CodeMoverUtils] Add more data dependency related test case.
Jul 20 2020, 9:39 AM · Restricted Project

Jul 18 2020

Whitney added inline comments to D83311: [CodeMoverUtils] Add optional data dependence checks using MSSA.
Jul 18 2020, 4:10 AM · Restricted Project

Jul 10 2020

Whitney added inline comments to D83543: [CodeMoverUtils] Add more data dependency related test case.
Jul 10 2020, 11:20 AM · Restricted Project
Whitney added inline comments to D83543: [CodeMoverUtils] Add more data dependency related test case.
Jul 10 2020, 7:42 AM · Restricted Project

Jul 9 2020

Whitney added inline comments to D83311: [CodeMoverUtils] Add optional data dependence checks using MSSA.
Jul 9 2020, 7:39 AM · Restricted Project

Jul 7 2020

Whitney added inline comments to D83311: [CodeMoverUtils] Add optional data dependence checks using MSSA.
Jul 7 2020, 10:25 AM · Restricted Project

Jul 6 2020

Whitney accepted D82566: [CodeMoverUtils] Make specific analysis dependent checks optional.
Jul 6 2020, 10:58 AM · Restricted Project

Jul 2 2020

Whitney accepted D83066: [NewPM][LoopFusion] Rename loop-fuse -> loop-fusion.

LGTM. Let's wait a day or two for @kbarton .

Jul 2 2020, 2:36 PM · Restricted Project
Whitney added a comment to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

I think that isInnermost() would make even more sense.

I'm fine with adding bool isInnermost() const { return empty(); } and while we are at it, bool isOutermost().

@fhahn @Meinersbur @Whitney @etiotto Objections?

Jul 2 2020, 2:36 PM · Restricted Project
Whitney added a reviewer for D83066: [NewPM][LoopFusion] Rename loop-fuse -> loop-fusion: kbarton.
Jul 2 2020, 12:57 PM · Restricted Project

Jun 29 2020

Whitney accepted D82293: [CodeMoverUtils][WIP] Move code motion related checks from LICM to CodeMoverUtils.
Jun 29 2020, 2:25 PM · Restricted Project
Whitney accepted D82290: [CodeMoverUtils][WIP] Isolate checks strictly related to the code motion candidate instruction.
Jun 29 2020, 2:25 PM · Restricted Project
Whitney added inline comments to D82566: [CodeMoverUtils] Make specific analysis dependent checks optional.
Jun 29 2020, 2:25 PM · Restricted Project
Whitney added inline comments to D82566: [CodeMoverUtils] Make specific analysis dependent checks optional.
Jun 29 2020, 7:31 AM · Restricted Project

Jun 28 2020

Whitney added inline comments to D82566: [CodeMoverUtils] Make specific analysis dependent checks optional.
Jun 28 2020, 8:22 PM · Restricted Project

Jun 26 2020

Whitney added inline comments to D82290: [CodeMoverUtils][WIP] Isolate checks strictly related to the code motion candidate instruction.
Jun 26 2020, 1:08 PM · Restricted Project
Whitney added inline comments to D82566: [CodeMoverUtils] Make specific analysis dependent checks optional.
Jun 26 2020, 1:08 PM · Restricted Project

Jun 25 2020

Whitney accepted D82590: [NewPM][LoopUnroll] Rename unroll* to loop-unroll*.
Jun 25 2020, 3:50 PM · Restricted Project
Whitney added a comment to D82590: [NewPM][LoopUnroll] Rename unroll* to loop-unroll*.

How about change unroll to loop-unroll as well? In that case unroll and unroll-and-jam name can be more consistent, and their name can also be consistent between pass mangers.

Jun 25 2020, 3:18 PM · Restricted Project
Whitney requested changes to D82566: [CodeMoverUtils] Make specific analysis dependent checks optional.
Jun 25 2020, 9:40 AM · Restricted Project

Jun 23 2020

Whitney abandoned D82407: [DSE,MSSA] Remove dead stores to stack-allocated locations.

Thanks for working on this. I think a patch I've been working on for a while solves the same problem, but in a slightly more general way I think: D72631.

There's one more slightly larger outstanding patch to support 'memory terminators' like lifetime.end/free as well: D72410. I think those patches should get us to almost cover all cases legacy DSE does, but there is plenty of potential for further improvements. I would be more than happy to sync up to avoid duplicating work, if you are also interested in working on MemorySSA backed DSE :)

Jun 23 2020, 4:43 PM · Restricted Project
Whitney added inline comments to D72631: [DSE] Eliminate stores at the end of the function..
Jun 23 2020, 4:43 PM · Restricted Project
Whitney added inline comments to D72631: [DSE] Eliminate stores at the end of the function..
Jun 23 2020, 4:43 PM · Restricted Project
Whitney created D82407: [DSE,MSSA] Remove dead stores to stack-allocated locations.
Jun 23 2020, 1:59 PM · Restricted Project

Jun 22 2020

Whitney added inline comments to D82293: [CodeMoverUtils][WIP] Move code motion related checks from LICM to CodeMoverUtils.
Jun 22 2020, 2:31 PM · Restricted Project
Whitney added inline comments to D82290: [CodeMoverUtils][WIP] Isolate checks strictly related to the code motion candidate instruction.
Jun 22 2020, 12:21 PM · Restricted Project
Whitney added inline comments to D82290: [CodeMoverUtils][WIP] Isolate checks strictly related to the code motion candidate instruction.
Jun 22 2020, 12:21 PM · Restricted Project

Jun 17 2020

Whitney added a comment to D80643: [CodeMoverUtils] Move OrderedInstructions to CodeMoverUtils.

@nikic ping

Jun 17 2020, 10:13 AM · Restricted Project

Jun 14 2020

Whitney committed rG5225cd43e8ff: [LoopUnroll] Allow loops with multiple exiting blocks where loop latch is not… (authored by Whitney).
[LoopUnroll] Allow loops with multiple exiting blocks where loop latch is not…
Jun 14 2020, 11:45 AM
Whitney closed D81053: [LoopUnroll] Allow loops with multiple exiting blocks where loop latch is not necessary one of them..
Jun 14 2020, 11:45 AM · Restricted Project

Jun 9 2020

Whitney committed rG01e64c971260: [LoopFusion] Update second loop guard non loop successor phis incoming blocks. (authored by Whitney).
[LoopFusion] Update second loop guard non loop successor phis incoming blocks.
Jun 9 2020, 2:22 PM
Whitney closed D81421: [LoopFusion] Update second loop guard non loop successor phis incoming blocks..
Jun 9 2020, 2:22 PM · Restricted Project
Whitney accepted D80643: [CodeMoverUtils] Move OrderedInstructions to CodeMoverUtils.

The patch LGTM. @nikic What do you think?

Jun 9 2020, 11:32 AM · Restricted Project
Whitney added inline comments to D80643: [CodeMoverUtils] Move OrderedInstructions to CodeMoverUtils.
Jun 9 2020, 7:05 AM · Restricted Project
Whitney added inline comments to D80643: [CodeMoverUtils] Move OrderedInstructions to CodeMoverUtils.
Jun 9 2020, 4:21 AM · Restricted Project

Jun 8 2020

Whitney created D81421: [LoopFusion] Update second loop guard non loop successor phis incoming blocks..
Jun 8 2020, 12:41 PM · Restricted Project
Whitney added inline comments to D80643: [CodeMoverUtils] Move OrderedInstructions to CodeMoverUtils.
Jun 8 2020, 7:38 AM · Restricted Project

Jun 4 2020

Whitney updated the diff for D81053: [LoopUnroll] Allow loops with multiple exiting blocks where loop latch is not necessary one of them..

Addressed review comments.

Jun 4 2020, 11:00 AM · Restricted Project

Jun 3 2020

Whitney updated the diff for D81053: [LoopUnroll] Allow loops with multiple exiting blocks where loop latch is not necessary one of them..

Obtain ContinueOnTrue and LoopExit before modifying loop latch branch.

Jun 3 2020, 10:25 AM · Restricted Project

Jun 2 2020

Whitney created D81053: [LoopUnroll] Allow loops with multiple exiting blocks where loop latch is not necessary one of them..
Jun 2 2020, 9:52 PM · Restricted Project

May 30 2020

Whitney committed rG0fee91a187d9: [LoopUnroll] Add a test case for rG7873376bb36b. (authored by Whitney).
[LoopUnroll] Add a test case for rG7873376bb36b.
May 30 2020, 1:47 PM
Whitney closed D80477: [LoopUnroll] Support loops with exiting block that is neither header nor latch..
May 30 2020, 1:46 PM · Restricted Project
Whitney committed rG7873376bb36b: [LoopUnroll] Fix build failure for allyesconfig. (authored by Whitney).
[LoopUnroll] Fix build failure for allyesconfig.
May 30 2020, 12:11 PM
Whitney updated the diff for D80477: [LoopUnroll] Support loops with exiting block that is neither header nor latch..

Updated the patch to fix build failure for allyesconfig.

May 30 2020, 11:39 AM · Restricted Project
Whitney reopened D80477: [LoopUnroll] Support loops with exiting block that is neither header nor latch..
May 30 2020, 4:44 AM · Restricted Project

May 28 2020

Whitney committed rG4e74541a9280: [LoopUnroll] Fix not-rotated.ll by adding back a limitation was unintentionally… (authored by Whitney).
[LoopUnroll] Fix not-rotated.ll by adding back a limitation was unintentionally…
May 28 2020, 8:20 PM
Whitney committed rG1bc73b02d693: [LoopUnroll] Support loops with exiting block that is neither header nor latch. (authored by Whitney).
[LoopUnroll] Support loops with exiting block that is neither header nor latch.
May 28 2020, 6:44 PM
Whitney added inline comments to D80744: DAGCombiner optimization for pow(x,0.75) and pow(x,0.25) on double and single precision even in case massv function is asked.
May 28 2020, 6:11 PM · Restricted Project, Restricted Project
Whitney committed rG47ffc81830d3: Revert "[LoopUnroll] Support loops with exiting block that is neither header… (authored by Whitney).
Revert "[LoopUnroll] Support loops with exiting block that is neither header…
May 28 2020, 12:40 PM
Whitney added a reverting change for rG281058226587: [LoopUnroll] Support loops with exiting block that is neither header nor latch.: rG47ffc81830d3: Revert "[LoopUnroll] Support loops with exiting block that is neither header….
May 28 2020, 12:39 PM