Page MenuHomePhabricator
Feed Advanced Search

Jul 9 2019

djtodoro closed D58042: [LiveDebugValues] Emit parameter's entry value.
Jul 9 2019, 1:37 AM · Restricted Project, debug-info

Jul 8 2019

djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Yes, that sounds good to me!

@dstenb Thanks!

Jul 8 2019, 4:29 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Remove redundant code
-Fix the debug entry value assertion from the VarLoc constructor

Jul 8 2019, 4:26 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Nit in a comment

Jul 8 2019, 12:08 AM · Restricted Project, debug-info

Jul 5 2019

djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Did you consider what should be done with llvm-dwarfdump's "scope bytes covered" statistics?

I think that it sounds reasonable to add an additional field there, something like "non-entry-val scope bytes covered".

Just to clarify, as the emission of entry values is behind a non-driver flag I'm not opposed to landing these patches without changing llvm-dwarfdump, so please don't let me stand in the way. I think that a "non-entry-val scope bytes covered" field would be helpful, but someone with more say in the debug info area than me should decide that.

Jul 5 2019, 1:11 AM · Restricted Project, debug-info

Jul 4 2019

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Fixing unintentional code during the rebase process

Jul 4 2019, 8:03 AM · Restricted Project, debug-info
djtodoro added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
Jul 4 2019, 7:57 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Fix the assertion

Jul 4 2019, 7:54 AM · Restricted Project, debug-info
djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

The 'llvm-dwarfdump' does calculate the debug location statistics, but maybe we could think of reporting it with more information, since the debug location info is such important debug info. Please find a proposal for having a separate tool that will calculate only the debug location statistics on my github (https://github.com/djolertrk/llvm-locstats) and let me know if it can be useful for us. Potentially, we could add more options, functionalities, etc..

Jul 4 2019, 7:50 AM · Restricted Project, debug-info

Jul 3 2019

djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Is this OK to go ?

Jul 3 2019, 6:10 AM · Restricted Project, debug-info

Jul 2 2019

djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Add support for entry values that are complex variables address (that avoids entry value not be safe for a single locations)
-Add a TODO for supporting local variables that are expressed in terms of parameters entry values

Jul 2 2019, 6:29 AM · Restricted Project, debug-info
djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Would it perhaps make sense to add a small sentence about that in those TODOs?

@dstenb Sure! Thanks!

Jul 2 2019, 4:46 AM · Restricted Project, debug-info
djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Can you change this comment from describing what the code does (which is fairly obvious), to why it does it?

@aprantl Sure. Thanks for the comment!

Jul 2 2019, 1:50 AM · Restricted Project, debug-info

Jul 1 2019

djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Clarify in the test the entry value coming from a location list

Jul 1 2019, 7:04 AM · Restricted Project, debug-info
djtodoro reopened D58042: [LiveDebugValues] Emit parameter's entry value.

Due to very latest patches we came up with situations when we need to avoid single location represented as an entry value.
Also, having in mind the debug entry value is special case of the 'DBG_VALUE' instruction, we found it is OK in some situations to generate it after a first terminator.
Is this still OK to go ?

Jul 1 2019, 6:46 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

Nit: Use DWARF 5 in a test case.

Jul 1 2019, 6:39 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Avoid a single location represented as an entry value (+ add a test for that)
-Allow a debug entry value after a first terminator

Jul 1 2019, 6:30 AM · Restricted Project, debug-info

Jun 27 2019

djtodoro committed rG774eabd0978b: Revert "[LiveDebugValues] Emit the debug entry values" (authored by djtodoro).
Revert "[LiveDebugValues] Emit the debug entry values"
Jun 27 2019, 11:14 AM
djtodoro added a reverting change for rL364553: [LiveDebugValues] Emit the debug entry values: rL364571: Revert "[LiveDebugValues] Emit the debug entry values".
Jun 27 2019, 11:13 AM
djtodoro committed rL364571: Revert "[LiveDebugValues] Emit the debug entry values".
Revert "[LiveDebugValues] Emit the debug entry values"
Jun 27 2019, 11:13 AM
djtodoro committed rGd6a46aff5913: [LiveDebugValues] Emit the debug entry values (authored by djtodoro).
[LiveDebugValues] Emit the debug entry values
Jun 27 2019, 8:37 AM
djtodoro committed rL364553: [LiveDebugValues] Emit the debug entry values.
[LiveDebugValues] Emit the debug entry values
Jun 27 2019, 8:36 AM
djtodoro closed D58042: [LiveDebugValues] Emit parameter's entry value.
Jun 27 2019, 8:35 AM · Restricted Project, debug-info
djtodoro committed rG7a9ca67fd556: [LiveRangeEdit] Fix build failure caused by the rL364536 (authored by djtodoro).
[LiveRangeEdit] Fix build failure caused by the rL364536
Jun 27 2019, 7:33 AM
djtodoro committed rL364549: [LiveRangeEdit] Fix build failure caused by the rL364536.
[LiveRangeEdit] Fix build failure caused by the rL364536
Jun 27 2019, 7:31 AM
djtodoro committed rGa0d45058ebb3: [DWARF] Handle the DW_OP_entry_value operand (authored by djtodoro).
[DWARF] Handle the DW_OP_entry_value operand
Jun 27 2019, 6:55 AM
djtodoro committed rL364542: [DWARF] Handle the DW_OP_entry_value operand.
[DWARF] Handle the DW_OP_entry_value operand
Jun 27 2019, 6:54 AM
djtodoro closed D60866: [DWARF] Handle DW_OP_entry_value operand.
Jun 27 2019, 6:54 AM · Restricted Project, debug-info
djtodoro committed rG71d3869f60c3: [Backend] Keep call site info valid through the backend (authored by djtodoro).
[Backend] Keep call site info valid through the backend
Jun 27 2019, 6:12 AM
djtodoro committed rL364536: [Backend] Keep call site info valid through the backend.
[Backend] Keep call site info valid through the backend
Jun 27 2019, 6:11 AM
djtodoro closed D61062: Keep call site info valid through the backend.
Jun 27 2019, 6:10 AM · Restricted Project, debug-info
djtodoro committed rG7eeeb5947ec0: [ISEL][X86] Tracking of registers that forward call arguments (authored by djtodoro).
[ISEL][X86] Tracking of registers that forward call arguments
Jun 27 2019, 3:53 AM
djtodoro committed rL364516: [ISEL][X86] Tracking of registers that forward call arguments.
[ISEL][X86] Tracking of registers that forward call arguments
Jun 27 2019, 3:51 AM
djtodoro closed D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Jun 27 2019, 3:51 AM · Restricted Project, debug-info
djtodoro committed rGa7cde103c182: [MachineFunction] Base support for call site info tracking (authored by djtodoro).
[MachineFunction] Base support for call site info tracking
Jun 27 2019, 12:51 AM
djtodoro committed rL364506: [MachineFunction] Base support for call site info tracking.
[MachineFunction] Base support for call site info tracking
Jun 27 2019, 12:50 AM
djtodoro closed D61061: [MachineFunction] Base support for call site info tracking.
Jun 27 2019, 12:50 AM · Restricted Project, debug-info

Jun 26 2019

djtodoro committed rG0f6516856670: [clang] Add DISuprogram and DIE for a func decl (authored by djtodoro).
[clang] Add DISuprogram and DIE for a func decl
Jun 26 2019, 11:46 PM
djtodoro committed rL364502: [clang] Add DISuprogram and DIE for a func decl.
[clang] Add DISuprogram and DIE for a func decl
Jun 26 2019, 11:44 PM
djtodoro closed D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Jun 26 2019, 11:44 PM · Restricted Project
djtodoro committed rG59b39faa1839: [IR] Add DISuprogram and DIE for a func decl (authored by djtodoro).
[IR] Add DISuprogram and DIE for a func decl
Jun 26 2019, 11:09 PM
djtodoro committed rL364500: [IR] Add DISuprogram and DIE for a func decl.
[IR] Add DISuprogram and DIE for a func decl
Jun 26 2019, 11:09 PM
djtodoro closed D60713: [IR] Add DISuprogram and DIE for func decl of an external.
Jun 26 2019, 11:09 PM · Restricted Project, debug-info
djtodoro committed rGed05d49aadc9: [clang/DIVar] Emit the flag for params that have unmodified value (authored by djtodoro).
[clang/DIVar] Emit the flag for params that have unmodified value
Jun 26 2019, 6:34 AM
djtodoro committed rL364424: [clang/DIVar] Emit the flag for params that have unmodified value.
[clang/DIVar] Emit the flag for params that have unmodified value
Jun 26 2019, 6:34 AM
djtodoro closed D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Jun 26 2019, 6:33 AM · Restricted Project, debug-info
djtodoro committed rGe821e79fce23: [IR/DIVar] Add the flag for params that have unmodified value (authored by djtodoro).
[IR/DIVar] Add the flag for params that have unmodified value
Jun 26 2019, 4:20 AM
djtodoro committed rL364406: [IR/DIVar] Add the flag for params that have unmodified value.
[IR/DIVar] Add the flag for params that have unmodified value
Jun 26 2019, 4:20 AM
djtodoro closed D58034: [IR/DIVar] Add flag for params that have unchanged values.
Jun 26 2019, 4:20 AM · Restricted Project, debug-info
djtodoro committed rGe17a52ebeeb0: [clang] Fix test failures after the rL364399 (authored by djtodoro).
[clang] Fix test failures after the rL364399
Jun 26 2019, 3:24 AM
djtodoro committed rL364402: [clang] Fix test failures after the rL364399.
[clang] Fix test failures after the rL364399
Jun 26 2019, 3:23 AM
djtodoro committed rG639d36b34e6e: [CC1Option] Add the option to enable the debug entry values (authored by djtodoro).
[CC1Option] Add the option to enable the debug entry values
Jun 26 2019, 2:40 AM
djtodoro committed rL364399: [CC1Option] Add the option to enable the debug entry values.
[CC1Option] Add the option to enable the debug entry values
Jun 26 2019, 2:38 AM
djtodoro closed D58033: Add option for emitting dbg info for call site parameters.
Jun 26 2019, 2:38 AM · Restricted Project, debug-info
djtodoro committed rGa5bbe8c8b93b: [TargetOption] Add option to ebanble the debug entry values (authored by djtodoro).
[TargetOption] Add option to ebanble the debug entry values
Jun 26 2019, 1:37 AM
djtodoro committed rL364395: [TargetOption] Add option to ebanble the debug entry values.
[TargetOption] Add option to ebanble the debug entry values
Jun 26 2019, 1:37 AM
djtodoro closed D60961: [TargetOption] Add option for enabling param entry val tracking dbg info.
Jun 26 2019, 1:36 AM · Restricted Project, debug-info
djtodoro committed rG5dff8ca26a90: [Metadata] Add GNU extensions for call site DWARF symbols (authored by djtodoro).
[Metadata] Add GNU extensions for call site DWARF symbols
Jun 26 2019, 12:32 AM
djtodoro committed rL364385: [Metadata] Add GNU extensions for call site DWARF symbols.
[Metadata] Add GNU extensions for call site DWARF symbols
Jun 26 2019, 12:31 AM
djtodoro closed D60712: [DWARF] Add GNU extensions for call site info DWARF symbols.
Jun 26 2019, 12:31 AM · Restricted Project, debug-info

Jun 20 2019

djtodoro added a comment to D61062: Keep call site info valid through the backend.

@aprantl The comment looks OK? :)

Jun 20 2019, 11:14 PM · Restricted Project, debug-info
djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@aprantl This still looks OK after the rebasing? :)

Jun 20 2019, 11:14 PM · Restricted Project, debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase

Jun 20 2019, 6:38 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase

Jun 20 2019, 6:37 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Rebase

Jun 20 2019, 6:35 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Rebase
-Add the comment explaining the assertion when deleting instructions

Jun 20 2019, 6:35 AM · Restricted Project, debug-info

Jun 17 2019

djtodoro added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Jun 17 2019, 11:22 PM · Restricted Project, debug-info

Jun 10 2019

djtodoro updated the diff for D61061: [MachineFunction] Base support for call site info tracking.

-Remove an unwanted code refactor change

Jun 10 2019, 4:30 AM · Restricted Project, debug-info

Jun 6 2019

djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Handle a deletion in the LiveRangeEdit

Jun 6 2019, 6:04 AM · Restricted Project, debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Handle the TargetDecl in more secure way (the same as the other code in the function)

Jun 6 2019, 6:01 AM · Restricted Project
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Explicitly enable the option only in the case of X86

Jun 6 2019, 5:58 AM · Restricted Project, debug-info

Jun 5 2019

djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@dstenb Thanks for the comment!

Jun 5 2019, 6:13 AM · Restricted Project, debug-info

Jun 4 2019

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

Oh.. and could you please document this either in LangRef.rst or SourceLevelDebugging.rst?

Sure. Please find it in the latest patch.
Thanks for your comments!

Jun 4 2019, 3:35 AM · Restricted Project, debug-info
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Address suggestions
-Document this

Jun 4 2019, 3:35 AM · Restricted Project, debug-info

May 31 2019

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

(2) function declarations may have a unique DISubprogram attached (new)

In addition, this will address only this.

May 31 2019, 5:38 AM · Restricted Project, debug-info
djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

@aprantl , @dexonsmith Thanks for your comments!

May 31 2019, 5:37 AM · Restricted Project, debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase tests

May 31 2019, 5:12 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase tests

May 31 2019, 5:12 AM · Restricted Project, debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Rebase

May 31 2019, 5:12 AM · Restricted Project
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Remove the SP flag
-Attach a unique sp to a declaration for the purpose of call site dbg info

May 31 2019, 5:12 AM · Restricted Project, debug-info

May 30 2019

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

I'm sorry if the answer to that question is already in your reply and I just failed to parse it: Why do we need the DISPFlagDeclForCallSite *flag* to differentiate the a DISubprogram. Isn't the fact that it is attached to a forward-declaration enough?

May 30 2019, 6:41 AM · Restricted Project, debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Rebase

May 30 2019, 6:34 AM · Restricted Project
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Refactor the code
-Change the test case

May 30 2019, 6:31 AM · Restricted Project, debug-info

May 29 2019

djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
May 29 2019, 5:52 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Addressing suggestions

May 29 2019, 5:52 AM · Restricted Project, debug-info
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Follow the new order of fields inside the ArgRegPair struct (the struct is now better packed))

May 29 2019, 5:52 AM · Restricted Project, debug-info
djtodoro updated the diff for D61061: [MachineFunction] Base support for call site info tracking.

-Addressing suggestions

May 29 2019, 5:49 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Addressing suggestions

May 29 2019, 5:47 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Addressing suggestions

May 29 2019, 5:47 AM · Restricted Project, debug-info

May 28 2019

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

@aprantl Thanks again for your comments!

May 28 2019, 11:58 PM · Restricted Project, debug-info

May 27 2019

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Addressing comments

May 27 2019, 6:47 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@dstenb Thanks a lot for your comments!

May 27 2019, 6:47 AM · Restricted Project, debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Refactor the code a bit
-Rebase

May 27 2019, 5:22 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Refactor test cases a bit
-Rebase

May 27 2019, 5:22 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Refactor the code a bit
-Rebase

May 27 2019, 5:18 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Rebase

May 27 2019, 5:17 AM · Restricted Project, debug-info
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Rebase

May 27 2019, 5:17 AM · Restricted Project, debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Rebase

May 27 2019, 5:17 AM · Restricted Project
djtodoro updated the diff for D61061: [MachineFunction] Base support for call site info tracking.

-Rebase

May 27 2019, 5:17 AM · Restricted Project, debug-info
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Rebase
-Improve the verifier
-Add a test
-Document the spFlag
-Refactor the code

May 27 2019, 5:13 AM · Restricted Project, debug-info