Page MenuHomePhabricator
Feed Advanced Search

Yesterday

djtodoro added a comment to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

Nice, thanks! Please post the rest of the patches, when you are ready, and make a stack of the patches.

This five patches reduces 'total availability' metric of clang binary
(debug build) from 126% to 87%.

I guess we are talking about the build with -g -O2?

Thu, Jan 16, 2:54 AM · debug-info, Restricted Project
djtodoro added a comment to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

Nice, thanks! Please post the rest of the patches, when you are ready, and make a stack of the patches.

Thu, Jan 16, 12:44 AM · debug-info, Restricted Project
djtodoro added a project to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs: debug-info.
Thu, Jan 16, 12:44 AM · debug-info, Restricted Project

Wed, Jan 15

djtodoro committed rG3b8ef7876ec7: [llvm-locstats] Add the --compare option (authored by djtodoro).
[llvm-locstats] Add the --compare option
Wed, Jan 15, 5:43 AM
djtodoro closed D71870: [llvm-locstats] Add the --compare option.
Wed, Jan 15, 5:43 AM · Restricted Project, debug-info
djtodoro committed rGce8795eb6c05: [llvm-locstats] Fix the docs (authored by djtodoro).
[llvm-locstats] Fix the docs
Wed, Jan 15, 3:33 AM
djtodoro committed rGada964661e2b: [llvm-locstats] Add the --draw-plot option (authored by djtodoro).
[llvm-locstats] Add the --draw-plot option
Wed, Jan 15, 3:06 AM
djtodoro closed D71869: [llvm-locstats] Add the --draw-plot option.
Wed, Jan 15, 3:05 AM · Restricted Project, debug-info
djtodoro committed rGa3ebc40644d7: [llvm-locstats][NFC] Support OOP concept (authored by djtodoro).
[llvm-locstats][NFC] Support OOP concept
Wed, Jan 15, 2:47 AM
djtodoro closed D71868: [llvm-locstats][NFC] Support OOP concept.
Wed, Jan 15, 2:47 AM · Restricted Project, debug-info
djtodoro added a comment to D71870: [llvm-locstats] Add the --compare option.

@aprantl Thanks for the comment, sorry for the late response, I was on the vacation.

How ubiquitous is matplotlib? I wonder if it might be better to textually print out a gnuplot file or something similar. OTOH the surface area in the code seems to be really small, so this may be fine.

I see the matplotlib is used within some of the LLVM Python tools, but I can investigate this further in order to see if the gnuplot is better option for this.

@aprantl For this option I would keep using the matplotlib (there is a help message saying we need the library, please see e.g. clang/utils/analyzer/CmpRuns.py).
Although, I think the gnuplot could be useful as well, but I don't see any obstacle that both ways of plotting coexist here, so we can add another feature to the llvm-locstats tool generating a gnuplot text file. WDYT?

Gnuplot also has a weird license and I don't necessarily want to introduce it as a dependency either. But some form of dumping the raw data that is being graphed into some sort of machine-readable output (perhaps CSV?) could be useful for importing it into other tools like spreadsheets, pgfplot, gnuplot and so on.

Wed, Jan 15, 1:32 AM · Restricted Project, debug-info

Tue, Jan 14

djtodoro added a comment to D71870: [llvm-locstats] Add the --compare option.

@aprantl Thanks for the comment, sorry for the late response, I was on the vacation.

How ubiquitous is matplotlib? I wonder if it might be better to textually print out a gnuplot file or something similar. OTOH the surface area in the code seems to be really small, so this may be fine.

I see the matplotlib is used within some of the LLVM Python tools, but I can investigate this further in order to see if the gnuplot is better option for this.

Tue, Jan 14, 3:53 AM · Restricted Project, debug-info

Mon, Jan 13

djtodoro added inline comments to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Mon, Jan 13, 11:30 PM · Restricted Project, debug-info
djtodoro updated the diff for D71870: [llvm-locstats] Add the --compare option.

-Addressing comments

Mon, Jan 13, 5:11 AM · Restricted Project, debug-info
djtodoro updated the diff for D71868: [llvm-locstats][NFC] Support OOP concept.

-Addressing comments

Mon, Jan 13, 5:11 AM · Restricted Project, debug-info
djtodoro updated the diff for D71869: [llvm-locstats] Add the --draw-plot option.

-Rebase

Mon, Jan 13, 5:11 AM · Restricted Project, debug-info
djtodoro added a comment to D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes).

I guess this should be closed? :)

Mon, Jan 13, 1:23 AM · Restricted Project
djtodoro added a comment to D71870: [llvm-locstats] Add the --compare option.

@aprantl Thanks for the comment, sorry for the late response, I was on the vacation.

Mon, Jan 13, 1:21 AM · Restricted Project, debug-info
djtodoro added a comment to D71869: [llvm-locstats] Add the --draw-plot option.

@vsk, @dstenb Thank you both for your comments!

Mon, Jan 13, 12:25 AM · Restricted Project, debug-info
djtodoro added a comment to D71868: [llvm-locstats][NFC] Support OOP concept.

Thanks for the comments! Sorry for the late response, I was on the vacation.

Mon, Jan 13, 12:25 AM · Restricted Project, debug-info
djtodoro added a comment to D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls.

Please add a test case.

Mon, Jan 13, 12:25 AM · debug-info, Restricted Project
djtodoro added inline comments to D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Mon, Jan 13, 12:25 AM · Restricted Project, Restricted Project
djtodoro added inline comments to D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Mon, Jan 13, 12:18 AM · Restricted Project, Restricted Project

Sun, Jan 12

djtodoro added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

Thanks for this!

Sun, Jan 12, 11:30 PM · Restricted Project, debug-info

Wed, Dec 25

djtodoro added inline comments to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.
Wed, Dec 25, 11:47 PM · Restricted Project, Restricted Project, debug-info
djtodoro updated the summary of D71868: [llvm-locstats][NFC] Support OOP concept.
Wed, Dec 25, 12:51 AM · Restricted Project, debug-info
djtodoro added a comment to D71870: [llvm-locstats] Add the --compare option.

An example of the plot on a GDB binary built with LLVM Trunk using the entry values vs. no entry values.

Wed, Dec 25, 12:41 AM · Restricted Project, debug-info
djtodoro added a parent revision for D71870: [llvm-locstats] Add the --compare option: D71869: [llvm-locstats] Add the --draw-plot option.
Wed, Dec 25, 12:41 AM · Restricted Project, debug-info
djtodoro added a child revision for D71869: [llvm-locstats] Add the --draw-plot option: D71870: [llvm-locstats] Add the --compare option.
Wed, Dec 25, 12:41 AM · Restricted Project, debug-info
djtodoro created D71870: [llvm-locstats] Add the --compare option.
Wed, Dec 25, 12:41 AM · Restricted Project, debug-info
djtodoro added a child revision for D71868: [llvm-locstats][NFC] Support OOP concept: D71869: [llvm-locstats] Add the --draw-plot option.
Wed, Dec 25, 12:32 AM · Restricted Project, debug-info
djtodoro added a parent revision for D71869: [llvm-locstats] Add the --draw-plot option: D71868: [llvm-locstats][NFC] Support OOP concept.
Wed, Dec 25, 12:32 AM · Restricted Project, debug-info
djtodoro added a comment to D71869: [llvm-locstats] Add the --draw-plot option.

An example of the plot on a GDB binary built with LLVM Trunk.

Wed, Dec 25, 12:32 AM · Restricted Project, debug-info
djtodoro created D71869: [llvm-locstats] Add the --draw-plot option.
Wed, Dec 25, 12:32 AM · Restricted Project, debug-info
djtodoro created D71868: [llvm-locstats][NFC] Support OOP concept.
Wed, Dec 25, 12:23 AM · Restricted Project, debug-info

Tue, Dec 24

djtodoro added inline comments to D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass..
Tue, Dec 24, 1:21 AM · Restricted Project
djtodoro added inline comments to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.
Tue, Dec 24, 1:21 AM · Restricted Project, Restricted Project, debug-info

Mon, Dec 23

djtodoro added inline comments to D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass..
Mon, Dec 23, 6:03 AM · Restricted Project
djtodoro added inline comments to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.
Mon, Dec 23, 6:02 AM · Restricted Project, Restricted Project, debug-info

Thu, Dec 19

djtodoro accepted D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.

Thanks for doing this! Looks good to me now!

Thu, Dec 19, 7:54 AM · Restricted Project
djtodoro added a comment to D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.

Please make sure the tool name is llvm-locstats instead of llvm-covstat.

Thu, Dec 19, 7:32 AM · Restricted Project
djtodoro updated subscribers of D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats.
Thu, Dec 19, 7:32 AM · Restricted Project
djtodoro added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Something like the diff bellow would address the concerns.

diff --git a/llvm/utils/llvm-locstats/CMakeLists.txt b/llvm/utils/llvm-locstats/CMakeLists.txt
index d5366f99050..82099fed314 100644
--- a/llvm/utils/llvm-locstats/CMakeLists.txt
+++ b/llvm/utils/llvm-locstats/CMakeLists.txt
@@ -2,6 +2,7 @@ if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
   add_custom_command(
     OUTPUT ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     DEPENDS ${LLVM_MAIN_SRC_DIR}/utils/llvm-locstats/llvm-locstats.py
+    DEPENDS llvm-dwarfdump
     COMMAND ${CMAKE_COMMAND} -E copy ${LLVM_MAIN_SRC_DIR}/utils/llvm-locstats/llvm-locstats.py ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     COMMENT "Copying llvm-locstats into ${LLVM_TOOLS_BINARY_DIR}"
     )
Thu, Dec 19, 6:06 AM · Restricted Project
djtodoro added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Something like the diff bellow would address the concerns.

Thu, Dec 19, 4:51 AM · Restricted Project
djtodoro added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Sorry for the confusion. May be the llvm/CMakeLists.txt is better place to address this?

llvm/CMakeLists.txt:

if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
  add_subdirectory(utils/llvm-locstats)
endif()

Changing it to:

if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS AND LLVM_BUILD_TOOLS)
  add_subdirectory(utils/llvm-locstats)

Doesn't help the issue, but maybe I'm missing your point here?

Yes that was my point. Should we add the AND LLVM_BUILD_TOOLS part in both of the llvm/CMakeLists.txt and llvm/utils/llvm-locstats/CMakeLists.txt?

This won't solve the problem you reported..

Thu, Dec 19, 3:33 AM · Restricted Project
djtodoro added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Sorry for the confusion. May be the llvm/CMakeLists.txt is better place to address this?

llvm/CMakeLists.txt:

if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
  add_subdirectory(utils/llvm-locstats)
endif()

Changing it to:

if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS AND LLVM_BUILD_TOOLS)
  add_subdirectory(utils/llvm-locstats)

Doesn't help the issue, but maybe I'm missing your point here?

Yes that was my point. Should we add the AND LLVM_BUILD_TOOLS part in both of the llvm/CMakeLists.txt and llvm/utils/llvm-locstats/CMakeLists.txt?

Thu, Dec 19, 3:14 AM · Restricted Project
djtodoro added a comment to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Sorry for the confusion. May be the llvm/CMakeLists.txt is better place to address this?

Thu, Dec 19, 2:49 AM · Restricted Project
djtodoro requested changes to D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Hm...actually...this is not good..

Thu, Dec 19, 2:45 AM · Restricted Project
djtodoro accepted D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built..

Thanks!

Thu, Dec 19, 2:39 AM · Restricted Project

Dec 17 2019

djtodoro accepted D71611: [cmake] Add llvm-locstats to LLVM_TEST_DEPENDS.

Good change! It sound reasonable to me.

Dec 17 2019, 8:47 AM · Restricted Project
djtodoro added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Looks good to me! Thanks!

Dec 17 2019, 8:43 AM · Restricted Project
djtodoro added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Sorry, one more nit included.

Dec 17 2019, 6:10 AM · Restricted Project
djtodoro added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

LGTM, thanks!

Dec 17 2019, 6:10 AM · Restricted Project

Dec 16 2019

djtodoro added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Thanks for addressing the comments.

Dec 16 2019, 12:07 PM · Restricted Project, debug-info
djtodoro added inline comments to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Dec 16 2019, 8:06 AM · Restricted Project, debug-info
djtodoro added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks for this! This looks good to me now!

Dec 16 2019, 7:20 AM · Restricted Project, debug-info

Dec 13 2019

djtodoro committed rGbaea913609f1: [llvm-locstats] Avoid the locstats when no scope bytes coverage found (authored by djtodoro).
[llvm-locstats] Avoid the locstats when no scope bytes coverage found
Dec 13 2019, 4:54 AM
djtodoro closed D71415: [llvm-locstats] Avoid the loc stats for the cases with no scope bytes coverage.
Dec 13 2019, 4:54 AM · Restricted Project, debug-info

Dec 12 2019

djtodoro added inline comments to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Dec 12 2019, 11:28 PM · Restricted Project
djtodoro added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Please address my comments and try using the DIExpression::appendExt(). Thanks.

Dec 12 2019, 11:19 PM · Restricted Project
djtodoro added a comment to D71416: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

We can use llvm.org/pr44275 to track improvements for this.

Dec 12 2019, 6:16 AM · Restricted Project, debug-info
djtodoro created D71415: [llvm-locstats] Avoid the loc stats for the cases with no scope bytes coverage.
Dec 12 2019, 5:48 AM · Restricted Project, debug-info
djtodoro accepted D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.

Please wait for someone else from the debug-info project to take a look as well.

Dec 12 2019, 4:54 AM · debug-info, Restricted Project

Dec 11 2019

djtodoro added a comment to D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

This one should be rebased on top of the D71366.

Dec 11 2019, 11:57 PM · debug-info, Restricted Project
djtodoro added a comment to D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.

@krisb Thanks for this!

Dec 11 2019, 11:12 PM · debug-info, Restricted Project
djtodoro added a project to D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC: debug-info.
Dec 11 2019, 11:12 PM · debug-info, Restricted Project

Dec 9 2019

djtodoro added inline comments to D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.
Dec 9 2019, 11:48 PM · debug-info, Restricted Project
djtodoro committed rG9b9e995819fe: [DebugInfo][EarlyCSE] Use the salvageDebugInfoOrMarkUndef(); NFC (authored by djtodoro).
[DebugInfo][EarlyCSE] Use the salvageDebugInfoOrMarkUndef(); NFC
Dec 9 2019, 4:59 AM
djtodoro closed D71061: [DebugInfo][EarlyCSE] Use the salvageDebugInfoOrMarkUndef(); NFC.
Dec 9 2019, 4:59 AM · Restricted Project, debug-info
djtodoro added a comment to D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

@krisb Thanks for this again. First option seems better to me.

Dec 9 2019, 3:34 AM · debug-info, Restricted Project

Dec 8 2019

djtodoro added a comment to D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

@djtodoro , yeah, it doesn't look good.
I also considered an option to rename the first bucket to smth like "No location info" or "Not covered" or something similar then the second can be safely named '0-9%'.
Or simply to use '0-9%' together with '0%' which might be a bit unclear, but as docs say 'The line 0% shows the number and the percentage of DIEs with no location information', it should not be confusing.

does this bucket include 9%? I guess the next bucket starts at 10%, so 0-9 includes 9.99%? so technically this one is (0, 10)% and the next one is [10, 91)% etc... (or I guess you could put the % inside the braces/parens)? but that might be insufficiently obvious to read?

Dec 8 2019, 11:29 PM · debug-info, Restricted Project
djtodoro accepted D70431: [DebugInfo] Make describeLoadedValue() reg aware.

LGTM as well! Thanks!

Dec 8 2019, 11:29 PM · Restricted Project, debug-info

Dec 6 2019

djtodoro added inline comments to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Dec 6 2019, 7:24 AM · Restricted Project, debug-info
djtodoro added a comment to D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

Hm, the bucket name ‘>0-9%' does not look nice to me as well.

Dec 6 2019, 7:15 AM · debug-info, Restricted Project
djtodoro added inline comments to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Dec 6 2019, 5:43 AM · Restricted Project, debug-info

Dec 5 2019

djtodoro added a project to D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%: debug-info.
Dec 5 2019, 11:40 PM · debug-info, Restricted Project
djtodoro accepted D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

LGTM as well, thanks!

Dec 5 2019, 11:40 PM · debug-info, Restricted Project
djtodoro created D71061: [DebugInfo][EarlyCSE] Use the salvageDebugInfoOrMarkUndef(); NFC.
Dec 5 2019, 6:02 AM · Restricted Project, debug-info
djtodoro committed rG52b231ee84ca: [LiveDebugValues] Silence the unused var warning; NFC (authored by djtodoro).
[LiveDebugValues] Silence the unused var warning; NFC
Dec 5 2019, 3:34 AM
djtodoro accepted D71024: [DebugInfo] Handle call site values for instructions before call bundle.

Looks good! Thanks!

Dec 5 2019, 2:57 AM · Restricted Project, debug-info
djtodoro committed rG4b4ede440a2a: Reland "[LiveDebugValues] Introduce entry values of unmodified params" (authored by djtodoro).
Reland "[LiveDebugValues] Introduce entry values of unmodified params"
Dec 5 2019, 2:12 AM

Dec 4 2019

djtodoro added inline comments to D68209: [LiveDebugValues] Introduce entry values of unmodified params.
Dec 4 2019, 3:21 AM · Restricted Project, Restricted Project, debug-info
djtodoro added inline comments to D69178: [DebugInfo] Use DBG_VALUEs IsIndirect field for describing stack spills.
Dec 4 2019, 2:35 AM · Restricted Project

Dec 3 2019

djtodoro added a comment to D68209: [LiveDebugValues] Introduce entry values of unmodified params.

Reverted while investigating. I am not sure what happened, since the test passed on my machine. Thanks!

Dec 3 2019, 4:23 AM · Restricted Project, Restricted Project, debug-info
djtodoro committed rG409350deeaf2: Revert "[LiveDebugValues] Introduce entry values of unmodified params" (authored by djtodoro).
Revert "[LiveDebugValues] Introduce entry values of unmodified params"
Dec 3 2019, 4:14 AM
djtodoro added a reverting change for rG4cfceb910692: [LiveDebugValues] Introduce entry values of unmodified params: rG409350deeaf2: Revert "[LiveDebugValues] Introduce entry values of unmodified params".
Dec 3 2019, 4:14 AM
djtodoro added a comment to D68209: [LiveDebugValues] Introduce entry values of unmodified params.

Thanks for the reviews!

Dec 3 2019, 2:10 AM · Restricted Project, Restricted Project, debug-info
djtodoro committed rG4cfceb910692: [LiveDebugValues] Introduce entry values of unmodified params (authored by djtodoro).
[LiveDebugValues] Introduce entry values of unmodified params
Dec 3 2019, 2:05 AM
djtodoro closed D68209: [LiveDebugValues] Introduce entry values of unmodified params.
Dec 3 2019, 2:05 AM · Restricted Project, Restricted Project, debug-info
djtodoro added inline comments to D70720: [llvm-objdump] Display locations of variables alongside disassembly.
Dec 3 2019, 12:15 AM · debug-info, Restricted Project
djtodoro added a project to D70720: [llvm-objdump] Display locations of variables alongside disassembly: debug-info.
Dec 3 2019, 12:06 AM · debug-info, Restricted Project

Nov 28 2019

djtodoro added inline comments to D70431: [DebugInfo] Make describeLoadedValue() reg aware.
Nov 28 2019, 11:24 PM · Restricted Project, debug-info
djtodoro accepted D70248: Disallow shift operations in debug expressions spanning multiple registers.

LGTM. Thanks for doing this!

Nov 28 2019, 1:54 AM · Restricted Project
djtodoro added inline comments to D70431: [DebugInfo] Make describeLoadedValue() reg aware.
Nov 28 2019, 1:31 AM · Restricted Project, debug-info
djtodoro added a comment to D70431: [DebugInfo] Make describeLoadedValue() reg aware.

I like the way of the implementation. Thanks!

Nov 28 2019, 1:31 AM · Restricted Project, debug-info
djtodoro added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

I'm not sure if that's possible here. Everything seems quite interdependent, and the bug fix (functionality change) happens as a result of the structural change (also a functionality change).
I could split this into two or more dependant patches and keep 'related' things together. For example, put all the debug print() updates in a single patch. Not sure that this would this help though, what do you think?
There is a very small change/fix to DbgValueLocation which I included in this patch. I could take that out (and probably should) but it won't have a noticable impact on the diff size.

I see. The semantic of the change does not allow us to get it shorter, so I am OK with that. Thanks for considering that!

Nov 28 2019, 12:56 AM · Restricted Project, debug-info

Nov 27 2019

djtodoro added a comment to D68209: [LiveDebugValues] Introduce entry values of unmodified params.

@jmorse Thanks for your comment!

Nov 27 2019, 5:49 AM · Restricted Project, Restricted Project, debug-info

Nov 26 2019

djtodoro added a comment to D68209: [LiveDebugValues] Introduce entry values of unmodified params.

Ping.

Nov 26 2019, 9:44 AM · Restricted Project, Restricted Project, debug-info

Nov 25 2019

djtodoro added a comment to D70431: [DebugInfo] Make describeLoadedValue() reg aware.

IMO, if there is no specifications for recognizing the instructions that may zero-extend, the individual per-target handling seems good to me.

Nov 25 2019, 11:39 PM · Restricted Project, debug-info
djtodoro added a comment to D70601: Disallow DIExpressions with shift operators from being fragmented.

LGTM. It might be cleaner to replace the macros with helper functions which accept opcodes as vector<uint64_t> (using brace init on the caller side should be pretty readable).

+1

Nov 25 2019, 6:12 AM · Restricted Project, debug-info