Page MenuHomePhabricator
Feed Advanced Search

Today

djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Remove const from getSDCallSiteInfo()

Wed, Apr 24, 6:09 AM · debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase
-Addressing comments
-Rename interpretationAnalysis()--> collectCallSiteParameters()
-Refactor the code

Wed, Apr 24, 5:42 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Addressing comments

Wed, Apr 24, 5:40 AM · debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Add documentation
-Add a verifier check

Wed, Apr 24, 5:40 AM · debug-info
djtodoro added a child revision for D61062: Keep call site info valid through the backend: D60866: [DWARF] Handle DW_OP_entry_value operand.
Wed, Apr 24, 5:34 AM · debug-info
djtodoro added a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D61062: Keep call site info valid through the backend.
Wed, Apr 24, 5:34 AM · debug-info
djtodoro added a parent revision for D61062: Keep call site info valid through the backend: D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Wed, Apr 24, 5:34 AM · debug-info
djtodoro edited child revisions for D60715: [ISEL][X86] Tracking of registers that forward call arguments, added: 1; removed: 1.
Wed, Apr 24, 5:34 AM · debug-info
djtodoro removed a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Wed, Apr 24, 5:34 AM · debug-info
djtodoro added a child revision for D60714: [clang] Add DISuprogram and DIE for func decl of an external : D61061: [MachineFunction] Base support for call site info tracking.
Wed, Apr 24, 5:32 AM
djtodoro added a parent revision for D61061: [MachineFunction] Base support for call site info tracking: D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Wed, Apr 24, 5:32 AM · debug-info
djtodoro added a child revision for D61061: [MachineFunction] Base support for call site info tracking: D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Wed, Apr 24, 5:32 AM · debug-info
djtodoro edited parent revisions for D60715: [ISEL][X86] Tracking of registers that forward call arguments, added: 1; removed: 1.
Wed, Apr 24, 5:32 AM · debug-info
djtodoro removed a child revision for D60714: [clang] Add DISuprogram and DIE for func decl of an external : D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Wed, Apr 24, 5:32 AM
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Split up of introduction, production and handling of call site info

Wed, Apr 24, 5:31 AM · debug-info
djtodoro created D61062: Keep call site info valid through the backend.
Wed, Apr 24, 5:21 AM · debug-info
djtodoro created D61061: [MachineFunction] Base support for call site info tracking.
Wed, Apr 24, 5:16 AM · debug-info
djtodoro added a comment to D60866: [DWARF] Handle DW_OP_entry_value operand.

This looks mostly good, IMO what's missing is

Thanks!

an entry in SourceLevelDebugging.rst (or LangRef.rst?) explaining the semantics and limitations of our DW_OP_entry_value support

Done.

a Verifier check that yells when a DW_OP_entry_value is not at position 0

Done.

bonus points for refactoring the With* parameters to a flag enum that is slightly less error-prone to use.

Since there are a lot of places using With* it is better doing this as a separate commit. I am working on the patch. :)

Wed, Apr 24, 4:52 AM · debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@aprantl Thanks for your comments!

Wed, Apr 24, 4:47 AM · debug-info
djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Wed, Apr 24, 4:43 AM · debug-info

Yesterday

djtodoro added a comment to D58033: Add option for emitting dbg info for call site parameters.

Is there some kind of testcase?

@aprantl Usage of the option is tested within following patches from the stack. I am not sure if we need some additional test here?

Tue, Apr 23, 4:43 AM · debug-info
djtodoro removed a reviewer for D60714: [clang] Add DISuprogram and DIE for func decl of an external : petarj.
Tue, Apr 23, 4:39 AM
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Move debug info related code into CGDebugInfo::HandleFunctionCall()
-Add test case

Tue, Apr 23, 4:37 AM
djtodoro added a comment to D60714: [clang] Add DISuprogram and DIE for func decl of an external .

@aprantl Sure. Thanks for your comments!

Tue, Apr 23, 4:35 AM

Mon, Apr 22

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase

Mon, Apr 22, 4:53 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase

Mon, Apr 22, 4:53 AM · debug-info
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Rebase

Mon, Apr 22, 4:53 AM · debug-info
djtodoro added a parent revision for D58034: [IR/DIVar] Add flag for params that have unchanged values: D60961: [TargetOption] Add option for enabling param entry val tracking dbg info.
Mon, Apr 22, 4:49 AM · debug-info
djtodoro added a child revision for D60961: [TargetOption] Add option for enabling param entry val tracking dbg info: D58034: [IR/DIVar] Add flag for params that have unchanged values.
Mon, Apr 22, 4:49 AM · debug-info
djtodoro edited child revisions for D58033: Add option for emitting dbg info for call site parameters, added: 1; removed: 1.
Mon, Apr 22, 4:49 AM · debug-info
djtodoro added a parent revision for D60961: [TargetOption] Add option for enabling param entry val tracking dbg info: D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 22, 4:49 AM · debug-info
djtodoro removed a parent revision for D58034: [IR/DIVar] Add flag for params that have unchanged values: D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 22, 4:49 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Add only cc1 option
-Set up back end

Mon, Apr 22, 4:47 AM · debug-info
djtodoro created D60961: [TargetOption] Add option for enabling param entry val tracking dbg info.
Mon, Apr 22, 4:45 AM · debug-info
djtodoro abandoned D58043: Add experimental options for call site related dbg info.
Mon, Apr 22, 4:39 AM · debug-info
djtodoro removed a child revision for D58043: Add experimental options for call site related dbg info: D60716: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Apr 22, 4:37 AM · debug-info
djtodoro removed a parent revision for D60716: [DwarfDebug] Dump call site debug info into DWARF: D58043: Add experimental options for call site related dbg info.
Mon, Apr 22, 4:37 AM · debug-info
djtodoro edited child revisions for D58042: [LiveDebugValues] Emit parameter's entry value, added: 1; removed: 1.
Mon, Apr 22, 4:37 AM · debug-info
djtodoro removed a parent revision for D58043: Add experimental options for call site related dbg info: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Apr 22, 4:37 AM · debug-info
djtodoro added a parent revision for D60716: [DwarfDebug] Dump call site debug info into DWARF: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Apr 22, 4:37 AM · debug-info

Thu, Apr 18

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase
-Update tests

Thu, Apr 18, 6:24 AM · debug-info
djtodoro added a child revision for D58042: [LiveDebugValues] Emit parameter's entry value: D58043: Add experimental options for call site related dbg info.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro added a parent revision for D58043: Add experimental options for call site related dbg info: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro added a parent revision for D58042: [LiveDebugValues] Emit parameter's entry value: D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro added a child revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro removed a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:21 AM · debug-info
djtodoro removed a child revision for D58042: [LiveDebugValues] Emit parameter's entry value: D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, Apr 18, 6:21 AM · debug-info
djtodoro edited child revisions for D60715: [ISEL][X86] Tracking of registers that forward call arguments, added: 1; removed: 1.
Thu, Apr 18, 6:20 AM · debug-info
djtodoro removed a parent revision for D58042: [LiveDebugValues] Emit parameter's entry value: D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Thu, Apr 18, 6:20 AM · debug-info
djtodoro added a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Thu, Apr 18, 6:20 AM · debug-info
djtodoro edited child revisions for D58042: [LiveDebugValues] Emit parameter's entry value, added: 1; removed: 1.
Thu, Apr 18, 6:16 AM · debug-info
djtodoro added a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:16 AM · debug-info
djtodoro removed a parent revision for D58043: Add experimental options for call site related dbg info: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:16 AM · debug-info
djtodoro created D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, Apr 18, 6:15 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Use DW_OP_entry_value from DWARF 5
-Split up introduction and production of entry values

Thu, Apr 18, 6:15 AM · debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.
Thu, Apr 18, 2:15 AM · debug-info

Wed, Apr 17

djtodoro updated the diff for D58043: Add experimental options for call site related dbg info.

-Rebase

Wed, Apr 17, 8:02 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Fix comments

Wed, Apr 17, 7:55 AM · debug-info
djtodoro updated the diff for D58043: Add experimental options for call site related dbg info.

-Rebase

Wed, Apr 17, 7:42 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Refactor
-Remove CC1 def

Wed, Apr 17, 7:35 AM · debug-info
djtodoro added a comment to D58033: Add option for emitting dbg info for call site parameters.

@probinson @aprantl Thanks a lot for your comments!

Wed, Apr 17, 7:32 AM · debug-info
djtodoro added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
Wed, Apr 17, 3:33 AM · debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Format
-Support DWARF 5 as well

Wed, Apr 17, 3:13 AM
djtodoro added inline comments to D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Wed, Apr 17, 3:10 AM

Tue, Apr 16

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Minor refactor

Tue, Apr 16, 5:49 AM · debug-info
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Run clang-format
-Use cast instead of 'dyn_cast'

Tue, Apr 16, 5:49 AM · debug-info
djtodoro added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Tue, Apr 16, 5:42 AM · debug-info
djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Tue, Apr 16, 12:04 AM · debug-info

Mon, Apr 15

djtodoro added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 15, 11:44 PM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

Thanks!

Mon, Apr 15, 11:44 PM · debug-info
djtodoro added a reviewer for D60716: [DwarfDebug] Dump call site debug info into DWARF: qcolombet.
Mon, Apr 15, 9:01 AM · debug-info
djtodoro added reviewers for D60715: [ISEL][X86] Tracking of registers that forward call arguments: llvm-commits, probinson, vsk, qcolombet.
Mon, Apr 15, 9:00 AM · debug-info
djtodoro added reviewers for D60713: [IR] Add DISuprogram and DIE for func decl of an external: llvm-commits, aprantl, probinson, vsk.
Mon, Apr 15, 9:00 AM · debug-info
djtodoro added reviewers for D60712: [DWARF] Add GNU extensions for call site info DWARF symbols: llvm-commits, aprantl, probinson, vsk.
Mon, Apr 15, 9:00 AM · debug-info
djtodoro removed a parent revision for D58044: [DwarfDebug] Dump call site debug info into DWARF: D58043: Add experimental options for call site related dbg info.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro created D60716: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro edited child revisions for D58043: Add experimental options for call site related dbg info, added: 1; removed: 1.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro added a parent revision for D60716: [DwarfDebug] Dump call site debug info into DWARF: D58043: Add experimental options for call site related dbg info.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro updated the diff for D58043: Add experimental options for call site related dbg info.
Mon, Apr 15, 8:53 AM · debug-info
djtodoro edited parent revisions for D58042: [LiveDebugValues] Emit parameter's entry value, added: 1; removed: 1.
Mon, Apr 15, 8:50 AM · debug-info
djtodoro added a child revision for D60715: [ISEL][X86] Tracking of registers that forward call arguments: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Apr 15, 8:50 AM · debug-info
djtodoro removed a child revision for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Apr 15, 8:50 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase
-Follow-up with the new approach

Mon, Apr 15, 8:50 AM · debug-info
djtodoro added a child revision for D60714: [clang] Add DISuprogram and DIE for func decl of an external : D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Mon, Apr 15, 8:49 AM
djtodoro added a parent revision for D60715: [ISEL][X86] Tracking of registers that forward call arguments: D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Mon, Apr 15, 8:49 AM · debug-info
djtodoro created D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Mon, Apr 15, 8:49 AM · debug-info
djtodoro added a child revision for D60713: [IR] Add DISuprogram and DIE for func decl of an external: D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Mon, Apr 15, 8:43 AM · debug-info
djtodoro added a parent revision for D60714: [clang] Add DISuprogram and DIE for func decl of an external : D60713: [IR] Add DISuprogram and DIE for func decl of an external.
Mon, Apr 15, 8:43 AM
djtodoro created D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Mon, Apr 15, 8:43 AM
djtodoro edited child revisions for D58035: [clang/DIVar] Emit flag for params that have unchanged values, added: 1; removed: 1.
Mon, Apr 15, 8:36 AM · debug-info
djtodoro added a parent revision for D60713: [IR] Add DISuprogram and DIE for func decl of an external: D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, Apr 15, 8:36 AM · debug-info
djtodoro removed a parent revision for D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata: D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, Apr 15, 8:36 AM · debug-info
djtodoro created D60713: [IR] Add DISuprogram and DIE for func decl of an external.
Mon, Apr 15, 8:35 AM · debug-info
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Rebase
-Use ExprMutationAnalyzer for parameter's modification check

Mon, Apr 15, 8:31 AM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.

-Rebase
-Add setIsNotModified()

Mon, Apr 15, 8:31 AM · debug-info
djtodoro edited parent revisions for D58033: Add option for emitting dbg info for call site parameters, added: 1; removed: 1.
Mon, Apr 15, 8:29 AM · debug-info
djtodoro added a child revision for D60712: [DWARF] Add GNU extensions for call site info DWARF symbols: D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 15, 8:29 AM · debug-info
djtodoro removed a child revision for D58032: [Metadata] Introduce call site dbg info metadata: D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 15, 8:29 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Rebase
-Add all_call_sites flag in the case of GNU extensions

Mon, Apr 15, 8:26 AM · debug-info
djtodoro created D60712: [DWARF] Add GNU extensions for call site info DWARF symbols.
Mon, Apr 15, 8:20 AM · debug-info