-Remove const from getSDCallSiteInfo()
-Rename interpretationAnalysis()--> collectCallSiteParameters()
-Refactor the code
-Add a verifier check
-Split up of introduction, production and handling of call site info
This looks mostly good, IMO what's missing is
an entry in SourceLevelDebugging.rst (or LangRef.rst?) explaining the semantics and limitations of our DW_OP_entry_value support
a Verifier check that yells when a DW_OP_entry_value is not at position 0
bonus points for refactoring the With* parameters to a flag enum that is slightly less error-prone to use.
Since there are a lot of places using With* it is better doing this as a separate commit. I am working on the patch. :)
@aprantl Thanks for your comments!
Is there some kind of testcase?
@aprantl Usage of the option is tested within following patches from the stack. I am not sure if we need some additional test here?
-Move debug info related code into CGDebugInfo::HandleFunctionCall()
-Add test case
@aprantl Sure. Thanks for your comments!
Mon, Apr 22
-Add only cc1 option
-Set up back end
Thu, Apr 18
-Use DW_OP_entry_value from DWARF 5
-Split up introduction and production of entry values
Wed, Apr 17
-Remove CC1 def
-Support DWARF 5 as well
Tue, Apr 16
-Use cast instead of 'dyn_cast'
Mon, Apr 15
-Follow-up with the new approach
-Use ExprMutationAnalyzer for parameter's modification check
-Add all_call_sites flag in the case of GNU extensions