Page MenuHomePhabricator
Feed Advanced Search

Today

djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Tue, Sep 17, 6:42 AM · Restricted Project, debug-info
djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Tue, Sep 17, 2:10 AM · Restricted Project, debug-info

Yesterday

djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Mon, Sep 16, 8:00 AM · Restricted Project, debug-info

Thu, Sep 12

djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Thu, Sep 12, 11:55 PM · Restricted Project, debug-info
djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Thu, Sep 12, 11:25 PM · Restricted Project, debug-info
djtodoro requested review of D66526: [utils] Add the llvm-locstats tool.
Thu, Sep 12, 9:16 AM · Restricted Project, debug-info
djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.

-Adjust the CMake
-Adjust the tool to work on Windows (skip the backslash character from JSON string)
-Adjust the test case to work on Windows

Thu, Sep 12, 9:16 AM · Restricted Project, debug-info
djtodoro reopened D66526: [utils] Add the llvm-locstats tool.

This was reverted with the rL371527 due to test failure on Windows platform.

Thu, Sep 12, 8:55 AM · Restricted Project, debug-info
djtodoro added inline comments to D67398: [DebugInfo] LiveDebugValues: Move DBG_VALUE creation into VarLoc class.
Thu, Sep 12, 4:39 AM · Restricted Project
djtodoro added a comment to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.

@dstenb Thanks for this! This makes sense.

Thu, Sep 12, 4:39 AM · Restricted Project, debug-info

Wed, Sep 11

djtodoro added a comment to D67398: [DebugInfo] LiveDebugValues: Move DBG_VALUE creation into VarLoc class.

I think that the problem described within the D67393 imposes a solution with introducing something like DBG_LOC, as @aprantl already suggested.

Wed, Sep 11, 3:01 AM · Restricted Project
djtodoro added a project to D67410: [DWARF] Emit call site parameter info when tuning for lldb: debug-info.
Wed, Sep 11, 12:13 AM · debug-info, Restricted Project
djtodoro added a comment to D67410: [DWARF] Emit call site parameter info when tuning for lldb.

An idea: After this got implemented, we can add a new sub-directory inside the debuginfo-tests project called DOC (Debugging Optimized Code) and start testing (and tracking) improvements in that area. WDYT?

Wed, Sep 11, 12:11 AM · debug-info, Restricted Project
djtodoro added a comment to D67410: [DWARF] Emit call site parameter info when tuning for lldb.

Thanks for this! I am so exciting to see this implemented. :)

Wed, Sep 11, 12:01 AM · debug-info, Restricted Project

Tue, Sep 10

djtodoro committed rGb21cc626c9a7: Revert "[utils] Implement the llvm-locstats tool" (authored by djtodoro).
Revert "[utils] Implement the llvm-locstats tool"
Tue, Sep 10, 7:51 AM
djtodoro committed rL371527: Revert "[utils] Implement the llvm-locstats tool".
Revert "[utils] Implement the llvm-locstats tool"
Tue, Sep 10, 7:51 AM
djtodoro added a reverting change for rL371520: [utils] Implement the llvm-locstats tool: rL371527: Revert "[utils] Implement the llvm-locstats tool".
Tue, Sep 10, 7:51 AM
djtodoro committed rG54008972d17b: [utils] Implement the llvm-locstats tool (authored by djtodoro).
[utils] Implement the llvm-locstats tool
Tue, Sep 10, 6:47 AM
djtodoro committed rL371520: [utils] Implement the llvm-locstats tool.
[utils] Implement the llvm-locstats tool
Tue, Sep 10, 6:47 AM
djtodoro closed D66526: [utils] Add the llvm-locstats tool.
Tue, Sep 10, 6:46 AM · Restricted Project, debug-info
djtodoro committed rGc714a88a4dc4: [llvm-dwarfdump] Add additional stats fields (authored by djtodoro).
[llvm-dwarfdump] Add additional stats fields
Tue, Sep 10, 3:37 AM
djtodoro committed rL371506: [llvm-dwarfdump] Add additional stats fields.
[llvm-dwarfdump] Add additional stats fields
Tue, Sep 10, 3:36 AM
djtodoro closed D66525: [llvm-dwarfdump] Add additional stats fields.
Tue, Sep 10, 3:36 AM · Restricted Project, debug-info

Fri, Sep 6

djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

Is this OK to go?

Fri, Sep 6, 5:32 AM · Restricted Project, debug-info
djtodoro added a comment to D66525: [llvm-dwarfdump] Add additional stats fields.

@vsk Thanks a lot for the review!

Fri, Sep 6, 5:31 AM · Restricted Project, debug-info
djtodoro committed rGd409408e3172: [test] Update the name of the debug entry values option. NFC (authored by djtodoro).
[test] Update the name of the debug entry values option. NFC
Fri, Sep 6, 5:23 AM
djtodoro committed rL371199: [test] Update the name of the debug entry values option. NFC.
[test] Update the name of the debug entry values option. NFC
Fri, Sep 6, 5:23 AM
djtodoro added a comment to D67261: [NFC] Make the describeLoadedValue() hook return machine operand objects.

Thanks for this! This looks good.

Fri, Sep 6, 1:04 AM · Restricted Project, debug-info

Thu, Sep 5

djtodoro added a comment to D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.

Thanks for this! As we have discussed before, this is desirable for sure.

Thu, Sep 5, 11:42 PM · Restricted Project, debug-info
djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.

-Add the documentation
-Add the test case
-Adjust the CMake

Thu, Sep 5, 7:49 AM · Restricted Project, debug-info
djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Thu, Sep 5, 7:49 AM · Restricted Project, debug-info
djtodoro updated the diff for D66525: [llvm-dwarfdump] Add additional stats fields.

-Define and use a lambda expression to get the coverage bucket

Thu, Sep 5, 7:43 AM · Restricted Project, debug-info
djtodoro added inline comments to D66525: [llvm-dwarfdump] Add additional stats fields.
Thu, Sep 5, 7:42 AM · Restricted Project, debug-info

Wed, Sep 4

djtodoro committed rGa1a22f375abb: [llvm-dwarfdump] Fix spelling in the comments. NFC (authored by djtodoro).
[llvm-dwarfdump] Fix spelling in the comments. NFC
Wed, Sep 4, 2:46 AM
djtodoro committed rL370861: [llvm-dwarfdump] Fix spelling in the comments. NFC.
[llvm-dwarfdump] Fix spelling in the comments. NFC
Wed, Sep 4, 2:46 AM

Mon, Sep 2

djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.
-Use `print_function ` from `__future__`
Mon, Sep 2, 3:41 AM · Restricted Project, debug-info
djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Mon, Sep 2, 3:35 AM · Restricted Project, debug-info
djtodoro committed rG5c6b82a7567c: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols (authored by djtodoro).
[DWARFVerifier] Verify GNU extensions of call site DWARF symbols
Mon, Sep 2, 2:22 AM
djtodoro committed rL370631: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols.
[DWARFVerifier] Verify GNU extensions of call site DWARF symbols
Mon, Sep 2, 2:21 AM
djtodoro closed D66865: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols.
Mon, Sep 2, 2:20 AM · Restricted Project, debug-info

Fri, Aug 30

djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.
  • Simplify the code
  • Rebase
Fri, Aug 30, 3:26 AM · Restricted Project, debug-info
djtodoro updated the diff for D66525: [llvm-dwarfdump] Add additional stats fields.

-Fix the location stats output

Fri, Aug 30, 3:22 AM · Restricted Project, debug-info
djtodoro added a comment to D66865: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols.

@aprantl Thanks for the review!

Fri, Aug 30, 1:55 AM · Restricted Project, debug-info

Thu, Aug 29

djtodoro updated the diff for D66865: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols.

-Verify only GNU extensions in this patch

Thu, Aug 29, 2:29 AM · Restricted Project, debug-info
djtodoro added inline comments to D66865: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols.
Thu, Aug 29, 2:22 AM · Restricted Project, debug-info
djtodoro added a comment to D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

@dstenb Thanks a lot for the test case, I will take a look into that.

Thu, Aug 29, 1:40 AM · Restricted Project, debug-info

Wed, Aug 28

djtodoro added inline comments to D66888: [LiveDebugValues] Insert entry values after bundles.
Wed, Aug 28, 9:10 AM · Restricted Project, debug-info
djtodoro added a comment to D66888: [LiveDebugValues] Insert entry values after bundles.

@dstenb This is desirable! Thanks a lot for working on this! We also found such case when trying to add support for MIPS and we wanted to shared it, but it is good to see you also have found it!

Wed, Aug 28, 9:10 AM · Restricted Project, debug-info
djtodoro added a comment to D66865: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols.

@probinson Thanks a lot for your comments!

Wed, Aug 28, 6:27 AM · Restricted Project, debug-info
djtodoro created D66865: [DWARFVerifier] Verify GNU extensions of call site DWARF symbols.
Wed, Aug 28, 2:25 AM · Restricted Project, debug-info

Tue, Aug 27

djtodoro updated the diff for D66525: [llvm-dwarfdump] Add additional stats fields.

-Refactor the LocationStats struct

Tue, Aug 27, 5:31 AM · Restricted Project, debug-info
djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.

-Rebase
-Use the tempfile.TemporaryFile
-Use subprocess.calll
-Use os.path.join

Tue, Aug 27, 5:14 AM · Restricted Project, debug-info
djtodoro updated the diff for D66525: [llvm-dwarfdump] Add additional stats fields.

-Use std::vector to map more debug location categories in order to have more granular reports

Tue, Aug 27, 5:06 AM · Restricted Project, debug-info
djtodoro added a comment to D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

I have interpreted the size as meaning the byte size of the DWARF block that the operation will cover. Assuming that, at the time of running LiveDebugValues I don't think there is a good way to query the size of the block that the entry value will cover; we don't know that until we actually emit the DWARF, as far as I can tell. That is why I have assumed that a hard coded operand of 1 is emitted there, with the assumption that only simple register location descriptions are supported.

However, I now got uncertain when looking at prependOpcodes() which is used to add the operation to the DIExpression:

Ops.push_back(dwarf::DW_OP_entry_value);
Add size info needed for entry value expression.
Add plus one for target register operand.
Ops.push_back(Expr->getNumElements() + 1);

Tue, Aug 27, 3:01 AM · Restricted Project, debug-info

Mon, Aug 26

djtodoro added a comment to D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

Thanks for the patch.
We wanted to avoid any complex DIExpression here, so this looks good. In order to support it here, we need to add fully support within the AsmPrinter (DwarfDebug, DwarfExpression, DwarfCompileUnit) and then enable it here.

Mon, Aug 26, 11:42 PM · Restricted Project, debug-info
djtodoro added a comment to D66467: [Codegen] skip debug instr to avoid code change.

@yechunliang Thanks for the test case. Have you tried to simplify it?

Mon, Aug 26, 1:29 AM · Restricted Project

Thu, Aug 22

djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

@vsk

I really like this approach. Thanks for doing this!

Thanks!

Thu, Aug 22, 7:42 AM · Restricted Project, debug-info
djtodoro added a comment to D66525: [llvm-dwarfdump] Add additional stats fields.

@vsk Thanks for your comments!

Thu, Aug 22, 7:42 AM · Restricted Project, debug-info

Wed, Aug 21

djtodoro added a comment to D65585: WIP: [llvm-locstats] Add the llvm-locstats tool.

The revisions are: D66525 and D66526.

Wed, Aug 21, 5:28 AM · Restricted Project, debug-info
djtodoro added a child revision for D66525: [llvm-dwarfdump] Add additional stats fields: D66526: [utils] Add the llvm-locstats tool.
Wed, Aug 21, 5:28 AM · Restricted Project, debug-info
djtodoro added a parent revision for D66526: [utils] Add the llvm-locstats tool: D66525: [llvm-dwarfdump] Add additional stats fields.
Wed, Aug 21, 5:28 AM · Restricted Project, debug-info
djtodoro created D66526: [utils] Add the llvm-locstats tool.
Wed, Aug 21, 5:28 AM · Restricted Project, debug-info
djtodoro created D66525: [llvm-dwarfdump] Add additional stats fields.
Wed, Aug 21, 5:06 AM · Restricted Project, debug-info
djtodoro abandoned D65585: WIP: [llvm-locstats] Add the llvm-locstats tool.

I am abandoning this and creating new revisions for the tool implemented as an utility (within utils/).

Wed, Aug 21, 4:55 AM · Restricted Project, debug-info
djtodoro added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Thanks for this (a few comments added).

Wed, Aug 21, 2:32 AM · Restricted Project
djtodoro added a comment to D66352: Debug Info: Support for DW_AT_export_symbols for anonymous structs.

Thanks for this (just added a few nitpicks inside).

Wed, Aug 21, 1:50 AM · Restricted Project, debug-info

Aug 13 2019

djtodoro added a comment to D66145: [DebugInfo] Allow bundled calls in the MIR's call site info.

Thanks a lot for this! It looks reasonable to me.
(I am not sure if I can approve it, so please wait for @aprantl and @vsk too)

Aug 13 2019, 11:30 PM · Restricted Project, debug-info

Aug 7 2019

djtodoro added a comment to D65585: WIP: [llvm-locstats] Add the llvm-locstats tool.

@aprantl, @vsk,
IIUC, I can abandon this patch and make a separate patch(es) for adding additional fields into the llvm-dwarfdump stats output, and then make a script (and put into the utils/) parsing the fields by doing the locstats job?

Aug 7 2019, 2:30 AM · Restricted Project, debug-info
djtodoro added a comment to D65585: WIP: [llvm-locstats] Add the llvm-locstats tool.

@MaskRay Thanks for your review! We are still discussing on the llvm-dev mailing list how we should continue with this. As soon as we finished, I will start cleaning up the code and addressing comments.

Aug 7 2019, 2:16 AM · Restricted Project, debug-info

Aug 1 2019

djtodoro added a comment to D65585: WIP: [llvm-locstats] Add the llvm-locstats tool.

@aprantl Thanks for your comment. WDYT about implementing this as a llvm-dwarfdump subtool?

Aug 1 2019, 10:39 AM · Restricted Project, debug-info
djtodoro added a reviewer for D65585: WIP: [llvm-locstats] Add the llvm-locstats tool: dblaikie.
Aug 1 2019, 10:26 AM · Restricted Project, debug-info
djtodoro created D65585: WIP: [llvm-locstats] Add the llvm-locstats tool.
Aug 1 2019, 9:07 AM · Restricted Project, debug-info

Jul 31 2019

djtodoro committed rGb9973f87c6e2: Reland "[DwarfDebug] Dump call site debug info" (authored by djtodoro).
Reland "[DwarfDebug] Dump call site debug info"
Jul 31 2019, 9:54 AM
djtodoro committed rL367446: Reland "[DwarfDebug] Dump call site debug info".
Reland "[DwarfDebug] Dump call site debug info"
Jul 31 2019, 9:54 AM
djtodoro closed D60716: [DwarfDebug] Dump call site debug info into DWARF.
Jul 31 2019, 9:54 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@vsk Thanks a lot!

Jul 31 2019, 8:27 AM · Restricted Project, debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Addressing comments

Jul 31 2019, 4:28 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@vsk Thanks for the comments!

Jul 31 2019, 4:26 AM · Restricted Project, debug-info

Jul 29 2019

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Addressing comments

Jul 29 2019, 7:36 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@vsk Thanks a lot for such nice review!

Jul 29 2019, 7:36 AM · Restricted Project, debug-info

Jul 25 2019

djtodoro added a comment to D65178: WIP: [DWARF] Collect statistics for DW_OP_entry_value.

@vsk Thanks! As soon as we re-land the callsiteparam work I will start cleaning up the code and up streaming it!

Jul 25 2019, 11:37 PM · Restricted Project
djtodoro added a comment to D65178: WIP: [DWARF] Collect statistics for DW_OP_entry_value.

@vsk IIUC, you think the tool will be useful ? :)

I’ll set this patch aside for now.

I think the goal of this patch is desirable for sure. In addition, I am not opposed to coexisting of this kind of stats within both of the llvm-dwarfdump and llvm-locstats, but that can be a point of discussion.

Jul 25 2019, 1:54 AM · Restricted Project

Jul 24 2019

djtodoro added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Thanks for working on this, it seems very useful! Any updates?

Jul 24 2019, 4:19 AM · Restricted Project

Jul 23 2019

djtodoro added a comment to D65178: WIP: [DWARF] Collect statistics for DW_OP_entry_value.

@vsk Thanks for this! We have discussed about this on the other threads and the stats is useful for sure!
Having this stats gives us info about the "normal" (non-entry values) debug location coverage, because those locations with the entry value are useless if do not have proper call_site and call_site_paramters debug information generated in the .debug_info section.

Jul 23 2019, 11:38 PM · Restricted Project

Jul 12 2019

djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@uweigand Thanks for the note and comment!

Jul 12 2019, 6:37 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@dstenb Thanks a lot, that seems useful!

Jul 12 2019, 5:04 AM · Restricted Project, debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Make a wrapper around the getCallPreservedMask() and use it in order to avoid changes in generated code

Jul 12 2019, 4:35 AM · Restricted Project, debug-info
djtodoro reopened D60716: [DwarfDebug] Dump call site debug info into DWARF.

@uweigand Thanks for that! The commit is reverted with the rL365886.

Jul 12 2019, 4:31 AM · Restricted Project, debug-info
djtodoro committed rG0739ccd3b588: Revert "[DwarfDebug] Dump call site debug info" (authored by djtodoro).
Revert "[DwarfDebug] Dump call site debug info"
Jul 12 2019, 2:46 AM
djtodoro committed rL365886: Revert "[DwarfDebug] Dump call site debug info".
Revert "[DwarfDebug] Dump call site debug info"
Jul 12 2019, 2:45 AM

Jul 11 2019

djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@dstenb Thanks a lot!

Jul 11 2019, 6:43 AM · Restricted Project, debug-info
djtodoro accepted D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC.

LGTM! Thanks @vsk!

Jul 11 2019, 3:27 AM · Restricted Project
djtodoro updated subscribers of D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC.
Jul 11 2019, 3:24 AM · Restricted Project

Jul 9 2019

djtodoro committed rGc1e0ea976530: [NFC][AsmPrinter] Fix the formatting for the rL365467 (authored by djtodoro).
[NFC][AsmPrinter] Fix the formatting for the rL365467
Jul 9 2019, 5:07 AM
djtodoro committed rL365469: [NFC][AsmPrinter] Fix the formatting for the rL365467.
[NFC][AsmPrinter] Fix the formatting for the rL365467
Jul 9 2019, 5:06 AM
djtodoro committed rG01eaae6dd128: [DwarfDebug] Dump call site debug info (authored by djtodoro).
[DwarfDebug] Dump call site debug info
Jul 9 2019, 4:34 AM
djtodoro committed rL365467: [DwarfDebug] Dump call site debug info.
[DwarfDebug] Dump call site debug info
Jul 9 2019, 4:34 AM
djtodoro closed D60716: [DwarfDebug] Dump call site debug info into DWARF.
Jul 9 2019, 4:34 AM · Restricted Project, debug-info
djtodoro committed rG12aca5de026b: Reland "[LiveDebugValues] Emit the debug entry values" (authored by djtodoro).
Reland "[LiveDebugValues] Emit the debug entry values"
Jul 9 2019, 1:38 AM
djtodoro committed rL365444: Reland "[LiveDebugValues] Emit the debug entry values".
Reland "[LiveDebugValues] Emit the debug entry values"
Jul 9 2019, 1:37 AM