- Adjust documentation
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Today
Sun, Feb 17
- Change a comment for isDescribedByReg()
- Remove a dead code
- Use isEntryValue() from DIExpression
@aprantl I just updated the diff with documentation. Please let me know what do you think.
- Add documentation for the flag
Thu, Feb 14
LGTM. One last request: Could you please add (either to >the doxygen comment of isArgNotModified or to >LangRef.rst or SourceLevelDebugging.rst) an >explanation of the semantics of the flag. Ie.: What it is >used for and under what conditions a frontend should >generate it?
Wed, Feb 13
- Use MBB.instrs()
@dstenb Thanks for comments!
- Rename: VariableNotChanged ===> ArgumentNotModified
- Refactor test cases
If we wanted to support the DWARF 5 variants are there any semantic differences, or do we just need to rename the attributes?
@aprantl Yes, it will take only DWARF symbols (tag, attributes, operand) renaming.
- Rename: VariableNotChanged ===> ArgumentNotModified
- Refactor test cases
- Rename: VariableNotChanged ===> ArgumentNotModified
- Refactor a test case
- Rename: VariableNotChanged ===> ArgumentNotModified
- Refactor test cases
- Rename: VariableNotChanged ===> ArgumentNotModified
- Refactor a test case
- Rename: VariableNotChanged ===> ArgumentNotModified
- Add test case in test/Assembler/debug-info.ll
@aprantl I agree. Thanks for the comment!
Tue, Feb 12
@wolfgangp Thanks a lot for your comments! It has been addressed.
@aprantl Thanks for your comments!
Mon, Feb 11
Dec 10 2018
LGTM as well! Thanks!
Sep 14 2018
Sep 13 2018
@vsk Thanks for the review!
Sep 12 2018
Please see the following lldb session:
Feb 13 2018
Feb 10 2018
Feb 6 2018
Feb 5 2018
Feb 2 2018
Feb 1 2018
@aprantl All test cases pass. That is why RAUW has redundant check (getLocalFunctionMetadata for From and To). Maybe in some cases LLVM PASS just did not get the place where actually it updates the pointer to the DISubprogram (or it was pointer to the function before D42541) and if it is null at that particular point that does not mean that it clobbers dbg info (because it would be != than other metadata at the time).