Page MenuHomePhabricator
Feed Advanced Search

Today

hokein added a comment to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

the code looks clearer now!

Tue, Jul 16, 7:54 AM · Restricted Project
hokein accepted D64754: [clangd] Added highlighting for the targets in typedefs..
Tue, Jul 16, 4:45 AM · Restricted Project, Restricted Project
hokein added inline comments to D64741: [clangd] Added highlighting for tokens that are macro arguments..
Tue, Jul 16, 2:31 AM · Restricted Project
hokein added inline comments to D64754: [clangd] Added highlighting for the targets in typedefs..
Tue, Jul 16, 2:20 AM · Restricted Project, Restricted Project
hokein added a comment to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

based on the offline discussion, now I understand the patch better (thanks).

Tue, Jul 16, 1:55 AM · Restricted Project

Fri, Jul 12

hokein added inline comments to D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.
Fri, Jul 12, 2:15 PM · Restricted Project, Restricted Project
hokein accepted D64617: [clangd] Added highlighting for members and methods.
Fri, Jul 12, 2:03 PM · Restricted Project, Restricted Project
hokein accepted D64624: [clangd] Added highlighting to enum constants..
Fri, Jul 12, 1:58 PM · Restricted Project, Restricted Project
hokein created D64627: [clangd] Suppress unwritten scopes when expanding auto..
Fri, Jul 12, 3:38 AM · Restricted Project
hokein added a comment to D64624: [clangd] Added highlighting to enum constants..

mostly good.

Fri, Jul 12, 3:07 AM · Restricted Project, Restricted Project
hokein added inline comments to D64617: [clangd] Added highlighting for members and methods.
Fri, Jul 12, 2:51 AM · Restricted Project, Restricted Project
hokein committed rG210a9b6aee62: [clangd] Move the expandAuto tweak from global namespace into annoymous… (authored by hokein).
[clangd] Move the expandAuto tweak from global namespace into annoymous…
Fri, Jul 12, 2:42 AM
hokein committed rL365885: [clangd] Move the expandAuto tweak from global namespace into annoymous….
[clangd] Move the expandAuto tweak from global namespace into annoymous…
Fri, Jul 12, 2:42 AM
hokein committed rG7eeb82b58554: [clangd] Don't run the prepare for tweaks that are disabled. (authored by hokein).
[clangd] Don't run the prepare for tweaks that are disabled.
Fri, Jul 12, 1:51 AM
hokein committed rL365882: [clangd] Don't run the prepare for tweaks that are disabled..
[clangd] Don't run the prepare for tweaks that are disabled.
Fri, Jul 12, 1:50 AM
hokein closed D64565: [clangd] Don't run the prepare for tweaks that are disabled..
Fri, Jul 12, 1:50 AM · Restricted Project, Restricted Project
hokein updated the diff for D64565: [clangd] Don't run the prepare for tweaks that are disabled..

Address comments.

Fri, Jul 12, 1:49 AM · Restricted Project, Restricted Project

Thu, Jul 11

hokein added inline comments to D64565: [clangd] Don't run the prepare for tweaks that are disabled..
Thu, Jul 11, 8:10 AM · Restricted Project, Restricted Project
hokein updated the diff for D64565: [clangd] Don't run the prepare for tweaks that are disabled..

Address comments.

Thu, Jul 11, 8:10 AM · Restricted Project, Restricted Project
hokein updated the diff for D64565: [clangd] Don't run the prepare for tweaks that are disabled..

Simplify the code further based on offline discussion.

Thu, Jul 11, 7:36 AM · Restricted Project, Restricted Project
hokein committed rGf3661a78bf32: [clangd] Remove an extra ";", NFC (authored by hokein).
[clangd] Remove an extra ";", NFC
Thu, Jul 11, 7:00 AM
hokein committed rL365778: [clangd] Remove an extra ";", NFC.
[clangd] Remove an extra ";", NFC
Thu, Jul 11, 7:00 AM
hokein created D64565: [clangd] Don't run the prepare for tweaks that are disabled..
Thu, Jul 11, 6:49 AM · Restricted Project, Restricted Project
hokein updated subscribers of rL365675: Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the….

@hintonda, this patch caused a crash in SupportTests (CommandLineTest.AliasesWithArguments), I have reverted in rL365742. Feel free to re-commit it after you fix the issue.

Thu, Jul 11, 5:36 AM
hokein committed rGe3971724387d: [clangd] Remove the extra ";", NFC (authored by hokein).
[clangd] Remove the extra ";", NFC
Thu, Jul 11, 5:33 AM
hokein committed rL365764: [clangd] Remove the extra ";", NFC.
[clangd] Remove the extra ";", NFC
Thu, Jul 11, 5:33 AM
hokein committed rG1503a3b2e714: [clangd] Fix an assertion crash in "ExtractVariable" tweak (authored by hokein).
[clangd] Fix an assertion crash in "ExtractVariable" tweak
Thu, Jul 11, 5:30 AM
hokein committed rL365763: [clangd] Fix an assertion crash in "ExtractVariable" tweak.
[clangd] Fix an assertion crash in "ExtractVariable" tweak
Thu, Jul 11, 5:30 AM
hokein closed D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak.
Thu, Jul 11, 5:30 AM · Restricted Project, Restricted Project
hokein updated the diff for D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak.

Address comment.

Thu, Jul 11, 4:37 AM · Restricted Project, Restricted Project
hokein added inline comments to D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak.
Thu, Jul 11, 4:16 AM · Restricted Project, Restricted Project
hokein created D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak.
Thu, Jul 11, 4:14 AM · Restricted Project, Restricted Project
hokein committed rG63f523597856: [clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor. (authored by hokein).
[clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor.
Thu, Jul 11, 3:08 AM
hokein committed rL365751: [clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor..
[clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor.
Thu, Jul 11, 3:06 AM
hokein committed rGe6695821e592: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from… (authored by hokein).
Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from…
Thu, Jul 11, 1:55 AM
hokein committed rL365742: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from….
Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from…
Thu, Jul 11, 1:54 AM
hokein accepted D64492: [clangd] Added highlightings for namespace specifiers..

looks good from my side, just a comment for the TM scope name.

Thu, Jul 11, 1:39 AM · Restricted Project, Restricted Project
hokein added a comment to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

Thanks for bringing this up and implementing it.

Thu, Jul 11, 1:27 AM · Restricted Project

Wed, Jul 10

hokein added inline comments to D64492: [clangd] Added highlightings for namespace specifiers..
Wed, Jul 10, 8:04 AM · Restricted Project, Restricted Project
hokein committed rG6b043f051836: [clangd] Add a flag to clangdServer rename function to control whether we want… (authored by hokein).
[clangd] Add a flag to clangdServer rename function to control whether we want…
Wed, Jul 10, 6:45 AM
hokein committed rL365631: [clangd] Add a flag to clangdServer rename function to control whether we want….
[clangd] Add a flag to clangdServer rename function to control whether we want…
Wed, Jul 10, 6:44 AM
hokein closed D64481: [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements..
Wed, Jul 10, 6:44 AM · Restricted Project, Restricted Project
hokein updated the diff for D64481: [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements..

Address review comment.

Wed, Jul 10, 6:40 AM · Restricted Project, Restricted Project
hokein created D64481: [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements..
Wed, Jul 10, 6:03 AM · Restricted Project, Restricted Project
hokein added a comment to D64257: [clangd] Added highlighting for class and enum types.

are you testing these patches against a client-side implementation of semantic highlighting? If so, which one?

Wed, Jul 10, 1:28 AM · Restricted Project, Restricted Project
hokein accepted D64257: [clangd] Added highlighting for class and enum types.

thanks, looks good.

Wed, Jul 10, 1:20 AM · Restricted Project, Restricted Project

Tue, Jul 9

hokein added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Tue, Jul 9, 7:37 AM · Restricted Project, Restricted Project
hokein added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Tue, Jul 9, 3:49 AM · Restricted Project, Restricted Project
hokein committed rG564daa01fcf2: [llvm-profdata] Don't make the output overwrite the input file. (authored by hokein).
[llvm-profdata] Don't make the output overwrite the input file.
Tue, Jul 9, 3:00 AM
hokein committed rL365450: [llvm-profdata] Don't make the output overwrite the input file..
[llvm-profdata] Don't make the output overwrite the input file.
Tue, Jul 9, 3:00 AM
hokein added a comment to D64257: [clangd] Added highlighting for class and enum types.

could you please also update the patch description? "non-builtin" types are not precise, this patch only highlights the class and enum types.

Tue, Jul 9, 1:59 AM · Restricted Project, Restricted Project

Mon, Jul 8

hokein added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Mon, Jul 8, 8:09 AM · Restricted Project, Restricted Project
hokein added a comment to D64312: [clangd] Simpler/more compact in-memory representation of RefSlab/Builder.

just some nits to make the code more understandable.

Mon, Jul 8, 4:37 AM · Restricted Project
hokein added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Mon, Jul 8, 1:22 AM · Restricted Project, Restricted Project

Fri, Jul 5

hokein committed rGee08036df8db: [clangd] Deduplicate clang-tidy diagnostic messages. (authored by hokein).
[clangd] Deduplicate clang-tidy diagnostic messages.
Fri, Jul 5, 5:59 AM
hokein committed rL365204: [clangd] Deduplicate clang-tidy diagnostic messages..
[clangd] Deduplicate clang-tidy diagnostic messages.
Fri, Jul 5, 5:59 AM
hokein closed D64127: [clangd] Deduplicate clang-tidy diagnostic messages..
Fri, Jul 5, 5:59 AM · Restricted Project, Restricted Project
hokein added inline comments to D64127: [clangd] Deduplicate clang-tidy diagnostic messages..
Fri, Jul 5, 5:59 AM · Restricted Project, Restricted Project
hokein added inline comments to D64127: [clangd] Deduplicate clang-tidy diagnostic messages..
Fri, Jul 5, 5:26 AM · Restricted Project, Restricted Project
hokein updated the diff for D64127: [clangd] Deduplicate clang-tidy diagnostic messages..

Address comment.

Fri, Jul 5, 5:26 AM · Restricted Project, Restricted Project
hokein accepted D64199: [clangd] Added highlighting for variable references (declrefs).

thanks, looks good.

Fri, Jul 5, 5:08 AM · Restricted Project, Restricted Project
hokein added a comment to D64199: [clangd] Added highlighting for variable references (declrefs).

the implementation looks good, a few comments on the test.

Fri, Jul 5, 1:37 AM · Restricted Project, Restricted Project
hokein added a reviewer for D64127: [clangd] Deduplicate clang-tidy diagnostic messages.: kadircet.
Fri, Jul 5, 1:37 AM · Restricted Project, Restricted Project

Thu, Jul 4

hokein committed rG1ca2ee4dc114: [clangd] Some tweaks on semantic highlighting lookuptable. (authored by hokein).
[clangd] Some tweaks on semantic highlighting lookuptable.
Thu, Jul 4, 5:30 AM
hokein committed rL365135: [clangd] Some tweaks on semantic highlighting lookuptable..
[clangd] Some tweaks on semantic highlighting lookuptable.
Thu, Jul 4, 5:30 AM
hokein closed D64202: [clangd] Some tweaks on semantic highlighting lookuptable..
Thu, Jul 4, 5:30 AM · Restricted Project, Restricted Project
hokein updated the diff for D64202: [clangd] Some tweaks on semantic highlighting lookuptable..

Address comments.

Thu, Jul 4, 5:26 AM · Restricted Project, Restricted Project
hokein added inline comments to D64199: [clangd] Added highlighting for variable references (declrefs).
Thu, Jul 4, 5:06 AM · Restricted Project, Restricted Project
hokein created D64202: [clangd] Some tweaks on semantic highlighting lookuptable..
Thu, Jul 4, 4:36 AM · Restricted Project, Restricted Project
hokein committed rGb7ec41556b9c: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file. (authored by hokein).
[clangd] Add a hidden tweak to annotate all highlighting tokens of the file.
Thu, Jul 4, 3:50 AM
hokein committed rL365130: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file..
[clangd] Add a hidden tweak to annotate all highlighting tokens of the file.
Thu, Jul 4, 3:50 AM
hokein closed D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file..
Thu, Jul 4, 3:50 AM · Restricted Project, Restricted Project
hokein updated the diff for D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file..

Address comments

Thu, Jul 4, 3:43 AM · Restricted Project, Restricted Project
hokein updated the diff for D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file..

address comments:

  • emit textmate scope names
  • rescope to the selected node rather than TU decl.
Thu, Jul 4, 2:32 AM · Restricted Project, Restricted Project
hokein accepted D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

thanks, looks good.

Thu, Jul 4, 12:37 AM · Restricted Project, Restricted Project

Wed, Jul 3

hokein created D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file..
Wed, Jul 3, 8:09 AM · Restricted Project, Restricted Project
hokein added a comment to D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

mostly good, a few more nits.

Wed, Jul 3, 6:46 AM · Restricted Project, Restricted Project
hokein added a comment to D64127: [clangd] Deduplicate clang-tidy diagnostic messages..

Could you also revert changes in LSPDiagnosticCompare in Protocol.h, that were introduced by rL363889? (or bring back fixits-duplication.test)

Wed, Jul 3, 4:59 AM · Restricted Project, Restricted Project
hokein updated the diff for D64127: [clangd] Deduplicate clang-tidy diagnostic messages..

Revert the LSPDiagnosticCompare change in rL363889.

Wed, Jul 3, 4:59 AM · Restricted Project, Restricted Project
hokein added inline comments to D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.
Wed, Jul 3, 3:46 AM · Restricted Project, Restricted Project
hokein created D64127: [clangd] Deduplicate clang-tidy diagnostic messages..
Wed, Jul 3, 2:57 AM · Restricted Project, Restricted Project
hokein accepted D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory.
Wed, Jul 3, 12:33 AM · Restricted Project, Restricted Project

Tue, Jul 2

hokein added inline comments to D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.
Tue, Jul 2, 3:15 AM · Restricted Project, Restricted Project
hokein accepted D64063: [clang][ArgumentAdjusters] Do not add fsyntax-only if already exists.
Tue, Jul 2, 2:59 AM · Restricted Project, Restricted Project
hokein added a comment to D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory.

looks mostly good, a few nits.

Tue, Jul 2, 2:28 AM · Restricted Project, Restricted Project
hokein committed rG7c251fa069a6: [clangd] Collect the refs when the main file is header. (authored by hokein).
[clangd] Collect the refs when the main file is header.
Tue, Jul 2, 2:18 AM
hokein committed rL364893: [clangd] Collect the refs when the main file is header..
[clangd] Collect the refs when the main file is header.
Tue, Jul 2, 2:18 AM
hokein closed D63818: [clangd] Collect the refs when the main file is header..
Tue, Jul 2, 2:18 AM · Restricted Project, Restricted Project
hokein added inline comments to D64019: [clangd] Turn background-index on by default.
Tue, Jul 2, 1:57 AM · Restricted Project, Restricted Project

Mon, Jul 1

hokein added a comment to D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory.

Discussed it offline, technically taking the main file directory into account when shorten the #include path would not break the compiler, but it may introduce issues violating the code style -- in clangd codebase, we prefer to use "#include "<subdir_under_clangd>/header.h" style, e.g. index/background.cc uses #include "index/Background.h", with this patch we will shorten the include as #include "background.h", so we don't count the the index/background.h as included (a new #include "background.h" will be inserted).

Mon, Jul 1, 7:41 AM · Restricted Project, Restricted Project
hokein committed rG9d34f4569b48: [clangd] Show better message when we rename macros. (authored by hokein).
[clangd] Show better message when we rename macros.
Mon, Jul 1, 2:27 AM
hokein committed rL364735: [clangd] Show better message when we rename macros..
[clangd] Show better message when we rename macros.
Mon, Jul 1, 2:26 AM
hokein closed D63922: [clangd] Show better message when we rename macros..
Mon, Jul 1, 2:26 AM · Restricted Project, Restricted Project
hokein added a reviewer for D63818: [clangd] Collect the refs when the main file is header.: sammccall.
Mon, Jul 1, 2:25 AM · Restricted Project, Restricted Project
hokein added inline comments to D63922: [clangd] Show better message when we rename macros..
Mon, Jul 1, 2:04 AM · Restricted Project, Restricted Project
hokein updated the diff for D63922: [clangd] Show better message when we rename macros..

Address review comments:

  • renaming
  • add unittest
Mon, Jul 1, 2:00 AM · Restricted Project, Restricted Project
hokein committed rGb739b91cd3a4: [clangd] Make FixIt message be consistent with the clang-tidy diagnostic… (authored by hokein).
[clangd] Make FixIt message be consistent with the clang-tidy diagnostic…
Mon, Jul 1, 1:09 AM
hokein committed rL364731: [clangd] Make FixIt message be consistent with the clang-tidy diagnostic….
[clangd] Make FixIt message be consistent with the clang-tidy diagnostic…
Mon, Jul 1, 1:05 AM
hokein closed D63926: [clangd] Make FixIt message be consistent with the clang-tidy diagnostic message..
Mon, Jul 1, 1:05 AM · Restricted Project, Restricted Project
hokein accepted D63817: [clangd] No longer getting template instantiations from header files in Main AST..

Looks good, please update the patch description (in git, and phabricator), mentioning why the previous solution won't work.

Mon, Jul 1, 1:03 AM · Restricted Project, Restricted Project