Page MenuHomePhabricator
Feed Advanced Search

Today

hokein added inline comments to D68977: [clangd] Report declaration references in findExplicitReferences..
Thu, Oct 17, 7:30 AM · Restricted Project
hokein updated the diff for D68977: [clangd] Report declaration references in findExplicitReferences..

address remaining nits.

Thu, Oct 17, 7:30 AM · Restricted Project
hokein committed rGc8e3f43ab514: [clangd] Use our own relation kind. (authored by hokein).
[clangd] Use our own relation kind.
Thu, Oct 17, 7:12 AM
hokein committed rL375117: [clangd] Use our own relation kind..
[clangd] Use our own relation kind.
Thu, Oct 17, 7:12 AM
hokein closed D68981: [clangd] Use our own relation kind..
Thu, Oct 17, 7:12 AM · Restricted Project, Restricted Project
hokein added inline comments to D68977: [clangd] Report declaration references in findExplicitReferences..
Thu, Oct 17, 6:43 AM · Restricted Project
hokein updated the diff for D68977: [clangd] Report declaration references in findExplicitReferences..

address comments.

Thu, Oct 17, 6:43 AM · Restricted Project
hokein added inline comments to D68977: [clangd] Report declaration references in findExplicitReferences..
Thu, Oct 17, 4:29 AM · Restricted Project
hokein updated the diff for D68977: [clangd] Report declaration references in findExplicitReferences..

address comments:

  • remove the confusing IsDeclRef
  • use getQualifier from AST.h
Thu, Oct 17, 4:29 AM · Restricted Project
hokein updated the summary of D69094: [WIP] Add override relationship..
Thu, Oct 17, 2:44 AM · Restricted Project
hokein created D69094: [WIP] Add override relationship..
Thu, Oct 17, 2:44 AM · Restricted Project

Tue, Oct 15

hokein updated the diff for D68981: [clangd] Use our own relation kind..

more static_cast

Tue, Oct 15, 7:59 AM · Restricted Project, Restricted Project
hokein updated the diff for D68981: [clangd] Use our own relation kind..

fix a missing static_cast.

Tue, Oct 15, 7:50 AM · Restricted Project, Restricted Project
hokein updated the diff for D68981: [clangd] Use our own relation kind..

address comments.

Tue, Oct 15, 7:49 AM · Restricted Project, Restricted Project
hokein updated the diff for D68981: [clangd] Use our own relation kind..

address comments.

Tue, Oct 15, 7:30 AM · Restricted Project, Restricted Project
hokein added inline comments to D68981: [clangd] Use our own relation kind..
Tue, Oct 15, 7:30 AM · Restricted Project, Restricted Project
hokein updated the diff for D68981: [clangd] Use our own relation kind..

update a style comment.

Tue, Oct 15, 6:10 AM · Restricted Project, Restricted Project
hokein created D68981: [clangd] Use our own relation kind..
Tue, Oct 15, 4:10 AM · Restricted Project, Restricted Project
hokein created D68977: [clangd] Report declaration references in findExplicitReferences..
Tue, Oct 15, 3:00 AM · Restricted Project

Mon, Oct 14

hokein accepted D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154).

thanks, looks great now!

Mon, Oct 14, 1:32 AM · Restricted Project
hokein committed rL374757: Add github commit access for hokein.
Add github commit access for hokein
Mon, Oct 14, 1:14 AM

Wed, Oct 9

hokein added inline comments to D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154).
Wed, Oct 9, 6:08 AM · Restricted Project

Mon, Oct 7

hokein committed rG77c97002dc1a: [clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch. (authored by hokein).
[clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch.
Mon, Oct 7, 10:11 PM
hokein committed rL373897: [clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch..
[clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch.
Mon, Oct 7, 10:11 PM
hokein closed D68564: [clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch..
Mon, Oct 7, 10:11 PM · Restricted Project, Restricted Project
hokein committed rG2fa81d201f4b: [clangd] Collect missing macro references. (authored by hokein).
[clangd] Collect missing macro references.
Mon, Oct 7, 10:08 PM
hokein committed rL373889: [clangd] Collect missing macro references..
[clangd] Collect missing macro references.
Mon, Oct 7, 10:08 PM
hokein closed D68458: [clangd] Collect missing macro references..
Mon, Oct 7, 10:08 PM · Restricted Project, Restricted Project
hokein added a comment to D67536: [WIP] [clangd] Add support for an inactive regions notification.

How would one even measure the line length? SourceManager doesn't sem to have a method like getLineLength() or similar.

Mon, Oct 7, 8:07 AM · Restricted Project
hokein created D68564: [clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch..
Mon, Oct 7, 2:55 AM · Restricted Project, Restricted Project

Fri, Oct 4

hokein committed rG5d862c042b52: [clang-rename] Fix a crash when renaming a class without definition. (authored by hokein).
[clang-rename] Fix a crash when renaming a class without definition.
Fri, Oct 4, 7:09 AM
hokein committed rL373748: [clang-rename] Fix a crash when renaming a class without definition..
[clang-rename] Fix a crash when renaming a class without definition.
Fri, Oct 4, 7:09 AM
hokein closed D68459: [clang-rename] Fix a crash when renaming a class without definition..
Fri, Oct 4, 7:09 AM · Restricted Project, Restricted Project
hokein committed rGbc4e43e9c1f0: [clangd] update the package-lock.json. (authored by hokein).
[clangd] update the package-lock.json.
Fri, Oct 4, 5:36 AM
hokein committed rL373739: [clangd] update the package-lock.json..
[clangd] update the package-lock.json.
Fri, Oct 4, 5:34 AM
hokein created D68459: [clang-rename] Fix a crash when renaming a class without definition..
Fri, Oct 4, 5:27 AM · Restricted Project, Restricted Project
hokein created D68458: [clangd] Collect missing macro references..
Fri, Oct 4, 5:14 AM · Restricted Project, Restricted Project

Wed, Oct 2

hokein added inline comments to D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154).
Wed, Oct 2, 6:34 AM · Restricted Project
hokein abandoned D67651: [clangd] No ExtractFunction on empty selections..
Wed, Oct 2, 6:24 AM · Restricted Project
hokein committed rGd44fc23abdb6: [clangd] Bail out early if we are sure that the symbol is used outside of the… (authored by hokein).
[clangd] Bail out early if we are sure that the symbol is used outside of the…
Wed, Oct 2, 3:50 AM
hokein committed rL373444: [clangd] Bail out early if we are sure that the symbol is used outside of the….
[clangd] Bail out early if we are sure that the symbol is used outside of the…
Wed, Oct 2, 3:49 AM
hokein closed D68325: [clangd] Bail out early if we are sure that the symbol is used outside of the file..
Wed, Oct 2, 3:49 AM · Restricted Project, Restricted Project
hokein added a comment to D67536: [WIP] [clangd] Add support for an inactive regions notification.

Could you add tests for this?

Wed, Oct 2, 3:40 AM · Restricted Project
hokein committed rGfbd134f96983: [clang-rename] Better renaming the typedef decl. (authored by hokein).
[clang-rename] Better renaming the typedef decl.
Wed, Oct 2, 2:50 AM
hokein committed rL373440: [clang-rename] Better renaming the typedef decl..
[clang-rename] Better renaming the typedef decl.
Wed, Oct 2, 2:50 AM
hokein closed D68322: [clang-rename] Better renaming the typedef decl..
Wed, Oct 2, 2:50 AM · Restricted Project, Restricted Project
hokein created D68325: [clangd] Bail out early if we are sure that the symbol is used outside of the file..
Wed, Oct 2, 2:38 AM · Restricted Project, Restricted Project
hokein added a reviewer for D68322: [clang-rename] Better renaming the typedef decl.: sammccall.
Wed, Oct 2, 1:30 AM · Restricted Project, Restricted Project
hokein created D68322: [clang-rename] Better renaming the typedef decl..
Wed, Oct 2, 1:12 AM · Restricted Project, Restricted Project

Tue, Oct 1

hokein added a comment to D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154).

I do feel strongly that types and non-types should be highlighted differently, so the updated patch adds two new dependent highlightings, one for types and one for variables/functions.

Tue, Oct 1, 8:04 AM · Restricted Project
hokein committed rG9f2bf666bc0e: [clangd] Implement getBeginning for overloaded operators. (authored by hokein).
[clangd] Implement getBeginning for overloaded operators.
Tue, Oct 1, 4:03 AM
hokein committed rL373323: [clangd] Implement getBeginning for overloaded operators..
[clangd] Implement getBeginning for overloaded operators.
Tue, Oct 1, 4:03 AM
hokein closed D67695: [clangd] Implement getBeginning for overloaded operators..
Tue, Oct 1, 4:03 AM · Restricted Project, Restricted Project
hokein added inline comments to D67695: [clangd] Implement getBeginning for overloaded operators..
Tue, Oct 1, 3:55 AM · Restricted Project, Restricted Project
hokein updated the diff for D67695: [clangd] Implement getBeginning for overloaded operators..

add one more testcase.

Tue, Oct 1, 3:53 AM · Restricted Project, Restricted Project
hokein accepted D68024: [clangd] Implement GetEligiblePoints.

looks good.

Tue, Oct 1, 3:42 AM · Restricted Project
hokein committed rGd6d5eddcdba7: [clangd] Use the index-based API to do the header-source switch. (authored by hokein).
[clangd] Use the index-based API to do the header-source switch.
Tue, Oct 1, 3:20 AM
hokein committed rL373320: [clangd] Use the index-based API to do the header-source switch..
[clangd] Use the index-based API to do the header-source switch.
Tue, Oct 1, 3:19 AM
hokein closed D68211: [clangd] Use the index-based API to do the header-source switch..
Tue, Oct 1, 3:19 AM · Restricted Project, Restricted Project
hokein updated the diff for D68211: [clangd] Use the index-based API to do the header-source switch..

address comments.

Tue, Oct 1, 3:13 AM · Restricted Project, Restricted Project

Mon, Sep 30

hokein updated the diff for D68211: [clangd] Use the index-based API to do the header-source switch..

address comments.

Mon, Sep 30, 7:53 AM · Restricted Project, Restricted Project
hokein added inline comments to D68024: [clangd] Implement GetEligiblePoints.
Mon, Sep 30, 7:35 AM · Restricted Project
hokein added inline comments to D67695: [clangd] Implement getBeginning for overloaded operators..
Mon, Sep 30, 7:03 AM · Restricted Project, Restricted Project
hokein updated the diff for D67695: [clangd] Implement getBeginning for overloaded operators..

address comments.

Mon, Sep 30, 7:03 AM · Restricted Project, Restricted Project
hokein created D68211: [clangd] Use the index-based API to do the header-source switch..
Mon, Sep 30, 5:42 AM · Restricted Project, Restricted Project
hokein committed rGfdbe5b4b6fdc: [clangd] Implement a smart version of HeaderSource switch. (authored by hokein).
[clangd] Implement a smart version of HeaderSource switch.
Mon, Sep 30, 3:47 AM
hokein committed rL373197: [clangd] Implement a smart version of HeaderSource switch..
[clangd] Implement a smart version of HeaderSource switch.
Mon, Sep 30, 3:47 AM
hokein closed D67907: [clangd] Implement a smart version of HeaderSource switch..
Mon, Sep 30, 3:47 AM · Restricted Project, Restricted Project
hokein added inline comments to D67907: [clangd] Implement a smart version of HeaderSource switch..
Mon, Sep 30, 1:00 AM · Restricted Project, Restricted Project
hokein updated the diff for D67907: [clangd] Implement a smart version of HeaderSource switch..

address review comments.

Mon, Sep 30, 1:00 AM · Restricted Project, Restricted Project

Fri, Sep 27

hokein added a comment to D68024: [clangd] Implement GetEligiblePoints.

The implementation looks good, just have some questions on the API.

Fri, Sep 27, 5:59 AM · Restricted Project
hokein committed rG7e317cab7321: [clangd] Remove an unrelated comment, NFC. (authored by hokein).
[clangd] Remove an unrelated comment, NFC.
Fri, Sep 27, 5:32 AM
hokein committed rL373079: [clangd] Remove an unrelated comment, NFC..
[clangd] Remove an unrelated comment, NFC.
Fri, Sep 27, 5:32 AM
hokein added inline comments to D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154).
Fri, Sep 27, 5:20 AM · Restricted Project
hokein added inline comments to D67907: [clangd] Implement a smart version of HeaderSource switch..
Fri, Sep 27, 2:47 AM · Restricted Project, Restricted Project
hokein updated the diff for D67907: [clangd] Implement a smart version of HeaderSource switch..

format the testcases.

Fri, Sep 27, 2:47 AM · Restricted Project, Restricted Project
hokein updated the diff for D67907: [clangd] Implement a smart version of HeaderSource switch..

address review comments.

Fri, Sep 27, 2:47 AM · Restricted Project, Restricted Project

Thu, Sep 26

hokein added a comment to D66647: [clangd] DefineInline action apply logic with fully qualified names.

We also need to rename parameters sometimes, right?

// Sometimes we need to rename parameters.
void usages(int decl_param, int);

void usages(int def_param, int now_named) {
  llvm::errs() << def_param + now_named;
}

// And template parameters! (these are even more interesting)
template <class T>
struct Foo {
  template <class U, class>
  void usages();
};
template <class L>
template <class R, class NowNamed>
void Foo<L>::usages() {
  llvm::errs() << L() + R() + NowNamed();
}
Thu, Sep 26, 7:28 AM · Restricted Project
hokein committed rG1822087facdf: [clangd] Bump vscode-clangd v0.0.18 (authored by hokein).
[clangd] Bump vscode-clangd v0.0.18
Thu, Sep 26, 7:11 AM
hokein committed rG2745e5ea4af3: [clangd][vscode] Add npm helper commands to package/release the extension. (authored by hokein).
[clangd][vscode] Add npm helper commands to package/release the extension.
Thu, Sep 26, 7:11 AM
hokein committed rL372981: [clangd] Bump vscode-clangd v0.0.18.
[clangd] Bump vscode-clangd v0.0.18
Thu, Sep 26, 7:11 AM
hokein committed rL372980: [clangd][vscode] Add npm helper commands to package/release the extension..
[clangd][vscode] Add npm helper commands to package/release the extension.
Thu, Sep 26, 7:03 AM
hokein closed D68080: [clangd][vscode] Add npm helper commands to package/release the extension..
Thu, Sep 26, 7:02 AM · Restricted Project, Restricted Project
hokein added inline comments to D68080: [clangd][vscode] Add npm helper commands to package/release the extension..
Thu, Sep 26, 7:01 AM · Restricted Project, Restricted Project
hokein added inline comments to D68080: [clangd][vscode] Add npm helper commands to package/release the extension..
Thu, Sep 26, 6:42 AM · Restricted Project, Restricted Project
hokein added inline comments to D67695: [clangd] Implement getBeginning for overloaded operators..
Thu, Sep 26, 6:38 AM · Restricted Project, Restricted Project
hokein updated the diff for D67695: [clangd] Implement getBeginning for overloaded operators..

Upload correct diff.

Thu, Sep 26, 6:38 AM · Restricted Project, Restricted Project
hokein updated the diff for D67695: [clangd] Implement getBeginning for overloaded operators..

Simplify the logic.

Thu, Sep 26, 6:38 AM · Restricted Project, Restricted Project
hokein created D68080: [clangd][vscode] Add npm helper commands to package/release the extension..
Thu, Sep 26, 4:51 AM · Restricted Project, Restricted Project
hokein committed rGe69f12d6cfbb: [clangd][vscode] Update vscode lsp dependencies to pickup the new changes in… (authored by hokein).
[clangd][vscode] Update vscode lsp dependencies to pickup the new changes in…
Thu, Sep 26, 4:36 AM
hokein committed rG0f61f9fca851: [clangd][vscode] Turn on the semantic highlighting by default. (authored by hokein).
[clangd][vscode] Turn on the semantic highlighting by default.
Thu, Sep 26, 4:34 AM
hokein committed rL372970: [clangd][vscode] Update vscode lsp dependencies to pickup the new changes in….
[clangd][vscode] Update vscode lsp dependencies to pickup the new changes in…
Thu, Sep 26, 4:34 AM
hokein closed D67964: [clangd] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0..
Thu, Sep 26, 4:34 AM · Restricted Project, Restricted Project
hokein committed rL372969: [clangd][vscode] Turn on the semantic highlighting by default..
[clangd][vscode] Turn on the semantic highlighting by default.
Thu, Sep 26, 4:34 AM
hokein closed D68077: [clangd][vscode] Turn on the semantic highlighting by default..
Thu, Sep 26, 4:34 AM · Restricted Project, Restricted Project
hokein committed rG0d808e506457: [clang-tidy] Make llvm-header-guard work on llvm git monorepo (authored by hokein).
[clang-tidy] Make llvm-header-guard work on llvm git monorepo
Thu, Sep 26, 2:59 AM
hokein created D68077: [clangd][vscode] Turn on the semantic highlighting by default..
Thu, Sep 26, 2:59 AM · Restricted Project, Restricted Project
hokein committed rL372953: [clang-tidy] Make llvm-header-guard work on llvm git monorepo.
[clang-tidy] Make llvm-header-guard work on llvm git monorepo
Thu, Sep 26, 2:54 AM
hokein closed D68026: [clang-tidy] Make llvm-header-guard work on llvm git monorepo.
Thu, Sep 26, 2:54 AM · Restricted Project, Restricted Project
hokein added a reviewer for D67964: [clangd] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0.: ilya-biryukov.
Thu, Sep 26, 2:52 AM · Restricted Project, Restricted Project