Page MenuHomePhabricator
Feed Advanced Search

Today

hokein added inline comments to D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl..
Wed, Sep 30, 4:28 AM · Restricted Project
hokein updated the diff for D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl..

refine the patch based on the offline discussion:

Wed, Sep 30, 4:27 AM · Restricted Project

Yesterday

hokein added inline comments to D88469: [clangd] Heuristic resolution for dependent type and template names.
Tue, Sep 29, 11:59 PM · Restricted Project
hokein added a reviewer for D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.: sammccall.
Tue, Sep 29, 2:46 AM · Restricted Project
hokein added inline comments to D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl..
Tue, Sep 29, 2:46 AM · Restricted Project
hokein requested review of D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl..
Tue, Sep 29, 2:42 AM · Restricted Project
hokein added inline comments to D88469: [clangd] Heuristic resolution for dependent type and template names.
Tue, Sep 29, 2:07 AM · Restricted Project
hokein added a reviewer for D88469: [clangd] Heuristic resolution for dependent type and template names: hokein.
Tue, Sep 29, 1:49 AM · Restricted Project
hokein added inline comments to D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery..
Tue, Sep 29, 1:19 AM · Restricted Project
hokein updated the diff for D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery..

add isDependenceAllowed function.

Tue, Sep 29, 1:18 AM · Restricted Project
hokein added inline comments to D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery..
Tue, Sep 29, 12:47 AM · Restricted Project
hokein updated the diff for D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery..

address comments:

  • reuse the RecoveryAST to control the early typo-correction;
  • uses the fixed result type for some operators
Tue, Sep 29, 12:45 AM · Restricted Project

Mon, Sep 28

hokein committed rGbf890dcb0f5e: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid… (authored by hokein).
[clang] Don't emit "no member" diagnostic if the lookup fails on an invalid…
Mon, Sep 28, 6:10 AM
hokein closed D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl..
Mon, Sep 28, 6:10 AM · Restricted Project, Restricted Project
hokein added inline comments to D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl..
Mon, Sep 28, 2:56 AM · Restricted Project, Restricted Project
hokein updated the diff for D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl..

Fix a comment.

Mon, Sep 28, 2:56 AM · Restricted Project, Restricted Project
hokein added inline comments to D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr..
Mon, Sep 28, 2:00 AM · Restricted Project
hokein updated the diff for D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr..

update the patch to fix another crash ABC<N> abc where N's initailizer is contains-errors.

Mon, Sep 28, 1:56 AM · Restricted Project

Sun, Sep 27

hokein accepted D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls.

thanks.

Sun, Sep 27, 11:47 PM · Restricted Project

Fri, Sep 25

hokein added inline comments to D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls.
Fri, Sep 25, 6:42 AM · Restricted Project

Thu, Sep 24

hokein added inline comments to D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.
Thu, Sep 24, 1:03 PM · Restricted Project
hokein updated the diff for D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.

store the actual expression in DecltypeTypeLoc and address comments.

Thu, Sep 24, 1:00 PM · Restricted Project
hokein accepted D88222: [AST] Use data-recursion when building ParentMap, avoid stack overflow..

Thanks for fixing this!

Thu, Sep 24, 8:19 AM · Restricted Project

Tue, Sep 22

hokein added a comment to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

@rsmith this patch should be ready for another round of review.

Tue, Sep 22, 11:37 AM · Restricted Project
hokein updated the diff for D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

rebase

Tue, Sep 22, 11:35 AM · Restricted Project
hokein committed rG16ca71180330: [clang] Fix a typo-correction crash (authored by hokein).
[clang] Fix a typo-correction crash
Tue, Sep 22, 11:21 AM
hokein closed D87815: [clang] Fix a typo-correction crash.
Tue, Sep 22, 11:21 AM · Restricted Project
hokein added a comment to D86964: [ASTMatchers] Avoid recursion in ancestor matching to save stack space..

bump this in case you have missed this patch :) our another internal pipeline seems to need this fix.

Tue, Sep 22, 4:06 AM · Restricted Project

Mon, Sep 21

hokein committed rG41a8bbad5e52: Fix buildbot. (authored by hokein).
Fix buildbot.
Mon, Sep 21, 4:40 AM
hokein committed rGaf29591650c4: [AST] Reduce the size of TemplateArgumentLocInfo. (authored by hokein).
[AST] Reduce the size of TemplateArgumentLocInfo.
Mon, Sep 21, 4:09 AM
hokein closed D87080: [AST] Reduce the size of TemplateArgumentLocInfo..
Mon, Sep 21, 4:09 AM · Restricted Project
hokein accepted D87257: [clang] Traverse init-captures while indexing.
Mon, Sep 21, 2:04 AM · Restricted Project
hokein added inline comments to D87080: [AST] Reduce the size of TemplateArgumentLocInfo..
Mon, Sep 21, 1:35 AM · Restricted Project
hokein updated the diff for D87080: [AST] Reduce the size of TemplateArgumentLocInfo..

address review comments.

Mon, Sep 21, 1:34 AM · Restricted Project
hokein added inline comments to D87350: [AST][RecoveryExpr] Fix a crash on undeduced type..
Mon, Sep 21, 12:01 AM · Restricted Project

Sun, Sep 20

hokein committed rGf8f1e5fb39d2: [AST] Fix dependence-bits for CXXDefaultInitExpr. (authored by hokein).
[AST] Fix dependence-bits for CXXDefaultInitExpr.
Sun, Sep 20, 11:47 PM
hokein closed D87382: [AST] Fix dependence-bits for CXXDefaultInitExpr..
Sun, Sep 20, 11:47 PM · Restricted Project
hokein accepted D87979: [clangd] Link libclangdSupport into clangd-index-server.
Sun, Sep 20, 11:28 PM · Restricted Project
hokein added a comment to D87080: [AST] Reduce the size of TemplateArgumentLocInfo..

Would it be possible to compile some big file in LLVM (probably doesn't matter much which, Sema something?) and observe if there's a significant change in overall ASTContext size?

Sun, Sep 20, 1:48 PM · Restricted Project
hokein updated the diff for D87080: [AST] Reduce the size of TemplateArgumentLocInfo..

address review comments.

Sun, Sep 20, 1:47 PM · Restricted Project

Fri, Sep 18

hokein added inline comments to D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.
Fri, Sep 18, 7:22 AM · Restricted Project
hokein updated the diff for D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.

address comments:

  • don't break existing mangling tests
  • deduplicate instantiation-dependent-but-not-type-dependent DecltypeType node (for name mangling substitution)
  • fix the dependence bit of DecltypeType
Fri, Sep 18, 7:20 AM · Restricted Project

Thu, Sep 17

hokein added a reviewer for D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.: adamcz.
Thu, Sep 17, 1:08 AM · Restricted Project
hokein requested review of D87815: [clang] Fix a typo-correction crash.
Thu, Sep 17, 12:56 AM · Restricted Project

Wed, Sep 16

hokein accepted D87686: [clang-tidy] Improve documentation on Clangd integration.

thanks!

Wed, Sep 16, 3:06 AM · Restricted Project

Tue, Sep 15

hokein added a comment to D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr..

The crux is we're forcing decltype(N) to be a (unique) dependent type, which feels wrong.
[...]
There are three behaviors:

  • standard up to C++14: traversing the expr looking for a template param to be lexically included (this is my reading of the standard)

FWIW, "involves a template parameter" is exactly the same phrasing that [temp.over.link] uses to refer to instantiation-dependence; that's why Clang uses instantiation-dependence in this case at the moment.

  • what clang actually does: check instantiation dependence, which I think pulls in too many cases
  • standard after http://wg21.link/cwg2064: check type dependence

I think it's probably OK to adopt the C++17 behavior for all versions (if I'm right that the current behavior is a bug).
@rsmith It's your DR, what do you think :-)

Let's try it and see what happens. I think this will reveal a collection of cases where we don't properly handle instantiation-dependent-but-not-type-dependent constructs (such as, if I remember correctly, the types of non-type template parameters), but we should be fixing those bugs anyway :)

Tue, Sep 15, 11:20 AM · Restricted Project
hokein added inline comments to D87686: [clang-tidy] Improve documentation on Clangd integration.
Tue, Sep 15, 7:06 AM · Restricted Project
hokein added a reviewer for D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.: sammccall.
Tue, Sep 15, 1:31 AM · Restricted Project

Wed, Sep 9

hokein added inline comments to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..
Wed, Sep 9, 9:16 AM · Restricted Project
hokein updated the diff for D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

address review comments.

Wed, Sep 9, 9:13 AM · Restricted Project
hokein requested review of D87382: [AST] Fix dependence-bits for CXXDefaultInitExpr..
Wed, Sep 9, 8:00 AM · Restricted Project
hokein requested review of D87350: [AST][RecoveryExpr] Fix a crash on undeduced type..
Wed, Sep 9, 12:25 AM · Restricted Project
hokein requested review of D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.
Wed, Sep 9, 12:23 AM · Restricted Project

Tue, Sep 8

hokein added a comment to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

friendly ping @rsmith.

Tue, Sep 8, 10:50 AM · Restricted Project
hokein committed rG32ae37b038b1: [clang-tidy] Fix dynamic build failures after… (authored by hokein).
[clang-tidy] Fix dynamic build failures after…
Tue, Sep 8, 7:28 AM
hokein committed rG9c9974c3ccb6: [clang] Limit the maximum level of fold-expr expansion. (authored by hokein).
[clang] Limit the maximum level of fold-expr expansion.
Tue, Sep 8, 6:41 AM
hokein closed D86936: [clang] Limit the maximum level of fold-expr expansion..
Tue, Sep 8, 6:40 AM · Restricted Project
hokein updated the diff for D86936: [clang] Limit the maximum level of fold-expr expansion..

fix a typo.

Tue, Sep 8, 3:46 AM · Restricted Project
hokein added a comment to D87257: [clang] Traverse init-captures while indexing.

I did try to add a test to clang/test/Index/Core/index-source.cpp, however the output of c-index-test does not seem to be changed by adding this reference.

Tue, Sep 8, 1:36 AM · Restricted Project
hokein added a comment to D87256: [clangd] Avoid relations being overwritten in a header shard.

+@kadircet, he is tracking on this -- we had some discussion internally last week, but we don't reply on that thread yet (sorry).

Tue, Sep 8, 1:06 AM · Restricted Project
hokein added a reviewer for D87256: [clangd] Avoid relations being overwritten in a header shard: kadircet.
Tue, Sep 8, 1:05 AM · Restricted Project
hokein added inline comments to D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls.
Tue, Sep 8, 12:40 AM · Restricted Project

Mon, Sep 7

hokein added a reviewer for D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls: hokein.
Mon, Sep 7, 1:34 AM · Restricted Project
hokein added inline comments to D87080: [AST] Reduce the size of TemplateArgumentLocInfo..
Mon, Sep 7, 12:00 AM · Restricted Project

Sun, Sep 6

hokein updated the summary of D87080: [AST] Reduce the size of TemplateArgumentLocInfo..
Sun, Sep 6, 11:56 PM · Restricted Project
hokein updated the summary of D87080: [AST] Reduce the size of TemplateArgumentLocInfo..
Sun, Sep 6, 11:56 PM · Restricted Project
hokein updated the diff for D87080: [AST] Reduce the size of TemplateArgumentLocInfo..

format

Sun, Sep 6, 11:54 PM · Restricted Project
hokein updated the diff for D87080: [AST] Reduce the size of TemplateArgumentLocInfo..

address review comments:

  • use PointerUnion
  • keep the TemplateArgumentLocInfo trivial, allocate from allocator, no deallocation.
Sun, Sep 6, 11:53 PM · Restricted Project

Thu, Sep 3

hokein requested review of D87080: [AST] Reduce the size of TemplateArgumentLocInfo..
Thu, Sep 3, 2:58 AM · Restricted Project
hokein accepted D86964: [ASTMatchers] Avoid recursion in ancestor matching to save stack space..
Thu, Sep 3, 12:01 AM · Restricted Project

Wed, Sep 2

hokein added inline comments to D86936: [clang] Limit the maximum level of fold-expr expansion..
Wed, Sep 2, 2:12 AM · Restricted Project
hokein updated the diff for D86936: [clang] Limit the maximum level of fold-expr expansion..

address review comments.

Wed, Sep 2, 2:11 AM · Restricted Project

Tue, Sep 1

hokein accepted D86861: [clangd] Handle templates more consistently in type hierarchy.
Tue, Sep 1, 7:43 AM · Restricted Project
hokein added a comment to D86861: [clangd] Handle templates more consistently in type hierarchy.

thanks, the current behavior looks nicer than before.

Tue, Sep 1, 7:43 AM · Restricted Project
hokein accepted D86424: [clang] Do not consider the template arguments of bases to be bases themselves.
Tue, Sep 1, 7:36 AM · Restricted Project
hokein requested review of D86936: [clang] Limit the maximum level of fold-expr expansion..
Tue, Sep 1, 6:35 AM · Restricted Project

Aug 31 2020

hokein accepted D76496: [clang-tidy] add support to 3-arg find() in StringFindStartswith.
Aug 31 2020, 4:05 AM · Restricted Project, Restricted Project

Aug 28 2020

hokein closed D86688: [RecoveryExpr] Add 11.0.0 release note..

committed in https://github.com/llvm/llvm-project/commit/5d21aedfdbf0b85d65bad08b7b89913205de4b33.

Aug 28 2020, 12:59 AM · Restricted Project
hokein updated the diff for D86688: [RecoveryExpr] Add 11.0.0 release note..

address comments

Aug 28 2020, 12:53 AM · Restricted Project
hokein requested review of D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl..
Aug 28 2020, 12:47 AM · Restricted Project, Restricted Project

Aug 27 2020

hokein committed rG3f8a0ecdaa63: [libcxx] Fix the broken test after D82657. (authored by hokein).
[libcxx] Fix the broken test after D82657.
Aug 27 2020, 12:12 PM
hokein closed D86685: [libcxx] Fix the broken test after D82657..
Aug 27 2020, 12:12 PM · Restricted Project
hokein added a comment to D86685: [libcxx] Fix the broken test after D82657..

In that case, please use // expected-error@memory:* 0+ {{no member named 'value' in}} and add a proper FIXME comment with a link to this review or similar. The 0+ will make sure the test passes whether or not Clang emits the secondary diagnostic.

Aug 27 2020, 11:37 AM · Restricted Project
hokein updated the diff for D86685: [libcxx] Fix the broken test after D82657..

add FIXME.

Aug 27 2020, 11:34 AM · Restricted Project
hokein requested review of D86688: [RecoveryExpr] Add 11.0.0 release note..
Aug 27 2020, 1:37 AM · Restricted Project
hokein added a comment to D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression..

Hi @hokein,

sorry, but looks like your changes break one of libc++ tests on ARM cross toolchain build on Windows: libc++::function_type_default_deleter.fail.cpp
Here is the first failed build: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/945

I didn't get how these changes affects the failing test, but reverting of your commit fixes the problem.

Would you take a look and fix the problem? or revert the changes if it is going to take a lot of time to resolve?

Here is the command line to build the test:

C:/buildbot/temp/build/./bin/clang++.exe C:/buildbot/temp/llvm-project/libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp -v --sysroot=C:/buildbot/.arm-ubuntu --target=armv7-linux-gnueabihf -include C:/buildbot/temp/build/runtimes/runtimes-bins/libcxx\__config_site -include C:/buildbot/temp/llvm-project/libcxx\test\support\nasty_macros.h -nostdinc++ -IC:/buildbot/temp/llvm-project/libcxx\include -IC:/buildbot/temp/build/runtimes/runtimes-bins/libcxx\include\c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -IC:/buildbot/temp/llvm-project/libcxx\test/support -Werror -Wall -Wextra -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -std=c++2a -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only -Wno-error -Xclang -verify -Xclang -verify-ignore-unexpected=note -ferror-limit=0

Here is the result output:

clang -cc1 version 12.0.0 based upon LLVM 12.0.0git default target armv7-linux-gnueabihf
ignoring nonexistent directory "C:/buildbot/.arm-ubuntu/usr/local/include"
ignoring nonexistent directory "C:/buildbot/.arm-ubuntu/include"
#include "..." search starts here:
#include <...> search starts here:
 C:/buildbot/temp/llvm-project/libcxx\include
 C:/buildbot/temp/build/runtimes/runtimes-bins/libcxx\include\c++build
 C:/buildbot/temp/llvm-project/libcxx\test/support
 C:\buildbot\temp\build\lib\clang\12.0.0\include
 C:/buildbot/.arm-ubuntu/usr/include/arm-linux-gnueabihf
 C:/buildbot/.arm-ubuntu/usr/include
End of search list.
error: 'error' diagnostics seen but not expected:
  File C:/buildbot/temp/llvm-project/libcxx\include\memory Line 2033: no member named 'value' in 'std::__1::is_empty<std::__1::__compressed_pair<void
(*)(Tag<5>), std::__1::default_delete<void (Tag<5>)>>>'
1 error generated.
Aug 27 2020, 12:56 AM · Restricted Project
hokein added a comment to D86685: [libcxx] Fix the broken test after D82657..

I'm not sure this is the correct solution to fix the failing test due to the new diagnostic of the compiler.

Aug 27 2020, 12:55 AM · Restricted Project
hokein edited reviewers for D86685: [libcxx] Fix the broken test after D82657., added: ldionne, vvereschaka; removed: Restricted Project.
Aug 27 2020, 12:54 AM · Restricted Project
hokein updated the summary of D86685: [libcxx] Fix the broken test after D82657..
Aug 27 2020, 12:47 AM · Restricted Project
hokein requested review of D86685: [libcxx] Fix the broken test after D82657..
Aug 27 2020, 12:43 AM · Restricted Project

Aug 26 2020

hokein committed rG667867e0df26: [clangd] Enable recovery-ast-type by default. (authored by hokein).
[clangd] Enable recovery-ast-type by default.
Aug 26 2020, 7:47 AM
hokein closed D86602: [clangd] Enable recovery-ast-type by default..
Aug 26 2020, 7:47 AM · Restricted Project
hokein requested review of D86602: [clangd] Enable recovery-ast-type by default..
Aug 26 2020, 2:00 AM · Restricted Project
hokein committed rG0aaa2acc4ca0: [clangd] Compute the inactive code range for semantic highlighting. (authored by hokein).
[clangd] Compute the inactive code range for semantic highlighting.
Aug 26 2020, 1:51 AM
hokein closed D85635: [clangd] Compute the inactive code range for semantic highlighting..
Aug 26 2020, 1:51 AM · Restricted Project

Aug 24 2020

hokein added inline comments to D86424: [clang] Do not consider the template arguments of bases to be bases themselves.
Aug 24 2020, 11:49 PM · Restricted Project
hokein accepted D86473: [clangd] When inserting "using", add "::" in front if that's the style..
Aug 24 2020, 11:36 PM · Restricted Project
hokein updated the diff for D85635: [clangd] Compute the inactive code range for semantic highlighting..

address comment.

Aug 24 2020, 8:19 AM · Restricted Project
hokein added inline comments to D86424: [clang] Do not consider the template arguments of bases to be bases themselves.
Aug 24 2020, 6:52 AM · Restricted Project
hokein committed rG09e7fe9859b4: [AST][RecoveryAST] Preserve the type by default for recovery expression. (authored by hokein).
[AST][RecoveryAST] Preserve the type by default for recovery expression.
Aug 24 2020, 5:34 AM