Page MenuHomePhabricator
Feed Advanced Search

Mar 18 2023

Lancern added a comment to D138005: [libc++abi] Improve performance of __dynamic_cast.

Ping: any updates on landing of this revision?

Mar 18 2023, 11:42 PM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2023

Lancern updated the diff for D138005: [libc++abi] Improve performance of __dynamic_cast.

Rebase work onto the latest main.

Mar 2 2023, 3:06 AM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2023

Lancern updated the diff for D138005: [libc++abi] Improve performance of __dynamic_cast.

Rebase work onto the latest main

Feb 23 2023, 3:34 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2023

Lancern updated the diff for D138006: [libc++abi] Refactoring works around __dynamic_cast.

Sync with the parent commit.

Feb 22 2023, 4:03 AM · Restricted Project, Restricted Project, Restricted Project
Lancern updated the diff for D138005: [libc++abi] Improve performance of __dynamic_cast.

Got rst formatting wrong :( fixed that.

Feb 22 2023, 4:02 AM · Restricted Project, Restricted Project, Restricted Project
Lancern updated the diff for D138005: [libc++abi] Improve performance of __dynamic_cast.

Update release notes to point out the performance improvements.

Feb 22 2023, 3:54 AM · Restricted Project, Restricted Project, Restricted Project

Feb 21 2023

Lancern added a comment to D138005: [libc++abi] Improve performance of __dynamic_cast.

@avogelsgesang I don't have commit access so I think somebody else needs to commit this. And where can I add release notes? I'm not clear on how to add release notes.

Feb 21 2023, 6:31 AM · Restricted Project, Restricted Project, Restricted Project

Feb 20 2023

Lancern updated the diff for D138006: [libc++abi] Refactoring works around __dynamic_cast.

Rebase work onto the latest main.

Feb 20 2023, 6:46 AM · Restricted Project, Restricted Project, Restricted Project
Lancern updated the diff for D138005: [libc++abi] Improve performance of __dynamic_cast.

Rebase work onto the latest main.

Feb 20 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

Lancern added a comment to D138005: [libc++abi] Improve performance of __dynamic_cast.

The libcxx CI fails because:

Feb 13 2023, 6:20 PM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2023

Lancern updated the diff for D138006: [libc++abi] Refactoring works around __dynamic_cast.

Rebase onto b945bb246ad9.

Feb 11 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project
Lancern updated the diff for D138005: [libc++abi] Improve performance of __dynamic_cast.

Add license header to the benchmark source code file.

Feb 11 2023, 6:42 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2023

Lancern added a comment to D138005: [libc++abi] Improve performance of __dynamic_cast.

Are there any reviewer updates on this revision and the child revision?

Feb 6 2023, 7:25 PM · Restricted Project, Restricted Project, Restricted Project

Dec 24 2022

Lancern updated the diff for D138006: [libc++abi] Refactoring works around __dynamic_cast.

Fix build issues on Apple system

Dec 24 2022, 2:05 AM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

Lancern added a comment to D138006: [libc++abi] Refactoring works around __dynamic_cast.

Seems like the failed unit tests are not related to this patch nor the parent revision.

Dec 9 2022, 6:26 PM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2022

Lancern updated the diff for D138006: [libc++abi] Refactoring works around __dynamic_cast.

Rebase onto the main branch so that CI triggers correctly

Nov 23 2022, 11:47 PM · Restricted Project, Restricted Project, Restricted Project
Lancern updated the diff for D138005: [libc++abi] Improve performance of __dynamic_cast.

Rebase changes onto the main branch so that CI correctly triggers.

Nov 23 2022, 11:46 PM · Restricted Project, Restricted Project, Restricted Project

Nov 14 2022

Lancern updated the summary of D138006: [libc++abi] Refactoring works around __dynamic_cast.
Nov 14 2022, 11:43 PM · Restricted Project, Restricted Project, Restricted Project
Lancern abandoned D137315: [libc++abi] Improve performance of __dynamic_cast.

This revision is abandoned since I screwed it with multiple commits. I re-created 2 new revisions for each of the 2 commits contained in this revision, respectively:

Nov 14 2022, 11:42 PM · Restricted Project, Restricted Project, Restricted Project
Lancern requested review of D138006: [libc++abi] Refactoring works around __dynamic_cast.
Nov 14 2022, 11:37 PM · Restricted Project, Restricted Project, Restricted Project
Lancern updated the summary of D138005: [libc++abi] Improve performance of __dynamic_cast.
Nov 14 2022, 11:30 PM · Restricted Project, Restricted Project, Restricted Project
Lancern requested review of D138005: [libc++abi] Improve performance of __dynamic_cast.
Nov 14 2022, 11:25 PM · Restricted Project, Restricted Project, Restricted Project
Lancern added a comment to D137315: [libc++abi] Improve performance of __dynamic_cast.

Do you know why the hint wasn't initially used? Was there a point where compilers didn't actually provide the hints?

Nov 14 2022, 6:55 PM · Restricted Project, Restricted Project, Restricted Project
Lancern added a comment to D137315: [libc++abi] Improve performance of __dynamic_cast.

Ping

Nov 14 2022, 6:10 AM · Restricted Project, Restricted Project, Restricted Project

Nov 7 2022

Lancern added a comment to D137315: [libc++abi] Improve performance of __dynamic_cast.

I instrumented private_typeinfo.cpp with gcov and get its coverage during unit tests. The coverage shows that all new branches introduced in this patch series are covered by existing unit tests.

Nov 7 2022, 6:12 AM · Restricted Project, Restricted Project, Restricted Project
Lancern updated the diff for D137315: [libc++abi] Improve performance of __dynamic_cast.

Resolve the reviewed issues posted at D137315#3910662

Nov 7 2022, 6:05 AM · Restricted Project, Restricted Project, Restricted Project

Nov 3 2022

Lancern added a comment to D137315: [libc++abi] Improve performance of __dynamic_cast.

Could you provide before and after numbers for the benchmark?

Nov 3 2022, 4:34 AM · Restricted Project, Restricted Project, Restricted Project
Lancern requested review of D137315: [libc++abi] Improve performance of __dynamic_cast.
Nov 3 2022, 12:08 AM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2022

Lancern updated the diff for D128351: [clang] missing outer template levels when checking template constraints.

Fix some regression issues

Jun 22 2022, 8:27 PM · Restricted Project, Restricted Project
Lancern edited reviewers for D128351: [clang] missing outer template levels when checking template constraints, added: klimek, dcoughlin, rsmith; removed: Richard, smith.
Jun 22 2022, 9:06 AM · Restricted Project, Restricted Project
Lancern requested review of D128351: [clang] missing outer template levels when checking template constraints.
Jun 22 2022, 8:56 AM · Restricted Project, Restricted Project