Page MenuHomePhabricator
Feed Advanced Search

Yesterday

NoQ added a comment to D61912: [analyzer] print() JSONify: Store implementation.

Thanks @NoQ! The   works well, but it produces a huge SVG file, here is a complete example of node-printing:

Thu, May 23, 4:47 PM · Restricted Project
NoQ accepted D62346: [analyzer] print() JSONify: getNodeLabel implementation.

Great job tho!

Thu, May 23, 4:40 PM · Restricted Project
NoQ added inline comments to D62346: [analyzer] print() JSONify: getNodeLabel implementation.
Thu, May 23, 4:40 PM · Restricted Project
NoQ accepted D62085: [analyzer] print() JSONify: Constructing objects implementation.
Thu, May 23, 4:31 PM · Restricted Project
NoQ added inline comments to D62085: [analyzer] print() JSONify: Constructing objects implementation.
Thu, May 23, 4:26 PM · Restricted Project
NoQ accepted D62087: [analyzer] print() JSONify: Program state implementation.

Looks great!

Thu, May 23, 4:23 PM · Restricted Project
NoQ added a comment to D62086: [analyzer] print() JSONify: Checker messages implementation.

Let's add a real test here as well. This code is complicated enough.

Thu, May 23, 4:19 PM · Restricted Project
NoQ added inline comments to D62085: [analyzer] print() JSONify: Constructing objects implementation.
Thu, May 23, 4:14 PM · Restricted Project
NoQ accepted D62083: [analyzer] print() JSONify: Type information implementation.

I wish for more tests, but hopefully we'll get them eventually.

Thu, May 23, 4:09 PM · Restricted Project
NoQ accepted D62081: [analyzer] print() JSONify: Environment implementation.

Looks great!

Thu, May 23, 4:07 PM · Restricted Project
NoQ accepted D62082: [analyzer] print() JSONify: Constraints implementation.

Looks great!

Thu, May 23, 4:07 PM · Restricted Project
NoQ added a comment to D59555: [analyzer] Add yaml parser to GenericTaintChecker.

Ok! This looks like there isn't that much code, so it should be fine to duplicate. Do you have plans to eliminate the existing switch and instead use yaml for *all* supported functions while shipping a default .yaml file with the analyzer?

Thu, May 23, 1:27 PM · Restricted Project
NoQ accepted D62094: [analyzer] List checker/plugin options in 3 categories: released, alpha, developer.

Thank you. This formalization work made things a lot easier and safer to deal with.

Thu, May 23, 12:53 PM · Restricted Project
NoQ accepted D61839: [analyzer] Hide developer-only checker/package options by default.

Next!

Thu, May 23, 12:53 PM · Restricted Project
NoQ added a comment to D62093: [analyzer] List checkers in 3 categories: released, alpha, developer.

Thx!~

Thu, May 23, 12:38 PM · Restricted Project, Restricted Project

Wed, May 22

NoQ accepted D62093: [analyzer] List checkers in 3 categories: released, alpha, developer.

Looks great, thanks!

Wed, May 22, 3:48 PM · Restricted Project, Restricted Project
NoQ added a comment to D61912: [analyzer] print() JSONify: Store implementation.

I meant the [Store (ID)] title business and the pointers which appears between < > like the ID of the Store.

If we write out some ProgramPoints it looks like that:

DeclRefExpr S2079258 <0x29c35c0> RM
line=2715 col=11
--------
ImplicitCastExpr S2079262 <0x29c35e0> RM
line=2715 col=11

Would you need the S or the < > version of IDs, or both? How would you call the latter?

Wed, May 22, 2:15 PM · Restricted Project
NoQ added a comment to D61912: [analyzer] print() JSONify: Store implementation.

After a while I think we could drop the IDs and the title part.

Wed, May 22, 1:33 PM · Restricted Project

Fri, May 17

NoQ added inline comments to D62082: [analyzer] print() JSONify: Constraints implementation.
Fri, May 17, 4:08 PM · Restricted Project
NoQ added inline comments to D61912: [analyzer] print() JSONify: Store implementation.
Fri, May 17, 4:00 PM · Restricted Project
NoQ accepted D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

Go for it!

Fri, May 17, 3:53 PM · Restricted Project
NoQ added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

Mmm, just had a fresh look and i kinda like it. I think in its current shape it's intuitive enough what this means.

Fri, May 17, 3:03 PM · Restricted Project

Thu, May 16

NoQ added a comment to D59464: [analyzer] Add an example plugin for checker dependency handling.

Can we have a full build log?

Thu, May 16, 2:01 PM · Restricted Project, Restricted Project

Wed, May 15

NoQ accepted D61912: [analyzer] print() JSONify: Store implementation.

Generally this is good to go, i think. I like it!

Wed, May 15, 4:11 PM · Restricted Project
NoQ added a comment to D61912: [analyzer] print() JSONify: Store implementation.

PrettyStackTraceLocationContext.h definitely needs the default print() method (may other users too). Even it is a little bit silly but I think we have to keep them and create printJSON(). What do you think?

Wed, May 15, 4:10 PM · Restricted Project
NoQ created D61958: [analyzer] RetainCount: Fix a crash when os_returns_retained_on_zero (_nonzero) is applied to functions that return weird stuff..
Wed, May 15, 11:22 AM · Restricted Project

Tue, May 14

NoQ added a comment to D57858: [analyzer] Add a new frontend flag to display all checker options.

http://lists.llvm.org/pipermail/cfe-dev/2019-May/062298.html

Tue, May 14, 7:33 PM · Restricted Project, Restricted Project
NoQ added inline comments to D61925: [analyzer] MIGChecker: Add support for os_ref_retain()..
Tue, May 14, 5:10 PM · Restricted Project
NoQ created D61925: [analyzer] MIGChecker: Add support for os_ref_retain()..
Tue, May 14, 5:10 PM · Restricted Project
NoQ updated the diff for D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses..

What about "the most derived class"

Tue, May 14, 4:37 PM · Restricted Project
NoQ updated the diff for D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..

Rebase.

Tue, May 14, 4:27 PM · Restricted Project
NoQ updated the diff for D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead..

Fxd.

Tue, May 14, 4:26 PM · Restricted Project, Restricted Project
NoQ added inline comments to D61912: [analyzer] print() JSONify: Store implementation.
Tue, May 14, 3:51 PM · Restricted Project
NoQ added a comment to D61912: [analyzer] print() JSONify: Store implementation.

Yay great!

Tue, May 14, 3:48 PM · Restricted Project
NoQ added a comment to D57858: [analyzer] Add a new frontend flag to display all checker options.

These are the alpha checkers that we are testing in Ericsson:

Tue, May 14, 2:21 PM · Restricted Project, Restricted Project

Mon, May 13

NoQ updated the diff for D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses..

Improve note text so that to avoid the singular/plural problem.

Mon, May 13, 6:02 PM · Restricted Project
NoQ added a comment to D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..

Note that a similar functionality is necessary for destructors of virtual bases, but it remains to be done for now. We should be able to re-use the same terminator kind.

Mon, May 13, 5:54 PM · Restricted Project
NoQ accepted D61136: [Analyzer] Refactor begin and end symbol creation.

Thx!

Mon, May 13, 3:06 PM · Restricted Project, Restricted Project
NoQ added a comment to D57858: [analyzer] Add a new frontend flag to display all checker options.

Some alpha checkers are considerably more mature than others and are quite usable. In our experience, there are some users who are keen to run these checkers on their code and report back any false positives to us. So in this sense these are not "developer only" checkers. So I think we should let the users list them, read their descriptions and try them out. Some of them will come back with useful feedback as to how to improve them further.

Mon, May 13, 3:00 PM · Restricted Project, Restricted Project
NoQ added a comment to D61677: [analyzer] ExplodedGraph: printDiff(): ProgramState implementation.

What is a cluster here?

Mon, May 13, 2:44 PM · Restricted Project
NoQ added inline comments to D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.
Mon, May 13, 2:32 PM · Restricted Project, Restricted Project
NoQ accepted D59465: [analyzer] Add a test plugin for checker option handling.

I don't see any problems with adding more tests.

Mon, May 13, 2:25 PM · Restricted Project, Restricted Project
NoQ accepted D59464: [analyzer] Add an example plugin for checker dependency handling.

I can't say "no" to more tests.

Mon, May 13, 2:15 PM · Restricted Project, Restricted Project
NoQ added a comment to D61839: [analyzer] Hide developer-only checker/package options by default.

Checker options are a different kind of animal entirely. I think we should definitely let the user fine-tune some modeling checkers, for instance, unix.DynamicMemoryModeling:Optimistic, despite us not really wanting to let anyone (even developers really) mess around whether unix.DynamicMemoryModeling should be enabled.

Mon, May 13, 2:08 PM · Restricted Project

Fri, May 10

NoQ added a comment to D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses..

This is how it looks:

Fri, May 10, 8:26 PM · Restricted Project
NoQ added a parent revision for D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.: D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..
Fri, May 10, 8:22 PM · Restricted Project
NoQ updated the diff for D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses..

Fix formatting in tests.

Fri, May 10, 8:22 PM · Restricted Project
NoQ added a child revision for D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.: D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses..
Fri, May 10, 8:22 PM · Restricted Project
NoQ created D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses..
Fri, May 10, 8:22 PM · Restricted Project
NoQ added parent revisions for D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.: D61815: [CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp., D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead..
Fri, May 10, 8:15 PM · Restricted Project
NoQ added a child revision for D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead.: D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..
Fri, May 10, 8:15 PM · Restricted Project, Restricted Project
NoQ added a child revision for D61815: [CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp.: D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..
Fri, May 10, 8:15 PM · Restricted Project
NoQ created D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..
Fri, May 10, 8:14 PM · Restricted Project
NoQ created D61815: [CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp..
Fri, May 10, 8:05 PM · Restricted Project
NoQ created D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead..
Fri, May 10, 8:05 PM · Restricted Project, Restricted Project
NoQ added a comment to D57858: [analyzer] Add a new frontend flag to display all checker options.

Also, for CodeChecker purposes wouldn't you rather have a machine-readable dump?

Fri, May 10, 2:33 PM · Restricted Project, Restricted Project
NoQ added a comment to D57858: [analyzer] Add a new frontend flag to display all checker options.

Let's land this together with @Szelethus's proposed solution of hiding hidden options (like checkers in D60925). I'm still in favor of hiding alpha checkers (as they are for development only, much like debug flags; i'd recommend hiding them in the CodeChecker UI as well) and we should probably automatically hide options of checker that are hidden. Let's also, indeed, remove the USAGE thingy as it doesn't add much.

Fri, May 10, 2:32 PM · Restricted Project, Restricted Project
NoQ accepted D57860: [analyzer] Validate checker option names and values.

Setting compatibility mode to be true in the driver is not sufficient since many build systems call the frontend directly.

This doesn't seem to be the case; all build systems i'm aware of would pick up the driver flag.

Fri, May 10, 1:53 PM · Restricted Project, Restricted Project

Thu, May 9

NoQ added a comment to D61677: [analyzer] ExplodedGraph: printDiff(): ProgramState implementation.

I propose neither implementing ProgramState::printJSON() nor ProgramState::printDiff() but instead replacing the current implementation of ProgramState::print() with a brand-new implementation that prints JSON which is both human-readable and machine-readable.

Thu, May 9, 2:23 PM · Restricted Project
NoQ added a comment to D61677: [analyzer] ExplodedGraph: printDiff(): ProgramState implementation.

Ok, here's a plan:

  • Completely screw current program point and program state dumps and transform them into JSON dumps entirely while keeping it relatively human-readable when it comes to whitespace. This isn't much less readable than the existing dumps but it's also fully machine-readable, and we don't have to maintain two separate dumping facilities. Eg.:
{
  "program_points" : [
    { "kind" : "BinaryOperator", "file" : "test.c", "line" : 13, "col" : 7, "pretty" : "a + b" },
  ],
  "program_state" : [
    { "trait": "Environment", "items": [
      { "location_context" : 3, "calling" : "foo() on line 25", "items" : [
        { "pretty" : "a", "value" : "reg_$1<b>" },
        { "pretty" : "b", "value" : "reg_$0<a>" },
        { "pretty" : "a + b", "value" : "reg_$0<a> + reg_$1<b>" },
      ]},
      { "location_context" : 1, "calling" : "bar()", "items": [
        { "pretty" : "foo", "value" : "&code<foo>" },
      ]}
    ]},
    { "trait" : "Store", "items" : [
      { "cluster" : "SymRegion{reg_$2<x>}", "items" : [
        { "kind" : "Direct", "offset" : 0, "value" : "reg_$0<a> + reg_$1<b>" },
        { "kind" : "Direct", "offset" : 32, "value" : "reg_$1<b> - reg_$0<a>" },
      ]},
    ]},
  ]
}
Thu, May 9, 12:43 PM · Restricted Project

Wed, May 8

NoQ added a comment to D61677: [analyzer] ExplodedGraph: printDiff(): ProgramState implementation.

Aha, ook, so you're going for diffing within clang. That'd require duplicating the diff work in every checker (i.e., in every implementation of Checker::printState()), which is probably fine. I suspect that the solution of dumping the graph to, say, JSON or YAML and then converting it to DOT with a python script (where we can easily implement diffing in a generic way, regardless of what sort of data we're diffing) would have taken less code (and would have additionally helped us with serializing the program state for the (crazy) purposes of summary-based cross-translation-unit analysis), so i would have slightly preferred this direction, but it doesn't sound too heavy anyway, so i don't mind^^

Wed, May 8, 12:15 PM · Restricted Project

Tue, May 7

NoQ updated the diff for D61545: [analyzer] Fix a crash in RVO from within blocks..

Remove unused declaration from the test.

Tue, May 7, 2:45 PM · Restricted Project

Mon, May 6

NoQ added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

Could you have a quick look at how does the vulgar fractions solution look?, i.e., 42½ etc., maybe you can modify the html directly if you don't want to code it, as it might be annoying to code. I don't immediately see any downsides.

Mon, May 6, 6:47 PM · Restricted Project
NoQ updated the diff for D61545: [analyzer] Fix a crash in RVO from within blocks..

No, this is all wrong. We shouldn't unwrap to the parent stack frame here. We should end up exactly in the location context in which the call has happened. But we should still unwrap the block invocation context, as an exception, because it's just a weird location context that goes before the stack frame but still has its corresponding AnalysisDeclContext tied to the *callee* stack frame.

Mon, May 6, 2:50 PM · Restricted Project

Sun, May 5

NoQ accepted D61570: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType.

Yup, this definitely deserves to be a compound value. Could you also add a test that tries to load real/imaginary parts of y and compares them to 1? Just to know whether it actually works or just pretends to.

Sun, May 5, 2:25 PM · Restricted Project, Restricted Project

Fri, May 3

NoQ created D61545: [analyzer] Fix a crash in RVO from within blocks..
Fri, May 3, 6:40 PM · Restricted Project

Wed, May 1

NoQ added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

The reason why i don't want numbers on pop-up notes match numbers on regular notes is that the text on the pop-up note may no longer be true at the moment of time when we reach the regular note. Like, the value of the variable may change in between.

Wed, May 1, 7:13 PM · Restricted Project

Mon, Apr 29

NoQ added a comment to D61285: [analyzer] SmartPtrModeling: Fix a null dereference..

The whole AST consists in passing raw unannotated pointers around and i suspect it'll be annoying to deal with Stmt &s and Decl &s specifically in the Analyzer when all AST APIs accept pointers.

Mon, Apr 29, 7:43 PM · Restricted Project
NoQ updated the diff for D61051: [analyzer] Treat functions without runtime branches as "small"..

Crystallize the isHuge() function and document more stuff.

Mon, Apr 29, 7:33 PM · Restricted Project
NoQ updated the summary of D61285: [analyzer] SmartPtrModeling: Fix a null dereference..
Mon, Apr 29, 4:54 PM · Restricted Project
NoQ created D61285: [analyzer] SmartPtrModeling: Fix a null dereference..
Mon, Apr 29, 4:53 PM · Restricted Project
NoQ added a comment to D61136: [Analyzer] Refactor begin and end symbol creation.

Abstract iterator positions are represented by symbolic expressions because we must be able to do simple calculations with them. This has nothing to do with iterator objects represented as symbols. Or what do you mean exactly by "replacing position symbols with SymbolMetadata"?

Mon, Apr 29, 3:49 PM · Restricted Project, Restricted Project
NoQ added inline comments to D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive.
Mon, Apr 29, 3:26 PM · Restricted Project, Restricted Project
NoQ added a comment to D61051: [analyzer] Treat functions without runtime branches as "small"..

Great patch! There is only a design problem:
You have negated every isSmall() condition looks like you could write isLarge() instead but there is no connection between these functions.
Could you rename or redesign them? The following would be cool: isLarge() iff !isSmalll and isSmall() iff !isLarge().

Mon, Apr 29, 12:07 PM · Restricted Project

Thu, Apr 25

NoQ updated the diff for D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule"..

Fix whitespace.

Thu, Apr 25, 5:09 PM · Restricted Project
NoQ updated the diff for D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule"..

Make tests more C++-y. They still test the C function case.

Thu, Apr 25, 5:09 PM · Restricted Project
NoQ created D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule"..
Thu, Apr 25, 4:42 PM · Restricted Project
NoQ updated the diff for D61051: [analyzer] Treat functions without runtime branches as "small"..

Fxd.

Thu, Apr 25, 3:08 PM · Restricted Project
NoQ added inline comments to D61051: [analyzer] Treat functions without runtime branches as "small"..
Thu, Apr 25, 3:08 PM · Restricted Project
NoQ added a comment to D61136: [Analyzer] Refactor begin and end symbol creation.

Do you plan to centralize other code paths on which you conjure symbols?

Thu, Apr 25, 2:15 PM · Restricted Project, Restricted Project
NoQ accepted D61134: [Analyzer] Iterator Checkers - Do an early return after handling calls.

Thx, this is safer!

Thu, Apr 25, 1:46 PM · Restricted Project

Wed, Apr 24

NoQ added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

Hmm, i just realized that there may be multiple pop-ups for the same expression, with different values. This may happen if the expression is used in a loop or the function is called multiple times. We'd have to include all of them somehow, maybe something like this:

/------------------\
| (42.a)  X is 5   |    /-----------------\
| (69.a)  X is -2  |    | (42.b)  Y is 7  |
\  /---------------/    \  /--------------/
 \/                      \/
Wed, Apr 24, 5:35 PM · Restricted Project
NoQ added inline comments to D61051: [analyzer] Treat functions without runtime branches as "small"..
Wed, Apr 24, 2:45 PM · Restricted Project

Apr 23 2019

NoQ updated the summary of D61051: [analyzer] Treat functions without runtime branches as "small"..
Apr 23 2019, 6:58 PM · Restricted Project
NoQ updated the summary of D61051: [analyzer] Treat functions without runtime branches as "small"..
Apr 23 2019, 6:58 PM · Restricted Project
NoQ created D61051: [analyzer] Treat functions without runtime branches as "small"..
Apr 23 2019, 6:56 PM · Restricted Project
NoQ added inline comments to D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..
Apr 23 2019, 1:16 PM · Restricted Project, Restricted Project
NoQ added inline comments to D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..
Apr 23 2019, 1:16 PM · Restricted Project, Restricted Project
NoQ updated the diff for D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..

Add comments that getAsCharRange() is in fact used often misused.

Apr 23 2019, 1:16 PM · Restricted Project, Restricted Project

Apr 22 2019

NoQ added a comment to D60899: [analyzer] Unbreak body farms in presence of multiple declarations..

With body farms, i think, the current declaration also remains unchanged, we're just getting a shining new CompoundStmt as a body in the middle of nowhere, i.e., ADC->getDecl()->getBody() isn't the same as ADC->getBody(). Which is, yeah, still weird :)

Apr 22 2019, 7:53 PM · Restricted Project, Restricted Project
NoQ created D60991: [analyzer] RetainCount: Allow offsets in return values..
Apr 22 2019, 7:37 PM · Restricted Project
NoQ created D60988: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil..
Apr 22 2019, 6:19 PM · Restricted Project
NoQ accepted D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden.
Apr 22 2019, 5:17 PM · Restricted Project, Restricted Project
NoQ added a comment to D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden.

Yup, that sounds useful!

Apr 22 2019, 5:17 PM · Restricted Project, Restricted Project
NoQ updated the diff for D60796: [analyzer] PR41269: SmartPtrModeling..

Rename the checker.

Apr 22 2019, 4:32 PM · Restricted Project
NoQ added a comment to D60796: [analyzer] PR41269: SmartPtrModeling..

Yea, something along the lines of SmartPtrModeling would be neat -- logically, if you plan to emit errors down the line, subcheckers should be used for that, in order to enable checkers to depend purely on the modeling part.

Apr 22 2019, 4:24 PM · Restricted Project
NoQ added a comment to D60796: [analyzer] PR41269: SmartPtrModeling..

This might be an ideal candidate for being hidden by default though (D60925).

Apr 22 2019, 4:11 PM · Restricted Project
NoQ added a comment to D60899: [analyzer] Unbreak body farms in presence of multiple declarations..

the correct solution is to synthesize a shining new function and include it into the redeclaration chain.

Apr 22 2019, 4:09 PM · Restricted Project, Restricted Project
NoQ updated the diff for D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..

It looks like there's a number of users of this function beyond what you've mentioned:
clang-tidy/readability/IsolateDeclarationCheck.cpp:210

Apr 22 2019, 3:55 PM · Restricted Project, Restricted Project

Apr 19 2019

NoQ added inline comments to D60796: [analyzer] PR41269: SmartPtrModeling..
Apr 19 2019, 5:29 PM · Restricted Project