Fri, Nov 8
Thu, Nov 7
Thanks for the review, leaving open for final comments, will merge tomorrow.
Just grabbed a version string off a MBP:
Wed, Nov 6
Tue, Nov 5
Wed, Oct 30
Linux has been patched by to use normal section switching syntax https://lkml.org/lkml/2019/10/30/807. Abandon this LLVM patch as we should be fine without it.
Tue, Oct 29
The original patch looks fine because the SunStyleELFSectionSwitchSyntax functionality is already there. Now we start to add IsCompatibleWithSunStyleELFSectionSwitchSyntax... Have we communicated the Solaris assembler's .section syntax problem to the Linux community?
There are also some test cases for other ISA's in https://bugs.llvm.org/show_bug.cgi?id=41825.
Mon, Oct 28
Thanks for the patch! Looks like this was much simpler to support than I expected.
Fri, Oct 25
Wed, Oct 16
Likely also fixes regressions for aarch64 linux kernel builds: https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/246197698
Mon, Oct 14
Thanks for the patch and for following up on code review!
Oct 11 2019
Oct 10 2019
Great test cases. Thanks for the patch!
This transformation seems to increase code size significantly. Is the snprintf "%s" pattern common enough? I suspect most projects have already used memccpy, stpncpy, strscpy, or strlcpy. For the few that don't, the performance probably does not matter.
Oct 7 2019
Also, I'm fairly certain __forceinline and always_inline, confusingly enough differ in semantics, with __forceinline only being a stronger hint on MSVC.
Oct 4 2019
Oct 3 2019
- add links
- remove extra whitespace
- rewording, split onto separate lines to ease code review
- add spellings to heading
- fix two unit tests that needed updating
Sorry, this breaks:
Oct 2 2019
- git-clang-format HEAD~
It sounds like memccpy is part of C20. Can we not do this transform unless LangOpt says we're C20 or greater? Otherwise the Linux kernel doesn't implement this routine.
Oct 1 2019
Sep 30 2019
Sep 27 2019
Thanks for the patch! Just some small thoughts on style.
Sep 25 2019
Thanks for the patch. No comment if this is "the right thing to do," just basic code review comments.
Sep 23 2019
Bumping for code review
Please post patches with context.
Sep 17 2019
Sep 12 2019
Sep 11 2019
- adjust parens
Sep 6 2019
FWIW, I verified that this patch fixes pr/42012 and the test case pases. Thanks @eli.friedman !
- git-clang-format HEAD~
- updated commit message
I have verified this allows me to boot:
- arm64 linux-next (this patch fixes this regression, the below I verified are not regressed)
- x86_64 linux-next
- arm linux-next
- arm linux-next + CONFIG_JUMP_LABEL
- arm64 linux
- x86_64 linux
- arm linux
- arm linux + CONFIG_JUMP_LABEL
- rebase, add/clean up the commit message
@eli.friedman fixed this in r371111. Thanks Eli!
Sep 5 2019
Sep 4 2019
- fix my added unit test
- add unit test, add invariant to LangRef, remove "or jump" from LangRef (was never there)
- rebase on master, run git-clang-format HEAD~
Aug 28 2019
Ok, thanks for the iteration on code review.
Looks good, will likely approve after these 2 questions.