This make sense to me, thank you
Wed, Nov 11
Thu, Nov 5
Wed, Nov 4
Address Ahmed's comments.
Mon, Nov 2
LGTM, thanks for cleaning it up
Wed, Oct 28
This warrants a revert since it's breaking ABI compatibility for our libclang's users. @Anastasia will you be able to take a look at this soon? I plan on reverting this patch in a couple of weeks if the issue is still unresolved.
This approach seems like a reasonable compromise, thanks! LGTM.
Tue, Oct 27
What's wrong with using Optional<FileEntryRef> instead of MaybeFileEntryRef?
Mon, Oct 26
Oct 23 2020
LGTM with a nit.
Oct 21 2020
Oct 20 2020
Don't try to fallback to the "apple-a12" cpu type when the user explicitly specifies an older cpu. The default is still "apple-a12".
Thanks. Could you expand the comment in the test that this test path specifically exercises the behavior produced by the RedirectingFileSystem?
Oct 19 2020
Oct 14 2020
Oct 13 2020
Oct 12 2020
Sep 29 2020
Sep 28 2020
Hmm if this unit tests doesn't reproduce it then you don't need to add it. But no further objections from me on this change.
Sep 15 2020
Could you add a test-case that verifies that passing -Wno-format-insufficient-args suppresses warn_printf_insufficient_data_args?
Okay, that's fair. Is there any way to trigger the computeMacroArgsCache outside of libclang, to create a clang-specific test case?
Sep 4 2020
LGTM, with one comment below:
Sep 2 2020
I think the methods that use the rewriter should be prefixed with clang_Rewriter_ to match the naming convention, e.g. clang_Rewriter_removeText, clang_Rewriter_dispose, clang_Rewriter_create.
These methods should be prefixed with clang_Cursor_ to match the naming convention.
Do you have a test case? Please add a comment stating why the check is needed.
Sep 1 2020
got it, we'll do what we can to release it as soon as possible in Xcode
Aug 31 2020
@jkorous if the ambiguity between char/token ranges is a problem, how about adding a getRangeCharSize that takes an unambiguous CharSourceRange range, or even making getRangeSize take the CharSourceRange instead?
Could you please add a comment stating why it's necessary to skip the module map files? Is the problem caused by the module map file that's included in the include hierarchy when it's an external module?
Aug 18 2020
Aug 17 2020
add missing test fix
Aug 13 2020
Jul 30 2020
don't check if the SDK isn't present.