Page MenuHomePhabricator
Feed Advanced Search

Mon, Jun 3

srhines added a comment to rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests..

FYI, https://reviews.llvm.org/D56571 is the review where this was accepted.

Mon, Jun 3, 4:35 PM
srhines updated subscribers of rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests..
Mon, Jun 3, 4:35 PM

Fri, May 31

srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Fri, May 31, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
srhines added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
Fri, May 31, 1:05 PM · Restricted Project, Restricted Project, Restricted Project

Thu, May 30

srhines added inline comments to D62555: [TailDuplicator] prevent tail duplication for INLINEASM_BR.
Thu, May 30, 5:12 PM · Restricted Project

Wed, May 29

srhines accepted D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..

Everything looks great. Thanks for adding these improvements. While it's probably safe to commit this, perhaps you should give it 24 hours in case some of the other clang-tidy folks have different style or testing concerns.

Wed, May 29, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Wed, May 29, 3:11 PM · Restricted Project, Restricted Project, Restricted Project

Thu, May 23

srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Thu, May 23, 11:06 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 21

srhines accepted D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS.
Tue, May 21, 2:34 PM · Restricted Project
srhines added inline comments to D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS.
Tue, May 21, 2:21 PM · Restricted Project
srhines added inline comments to D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS.
Tue, May 21, 2:12 PM · Restricted Project
srhines accepted D57930: [Driver] Verify GCCInstallation is valid.

Thanks for picking this up and finishing it.

Tue, May 21, 2:04 PM · Restricted Project
srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Tue, May 21, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Tue, May 21, 1:00 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2019

srhines accepted D62055: [ARM][AArch64] Revert Android Bionic PT_TLS overaligning hack.

The revert is fine with me, although I still would like Ryan to follow up on verifying that the suggested fix for Bionic will indeed work for all cases. I think it is fine for you to merge now to unbreak things for everyone else though. Thanks for working through the problem.

May 17 2019, 7:54 PM · Restricted Project
srhines added a comment to D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used.

This LGTM if Ryan is happy with it. Thanks for taking care of getting a workaround implemented until this can be fixed.

May 17 2019, 11:21 AM · Restricted Project

May 16 2019

srhines updated subscribers of D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 16 2019, 1:14 PM · Restricted Project, Restricted Project, Restricted Project

Apr 30 2019

srhines added inline comments to D58260: [INLINER] allow inlining of blockaddresses if sole uses are callbrs.
Apr 30 2019, 12:02 AM · Restricted Project

Apr 26 2019

srhines added inline comments to D61201: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic).
Apr 26 2019, 10:50 AM
srhines added a comment to D61201: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic).

I had just a few small suggestions to make things more consistent. Feel free to ignore my fallthrough comment, but I feel like -Wimplicit-fallthrough has been quite valuable in Android.

Apr 26 2019, 10:43 AM

Apr 20 2019

srhines added a comment to D60927: [llvm-objdump] Switch between ARM/Thumb based on mapping symbols..

I added Peter and Oliver since they might have some suggestions here too.

Apr 20 2019, 11:17 AM · Restricted Project
srhines updated subscribers of D60927: [llvm-objdump] Switch between ARM/Thumb based on mapping symbols..
Apr 20 2019, 11:17 AM · Restricted Project

Apr 17 2019

srhines accepted D60840: [AArch64][MC] Reject "add x0, x1, w2, lsl #1" etc..

Thanks for taking a look at this.

Apr 17 2019, 6:15 PM · Restricted Project

Apr 16 2019

srhines accepted D60805: [builtins] Add __cmpsf2 for ARM version of comparesf2.

Thanks for finding this. Note that this is the exact code in comparesf2.c.

Apr 16 2019, 6:04 PM · Restricted Project, Restricted Project

Apr 11 2019

srhines added a comment to D60577: [X86AsmPrinter] refactor static functions into private methods. NFC.

I have zero context on this change specifically, but "we should prefer functions in a private namespace" seems to be the exact opposite of the advice in https://llvm.org/docs/CodingStandards.html#static

Apr 11 2019, 3:13 PM · Restricted Project

Apr 4 2019

srhines accepted rG5d289ed3fee3: [test] Specify an explicit darwin version in a triple in `test/Driver/debug….

Thank you for fixing this quickly!

Apr 4 2019, 6:48 PM
srhines committed rG1ee8876d3d70: Verify that Android targets generate DWARF 4 by default. (authored by srhines).
Verify that Android targets generate DWARF 4 by default.
Apr 4 2019, 11:17 AM
srhines committed rC357713: Verify that Android targets generate DWARF 4 by default..
Verify that Android targets generate DWARF 4 by default.
Apr 4 2019, 11:17 AM
srhines committed rL357713: Verify that Android targets generate DWARF 4 by default..
Verify that Android targets generate DWARF 4 by default.
Apr 4 2019, 11:16 AM
srhines closed D60238: Verify that Android targets generate DWARF 4 by default..
Apr 4 2019, 11:16 AM · Restricted Project, Restricted Project

Apr 3 2019

srhines added inline comments to D60238: Verify that Android targets generate DWARF 4 by default..
Apr 3 2019, 4:53 PM · Restricted Project, Restricted Project
srhines created D60238: Verify that Android targets generate DWARF 4 by default..
Apr 3 2019, 4:06 PM · Restricted Project, Restricted Project
srhines updated subscribers of D60238: Verify that Android targets generate DWARF 4 by default..
Apr 3 2019, 4:06 PM · Restricted Project, Restricted Project

Apr 1 2019

srhines added a comment to D60059: [Driver] implement -feverything.

In addition to -fno-everything, don't forget about -fnothing and -fno-nothing, which seem like they would also be nice to have.

Apr 1 2019, 8:56 AM · Restricted Project, Restricted Project

Mar 29 2019

srhines accepted D53344: [Driver] Use --warn-shared-textrel for Android..
Mar 29 2019, 11:04 AM · Restricted Project

Mar 25 2019

srhines accepted D59807: Fix nondeterminism introduced in r353954.

@jmorse can I get your approval on this CL before we submit it? Thanks.

Mar 25 2019, 11:45 PM · Restricted Project
srhines added a comment to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.

https://reviews.llvm.org/D59807 has the fix for the nondeterminism. Thanks for the hints about the reverse iteration order. That helps make it more likely to fail deterministically, but it still runs a small chance of "passing" if the fix isn't there.

Mar 25 2019, 11:41 PM · Restricted Project
srhines added a comment to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.

Switching it to a MapVector makes it deterministic. I was just struggling late last night to try to reduce the .ll file down to something worth checking in! If you want to take over to minimize the test case, that would be much appreciated. Let me know so I can continue doing that if needed. Thanks.

Mar 25 2019, 8:11 AM · Restricted Project

Mar 23 2019

srhines added a comment to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.

This patch appears to generate non-reproducible builds in some cases. I can craft a more minimal test case, but the following link (https://godbolt.org/z/sWucUZ) is what I have been using. If I run Clang multiple times, the output eventually swaps the order of some undef DEBUG_VALUE's. I am just passing "-O1 -g" with that .ii file. It isn't obvious to me yet what is causing this to be unordered/non-deterministic.

Mar 23 2019, 9:44 AM · Restricted Project

Mar 20 2019

srhines added inline comments to D58531: [clang] Specify type of pthread_create builtin.
Mar 20 2019, 8:43 AM · Restricted Project

Mar 13 2019

srhines updated subscribers of D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Mar 13 2019, 5:02 PM · Restricted Project, Restricted Project

Mar 7 2019

srhines updated subscribers of D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 7 2019, 3:11 PM · Restricted Project

Feb 20 2019

srhines accepted D58477: [Driver] Fix float ABI default for Android ARMv8..

Dan, this seems pretty important for the NDK. If you submit this, would you want it cherry-picked ASAP?

Feb 20 2019, 6:03 PM · Restricted Project, Restricted Project

Feb 15 2019

srhines added a comment to D58266: [MC] Sort DWARF FDEs by the associated CIE before emitting them..

I asked Chris to comment here about libunwindstack. Hopefully we can get the problem fixed, but I think this workaround might be necessary for code running on older devices in any case (i.e. NDK apps).

Feb 15 2019, 10:02 AM · Restricted Project

Feb 14 2019

srhines added a comment to D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE..

Very cool, thank you for coming up with a great way to improve this case.

Feb 14 2019, 1:06 PM · Restricted Project
srhines updated subscribers of D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE..
Feb 14 2019, 1:01 PM · Restricted Project

Feb 7 2019

srhines added a comment to D57930: [Driver] Verify GCCInstallation is valid.

Would it be reasonable to have a test for this with perhaps an invalid GCC installation? There is some mock GCC/sysroot testing in https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/android-gcc-toolchain.c and https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/android-ndk-standalone.cpp. I am not sure that it will be easy to trip this same bug that way, but I think it is possible.

Feb 7 2019, 5:09 PM · Restricted Project
srhines accepted D57911: [LLDB] Remove all abandoned LLDB bots.

LGTM for removing the broken Android builders.

Feb 7 2019, 3:46 PM · Restricted Project

Feb 6 2019

srhines committed rC353318: Switch to cantFail(), since it does the same assertion..
Switch to cantFail(), since it does the same assertion.
Feb 6 2019, 10:00 AM
srhines committed rGe0a89091d663: Switch to cantFail(), since it does the same assertion. (authored by srhines).
Switch to cantFail(), since it does the same assertion.
Feb 6 2019, 10:00 AM
srhines committed rL353318: Switch to cantFail(), since it does the same assertion..
Switch to cantFail(), since it does the same assertion.
Feb 6 2019, 9:59 AM
srhines closed D36806: Switch to cantFail(), since it does the same assertion..
Feb 6 2019, 9:59 AM · Restricted Project

Feb 5 2019

srhines added a comment to D36806: Switch to cantFail(), since it does the same assertion..

Looks like this was LGTM'd but never applied. Stephen -- do you have commit access?

Feb 5 2019, 2:10 PM · Restricted Project

Jan 30 2019

srhines added a reviewer for D57143: [builtins] Rounding mode support for addxf3/subxf3: peter.smith.
Jan 30 2019, 9:08 AM · Restricted Project, Restricted Project

Jan 22 2019

srhines accepted D56977: [builtins] Do not set hidden attribute on Android.
Jan 22 2019, 4:47 PM

Jan 8 2019

srhines accepted D56456: [Driver] Default to -fno-addrsig on Android..
Jan 8 2019, 2:28 PM
srhines accepted D55953: Android is not GNU, so don't claim that it is..

Sorry about the delay.

Jan 8 2019, 1:36 PM

Dec 11 2018

srhines accepted D55587: [hwasan] Verify Android TLS slot at startup..
Dec 11 2018, 4:56 PM

Dec 7 2018

srhines added inline comments to D34796: upporting -f(no)-reorder-functions flag, clang side change.
Dec 7 2018, 10:15 AM

Dec 3 2018

srhines added a comment to D53850: Declares __cpu_model as dso local.

Craig, does this look ok now?

Dec 3 2018, 5:27 PM

Nov 30 2018

srhines updated subscribers of D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 30 2018, 11:48 AM

Nov 28 2018

srhines added a comment to D55029: set default max-page-size to 4KB in lld for Android Aarch64.

I wouldn't rush to submit this now, given that this issue is not new at all. Maybe we can just wait for Peter's response?

Nov 28 2018, 3:09 PM
srhines accepted D55029: set default max-page-size to 4KB in lld for Android Aarch64.

Thanks Zhizhou! I'm curious about Peter's answer to the 64KiB default as well, but I think we should move forward with getting this patch submitted.

Nov 28 2018, 2:52 PM

Nov 16 2018

srhines added a comment to D52025: [TargetLowering] Android has sincos functions.

I just wanted to follow up here.

Nov 16 2018, 7:51 PM

Nov 1 2018

srhines added a comment to D53906: [ARM][AArch64] Increase TLS alignment to reserve space for Android's TCB.

Yabin did some of the work to bring TSan to Android. Perhaps he knows whether this is has significant use. Considering that it is meant as a debugging aide, I would actually be comfortable with moving it. You are also correct that we never officially marked it as a feature of the NDK (or platform). That is something we want to do though.

Nov 1 2018, 5:25 PM · Restricted Project
srhines updated subscribers of D53906: [ARM][AArch64] Increase TLS alignment to reserve space for Android's TCB.
Nov 1 2018, 5:23 PM · Restricted Project

Oct 26 2018

srhines updated subscribers of D53765: [RFC prototype] Implementation of asm-goto support in LLVM.
Oct 26 2018, 11:24 PM · Restricted Project

Oct 25 2018

srhines added a comment to D53742: [XRay] Use std::errc::invalid_argument instead of std::errc::bad_message.

LGTM, but please wait for dberris approval.

Oct 25 2018, 9:41 PM

Oct 24 2018

srhines updated subscribers of D53486: [libcxx] Only define __libcpp_is_floating_point<_Float16> for Clang.
Oct 24 2018, 9:19 AM

Oct 22 2018

srhines accepted D53529: [Driver] fix broken test.
Oct 22 2018, 2:25 PM

Oct 19 2018

srhines accepted D53463: [Driver] allow Android triples to alias for non Android targets.

Please remove the reference to b/X in the commit message. LLVM doesn't allow internal bug numbers, and you described the issue well enough without it.

Oct 19 2018, 6:14 PM

Oct 10 2018

srhines accepted D53118: [Driver] Fix --hash-style choice for Android..
Oct 10 2018, 6:28 PM
srhines accepted D53117: [Driver] Default to `-z now` and `-z relro` on Android..
Oct 10 2018, 6:25 PM
srhines added a comment to D53121: [Driver] Add defaults for Android ARM FPUs..

This LGTM, but we should wait to hear from Kristof before submitting.

Oct 10 2018, 6:23 PM
srhines added a reviewer for D53121: [Driver] Add defaults for Android ARM FPUs.: kristof.beyls.
Oct 10 2018, 6:21 PM
srhines accepted D53109: [Driver] Default Android toolchains to libc++..

Really cool! Thanks for making everything easier to use out-of-the-box.

Oct 10 2018, 6:19 PM

Oct 8 2018

srhines added a reviewer for D53003: [ELF] Fix link failure with Android compressed relocation support.: rprichard.
Oct 8 2018, 4:04 PM

Oct 2 2018

srhines committed rCRT343599: [sanitizer] Use -Wl,-z,global on Android for sanitizers except UBsan.
[sanitizer] Use -Wl,-z,global on Android for sanitizers except UBsan
Oct 2 2018, 9:22 AM
srhines committed rL343599: [sanitizer] Use -Wl,-z,global on Android for sanitizers except UBsan.
[sanitizer] Use -Wl,-z,global on Android for sanitizers except UBsan
Oct 2 2018, 9:22 AM
srhines closed D52770: [sanitizer] Use -Wl,-z,global on Android for sanitizers except UBsan.
Oct 2 2018, 9:21 AM
srhines created D52770: [sanitizer] Use -Wl,-z,global on Android for sanitizers except UBsan.
Oct 2 2018, 12:17 AM

Sep 20 2018

srhines added inline comments to D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs.
Sep 20 2018, 1:48 PM

Sep 19 2018

srhines accepted D52251: [builtins] Add __emutls_unregister_key function.

+enh and danalbert - in case they have any other concerns about this (Ryan's already on the review). From my perspective, everything here makes sense for resolving this issue.

Sep 19 2018, 3:13 PM
srhines updated subscribers of D52251: [builtins] Add __emutls_unregister_key function.
Sep 19 2018, 3:09 PM

Sep 18 2018

srhines added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Thanks @dblaikie for the quick fixup. I must have accidentally dropped the '!', because I did run check-all to test the change.

Sep 18 2018, 1:21 PM
srhines committed rC342501: Fix logic around determining use of frame pointer with -pg..
Fix logic around determining use of frame pointer with -pg.
Sep 18 2018, 11:38 AM
srhines committed rL342501: Fix logic around determining use of frame pointer with -pg..
Fix logic around determining use of frame pointer with -pg.
Sep 18 2018, 11:38 AM
srhines closed D52191: Fix logic around determining use of frame pointer with -pg..
Sep 18 2018, 11:38 AM
srhines closed D52191: Fix logic around determining use of frame pointer with -pg..
Sep 18 2018, 11:38 AM
srhines added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Sure, looks good. Though my other/vague concern is why does this case error about fomit-frame-pointer having no effect, but other things (like using -fomit-frame-pointer on a target that requires frame pointers) that ignore -fomit-frame-pointer don't? Weird. But it probably makes sense somehow.

Sep 18 2018, 11:34 AM

Sep 17 2018

srhines created D52191: Fix logic around determining use of frame pointer with -pg..
Sep 17 2018, 1:58 PM
srhines added a comment to D50297: Align AArch64 and i386 image base to superpage.

+Ryan in case there is anything here that could affect Bionic loading from these pages.

Sep 17 2018, 10:53 AM
srhines added a reviewer for D50297: Align AArch64 and i386 image base to superpage: rprichard.
Sep 17 2018, 10:49 AM
srhines accepted D52163: -S as an alias for --strip-all-gnu.

Thanks again! @alexshap feel free to submit this or I can do it in the morning tomorrow (can't stay up any later to watch for unlikely breakage, etc.).

Sep 17 2018, 2:25 AM
srhines added inline comments to D52163: -S as an alias for --strip-all-gnu.
Sep 17 2018, 1:59 AM
srhines added a comment to D52163: -S as an alias for --strip-all-gnu.

Thanks for noticing this missing feature, as well as for the patch! You really should add a simple test to test/tools/llvm-objcopy/strip-all-gnu.test so that this doesn't ever regress. The test strip-all-and-keep-symbol.test is an example that has multiple RUN lines. Here is what you need to change the strip-all-gnu.test to (I believe) in order to get this working:

Sep 17 2018, 1:35 AM

Sep 13 2018

srhines committed rL342165: Support -fno-omit-frame-pointer with -pg..
Support -fno-omit-frame-pointer with -pg.
Sep 13 2018, 12:51 PM
srhines committed rC342165: Support -fno-omit-frame-pointer with -pg..
Support -fno-omit-frame-pointer with -pg.
Sep 13 2018, 12:51 PM
srhines closed D51713: Support -fno-omit-frame-pointer with -pg..
Sep 13 2018, 12:51 PM
srhines added inline comments to D18086: Fix default processor name for armv6k..
Sep 13 2018, 12:33 PM