Page MenuHomePhabricator
Feed Advanced Search

Mon, Sep 13

DanielMcIntosh-IBM updated the summary of D109539: [NFC][libcxxabi] Rename GlobalLock to GlobalMutex.
Mon, Sep 13, 12:35 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D109539: [NFC][libcxxabi] Rename GlobalLock to GlobalMutex.

Update description with a bit more detail

Mon, Sep 13, 12:35 PM · Restricted Project

Fri, Sep 10

DanielMcIntosh-IBM accepted D98207: [SystemZ][z/OS] Missing wchar functions libc++.
Fri, Sep 10, 12:52 PM · Restricted Project

Thu, Sep 9

DanielMcIntosh-IBM added a comment to D108343: [NFC][libcxxabi] Refactor libcxxabi/src/cxa_guard_impl.h.

If you can split it into a few changes that are easier to review, it would be helpful.

Thu, Sep 9, 1:21 PM · Restricted Project
DanielMcIntosh-IBM requested review of D109539: [NFC][libcxxabi] Rename GlobalLock to GlobalMutex.
Thu, Sep 9, 1:13 PM · Restricted Project

Wed, Sep 8

DanielMcIntosh-IBM requested changes to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

As discussed over slack, there is an edge case that needs to be addressed (the case where ps == nullptr on line 55 of wcsnrtombs and/or on line 61 of mbsnrtowcs).
Once that's fixed, LGTM. I've left several comments for a few more ways it could be tidied up, but none of them are functional changes.

Wed, Sep 8, 2:35 PM · Restricted Project

Wed, Sep 1

DanielMcIntosh-IBM added a comment to D108343: [NFC][libcxxabi] Refactor libcxxabi/src/cxa_guard_impl.h.

Ping

Wed, Sep 1, 8:12 AM · Restricted Project

Fri, Aug 20

DanielMcIntosh-IBM abandoned D105910: [SystemZ][z/OS][libcxx] Mark tests that require runtime linking as unsupported on z/OS.
Fri, Aug 20, 1:39 PM · Restricted Project

Aug 18 2021

DanielMcIntosh-IBM requested review of D108343: [NFC][libcxxabi] Refactor libcxxabi/src/cxa_guard_impl.h.
Aug 18 2021, 4:44 PM · Restricted Project
DanielMcIntosh-IBM committed rGf6ba6c397641: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h (authored by DanielMcIntosh-IBM).
[NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h
Aug 18 2021, 4:09 PM
DanielMcIntosh-IBM closed D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.
Aug 18 2021, 4:09 PM · Restricted Project
DanielMcIntosh-IBM retitled D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h from [NFC][SystemZ][z/OS] Run clang-format on libcxxabi/src/cxa_guard_impl.h to [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.
Aug 18 2021, 4:04 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.

Update commit tags

Aug 18 2021, 4:03 PM · Restricted Project
DanielMcIntosh-IBM retitled D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h from [NFC][SystemZ][z/OS] Run clang-format on libcxxabi/src/cxa_guard_impl.h to [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.
Aug 18 2021, 4:03 PM · Restricted Project
DanielMcIntosh-IBM added a comment to D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.

I'd normally frown upon this since we generally don't clang-format whole files at once, but since the changes are pretty small, it might be OK to do that. But we definitely want to clang-format it right though.

Aug 18 2021, 12:18 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.

Address Louis's comments

Aug 18 2021, 8:17 AM · Restricted Project
DanielMcIntosh-IBM updated the summary of D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.
Aug 18 2021, 8:10 AM · Restricted Project

Aug 17 2021

DanielMcIntosh-IBM requested review of D108231: [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h.
Aug 17 2021, 12:03 PM · Restricted Project

Aug 4 2021

DanielMcIntosh-IBM added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

I will update D105910 with these test cases, so this can be closed

Aug 4 2021, 12:41 PM
DanielMcIntosh-IBM added a comment to D105910: [SystemZ][z/OS][libcxx] Mark tests that require runtime linking as unsupported on z/OS.

Given the nature of these changes, they're fairly low priority for us to get upstream right now, but I will come back to these at a later date to address the comments and get this into a state where it is suitable to merge

Aug 4 2021, 12:39 PM · Restricted Project

Jul 13 2021

DanielMcIntosh-IBM requested review of D105910: [SystemZ][z/OS][libcxx] Mark tests that require runtime linking as unsupported on z/OS.
Jul 13 2021, 10:28 AM · Restricted Project

Jul 7 2021

DanielMcIntosh-IBM committed rGd0fe294729a2: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS (authored by DanielMcIntosh-IBM).
[SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS
Jul 7 2021, 7:54 AM
DanielMcIntosh-IBM closed D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.
Jul 7 2021, 7:54 AM · Restricted Project
DanielMcIntosh-IBM retitled D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS from [SystemZ][z/OS] XFAIL aligned allocation tests on z/OS to [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.
Jul 7 2021, 7:52 AM · Restricted Project

Jul 6 2021

DanielMcIntosh-IBM updated the diff for D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.

Update PR based on internal discussions about whether to match targets based on
just zos or both s390 and zos.

Jul 6 2021, 11:38 AM · Restricted Project

Jun 18 2021

DanielMcIntosh-IBM added a comment to D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.

LGTM, but just out of curiosity, will this stay unsupported forever, or will this be implemented eventually?

Normally, we try to support things unless we have a fundamental reason why it can't be done (for example supporting exceptions on an embedded system). But it seems a bit strange to me to mark aligned allocation function tests as unsupported based on the *architecture* - instead I would have expected it to be marked as unsupported based on specific OS versions that do not implement the feature yet.

As of today z/OS does not support aligned allocation. Once it is supported we will be able to say it is only supported in z/OS X.Y and above. The tag "s390-zos" is more than an architecture tag. It is more of an OS tag. We have zLinux on s390 as well. The s390-zos tag only covers z/OS, not zLinux. We can change that name if it helps clarify some confusion.

Jun 18 2021, 11:43 AM · Restricted Project

Jun 17 2021

DanielMcIntosh-IBM updated the diff for D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.

Updating with related changes instead of creating new PRs

Jun 17 2021, 12:30 PM · Restricted Project

Jun 14 2021

DanielMcIntosh-IBM updated the diff for D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.

Update to address Louis's comments.

Jun 14 2021, 11:44 AM · Restricted Project

Jun 9 2021

DanielMcIntosh-IBM added inline comments to D98207: [SystemZ][z/OS] Missing wchar functions libc++.
Jun 9 2021, 12:03 PM · Restricted Project
DanielMcIntosh-IBM added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Immediately after hitting submit I notice a few more things. Added them as comments too

Jun 9 2021, 11:44 AM · Restricted Project
DanielMcIntosh-IBM requested changes to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

If this is taken from windows, I will point out that, on windows wide characters are only 16 bits (on most systems, wchar_t is 32 bits). This may result in some assumptions in the implementation which aren't true for z/OS. I'm particularly concerned about line 39 potentially writing more than dest_remaining characters (TBH, I'm a little surprised this part works correctly on windows). This could result in writing past the end of dst (i.e. a buffer overflow). This would then be made even worse by dest_remaining -= char_size not setting dest to 0 at that point, and thus the ! dest_remaining check not triggering. Assuming it has the correct license, using the z/OS implementation of wcsrtombs as a reference might be better (unlike wcsnrtombs which is a POSIX extention, wcsrtombs is a part of the C and C++ standards).

Jun 9 2021, 10:49 AM · Restricted Project
DanielMcIntosh-IBM added a comment to D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.

Ping

Jun 9 2021, 8:33 AM · Restricted Project

Jun 7 2021

DanielMcIntosh-IBM retitled D103558: [libcxx] Remove VLA from libcxx locale header from Remove VLA from libcxx locale header to [libcxx] Remove VLA from libcxx locale header.
Jun 7 2021, 11:57 AM · Restricted Project

Jun 4 2021

DanielMcIntosh-IBM added inline comments to D103558: [libcxx] Remove VLA from libcxx locale header.
Jun 4 2021, 10:06 AM · Restricted Project
DanielMcIntosh-IBM updated the diff for D103558: [libcxx] Remove VLA from libcxx locale header.

rebase

Jun 4 2021, 9:16 AM · Restricted Project

Jun 2 2021

DanielMcIntosh-IBM requested review of D103558: [libcxx] Remove VLA from libcxx locale header.
Jun 2 2021, 2:49 PM · Restricted Project

Jun 1 2021

DanielMcIntosh-IBM added reviewers for D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS: abhina.sreeskantharajan, fanbo-meng, zibi.
Jun 1 2021, 3:31 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D103339: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments.

rebase

Jun 1 2021, 3:24 PM · Restricted Project

May 28 2021

DanielMcIntosh-IBM updated the summary of D103339: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments.
May 28 2021, 1:39 PM · Restricted Project
DanielMcIntosh-IBM requested review of D103339: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments.
May 28 2021, 1:37 PM · Restricted Project

May 19 2021

DanielMcIntosh-IBM requested review of D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.
May 19 2021, 12:08 PM · Restricted Project

Mar 2 2021

DanielMcIntosh-IBM requested review of D97796: [test] Fix apparent typo in clang/test/Driver/std.c.
Mar 2 2021, 12:50 PM · Restricted Project