Page MenuHomePhabricator
Feed Advanced Search

Mon, Aug 19

phosek added a comment to D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared.

I started seeing segfaults in some of our tests after the latests Clang roll and bisecting narrowed it down to this change. I also tried reverting this change locally and the segfaults no longer occur so I'm pretty confident it's this change. What's confusing is that it's not happening in regular Clang builds, it's only affecting GCC builds (we're using GCC 8.3) that are using libc++ and ASan builds. It's also don't see any of the modified functions on the stack which makes it even more confusing but I'm suspecting memory corruption that's happens earlier.

Mon, Aug 19, 12:39 AM

Fri, Aug 16

phosek committed rGedf504f5038b: [Fuchsia] Create the VMO during initialization, not during exit (authored by phosek).
[Fuchsia] Create the VMO during initialization, not during exit
Fri, Aug 16, 5:55 PM
phosek committed rL369180: [Fuchsia] Create the VMO during initialization, not during exit.
[Fuchsia] Create the VMO during initialization, not during exit
Fri, Aug 16, 5:55 PM
phosek closed D66323: [Fuchsia] Create the VMO during initialization, not during exit.
Fri, Aug 16, 5:55 PM · Restricted Project, Restricted Project
phosek committed rG0b5ecef299fd: [llvm-readobj] Unwrap the value first to avoid the error (authored by phosek).
[llvm-readobj] Unwrap the value first to avoid the error
Fri, Aug 16, 5:14 PM
phosek committed rL369177: [llvm-readobj] Unwrap the value first to avoid the error.
[llvm-readobj] Unwrap the value first to avoid the error
Fri, Aug 16, 5:06 PM
phosek committed rG7da81b5e4d2b: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections (authored by phosek).
[llvm-readobj] Fallback to PT_NOTE if file doesn't have sections
Fri, Aug 16, 4:16 PM
phosek committed rL369169: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
[llvm-readobj] Fallback to PT_NOTE if file doesn't have sections
Fri, Aug 16, 4:15 PM
phosek closed D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
Fri, Aug 16, 4:15 PM · Restricted Project
phosek updated the diff for D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.

It should reproduce now.

Fri, Aug 16, 1:07 PM · Restricted Project
phosek created D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
Fri, Aug 16, 11:59 AM · Restricted Project

Thu, Aug 15

phosek created D66323: [Fuchsia] Create the VMO during initialization, not during exit.
Thu, Aug 15, 4:50 PM · Restricted Project, Restricted Project
phosek accepted D62315: [compiler-rt][crt] Pass -fno-lto in check_cxx_section_exists.

LGTM

Thu, Aug 15, 11:23 AM · Restricted Project

Wed, Aug 14

phosek accepted D66271: [CMake] Check for C++14 instead of C++11.

LGTM

Wed, Aug 14, 9:33 PM · Restricted Project, Restricted Project
phosek accepted D64939: Add a proposal for a libc project under the LLVM umbrella..
Wed, Aug 14, 4:17 PM · Restricted Project
phosek added inline comments to D64939: Add a proposal for a libc project under the LLVM umbrella..
Wed, Aug 14, 2:52 PM · Restricted Project

Wed, Aug 7

phosek added a comment to D63672: Added Delta IR Reduction Tool.

Hey Diego, generally patches should not be committed without explicit approval (once a patch is sent for review, it's assumed it needs some kind of completion/sign-off/approval before committing). This patch has now been submitted 3 times without approval being given, I think?

Also when recommitting a reverted patch, it's important to include information about how the reason for a revert has been addressed. Committing with no fix to the bug is not usually acceptable except in fairly narrow circumstances (where all other avenues to reproduce the failure have been exhausted - including asking other developers who reported the failure to help reproduce the issue (they might be able to give hints about particular architectures and other environmental issues, etc - and they can do so on their own timeline rather than being forced to dig the issue out because they sync'd up and hit your patch again)).

I'm so sorry, I will be more thorough before committing Diffs; I will ask around to see if I can find the cause of the broken builds

No worries (:

I'm /guessing/ it might have something to do with running the interestingness test script - I doubt there's anything else quite like that in-tree, so probably a fair few reasons it might not work, I'd guess?

Wed, Aug 7, 4:26 PM · Restricted Project

Tue, Aug 6

phosek committed rG989679c3711a: Reverts commit r368117, r368115 and r368112 (authored by phosek).
Reverts commit r368117, r368115 and r368112
Tue, Aug 6, 10:20 PM
phosek added a comment to D63672: Added Delta IR Reduction Tool.

Reverted in rL368122.

Tue, Aug 6, 10:20 PM · Restricted Project
phosek committed rL368122: Reverts commit r368117, r368115 and r368112.
Reverts commit r368117, r368115 and r368112
Tue, Aug 6, 10:15 PM
phosek added a comment to D63672: Added Delta IR Reduction Tool.

We see a different test failure:

******************** TEST 'LLVM :: Reduce/remove-funcs.ll' FAILED ********************
Script:
--
: 'RUN: at line 4';   llvm-reduce --test /b/s/w/ir/k/llvm-project/llvm/test/Reduce/Inputs/remove-funcs.sh /b/s/w/ir/k/llvm-project/llvm/test/Reduce/remove-funcs.ll
: 'RUN: at line 5';   cat reduced.ll | /b/s/w/ir/k/recipe_cleanup/clangzMsUXi/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/Reduce/remove-funcs.ll
--
Exit Code: 1
Tue, Aug 6, 7:48 PM · Restricted Project
phosek accepted D65838: [Driver] Use enumeration for quoting mode. NFC.

LGTM

Tue, Aug 6, 6:47 PM · Restricted Project
phosek accepted D65824: Append an executable suffix to the toolchain tool paths on Windows platform..

LGTM

Tue, Aug 6, 5:33 PM · Restricted Project
phosek added a comment to D65307: Appending COMPILER_RT_LIBCXX_PATH include path to -isystem for compiler-rt xray.

I see a lot of errors when building XRay against the just built libc++ in the runtimes build after this change landed:

/b/s/w/ir/k/recipe_cleanup/clang1YIxKp/llvm_build_dir/./bin/clang++ --target=aarch64-unknown-fuchsia --sysroot=/b/s/w/ir/k/cipd/sdk/arch/arm64/sysroot  -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/.. -I/b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/../../include -I/b/s/w/ir/k/cipd/sdk/pkg/fdio/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -ffunction-sections -fdata-sections -fdebug-prefix-map=/b/s/w/ir/k/recipe_cleanup/clang1YIxKp/llvm_build_dir/runtimes/runtimes-aarch64-unknown-fuchsia-bins=../recipe_cleanup/clang1YIxKp/llvm_build_dir/runtimes/runtimes-aarch64-unknown-fuchsia-bins -fdebug-prefix-map=/b/s/w/ir/k/llvm-project/= -no-canonical-prefixes -Wall -std=c++11 -Wno-unused-parameter -O2 -g    -UNDEBUG  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtual-dtor -isystem /b/s/w/ir/k/llvm-project/llvm/../libcxx/include -fno-rtti -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_init.cpp.obj -MF compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_init.cpp.obj.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_init.cpp.obj -c /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/xray_init.cpp
In file included from /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/xray_init.cpp:21:
In file included from /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/xray_interface_internal.h:18:
In file included from /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/../../include/xray/xray_interface.h:18:
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:152:8: error: no member named 'int8_t' in the global namespace
using::int8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:153:8: error: no member named 'int16_t' in the global namespace
using::int16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:154:8: error: no member named 'int32_t' in the global namespace
using::int32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:155:8: error: no member named 'int64_t' in the global namespace
using::int64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:157:8: error: no member named 'uint8_t' in the global namespace
using::uint8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:158:8: error: no member named 'uint16_t' in the global namespace
using::uint16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:159:8: error: no member named 'uint32_t' in the global namespace
using::uint32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:160:8: error: no member named 'uint64_t' in the global namespace
using::uint64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:162:8: error: no member named 'int_least8_t' in the global namespace
using::int_least8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:163:8: error: no member named 'int_least16_t' in the global namespace
using::int_least16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:164:8: error: no member named 'int_least32_t' in the global namespace
using::int_least32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:165:8: error: no member named 'int_least64_t' in the global namespace
using::int_least64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:167:8: error: no member named 'uint_least8_t' in the global namespace
using::uint_least8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:168:8: error: no member named 'uint_least16_t' in the global namespace
using::uint_least16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:169:8: error: no member named 'uint_least32_t' in the global namespace
using::uint_least32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:170:8: error: no member named 'uint_least64_t' in the global namespace
using::uint_least64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:172:8: error: no member named 'int_fast8_t' in the global namespace
using::int_fast8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:173:8: error: no member named 'int_fast16_t' in the global namespace
using::int_fast16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:174:8: error: no member named 'int_fast32_t' in the global namespace
using::int_fast32_t;
     ~~^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.

See https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8905896666240143152 for a full log. IMHO this should be conditionalized on NOT HAVE_LIBCXX (which is set by the runtimes build). Can we please address this issue or revert this change?

Tue, Aug 6, 12:46 AM · Restricted Project, Restricted Project

Mon, Aug 5

phosek accepted D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

LGTM

Mon, Aug 5, 10:28 PM · Restricted Project, Restricted Project
phosek accepted D64089: [Driver] Introduce -stdlib++-isystem.

LGTM

Mon, Aug 5, 10:23 PM · Restricted Project, Restricted Project
phosek accepted D65767: gn build: Add AMDGPU target.

LGTM, the s/SystemOperands/SearchableTables/ change could land separately.

Mon, Aug 5, 3:56 PM · Restricted Project
phosek accepted D65773: Build libfuzzer libcxx-static with PIC.

LGTM

Mon, Aug 5, 3:52 PM · Restricted Project, Restricted Project
phosek added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

This looks reasonable to me; I'd prefer to clean up Clang's internal headers to be compatible with both FreeBSD's and musl's standard headers as suggested in http://lists.llvm.org/pipermail/llvm-dev/2019-August/134353.html, but I'm not sure how feasible or doable that is.

Mon, Aug 5, 2:14 PM · Restricted Project, Restricted Project
phosek added a comment to D65430: Add `--dependency-files` option, which is equivalent to compiler option -MD..

My understanding is that many developers use makefile/ninja generation systems such as cmake rather than hand-write the file themselves. As such would this get much use unless it was integrated into these generators? May be worth approaching them to see if they have any requirements/observations about the option?

Having it integrated into e.g. cmake would be a great project for someone to take on, but for us (FreeBSD) it would be useful by itself. Our build is about 175K lines of hand-written Makefiles and we could plug it in with a small change in a couple of places. In any case we shouldn't hold up lld support waiting on prospective cmake changes IMO.

Ed, does ld.lld a.o -o /dev/null | sed 's/(.*//' | sort -u | sed '$!s/$/ \\/';} generate a usable Makefile fragment? I think the scenarios where people write Makefile are not very common now (think cmake/bazel/meson/scons/buck/...). Makefile and build.ninja are mostly used as an "assembly language". I think a dependency graph feature will be useful, but a Makefile fragment is probably not the best format. (I actually like Makefile more than the alternatives but I know the trend is that people are moving away from hand-written Makefile) At least it looks like the output can be easily generated from ld.lld -t output.

I mentioned Makefile because -MD was created with that usage in mind (at least originally), but I guess that file format can be understood by other build tools. Am I missing something? Even though some build tools can understand C/C++ file dependencies without using a compiler, there's still some languages that the build systems cannot read, but still they can read auto-generated Makefile-compatible dependency file, no?

Different build systems use different syntax :/

Some are represented as a function call, e.g. executable('main', 'main.c'). Some are cc_binary(name="main", srcs=["main.c"]). llvm has LLVMBuild.txt. A Makefile fragment cannot be consumed by any of the build systems ;-)

In a hand-written Makefile, a.d is usually used in the following pattern:

a.o a.d: a.c
  gcc -MD -c $<

-include a.d   # suppress the error if a.d does not exist

a.c has many direct and indirect includes, e.g. stdio.h, stddef.h, a.h.
When any of the dependency is updated, a.o will be considered stale and will get rebuilt next time make is executed.

-MD is useful in that it gives the information that isn't available before: we can't tell what files a.c includes.

In the ld.lld --write-dependencies= case, the dependencies (bitcode files, object files, shared objects, and archive members that get pulled out) are already known. If it isn't, we'll get a "undefined reference" error. So I don't know who will be the consumer of the dependency output.

Mon, Aug 5, 12:07 PM · Restricted Project
phosek added a comment to D64378: [libcxx] Use C11 thread API on Fuchsia.

@EricWF friendly ping?

Mon, Aug 5, 11:56 AM

Sun, Aug 4

phosek committed rG1e4f2792faf1: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack (authored by phosek).
[Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
Sun, Aug 4, 9:49 PM
phosek committed rL367799: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
[Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
Sun, Aug 4, 9:49 PM
phosek closed D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
Sun, Aug 4, 9:49 PM · Restricted Project, Restricted Project
phosek updated the diff for D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
Sun, Aug 4, 9:31 PM · Restricted Project, Restricted Project
phosek commandeered D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
Sun, Aug 4, 9:31 PM · Restricted Project, Restricted Project
phosek committed rGbc3c2994033c: [Driver] Derive Fuchsia Linker directly from Tool (authored by phosek).
[Driver] Derive Fuchsia Linker directly from Tool
Sun, Aug 4, 6:40 PM
phosek committed rL367797: [Driver] Derive Fuchsia Linker directly from Tool.
[Driver] Derive Fuchsia Linker directly from Tool
Sun, Aug 4, 6:36 PM
phosek committed rG5b066a9d9045: [Driver] Always use -z separate-code with lld on Fuchsia (authored by phosek).
[Driver] Always use -z separate-code with lld on Fuchsia
Sun, Aug 4, 6:16 PM
phosek committed rL367796: [Driver] Always use -z separate-code with lld on Fuchsia.
[Driver] Always use -z separate-code with lld on Fuchsia
Sun, Aug 4, 6:15 PM
phosek committed rG85faa70e0470: [Driver] Support for disabling sanitizer runtime linking (authored by phosek).
[Driver] Support for disabling sanitizer runtime linking
Sun, Aug 4, 3:28 PM
phosek committed rL367794: [Driver] Support for disabling sanitizer runtime linking.
[Driver] Support for disabling sanitizer runtime linking
Sun, Aug 4, 3:28 PM
phosek closed D65029: [Driver] Support for disabling sanitizer runtime linking.
Sun, Aug 4, 3:28 PM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.
Sun, Aug 4, 1:59 PM · Restricted Project, Restricted Project
phosek updated the summary of D65029: [Driver] Support for disabling sanitizer runtime linking.
Sun, Aug 4, 2:27 AM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.
Sun, Aug 4, 2:27 AM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.

One more change, I went with -fsanitize-runtime and -fno-sanitize-runtime in the end which seems like the best fit.

Sun, Aug 4, 1:37 AM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.

I've decided to go with the original -f[no-]sanitize-link-deps: -fsanitize-minimal-runtime is also a cc1 flag which affects codegen, -fshared-libsan and -fstatic-libsan are orthogonal, e.g. it's possible to have minimal shared or static runtime, so these really need to be different flags.

Sun, Aug 4, 1:06 AM · Restricted Project, Restricted Project
phosek accepted D65703: Fix typo in GN build configuration.

LGTM

Sun, Aug 4, 12:58 AM · Restricted Project

Fri, Aug 2

phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.

I've updated the change and renamed the flag to -fsanitize-no-runtime although I'm not sure if it's necessarily better. I was thinking that ideal interface might be -fsanitize-runtime=(none|minimal|shared|static) which could also replace -fshared-libsan and -fstatic-libsan, but it'd be a breaking change so we might have to keep the existing flag and maybe print a deprecation warning. WDYT?

Fri, Aug 2, 7:53 PM · Restricted Project, Restricted Project
phosek added inline comments to D65690: [clang-doc] Add index in each info html file.
Fri, Aug 2, 6:32 PM · Restricted Project, Restricted Project

Thu, Aug 1

phosek added a comment to D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager.

Looks like this change broke Profile/gcc-flag-compatibility.c test on macOS:

******************** TEST 'Clang :: Profile/gcc-flag-compatibility.c' FAILED ********************
Script:
--
: 'RUN: at line 10';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-GEN /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 11';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-GEN /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 16';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate=/path/to -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefixes=PROFILE-GEN,PROFILE-GEN-EQ /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 22';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 23';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 24';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/default.profdata
: 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 26';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 30';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 31';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 32';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof
: 'RUN: at line 33';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 34';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 39';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 40';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 41';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility_IR.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/default.profdata
: 'RUN: at line 42';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 43';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 47';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 48';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 49';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility_IR.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof
: 'RUN: at line 50';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 51';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
--
Exit Code: 1
Thu, Aug 1, 11:52 PM · Restricted Project
phosek abandoned D64711: [LTO] Don't override relocation model stored in the module.

This was addressed in rL366644.

Thu, Aug 1, 6:47 PM · Restricted Project

Wed, Jul 31

phosek accepted D65512: gn build: Fix redundant object files in builtin lib..

LGTM

Wed, Jul 31, 9:09 AM · Restricted Project
phosek accepted D65518: gn build: Add build files for compiler-rt/lib/profile.

LGTM

Wed, Jul 31, 9:00 AM · Restricted Project
phosek accepted D65513: gn build: Make builtin library build on macOS.

LGTM

Wed, Jul 31, 8:56 AM · Restricted Project

Tue, Jul 30

phosek added inline comments to D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings.
Tue, Jul 30, 7:41 PM · Restricted Project
phosek added inline comments to D65430: Add `--dependency-files` option, which is equivalent to compiler option -MD..
Tue, Jul 30, 6:40 PM · Restricted Project

Sat, Jul 27

phosek added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

I made another fixup (similar to https://reviews.llvm.org/rL367176) here https://reviews.llvm.org/rL367182.

Can someone please take a look (a post-commit review) of https://reviews.llvm.org/rL367182 to verify that I did not misunderstand the intention with the test somehow?

Sat, Jul 27, 1:47 PM · Restricted Project
phosek added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

phosek: In what config / on what bot?

Sat, Jul 27, 1:18 PM · Restricted Project

Fri, Jul 26

phosek added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

We see test failures in as-options.s:

******************** TEST 'Clang :: Driver/as-options.s' FAILED ********************
Script:
--
: 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 7';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -I foo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 11';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 15';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -I foo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 21';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target aarch64-linux-gnu -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target aarch64-linux-gnu -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 29';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target armv7-linux-gnueabihf -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 33';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target armv7-linux-gnueabihf -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 42';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mincremental-linker-compatible -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 45';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mincremental-linker-compatible -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 48';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mimplicit-it=always -target armv7-linux-gnueabi -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 51';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mimplicit-it=always -target armv7-linux-gnueabi -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 54';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mbig-obj -target i386-pc-windows -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 57';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mbig-obj -target i386-pc-windows -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 60';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Xassembler -mbig-obj -target i386-pc-windows -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 63';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Xassembler -mbig-obj -target i386-pc-windows -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 70';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mno-warn-deprecated -fno-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOERROR --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 76';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mno-warn-deprecated -fno-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 81';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mrelax-all -fintegrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 83';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mrelax-all -fno-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=WARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
--
Exit Code: 1
Fri, Jul 26, 10:31 PM · Restricted Project
phosek committed rG92a2e1bbb900: Revert "[ARM] Set default alignment to 64bits" (authored by phosek).
Revert "[ARM] Set default alignment to 64bits"
Fri, Jul 26, 7:03 PM
phosek committed rL367166: Revert "[ARM] Set default alignment to 64bits".
Revert "[ARM] Set default alignment to 64bits"
Fri, Jul 26, 6:59 PM
phosek added a comment to D65000: [ARM] Set default alignment to 64bits.

Reverted in rL367166.

Fri, Jul 26, 6:59 PM · Restricted Project, Restricted Project
phosek added inline comments to D65000: [ARM] Set default alignment to 64bits.
Fri, Jul 26, 4:55 PM · Restricted Project, Restricted Project
phosek accepted D65270: [CMake] Fix source path generation for install in multi-config (MSBuild).
Fri, Jul 26, 12:52 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D65270: [CMake] Fix source path generation for install in multi-config (MSBuild).

LGTM, @beanz and @smeenai do you have any further comments?

Fri, Jul 26, 12:52 PM · Restricted Project, Restricted Project, Restricted Project
phosek added reviewers for D65270: [CMake] Fix source path generation for install in multi-config (MSBuild): beanz, smeenai.
Fri, Jul 26, 12:52 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jul 24

phosek committed rGf55f51b7beeb: Revert "[Sema] Enable -Wimplicit-float-conversion for integral to floating… (authored by phosek).
Revert "[Sema] Enable -Wimplicit-float-conversion for integral to floating…
Wed, Jul 24, 8:15 PM
phosek committed rL366979: Revert "[Sema] Enable -Wimplicit-float-conversion for integral to floating….
Revert "[Sema] Enable -Wimplicit-float-conversion for integral to floating…
Wed, Jul 24, 8:11 PM
phosek requested changes to D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss.
Wed, Jul 24, 8:11 PM · Restricted Project, Restricted Project
phosek reopened D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss.

Reverted in r366979.

Wed, Jul 24, 8:11 PM · Restricted Project, Restricted Project
phosek added a comment to D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss.

I'm seeing some test failures which appear to have been introduced by this change:

******************** TEST 'Clang :: CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';   /b/s/w/ir/k/recipe_cleanup/clango5zn3b/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clango5zn3b/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc -fsyntax-only -std=c++11 -triple x86_64-apple-macosx10.6.7 -verify /b/s/w/ir/k/llvm-project/clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp
--
Exit Code: 1
Wed, Jul 24, 6:35 PM · Restricted Project, Restricted Project
phosek added a comment to D65140: [yaml2obj] - Allow custom fields for the SHT_UNDEF sections..

The elf-custom-null-section.yaml test is failing on macOS with the following error:

FAIL: LLVM :: tools/yaml2obj/elf-custom-null-section.yaml (32620 of 32657)
******************** TEST 'LLVM :: tools/yaml2obj/elf-custom-null-section.yaml' FAILED ********************
Script:
--
: 'RUN: at line 5';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=1 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp1
: 'RUN: at line 6';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp1 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=DEFAULT
: 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=2 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp2
: 'RUN: at line 26';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp2 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=DEFAULT
: 'RUN: at line 47';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=3 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3
: 'RUN: at line 48';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=REDEFINE
: 'RUN: at line 74';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=4 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp4
: 'RUN: at line 75';   stat /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3 > /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt
: 'RUN: at line 76';   stat /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp4 >> /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt
: 'RUN: at line 77';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --input-file=/b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt --check-prefix=SIZE
: 'RUN: at line 101';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=5 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp5
: 'RUN: at line 102';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp5 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=OTHER-SECTION
: 'RUN: at line 131';   not /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=6 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp6 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=CASE4
: 'RUN: at line 147';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=7 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp7
: 'RUN: at line 148';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp7 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=DEFAULT
: 'RUN: at line 161';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=8 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp8
: 'RUN: at line 162';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp8 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=MULTIPLE
: 'RUN: at line 188';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=9 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp9
: 'RUN: at line 189';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp9 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=OVERRIDE
--
Exit Code: 1
Wed, Jul 24, 10:14 AM · Restricted Project
phosek added a comment to D65166: [AArch64][GlobalISel] Add support for s128 loads, stores, extracts, truncs..

We're seeing the following error in our build which appears to have been introduced by this change:

Wed, Jul 24, 1:30 AM · Restricted Project

Tue, Jul 23

phosek committed rG8b161bacf413: [SafeStack] Insert the deref before remaining elements (authored by phosek).
[SafeStack] Insert the deref before remaining elements
Tue, Jul 23, 5:19 PM
phosek committed rL366865: [SafeStack] Insert the deref before remaining elements.
[SafeStack] Insert the deref before remaining elements
Tue, Jul 23, 5:16 PM
phosek closed D65172: [SafeStack] Insert the deref before remaining elements.
Tue, Jul 23, 5:16 PM · Restricted Project
phosek updated the diff for D65172: [SafeStack] Insert the deref before remaining elements.

Done

Tue, Jul 23, 5:06 PM · Restricted Project
phosek updated the diff for D65172: [SafeStack] Insert the deref before remaining elements.
Tue, Jul 23, 4:36 PM · Restricted Project
phosek created D65172: [SafeStack] Insert the deref before remaining elements.
Tue, Jul 23, 4:16 PM · Restricted Project
phosek added a comment to D64971: [SafeStack] Insert the deref after the offset.

It seems like this change has introduced a crash in our build. I obtained the following stack trace:

invalid expression
!DIExpression(16, 537, 28, 4096, 456, 8, 6)
clang: /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/MachineInstr.cpp:2034: llvm::MachineInstrBuilder llvm::BuildMI(llvm::MachineFunction &, const llvm::DebugLoc &, const llvm::MCInstrDesc &, bool, llvm::MachineOperand &, const llvm::MDNode *, const llvm::MDNode *): Assertion `cast<DIExpression>(Expr)->isValid() && "not an expression"' failed.
Stack dump:
0.      Program arguments: ./bin/clang -cc1 -triple x86_64-fuchsia -emit-obj --mrelax-relocations -disable-free -main-file-name nir_opt_if.c -mrelocation-model pic -pic-level 2 -pic-is-pie -mthread-model posix -mframe-pointer=none -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu x86-64 -target-feature +cx16 -dwarf-column-info -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -ffunction-sections -fdata-sections -coverage-notes-file /b/s/w/ir/k/out/default/obj/third_party/mesa/src/compiler/nir/nir.nir_opt_if.gcno -sys-header-deps -D _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D NDEBUG=1 -D _LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D STDC_HEADERS=1 -D HAVE_SYS_TYPES_H=1 -D HAVE_SYS_STAT_H=1 -D HAVE_STDLIB_H=1 -D HAVE_STRING_H=1 -D HAVE_MEMORY_H=1 -D HAVE_STRINGS_H=1 -D HAVE_INTTYPES_H=1 -D HAVE_STDINT_H=1 -D HAVE_TIMESPEC_GET=1 -D HAVE_UNISTD_H=1 -D HAVE_DLFCN_H=1 -D YYTEXT_POINTER=1 -D HAVE___BUILTIN_BSWAP32=1 -D HAVE___BUILTIN_BSWAP64=1 -D HAVE___BUILTIN_CLZ=1 -D HAVE___BUILTIN_CLZLL=1 -D HAVE___BUILTIN_CTZ=1 -D HAVE___BUILTIN_EXPECT=1 -D HAVE___BUILTIN_FFS=1 -D HAVE___BUILTIN_FFSLL=1 -D HAVE___BUILTIN_POPCOUNT=1 -D HAVE___BUILTIN_POPCOUNTLL=1 -D HAVE___BUILTIN_UNREACHABLE=1 -D HAVE_FUNC_ATTRIBUTE_CONST=1 -D HAVE_FUNC_ATTRIBUTE_FLATTEN=1 -D HAVE_FUNC_ATTRIBUTE_FORMAT=1 -D HAVE_FUNC_ATTRIBUTE_MALLOC=1 -D HAVE_FUNC_ATTRIBUTE_PACKED=1 -D HAVE_FUNC_ATTRIBUTE_PURE=1 -D HAVE_FUNC_ATTRIBUTE_UNUSED=1 -D HAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT=1 -D HAVE_FUNC_ATTRIBUTE_NORETURN=1 -D HAVE_DLADDR=1 -D HAVE_DL_ITERATE_PHDR=1 -D HAVE_CLOCK_GETTIME=1 -D PACKAGE_NAME="Mesa"  -D PACKAGE_TARNAME="mesa"  -D PACKAGE_VERSION="19.1.0"  -D PACKAGE_STRING="Mesa 19.1.0"  -D PACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi\?product=Mesa"  -D PACKAGE_URL=""  -D PACKAGE="mesa"  -D VERSION="19.1.0" -D _DEFAULT_SOURCE -D _GNU_SOURCE=1 -D _DEFAULT_SOURCE -D HAVE_PTHREAD=1 -O3 -Wall -Wextra -Wnewline-eof -Wno-unused-parameter -Werror -Wno-error=deprecated-declarations -Wall -Wno-missing-field-initializers -Wno-initializer-overrides -Wno-sign-compare -Wno-overloaded-virtual -Wno-absolute-value -Wno-missing-braces -Wno-unused-function -Wno-mismatched-tags -Wno-enum-conversion -Wno-unused-variable -Wno-unused-private-field -Wno-sometimes-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-unused-label -Wno-switch -Wno-gnu-variable-sized-type-not-at-end -Wno-extra-semi -Wno-newline-eof -std=c11 -fdebug-prefix-map=/b/s/w/ir/k/out/default=. -fdebug-prefix-map=/b/s/w/ir/k/out=.. -fdebug-prefix-map=/b/s/w/ir/k=../.. -ferror-limit 19 -fmessage-length 0 -fvisibility hidden -fsanitize=safe-stack -stack-protector 2 -ftrivial-auto-var-init=pattern -fobjc-runtime=gcc -fno-common -fdiagnostics-show-option -fcolor-diagnostics -vectorize-loops -vectorize-slp -faddrsig -x c nir_opt_if-63c469.c
1.      <eof> parser at end of file
2.      Code generation
3.      Running pass 'Function Pass Manager' on module 'nir_opt_if-63c469.c'.
4.      Running pass 'Virtual Register Rewriter' on function '@opt_if_cf_list'
 #0 0x00000000073a0627 llvm::sys::PrintStackTrace(llvm::raw_ostream&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/Support/Unix/Signals.inc:533:11
 #1 0x00000000073a0719 PrintStackTraceSignalHandler(void*) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/Support/Unix/Signals.inc:594:1
 #2 0x000000000739f15b llvm::sys::RunSignalHandlers() /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/Support/Signals.cpp:67:5
 #3 0x00000000073a0d88 SignalHandler(int) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/Support/Unix/Signals.inc:385:1
 #4 0x00007f38a40fd3a0 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x123a0)
 #5 0x00007f38a318bcfb raise (/lib/x86_64-linux-gnu/libc.so.6+0x36cfb)
 #6 0x00007f38a31768ad abort (/lib/x86_64-linux-gnu/libc.so.6+0x218ad)
 #7 0x00007f38a317677f (/lib/x86_64-linux-gnu/libc.so.6+0x2177f)
 #8 0x00007f38a3184542 (/lib/x86_64-linux-gnu/libc.so.6+0x2f542)
 #9 0x000000000650cee9 llvm::BuildMI(llvm::MachineFunction&, llvm::DebugLoc const&, llvm::MCInstrDesc const&, bool, llvm::MachineOperand&, llvm::MDNode const*, llvm::MDNode const*) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/MachineInstr.cpp:2035:3
#10 0x000000000650d1f6 llvm::BuildMI(llvm::MachineBasicBlock&, llvm::MachineInstrBundleIterator<llvm::MachineInstr, false>, llvm::DebugLoc const&, llvm::MCInstrDesc const&, bool, llvm::MachineOperand&, llvm::MDNode const*, llvm::MDNode const*) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/MachineInstr.cpp:2065:22
#11 0x00000000067910bd (anonymous namespace)::UserValue::insertDebugValue(llvm::MachineBasicBlock*, llvm::SlotIndex, llvm::SlotIndex, DbgValueLocation, bool, unsigned int, llvm::LiveIntervals&, llvm::TargetInstrInfo const&, llvm::TargetRegisterInfo const&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/LiveDebugVariables.cpp:1318:5
#12 0x00000000067907b7 (anonymous namespace)::UserValue::emitDebugValues(llvm::VirtRegMap*, llvm::LiveIntervals&, llvm::TargetInstrInfo const&, llvm::TargetRegisterInfo const&, llvm::DenseMap<unsigned int, unsigned int, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, unsigned int> > const&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/LiveDebugVariables.cpp:1360:19
#13 0x00000000067884bf (anonymous namespace)::LDVImpl::emitDebugValues(llvm::VirtRegMap*) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/LiveDebugVariables.cpp:1394:24
#14 0x0000000006788317 llvm::LiveDebugVariables::emitDebugValues(llvm::VirtRegMap*) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/LiveDebugVariables.cpp:1410:1
#15 0x0000000006812b44 (anonymous namespace)::VirtRegRewriter::runOnMachineFunction(llvm::MachineFunction&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/VirtRegMap.cpp:258:37
#16 0x00000000064fe61f llvm::MachineFunctionPass::runOnFunction(llvm::Function&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:73:8
#17 0x00000000069e173c llvm::FPPassManager::runOnFunction(llvm::Function&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1648:23
#18 0x00000000069e1b9f llvm::FPPassManager::runOnModule(llvm::Module&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1685:16
#19 0x00000000069e2334 (anonymous namespace)::MPPassManager::runOnModule(llvm::Module&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1750:23
#20 0x00000000069e1e58 llvm::legacy::PassManagerImpl::run(llvm::Module&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1863:16
#21 0x00000000069e28d1 llvm::legacy::PassManager::run(llvm::Module&) /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1894:3
#22 0x00000000076e3c0c (anonymous namespace)::EmitAssemblyHelper::EmitAssembly(clang::BackendAction, std::__2::unique_ptr<llvm::raw_pwrite_stream, std::__2::default_delete<llvm::raw_pwrite_stream> >) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/CodeGen/BackendUtil.cpp:903:3
#23 0x00000000076e031c clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::DataLayout const&, llvm::Module*, clang::BackendAction, std::__2::unique_ptr<llvm::raw_pwrite_stream, std::__2::default_delete<llvm::raw_pwrite_stream> >) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1502:5
#24 0x0000000008198a02 clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/CodeGen/CodeGenAction.cpp:303:7
#25 0x000000000a0deb9e clang::ParseAST(clang::Sema&, bool, bool) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/Parse/ParseAST.cpp:178:12
#26 0x0000000008004652 clang::ASTFrontendAction::ExecuteAction() /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/Frontend/FrontendAction.cpp:1043:1
#27 0x0000000008195fec clang::CodeGenAction::ExecuteAction() /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/CodeGen/CodeGenAction.cpp:1060:1
#28 0x0000000008004028 clang::FrontendAction::Execute() /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/Frontend/FrontendAction.cpp:938:7
#29 0x0000000007f3936f clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:944:23
#30 0x0000000008185b36 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:291:8
#31 0x000000000471e69f cc1_main(llvm::ArrayRef<char const*>, char const*, void*) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/tools/driver/cc1_main.cpp:249:13
#32 0x000000000471146f ExecuteCC1Tool(llvm::ArrayRef<char const*>, llvm::StringRef) /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/tools/driver/driver.cpp:309:5
#33 0x0000000004710814 main /usr/local/google/home/phosek/clang-llvm/llvm-project/clang/tools/driver/driver.cpp:381:5
#34 0x00007f38a317852b __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2352b)
#35 0x000000000471002a _start (./bin/clang+0x471002a)

I'm still debugging this, but if you have any ideas what's the problem, I'd appreciate any pointers.

Tue, Jul 23, 3:15 PM · Restricted Project

Mon, Jul 22

phosek committed rG89385633ba1f: [libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails (authored by phosek).
[libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails
Mon, Jul 22, 12:55 PM
phosek committed rL366730: [libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails.
[libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails
Mon, Jul 22, 12:54 PM
phosek closed D64979: [libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails.
Mon, Jul 22, 12:54 PM · Restricted Project
phosek updated the diff for D64979: [libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails.
Mon, Jul 22, 12:50 PM · Restricted Project
phosek accepted D65098: [runtimes] Do not depend on libpthread on Android.

LGTM

Mon, Jul 22, 12:08 PM · Restricted Project
phosek committed rGf6cd6ffbc9f8: [SafeStack] Insert the deref after the offset (authored by phosek).
[SafeStack] Insert the deref after the offset
Mon, Jul 22, 11:58 AM
phosek committed rL366726: [SafeStack] Insert the deref after the offset.
[SafeStack] Insert the deref after the offset
Mon, Jul 22, 11:52 AM
phosek closed D64971: [SafeStack] Insert the deref after the offset.
Mon, Jul 22, 11:52 AM · Restricted Project

Jul 21 2019

phosek added a comment to D64378: [libcxx] Use C11 thread API on Fuchsia.

Ping? Anything else you'd like me to change?

Jul 21 2019, 3:38 PM
phosek closed D65032: [ELF] Support explicitly overriding relocation model in LTO.
Jul 21 2019, 2:58 PM · Restricted Project

Jul 20 2019

phosek added a comment to D65029: [Driver] Support for disabling sanitizer runtime linking.
In D65029#1594437, @pcc wrote:

It's also worth asking whether -nodefaultlibs would work for this use case as @filcab suggested on D64547.

Jul 20 2019, 6:36 PM · Restricted Project, Restricted Project
phosek committed rGae4c30a4bed9: [ELF] Support explicitly overriding relocation model in LTO (authored by phosek).
[ELF] Support explicitly overriding relocation model in LTO
Jul 20 2019, 3:00 PM
phosek committed rL366644: [ELF] Support explicitly overriding relocation model in LTO.
[ELF] Support explicitly overriding relocation model in LTO
Jul 20 2019, 3:00 PM
phosek updated the diff for D65032: [ELF] Support explicitly overriding relocation model in LTO.
Jul 20 2019, 3:00 PM · Restricted Project

Jul 19 2019

phosek created D65032: [ELF] Support explicitly overriding relocation model in LTO.
Jul 19 2019, 5:49 PM · Restricted Project
phosek created D65029: [Driver] Support for disabling sanitizer runtime linking.
Jul 19 2019, 4:37 PM · Restricted Project, Restricted Project
phosek updated the diff for D64979: [libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails.

Test added, would it be possible to take a look?

Jul 19 2019, 4:10 PM · Restricted Project
phosek updated the diff for D64971: [SafeStack] Insert the deref after the offset.

I've moved the deref after the offset calculation, tested this against our build and it's producing the expected DWARF output.

Jul 19 2019, 12:10 PM · Restricted Project