Page MenuHomePhabricator
Feed Advanced Search

Mon, Jun 17

phosek accepted D63449: [GN] Generation failure caused by trailing space in file name.

LGTM

Mon, Jun 17, 2:52 PM · Restricted Project

Sun, Jun 16

phosek added inline comments to D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect..
Sun, Jun 16, 10:19 PM · Restricted Project, Restricted Project

Fri, Jun 14

phosek accepted D63210: gn build: Add NVPTX target.

Since you always include all three of //llvm/lib/Target/targets.gni, //llvm/lib/Target/targets_with_asm_parsers.gni, //llvm/lib/Target/targets_with_disassemblers.gni, why not just combine all of them into //llvm/lib/Target/targets.gni? If we ever need them separately and performance becomes an issue, we can split them later.

Fri, Jun 14, 10:45 AM · Restricted Project
phosek accepted D63200: gn build: Simplify Target build files.

LGTM

Fri, Jun 14, 10:42 AM · Restricted Project

Thu, Jun 13

phosek added a comment to D61697: [lit] Disable test on darwin when building shared libs..

This broke all our macOS builders:

llvm-lit: /b/s/w/ir/k/llvm-project/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/b/s/w/ir/k/recipe_cleanup/clangh7IvHV/llvm_build_dir/tools/lld/test/lit.site.cfg.py', traceback: Traceback (most recent call last):
  File "/b/s/w/ir/k/llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "/b/s/w/ir/k/recipe_cleanup/clangh7IvHV/llvm_build_dir/tools/lld/test/lit.site.cfg.py", line 31, in <module>
    lit.llvm.initialize(lit_config, config)
  File "/b/s/w/ir/k/llvm-project/llvm/utils/lit/lit/llvm/__init__.py", line 9, in initialize
    llvm_config = config.LLVMConfig(lit_config, test_config)
  File "/b/s/w/ir/k/llvm-project/llvm/utils/lit/lit/llvm/config.py", line 51, in __init__
    if config.enable_shared:
AttributeError: TestingConfig instance has no attribute 'enable_shared'

The problem is that enable_shared isn't defined in lld's lit.site.cfg.py. Is it possible to either fix this or revert this change?

Thu, Jun 13, 4:56 PM · Restricted Project, Restricted Project

Wed, Jun 12

phosek planned changes to D63092: [Frontend] Use executable path when creating invocation from cmdline.
Wed, Jun 12, 12:14 AM · Restricted Project

Tue, Jun 11

phosek added a reviewer for D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect.: phosek.
Tue, Jun 11, 5:24 PM · Restricted Project, Restricted Project

Mon, Jun 10

phosek accepted D63107: Setup testing target dependencies for default runtimes.

LGTM

Mon, Jun 10, 5:08 PM · Restricted Project
phosek added a comment to D63092: [Frontend] Use executable path when creating invocation from cmdline.

One more thing, do you think it's reasonable to use llvm::sys::findProgramByName(Args[0])instead of Args[0] when creating the driver instance? One of the failure modes I ran into is the case where the generated compilation database would contain just the executable name, e.g. clang++. If you invoke that command, everything works as expected because driver resolves the binary to a full path, but when used with clangd, it'll fail because that resolution will never happen, the Dir/InstalledDir will be an empty path and attempt to resolve C++ library headers will end up with /../include/c++/v1 which is invalid.

Mon, Jun 10, 2:53 PM · Restricted Project
phosek added a comment to D63092: [Frontend] Use executable path when creating invocation from cmdline.

argv[0] does carry important information though, I think this will break a lot of things. It's... concerning that no tests broke.

For example, if it's clang or g++ or clang-cl then that affects how command lines are parsed (regardless of whether the path actually exists).

Mon, Jun 10, 2:37 PM · Restricted Project
phosek created D63092: [Frontend] Use executable path when creating invocation from cmdline.
Mon, Jun 10, 1:05 PM · Restricted Project

Wed, Jun 5

phosek committed rG2f94203e23de: Revert "[AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is… (authored by phosek).
Revert "[AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is…
Wed, Jun 5, 3:27 PM
phosek committed rL362662: Revert "[AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is….
Revert "[AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is…
Wed, Jun 5, 3:24 PM
phosek added a comment to D62695: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp.

This seems to have introduced PR42129.

Wed, Jun 5, 1:50 PM · Restricted Project

Tue, Jun 4

phosek committed rG9d8d0f68fbc3: [CMake][Fuchsia] Use libc++ ABIv2 for the first stage build (authored by phosek).
[CMake][Fuchsia] Use libc++ ABIv2 for the first stage build
Tue, Jun 4, 11:57 PM
phosek committed rL362585: [CMake][Fuchsia] Use libc++ ABIv2 for the first stage build.
[CMake][Fuchsia] Use libc++ ABIv2 for the first stage build
Tue, Jun 4, 11:57 PM
phosek added a comment to D62695: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp.

This seems to have introduced PR42129.

Tue, Jun 4, 8:25 PM · Restricted Project
phosek committed rG516e6cc1dd94: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3 (authored by phosek).
[Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3
Tue, Jun 4, 8:15 PM
phosek committed rL362580: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3.
[Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3
Tue, Jun 4, 8:15 PM
phosek closed D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3.
Tue, Jun 4, 8:14 PM · Restricted Project, Restricted Project
phosek added reviewers for D53379: GSYM symbolication format: jakehehrlich, phosek.
Tue, Jun 4, 7:48 PM

Mon, Jun 3

phosek committed rGd2d6c17760d5: [builtins] Use libtool for builtins when building for Apple platform (authored by phosek).
[builtins] Use libtool for builtins when building for Apple platform
Mon, Jun 3, 7:38 PM
phosek committed rL362466: [builtins] Use libtool for builtins when building for Apple platform.
[builtins] Use libtool for builtins when building for Apple platform
Mon, Jun 3, 7:35 PM
phosek closed D62820: [builtins] Use libtool for builtins when building for Apple platform.
Mon, Jun 3, 7:35 PM · Restricted Project, Restricted Project
phosek added a comment to D61583: [ELF] Create Undefined for local STT_SECTION symbol if the section is discarded.

https://storage.googleapis.com/fuchsia-build/reproducer/fuzzer.tar.bz2 is the reproducer.

Mon, Jun 3, 7:10 PM · Restricted Project
phosek added a comment to D61583: [ELF] Create Undefined for local STT_SECTION symbol if the section is discarded.

We're now getting a lot of STT_SECTION symbol should be defined warnings when building libFuzzer: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8911634509805270864/+/steps/clang/0/steps/build/0/stdout. The libFuzzer uses lld to produce a single relocatable file with libc++ linked in: https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/fuzzer/CMakeLists.txt#L132. I haven't yet figured out what's going on (the warning could be also a little more specific, e.g. which symbol and which section). Do you have any idea what's going on?

Mon, Jun 3, 4:48 PM · Restricted Project
phosek created D62820: [builtins] Use libtool for builtins when building for Apple platform.
Mon, Jun 3, 12:28 PM · Restricted Project, Restricted Project

Sat, Jun 1

phosek committed rG84254dd8abb2: [CMake] Use libtool for runtimes when building for Apple platform (authored by phosek).
[CMake] Use libtool for runtimes when building for Apple platform
Sat, Jun 1, 7:04 PM
phosek committed rL362313: [CMake] Use libtool for runtimes when building for Apple platform.
[CMake] Use libtool for runtimes when building for Apple platform
Sat, Jun 1, 7:04 PM
phosek closed D62769: [CMake] Use libtool for runtimes when building for Apple platform.
Sat, Jun 1, 7:04 PM · Restricted Project
phosek updated the diff for D62769: [CMake] Use libtool for runtimes when building for Apple platform.
Sat, Jun 1, 7:04 PM · Restricted Project
phosek committed rG737de4d363ed: [libcxx] Use libtool when merging archives on Apple platforms (authored by phosek).
[libcxx] Use libtool when merging archives on Apple platforms
Sat, Jun 1, 6:15 PM
phosek committed rL362311: [libcxx] Use libtool when merging archives on Apple platforms.
[libcxx] Use libtool when merging archives on Apple platforms
Sat, Jun 1, 6:14 PM
phosek closed D62770: [libcxx] Use libtool when merging archives on Apple platforms.
Sat, Jun 1, 6:14 PM · Restricted Project

Fri, May 31

phosek created D62770: [libcxx] Use libtool when merging archives on Apple platforms.
Fri, May 31, 11:33 PM · Restricted Project
phosek created D62769: [CMake] Use libtool for runtimes when building for Apple platform.
Fri, May 31, 11:33 PM · Restricted Project

Thu, May 30

phosek committed rG2ab7af29c6ca: [CMake] Provide an option to use relative paths in debug info (authored by phosek).
[CMake] Provide an option to use relative paths in debug info
Thu, May 30, 6:33 PM
phosek committed rL362185: [CMake] Provide an option to use relative paths in debug info.
[CMake] Provide an option to use relative paths in debug info
Thu, May 30, 6:32 PM
phosek closed D62622: [CMake] Provide an option to use relative paths in debug info.
Thu, May 30, 6:32 PM · debug-info, Restricted Project, Restricted Project
phosek committed rGa35c50c9a4d1: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well (authored by phosek).
[CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
Thu, May 30, 6:15 PM
phosek committed rL362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well.
[CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
Thu, May 30, 6:15 PM
phosek closed D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well.
Thu, May 30, 6:15 PM · Restricted Project, Restricted Project
phosek created D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well.
Thu, May 30, 6:10 PM · Restricted Project, Restricted Project
phosek added a comment to D62622: [CMake] Provide an option to use relative paths in debug info.

I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO.

Thu, May 30, 2:55 PM · debug-info, Restricted Project, Restricted Project
phosek updated the diff for D62622: [CMake] Provide an option to use relative paths in debug info.
Thu, May 30, 2:55 PM · debug-info, Restricted Project, Restricted Project
phosek committed rG433a19168379: [CMake] Use find_package(LLVM) instead of LLVMConfig (authored by phosek).
[CMake] Use find_package(LLVM) instead of LLVMConfig
Thu, May 30, 12:35 AM
phosek committed rUNW362065: [CMake] Use find_package(LLVM) instead of LLVMConfig.
[CMake] Use find_package(LLVM) instead of LLVMConfig
Thu, May 30, 12:35 AM
phosek committed rL362065: [CMake] Use find_package(LLVM) instead of LLVMConfig.
[CMake] Use find_package(LLVM) instead of LLVMConfig
Thu, May 30, 12:35 AM
phosek closed D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Thu, May 30, 12:35 AM · Restricted Project, Restricted Project
phosek updated the diff for D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Thu, May 30, 12:30 AM · Restricted Project, Restricted Project
phosek added inline comments to D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Thu, May 30, 12:30 AM · Restricted Project, Restricted Project
phosek added inline comments to D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Thu, May 30, 12:12 AM · Restricted Project, Restricted Project
phosek updated the diff for D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Thu, May 30, 12:12 AM · Restricted Project, Restricted Project

Wed, May 29

phosek committed rGb19977d5afbf: [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files (authored by phosek).
[runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files
Wed, May 29, 11:55 PM
phosek committed rCXX362061: [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files.
[runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files
Wed, May 29, 11:55 PM
phosek committed rL362061: [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files.
[runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files
Wed, May 29, 11:55 PM
phosek added a reviewer for D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig: smeenai.
Wed, May 29, 11:34 PM · Restricted Project, Restricted Project
phosek committed rG0528726a69c2: [libcxx][libcxxabi] Remove the unused CMake checks (authored by phosek).
[libcxx][libcxxabi] Remove the unused CMake checks
Wed, May 29, 11:10 PM
phosek committed rL362058: [libcxx][libcxxabi] Remove the unused CMake checks.
[libcxx][libcxxabi] Remove the unused CMake checks
Wed, May 29, 11:10 PM
phosek committed rCXX362058: [libcxx][libcxxabi] Remove the unused CMake checks.
[libcxx][libcxxabi] Remove the unused CMake checks
Wed, May 29, 11:10 PM
phosek committed rCXXA362058: [libcxx][libcxxabi] Remove the unused CMake checks.
[libcxx][libcxxabi] Remove the unused CMake checks
Wed, May 29, 11:10 PM
phosek closed D62566: [libcxx][libcxxabi] Remove the unused CMake checks.
Wed, May 29, 11:10 PM · Restricted Project
phosek committed rGf1ddf431b5dd: [runtimes] Use -Wunknown-pragmas for the pragma check (authored by phosek).
[runtimes] Use -Wunknown-pragmas for the pragma check
Wed, May 29, 10:38 PM
phosek committed rCXX362057: [runtimes] Use -Wunknown-pragmas for the pragma check.
[runtimes] Use -Wunknown-pragmas for the pragma check
Wed, May 29, 10:38 PM
phosek committed rL362057: [runtimes] Use -Wunknown-pragmas for the pragma check.
[runtimes] Use -Wunknown-pragmas for the pragma check
Wed, May 29, 10:38 PM
phosek committed rCXXA362057: [runtimes] Use -Wunknown-pragmas for the pragma check.
[runtimes] Use -Wunknown-pragmas for the pragma check
Wed, May 29, 10:38 PM
phosek committed rUNW362057: [runtimes] Use -Wunknown-pragmas for the pragma check.
[runtimes] Use -Wunknown-pragmas for the pragma check
Wed, May 29, 10:38 PM
phosek committed rG789b7f0828b0: [runtimes] Check if pragma comment(lib, ...) is supported first (authored by phosek).
[runtimes] Check if pragma comment(lib, ...) is supported first
Wed, May 29, 9:40 PM
phosek committed rCXX362055: [runtimes] Check if pragma comment(lib, ...) is supported first.
[runtimes] Check if pragma comment(lib, ...) is supported first
Wed, May 29, 9:40 PM
phosek committed rCXXA362055: [runtimes] Check if pragma comment(lib, ...) is supported first.
[runtimes] Check if pragma comment(lib, ...) is supported first
Wed, May 29, 9:39 PM
phosek committed rUNW362055: [runtimes] Check if pragma comment(lib, ...) is supported first.
[runtimes] Check if pragma comment(lib, ...) is supported first
Wed, May 29, 9:39 PM
phosek committed rL362055: [runtimes] Check if pragma comment(lib, ...) is supported first.
[runtimes] Check if pragma comment(lib, ...) is supported first
Wed, May 29, 9:39 PM
phosek added a comment to D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.

I've tested this locally and it seems to be working fine, I'd like to land this to unbreak our bots.

Wed, May 29, 9:26 PM · Restricted Project, Restricted Project
phosek retitled D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig from [CMake] Pass LLVM_BINARY_DIR to runtimes build to [CMake] Use find_package(LLVM) instead of LLVMConfig.
Wed, May 29, 8:08 PM · Restricted Project, Restricted Project
phosek updated the diff for D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Wed, May 29, 8:08 PM · Restricted Project, Restricted Project
phosek updated the diff for D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Wed, May 29, 7:30 PM · Restricted Project, Restricted Project
phosek created D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Wed, May 29, 7:25 PM · Restricted Project, Restricted Project
phosek committed rCXXA362048: [runtimes] Support ELF dependent libraries feature.
[runtimes] Support ELF dependent libraries feature
Wed, May 29, 6:36 PM
phosek committed rG996e62eef750: [runtimes] Support ELF dependent libraries feature (authored by phosek).
[runtimes] Support ELF dependent libraries feature
Wed, May 29, 6:36 PM
phosek committed rUNW362048: [runtimes] Support ELF dependent libraries feature.
[runtimes] Support ELF dependent libraries feature
Wed, May 29, 6:36 PM
phosek committed rCXX362048: [runtimes] Support ELF dependent libraries feature.
[runtimes] Support ELF dependent libraries feature
Wed, May 29, 6:36 PM
phosek committed rL362048: [runtimes] Support ELF dependent libraries feature.
[runtimes] Support ELF dependent libraries feature
Wed, May 29, 6:36 PM
phosek closed D62090: [runtimes] Support ELF dependent libraries feature.
Wed, May 29, 6:36 PM · Restricted Project
phosek added a comment to D62622: [CMake] Provide an option to use relative paths in debug info.

-DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false impression. Is there a name that emphasizes that this affects the debug info of the built compiler?

Wed, May 29, 6:36 PM · debug-info, Restricted Project, Restricted Project
phosek committed rG7e041d6dac74: [CMake] Set LLVM_PATH in the runtimes build (authored by phosek).
[CMake] Set LLVM_PATH in the runtimes build
Wed, May 29, 6:25 PM
phosek committed rL362047: [CMake] Set LLVM_PATH in the runtimes build.
[CMake] Set LLVM_PATH in the runtimes build
Wed, May 29, 6:21 PM
phosek closed D62637: [CMake] Set LLVM_PATH in the runtimes build.
Wed, May 29, 6:21 PM · Restricted Project
phosek created D62637: [CMake] Set LLVM_PATH in the runtimes build.
Wed, May 29, 6:03 PM · Restricted Project
phosek updated the diff for D62622: [CMake] Provide an option to use relative paths in debug info.
Wed, May 29, 2:49 PM · debug-info, Restricted Project, Restricted Project
phosek created D62622: [CMake] Provide an option to use relative paths in debug info.
Wed, May 29, 1:00 PM · debug-info, Restricted Project, Restricted Project
phosek added a comment to D62566: [libcxx][libcxxabi] Remove the unused CMake checks.

Does anyone have any opinion on add_compile_flags_if_supported vs check_cxx_compiler_flag + append_if? If not I'm going to land this as is.

Wed, May 29, 11:47 AM · Restricted Project
phosek updated the diff for D62090: [runtimes] Support ELF dependent libraries feature.
Wed, May 29, 11:47 AM · Restricted Project
phosek added a comment to D62090: [runtimes] Support ELF dependent libraries feature.

It's not entirely clear to me that adding an option to control this is better than just doing it unconditionally. Have you run into a scenario where you didn't want to enable it (and if so, why?).

If that's "just in case", I'd suggest doing it unconditionally and adding an option later if a vendor wants to disable it.

Wed, May 29, 11:47 AM · Restricted Project
phosek accepted D62508: gn build: Make it possible to build with coverage information.

LGTM

Wed, May 29, 11:37 AM · Restricted Project
phosek added inline comments to D62566: [libcxx][libcxxabi] Remove the unused CMake checks.
Wed, May 29, 8:38 AM · Restricted Project

Tue, May 28

phosek added a comment to D62566: [libcxx][libcxxabi] Remove the unused CMake checks.

Alternative would be to avoid add_compile_flags_if_supported altogether and instead the combination of check_cxx_compiler_flag and append_if as is used in libunwind (https://github.com/llvm/llvm-project/blob/master/libunwind/CMakeLists.txt#L274). The advantage of the latter is that we could in theory have different config-ix.cmake files (e.g. pre-populated ones for the runtimes build).

Tue, May 28, 10:45 PM · Restricted Project
phosek created D62566: [libcxx][libcxxabi] Remove the unused CMake checks.
Tue, May 28, 8:27 PM · Restricted Project
phosek retitled D62090: [runtimes] Support ELF dependent libraries feature from [runtimes] Support ELF dependent libraries feature on Linux to [runtimes] Support ELF dependent libraries feature.
Tue, May 28, 7:48 PM · Restricted Project
phosek updated the diff for D62090: [runtimes] Support ELF dependent libraries feature.
Tue, May 28, 7:48 PM · Restricted Project
phosek committed rG529118fc87c0: [builtins] Move the compare2f definition outside of the macro (authored by phosek).
[builtins] Move the compare2f definition outside of the macro
Tue, May 28, 6:54 PM