Page MenuHomePhabricator
Feed Advanced Search

Today

Peiming committed rG54ac02dd16c8: [mlir][sparse] fix crashes when generation conv_2d_nchw_fchw with Compressed… (authored by Peiming).
[mlir][sparse] fix crashes when generation conv_2d_nchw_fchw with Compressed…
Wed, May 31, 11:06 AM · Restricted Project, Restricted Project
Peiming closed D151773: [mlir][sparse] fix crashes when generation conv_2d_nchw_fchw with Compressed Dense Compressed Dense sparse encoding..
Wed, May 31, 11:06 AM · Restricted Project, Restricted Project
Peiming updated the diff for D151773: [mlir][sparse] fix crashes when generation conv_2d_nchw_fchw with Compressed Dense Compressed Dense sparse encoding..

address comments.

Wed, May 31, 11:04 AM · Restricted Project, Restricted Project
Peiming added inline comments to D151592: [mlir][sparse][gpu] add result type to spmv, spmm and sddmm gpu libgen path.
Wed, May 31, 9:00 AM · Restricted Project, Restricted Project

Yesterday

Peiming planned changes to D151776: [draft] sparse pooling.
Tue, May 30, 9:54 PM · Restricted Project, Restricted Project
Peiming requested review of D151776: [draft] sparse pooling.
Tue, May 30, 9:53 PM · Restricted Project, Restricted Project
Peiming added reviewers for D151773: [mlir][sparse] fix crashes when generation conv_2d_nchw_fchw with Compressed Dense Compressed Dense sparse encoding.: wrengr, bixia.
Tue, May 30, 8:45 PM · Restricted Project, Restricted Project
Peiming requested review of D151773: [mlir][sparse] fix crashes when generation conv_2d_nchw_fchw with Compressed Dense Compressed Dense sparse encoding..
Tue, May 30, 8:45 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151505: [mlir][sparse] Combining `dimOrdering`+`higherOrdering` fields into `dimToLvl`.
Tue, May 30, 1:49 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151592: [mlir][sparse][gpu] add result type to spmv, spmm and sddmm gpu libgen path.
Tue, May 30, 1:19 PM · Restricted Project, Restricted Project
Peiming committed rGdb7f639b900d: [mlir][sparse] fix a crash when generating sparse convolution with nchw input (authored by Peiming).
[mlir][sparse] fix a crash when generating sparse convolution with nchw input
Tue, May 30, 1:17 PM · Restricted Project, Restricted Project
Peiming closed D151744: [mlir][sparse] fix a crash when generating sparse convolution with nchw input.
Tue, May 30, 1:17 PM · Restricted Project, Restricted Project
Peiming updated the diff for D151744: [mlir][sparse] fix a crash when generating sparse convolution with nchw input.

address comments

Tue, May 30, 1:04 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151592: [mlir][sparse][gpu] add result type to spmv, spmm and sddmm gpu libgen path.
Tue, May 30, 1:00 PM · Restricted Project, Restricted Project
Peiming added reviewers for D151744: [mlir][sparse] fix a crash when generating sparse convolution with nchw input: wrengr, bixia.
Tue, May 30, 12:04 PM · Restricted Project, Restricted Project
Peiming requested review of D151744: [mlir][sparse] fix a crash when generating sparse convolution with nchw input.
Tue, May 30, 12:02 PM · Restricted Project, Restricted Project

Fri, May 26

Peiming added inline comments to D151279: [mlir][gpu][sparse] adding initial cusparse sddmm libgen support.
Fri, May 26, 1:31 PM · Restricted Project, Restricted Project
Peiming accepted D151574: [mlir][sparse][gpu] fix merge conflict.
Fri, May 26, 10:58 AM · Restricted Project, Restricted Project

Thu, May 25

Peiming accepted D151518: [mlir][sparse] Adding new STEA::{with,without}DimSlices factories.
Thu, May 25, 5:08 PM · Restricted Project, Restricted Project
Peiming accepted D151522: [mlir][sparse] Removing unused helper function.
Thu, May 25, 5:07 PM · Restricted Project, Restricted Project
Peiming accepted D151513: [mlir][sparse] Updating STEA parser/printer to use the name "dimSlices".
Thu, May 25, 3:55 PM · Restricted Project, Restricted Project
Peiming committed rGf7b8b005ff12: [mlir][sparse] fix bugs when computing the memory size when lowering pack op. (authored by Peiming).
[mlir][sparse] fix bugs when computing the memory size when lowering pack op.
Thu, May 25, 12:20 PM · Restricted Project, Restricted Project
Peiming closed D151481: [mlir][sparse] fix bugs when computing the memory size when lowering pack op..
Thu, May 25, 12:20 PM · Restricted Project, Restricted Project
Peiming updated the diff for D151481: [mlir][sparse] fix bugs when computing the memory size when lowering pack op..

fix check tests.

Thu, May 25, 11:49 AM · Restricted Project, Restricted Project
Peiming updated the diff for D151481: [mlir][sparse] fix bugs when computing the memory size when lowering pack op..

fix check tests.

Thu, May 25, 11:45 AM · Restricted Project, Restricted Project
Peiming requested review of D151481: [mlir][sparse] fix bugs when computing the memory size when lowering pack op..
Thu, May 25, 11:35 AM · Restricted Project, Restricted Project

Tue, May 23

Peiming accepted D151255: [mlir][sparse][gpu] fix F32 bug for SpMV and SpMM.
Tue, May 23, 4:07 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151255: [mlir][sparse][gpu] fix F32 bug for SpMV and SpMM.
Tue, May 23, 4:07 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151255: [mlir][sparse][gpu] fix F32 bug for SpMV and SpMM.
Tue, May 23, 4:04 PM · Restricted Project, Restricted Project
Peiming committed rGb2e6b7354452: [mlir][sparse] extend unpack operation to unpack arbitrary encodings. (authored by Peiming).
[mlir][sparse] extend unpack operation to unpack arbitrary encodings.
Tue, May 23, 3:34 PM · Restricted Project, Restricted Project
Peiming closed D151174: [mlir][sparse] extend unpack operation to unpack arbitrary encodings..
Tue, May 23, 3:34 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151255: [mlir][sparse][gpu] fix F32 bug for SpMV and SpMM.
Tue, May 23, 2:34 PM · Restricted Project, Restricted Project
Peiming updated the diff for D151174: [mlir][sparse] extend unpack operation to unpack arbitrary encodings..

address comments.

Tue, May 23, 2:32 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151174: [mlir][sparse] extend unpack operation to unpack arbitrary encodings..
Tue, May 23, 2:27 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151014: [mlir] [gpu] [sparse] refined SparseHandle type.
Tue, May 23, 2:05 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151255: [mlir][sparse][gpu] fix F32 bug for SpMV and SpMM.
Tue, May 23, 1:55 PM · Restricted Project, Restricted Project
Peiming updated the diff for D151174: [mlir][sparse] extend unpack operation to unpack arbitrary encodings..

revert unintended changes.

Tue, May 23, 11:58 AM · Restricted Project, Restricted Project
Peiming updated the diff for D151174: [mlir][sparse] extend unpack operation to unpack arbitrary encodings..

update docs.

Tue, May 23, 11:51 AM · Restricted Project, Restricted Project
Peiming added reviewers for D151174: [mlir][sparse] extend unpack operation to unpack arbitrary encodings.: bixia, wrengr.
Tue, May 23, 11:39 AM · Restricted Project, Restricted Project

Mon, May 22

Peiming requested review of D151174: [mlir][sparse] extend unpack operation to unpack arbitrary encodings..
Mon, May 22, 5:29 PM · Restricted Project, Restricted Project
Peiming added a comment to D150061: [mlir][sparse] Use incremental topological sort to compute loop order from iteration graph.

Relax constraints for dense tensors so that we only require the innermost dimension to be last. As far as I can tell, there is no need to have a specific ordering between dimensions otherwise.

Mon, May 22, 10:41 AM · Restricted Project, Restricted Project
Peiming closed D151114: [mlir][sparse] fix document format.
Mon, May 22, 9:33 AM · Restricted Project, Restricted Project
Peiming committed rGf396f30a010b: [mlir][sparse] fix document format (authored by Peiming).
[mlir][sparse] fix document format
Mon, May 22, 9:31 AM · Restricted Project, Restricted Project
Peiming closed D151114: [mlir][sparse] fix document format.
Mon, May 22, 9:31 AM · Restricted Project, Restricted Project
Peiming added reviewers for D151114: [mlir][sparse] fix document format: bixia, wrengr.
Mon, May 22, 9:09 AM · Restricted Project, Restricted Project
Peiming requested review of D151114: [mlir][sparse] fix document format.
Mon, May 22, 9:01 AM · Restricted Project, Restricted Project

Fri, May 19

Peiming accepted D150715: [mlir][sparse][gpu] recognize SpMM cuSparse during sparsification.
Fri, May 19, 5:21 PM · Restricted Project, Restricted Project
Peiming accepted D151005: [mlir][sparse][gpu] derive type of cuSparse op.
Fri, May 19, 5:01 PM · Restricted Project, Restricted Project
Peiming added inline comments to D151005: [mlir][sparse][gpu] derive type of cuSparse op.
Fri, May 19, 4:22 PM · Restricted Project, Restricted Project
Peiming committed rGde56088866be: [mlir][sparse] Support packing external data into arbitrary sparse tensor… (authored by Peiming).
[mlir][sparse] Support packing external data into arbitrary sparse tensor…
Fri, May 19, 10:42 AM · Restricted Project, Restricted Project
Peiming closed D150916: [mlir][sparse] Support packing external data into arbitrary sparse tensor encoding..
Fri, May 19, 10:41 AM · Restricted Project, Restricted Project
Peiming added inline comments to D150919: [mlir][sparse] Improving SparseTensorDimSliceAttr methods.
Fri, May 19, 8:44 AM · Restricted Project, Restricted Project

Thu, May 18

Peiming added inline comments to D150919: [mlir][sparse] Improving SparseTensorDimSliceAttr methods.
Thu, May 18, 5:24 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150916: [mlir][sparse] Support packing external data into arbitrary sparse tensor encoding..

address comments.

Thu, May 18, 5:03 PM · Restricted Project, Restricted Project
Peiming added inline comments to D150916: [mlir][sparse] Support packing external data into arbitrary sparse tensor encoding..
Thu, May 18, 4:57 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150916: [mlir][sparse] Support packing external data into arbitrary sparse tensor encoding..

address comments.

Thu, May 18, 4:56 PM · Restricted Project, Restricted Project
Peiming accepted D150917: [mlir][sparse] Adding SparseTensorEncodingAttr::getDimSlice.
Thu, May 18, 4:22 PM · Restricted Project, Restricted Project
Peiming added reviewers for D150916: [mlir][sparse] Support packing external data into arbitrary sparse tensor encoding.: wrengr, bixia.
Thu, May 18, 3:56 PM · Restricted Project, Restricted Project
Peiming requested review of D150916: [mlir][sparse] Support packing external data into arbitrary sparse tensor encoding..
Thu, May 18, 3:54 PM · Restricted Project, Restricted Project
Peiming committed rGafe78db7701d: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available. (authored by Peiming).
[mlir][sparse] Make sparse_tensor::StorageLayout publicly available.
Thu, May 18, 1:30 PM · Restricted Project, Restricted Project
Peiming closed D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..
Thu, May 18, 1:29 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

rebase.

Thu, May 18, 12:53 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

address comments.

Thu, May 18, 12:51 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

address comments.

Thu, May 18, 10:35 AM · Restricted Project, Restricted Project

Wed, May 17

Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

rebase and address comments.

Wed, May 17, 9:02 PM · Restricted Project, Restricted Project
Peiming added inline comments to D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..
Wed, May 17, 9:01 PM · Restricted Project, Restricted Project
Peiming accepted D150815: [mlir][sparse] Calling `SparseTensorType::get{Pos,Crd}Type` directly.
Wed, May 17, 2:23 PM · Restricted Project, Restricted Project
Peiming added reviewers for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available.: wrengr, bixia.
Wed, May 17, 2:20 PM · Restricted Project, Restricted Project

Tue, May 16

Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

remove outdated files.

Tue, May 16, 5:11 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

minor fixes.

Tue, May 16, 5:07 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

update bazel file

Tue, May 16, 5:05 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

revert unintended changes.

Tue, May 16, 5:03 PM · Restricted Project, Restricted Project
Peiming updated the diff for D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..

rebase.

Tue, May 16, 4:53 PM · Restricted Project, Restricted Project
Peiming requested review of D150739: [mlir][sparse] Make sparse_tensor::StorageLayout publicly available..
Tue, May 16, 4:52 PM · Restricted Project, Restricted Project
Peiming committed rGad469385ab37: [mlir][sparse] Add a helper class to help lowering operations with/without… (authored by Peiming).
[mlir][sparse] Add a helper class to help lowering operations with/without…
Tue, May 16, 10:23 AM · Restricted Project, Restricted Project
Peiming closed D150477: [mlir][sparse] Add a helper class to help lowering operations with/without function calls.
Tue, May 16, 10:22 AM · Restricted Project, Restricted Project
Peiming updated the diff for D150477: [mlir][sparse] Add a helper class to help lowering operations with/without function calls.

address comments.

Tue, May 16, 10:08 AM · Restricted Project, Restricted Project
Peiming accepted D150692: [mlir][sparse][gpu] set cubin flag when building for cuda.
Tue, May 16, 10:05 AM · Restricted Project, Restricted Project
Peiming updated the diff for D150477: [mlir][sparse] Add a helper class to help lowering operations with/without function calls.

align changes.

Tue, May 16, 9:04 AM · Restricted Project, Restricted Project
Peiming updated the diff for D150477: [mlir][sparse] Add a helper class to help lowering operations with/without function calls.

address comments.

Tue, May 16, 9:03 AM · Restricted Project, Restricted Project

Mon, May 15

Peiming accepted D150628: [mlir][sparse] change runners to c_runners.
Mon, May 15, 6:00 PM · Restricted Project, Restricted Project
Peiming accepted D150172: [mlir][sparse][gpu] end-to-end integration test of GPU libgen approach.
Mon, May 15, 10:54 AM · Restricted Project, Restricted Project

Fri, May 12

Peiming added inline comments to D150170: [mlir][sparse][gpu] first implementation of the GPU libgen approach.
Fri, May 12, 3:23 PM · Restricted Project, Restricted Project
Peiming added reviewers for D150477: [mlir][sparse] Add a helper class to help lowering operations with/without function calls: bixia, anlunx, wrengr.
Fri, May 12, 1:35 PM · Restricted Project, Restricted Project
Peiming requested review of D150477: [mlir][sparse] Add a helper class to help lowering operations with/without function calls.
Fri, May 12, 1:34 PM · Restricted Project, Restricted Project

Thu, May 11

Peiming accepted D150414: [mlir][sparse] minor reorg of sparse tensor tablegen defs.
Thu, May 11, 8:27 PM · Restricted Project, Restricted Project
Peiming committed rG2c2a15dd97fe: [bazel] fix bazel (authored by Peiming).
[bazel] fix bazel
Thu, May 11, 3:35 PM · Restricted Project
Peiming closed D150405: [bazel] fix bazel.
Thu, May 11, 3:34 PM · Restricted Project, Restricted Project
Peiming requested review of D150405: [bazel] fix bazel.
Thu, May 11, 3:31 PM · Restricted Project, Restricted Project
Peiming accepted D150382: [mlir][sparse] add util for ToCoordinatesBuffer for COO AoS.
Thu, May 11, 10:09 AM · Restricted Project, Restricted Project

Thu, May 4

Peiming committed rG0e1429add57f: [mlir][sparse] fix build error. (authored by Peiming).
[mlir][sparse] fix build error.
Thu, May 4, 10:30 AM · Restricted Project, Restricted Project
Peiming closed D149874: [mlir][sparse] fix build error..
Thu, May 4, 10:30 AM · Restricted Project, Restricted Project
Peiming added a comment to D149874: [mlir][sparse] fix build error..

Thank you. Would you please also fix issue in another file: https://reviews.llvm.org/D148565#inline-1447882?

nit: I think this is not Windows-specific

Thu, May 4, 10:28 AM · Restricted Project, Restricted Project
Peiming retitled D149874: [mlir][sparse] fix build error. from [mlir][sparse] fix windows build error. to [mlir][sparse] fix build error..
Thu, May 4, 10:28 AM · Restricted Project, Restricted Project
Peiming updated the diff for D149874: [mlir][sparse] fix build error..

fix more

Thu, May 4, 10:28 AM · Restricted Project, Restricted Project
Peiming added reviewers for D149874: [mlir][sparse] fix build error.: vzakhari, chaitanyav.
Thu, May 4, 10:23 AM · Restricted Project, Restricted Project
Peiming added a comment to D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.

Hi @Peiming, the buildbots are failing (e.g. https://lab.llvm.org/buildbot/#/builders/160/builds/19165) - could you please fix it?

Yeah, I saw it. but the warning seems to be unrelated to this change... I will take a look

Thu, May 4, 10:21 AM · Restricted Project, Restricted Project
Peiming requested review of D149874: [mlir][sparse] fix build error..
Thu, May 4, 10:21 AM · Restricted Project, Restricted Project
Peiming added a comment to D148565: [mlir][sparse] group tensor id and levels into pairs in loop emitter.

@Peiming can you please check, the build is failing. Pasting the link to premerge-check https://buildkite.com/llvm-project/premerge-checks/builds/150384#0187e78d-a047-440e-9018-0eecabff91c8

In file included from /home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.h:17,
                 from /home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp:13:
/home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h: In member function ‘constexpr mlir::sparse_tensor::TensorLevel mlir::sparse_tensor::LoopEmitter::makeTensorLevel(mlir::sparse_tensor::TensorId, mlir::sparse_tensor::Level) const’:
/home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h:199:29: error: call to non-‘constexpr’ function ‘unsigned int mlir::sparse_tensor::LoopEmitter::getNumTensors() const’
  199 |     return l * getNumTensors() + t;
      |                ~~~~~~~~~~~~~^~
/home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h:195:12: note: ‘unsigned int mlir::sparse_tensor::LoopEmitter::getNumTensors() const’ declared here
  195 |   unsigned getNumTensors() const { return tensors.size(); }
      |            ^~~~~~~~~~~~~
In file included from /usr/include/c++/11/cassert:44,
                 from /home/scratch/llvm-project/llvm/include/llvm/Support/CommandLine.h:34,
                 from /home/scratch/llvm-project/mlir/include/mlir/Pass/PassOptions.h:21,
                 from /home/scratch/llvm-project/mlir/include/mlir/Pass/PassRegistry.h:17,
                 from /home/scratch/llvm-project/mlir/include/mlir/Pass/Pass.h:13,
                 from /home/scratch/llvm-project/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.h:21,
                 from /home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.h:21,
                 from /home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp:13:
/home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.h: In member function ‘constexpr mlir::sparse_tensor::TensorLevel mlir::sparse_tensor::CodegenEnv::makeTensorLevel(mlir::sparse_tensor::TensorId, mlir::sparse_tensor::Level) const’:
/home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.h:95:37: error: call to non-‘constexpr’ function ‘unsigned int mlir::sparse_tensor::LoopEmitter::getNumTensors() const’
   95 |     assert(loopEmitter.getNumTensors() == linalgOp->getNumOperands() &&
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from /home/scratch/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.h:17
Thu, May 4, 10:18 AM · Restricted Project, Restricted Project
Peiming added a comment to D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.

@vzakhari I do not think my patch caused the error, see https://lab.llvm.org/buildbot/#/builders/160/builds/19161, there was already the same warning (but I do not know why it was not treated as errors).

Thu, May 4, 10:13 AM · Restricted Project, Restricted Project