Page MenuHomePhabricator
Feed Advanced Search

Nov 30 2021

crayroud added inline comments to D114725: [clang-format] add back tests which didn't cause a regression.
Nov 30 2021, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
crayroud added inline comments to D114725: [clang-format] add back tests which didn't cause a regression.
Nov 30 2021, 9:34 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

crayroud added inline comments to D114725: [clang-format] add back tests which didn't cause a regression.
Nov 29 2021, 11:04 AM · Restricted Project, Restricted Project, Restricted Project
crayroud added inline comments to D114696: [clang-format] regressed default behavior for operator parentheses.
Nov 29 2021, 8:38 AM · Restricted Project, Restricted Project
crayroud added inline comments to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Nov 29 2021, 8:24 AM · Restricted Project, Restricted Project

Nov 10 2021

crayroud closed D110833: [clang-format] Refactor SpaceBeforeParens to add options.

git revision: 6facafe7da59eb02e8c1519670b503efda2f4b58

Nov 10 2021, 2:42 AM · Restricted Project, Restricted Project

Nov 5 2021

crayroud added a comment to D110833: [clang-format] Refactor SpaceBeforeParens to add options.

I do not have commit access, could you please help with the push?

Nov 5 2021, 7:14 AM · Restricted Project, Restricted Project

Nov 4 2021

crayroud added a comment to D110833: [clang-format] Refactor SpaceBeforeParens to add options.

Could you please wait before to push this changes to the main branch, there is one more point I want to verify.

Nov 4 2021, 4:22 AM · Restricted Project, Restricted Project
crayroud added a comment to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Nov 4 2021, 3:57 AM · Restricted Project, Restricted Project
crayroud added a comment to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Nov 4 2021, 3:55 AM · Restricted Project, Restricted Project
crayroud updated crayroud.
Nov 4 2021, 3:15 AM
crayroud updated the diff for D110833: [clang-format] Refactor SpaceBeforeParens to add options.

Fix ordering of SpaceBeforeParensCustom options

Nov 4 2021, 1:02 AM · Restricted Project, Restricted Project

Nov 3 2021

crayroud added inline comments to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Nov 3 2021, 12:19 AM · Restricted Project, Restricted Project
crayroud updated the diff for D110833: [clang-format] Refactor SpaceBeforeParens to add options.

Reorder the options

Nov 3 2021, 12:19 AM · Restricted Project, Restricted Project

Nov 2 2021

crayroud updated the diff for D110833: [clang-format] Refactor SpaceBeforeParens to add options.

Add a release note into clang/docs/ReleaseNotes.rst

Nov 2 2021, 1:31 AM · Restricted Project, Restricted Project
crayroud added inline comments to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Nov 2 2021, 1:15 AM · Restricted Project, Restricted Project
crayroud added a comment to D110833: [clang-format] Refactor SpaceBeforeParens to add options.

I used the following command to verify my changes on multiple files. Thank you for the tip.

Nov 2 2021, 12:43 AM · Restricted Project, Restricted Project
crayroud added inline comments to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Nov 2 2021, 12:38 AM · Restricted Project, Restricted Project
crayroud updated the diff for D110833: [clang-format] Refactor SpaceBeforeParens to add options.
  • SpaceBeforeParensFlags has been renamed to SpaceBeforeParensOptions
  • All common space before parentheses are now grouped
  • More tests has been added
Nov 2 2021, 12:33 AM · Restricted Project, Restricted Project

Oct 25 2021

crayroud added inline comments to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Oct 25 2021, 3:09 AM · Restricted Project, Restricted Project

Oct 22 2021

crayroud added inline comments to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Oct 22 2021, 2:37 AM · Restricted Project, Restricted Project

Oct 21 2021

crayroud updated the diff for D110833: [clang-format] Refactor SpaceBeforeParens to add options.

This new version adds the possibility to configure space before opening parentheses independently from one another. Instead of creating a new SBPO_ mode for each combinations.

Oct 21 2021, 1:11 AM · Restricted Project, Restricted Project
crayroud retitled D110833: [clang-format] Refactor SpaceBeforeParens to add options from [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens to [clang-format] Refactor SpaceBeforeParens to add flags.
Oct 21 2021, 12:55 AM · Restricted Project, Restricted Project

Oct 5 2021

crayroud added a comment to D110833: [clang-format] Refactor SpaceBeforeParens to add options.

Thank you for your inputs. I will work on the changes and update the patch once it is ready.

Oct 5 2021, 7:48 AM · Restricted Project, Restricted Project

Oct 1 2021

crayroud added inline comments to D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Oct 1 2021, 3:12 AM · Restricted Project, Restricted Project

Sep 30 2021

crayroud requested review of D110833: [clang-format] Refactor SpaceBeforeParens to add options.
Sep 30 2021, 7:29 AM · Restricted Project, Restricted Project