Page MenuHomePhabricator
Feed Advanced Search

Thu, Jun 10

ksyx updated the diff for D103313: [RISCV][Clang] Implement support for zmmul-experimental.

add: zmmul arch string test

Thu, Jun 10, 1:05 AM · Restricted Project, Restricted Project

Fri, May 28

ksyx added inline comments to D103313: [RISCV][Clang] Implement support for zmmul-experimental.
Fri, May 28, 6:23 PM · Restricted Project, Restricted Project
ksyx added a comment to D103313: [RISCV][Clang] Implement support for zmmul-experimental.

I have took a look into ELFObjectFile.cpp but I am not sure what work I need to do there since it seems other Z* extensions are not being handled there.

Fri, May 28, 6:19 PM · Restricted Project, Restricted Project
ksyx updated the diff for D103313: [RISCV][Clang] Implement support for zmmul-experimental.
  • Move down zmmul lines to fit the ordering
  • Add Zmmul into parseDirectiveAttribute
Fri, May 28, 6:18 PM · Restricted Project, Restricted Project
ksyx updated the diff for D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

split Zmmul implementation and -mno-div implementation

Fri, May 28, 7:31 AM · Restricted Project, Restricted Project
ksyx requested review of D103313: [RISCV][Clang] Implement support for zmmul-experimental.
Fri, May 28, 6:18 AM · Restricted Project, Restricted Project

Thu, May 27

ksyx added a comment to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

Thanks for mentioning that! Now, I changed the effect of no-div option into choosing a proper extension and implemented the Zmmul subextension. Is this solution acceptable or are there anything need further changes?

It seems like the community is quickly converging on just using the ISA string with Zmmul, and not using no-div. While being compatible with the GNU tools is nice, if they are planning on dropping support for no-div soonish then we probably shouldn't add support for it. IMO, Zmmul should be a separate patch and presumably (at the moment) be gated by -menable-experimental-extensions.

Thu, May 27, 5:24 PM · Restricted Project, Restricted Project
ksyx added a comment to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

So it seems the better way to do this would definitely by adding a subextension as the spec had changed. But I'd like also to ask how will GCC deal with this option, and should we make this option an alias to turn off M extension and turn on ZMMul extension?

Regarding "turn off M extension", see Krste's comment in the PR:

I think -mno-div is OK as a compiler option, but it's meaning is for the compiler not to generate divide instructions, not to indicate what the ISA is. So for example, -mno-div should not set ELF flags in binary to indicate ISA doesn't have divide - it should simply not generate divide instructions.

Thu, May 27, 3:40 AM · Restricted Project, Restricted Project
ksyx updated the diff for D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

Implemented Zmmul subextension, and let no-div to be using this subextension instead of M itself.

Thu, May 27, 3:32 AM · Restricted Project, Restricted Project

Wed, May 26

ksyx added a comment to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

So it seems the better way to do this would definitely by adding a subextension as the spec had changed. But I'd like also to ask how will GCC deal with this option, and should we make this option an alias to turn off M extension and turn on ZMMul extension?

Wed, May 26, 5:41 PM · Restricted Project, Restricted Project

Tue, May 25

ksyx updated the diff for D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

fix: indent

Tue, May 25, 4:50 AM · Restricted Project, Restricted Project
ksyx updated the diff for D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.
  • remove redundant macro definition
  • split mul and div handling in RISCVISelLowering.cpp
  • rename no-idiv into no-div
Tue, May 25, 3:54 AM · Restricted Project, Restricted Project

Mon, May 24

ksyx updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

fix: types of immargs to better fit the proposal

Mon, May 24, 4:31 AM · Restricted Project

Sat, May 22

ksyx added a comment to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

Isn't the gcc name for this -mno-div? Should we be consistent?

Sat, May 22, 10:28 PM · Restricted Project, Restricted Project

Fri, May 21

ksyx updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

refactor: fix spaces

Fri, May 21, 4:21 AM · Restricted Project

Thu, May 20

ksyx requested review of D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.
Thu, May 20, 3:56 AM · Restricted Project, Restricted Project

May 14 2021

ksyx updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

refactor: remove redundant spaces around colons

May 14 2021, 1:11 AM · Restricted Project

May 11 2021

ksyx updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

fix: patch does not apply (retrigger ci after adding parent revision)

May 11 2021, 11:46 PM · Restricted Project
ksyx requested review of D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.
May 11 2021, 11:42 PM · Restricted Project

May 10 2021

ksyx requested review of D102151: [TableGen] Remove redundant `Error:` in msg (NFC).
May 10 2021, 12:44 AM · Restricted Project

May 5 2021

ksyx added a comment to D100179: [GVN][NFC] Refactor code and add description for GVN object.

Ping :)
Please tell me if there is anything that could be improved, thanks!

May 5 2021, 5:33 AM · Restricted Project

Apr 18 2021

ksyx added a reviewer for D100179: [GVN][NFC] Refactor code and add description for GVN object: asbirlea.
Apr 18 2021, 9:49 PM · Restricted Project

Apr 15 2021

ksyx added a comment to D100179: [GVN][NFC] Refactor code and add description for GVN object.

ping :)

Apr 15 2021, 12:57 AM · Restricted Project

Apr 11 2021

ksyx updated the diff for D100179: [GVN][NFC] Refactor code and add description for GVN object.

apply suggestions from code review.

Apr 11 2021, 6:58 PM · Restricted Project
ksyx added a comment to D100179: [GVN][NFC] Refactor code and add description for GVN object.

Just FYI, recently work on NewGVN has started again, so that's where the focus will (hopefully) be in the future.

Apr 11 2021, 5:14 PM · Restricted Project

Apr 9 2021

ksyx added a reviewer for D100179: [GVN][NFC] Refactor code and add description for GVN object: fhahn.
Apr 9 2021, 4:00 PM · Restricted Project
ksyx updated the diff for D100179: [GVN][NFC] Refactor code and add description for GVN object.

fix: clang-format failed

Apr 9 2021, 6:01 AM · Restricted Project
ksyx updated the diff for D100179: [GVN][NFC] Refactor code and add description for GVN object.

fix: unable to apply patch

Apr 9 2021, 5:35 AM · Restricted Project
ksyx requested review of D100179: [GVN][NFC] Refactor code and add description for GVN object.
Apr 9 2021, 4:44 AM · Restricted Project

Mar 31 2021

ksyx requested review of D99648: [GVN] Refactor analyzeLoadFromClobberingWrite to simplify code.
Mar 31 2021, 3:43 AM · Restricted Project

Feb 22 2021

ksyx closed D96846: [LLVM][GVN] fix a typo in comment.
Feb 22 2021, 6:53 PM · Restricted Project
ksyx committed rG4125cabce137: [GVN] Fix a typo in comment (authored by ksyx).
[GVN] Fix a typo in comment
Feb 22 2021, 6:40 PM

Feb 21 2021

ksyx added a comment to D96846: [LLVM][GVN] fix a typo in comment.

Politely ping. This is a simple fix of typo in comment.

Feb 21 2021, 6:41 PM · Restricted Project

Feb 17 2021

ksyx updated ksyx.
Feb 17 2021, 12:57 AM
ksyx requested review of D96846: [LLVM][GVN] fix a typo in comment.
Feb 17 2021, 12:50 AM · Restricted Project