Page MenuHomePhabricator
Feed Advanced Search

Jun 9 2021

jsetoain committed rG96ca2d92b52b: [mlir][ArmSVE] Add basic load/store operations (authored by jsetoain).
[mlir][ArmSVE] Add basic load/store operations
Jun 9 2021, 8:04 AM
jsetoain closed D103535: [mlir][ArmSVE] Add basic load/store operations.
Jun 9 2021, 8:04 AM · Restricted Project
jsetoain updated the diff for D103535: [mlir][ArmSVE] Add basic load/store operations.

Rebase to main and address comments

Jun 9 2021, 3:15 AM · Restricted Project
jsetoain committed rGf880bd261f4e: [mlir][ArmSVE] Add basic mask generation operations (authored by jsetoain).
[mlir][ArmSVE] Add basic mask generation operations
Jun 9 2021, 1:59 AM
jsetoain closed D103473: [mlir][ArmSVE] Add basic mask generation operation.
Jun 9 2021, 1:59 AM · Restricted Project

Jun 8 2021

jsetoain updated the diff for D103473: [mlir][ArmSVE] Add basic mask generation operation.

Fixed shared library dependency

Jun 8 2021, 3:55 AM · Restricted Project
jsetoain added a comment to D103473: [mlir][ArmSVE] Add basic mask generation operation.

Sorry it took me so long to revert, and thank you for the instructions!

Jun 8 2021, 2:09 AM · Restricted Project
jsetoain added a reverting change for rG392af6a78bb7: [mlir][ArmSVE] Add basic mask generation operations: rG57546f5b2224: Revert "[mlir][ArmSVE] Add basic mask generation operations".
Jun 8 2021, 2:03 AM
jsetoain committed rG57546f5b2224: Revert "[mlir][ArmSVE] Add basic mask generation operations" (authored by jsetoain).
Revert "[mlir][ArmSVE] Add basic mask generation operations"
Jun 8 2021, 2:03 AM
jsetoain added a reverting change for D103473: [mlir][ArmSVE] Add basic mask generation operation: rG57546f5b2224: Revert "[mlir][ArmSVE] Add basic mask generation operations".
Jun 8 2021, 2:03 AM · Restricted Project
jsetoain reopened D103473: [mlir][ArmSVE] Add basic mask generation operation.

This patch breaks mlir-nvidia, and a couple of flang-related builders:

Jun 8 2021, 1:32 AM · Restricted Project
jsetoain committed rG392af6a78bb7: [mlir][ArmSVE] Add basic mask generation operations (authored by jsetoain).
[mlir][ArmSVE] Add basic mask generation operations
Jun 8 2021, 1:00 AM
jsetoain closed D103473: [mlir][ArmSVE] Add basic mask generation operation.
Jun 8 2021, 1:00 AM · Restricted Project

Jun 4 2021

jsetoain updated the diff for D103535: [mlir][ArmSVE] Add basic load/store operations.

Clang format...

Jun 4 2021, 11:38 AM · Restricted Project
jsetoain added inline comments to D103535: [mlir][ArmSVE] Add basic load/store operations.
Jun 4 2021, 11:27 AM · Restricted Project
jsetoain updated the diff for D103535: [mlir][ArmSVE] Add basic load/store operations.

Fixed legality check on memref

Jun 4 2021, 11:23 AM · Restricted Project
jsetoain added inline comments to D103473: [mlir][ArmSVE] Add basic mask generation operation.
Jun 4 2021, 10:32 AM · Restricted Project
jsetoain updated the diff for D103473: [mlir][ArmSVE] Add basic mask generation operation.

Moved Cmp[F|I]Predicate from Ops.td to StandardOpsBase.td and reuse them in ArmSVE

Jun 4 2021, 10:30 AM · Restricted Project

Jun 2 2021

jsetoain published D103535: [mlir][ArmSVE] Add basic load/store operations for review.
Jun 2 2021, 9:42 AM · Restricted Project
jsetoain published D103473: [mlir][ArmSVE] Add basic mask generation operation for review.
Jun 2 2021, 4:08 AM · Restricted Project

May 5 2021

jsetoain committed rG95861216ac65: [mlir][ArmSVE] Add masked arithmetic operations (authored by jsetoain).
[mlir][ArmSVE] Add masked arithmetic operations
May 5 2021, 9:47 AM
jsetoain closed D100982: [mlir][ArmSVE] Add masked arithmetic operations.
May 5 2021, 9:47 AM · Restricted Project
jsetoain added inline comments to D100982: [mlir][ArmSVE] Add masked arithmetic operations.
May 5 2021, 3:05 AM · Restricted Project
jsetoain updated the diff for D100982: [mlir][ArmSVE] Add masked arithmetic operations.

Address comments

May 5 2021, 3:04 AM · Restricted Project

Apr 29 2021

jsetoain published D100982: [mlir][ArmSVE] Add masked arithmetic operations for review.
Apr 29 2021, 3:45 AM · Restricted Project
jsetoain added a comment to D100837: [mlir][ArmSVE] Add basic arithmetic operations.

I can't land revisions myself, if nobody else has any issues with the patch, please do that when ready. Thanks!

Apr 29 2021, 3:40 AM · Restricted Project

Apr 23 2021

jsetoain added a comment to D100837: [mlir][ArmSVE] Add basic arithmetic operations.

Is there an integration test running on some simulator that could be added in the future (similar to what we have for AVX512 and AMX) ?

Apr 23 2021, 12:26 PM · Restricted Project
jsetoain added inline comments to D100837: [mlir][ArmSVE] Add basic arithmetic operations.
Apr 23 2021, 12:19 PM · Restricted Project
jsetoain updated the diff for D100837: [mlir][ArmSVE] Add basic arithmetic operations.

Address comments

Apr 23 2021, 12:19 PM · Restricted Project

Apr 20 2021

jsetoain added a comment to D100840: [mlir][Standard][NFC] Fix op documentation.

I can't land this myself, please go ahead when ready!

Apr 20 2021, 10:45 AM · Restricted Project
jsetoain added reviewers for D100840: [mlir][Standard][NFC] Fix op documentation: mehdi_amini, rriddle.
Apr 20 2021, 4:01 AM · Restricted Project
jsetoain requested review of D100840: [mlir][Standard][NFC] Fix op documentation.
Apr 20 2021, 3:58 AM · Restricted Project
jsetoain added reviewers for D100837: [mlir][ArmSVE] Add basic arithmetic operations: aartbik, nicolasvasilache.
Apr 20 2021, 3:35 AM · Restricted Project
jsetoain requested review of D100837: [mlir][ArmSVE] Add basic arithmetic operations.
Apr 20 2021, 3:33 AM · Restricted Project

Apr 15 2021

jsetoain retitled D100171: [mlir][ArmSVE] Cleanup dialect registration from [mlir][ArmSVE] Cleanup dialect registration and initialization to [mlir][ArmSVE] Cleanup dialect registration.
Apr 15 2021, 2:17 AM · Restricted Project
jsetoain updated the diff for D100171: [mlir][ArmSVE] Cleanup dialect registration.

Rebase on latest main

Apr 15 2021, 2:14 AM · Restricted Project

Apr 13 2021

jsetoain added a comment to D100171: [mlir][ArmSVE] Cleanup dialect registration.

I can't land revisions myself, can somebody do that for me, please? Thanks!

Apr 13 2021, 11:51 PM · Restricted Project
jsetoain updated the diff for D100171: [mlir][ArmSVE] Cleanup dialect registration.

Rebasing on main and addressing comments

Apr 13 2021, 11:47 PM · Restricted Project

Apr 9 2021

jsetoain updated the diff for D100171: [mlir][ArmSVE] Cleanup dialect registration.

Fixed command line test.

Apr 9 2021, 5:09 AM · Restricted Project
jsetoain added a reviewer for D100171: [mlir][ArmSVE] Cleanup dialect registration: nicolasvasilache.
Apr 9 2021, 3:49 AM · Restricted Project
jsetoain requested review of D100171: [mlir][ArmSVE] Cleanup dialect registration.
Apr 9 2021, 3:43 AM · Restricted Project

Dec 17 2020

jsetoain updated the diff for D93465: [mlir][ArmSVE] Add documentation generation.

Patch against main

Dec 17 2020, 11:41 AM · Restricted Project
jsetoain updated the diff for D93465: [mlir][ArmSVE] Add documentation generation.

Rebase on master

Dec 17 2020, 11:30 AM · Restricted Project
jsetoain added a comment to D93465: [mlir][ArmSVE] Add documentation generation.

I don't have commit access. Please, commit when ready. Thank you!

Dec 17 2020, 9:55 AM · Restricted Project
jsetoain added reviewers for D93465: [mlir][ArmSVE] Add documentation generation: aartbik, nicolasvasilache.
Dec 17 2020, 9:12 AM · Restricted Project
jsetoain requested review of D93465: [mlir][ArmSVE] Add documentation generation.
Dec 17 2020, 9:09 AM · Restricted Project

Dec 14 2020

jsetoain added a comment to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

I don't have commit access to the repository. Please, commit when ready.

Dec 14 2020, 1:27 PM · Restricted Project
jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Dec 14 2020, 12:55 PM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Reorder operations and initializations alphabetically
Removed useless code
Clean up unnecessary 'auto' declartion
Fixed namespace usage

Dec 14 2020, 12:47 PM · Restricted Project

Dec 11 2020

jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Align test syntax style with common practise

Dec 11 2020, 6:58 PM · Restricted Project
jsetoain retitled D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect from [mlir][ArmSVE][RFC] Add an SVE dialect to [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Dec 11 2020, 12:24 PM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Rebased on top of D92171
Dialect syntax homogenized with ArmNeon dialect
Naming convention aligned with ArmNeon dialect
File location aligned with ArmNeon dialect
Conversion code aligned with ArmNeon dialect
Improved type checking
Added extra scalable vector type traits

Dec 11 2020, 12:11 PM · Restricted Project

Dec 8 2020

jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Dec 8 2020, 3:29 AM · Restricted Project
jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Dec 8 2020, 3:19 AM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Improve documentation around signedness of operations.

Dec 8 2020, 3:15 AM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Fixed default value for enabling ArmSVE extensions in vector

Dec 8 2020, 2:57 AM · Restricted Project

Dec 7 2020

jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Dec 7 2020, 3:36 PM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Fixed lint problems.
Improved documentation.
Merged with D92614, doesn't require it's own lowering pass anymore.

Dec 7 2020, 3:28 PM · Restricted Project

Dec 3 2020

jsetoain retitled D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect from [mlir][SVE][RFC] Add an SVE dialect to [mlir][ArmSVE][RFC] Add an SVE dialect.
Dec 3 2020, 11:03 AM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Make operations signless.
Rename dialect and move it to a different namespace.

Dec 3 2020, 11:01 AM · Restricted Project

Nov 27 2020

jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Nov 27 2020, 12:23 PM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Switching to ODS for type generation

Nov 27 2020, 12:16 PM · Restricted Project
jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Nov 27 2020, 9:41 AM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Fixed issue with doc formating.
Changed name of vector scale size operation to a better suited one, fixed documentation accordingly.

Nov 27 2020, 9:35 AM · Restricted Project
jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Nov 27 2020, 3:55 AM · Restricted Project

Nov 26 2020

jsetoain added inline comments to D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Nov 26 2020, 9:54 AM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Added missing documentation for SVE intrinsics

Nov 26 2020, 9:28 AM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Remove commented code

Nov 26 2020, 8:30 AM · Restricted Project
jsetoain updated the diff for D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.

Change to comply with header guard naming style

Nov 26 2020, 8:24 AM · Restricted Project
jsetoain updated the summary of D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Nov 26 2020, 7:03 AM · Restricted Project
jsetoain retitled D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect from [mlir][SVE] Add an SVE dialect to [mlir][SVE][RFC] Add an SVE dialect.
Nov 26 2020, 4:13 AM · Restricted Project
jsetoain requested review of D92172: [mlir][ArmSVE][RFC] Add an ArmSVE dialect.
Nov 26 2020, 4:13 AM · Restricted Project

Feb 5 2020

jsetoain accepted D74056: [mlir][AVX512] Start an AVX512 dialect.

Brilliant! Thanks, Nicholas. This will indeed be a helpful reference for "close-to-ISA" dialects in general :-)

Feb 5 2020, 11:02 AM · Restricted Project

Jan 29 2020

jsetoain accepted D73145: [mlir][Linalg] Introduce folding patterns to remove certain MemRefCastOp.

LGTM.

Jan 29 2020, 5:40 AM · Restricted Project

Jan 23 2020

jsetoain added inline comments to D73145: [mlir][Linalg] Introduce folding patterns to remove certain MemRefCastOp.
Jan 23 2020, 10:37 AM · Restricted Project