Page MenuHomePhabricator
Feed Advanced Search

Yesterday

frasercrmck added inline comments to D95447: [RISCV] Add support for RVV int<->fp & fp<->fp conversions.
Wed, Jan 27, 1:18 PM · Restricted Project
frasercrmck added inline comments to D95447: [RISCV] Add support for RVV int<->fp & fp<->fp conversions.
Wed, Jan 27, 3:49 AM · Restricted Project
frasercrmck updated the diff for D95447: [RISCV] Add support for RVV int<->fp & fp<->fp conversions.
  • rebase on main
  • change comment: round-towards-odd -> round-to-odd
Wed, Jan 27, 3:49 AM · Restricted Project
frasercrmck committed rG9a75a808c27f: [RISCV] Fix a codegen crash in getSetCCResultType (authored by frasercrmck).
[RISCV] Fix a codegen crash in getSetCCResultType
Wed, Jan 27, 2:29 AM
frasercrmck closed D95434: [RISCV] Fix a codegen crash in getSetCCResultType.
Wed, Jan 27, 2:29 AM · Restricted Project
frasercrmck accepted D95491: [RISCV] Group the legal vector types into lists we can iterator over in the RISCVISelLowering constructor.

LGTM

Wed, Jan 27, 1:50 AM · Restricted Project

Tue, Jan 26

frasercrmck updated the diff for D95447: [RISCV] Add support for RVV int<->fp & fp<->fp conversions.
  • merge rv32/rv64 tests
Tue, Jan 26, 8:17 AM · Restricted Project
frasercrmck added inline comments to D95447: [RISCV] Add support for RVV int<->fp & fp<->fp conversions.
Tue, Jan 26, 8:08 AM · Restricted Project
frasercrmck requested review of D95447: [RISCV] Add support for RVV int<->fp & fp<->fp conversions.
Tue, Jan 26, 7:51 AM · Restricted Project
frasercrmck requested review of D95434: [RISCV] Fix a codegen crash in getSetCCResultType.
Tue, Jan 26, 3:52 AM · Restricted Project
frasercrmck accepted D95272: [RISCV] Add rv64 run lines to rv32 MC layer tests for B extension.

LGTM

Tue, Jan 26, 1:47 AM · Restricted Project
frasercrmck added a comment to D95025: [RISCV] Add a test showing incorrect codegen.

Yes, we're certainly not moving away from update_llc_test_checks.py for the vector tests; I've used it in all of my work thus far. This test doesn't work perfectly with either the llc or mir scripts because it's IR -> MIR. The llc script does nothing on this test.

Tue, Jan 26, 1:25 AM · Restricted Project
frasercrmck added a comment to D95404: [RISCV] Adjust RISCVInstrInfoVSDPatterns.td for different pseudo instructions for different FPR..

Thanks, @craig.topper!

Tue, Jan 26, 1:14 AM · Restricted Project

Mon, Jan 25

frasercrmck committed rG15141cd115e0: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns (authored by frasercrmck).
[RISCV] Add RVV insertelt/extractelt scalable-vector patterns
Mon, Jan 25, 2:10 PM
frasercrmck closed D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
Mon, Jan 25, 2:10 PM · Restricted Project
frasercrmck added inline comments to D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
Mon, Jan 25, 4:56 AM · Restricted Project
frasercrmck updated the diff for D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
  • rebase on main
  • use custom-lowering and fewer patterns
  • move FromFPR32 helper to anticipate incoming changes
Mon, Jan 25, 4:54 AM · Restricted Project
frasercrmck committed rGfde24661718c: [SelectionDAG] Support scalable-vector splats in more cases (authored by frasercrmck).
[SelectionDAG] Support scalable-vector splats in more cases
Mon, Jan 25, 3:05 AM
frasercrmck closed D94501: [SelectionDAG] Support scalable-vector splats in more cases.
Mon, Jan 25, 3:05 AM · Restricted Project
frasercrmck added a comment to D95272: [RISCV] Add rv64 run lines to rv32 MC layer tests for B extension.

That's not what we've done elsewhere; rv64 is regarded as a superset of rv32, which is almost true.

Mon, Jan 25, 2:35 AM · Restricted Project
frasercrmck added inline comments to D95289: [TargetLowering][RISCV] Don't turn (seteq/ne (sext_inreg X, VT), C1) -> (seteq/ne (zext_inreg X, VT), C1) if the sext_inreg is cheaper.
Mon, Jan 25, 2:33 AM · Restricted Project
frasercrmck added a comment to D95272: [RISCV] Add rv64 run lines to rv32 MC layer tests for B extension.

Looking good; thanks for doing this. Should we change the name of the 32+64 tests now that they test both?

Mon, Jan 25, 2:23 AM · Restricted Project
frasercrmck added inline comments to D95148: [RISCV] Spilling for RISC-V V extension. (2nd version).
Mon, Jan 25, 2:20 AM · Restricted Project
frasercrmck accepted D95322: [RISCV] Custom type legalize i8/i16 UDIV/UREM/SDIV on RV64 so we can use divuw/remuw/divw..

LGTM, though I'd prefer the linter's suggestion over that manually-formatted code. You might be able to improve it somewhat with choice use of parens?

Mon, Jan 25, 2:17 AM · Restricted Project
frasercrmck added inline comments to D95234: [RISCV] Define different pseudo instructions for different FPR..
Mon, Jan 25, 1:46 AM · Restricted Project

Fri, Jan 22

frasercrmck accepted D95002: [RISCV] Update B extension version to 0.93..
Fri, Jan 22, 10:15 AM · Restricted Project, Restricted Project
frasercrmck retitled D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns from [RISCV][WIP] Add RVV insertelt/extractelt scalable-vector patterns to [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
Fri, Jan 22, 10:14 AM · Restricted Project
frasercrmck added inline comments to D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
Fri, Jan 22, 10:12 AM · Restricted Project
frasercrmck updated the diff for D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
  • rebase on main
  • address bits of Craig's feedback
Fri, Jan 22, 10:03 AM · Restricted Project
frasercrmck added inline comments to D94501: [SelectionDAG] Support scalable-vector splats in more cases.
Fri, Jan 22, 9:48 AM · Restricted Project
frasercrmck updated the diff for D94501: [SelectionDAG] Support scalable-vector splats in more cases.
  • add in assertions
Fri, Jan 22, 9:47 AM · Restricted Project
frasercrmck added inline comments to D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).
Fri, Jan 22, 9:40 AM · Restricted Project
frasercrmck added inline comments to D94501: [SelectionDAG] Support scalable-vector splats in more cases.
Fri, Jan 22, 8:59 AM · Restricted Project
frasercrmck updated the diff for D94501: [SelectionDAG] Support scalable-vector splats in more cases.

rebase on main

Fri, Jan 22, 8:59 AM · Restricted Project
frasercrmck added inline comments to D95002: [RISCV] Update B extension version to 0.93..
Fri, Jan 22, 6:56 AM · Restricted Project, Restricted Project
frasercrmck accepted D95150: [RISCV] Add B extension tests to make sure RV64 only instructions aren't accepted in RV32..

LGTM

Fri, Jan 22, 6:54 AM · Restricted Project
frasercrmck accepted D94999: [RISCV] Add xperm.* instructions to Zbp extension..

LGTM

Fri, Jan 22, 6:51 AM · Restricted Project
frasercrmck accepted D94653: [RISCV] Rename Zbs instructions to start with just 'b' instead of 'sb' to match 0.93 bitmanip spec..

LGTM

Fri, Jan 22, 6:48 AM · Restricted Project
frasercrmck accepted D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec..
In D94652#2512628, @asb wrote:

I think making the assumption that they probably meant to move to Zbp should be fine.

Fri, Jan 22, 6:47 AM · Restricted Project

Thu, Jan 21

frasercrmck added inline comments to D94999: [RISCV] Add xperm.* instructions to Zbp extension..
Thu, Jan 21, 4:10 AM · Restricted Project
frasercrmck accepted D94736: [RISCV] Change zext.w to be an alias of add.uw rd, rs1, x0 instead of pack..

LGTM, but should we document these "extra" things we're doing on top of the published spec? I'm not sure where, but it might help someone reading the spec as written.

Thu, Jan 21, 4:08 AM · Restricted Project
frasercrmck accepted D94818: [RISCV] Add zext.h instruction to Zbb..

LGTM

Thu, Jan 21, 4:03 AM · Restricted Project
frasercrmck accepted D94944: [RISCV] Add support for rev8 and orc.b to Zbb..

LGTM

Thu, Jan 21, 4:00 AM · Restricted Project
frasercrmck accepted D95090: [RISCV] Modify add.uw patterns to put the masked operand in rs1 to match 0.93 bitmanip spec..

LGTM

Thu, Jan 21, 3:52 AM · Restricted Project
frasercrmck added a comment to D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec..

My hope is to get the 0.93 move into LLVM 12. Zbb is marked frozen in the 0.93 spec and does not include these. So I'd at least like them out of Zbb. Would it be better to just remove them until they have a home?

Thu, Jan 21, 3:48 AM · Restricted Project
frasercrmck added inline comments to D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
Thu, Jan 21, 3:46 AM · Restricted Project
frasercrmck accepted D95113: [RISCV] Add intrinsics for RVV v1.0 VFRSQRTE7 & VFRECE7.

LGTM

Thu, Jan 21, 1:09 AM · Restricted Project
frasercrmck accepted D93612: [RISCV] Update V instructions constraints to conform to v1.0.

LGTM

Thu, Jan 21, 1:01 AM · Restricted Project

Wed, Jan 20

frasercrmck accepted D94742: [RISCV] Move pack instructions to Zbp extension only..

LGTM

Wed, Jan 20, 3:54 AM · Restricted Project
frasercrmck added a comment to D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec..

Changes look good but, like you, I can't see that these instructions are in that section (or any section for that matter). We can keep an eye on the issue you filed and approve once it's confirmed?

Wed, Jan 20, 3:49 AM · Restricted Project
frasercrmck accepted D94637: [RISCV] Add SH*ADD(.UW) instructions to Zba extension based on 0.93 bitmanip spec..

LGTM. I take it the patterns can come later?

Wed, Jan 20, 3:43 AM · Restricted Project
frasercrmck accepted D94617: [RISCV] Add Zba feature and move add.uw and slli.uw to it..

LGTM

Wed, Jan 20, 3:40 AM · Restricted Project, Restricted Project
frasercrmck accepted D94582: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93 bitmanip spec..

LGTM

Wed, Jan 20, 3:37 AM · Restricted Project, Restricted Project
frasercrmck added a comment to D94653: [RISCV] Rename Zbs instructions to start with just 'b' instead of 'sb' to match 0.93 bitmanip spec..

What are the implications of having the renamed Zbe instructions in what we'll advertise as 0.93?

Wed, Jan 20, 3:36 AM · Restricted Project
frasercrmck added a comment to D95025: [RISCV] Add a test showing incorrect codegen.

I posted something about this bug late last year but haven't found the time to progress with it. So I thought I'd at least put up a test case so it's tracked.

Wed, Jan 20, 12:07 AM · Restricted Project
frasercrmck requested review of D95025: [RISCV] Add a test showing incorrect codegen.
Wed, Jan 20, 12:05 AM · Restricted Project

Tue, Jan 19

frasercrmck updated the diff for D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
  • rebase on main
Tue, Jan 19, 11:41 PM · Restricted Project
frasercrmck accepted D94894: [RISCV] Add way to mark CompressPats that should only be used for compressing..

LGTM

Tue, Jan 19, 11:26 PM · Restricted Project
frasercrmck committed rG9c6a00fe99c4: [RISCV] Add ISel patterns for scalable mask exts & truncs (authored by frasercrmck).
[RISCV] Add ISel patterns for scalable mask exts & truncs
Tue, Jan 19, 10:20 AM
frasercrmck closed D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
Tue, Jan 19, 10:20 AM · Restricted Project
frasercrmck added inline comments to D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
Tue, Jan 19, 10:19 AM · Restricted Project
frasercrmck committed rG15fd6bae0e49: [RISCV] Extend RVV VType info with the type's AVL (NFC) (authored by frasercrmck).
[RISCV] Extend RVV VType info with the type's AVL (NFC)
Tue, Jan 19, 7:53 AM
frasercrmck closed D94594: [RISCV] Extend RVV VType info with the type's AVL (NFC).
Tue, Jan 19, 7:53 AM · Restricted Project
frasercrmck added inline comments to D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
Tue, Jan 19, 3:12 AM · Restricted Project
frasercrmck updated the diff for D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
  • rebase on main
  • only custom-lower for legal types
  • improve handling of illegal scalar types and splats thereof
Tue, Jan 19, 3:10 AM · Restricted Project
frasercrmck added inline comments to D94894: [RISCV] Add way to mark CompressPats that should only be used for compressing..
Tue, Jan 19, 1:49 AM · Restricted Project
frasercrmck committed rGc81ea9429f8d: [RISCV] Add scalable-vector integer extension patterns (authored by frasercrmck).
[RISCV] Add scalable-vector integer extension patterns
Tue, Jan 19, 1:37 AM
frasercrmck closed D94694: [RISCV] Add scalable-vector integer extension patterns.
Tue, Jan 19, 1:36 AM · Restricted Project

Mon, Jan 18

frasercrmck added inline comments to D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
Mon, Jan 18, 8:30 AM · Restricted Project
frasercrmck updated the diff for D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
  • rebase on main
  • fix conflicts
Mon, Jan 18, 7:51 AM · Restricted Project
frasercrmck updated the diff for D94694: [RISCV] Add scalable-vector integer extension patterns.

add pats for anyext: treat like zext for now

Mon, Jan 18, 7:45 AM · Restricted Project
frasercrmck accepted D94577: [RISCV] Remove addiwu, addwu, subwu, subuw, clmulw, clmulrw, clmulhw to match 0.93 bitmanip spec..

LGTM

Mon, Jan 18, 7:25 AM · Restricted Project
frasercrmck added inline comments to D94694: [RISCV] Add scalable-vector integer extension patterns.
Mon, Jan 18, 7:18 AM · Restricted Project
frasercrmck updated the diff for D94694: [RISCV] Add scalable-vector integer extension patterns.
  • rebase on main
Mon, Jan 18, 3:38 AM · Restricted Project
frasercrmck committed rGac603c8d3850: [RISCV] Add scalable vector truncate patterns (authored by frasercrmck).
[RISCV] Add scalable vector truncate patterns
Mon, Jan 18, 2:25 AM
frasercrmck closed D94796: [RISCV] Add scalable vector truncate patterns.
Mon, Jan 18, 2:25 AM · Restricted Project

Fri, Jan 15

frasercrmck accepted D94628: [RISCV] Add implementation of targetShrinkDemandedConstant to optimize AND immediates..

LGTM. I hadn't come across this function before so thanks for the intro.

Fri, Jan 15, 9:19 AM · Restricted Project
frasercrmck updated the diff for D94694: [RISCV] Add scalable-vector integer extension patterns.
  • fix up bad type mangling in tests (e.g. nx4i8 -> nxv4i8)
Fri, Jan 15, 9:18 AM · Restricted Project
frasercrmck requested review of D94796: [RISCV] Add scalable vector truncate patterns.
Fri, Jan 15, 9:14 AM · Restricted Project
frasercrmck added inline comments to D94628: [RISCV] Add implementation of targetShrinkDemandedConstant to optimize AND immediates..
Fri, Jan 15, 7:51 AM · Restricted Project
frasercrmck accepted D94580: [RISCV] Swap encodings of max and minu to match 0.93 bitmanip spec..

LGTM

Fri, Jan 15, 7:24 AM · Restricted Project
frasercrmck added inline comments to D94577: [RISCV] Remove addiwu, addwu, subwu, subuw, clmulw, clmulrw, clmulhw to match 0.93 bitmanip spec..
Fri, Jan 15, 7:23 AM · Restricted Project
frasercrmck accepted D94568: [RISCV] Rename pcnt->cpop to match 0.93 bitmanip spec..

LGTM from a change point of view. I can't really add to the discussion about how/when to switch from 0.92 to 0.93 so I'm not saying "merge right away" :)

Fri, Jan 15, 7:16 AM · Restricted Project
frasercrmck accepted D94751: [RISCV] Correct alignment settings for vector registers..

Makes sense to me. I think we'll have to handle "misaligned" vectors at some point too, since the DataLayout can only represent the alignment of vectors based on their overall size.

Fri, Jan 15, 7:15 AM · Restricted Project
frasercrmck added inline comments to D94294: [RISCV] Add scalable vector vselect ISel patterns.
Fri, Jan 15, 2:43 AM · Restricted Project
frasercrmck accepted D94750: [NFC][RISCV] Remove useless code in RISCVRegisterInfo.td..

LGTM

Fri, Jan 15, 1:26 AM · Restricted Project

Thu, Jan 14

frasercrmck requested review of D94694: [RISCV] Add scalable-vector integer extension patterns.
Thu, Jan 14, 8:09 AM · Restricted Project
frasercrmck added inline comments to D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
Thu, Jan 14, 6:40 AM · Restricted Project
frasercrmck updated the diff for D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
  • replace patterns with custom-lowering
Thu, Jan 14, 6:39 AM · Restricted Project

Wed, Jan 13

frasercrmck requested review of D94615: [RISCV] Add RVV insertelt/extractelt scalable-vector patterns.
Wed, Jan 13, 10:17 AM · Restricted Project
frasercrmck accepted D94584: [NFC][RISCV] Add double type in RISC-V V CodeGen test cases for RV32..

A few too many changes to look over one-by-one, and my browser is chugging, but from what I've seen: LGTM.

Wed, Jan 13, 6:26 AM · Restricted Project
frasercrmck requested review of D94594: [RISCV] Extend RVV VType info with the type's AVL (NFC).
Wed, Jan 13, 5:46 AM · Restricted Project
frasercrmck requested review of D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
Wed, Jan 13, 4:38 AM · Restricted Project

Tue, Jan 12

frasercrmck added inline comments to D94501: [SelectionDAG] Support scalable-vector splats in more cases.
Tue, Jan 12, 8:52 AM · Restricted Project
frasercrmck updated subscribers of D94501: [SelectionDAG] Support scalable-vector splats in more cases.

@c-rhodes or @david-arm I've updated the AArch64 tests naively but I thought I'd tag you in case you don't intend to be shifting out all bits.

Tue, Jan 12, 8:15 AM · Restricted Project
frasercrmck requested review of D94501: [SelectionDAG] Support scalable-vector splats in more cases.
Tue, Jan 12, 8:12 AM · Restricted Project
frasercrmck committed rG09db958e37b3: [RISCV] Improve scalable-vector shift tests (NFC) (authored by frasercrmck).
[RISCV] Improve scalable-vector shift tests (NFC)
Tue, Jan 12, 3:47 AM
frasercrmck accepted D94450: [LegalizeDAG][RISCV][PowerPC][AMDGPU][WebAssembly] Improve expansion of SETONE/SETUEQ on targets without SETO/SETUO..

LGTM other than my suggestion.

Tue, Jan 12, 2:37 AM · Restricted Project
frasercrmck accepted D94471: [NFC] Use generic name for scalable vector stack ID..

LGTM

Tue, Jan 12, 1:15 AM · Restricted Project
frasercrmck accepted D94459: [RISCV] Use vmerge.vim for llvm.riscv.vfmerge with a 0.0 scalar operand..

LGTM.

Tue, Jan 12, 1:13 AM · Restricted Project