I've updated the diff to reflect the alternate non-wrapper exposure. This way requires the sanitizing of the exported objc_direct method name.
- All Stories
- Advanced Search
- Transaction Logs
Sep 3 2020
Sep 2 2020
Sep 1 2020
Aug 29 2020
Aug 26 2020
@YangZhihui landed at https://github.com/llvm/llvm-project/commit/f22d27624b6532a5542b283de9ce586c72c6b846
Aug 25 2020
In D86427#2235630, @YangZhihui wrote:
how can I add the Author property in the patch
In D86427#2235574, @YangZhihui wrote:
Thanks, but I don't have commit access
Aug 23 2020
LGTM. Go ahead and land it.
Aug 20 2020
@lanza I did it as a CodeGen option for now because we don't want anything like this to be the default until the ABI is fleshed out.
I think one danger in altering the name of the function to some extent is you dont want to clash potentially with user defined C functions.
Aug 19 2020
Ok, LGTM. I will land for you, but in your name on git. Thanks for this patch @kyulee.
Aug 18 2020
In D86049#2225202, @rjmccall wrote:
I think that, if we want to do this, we need to think carefully about what exactly we want the ABI to be.
Aug 17 2020
change for clang-tidy and clang-format.
I think this LGTM. @kyulee are there any other tests that use this flag? Can you add a test that both adds and also removes some different attributes. Also a test that adds and removes he same attribute too would be good.
Good stuff. Thanks for replying so quickly @fhahn :-)
Aug 15 2020
@fhahn I ran into an llvm_unreachable when building matrix-types-spec.cpp as part of an llvm-test-suite build using -Oz with -flto=thin. I reduced the IR that hit the unreachable to:
Aug 14 2020
Please Update Diff.
Aug 11 2020
In D85678#2211933, @phosek wrote:
I'd be fine with InterfaceStub as a name for the library.
In D85678#2211904, @haowei wrote:In D85678#2211863, @MaskRay wrote:
I would like to improve llvm-ifs tool on ELF object handling. Right now it uses yaml2obj which is not robust.
How is it not robust?
We contacted plotfi and learned that llvm-ifs does not work well in production when it is used for elf stub generation. We suggested to improve llvm-ifs tools and unify it with llvm-elfabi tool as they share many similarities. llvm-elfabi has its own elf handler, most of its code have not yet landed and we will try our best to make it to production grade. This CL is the first step to strip elf handler away from llvm-elfabi and put it into a standalone library so we can continue work on it and make it shared by both tools without breaking anything.
Aug 10 2020
Overall this change makes sense. I don't see why we shouldn't have this ability to remove attrs.
Closing, cause phab doesn't seem to be auto-closing.
Landed at https://github.com/llvm/llvm-project/commit/7bc03f55539f7f081daea5363f2e4845b2e75f57
Aug 9 2020
In D57265#2205797, @rjf wrote:
Would also really like to see this patch landed. Also, as of today (8/10/2020), the patch cannot be cleanly applied into trunk without inducing merge conflicts anymore.
Aug 8 2020
Adding BLR-based test case that explodes LR and all other registers to achieve the same assert without noreturn.
Jul 22 2020
Jul 21 2020
Update based on @paquette's feedback
Jul 20 2020
@t.p.northover gentle ping
Solidified the cases where we want to bail out after speaking with @paquette some more
Jul 17 2020
Filed a bugzilla task to track progress: https://bugs.llvm.org/show_bug.cgi?id=46767
@paquette gentle ping
Jul 16 2020
Updated based on @kyulee's suggestion to use FlagsSetInAll & MachineOutlinerMBBFlags::HasCalls
Jul 15 2020
In D83464#2152352, @kyulee wrote:
@plotfi I hit this in an internal workload (-Oz -flto=thin), but it won't surprise if the same issue is in llvm-test-suite.
Jul 14 2020
@kyulee Did you by chance come across this on the MultiSource/Applications/Burg test on llvm-test-suite? I hit something like this with -flto=full and -Oz and have been working on debugging it.
Abandoning. I think the stuff @AndrewLitteken added a few months ago is more than sufficient.
Update for harbormaster.
@t.p.northover Hi Tim, would you have some bandwidth to take a look at this patch for homogeneous prolog/epilog callee-save registers opti?
Jul 9 2020
@kyulee Update please (since the NFC has landed), so that Harbormaster can run again without conflict.
D82552 appears to have also fixed fastcc, so I will only land the test case.
@pratlucas Awesome thank you!
In D79730#2030530, @rjmccall wrote:
I think it makes sense; if nothing else, we're trying to upstream all that work.
In D66029#2052030, @mpaszkowski wrote:
@plotfi Should I create a new review so that the HarborMaster will be able run the builds after the fix?