Page MenuHomePhabricator
Feed Advanced Search

Mon, Oct 14

plotfi committed rG4e4b4f4099a6: [clang][IFS][test] Fixing lit test breakages on macOS due to r374798 (authored by plotfi).
[clang][IFS][test] Fixing lit test breakages on macOS due to r374798
Mon, Oct 14, 11:59 AM
plotfi added a comment to D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI.

I see what went wrong. Will post a fix shortly.

Mon, Oct 14, 11:20 AM · Restricted Project
plotfi committed rG76f9869bf200: [clang][IFS] Escape mangled names so MS ABI doesn't break YAML parsing. (authored by plotfi).
[clang][IFS] Escape mangled names so MS ABI doesn't break YAML parsing.
Mon, Oct 14, 11:02 AM
plotfi closed D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI.
Mon, Oct 14, 11:02 AM · Restricted Project

Sat, Oct 12

plotfi created D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI.
Sat, Oct 12, 11:04 AM · Restricted Project
plotfi updated the diff for D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI.
Sat, Oct 12, 11:04 AM · Restricted Project

Fri, Oct 11

plotfi committed rG17bde36a031a: [clang][IFS] Fixing spelling errors in interface-stubs OPT flag (NFC). (authored by plotfi).
[clang][IFS] Fixing spelling errors in interface-stubs OPT flag (NFC).
Fri, Oct 11, 11:25 PM
plotfi committed rGc0abc2e7f2f6: [clang][IFS] Updating tests to pass on -fvisibility=hidden builds (NFCi). (authored by plotfi).
[clang][IFS] Updating tests to pass on -fvisibility=hidden builds (NFCi).
Fri, Oct 11, 7:46 PM
plotfi closed D68897: [clang][ifs] Avoid assumption of default visibility in InterfaceStubs tests.
Fri, Oct 11, 7:46 PM · Restricted Project
plotfi accepted D68897: [clang][ifs] Avoid assumption of default visibility in InterfaceStubs tests.
Fri, Oct 11, 4:42 PM · Restricted Project
plotfi added a comment to D63978: Clang Interface Stubs merger plumbing for Driver.

Our team maintains a downstream embedded ARM clang distribution and some tests from this commit have begun to fail for us.
For a number of these tests, there was a REQUIRES: x86-registered-target at the top, which has now been removed. Specifically, externstatic.c, merge-conflict-test.c, object-float.c, and object.c are failing.

object* tests seem to be based on object.cpp, which had the REQUIRES line, and externstatic.c also had that line prior to the change.
I see that @compnerd suggested the removal, but were you certain that these tests would work on clang toolchains for which x86 is not a registered target?

For a failure example, here the output of lit for our toolchain. If you can make sense of it, I'd appreciate input on how we can fix or work around it:

> <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c | <WORKDIR>/arm-llvm/Release/llvm/bin/FileCheck -check-prefix=CHECK-TAPI <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
 <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c:5:16: error: CHECK-TAPI: expected string not found in input
 // CHECK-TAPI: data: { Type: Object, Size: 4 }
                ^
 <stdin>:1:1: note: scanning from here
 --- !experimental-ifs-v1
 ^

And when run without FileCheck, our raw output:

> <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
 --- !experimental-ifs-v1
 IfsVersion: 1.0
 Triple: thumbv7em-ti-none-eabihf
 ObjectFileFormat: ELF
 Symbols:
 ...

I am sorry for this James. I can add back the REQUIRES lines for now and coordinate with you on making sure your downstream bots are not affected again if the REQUIRES are removed again.
By chance are your bots accessible publicly?

Sadly, they are not. It's on our list of things to investigate, but we don't have the resources to do such a thing quite yet.
I'm looking into the 'arm7*' buildbots to see if they are built similar to ours so I am not leaving you entirely without something to look at. However, if it seems to be common knowledge to always include an X86 target, I think I can talk to my team and change up what we do.

These buildbots seem to also do LLVM_TARGETS_TO_BUILD=ARM, and then set the default target triple to a non-x86 triple (the host's)

That could point towards us being in error here. I'll investigate things a little further, and update when I get the chance.
To be clear: this feature should work for any ELF target, correct?

Yes, it is designed to work for all ELF targets but at the moment it is still in an early state. I am on the llvm IRC as zer0_ BTW

I'd love to bounce ideas off of people in IRC, but the big mean IT security guys say no to any sort of chat programs. It's a real shame.
I found the assumption being missed though, so good news!
Our targets assume hidden visibility by default. After scanning your code (and realizing 'interface' is spelled as 'iterface' in a number of places), I noticed it was looking only for externally visible decls. After that, I scanned out changes and found a sneaky '-fvisibility=hidden' in our toolchain options.

By running all of your tests with '-fvisibility=default', our toolchain passes! If you're willing to review/commit the fix upstream, I'm putting up a review presently.

Fri, Oct 11, 4:33 PM · Restricted Project, Restricted Project
plotfi added a comment to D63978: Clang Interface Stubs merger plumbing for Driver.

Our team maintains a downstream embedded ARM clang distribution and some tests from this commit have begun to fail for us.
For a number of these tests, there was a REQUIRES: x86-registered-target at the top, which has now been removed. Specifically, externstatic.c, merge-conflict-test.c, object-float.c, and object.c are failing.

object* tests seem to be based on object.cpp, which had the REQUIRES line, and externstatic.c also had that line prior to the change.
I see that @compnerd suggested the removal, but were you certain that these tests would work on clang toolchains for which x86 is not a registered target?

For a failure example, here the output of lit for our toolchain. If you can make sense of it, I'd appreciate input on how we can fix or work around it:

> <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c | <WORKDIR>/arm-llvm/Release/llvm/bin/FileCheck -check-prefix=CHECK-TAPI <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
 <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c:5:16: error: CHECK-TAPI: expected string not found in input
 // CHECK-TAPI: data: { Type: Object, Size: 4 }
                ^
 <stdin>:1:1: note: scanning from here
 --- !experimental-ifs-v1
 ^

And when run without FileCheck, our raw output:

> <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
 --- !experimental-ifs-v1
 IfsVersion: 1.0
 Triple: thumbv7em-ti-none-eabihf
 ObjectFileFormat: ELF
 Symbols:
 ...

I am sorry for this James. I can add back the REQUIRES lines for now and coordinate with you on making sure your downstream bots are not affected again if the REQUIRES are removed again.
By chance are your bots accessible publicly?

Sadly, they are not. It's on our list of things to investigate, but we don't have the resources to do such a thing quite yet.
I'm looking into the 'arm7*' buildbots to see if they are built similar to ours so I am not leaving you entirely without something to look at. However, if it seems to be common knowledge to always include an X86 target, I think I can talk to my team and change up what we do.

These buildbots seem to also do LLVM_TARGETS_TO_BUILD=ARM, and then set the default target triple to a non-x86 triple (the host's)

That could point towards us being in error here. I'll investigate things a little further, and update when I get the chance.
To be clear: this feature should work for any ELF target, correct?

Fri, Oct 11, 3:20 PM · Restricted Project, Restricted Project
plotfi added a comment to D63978: Clang Interface Stubs merger plumbing for Driver.

Our team maintains a downstream embedded ARM clang distribution and some tests from this commit have begun to fail for us.
For a number of these tests, there was a REQUIRES: x86-registered-target at the top, which has now been removed. Specifically, externstatic.c, merge-conflict-test.c, object-float.c, and object.c are failing.

object* tests seem to be based on object.cpp, which had the REQUIRES line, and externstatic.c also had that line prior to the change.
I see that @compnerd suggested the removal, but were you certain that these tests would work on clang toolchains for which x86 is not a registered target?

For a failure example, here the output of lit for our toolchain. If you can make sense of it, I'd appreciate input on how we can fix or work around it:

> <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c | <WORKDIR>/arm-llvm/Release/llvm/bin/FileCheck -check-prefix=CHECK-TAPI <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
 <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c:5:16: error: CHECK-TAPI: expected string not found in input
 // CHECK-TAPI: data: { Type: Object, Size: 4 }
                ^
 <stdin>:1:1: note: scanning from here
 --- !experimental-ifs-v1
 ^

And when run without FileCheck, our raw output:

> <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
 --- !experimental-ifs-v1
 IfsVersion: 1.0
 Triple: thumbv7em-ti-none-eabihf
 ObjectFileFormat: ELF
 Symbols:
 ...
Fri, Oct 11, 1:18 PM · Restricted Project, Restricted Project
plotfi committed rGe3388c42f39b: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs (authored by plotfi).
[clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs
Fri, Oct 11, 10:24 AM
plotfi closed D68859: Fixing crash in clang IFS for enum, record, and typedef decls..
Fri, Oct 11, 10:24 AM · Restricted Project

Thu, Oct 10

plotfi created D68859: Fixing crash in clang IFS for enum, record, and typedef decls..
Thu, Oct 10, 11:53 PM · Restricted Project

Wed, Oct 9

plotfi added a comment to D63978: Clang Interface Stubs merger plumbing for Driver.

It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which as far as I know, was only used for testing purposes until now. Is this intended?

Wed, Oct 9, 11:36 AM · Restricted Project, Restricted Project

Tue, Oct 8

plotfi committed rGc382d03ca85d: [clang][ifs] Clang Interface Stubs ToolChain plumbing. (authored by plotfi).
[clang][ifs] Clang Interface Stubs ToolChain plumbing.
Tue, Oct 8, 8:26 AM

Wed, Oct 2

plotfi committed rG30c8df02ba22: Fixing broken builds due to r373538, issues with filepath and hexagon toolchain. (authored by plotfi).
Fixing broken builds due to r373538, issues with filepath and hexagon toolchain.
Wed, Oct 2, 6:21 PM
plotfi committed rG8581f860c7ef: Fixing broken builds due to r373538 due to test that should have been deleted. (authored by plotfi).
Fixing broken builds due to r373538 due to test that should have been deleted.
Wed, Oct 2, 5:41 PM
plotfi committed rG406de17b9b93: [clang][ifs] Clang Interface Stubs ToolChain plumbing. (authored by plotfi).
[clang][ifs] Clang Interface Stubs ToolChain plumbing.
Wed, Oct 2, 3:53 PM
plotfi accepted D68319: [llvm-lipo] Relax the check of the specified input file architecture.

Make sure to clang format the new code. I think this looks ok.

Wed, Oct 2, 12:07 AM · Restricted Project

Wed, Sep 25

plotfi added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Wed, Sep 25, 4:43 PM · Restricted Project, Restricted Project
plotfi added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Wed, Sep 25, 3:46 PM · Restricted Project, Restricted Project
plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.

addressing cindy and saleem's feedback

Wed, Sep 25, 3:46 PM · Restricted Project, Restricted Project

Tue, Sep 24

plotfi committed rG67b705b18d62: [NFC] Invoke lipo from CMAKE_LIPO. (authored by plotfi).
[NFC] Invoke lipo from CMAKE_LIPO.
Tue, Sep 24, 4:52 PM
plotfi committed rG819ff64ea044: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds. (authored by plotfi).
Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds.
Tue, Sep 24, 3:40 PM
plotfi updated the diff for D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

s/;/|/g

Tue, Sep 24, 3:21 PM · Restricted Project

Mon, Sep 23

plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.
Mon, Sep 23, 11:17 PM · Restricted Project, Restricted Project
plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.

tests

Mon, Sep 23, 11:08 PM · Restricted Project, Restricted Project
plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.
Mon, Sep 23, 6:21 PM · Restricted Project, Restricted Project

Sun, Sep 22

plotfi added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Sun, Sep 22, 9:21 PM · Restricted Project, Restricted Project
plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.

Adding back -c. Fixing driver for .ifs files

Sun, Sep 22, 9:19 PM · Restricted Project, Restricted Project

Sep 22 2019

plotfi added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Sep 22 2019, 12:27 AM · Restricted Project, Restricted Project
plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.

fixed comment.

Sep 22 2019, 12:01 AM · Restricted Project, Restricted Project
plotfi added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Sep 22 2019, 12:01 AM · Restricted Project, Restricted Project

Sep 21 2019

plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.
Sep 21 2019, 11:53 PM · Restricted Project, Restricted Project

Sep 15 2019

plotfi added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 15 2019, 5:36 PM · Restricted Project

Sep 13 2019

plotfi added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..

I think this change might be breaking builds: http://lab.llvm.org:8011/builders/clang-aarch64-linux-build-cache/builds/16888

Sep 13 2019, 11:15 AM · Restricted Project
plotfi added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 13 2019, 11:14 AM · Restricted Project

Sep 12 2019

plotfi added reviewers for D67527: [TextAPI] Arch&Platform to Target: compnerd, smeenai.
Sep 12 2019, 4:24 PM · Restricted Project

Sep 10 2019

plotfi added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

Nice! Thanks @phosek. I’m fine with a revert. Currently away from keyboard.

Sep 10 2019, 5:38 PM · Restricted Project
plotfi added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

Where are your bots?

Sep 10 2019, 5:26 PM · Restricted Project
plotfi committed rG244e73848544: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds. (authored by plotfi).
Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds.
Sep 10 2019, 4:02 PM
plotfi added a comment to D66160: [llvm-nm] Add tapi file support.

Ah I get it, because ld64 is tbd-aware the end product is the text. I’m still not sure if I will add any support to lld for something like ifs, things still seem good just using the ifs text format for the intermediate symbol merging.

Sep 10 2019, 9:48 AM · Restricted Project

Sep 7 2019

plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.
Sep 7 2019, 12:50 AM · Restricted Project, Restricted Project

Sep 6 2019

plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.

Adding better wiring up to llvm-ifs

Sep 6 2019, 6:17 PM · Restricted Project, Restricted Project
plotfi committed rG5476bd943203: [llvm-ifs] Improving detection of PlatformKind from triple for TBD generation. (authored by plotfi).
[llvm-ifs] Improving detection of PlatformKind from triple for TBD generation.
Sep 6 2019, 1:00 PM
plotfi added a comment to D66160: [llvm-nm] Add tapi file support.

Does this addition mean that llvm-nm should eventually include some support for other text formats like ifs/elfabi etc? I think this could be pretty useful for writing tests, which I assume is part of the motivation here?

Sep 6 2019, 11:00 AM · Restricted Project
plotfi added a comment to D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.

bridgeOS hasn't been added to llvm triple yet, so it's fine to exclude it for now.
also I have a patch I'm adding very soon that takes in llvm::triple and does the arch/platform mapping so you won't need to. I'll update this file when it comes out.

Sep 6 2019, 10:34 AM · Restricted Project
plotfi added a comment to D67209: [MIR] MIR Namer pass.

Hi,

I did a minor change to the test case in r371171 since the

;CHECK: bb

checks matched on the line

;ModuleID = '/repo/bb/

in the output instead of the wanted "bb.0:".

I fixed it by reading input from stdin instead of from the file to make the change as small as possible, but perhaps the

;CHECK: bb

lines should be changed to

;CHECK-LABEL: bb.0:

etc instead.

Sep 6 2019, 10:34 AM · Restricted Project

Sep 5 2019

plotfi created D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.
Sep 5 2019, 11:15 PM · Restricted Project
plotfi added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

Ping?

Sep 5 2019, 4:46 PM · Restricted Project
plotfi committed rGdc97ca9f25ac: [MIR] MIRNamer pass for improving MIR test authoring experience. (authored by plotfi).
[MIR] MIRNamer pass for improving MIR test authoring experience.
Sep 5 2019, 1:45 PM
plotfi updated the diff for D67209: [MIR] MIR Namer pass.

addressing @paquette's feedback

Sep 5 2019, 12:15 PM · Restricted Project

Sep 4 2019

plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Sep 4 2019, 10:15 PM · Restricted Project
plotfi created D67209: [MIR] MIR Namer pass.
Sep 4 2019, 10:01 PM · Restricted Project
plotfi committed rG6d3ea2d9b60b: [mir-canon][NFC] Adding -verify-machineinstrs to mir-canon tests. (authored by plotfi).
[mir-canon][NFC] Adding -verify-machineinstrs to mir-canon tests.
Sep 4 2019, 7:12 PM
plotfi created D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..
Sep 4 2019, 3:27 PM · Restricted Project
plotfi abandoned D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Sep 4 2019, 2:46 PM · Restricted Project
plotfi committed rG028061d4ebeb: [mir-canon][NFC] Move MIR vreg renaming code to separate file for better reuse. (authored by plotfi).
[mir-canon][NFC] Move MIR vreg renaming code to separate file for better reuse.
Sep 4 2019, 2:30 PM
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

More comments.

Sep 4 2019, 12:57 PM · Restricted Project

Sep 3 2019

plotfi committed rG954d6d661f33: [NFC][llvm-ifs] Adding .ifs files to the test list for llvm-ifs tool. (authored by plotfi).
[NFC][llvm-ifs] Adding .ifs files to the test list for llvm-ifs tool.
Sep 3 2019, 5:50 PM
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Sep 3 2019, 4:40 PM · Restricted Project
plotfi added inline comments to D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Sep 3 2019, 4:40 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Sep 3 2019, 4:13 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

addressing @paquette's suggestions.

Sep 3 2019, 4:07 PM · Restricted Project
plotfi added inline comments to D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Sep 3 2019, 3:41 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Sep 3 2019, 3:41 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

Moving the guts of the candidate walk loop into the reusable MIRVRegNamer.cpp library

Sep 3 2019, 2:18 PM · Restricted Project
plotfi added inline comments to D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Sep 3 2019, 2:18 PM · Restricted Project
plotfi added inline comments to D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Sep 3 2019, 10:47 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Sep 3 2019, 10:45 AM · Restricted Project
plotfi created D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Sep 3 2019, 10:45 AM · Restricted Project
plotfi added a comment to D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..

Sounds good.

Sep 3 2019, 9:29 AM · Restricted Project

Sep 2 2019

plotfi created D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Sep 2 2019, 12:39 AM · Restricted Project

Aug 31 2019

plotfi committed rG75a8a212d4e4: [GlobalISel][NFC] Regression test cases for aarch64 legalizer (s128 sext+icmp). (authored by plotfi).
[GlobalISel][NFC] Regression test cases for aarch64 legalizer (s128 sext+icmp).
Aug 31 2019, 5:46 PM

Aug 30 2019

plotfi committed rG0227208b8753: [IFS][NFC] llvm-ifs: Fixing build bot build break: revert r370517 and r370510. (authored by plotfi).
[IFS][NFC] llvm-ifs: Fixing build bot build break: revert r370517 and r370510.
Aug 30 2019, 1:32 PM
plotfi committed rG7e9dd09db8a4: [IFS][NFC] llvm-ifs: Fixing build bot error due to commit conflicts. (authored by plotfi).
[IFS][NFC] llvm-ifs: Fixing build bot error due to commit conflicts.
Aug 30 2019, 1:10 PM
plotfi committed rG979e7cda8048: [IFS][NFC] llvm-ifs: Fixing build errors for bots using GCC. (authored by plotfi).
[IFS][NFC] llvm-ifs: Fixing build errors for bots using GCC.
Aug 30 2019, 12:55 PM
plotfi committed rGd719c50655e7: [llvm-ifs][IFS] llvm Interface Stubs merging + object file generation tool. (authored by plotfi).
[llvm-ifs][IFS] llvm Interface Stubs merging + object file generation tool.
Aug 30 2019, 11:27 AM
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

longer flags, no more =

Aug 30 2019, 10:13 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 30 2019, 9:55 AM · Restricted Project

Aug 29 2019

plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 29 2019, 2:06 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

better diag, better test names

Aug 29 2019, 2:04 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

adding .data and .rodata to elf sections

Aug 29 2019, 10:13 AM · Restricted Project

Aug 28 2019

plotfi added a comment to D66029: llvm-canon.

Gentle ping ;)

I would like to ask someone to commit this for me. I don't have commit rights.

Aug 28 2019, 9:59 PM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 28 2019, 10:46 AM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
  • Dropping vestigial ELFSymbols, now I have IFSSymbol.
  • addressed @compnerd 's feedback
Aug 28 2019, 10:46 AM · Restricted Project

Aug 27 2019

plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

More version checks

Aug 27 2019, 2:35 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

Checking for conflicts in the Ifs header.

Aug 27 2019, 1:21 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

Added some better conflict checking tests.

Aug 27 2019, 11:59 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 27 2019, 11:12 AM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 27 2019, 11:07 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 27 2019, 2:31 AM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

test updates based on feedback

Aug 27 2019, 2:19 AM · Restricted Project

Aug 26 2019

plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

adding another test, to merge objects and funcs of different sizes.

Aug 26 2019, 4:54 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

Adding some tests. and added some really basic symbol conflict error checking (no resolution though).

Aug 26 2019, 2:42 PM · Restricted Project

Aug 23 2019

plotfi updated the summary of D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 23 2019, 5:47 PM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 23 2019, 5:47 PM · Restricted Project