Page MenuHomePhabricator
Feed Advanced Search

Yesterday

jankratochvil committed rG7fc6d36d4848: [nfc] [lldb] clang-format #include files order (authored by jankratochvil).
[nfc] [lldb] clang-format #include files order
Thu, Jun 4, 11:58 PM
jankratochvil committed rG476f520a0bd2: [lldb] Fix SLEB128 decoding (authored by jankratochvil).
[lldb] Fix SLEB128 decoding
Thu, Jun 4, 11:03 AM
jankratochvil closed D81119: [lldb] Fix SLEB128 decoding.
Thu, Jun 4, 11:01 AM · Restricted Project
jankratochvil added inline comments to D81119: [lldb] Fix SLEB128 decoding.
Thu, Jun 4, 11:00 AM · Restricted Project
jankratochvil added a comment to D81119: [lldb] Fix SLEB128 decoding.

PS: You can still just drop the test if you think that's too much hassle. :)

Thu, Jun 4, 11:00 AM · Restricted Project
jankratochvil updated the diff for D81119: [lldb] Fix SLEB128 decoding.

Added unit test, simplified the .s test.

Thu, Jun 4, 8:44 AM · Restricted Project
jankratochvil planned changes to D81119: [lldb] Fix SLEB128 decoding.
Thu, Jun 4, 7:04 AM · Restricted Project

Wed, Jun 3

jankratochvil created D81119: [lldb] Fix SLEB128 decoding.
Wed, Jun 3, 2:20 PM · Restricted Project
jankratochvil retitled D81119: [lldb] Fix SLEB128 decoding from Fix SLEB128 decoding to [lldb] Fix SLEB128 decoding.
Wed, Jun 3, 2:20 PM · Restricted Project

Fri, May 29

jankratochvil added inline comments to D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
Fri, May 29, 9:45 AM · Restricted Project

Sat, May 9

jankratochvil committed rG68a9356bdea6: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol… (authored by jankratochvil).
[lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol…
Sat, May 9, 12:29 AM
jankratochvil closed D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files.
Sat, May 9, 12:29 AM · Restricted Project

Fri, May 8

jankratochvil created D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files.
Fri, May 8, 1:57 PM · Restricted Project

May 4 2020

jankratochvil added inline comments to D78421: Fix out of sync source code/executable when debugging.
May 4 2020, 11:48 AM · Restricted Project

Apr 27 2020

jankratochvil planned changes to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.
Apr 27 2020, 1:27 PM · Restricted Project
jankratochvil updated the diff for D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

This is only to get an idea what I am preparing, not for detailed reading. Maybe it should be split even more? It contains both main_unit addition to callbacks:

 void DebugNamesDWARFIndex::GetGlobalVariables(
-    const DWARFUnit &cu, llvm::function_ref<bool(DWARFDIE die)> callback) {
+    const DWARFUnit &cu,
+    llvm::function_ref<bool(DWARFCompileUnit *main_unit, DWARFDIE die)>
+        callback) {

and also data structure extensions like:

-  typedef llvm::DenseMap<const DWARFDebugInfoEntry *, lldb_private::Type *>
+  typedef llvm::DenseMap<
+      std::pair<DWARFCompileUnit *, const DWARFDebugInfoEntry *>,
+      lldb_private::Type *>
       DIEToTypePtr;
...
-  dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
+  dwarf->GetDIEToType()[die.MainCUtoDIEPair(main_unit)] = type_sp.get();

With some needed infrastructure for MainCUtoDIEPair & co.

Apr 27 2020, 1:27 PM · Restricted Project

Apr 24 2020

jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

@labath now with existing callbacks

llvm::function_ref<bool(DWARFDIE die)> callback

I am going to add DWARFCompileUnit *main_unit somewhere. BTW it can be nullptr, for example for DIES from type units. In my WIP patches I was putting it in front (as main_unit sort of contains the die):

llvm::function_ref<bool(DWARFCompileUnit *main_unit, DWARFDIE die)> callback

or do you prefer it added at the end?

llvm::function_ref<bool(DWARFDIE die, DWARFCompileUnit *main_unit)> callback

This applies also to API like:

clang::BlockDecl *DWARFASTParserClang::ResolveBlockDIE(DWARFCompileUnit *main_unit, const DWARFDIE &die) {

vs..

clang::BlockDecl *DWARFASTParserClang::ResolveBlockDIE(const DWARFDIE &die, DWARFCompileUnit *main_unit) {

I want to prevent using default parameters:

clang::BlockDecl *DWARFASTParserClang::ResolveBlockDIE(const DWARFDIE &die, DWARFCompileUnit *main_unit = nullptr) {

as that would easily lead to forgetting to delegate main_unit which would only be discovered during DWZ tests (and only if they test such specific API function).

Apr 24 2020, 5:54 AM · Restricted Project

Apr 22 2020

jankratochvil committed rGd482fe2add95: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE (authored by jankratochvil).
[nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE
Apr 22 2020, 8:39 AM
jankratochvil closed D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 22 2020, 8:39 AM · Restricted Project
jankratochvil added a comment to D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.

Thanks for the review and I have learned a new use case for llvm::function_ref.

Apr 22 2020, 8:38 AM · Restricted Project

Apr 21 2020

jankratochvil added a comment to D75750: [lldb] integrate debuginfod.

The current plan discussed with @kwk is to create the new SymbolServer abstract superclass and some its inherited implementation and move there the appropriate parts of existing lldb/source/Symbol/LocateSymbolFile.cpp. Current SymbolVendor implementations would then iterate new SymbolServers by the existing LocateExecutableSymbolFile function. That may be enough for a patch of its own.

I'll have to see the actual patch for a definitive opinion, but I have to say that a priori I am sceptical of this direction. And yes, that should definitely be a separate patch.

Apr 21 2020, 1:35 AM · Restricted Project
jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 21 2020, 1:35 AM · Restricted Project
jankratochvil added inline comments to D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 21 2020, 1:35 AM · Restricted Project
jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 21 2020, 1:35 AM · Restricted Project

Apr 18 2020

jankratochvil added inline comments to D78421: Fix out of sync source code/executable when debugging.
Apr 18 2020, 4:50 AM · Restricted Project
jankratochvil added a comment to rGacb0b99c8e4f: [lldb][NFC] Modernize lang/cpp/scope test.

I have fixed it up by rG239093f30c34, the original testcase was not dependent on variables order.

Apr 18 2020, 2:40 AM
jankratochvil committed rG239093f30c34: [lldb] [testsuite] Fix a regression of TestCppScope.py (authored by jankratochvil).
[lldb] [testsuite] Fix a regression of TestCppScope.py
Apr 18 2020, 2:08 AM

Apr 17 2020

jankratochvil committed rGeef9cb162889: [lldb] [testsuite] Fix TestFixIts.py on Linux (authored by jankratochvil).
[lldb] [testsuite] Fix TestFixIts.py on Linux
Apr 17 2020, 11:58 PM
jankratochvil added a comment to D75750: [lldb] integrate debuginfod.

The current plan discussed with @kwk is to create the new SymbolServer abstract superclass and some its inherited implementation and move there the appropriate parts of existing lldb/source/Symbol/LocateSymbolFile.cpp. Current SymbolVendor implementations would then iterate new SymbolServers by the existing LocateExecutableSymbolFile function. That may be enough for a patch of its own.

Apr 17 2020, 6:27 AM · Restricted Project

Apr 15 2020

jankratochvil accepted D78242: [lldb/Docs] Add some more info about the test suite layout.
Apr 15 2020, 4:02 PM · Restricted Project
jankratochvil added inline comments to D78242: [lldb/Docs] Add some more info about the test suite layout.
Apr 15 2020, 4:01 PM · Restricted Project
jankratochvil committed rG5e04b5f2fa84: [nfc] [lldb] Introduce DWARF callbacks (fixed-up) (authored by jankratochvil).
[nfc] [lldb] Introduce DWARF callbacks (fixed-up)
Apr 15 2020, 2:56 PM
jankratochvil closed D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 2:56 PM · Restricted Project
jankratochvil added inline comments to D78242: [lldb/Docs] Add some more info about the test suite layout.
Apr 15 2020, 2:55 PM · Restricted Project
jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 1:46 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 1:46 PM · Restricted Project
jankratochvil planned changes to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 7:04 AM · Restricted Project
jankratochvil reopened D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

I had to revert it: rG9289f34390da
It has caused a regression: lang/cpp/accelerator-table/TestCPPAccelerator.py

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/15323/consoleFull
Apr 15 2020, 7:04 AM · Restricted Project
jankratochvil committed rG9289f34390da: Revert "[nfc] [lldb] Introduce DWARF callbacks" (authored by jankratochvil).
Revert "[nfc] [lldb] Introduce DWARF callbacks"
Apr 15 2020, 6:34 AM
jankratochvil added a reverting change for rGbd47c470d13b: [nfc] [lldb] Introduce DWARF callbacks: rG9289f34390da: Revert "[nfc] [lldb] Introduce DWARF callbacks".
Apr 15 2020, 6:33 AM
jankratochvil committed rGbd47c470d13b: [nfc] [lldb] Introduce DWARF callbacks (authored by jankratochvil).
[nfc] [lldb] Introduce DWARF callbacks
Apr 15 2020, 2:09 AM
jankratochvil closed D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 2:08 AM · Restricted Project

Apr 14 2020

jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 14 2020, 10:11 AM · Restricted Project
jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 14 2020, 10:10 AM · Restricted Project
jankratochvil added a comment to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

The normal semantics of callbacks like these is to return true when one wants to continue iterating

Apr 14 2020, 10:10 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 14 2020, 10:10 AM · Restricted Project

Apr 13 2020

jankratochvil added a child revision for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks: D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 13 2020, 12:25 PM · Restricted Project
jankratochvil added a parent revision for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE: D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 13 2020, 12:25 PM · Restricted Project

Apr 12 2020

jankratochvil added inline comments to D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 12 2020, 4:15 AM · Restricted Project
jankratochvil created D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 12 2020, 3:43 AM · Restricted Project
jankratochvil retitled D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks from [nfc] [lldb] 2/2: Introduce DWARF callbacks to 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 12 2020, 3:43 AM · Restricted Project

Apr 9 2020

jankratochvil committed rG8fbac4e1a2f2: [nfc] [lldb] Unindent code (authored by jankratochvil).
[nfc] [lldb] Unindent code
Apr 9 2020, 1:15 PM
jankratochvil closed D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 9 2020, 1:15 PM · Restricted Project
jankratochvil added a comment to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

The bool return value on all of these methods, is that here just to implement the fallback mechanism in DebugNamesDWARFIndex?

Apr 9 2020, 5:55 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 9 2020, 5:55 AM · Restricted Project

Apr 8 2020

jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 8 2020, 1:35 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 8 2020, 1:35 AM · Restricted Project

Apr 7 2020

jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

Having a iterator/callback based api would allow us to minimize the impact of that, as it would only need to happen for the entries that are really used. And /I think/ we could make it interface returns DWARFDies directly, and each index converts to that using the most direct approach available.

Apr 7 2020, 2:43 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 7 2020, 2:43 PM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 7 2020, 2:43 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 7 2020, 2:43 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.

Implemented all the review comments.

Apr 7 2020, 2:10 PM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 7 2020, 2:10 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 7 2020, 12:31 PM · Restricted Project
jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 7 2020, 12:31 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 7 2020, 11:56 AM · Restricted Project
jankratochvil added a comment to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

I can't say I have tried this, but ummm.. why is there a need for a separate iterator class for this equal_range stuff? Couldn't this be implemented via an iterator_pair of the iterators of the underlying container (found via lower/upper_bound) ?

Apr 7 2020, 9:12 AM · Restricted Project
jankratochvil planned changes to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 7 2020, 9:12 AM · Restricted Project

Apr 6 2020

jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 6 2020, 1:37 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 6 2020, 1:37 PM · Restricted Project
jankratochvil planned changes to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 6 2020, 11:25 AM · Restricted Project
jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 6 2020, 8:06 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 6 2020, 8:06 AM · Restricted Project

Apr 4 2020

jankratochvil accepted D77376: [lldb][nfc] remove overriden funcs with default impl.

LGTM, thanks for the cleanup.

Apr 4 2020, 9:00 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 4 2020, 1:25 AM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 4 2020, 1:25 AM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 4 2020, 1:25 AM · Restricted Project

Apr 3 2020

jankratochvil committed rGfcab66d5fe53: [lldb] Findtypes -gmodules fix for too many matches (authored by jankratochvil).
[lldb] Findtypes -gmodules fix for too many matches
Apr 3 2020, 3:44 PM
jankratochvil closed D77336: Findtypes -gmodules fix.
Apr 3 2020, 3:43 PM · Restricted Project
jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 3 2020, 3:43 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 3 2020, 3:43 PM · Restricted Project
jankratochvil updated the summary of D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 3 2020, 1:33 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 3 2020, 1:33 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.

I have checked in the really obvious parts as rG80237523193d.
The remainder is left here - although I do not see there more problematic parts now.

Apr 3 2020, 1:33 PM · Restricted Project
jankratochvil committed rG80237523193d: [nfc] [lldb] Unindent code - obvious part (authored by jankratochvil).
[nfc] [lldb] Unindent code - obvious part
Apr 3 2020, 1:01 PM
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 3 2020, 11:55 AM · Restricted Project
jankratochvil added inline comments to D77376: [lldb][nfc] remove overriden funcs with default impl.
Apr 3 2020, 6:24 AM · Restricted Project
jankratochvil accepted D77377: [lldb][nfc] early exit/continue.
Apr 3 2020, 5:52 AM · Restricted Project
jankratochvil added a comment to D77336: Findtypes -gmodules fix.
In D77336#1959094, @kwk wrote:

Could you explain, why this was done please?

Apr 3 2020, 2:07 AM · Restricted Project

Apr 2 2020

jankratochvil retitled D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks from [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks to [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Apr 2 2020, 2:38 PM · Restricted Project
jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 2 2020, 2:38 PM · Restricted Project
jankratochvil created D77336: Findtypes -gmodules fix.
Apr 2 2020, 2:38 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 2 2020, 2:06 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 2 2020, 2:06 PM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 2 2020, 2:06 PM · Restricted Project
jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 2 2020, 12:28 PM · Restricted Project
jankratochvil added a parent revision for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks: D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 2 2020, 11:56 AM · Restricted Project
jankratochvil retitled D77326: 1/2: [nfc] [lldb] Unindent code from [nfc] [lldb] Unindent code to 1/2: [nfc] [lldb] Unindent code.
Apr 2 2020, 11:56 AM · Restricted Project
jankratochvil created D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 2 2020, 11:56 AM · Restricted Project
jankratochvil created D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 2 2020, 11:55 AM · Restricted Project