Page MenuHomePhabricator
Feed Advanced Search

Aug 23 2017

bollu updated the diff for D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
  • [Bugfix] add powi to the list of instructions that the NVPTX backend cannot lower.
  • [NFC] remove debug code
Aug 23 2017, 4:47 AM
bollu created D37058: [Polly] [PPCGCodeGeneration] Mild refactoring of checking validity of functions in a kernel..
Aug 23 2017, 4:37 AM
bollu created D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
Aug 23 2017, 3:11 AM

Aug 22 2017

bollu committed rL311471: [GPUJIT] Make max managed pointers an environment variable..
[GPUJIT] Make max managed pointers an environment variable.
Aug 22 2017, 10:33 AM
bollu closed D37012: [GPUJIT] Make max managed pointers an environment variable by committing rL311471: [GPUJIT] Make max managed pointers an environment variable..
Aug 22 2017, 10:33 AM
bollu added inline comments to D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..
Aug 22 2017, 9:36 AM · Restricted Project
bollu added inline comments to D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
Aug 22 2017, 6:46 AM
bollu updated the diff for D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
  • [Diff fix] Upload correct arc diff.
Aug 22 2017, 6:42 AM
bollu added inline comments to D35992: [Polly] [PPCGCodeGeneration] [NFC] [WIP] Add option to fail if a store to a scalar occursin a kernel..
Aug 22 2017, 6:40 AM
bollu created D37012: [GPUJIT] Make max managed pointers an environment variable.
Aug 22 2017, 6:37 AM
bollu updated the diff for D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
  • Use LegacyInlinerBase as the starting point for our inliner pass.
  • Cache inlining results because polyhedral analysis is expensive.
Aug 22 2017, 6:31 AM
bollu committed rL311440: [ManagedMemoryRewrite] Use `unit64_t` to store size, not `int`..
[ManagedMemoryRewrite] Use `unit64_t` to store size, not `int`.
Aug 22 2017, 2:31 AM
bollu committed rL311439: [ManagedMemoryRewrite] Get size in bytes rather than in bits and dividing by 8..
[ManagedMemoryRewrite] Get size in bytes rather than in bits and dividing by 8.
Aug 22 2017, 2:28 AM

Aug 21 2017

bollu committed rL311361: [ManagedMemoryRewrite] slightly tweak debug output style. [NFC].
[ManagedMemoryRewrite] slightly tweak debug output style. [NFC]
Aug 21 2017, 11:59 AM
bollu committed rL311360: [ManagedMemoryRewrite] Print reasons for skipping global array to dbgs(). [NFC].
[ManagedMemoryRewrite] Print reasons for skipping global array to dbgs(). [NFC]
Aug 21 2017, 11:53 AM
bollu committed rL311331: [ManagedMemoryRewrite] hide debug output behing DEBUG(...). [NFC].
[ManagedMemoryRewrite] hide debug output behing DEBUG(...). [NFC]
Aug 21 2017, 5:53 AM
bollu abandoned D35988: [Polly] [WIP] [PPCGCodeGeneration] Failing test case from COSMO.

Test now passes. Probably succeeds due to rL311042

Aug 21 2017, 5:20 AM
bollu abandoned D35486: [Polly] [PPCGCodeGeneration] [WIP] Do not consider writes to killable scalars as scalar stores.

Abandoned because rL311259 contains changes that this patch was supposed to perform.

Aug 21 2017, 5:15 AM
bollu committed rL311329: [ScopInfo] Add option to treat all function parameters as dereferencible..
[ScopInfo] Add option to treat all function parameters as dereferencible.
Aug 21 2017, 4:58 AM
bollu closed D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable by committing rL311329: [ScopInfo] Add option to treat all function parameters as dereferencible..
Aug 21 2017, 4:58 AM
bollu updated the diff for D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.
  • [NFC] fix whitespace and debug print (Fix screwed up diff due to rebase).
Aug 21 2017, 4:51 AM
bollu updated the diff for D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.
  • [NFC] fix whitespace and debug print
Aug 21 2017, 4:49 AM
bollu committed rL311328: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..
[PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen.
Aug 21 2017, 4:45 AM
bollu closed D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen. by committing rL311328: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..
Aug 21 2017, 4:45 AM
bollu added a comment to D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..

@annanay25 - I believe that was changed by people upstream due to the PostDomTree changes. (specifically, D35851).

Aug 21 2017, 4:43 AM
bollu added a comment to D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.

@grosser - review please.

Aug 21 2017, 4:32 AM
bollu updated the diff for D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.
  • Update code and add test case.
Aug 21 2017, 4:32 AM
bollu added a comment to D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..

@grosser @philip.pfaffe @Meinersbur @singam-sanjay ping, review please.

Aug 21 2017, 2:28 AM

Aug 20 2017

bollu added a comment to D36939: [Polly] Codegen for simple full function Scops.

Thanks a lot for the patch! I have some stylistic comments to make. However, I do not understand the related codebase well enough, so I'll leave that for the others :).

Aug 20 2017, 4:26 PM
bollu created D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..
Aug 20 2017, 8:11 AM
bollu committed rL311289: [GPUJIT] Switch from Runtime API calls for managed memory to Driver API calls..
[GPUJIT] Switch from Runtime API calls for managed memory to Driver API calls.
Aug 20 2017, 6:39 AM
bollu closed D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls. by committing rL311289: [GPUJIT] Switch from Runtime API calls for managed memory to Driver API calls..
Aug 20 2017, 6:39 AM
bollu retitled D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls. from [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls. [NFC] to [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls..
Aug 20 2017, 6:34 AM

Aug 19 2017

bollu committed rL311261: [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not….
[ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not…
Aug 19 2017, 1:53 PM
bollu closed D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself. by committing rL311261: [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not….
Aug 19 2017, 1:53 PM
bollu accepted D36929: [GPGPU] Correctly initialize array order and fixed_element information.

Please add the comment I requested for cc->isLatestScalarKind() ? isl_bool_true : isl_bool_false; and the test cases. LGTM.

Aug 19 2017, 1:18 PM · Restricted Project
bollu requested changes to D36929: [GPGPU] Correctly initialize array order and fixed_element information.

It's cool that invariant-load-hoisting-with-failing-scop.ll now succeeds, but that's not the purpose of the test case :)

Aug 19 2017, 12:45 PM · Restricted Project
bollu updated the diff for D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
  • [NFC] reorder statements
Aug 19 2017, 11:01 AM
bollu updated the diff for D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
  • [NFC] remove empty line
Aug 19 2017, 11:00 AM
bollu updated the diff for D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
  • Don't call DeleteValue on the ConstantExpr because there can be multiple use sites
Aug 19 2017, 10:46 AM
bollu updated the diff for D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
  • Invalidate Cur by deleting it and setting it to nullptr
Aug 19 2017, 10:42 AM
bollu added inline comments to D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
Aug 19 2017, 10:42 AM
bollu retitled D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself. from [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself [NFC] to [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
Aug 19 2017, 9:17 AM
bollu created D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
Aug 19 2017, 9:12 AM
bollu updated the diff for D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls..
  • [NFC] remove blank line
Aug 19 2017, 8:20 AM
bollu added a comment to D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls..

@PhilippSchaad - Can you confirm that this now allows you to link on a machine without CUDA? Sorry for letting this slip by, I mixed up the runtime/driver APIs.

Aug 19 2017, 8:20 AM
bollu added a reviewer for D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls.: PhilippSchaad.
Aug 19 2017, 8:19 AM
bollu created D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls..
Aug 19 2017, 8:18 AM
bollu accepted D36920: [GPGPU] Collect parameter dimension used in MemoryAccesses.

Thanks! Other than nits, LGTM.

Aug 19 2017, 5:54 AM · Restricted Project
bollu requested changes to D36920: [GPGPU] Collect parameter dimension used in MemoryAccesses.

I would like to discuss the isl::space ParamSpace issue before LGTM'ing this patch.

Aug 19 2017, 5:26 AM · Restricted Project

Aug 18 2017

bollu committed rL311158: [Polly] [PPCGCodeGeneration] Print current Scop and loop depth in PPCGCodeGen..
[Polly] [PPCGCodeGeneration] Print current Scop and loop depth in PPCGCodeGen.
Aug 18 2017, 6:19 AM
bollu closed D36871: [Polly] [PPCGCodeGeneration] Print current Scop and loop depth in PPCGCodeGen. [NFC] by committing rL311158: [Polly] [PPCGCodeGeneration] Print current Scop and loop depth in PPCGCodeGen..
Aug 18 2017, 6:19 AM
bollu created D36871: [Polly] [PPCGCodeGeneration] Print current Scop and loop depth in PPCGCodeGen. [NFC].
Aug 18 2017, 5:33 AM
bollu accepted D36867: [GPGPU] Synchronize after each kernel, not each copy out.

Does this patch depend on some other patch? If so, please record this information by creating a Parent Revision. (Edit Related Revisions -> Edit Parent Revision). If some other patch depends on this, then make this a parent of that patch. Helps when looking up revisions later on.

Aug 18 2017, 4:53 AM · Restricted Project
bollu accepted D36869: [GPGPU] Simplify PPCGSCop to reduce compile time [NFC].
Aug 18 2017, 4:51 AM · Restricted Project
bollu accepted D36868: [GPGPU] Do not create copy statements when targetting managed memory.

LGTM

Aug 18 2017, 4:51 AM · Restricted Project
bollu added a comment to D36869: [GPGPU] Simplify PPCGSCop to reduce compile time [NFC].

Other than comments, LGTM :)

Aug 18 2017, 4:45 AM · Restricted Project

Aug 17 2017

bollu created D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
Aug 17 2017, 4:44 PM
bollu committed rL311130: [ScpInliner] Move DEBUG-TYPE to below all includes to prevent cross-module….
[ScpInliner] Move DEBUG-TYPE to below all includes to prevent cross-module…
Aug 17 2017, 3:24 PM
bollu committed rL311126: [ScopInliner] Add a simple Scop-based inliner to polly..
[ScopInliner] Add a simple Scop-based inliner to polly.
Aug 17 2017, 2:58 PM
bollu closed D36832: [Polly] [ScopInliner] Implement basic scop inlining pass. by committing rL311126: [ScopInliner] Add a simple Scop-based inliner to polly..
Aug 17 2017, 2:58 PM
bollu updated the diff for D36832: [Polly] [ScopInliner] Implement basic scop inlining pass..
  • [NFC] remove metadata from tests
Aug 17 2017, 2:43 PM
bollu added inline comments to D36832: [Polly] [ScopInliner] Implement basic scop inlining pass..
Aug 17 2017, 2:22 PM
bollu updated the diff for D36832: [Polly] [ScopInliner] Implement basic scop inlining pass..
  • [Bugfix, Debug] Actually skip declarations and add better debug prints.
Aug 17 2017, 2:22 PM
bollu updated the diff for D36832: [Polly] [ScopInliner] Implement basic scop inlining pass..
  • [NFC] run through check-polly, slightly restructure code.
Aug 17 2017, 1:32 PM
bollu closed D36825: [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well. by committing rL311121: [ManagedMemoryRewrite] Rewrite malloc, free correctly inside `Constant`s..
Aug 17 2017, 1:28 PM
bollu updated the diff for D36825: [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well..
  • [NFC] rename function as what Tobias suggested and add comment explaining why
Aug 17 2017, 1:09 PM
bollu added a comment to D36825: [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well..

@grosser Dont, added tests.

Aug 17 2017, 12:05 PM
bollu updated the diff for D36825: [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well..
  • [NFC] add testcase
Aug 17 2017, 11:57 AM
bollu updated the diff for D36832: [Polly] [ScopInliner] Implement basic scop inlining pass..
  • [NFC] fix style comments, make ScopInliner check that -polly-allow-full-func is enabled
Aug 17 2017, 8:51 AM
bollu created D36832: [Polly] [ScopInliner] Implement basic scop inlining pass..
Aug 17 2017, 8:06 AM
bollu added inline comments to D36825: [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well..
Aug 17 2017, 5:14 AM
bollu created D36825: [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well..
Aug 17 2017, 5:14 AM
bollu retitled D36825: [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well. from [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well. Reuse the machinery built for replacing global arrays to replace malloc/free as well. Example replacement that was missed earlier: ```ll call void... to [Polly] [ManagedMemoryRewrite] Rewrite malloc, free correctly so it works inside bitcasts as well..
Aug 17 2017, 5:14 AM
bollu closed D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd by committing rL311080: [ManagedMemoryRewrite] Learn how to rewrite global arrays, allocas..
Aug 17 2017, 4:23 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [NFC] remove 0 address space because that is the default value.
Aug 17 2017, 3:41 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [NFC] Discuss algorithm with phillip offline, he helped to simplify it further.
  • [Linkage] Update linkage code to use the correct linker options as well as the ignore linkage flag. Update test case to match this change
  • [ReplaceUsesOfWith] remove double-loop that was not required.
Aug 17 2017, 2:34 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [Merge] Merged with master, hoping that GPUJIT does not show up from arc diff this time.
Aug 17 2017, 1:36 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [Re-upload] diff against the newest HEAD.
Aug 17 2017, 1:32 AM
bollu added a comment to D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.

@philip.pfaffe Another round of review, please?

Aug 17 2017, 1:29 AM
bollu added inline comments to D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
Aug 17 2017, 1:28 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [Bugfix] Send bytes, not bits. Also, move the alloca function extraction to the correct place.
Aug 17 2017, 1:28 AM

Aug 16 2017

bollu accepted D36800: Add rewrite by-reference parameter pass.

Nit: Consider using IRBuilder? Not sure if this is needed, but maybe it avoids the extra parameter. YMMV. Other than that LGTM.

Aug 16 2017, 3:36 PM · Restricted Project
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [NFC] Rewrite based on Phillip & Tobias' comments
Aug 16 2017, 8:25 AM

Aug 15 2017

bollu committed rL310941: [Polly] [GPUJIT] Set min size to 1 on CUDA allocation calls. [NFC].
[Polly] [GPUJIT] Set min size to 1 on CUDA allocation calls. [NFC]
Aug 15 2017, 11:24 AM
bollu closed D36751: [Polly] [GPUJIT] Set min size to 1 on allocation calls. by committing rL310941: [Polly] [GPUJIT] Set min size to 1 on CUDA allocation calls. [NFC].
Aug 15 2017, 11:24 AM
bollu updated the diff for D36751: [Polly] [GPUJIT] Set min size to 1 on allocation calls..
  • [NFC] remove TODO with actual code
Aug 15 2017, 11:05 AM
bollu added a comment to D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.

@Meinersbur - Second round of review, please :)

Aug 15 2017, 10:15 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [NFC] undo all changes to GPUJIT.
Aug 15 2017, 10:15 AM
bollu added a comment to D36751: [Polly] [GPUJIT] Set min size to 1 on allocation calls..

@singam-sanjay Review please.

Aug 15 2017, 10:13 AM
bollu updated the diff for D36751: [Polly] [GPUJIT] Set min size to 1 on allocation calls..
  • [NFC] document why we care about size 0 allocs
Aug 15 2017, 10:13 AM
bollu created D36751: [Polly] [GPUJIT] Set min size to 1 on allocation calls..
Aug 15 2017, 9:31 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [WIP] Update according to Michael's comments.
Aug 15 2017, 4:11 AM
bollu added inline comments to D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
Aug 15 2017, 2:02 AM

Aug 13 2017

bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [UNDEBUG] remove debug printing in GPUJIT
  • [NFC] check polly and fix test case to reduce size by x100
Aug 13 2017, 2:17 PM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [Code dump] Dump of all changes that now allow global arrays to be rewritten

correctly.

Aug 13 2017, 1:09 PM

Aug 11 2017

bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [WIP] version now works on test code, going to run it on COSMO to detect bugs in implementation.
Aug 11 2017, 5:12 AM

Aug 10 2017

bollu added a comment to D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.

Example of changes induced by this patch on a .ll file

Aug 10 2017, 3:08 AM
bollu updated the diff for D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.
  • [WIP] not sure why this doesn't work, code seems reasonable
Aug 10 2017, 3:03 AM
bollu added a comment to D36516: [WIP] [Polly] [ManagedMemoryRewrite] Rewrite global arrays with global pointers that are polly_mallocManage'd.

@grosser: could you change your status to "Requesting changes"? That way, you'll see when I push

Aug 10 2017, 1:40 AM